TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap opened issue TapTap/FastSync#50 2026-07-20 17:13:07 +02:00
mkdir_r() has potential buffer overflow in path construction loop
TapTap opened issue TapTap/FastSync#49 2026-07-20 17:12:55 +02:00
chunk_size truncated to int during wire transfer — values > 2GB silently corrupted
TapTap opened issue TapTap/FastSync#48 2026-07-20 17:12:47 +02:00
data_compress() ignores compression_level parameter — always uses zstd default (3)
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:09:16 +02:00
38be7c090a Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46)
TapTap commented on pull request TapTap/FastSync#47 2026-07-20 17:08:11 +02:00
Fix 11 Gitea issues — bugs, quality, security, and refactoring

PR REVIEW SUMMARY

Branch: fix/gitea-issues → main PR #47: "Fix 11 Gitea issues — bugs, quality, security, and refactoring" Files reviewed: 1 C source file (`src/shared/chunk.c…

TapTap deleted branch testing/comprehensive-test-suite from TapTap/FastSync 2026-07-20 17:05:53 +02:00
TapTap pushed to main at TapTap/FastSync 2026-07-20 17:05:46 +02:00
5fe89eb49f Merge pull request 'testing: add comprehensive test suite for test-driven development' (#25) from testing/comprehensive-test-suite into main
3f73012b36 fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope
ed6242cfc5 ci: bump CI image to v9 with libclang-rt-18-dev
a27f13d657 fix: bake CI deps into Docker image, fix chunk use_metadata OOB
eb8651e3d5 fix: address PR review — fuzz target fixes, UBSan, CI improvements
Compare 10 commits »
TapTap merged pull request TapTap/FastSync#25 2026-07-20 17:05:45 +02:00
testing: add comprehensive test suite for test-driven development
TapTap commented on pull request TapTap/FastSync#25 2026-07-20 17:04:47 +02:00
testing: add comprehensive test suite for test-driven development

Re-review: Approve ✅

All previous findings are fixed, CI is green across all jobs, new additions are well-structured.

Verified fixes from delta (952f693..3f73012)

TapTap created pull request TapTap/FastSync#47 2026-07-20 17:03:51 +02:00
Fix 11 Gitea issues — bugs, quality, security, and refactoring
TapTap created branch fix/gitea-issues in TapTap/FastSync 2026-07-20 17:03:37 +02:00
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:03:37 +02:00
TapTap opened issue TapTap/FastSync#46 2026-07-20 14:59:20 +02:00
quality: send_chunk has deeply nested if-else with duplicated file-sending loops
TapTap opened issue TapTap/FastSync#45 2026-07-20 14:59:14 +02:00
security: SSH transport uses fixed-size buffers in parse_remote_dest
TapTap opened issue TapTap/FastSync#44 2026-07-20 14:59:07 +02:00
quality: server_host and server_port are mutable global variables (not thread-safe)
TapTap opened issue TapTap/FastSync#43 2026-07-20 14:59:02 +02:00
bug: delete_extras_walk unconditionally calls rmdir on directories
TapTap opened issue TapTap/FastSync#42 2026-07-20 14:58:55 +02:00
bug: to_disk uses dirname() which may modify its argument (POSIX undefined)
TapTap opened issue TapTap/FastSync#41 2026-07-20 14:58:49 +02:00
bug: file_send_sendfile accepts compression_level parameter but ignores it
TapTap opened issue TapTap/FastSync#40 2026-07-20 14:58:39 +02:00
performance: entire file content loaded into RAM — no streaming for large files
TapTap opened issue TapTap/FastSync#39 2026-07-20 14:58:32 +02:00
quality: no unit tests for transport modules (TCP, SSH, TLS, Protocol)