TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Phase 4: symlink trust (-k/--copy-dirlinks, -K/--keep-dirlinks, --munge-links) #279

Closed
TapTap wants to merge 0 commits from feat/p4-symlink-trust into dev
pull from: feat/p4-symlink-trust
merge into: :dev
Conversation 1 Commits - Files Changed -
TapTap commented 2026-09-08 22:42:16 +02:00
Owner
Copy Link
Copy Source

Real symlink handling: -l now transmits symlink targets (STATUS_SYMLINK frame / chunk type). -k dereferences dir-symlinks; -K follows an in-root dest symlink-to-dir (O_NOFOLLOW realpath-rechecked); --munge-links sender-rewrites targets with #SYMLINK/ and never emits escaping targets; receiver-side symmetric containment rejects absolute/.. targets. munge_links+keep_dirlinks cross the wire; PROTOCOL_VERSION 2.12.0->2.13.0. Verified: unit 28/28, 6 symlink integration, 313 full. c-review fixes applied: receiver-side containment, gated unmunge, -K TOCTOU, keep_dirlinks set at config-accept.

Real symlink handling: -l now transmits symlink targets (STATUS_SYMLINK frame / chunk type). -k dereferences dir-symlinks; -K follows an in-root dest symlink-to-dir (O_NOFOLLOW realpath-rechecked); --munge-links sender-rewrites targets with #SYMLINK/ and never emits escaping targets; receiver-side symmetric containment rejects absolute/.. targets. munge_links+keep_dirlinks cross the wire; PROTOCOL_VERSION 2.12.0->2.13.0. Verified: unit 28/28, 6 symlink integration, 313 full. c-review fixes applied: receiver-side containment, gated unmunge, -K TOCTOU, keep_dirlinks set at config-accept.
TapTap commented 2026-09-08 23:00:09 +02:00
Author
Owner
Copy Link
Copy Source

Merged locally into dev (a4e1f2c). Full suite + CI green (run 90ccf29). Independent c-review addressed; fixes applied.

Merged locally into dev (a4e1f2c). Full suite + CI green (run 90ccf29). Independent c-review addressed; fixes applied.
TapTap closed this pull request 2026-09-08 23:00:09 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#279