 TapTap
|
5c686b0655
|
fix: address PR review — doc accuracy, clang-tidy info, config leak fix
CI / lint (push) Successful in 7s
CI / lint (pull_request) Successful in 7s
CI / build-and-test (push) Successful in 54s
CI / clang-tidy (push) Successful in 6s
CI / sanitizers (address) (push) Successful in 59s
CI / build-and-test (pull_request) Successful in 55s
CI / clang-tidy (pull_request) Successful in 5s
CI / sanitizers (address) (pull_request) Successful in 57s
Review findings addressed:
Critical:
- cmake-expert.md: replace commented-out sanitizer lines with actual
SANITIZER cache variable block, fix ENABLE_ASAN/TSAN/UBSAN pattern
- integrator.md: update YAML example to v7, use -DSANITIZER= instead
of raw flags, add symlink + LSAN suppression steps
Warnings:
- ci.yaml: rename clang-tidy step to 'informational, non-blocking',
add ::warning:: workflow command for visibility
- client_cli.c: add goto cleanup pattern to free config on error paths
(skip for multithreaded path where pipeline_context_sender_destroy
already owns config)
Suggestions:
- test-writer.md: clarify conftest.py is at tests/conftest.py
- .lsan-suppressions.txt: remove config_create suppression (leak fixed)
|
2026-07-20 14:28:42 +02:00 |
|
|
TapTap
|
bd17f50f9b
|
feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI
Agents:
- cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps
- integrator: fix stale test.py references to tests/integration/, update CI docs
- test-writer: update integration test patterns for modular test structure
- reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality)
Bug fixes:
- delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize
- scanner.c: free ArrayList when directory_scanner_next returns NULL
CI:
- Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks
- Add clang-tidy job with proper warning/error detection
- Remove || true masking (fixes now make sanitizer useful)
Cleanup:
- gitignore build-asan/
- .lsan-suppressions.txt for known CLI config leaks
|
2026-07-20 14:22:27 +02:00 |
|