feat: add rsync --old-args compatibility mode #230

Closed
TapTap wants to merge 0 commits from feat/rsync-old-args into dev
Owner

Implements only rsync-compatible --old-args for SSH transport. The default now shell-quotes the configured remote server path; --old-args restores raw legacy command construction for compatibility.

Security limitation: --old-args is an explicit opt-in and permits shell interpretation of the configured remote server path. Server-side authorization, path containment, and protocol protections are unchanged.

Implements only rsync-compatible --old-args for SSH transport. The default now shell-quotes the configured remote server path; --old-args restores raw legacy command construction for compatibility. Security limitation: --old-args is an explicit opt-in and permits shell interpretation of the configured remote server path. Server-side authorization, path containment, and protocol protections are unchanged.
TapTap added 1 commit 2026-09-03 16:27:56 +02:00
feat: add rsync old-args compatibility mode
CI / lint (pull_request) Successful in 11s
CI / sanitizers (address) (pull_request) Successful in 37s
CI / sanitizers (undefined) (pull_request) Successful in 37s
CI / fuzz-build (pull_request) Successful in 15s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 34s
393a440c78
TapTap added 1 commit 2026-09-03 21:34:36 +02:00
fix: propagate SSH child setup failures
CI / lint (pull_request) Successful in 11s
CI / sanitizers (address) (pull_request) Successful in 38s
CI / sanitizers (undefined) (pull_request) Successful in 36s
CI / fuzz-build (pull_request) Successful in 14s
CI / coverage (pull_request) Successful in 32s
CI / build-and-test (pull_request) Successful in 1m15s
CI / valgrind (pull_request) Successful in 33s
ec6160a8b9
Author
Owner

Merged as part of the Phase 1 rsync-compatibility batch. Content was integrated into dev sequentially via local merges with conflict resolution, then pushed to origin/dev (HEAD 48dfd5d). The incremental-skip regression found during integration (nanosecond mtime comparison at default modify-window=0) was fixed in 48dfd5d. Verification: unit tests 25/25, integration 74 passed. Closing this PR since its changes are already in dev; Gitea's merge endpoint is unavailable (2FA).

Merged as part of the Phase 1 rsync-compatibility batch. Content was integrated into `dev` sequentially via local merges with conflict resolution, then pushed to `origin/dev` (HEAD 48dfd5d). The incremental-skip regression found during integration (nanosecond mtime comparison at default modify-window=0) was fixed in 48dfd5d. Verification: unit tests 25/25, integration 74 passed. Closing this PR since its changes are already in `dev`; Gitea's merge endpoint is unavailable (2FA).
TapTap closed this pull request 2026-09-05 10:45:47 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#230