TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

refactor: consolidate transfer infrastructure #222

Closed
TapTap wants to merge 1 commits from docs/rsync-compatible-readme-clean into dev
pull from: docs/rsync-compatible-readme-clean
merge into: :dev
Conversation 1 Commits 1 Files Changed 9
+348 -587
TapTap commented 2026-09-01 21:23:21 +02:00
Owner
Copy Link
Copy Source

Summary

  • centralize synchronous and multithreaded receiver protocol dispatch
  • make Config wire serialization use one authoritative field list
  • share TCP connection setup between TCP and TLS transports
  • replace CMake source globs with explicit source lists and shared target configuration

Verification

  • strict build passed
  • unit tests: 25/25 passed
  • integration tests: 39 passed, 10 skipped, 1 xpassed
## Summary - centralize synchronous and multithreaded receiver protocol dispatch - make Config wire serialization use one authoritative field list - share TCP connection setup between TCP and TLS transports - replace CMake source globs with explicit source lists and shared target configuration ## Verification - strict build passed - unit tests: 25/25 passed - integration tests: 39 passed, 10 skipped, 1 xpassed
TapTap added 1 commit 2026-09-01 21:23:21 +02:00
refactor: consolidate transfer infrastructure
CI / lint (pull_request) Failing after 3s
Details
CI / build-and-test (pull_request) Skipped
Details
CI / sanitizers (address) (pull_request) Skipped
Details
CI / sanitizers (undefined) (pull_request) Skipped
Details
CI / fuzz-build (pull_request) Skipped
Details
CI / coverage (pull_request) Skipped
Details
CI / valgrind (pull_request) Skipped
Details
1aebcfd55d
TapTap closed this pull request 2026-09-06 11:47:16 +02:00
TapTap commented 2026-09-06 11:47:22 +02:00
Author
Owner
Copy Link
Copy Source

Closed without merging — no longer fits current dev. Single commit on a 135-commit-old base (protocol 2.2.0), conflicts in 7/9 files. #217 (unify receiver dispatch) is already implemented on dev via sink-based receiver_process() in src/server/receiver.c (carrying #251 outcomes + #254 byte-budget); the X-macro wire list predates remove_source_files and #252 canonicalization. Re-land #219 (tcp_connect_socket) and #220 (explicit CMake lists) as fresh small changes on modern dev if wanted.

**Closed without merging** — no longer fits current dev. Single commit on a 135-commit-old base (protocol 2.2.0), conflicts in 7/9 files. #217 (unify receiver dispatch) is already implemented on dev via sink-based receiver_process() in src/server/receiver.c (carrying #251 outcomes + #254 byte-budget); the X-macro wire list predates remove_source_files and #252 canonicalization. Re-land #219 (tcp_connect_socket) and #220 (explicit CMake lists) as fresh small changes on modern dev if wanted.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Defect or bug
 enhancement
Feature or improvement
 memory
Memory safety issue
 needs-triage
Needs human review
 performance
Performance issue
 quality
Code quality improvement
 security
Security vulnerability
 threading
Threading or concurrency
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
TapTap
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#222