refactor: split transfer and protocol responsibilities #212

Open

TapTap wants to merge 6 commits from refactor/codebase-structure into dev

pull from: refactor/codebase-structure

merge into: TapTap:dev

TapTap:dev

TapTap:security-fixes

TapTap:docs/rsync-compatible-readme-clean

TapTap:docs/rsync-compatible-readme

TapTap:main

Conversation 0 Commits 6 Files Changed 30

+1353 -1372

TapTap commented 2026-08-15 12:27:35 +02:00

Owner

Copy Link

Copy Source

Summary

• Extract shared server receiver, scanner, transport, file storage, and client validation boundaries
• Reduce duplicated transfer orchestration and configuration serialization
• Add explicit protocol session APIs while preserving wire format and compatibility wrappers
• Expand focused unit coverage and remove direct C-source inclusion from server tests

Verification

• Strict build: passed
• Unit tests: 25 passed
• Integration tests: 39 passed, 10 skipped, 1 xpassed
• AddressSanitizer: passed
• ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL
• cppcheck was unavailable in the local environment

## Summary - Extract shared server receiver, scanner, transport, file storage, and client validation boundaries - Reduce duplicated transfer orchestration and configuration serialization - Add explicit protocol session APIs while preserving wire format and compatibility wrappers - Expand focused unit coverage and remove direct C-source inclusion from server tests ## Verification - Strict build: passed - Unit tests: 25 passed - Integration tests: 39 passed, 10 skipped, 1 xpassed - AddressSanitizer: passed - ThreadSanitizer: builds, but the test process aborts with a sanitizer DEADLYSIGNAL - cppcheck was unavailable in the local environment

TapTap added 1 commit 2026-08-15 12:27:36 +02:00

refactor: split transfer and protocol responsibilities 8cca891b9a

TapTap added 1 commit 2026-08-15 12:30:55 +02:00

fix: satisfy cppcheck const analysis 3b7f97853c

TapTap added 1 commit 2026-08-15 12:34:20 +02:00

fix: link receiver into fuzz targets 298976aefb

TapTap added 1 commit 2026-08-15 12:48:39 +02:00

fix: address PR 212 review issues 09454413d4

TapTap added 1 commit 2026-08-15 13:13:54 +02:00

fix: close remaining PR review gaps 604a14f0be

TapTap added 1 commit 2026-08-15 13:20:56 +02:00

fix: handle pipeline cancellation failures 98f833980d

Some checks are pending

Hide all checks

CI / lint (pull_request) Successful in 30s

Details

CI / sanitizers (address) (pull_request) Successful in 37s

Details

CI / sanitizers (undefined) (pull_request) Successful in 38s

Details

CI / fuzz-build (pull_request) Successful in 16s

Details

CI / coverage (pull_request) Successful in 32s

Details

CI / build-and-test (pull_request) Successful in 1m16s

Details

CI / valgrind (pull_request) Successful in 32s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin refactor/codebase-structure:refactor/codebase-structure

git checkout refactor/codebase-structure

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Defect or bug

enhancement

Feature or improvement

memory

Memory safety issue

needs-triage

Needs human review

performance

Performance issue

quality

Code quality improvement

security

Security vulnerability

threading

Threading or concurrency

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

TapTap

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TapTap/FastSync#212