refactor: extract CLI parser helpers, fix validation bugs #200

Merged

TapTap merged 5 commits from refactor/cli-parser-helpers into dev 2026-08-08 20:02:10 +02:00

Conversation 5 Commits 5 Files Changed 19

+652 -294

5 Commits

Author	SHA1	Message	Date
TapTap	8743d7f522	fix: address PR #200 review issues ... - Fix memory leak in delta_deserialize() on BLOCK_MATCH error path - Fix memory leak on malloc failure for literal data - Add port range validation (1-65535) for -p/--port and --server-port - Restore -V/--version flag with usage text - Use MAX_DATA_PAYLOAD_SIZE consistently (remove local MAX_DATA_SIZE) - Fix integer truncation in config_send/config_receive for delta_block_size - Add log messages for malloc failures - Extract config_set_defaults() helper to eliminate duplication - Add 10 new CLI tests for argument parsing	2026-08-08 20:01:48 +02:00
TapTap	05a74770ca	fix: address PR #200 review issues ... - Restore PROTOCOL_VERSION to a forward-compatible 2.1.0 and document wire format - Add NULL guard to config_delete - Add pipeline cancellation flag and cancellation-aware queue helper - Join running threads before destroying pipeline contexts on creation failure - Fix NULL dereference and memory leaks in manifest/chunk handling - Fix TLS/TCP socket fd leak on connect error paths - Add compression-level range validation (1-22) - Close previous log file before opening a new one - Use getline for unbounded pattern-file lines - Fix thread-unsafe localtime() and add log level bounds check - Fix file_load_data to clean up data on read size mismatch - Add hard ceiling to decompression buffer growth - Fix mkdir_r bounds check and restore glob comments - Add send_str NULL guard and mutex-protect bandwidth limiter - Update AGENTS.md for per-thread io_ssl contract	2026-08-02 09:34:54 +02:00
TapTap	1064ae6c19	fix: address PR review issues in client_cli.c ... - Fix FILE* leak when --log-file specified multiple times - Add strtoull endptr validation for --delta-block/--delta-max - Add range validation (1-22) for -c compression level	2026-08-01 18:42:02 +02:00
TapTap	bf91c5b588	merge: resolve conflict with dev, apply helpers to new options	2026-08-01 18:14:55 +02:00
TapTap	5eaea9d92e	refactor: extract CLI parser helpers, fix validation bugs ... - Add set_string_option(), set_positive_int_option(), set_nonneg_int_option() helpers to eliminate duplicated alloc/free/assign patterns - Replace 14 string-option branches with set_string_option() calls - Replace 7 integer-option branches with set_positive/nonneg_int_option() - Fix --info/--debug: replace atoi() with validated parse - Fix --max-size/--min-size: add strtoull() error checking - Fix --chunk-size: validate input with error message on failure	2026-08-01 18:12:41 +02:00