Add custom opencode agents for FastSync development #16

Merged
TapTap merged 2 commits from add-custom-agents into main 2026-07-17 10:02:04 +02:00
Owner

Add 6 custom opencode agents tailored for the FastSync codebase:

  • c-reviewer: Reviews C code for memory safety, thread safety (C11 mtx/cnd), null checks, buffer overflows, and style conventions.
  • test-writer: Writes unit tests using the custom test framework (EXPECT_* macros), creates test_*.c/h, registers in runner.c.
  • cmake-expert: Manages CMakeLists.txt — adding targets, source files, dependencies, compiler flags, sanitizers.
  • perf-analyst: Analyzes transfer pipeline bottlenecks and suggests concrete optimizations.
  • protocol-designer: Designs/extends wire protocol — status codes, metadata format, chunk serialization.
  • doc-generator: Generates API docs, protocol specs, and usage examples from source.
Add 6 custom opencode agents tailored for the FastSync codebase: - **c-reviewer**: Reviews C code for memory safety, thread safety (C11 mtx/cnd), null checks, buffer overflows, and style conventions. - **test-writer**: Writes unit tests using the custom test framework (EXPECT_* macros), creates test_*.c/h, registers in runner.c. - **cmake-expert**: Manages CMakeLists.txt — adding targets, source files, dependencies, compiler flags, sanitizers. - **perf-analyst**: Analyzes transfer pipeline bottlenecks and suggests concrete optimizations. - **protocol-designer**: Designs/extends wire protocol — status codes, metadata format, chunk serialization. - **doc-generator**: Generates API docs, protocol specs, and usage examples from source.
TapTap added 1 commit 2026-07-16 17:01:37 +02:00
- c-reviewer: memory/thread safety, style review for C11 code
- test-writer: unit test generation using custom test framework
- cmake-expert: CMake build system management
- perf-analyst: transfer pipeline performance analysis
- protocol-designer: wire protocol design and extension
- doc-generator: API docs, protocol specs, usage examples
TapTap added 1 commit 2026-07-16 17:07:45 +02:00
- pr-review: read-only code review of PR branches, outputs findings report
- pr-build: builds, tests, and fixes PR branches, commits fixes
Author
Owner

PR Review Summary

Verdict: PASS — No issues found

Files reviewed: 8 (6 agent definitions + 2 skill definitions)


Assessment

All files are well-structured, internally consistent, and follow OpenCode conventions properly.

Frontmatter consistency:

  • Agents (c-reviewer, cmake-expert, doc-generator, perf-analyst, protocol-designer, test-writer): all correctly use description + mode: subagent
  • Skills (pr-build, pr-review): both correctly use name + description

Cross-file consistency:

  • Project structure references (src/shared/, src/client/, src/server/, tests/) consistent across all agents
  • Build commands consistent: cmake -B build -S . && cmake --build build -j$(nproc) appears in cmake-expert, test-writer, and pr-build
  • Review criteria in c-reviewer.md align with pr-review/SKILL.md
  • All agents reference the same key data types (Data, Queue, Config, etc.) and C11 threading primitives

Content quality: All files are complete with clear instructions, appropriate detail levels, and sensible tool lists. test-writer.md is appropriately the most detailed given it produces runnable code.

Safe to merge.

## PR Review Summary **Verdict: PASS** — No issues found **Files reviewed:** 8 (6 agent definitions + 2 skill definitions) --- ### Assessment All files are well-structured, internally consistent, and follow OpenCode conventions properly. **Frontmatter consistency:** - Agents (`c-reviewer`, `cmake-expert`, `doc-generator`, `perf-analyst`, `protocol-designer`, `test-writer`): all correctly use `description` + `mode: subagent` - Skills (`pr-build`, `pr-review`): both correctly use `name` + `description` **Cross-file consistency:** - Project structure references (`src/shared/`, `src/client/`, `src/server/`, `tests/`) consistent across all agents - Build commands consistent: `cmake -B build -S . && cmake --build build -j$(nproc)` appears in `cmake-expert`, `test-writer`, and `pr-build` - Review criteria in `c-reviewer.md` align with `pr-review/SKILL.md` - All agents reference the same key data types (`Data`, `Queue`, `Config`, etc.) and C11 threading primitives **Content quality:** All files are complete with clear instructions, appropriate detail levels, and sensible tool lists. `test-writer.md` is appropriately the most detailed given it produces runnable code. Safe to merge.
TapTap merged commit e2dac589a8 into main 2026-07-17 10:02:04 +02:00
TapTap deleted branch add-custom-agents 2026-07-17 10:02:07 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#16