fix: const qualifier for scanner root_directory parameter

.gitignore

@@ -5,6 +5,4 @@ __pycache__/
 build-asan
 coverage.info
 build-*/
-build2/
 build3/
-build_docker2/

AGENTS.md

@@ -60,153 +60,15 @@ python3 -m pytest tests/     # integration tests
 
 When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.
 
-## CI Troubleshooting
-
-### If lint (clang-format) fails
-Run clang-format in the CI Docker image to match the exact CI version:
-```bash
-docker run --rm -v "$PWD:/workspace" -w /workspace gitea.tap-tap.win/taptap/fastsync-ci:v9 \
-  sh -c 'find src/ tests/ -name "*.c" -o -name "*.h" | xargs clang-format -i'
-```
-
-### If cppcheck fails
-Fix reported issues locally, then verify with:
-```bash
-docker run --rm -v "$PWD:/workspace" -w /workspace gitea.tap-tap.win/taptap/fastsync-ci:v9 \
-  sh -c 'cppcheck --enable=warning,style,performance,portability --suppress=missingIncludeSystem --error-exitcode=1 --inline-suppr src/ tests/'
-```
-
-### If integration tests fail
-Run locally before pushing:
-```bash
-python3 -m pytest tests/ -v --tb=short
-```
-
 ## Branch Strategy
 
-Two main branches: `dev` (integration) and `main` (stable releases).
-
-### Rules
-- **All PRs target `dev`** — never target `main` directly
-- **`dev` is the default branch** in Gitea repo settings
-- **`main` is protected** — only merged from `dev` via PR with 2 approvals + full CI pass
-- **Feature/bug branches** branch from `dev`, PR back to `dev`
-- **`dev` → `main` merges** happen on-demand or weekly, requiring full CI + review
-
+Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch before making changes:
 ```bash
-# Start a new feature
-git checkout dev && git pull
-git checkout -b feat/my-feature
-# ... work, commit, push
-git push -u origin feat/my-feature
-# Create PR targeting dev
+git checkout -b <feature-branch-name>
 ```
-
-### Creating the `dev` branch (one-time setup)
+After committing changes, push the branch and create a PR:
 ```bash
-git checkout main && git pull
-git checkout -b dev
-git push origin dev
-# Then in Gitea: Settings → Repository → Default Branch → dev
+git push -u origin <feature-branch-name>
+gh pr create --fill
 ```
-
-### Branch protection (Gitea repo settings)
-**For `dev`:**
-- ✅ Require PR for merging
-- ✅ Require 1 approval
-- ✅ Require status checks (all CI jobs must pass)
-- ✅ Delete branch after merge
-
-**For `main`:**
-- ✅ Require PR from `dev` only
-- ✅ Require CI
-- ✅ Require 2 approvals
-- ✅ No direct pushes
-
-## Automated Agent Workflows
-
-All agents run locally via the opencode CLI. There is no CI-based agent automation — agents are invoked on-demand by the developer or by this assistant.
-
-### One-command batch workflow
-
-For fixing a set of issues and creating one integration PR:
-
-```bash
-# 1. Run each subagent on its category
-opencode run --agent security-auditor "Fix all open security issues"
-opencode run --agent debugger "Fix all open bugs"
-opencode run --agent test-writer "Add missing test coverage"
-
-# 2. The assistant handles: merging branches, fixing CI failures,
-#    pushing, creating the integration PR, waiting for CI, iterating.
-#    The developer only reviews the final PR.
-```
-
-### Issue triage loop
-When you want to fix a batch of issues autonomously:
-
-1. Tell the assistant: *"Fix all open issues and create one big PR"*
-2. The assistant delegates to subagents in parallel
-3. Merges their branches, handles CI failures iteratively
-4. Pushes and opens the final PR
-5. You review the PR once CI passes — no intermediate check-ins
-
-### Scheduling
-For periodic maintenance (security audits, code quality scans), run:
-
-```bash
-opencode run --agent security-auditor "Audit the codebase for vulnerabilities"
-opencode run --agent code-quality-guardian "Scan for code quality issues"
-```
-
-This can be cron'd locally if desired (e.g., `crontab -e` with `opencode run`).
-
-## Is opencode a good option?
-
-**Yes, for FastSync's needs.** The hybrid model works well:
-- opencode's 17 specialized agents handle deep code analysis, fixes, tests, and reviews
-- The assistant orchestrates subagents, merges branches, and iterates on CI
-- You only review the final output
-
-The key limitation: opencode is session-based, not a persistent daemon. But for the "fix all issues, one PR" workflow, this is fine — the assistant runs the full pipeline in one shot. Persistent webhook-driven automation isn't available for Gitea, but the one-shot batch approach is simpler and gives you full control over what gets merged.
-
-### Recommendations for this project
-- **Do** use the batch pattern: delegate to subagents, let the assistant merge + iterate CI, review once
-- **Don't** try to run opencode in Gitea Actions — the CI container doesn't have your LLM keys or the interactive context agents need
-- **If** you want fully hands-off periodic scans, set up a local cron job or systemd timer that runs `opencode run` and posts results to Gitea via API
-
-## Gitea API & tea CLI
-
-### Check CI status via API
-```bash
-TOKEN="<token>"
-curl -s -H "Authorization: token $TOKEN" \
-  "https://gitea.tap-tap.win/api/v1/repos/TapTap/FastSync/actions/runs?limit=5" \
-  | python3 -c "
-import json,sys; d=json.load(sys.stdin)
-for r in d.get('workflow_runs',[]):
-    path = r.get('path','')
-    prn = path.split('@')[1].replace('refs/pull/','').replace('/head','') if '@' in path else ''
-    print(f'PR #{prn}: sha={r[\"head_sha\"][:8]} {r[\"status\"]} {r.get(\"conclusion\",\"\")}')
-"
-```
-
-### Post review comments
-```bash
-curl -s -X POST -H "Authorization: token $TOKEN" -H "Content-Type: application/json" \
-  -d '{"body":"MARKDOWN_REVIEW_BODY"}' \
-  "https://gitea.tap-tap.win/api/v1/repos/TapTap/FastSync/issues/<PR_NUMBER>/comments"
-```
-
-### Use tea for PR operations
-```bash
-tea pr list --repo TapTap/FastSync
-tea pr close <number> --repo TapTap/FastSync
-```
-
-## Common pitfalls
-
-- **`__thread` on shared SSL context**: io_ssl must NOT be thread-local — worker threads inherit the SSL context from the main thread. Use regular `static SSL* io_ssl`.
-- **SSL WANT_READ/WANT_WRITE retry**: Always retry on `SSL_ERROR_WANT_READ` and `SSL_ERROR_WANT_WRITE` in `send_n_data`/`receive_n_data`. Removing these breaks TLS multithreaded transfers.
-- **clang-format version**: The CI image uses clang-format 18. Always format inside the CI Docker container for exact match.
-- **Merge order matters**: Merge the most comprehensive branch first, then smaller ones, to minimize conflicts when creating a combined branch.
+Wait for CI to pass on the PR before merging.

README.md

@@ -5,26 +5,17 @@ A high-performance file synchronization system with SSH and TCP transport, TLS e
 ## Technical Overview
 
 1. **Dual transport**: custom TCP client-server or SSH subprocess (rsync-style `user@host:/path`)
-2. **TLS encryption**: OpenSSL-based TLS 1.2+ for encrypted TCP connections with optional CA verification
+2. **TLS encryption**: OpenSSL-based TLS 1.2+ for encrypted TCP connections
 3. **Chunked file transfer**: files grouped into configurable-size chunks (default ~10 MB)
 4. **Streaming zstd compression** (levels 1–22) using `ZSTD_compressStream2`
 5. **Multithreading**: producer-consumer pipeline with thread-safe queues (scanner → loader → sender)
 6. **Incremental sync**: skip files unchanged since last transfer (compares size + mtime)
-7. **Batch incremental**: send incremental checks in batched groups for reduced round-trips
-8. **Metadata preservation**: `mode`, `uid`, `gid`, `mtime` restored on disk when enabled
-9. **`sendfile()` zero-copy** on TCP (~2× faster on loopback)
-10. **SSH ControlMaster** for connection reuse across repeated invocations
-11. **Bandwidth limiting**: token-bucket throttling (`--bwlimit`)
-12. **`--delete`**: receiver removes files not present in sender manifest
-13. **`--exclude` / `--include`**: glob-pattern filename filtering
-14. **Path traversal protection**: `..` sequences in file paths are rejected automatically
-15. **Connection limits**: server enforces maximum concurrent connections (default 100)
-16. **Keep-alive**: periodic `STATUS_KEEPALIVE` messages detect stalled connections
-17. **Abort handling**: `SIGINT` sends `STATUS_ABORT` for clean server-side teardown
-18. **Atomic writes**: received files are written to a temporary name then atomically renamed
-19. **Backup mode**: `--backup` preserves overwritten files with optional `--backup-dir`
-20. **Log file**: `--log-file` redirects log output to a file instead of stderr
-21. **Transfer statistics**: `--stats` prints summary of transferred bytes, files, and timing
+7. **Metadata preservation**: `mode`, `uid`, `gid`, `mtime` restored on disk when enabled
+8. **`sendfile()` zero-copy** on TCP (~2× faster on loopback)
+9. **SSH ControlMaster** for connection reuse across repeated invocations
+10. **Bandwidth limiting**: token-bucket throttling (`--bwlimit`)
+11. **`--delete`**: receiver removes files not present in sender manifest
+12. **`--exclude` / `--include`**: glob-pattern filename filtering
 
 ## System Architecture
 
@@ -34,33 +25,20 @@ A high-performance file synchronization system with SSH and TCP transport, TLS e
 - Streaming zstd compression with configurable level
 - Chunk serialization (compact binary format) or per-file transfer
 - Incremental transfer: sends file metadata to server, skips unchanged files
-- Batch incremental: groups incremental checks to minimize round-trips
 - Manifests all sent paths when `--delete` is active
 - Sends via TCP `sendfile()` or SSH pipe
 - Optional progress display with throughput
 - Bandwidth limiting via token-bucket algorithm
-- Configurable I/O and connection timeouts (`--timeout`, `--contimeout`)
-- Quiet mode (`-q`/`--quiet`) suppresses all non-error output
-- Backup overwritten files (`--backup`) with optional directory (`--backup-dir`)
-- Transfer statistics summary (`--stats`)
-- Maximum directory depth control (`--max-depth`)
-- Log file output (`--log-file`)
-- Configurable multithreaded queue size (`--queue-size`)
-- Exclude patterns from file (`--exclude-from`)
 
 ### Server
 - TCP mode: listens on configurable port (default 8080); SSH mode: runs via `--stdio`
-- TLS mode: wraps TCP connections with OpenSSL with optional CA verification
+- TLS mode: wraps TCP connections with OpenSSL
 - Receives and reassembles files
 - Decompresses (streaming zstd), deserializes, restores metadata
 - Handles incremental checks: compares size + mtime against destination files
-- Handles batch incremental checks for reduced round-trips
 - Processes `STATUS_MANIFEST` for `--delete`: walks destination tree, removes extras
-- Per-connection concurrency via `fork()` with configurable connection limit (default 100)
+- Per-connection concurrency via `fork()`
 - Thread pool for parallel processing
-- Atomic writes: files written to `.tmp` path then atomically renamed on success
-- Abort handling: cleanly shuts down on `STATUS_ABORT` from client
-- Path traversal protection: rejects file paths containing `..`
 
 ## Protocol Details
 
@@ -74,11 +52,6 @@ A high-performance file synchronization system with SSH and TCP transport, TLS e
 | `STATUS_CHUNK` | Following data is a serialized chunk |
 | `STATUS_MANIFEST` | Following data is a file manifest (for `--delete`) |
 | `STATUS_CHECK` | Incremental check: client sends file path + size + mtime, server responds with OK (skip) or NEXT (send) |
-| `STATUS_CHECK_BATCH` | Batch incremental check: multiple file checks sent in one message |
-| `STATUS_KEEPALIVE` | Keep-alive heartbeat to detect stalled connections |
-| `STATUS_ABORT` | Abort signal: client interrupts, server cleans up and exits |
-| `STATUS_DELTA_SIGNATURE` | Delta sync: following data is a file signature (rsync-style rolling hash) |
-| `STATUS_DELTA_DATA` | Delta sync: following data is a delta patch for a file |
 
 ### Wire Format — Metadata
 
@@ -86,16 +59,12 @@ When `use_metadata` is enabled (`-M`), each file entry carries a 4-byte `present
 
 ### Transfer Flow
 ```
-Config → (STATUS_NEXT | STATUS_CHUNK | STATUS_CHECK | STATUS_CHECK_BATCH)* → [STATUS_MANIFEST] → STATUS_FINISHED → STATUS_OK
+Config → (STATUS_NEXT | STATUS_CHUNK | STATUS_CHECK)* → [STATUS_MANIFEST] → STATUS_FINISHED → STATUS_OK
 ```
 
-Keep-alive (`STATUS_KEEPALIVE`) may be sent at any point during the transfer. The receiver resets its inactivity timer on receipt. If no data arrives within the receive timeout, the connection is aborted.
-
-Abort (`STATUS_ABORT`) may be sent at any point. On receipt the server cleans up temporary files and exits the child process.
-
 ### Protocol Version
 
-`1.3.0` — server and client must match. Mismatch results in `STATUS_ERROR`.
+`1.1.0` — server and client must match. Mismatch results in `STATUS_ERROR`.
 
 ## Command-Line Arguments
 
@@ -114,26 +83,15 @@ Abort (`STATUS_ABORT`) may be sent at any point. On receipt the server cleans up
 | `-n, --dry-run` | Scan and print what would be transferred |
 | `-p <port>` | SSH port (default: 22) |
 | `-v, --verbose` | Enable debug logging |
-| `-q, --quiet` | Suppress all non-error output |
-| `--silent` | Alias for `--quiet` |
 | `--progress` | Show real-time transfer speed |
 | `--delete` | Delete files on receiver not present in source |
 | `--exclude <pattern>` | Exclude files matching glob pattern (repeatable) |
-| `--exclude-from <file>` | Read exclude patterns from a file (one per line) |
 | `--include <pattern>` | Only transfer files matching glob pattern (repeatable, whitelist) |
 | `--max-size <n>` | Skip files larger than n bytes |
 | `--min-size <n>` | Skip files smaller than n bytes |
 | `--incremental` | Skip files unchanged since last transfer (size + mtime). Auto-enables `--preserve`. Incompatible with `-s`. |
 | `--bwlimit <KB/s>` | Bandwidth limit in kilobytes per second |
 | `--chunk-size <n>` | Chunk size in bytes (default: 10485760) |
-| `--timeout <sec>` | I/O timeout in seconds (default: 30) |
-| `--contimeout <sec>` | Connection timeout in seconds (default: 10) |
-| `--backup` | Backup existing destination files before overwriting |
-| `--backup-dir <dir>` | Target directory for backups (requires `--backup`) |
-| `--stats` | Print transfer statistics at end (bytes, files, timing) |
-| `--max-depth <n>` | Maximum directory depth to recurse (0 = unlimited, default: 0) |
-| `--log-file <path>` | Write log messages to file instead of stderr |
-| `--queue-size <n>` | Queue capacity for multithreaded mode (default: 100) |
 | `--source-dir <path>` | Source directory (overrides `FASTSYNC_SOURCE_DIR`) |
 | `--dest-dir <path>` | Server destination directory (overrides `FASTSYNC_DEST_DIR`) |
 | `--save-to-disk` | Write received files to disk |
@@ -164,12 +122,6 @@ Abort (`STATUS_ABORT`) may be sent at any point. On receipt the server cleans up
 | `FASTSYNC_SOURCE_DIR` | — | Source directory fallback |
 | `FASTSYNC_DEST_DIR` | — | Destination directory fallback |
 | `FASTSYNC_SAVE_TO_DISK` | `false` | Disk persistence fallback |
-| `FASTSYNC_SSH_PORT` | `22` | Default SSH port |
-| `FASTSYNC_SERVER_HOST` | `127.0.0.1` | Default server host |
-| `FASTSYNC_SERVER_PORT` | `8080` | Default server port |
-| `FASTSYNC_TLS_CERT` | — | Default TLS certificate path |
-| `FASTSYNC_TLS_KEY` | — | Default TLS private key path |
-| `FASTSYNC_TLS_CA` | — | Default TLS CA certificate path |
 
 ## Implementation Details
 
@@ -177,44 +129,21 @@ Abort (`STATUS_ABORT`) may be sent at any point. On receipt the server cleans up
 1. **Chunk** — collection of files (~10 MB total by default)
 2. **File** — path, content (`Data`), optional `FileMetadata` pointer
 3. **FileMetadata** — `mode`, `uid`, `gid`, `mtime_sec`, `mtime_nsec`
-4. **Config** — runtime parameters (transported over wire, TLS settings excluded). Includes `timeout`, `contimeout`, `quiet`, `backup`, `backup_dir`, `stats`, `max_depth`, `log_file`, `queue_size`.
+4. **Config** — runtime parameters (transported over wire, TLS settings excluded)
 5. **Queue** — thread-safe bounded queue with condition variables
-6. **DirectoryScanner** — recursive BFS traversal with exclude and include pattern support, max-depth enforcement
+6. **DirectoryScanner** — recursive BFS traversal with exclude and include pattern support
 
 ### Key Algorithms
-1. **File scanning** — BFS directory traversal; entries matched against exclude and include patterns, max-depth enforced
+1. **File scanning** — BFS directory traversal; entries matched against exclude and include patterns
 2. **Chunking** — files accumulated until `chunk_size` threshold, then flushed
 3. **Compression** — streaming zstd via `ZSTD_compressStream2` / `ZSTD_decompressStream`
-4. **Network protocol** — status-code-driven exchange with metadata packing, keep-alive, and abort support
-5. **Incremental check** — client sends `STATUS_CHECK` + path + size + mtime; server compares against destination. Can be batched via `STATUS_CHECK_BATCH` for reduced round-trips.
+4. **Network protocol** — status-code-driven exchange with metadata packing
+5. **Incremental check** — client sends `STATUS_CHECK` + path + size + mtime; server compares against destination
 6. **Bandwidth limiting** — token-bucket algorithm with `nanosleep` throttling on 64 KB write chunks
 7. **Metadata restoration** — `chmod()`, `chown()`, `utimensat()` on the receiving side
 8. **`--delete`** — sender tracks all sent paths; receiver walks destination tree and removes unlisted files/directories
 9. **SSH transport** — `socketpair()` + `fork()` + `execvp("ssh", ...)` with `ControlMaster` and port support
 10. **TLS transport** — OpenSSL `SSL_CTX` with TLS 1.2 minimum, optional CA verification, transparent `SSL_read`/`SSL_write` via `io_set_ssl()`
-11. **Path traversal protection** — `has_path_traversal()` rejects any file path containing `..` components, preventing directory escape attacks
-12. **Connection limiting** — server tracks active connections and rejects new ones beyond `max_connections` (default 100)
-13. **Keep-alive** — idle connections receive periodic `STATUS_KEEPALIVE` to detect half-open TCP connections
-14. **Abort handling** — `SIGINT` sets an abort flag; the next protocol operation sends `STATUS_ABORT` for clean server cleanup
-15. **Atomic writes** — files are written to a `.tmp` suffix then atomically renamed via `rename()`, preventing partial files
-16. **Backup** — before overwriting, existing files are moved to `--backup-dir` (or same directory with `~` suffix) preserving the original
-
-## Security Features
-
-### Path Traversal Protection
-All received file paths are validated by `has_path_traversal()` before any disk operation. Any path containing `..` components is rejected with `STATUS_ERROR`, preventing directory escape attacks.
-
-### TLS Certificate Verification
-When `--ca` is provided, the server performs mutual TLS verification (`SSL_VERIFY_PEER` with depth 4). Without `--ca`, TLS is still encrypted but peer certificates are not verified.
-
-### Connection Limits
-The server enforces a maximum of 100 concurrent connections (configurable via `max_connections` in `Server`). When the limit is reached, new connections are immediately rejected and closed.
-
-### Abort Handling
-If the client receives `SIGINT` (Ctrl+C) during a transfer, it sends `STATUS_ABORT` to the server. The server then cleans up temporary files and exits the child process, preventing incomplete files from remaining on disk.
-
-### Atomic Writes
-Received files are written to a temporary path (suffixed with `.tmp`) and then atomically renamed to the final filename via `rename()`. This prevents partial or corrupted files from appearing at the destination if the transfer is interrupted.
 
 ## Build Requirements
 
@@ -294,21 +223,6 @@ Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh u
 # Bandwidth limit to 1 MB/s
 ./build/client --bwlimit 1024 /src user@host:/dst
 
-# With timeouts, quiet mode, and stats
-./build/client --timeout 60 --contimeout 15 --quiet --stats /src user@host:/dst
-
-# Backup overwritten files to a directory
-./build/client --backup --backup-dir /backups /src user@host:/dst
-
-# Exclude patterns from file, limit depth
-./build/client --exclude-from ignore.txt --max-depth 3 /src user@host:/dst
-
-# Custom queue size for multithreading
-./build/client -m --queue-size 200 /src user@host:/dst
-
-# Log to file
-./build/client --log-file /tmp/fastsync.log /src user@host:/dst
-
 # All features
 ./build/client -a --progress --chunk-size 5242880 --exclude "*.log" --delete /src /dst
 ```
@@ -316,9 +230,7 @@ Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh u
 ## Testing
 
 ```bash
-# Unit tests (18 suites — array_list, chunk, compression, config, data, delta, file, glob,
-#                      metadata, property, protocol, queue, robustness, scanner,
-#                      shared_utils, stress, transport_tcp, transport_ssh, transport_tls)
+# Unit tests (7 suites)
 ./build/tests
 
 # Integration + benchmark suite
@@ -332,15 +244,12 @@ The benchmark prints throughput metrics, best configuration, and speedup vs rsyn
 1. Chunk size (~10 MB default) balances memory and transfer efficiency
 2. Compression level trades CPU for bandwidth
 3. `sendfile()` bypasses userspace — ~2× faster on localhost for large files
-4. Multithreading scales with core count; `--queue-size` controls pipeline buffering
+4. Multithreading scales with core count
 5. Metadata transfer adds negligible overhead (~24 bytes per file when enabled)
 6. SSH socketpair buffer set to 1 MB for improved pipe throughput
 7. SSH ControlMaster reuses connections across repeated invocations
 8. Incremental sync eliminates redundant transfers entirely
-9. Batch incremental reduces round-trips by grouping multiple checks into one message
-10. Bandwidth limiting uses token-bucket with nanosleep for accurate throttling
-11. Atomic writes add a single `rename()` per file — negligible overhead
-12. Path traversal check is O(n) in path length with negligible cost
+9. Bandwidth limiting uses token-bucket with nanosleep for accurate throttling
 
 ## Benchmark Results
 

src/client/client_cli.c

@@ -12,454 +12,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-/* Parse environment variables for source/destination directories and save-to-disk flag. */
-static void parse_environment(const char** out_env_source, const char** out_env_dest,
-                              bool* out_save_to_disk) {
-  *out_env_source = getenv("FASTSYNC_SOURCE_DIR");
-  *out_env_dest = getenv("FASTSYNC_DEST_DIR");
-  const char* env_save = getenv("FASTSYNC_SAVE_TO_DISK");
-  *out_save_to_disk = false;
-  if (env_save && (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0))
-    *out_save_to_disk = true;
-}
-
-/* Parse a string as a positive integer, returning true on success. */
-static bool parse_positive_int(const char* s, int* out_val) {
-  if (!s || *s == '\0')
-    return false;
-  char* endptr;
-  errno = 0;
-  long val = strtol(s, &endptr, 10);
-  if (errno != 0 || *endptr != '\0' || val <= 0 || val > INT_MAX)
-    return false;
-  *out_val = (int)val;
-  return true;
-}
-
-/* Parse a string as a non-negative integer, returning true on success. */
-static bool parse_nonneg_int(const char* s, int* out_val) {
-  if (!s || *s == '\0')
-    return false;
-  char* endptr;
-  errno = 0;
-  long val = strtol(s, &endptr, 10);
-  if (errno != 0 || *endptr != '\0' || val < 0 || val > INT_MAX)
-    return false;
-  *out_val = (int)val;
-  return true;
-}
-
-static void print_usage(void);
-static int read_patterns_from_file(const char* filepath, char*** patterns, int* count);
-
-/* Parse CLI arguments into config. Returns 0 on success, -1 on error, 1 for help/clean-exit. */
-static int parse_args(Config* config, int argc, char* argv[], int* positional_args,
-                      int* positional_count) {
-  for (int i = 1; i < argc; i++) {
-    if (strcmp(argv[i], "--help") == 0) {
-      print_usage();
-      return 1;
-    } else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
-      config->use_compression = true;
-      config->use_multithreading = true;
-      config->use_metadata = true;
-      log_message(LOG_LEVEL_INFO, "Enabled archive mode (-c -m -M)");
-    } else if (strcmp(argv[i], "-n") == 0 || strcmp(argv[i], "--dry-run") == 0) {
-      config->dry_run = true;
-    } else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
-      if (!parse_positive_int(argv[++i], &config->ssh_port)) {
-        fprintf(stderr, "Error: invalid --port/-p value: %s\n", argv[i]);
-        return -1;
-      }
-    } else if (strcmp(argv[i], "--delete") == 0) {
-      config->use_delete = true;
-    } else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
-      if (!tmp) {
-        fprintf(stderr, "Error: memory allocation failed for --exclude\n");
-        return -1;
-      }
-      config->exclude_patterns = tmp;
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --exclude\n");
-        return -1;
-      }
-      config->exclude_patterns[config->exclude_count++] = dup;
-    } else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
-      if (!tmp) {
-        fprintf(stderr, "Error: memory allocation failed for --include\n");
-        return -1;
-      }
-      config->include_patterns = tmp;
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --include\n");
-        return -1;
-      }
-      config->include_patterns[config->include_count++] = dup;
-    } else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
-      config->max_size = strtoull(argv[++i], NULL, 10);
-    } else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
-      config->min_size = strtoull(argv[++i], NULL, 10);
-    } else if (strcmp(argv[i], "--incremental") == 0) {
-      config->use_incremental = true;
-    } else if (strcmp(argv[i], "--delta") == 0) {
-      config->use_delta = true;
-    } else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
-        config->delta_block_size = (uint32_t)val;
-      else
-        fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
-    } else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val >= DELTA_MIN_FILE_SIZE)
-        config->delta_max_file_size = val;
-      else
-        fprintf(stderr, "Warning: --delta-max value %llu too small, using default\n", val);
-    } else if (strcmp(argv[i], "-c") == 0 || strcmp(argv[i], "-z") == 0) {
-      config->use_compression = true;
-      log_message(LOG_LEVEL_INFO, "Enabled Compression");
-      if (i + 1 < argc) {
-        char* end_ptr;
-        long level = strtol(argv[i + 1], &end_ptr, 10);
-        if (*end_ptr == '\0') {
-          config->compression_level = (int)level;
-          log_message(LOG_LEVEL_INFO, "Set Compression level to %ld", level);
-          i++;
-        }
-      }
-    } else if (strcmp(argv[i], "--source-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --source-dir\n");
-        return -1;
-      }
-      free(config->send_directory);
-      config->send_directory = dup;
-    } else if (strcmp(argv[i], "--dest-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --dest-dir\n");
-        return -1;
-      }
-      free(config->receive_root_directory);
-      config->receive_root_directory = dup;
-    } else if (strcmp(argv[i], "--save-to-disk") == 0) {
-      config->save_to_disk = true;
-    } else if (strcmp(argv[i], "-M") == 0 || strcmp(argv[i], "--preserve") == 0) {
-      config->use_metadata = true;
-      log_message(LOG_LEVEL_INFO, "Enabled metadata preservation");
-    } else if (strcmp(argv[i], "-f") == 0 || strcmp(argv[i], "--sendfile") == 0) {
-      config->use_sendfile = true;
-      log_message(LOG_LEVEL_INFO, "Enabled sendfile");
-    } else if (strcmp(argv[i], "-m") == 0) {
-      config->use_multithreading = true;
-      log_message(LOG_LEVEL_INFO, "Enabled Multithreading");
-    } else if (strcmp(argv[i], "-s") == 0) {
-      config->use_chunk_serialization = true;
-      log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
-    } else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --server-host\n");
-        return -1;
-      }
-      free(config->server_host);
-      config->server_host = dup;
-    } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
-      if (!parse_positive_int(argv[++i], &config->server_port)) {
-        fprintf(stderr, "Error: invalid --server-port value: %s\n", argv[i]);
-        return -1;
-      }
-    } else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
-      char* end;
-      errno = 0;
-      unsigned long long kbps = strtoull(argv[++i], &end, 10);
-      if (errno != 0 || *end != '\0' || kbps == 0) {
-        fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
-        return -1;
-      }
-      if (kbps > ULLONG_MAX / 1024) {
-        fprintf(stderr, "Error: --bwlimit value too large\n");
-        return -1;
-      }
-      io_set_bwlimit(kbps * 1024);
-      log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
-    } else if (strcmp(argv[i], "--progress") == 0) {
-      config->show_progress = true;
-    } else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val > 0)
-        config->chunk_size = val;
-    } else if (strcmp(argv[i], "--tls") == 0) {
-      config->use_tls = true;
-    } else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --cert\n");
-        return -1;
-      }
-      free(config->tls_cert);
-      config->tls_cert = dup;
-    } else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --key\n");
-        return -1;
-      }
-      free(config->tls_key);
-      config->tls_key = dup;
-    } else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --ca\n");
-        return -1;
-      }
-      free(config->tls_ca);
-      config->tls_ca = dup;
-    } else if (strcmp(argv[i], "--timeout") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --timeout must be a positive integer\n");
-        return -1;
-      }
-      config->timeout = val;
-    } else if (strcmp(argv[i], "--contimeout") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --contimeout must be a positive integer\n");
-        return -1;
-      }
-      config->contimeout = val;
-    } else if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--quiet") == 0 ||
-               strcmp(argv[i], "--silent") == 0) {
-      config->quiet = true;
-    } else if (strcmp(argv[i], "--backup") == 0) {
-      config->backup = true;
-    } else if (strcmp(argv[i], "--backup-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --backup-dir\n");
-        return -1;
-      }
-      free(config->backup_dir);
-      config->backup_dir = dup;
-    } else if (strcmp(argv[i], "--stats") == 0) {
-      config->stats = true;
-    } else if (strcmp(argv[i], "--max-depth") == 0 && i + 1 < argc) {
-      if (!parse_nonneg_int(argv[++i], &config->max_depth)) {
-        fprintf(stderr, "Error: --max-depth must be a non-negative integer\n");
-        return -1;
-      }
-    } else if (strcmp(argv[i], "--log-file") == 0 && i + 1 < argc) {
-      FILE* lf = fopen(argv[++i], "a");
-      if (!lf) {
-        fprintf(stderr, "Error: could not open log file '%s': %s\n", argv[i], strerror(errno));
-        return -1;
-      }
-      config->log_file = lf;
-      log_set_file(lf);
-    } else if (strcmp(argv[i], "--queue-size") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_positive_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --queue-size must be a positive integer\n");
-        return -1;
-      }
-      config->queue_size = val;
-    } else if (strcmp(argv[i], "--exclude-from") == 0 && i + 1 < argc) {
-      if (read_patterns_from_file(argv[++i], &config->exclude_patterns, &config->exclude_count) !=
-          0)
-        return -1;
-    } else if (strcmp(argv[i], "--include-from") == 0 && i + 1 < argc) {
-      if (read_patterns_from_file(argv[++i], &config->include_patterns, &config->include_count) !=
-          0)
-        return -1;
-    } else if (strcmp(argv[i], "--partial") == 0) {
-      config->partial = true;
-    } else if (strcmp(argv[i], "--fastsync-server-path") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup) {
-        fprintf(stderr, "Error: memory allocation failed for --fastsync-server-path\n");
-        return -1;
-      }
-      free(config->fastsync_server_path);
-      config->fastsync_server_path = dup;
-    } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
-      set_log_level(LOG_LEVEL_DEBUG);
-    } else if (strcmp(argv[i], "-l") == 0 || strcmp(argv[i], "--links") == 0) {
-      config->follow_symlinks = true;
-    } else if (strcmp(argv[i], "--copy-links") == 0) {
-      config->copy_links = true;
-    } else if (strcmp(argv[i], "--safe-links") == 0) {
-      config->safe_links = true;
-    } else if (strcmp(argv[i], "--copy-unsafe-links") == 0) {
-      config->copy_unsafe_links = true;
-    } else if (strcmp(argv[i], "-H") == 0 || strcmp(argv[i], "--hard-links") == 0) {
-      config->preserve_hard_links = true;
-    } else if (strcmp(argv[i], "-A") == 0 || strcmp(argv[i], "--acls") == 0) {
-      config->preserve_acls = true;
-    } else if (strcmp(argv[i], "-X") == 0 || strcmp(argv[i], "--xattrs") == 0) {
-      config->preserve_xattrs = true;
-    } else if (strcmp(argv[i], "-D") == 0 || strcmp(argv[i], "--devices") == 0) {
-      config->preserve_devices = true;
-    } else if (strcmp(argv[i], "-S") == 0 || strcmp(argv[i], "--sparse") == 0) {
-      config->preserve_sparse = true;
-    } else if (strcmp(argv[i], "-i") == 0 || strcmp(argv[i], "--itemize-changes") == 0) {
-      config->itemize_changes = true;
-    } else if (strcmp(argv[i], "--out-format") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->out_format);
-      config->out_format = dup;
-    } else if (strcmp(argv[i], "--info") == 0 && i + 1 < argc) {
-      config->info_level = atoi(argv[++i]);
-    } else if (strcmp(argv[i], "--debug") == 0 && i + 1 < argc) {
-      config->debug_level = atoi(argv[++i]);
-    } else if (strcmp(argv[i], "--list-only") == 0) {
-      config->list_only = true;
-    } else if (strcmp(argv[i], "-h") == 0 || strcmp(argv[i], "--human-readable") == 0) {
-      config->human_readable = true;
-    } else if (strcmp(argv[i], "-u") == 0 || strcmp(argv[i], "--update") == 0) {
-      config->update = true;
-    } else if (strcmp(argv[i], "--inplace") == 0) {
-      config->inplace = true;
-    } else if (strcmp(argv[i], "--append") == 0) {
-      config->append = true;
-    } else if (strcmp(argv[i], "--append-verify") == 0) {
-      config->append_verify = true;
-    } else if (strcmp(argv[i], "--delete-excluded") == 0) {
-      config->delete_excluded = true;
-    } else if (strcmp(argv[i], "--delete-after") == 0) {
-      config->delete_after = true;
-    } else if (strcmp(argv[i], "--max-delete") == 0 && i + 1 < argc) {
-      int val;
-      if (!parse_nonneg_int(argv[++i], &val)) {
-        fprintf(stderr, "Error: --max-delete must be a non-negative integer\n");
-        return -1;
-      }
-      config->max_delete = val;
-    } else if (strcmp(argv[i], "--filter") == 0 && i + 1 < argc) {
-      if (!config->filters)
-        config->filters = array_list_create(free);
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      array_list_add(config->filters, dup);
-    } else if (strcmp(argv[i], "--files-from") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->files_from);
-      config->files_from = dup;
-    } else if (strcmp(argv[i], "--cvs-exclude") == 0) {
-      config->cvs_exclude = true;
-    } else if (strcmp(argv[i], "--prune-empty-dirs") == 0) {
-      config->prune_empty_dirs = true;
-    } else if (strcmp(argv[i], "-R") == 0 || strcmp(argv[i], "--relative") == 0) {
-      config->relative = true;
-    } else if (strcmp(argv[i], "-e") == 0 || strcmp(argv[i], "--rsh") == 0) {
-      if (i + 1 < argc) {
-        char* dup = str_dup(argv[++i]);
-        if (!dup)
-          return -1;
-        free(config->rsh_command);
-        config->rsh_command = dup;
-      } else {
-        fprintf(stderr, "Error: -e/--rsh requires a command argument\n");
-        return -1;
-      }
-    } else if (strcmp(argv[i], "--rsync-path") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->rsync_path);
-      config->rsync_path = dup;
-    } else if (strcmp(argv[i], "--temp-dir") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->temp_dir);
-      config->temp_dir = dup;
-    } else if (strcmp(argv[i], "--compare-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->compare_dest);
-      config->compare_dest = dup;
-    } else if (strcmp(argv[i], "--copy-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->copy_dest);
-      config->copy_dest = dup;
-    } else if (strcmp(argv[i], "--link-dest") == 0 && i + 1 < argc) {
-      char* dup = str_dup(argv[++i]);
-      if (!dup)
-        return -1;
-      free(config->link_dest);
-      config->link_dest = dup;
-    } else if (argv[i][0] == '-') {
-      fprintf(stderr, "Unknown option: %s\n", argv[i]);
-      print_usage();
-      return -1;
-    } else {
-      if (*positional_count < 2)
-        positional_args[(*positional_count)++] = i;
-      else {
-        fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
-        print_usage();
-        return -1;
-      }
-    }
-  }
-  return 0;
-}
-
-/* Validate config after parsing. Returns true if valid. */
-static bool validate_config(const Config* config) {
-  if (!config->send_directory || !config->receive_root_directory) {
-    fprintf(stderr, "Error: source and destination directories are required\n");
-    print_usage();
-    return false;
-  }
-  if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
-    fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
-                    "serialization)\n");
-    return false;
-  }
-  if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
-    fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
-    return false;
-  }
-  if (config->use_incremental && config->use_chunk_serialization) {
-    fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
-    return false;
-  }
-  if (config->use_delta && !config->use_incremental) {
-    fprintf(stderr, "Error: --delta requires --incremental\n");
-    return false;
-  }
-  if (config->use_delta && config->use_chunk_serialization) {
-    fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
-    return false;
-  }
-  if (config->use_delta && config->use_sendfile) {
-    fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
-    return false;
-  }
-  if (config->use_tls) {
-    if (!config->tls_cert || !config->tls_key) {
-      fprintf(stderr, "Error: --tls requires --cert and --key\n");
-      return false;
-    }
-  }
-  return true;
-}
-
 static void print_usage(void) {
   printf("Usage:\n");
   printf("  fastsync [options] <source> <destination>\n");
@@ -516,42 +68,6 @@ static void print_usage(void) {
   printf("  --max-depth <n>     Maximum directory depth (0=unlimited)\n");
   printf("  --log-file <path>   Write log messages to file\n");
   printf("  --queue-size <n>    Queue capacity for multithreaded mode (default: 100)\n");
-  printf("  --partial           Keep partial files on interrupted transfer\n");
-  printf("  --fastsync-server-path <path>\n");
-  printf("                      Path to fastsync-server on remote (default: fastsync-server)\n");
-  printf("  -l, --links         Copy symlinks as symlinks\n");
-  printf("  --copy-links        Transform symlinks into referent files\n");
-  printf("  --safe-links        Skip symlinks that point outside transfer tree\n");
-  printf("  --copy-unsafe-links  Only transform unsafe symlinks into referent files\n");
-  printf("  -H, --hard-links    Preserve hard links\n");
-  printf("  -A, --acls          Preserve ACLs\n");
-  printf("  -X, --xattrs        Preserve extended attributes\n");
-  printf("  -D, --devices       Preserve device files\n");
-  printf("  -S, --sparse        Handle sparse files efficiently\n");
-  printf("  -i, --itemize-changes  Show per-file change summary\n");
-  printf("  --out-format <fmt>  Custom output format string\n");
-  printf("  --info <flags>      Info verbosity level\n");
-  printf("  --debug <flags>     Debug verbosity level\n");
-  printf("  --list-only         List files without transferring\n");
-  printf("  -h, --human-readable  Human-readable numbers\n");
-  printf("  -u, --update        Skip files newer on destination\n");
-  printf("  --inplace           Update files in-place (no temp+rename)\n");
-  printf("  --append            Append data to shorter files\n");
-  printf("  --append-verify     Append with verify\n");
-  printf("  --delete-excluded   Also delete excluded files\n");
-  printf("  --delete-after      Delete after transfer, not before\n");
-  printf("  --max-delete <n>    Maximum number of files to delete\n");
-  printf("  --filter <rule>     Add file filtering rule\n");
-  printf("  --files-from <file> Read file list from file\n");
-  printf("  --cvs-exclude       Auto-ignore CVS files\n");
-  printf("  --prune-empty-dirs  Omit empty directories from transfer\n");
-  printf("  -R, --relative      Use relative paths\n");
-  printf("  -e, --rsh <cmd>     Specify remote shell\n");
-  printf("  --rsync-path <path> Path to remote binary\n");
-  printf("  --temp-dir <dir>    Temporary directory for files\n");
-  printf("  --compare-dest <dir>  Compare destination\n");
-  printf("  --copy-dest <dir>   Copy destination\n");
-  printf("  --link-dest <dir>   Link destination\n");
   printf("  --help              Show this help\n");
 }
 
@@ -580,60 +96,237 @@ static int read_patterns_from_file(const char* filepath, char*** patterns, int*
       return -1;
     }
     *patterns = tmp;
-    char* dup = str_dup(p);
-    if (!dup) {
-      fprintf(stderr, "Error: memory allocation failed for pattern file\n");
-      fclose(fp);
-      return -1;
-    }
-    (*patterns)[(*count)++] = dup;
+    (*patterns)[(*count)++] = str_dup(p);
   }
   fclose(fp);
   return 0;
 }
 
 int main(int argc, char* argv[]) {
-  const char* env_source = NULL;
-  const char* env_dest = NULL;
-  bool save_to_disk = false;
-  parse_environment(&env_source, &env_dest, &save_to_disk);
+  const char* env_source = getenv("FASTSYNC_SOURCE_DIR");
+  const char* env_dest = getenv("FASTSYNC_DEST_DIR");
+  const char* env_save = getenv("FASTSYNC_SAVE_TO_DISK");
 
+  bool save_to_disk = false;
+  if (env_save && (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0)) {
+    save_to_disk = true;
+  }
+
+  Config* config = config_create(str_dup(PROTOCOL_VERSION), NULL, NULL, save_to_disk, false, false,
+                                 false, false, 5, false, 0);
   int exit_code = 0;
   bool config_owned_by_pipeline = false;
-  Config* config = config_create();
-  if (!config) {
-    fprintf(stderr, "Error: failed to allocate config\n");
-    return 1;
-  }
-  config->save_to_disk = save_to_disk;
 
   int positional_args[2];
   int positional_count = 0;
 
-  int parse_ret = parse_args(config, argc, argv, positional_args, &positional_count);
-  if (parse_ret != 0) {
-    if (parse_ret < 0)
+  for (int i = 1; i < argc; i++) {
+    if (strcmp(argv[i], "--help") == 0) {
+      print_usage();
+      goto cleanup;
+    } else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
+      config->use_compression = true;
+      config->use_multithreading = true;
+      config->use_metadata = true;
+      log_message(LOG_LEVEL_INFO, "Enabled archive mode (-c -m -M)");
+    } else if (strcmp(argv[i], "-n") == 0 || strcmp(argv[i], "--dry-run") == 0) {
+      config->dry_run = true;
+    } else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
+      config->ssh_port = atoi(argv[++i]);
+    } else if (strcmp(argv[i], "--delete") == 0) {
+      config->use_delete = true;
+    } else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
+      char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
+      if (!tmp) {
+        fprintf(stderr, "Error: memory allocation failed for --exclude\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+      config->exclude_patterns = tmp;
+      config->exclude_patterns[config->exclude_count++] = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
+      char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
+      if (!tmp) {
+        fprintf(stderr, "Error: memory allocation failed for --include\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+      config->include_patterns = tmp;
+      config->include_patterns[config->include_count++] = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
+      config->max_size = strtoull(argv[++i], NULL, 10);
+    } else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
+      config->min_size = strtoull(argv[++i], NULL, 10);
+    } else if (strcmp(argv[i], "--incremental") == 0) {
+      config->use_incremental = true;
+    } else if (strcmp(argv[i], "--delta") == 0) {
+      config->use_delta = true;
+    } else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
+      unsigned long long val = strtoull(argv[++i], NULL, 10);
+      if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
+        config->delta_block_size = (uint32_t)val;
+      else
+        fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
+    } else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
+      unsigned long long val = strtoull(argv[++i], NULL, 10);
+      if (val >= DELTA_MIN_FILE_SIZE)
+        config->delta_max_file_size = val;
+      else
+        fprintf(stderr, "Warning: --delta-max value %llu too small, using default\n", val);
+    } else if (strcmp(argv[i], "-c") == 0 || strcmp(argv[i], "-z") == 0) {
+      config->use_compression = true;
+      log_message(LOG_LEVEL_INFO, "Enabled Compression");
+      if (i + 1 < argc) {
+        char* end_ptr;
+        int level = strtol(argv[i + 1], &end_ptr, 10);
+        if (*end_ptr == '\0') {
+          config->compression_level = level;
+          log_message(LOG_LEVEL_INFO, "Set Compression level to %d", config->compression_level);
+          i++;
+        }
+      }
+    } else if (strcmp(argv[i], "--source-dir") == 0 && i + 1 < argc) {
+      free(config->send_directory);
+      config->send_directory = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--dest-dir") == 0 && i + 1 < argc) {
+      free(config->receive_root_directory);
+      config->receive_root_directory = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--save-to-disk") == 0) {
+      config->save_to_disk = true;
+    } else if (strcmp(argv[i], "-M") == 0 || strcmp(argv[i], "--preserve") == 0) {
+      config->use_metadata = true;
+      log_message(LOG_LEVEL_INFO, "Enabled metadata preservation");
+    } else if (strcmp(argv[i], "-f") == 0 || strcmp(argv[i], "--sendfile") == 0) {
+      config->use_sendfile = true;
+      log_message(LOG_LEVEL_INFO, "Enabled sendfile");
+    } else if (strcmp(argv[i], "-m") == 0) {
+      config->use_multithreading = true;
+      log_message(LOG_LEVEL_INFO, "Enabled Multithreading");
+    } else if (strcmp(argv[i], "-s") == 0) {
+      config->use_chunk_serialization = true;
+      log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
+    } else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
+      free(config->server_host);
+      config->server_host = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
+      config->server_port = atoi(argv[++i]);
+    } else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
+      char* end;
+      errno = 0;
+      unsigned long long kbps = strtoull(argv[++i], &end, 10);
+      if (errno != 0 || *end != '\0' || kbps == 0) {
+        fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+      if (kbps > ULLONG_MAX / 1024) {
+        fprintf(stderr, "Error: --bwlimit value too large\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+      io_set_bwlimit(kbps * 1024);
+      log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
+    } else if (strcmp(argv[i], "--progress") == 0) {
+      config->show_progress = true;
+    } else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
+      unsigned long long val = strtoull(argv[++i], NULL, 10);
+      if (val > 0)
+        config->chunk_size = val;
+    } else if (strcmp(argv[i], "--tls") == 0) {
+      config->use_tls = true;
+    } else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
+      free(config->tls_cert);
+      config->tls_cert = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
+      free(config->tls_key);
+      config->tls_key = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
+      free(config->tls_ca);
+      config->tls_ca = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--timeout") == 0 && i + 1 < argc) {
+      config->timeout = atoi(argv[++i]);
+      if (config->timeout <= 0) {
+        fprintf(stderr, "Error: --timeout must be a positive integer\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "--contimeout") == 0 && i + 1 < argc) {
+      config->contimeout = atoi(argv[++i]);
+      if (config->contimeout <= 0) {
+        fprintf(stderr, "Error: --contimeout must be a positive integer\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--quiet") == 0 ||
+               strcmp(argv[i], "--silent") == 0) {
+      config->quiet = true;
+    } else if (strcmp(argv[i], "--backup") == 0) {
+      config->backup = true;
+    } else if (strcmp(argv[i], "--backup-dir") == 0 && i + 1 < argc) {
+      config->backup_dir = str_dup(argv[++i]);
+    } else if (strcmp(argv[i], "--stats") == 0) {
+      config->stats = true;
+    } else if (strcmp(argv[i], "--max-depth") == 0 && i + 1 < argc) {
+      config->max_depth = atoi(argv[++i]);
+      if (config->max_depth < 0) {
+        fprintf(stderr, "Error: --max-depth must be a non-negative integer\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "--log-file") == 0 && i + 1 < argc) {
+      FILE* lf = fopen(argv[++i], "a");
+      if (!lf) {
+        fprintf(stderr, "Error: could not open log file '%s': %s\n", argv[i], strerror(errno));
+        exit_code = 1;
+        goto cleanup;
+      }
+      config->log_file = lf;
+      log_set_file(lf);
+    } else if (strcmp(argv[i], "--queue-size") == 0 && i + 1 < argc) {
+      config->queue_size = atoi(argv[++i]);
+      if (config->queue_size <= 0) {
+        fprintf(stderr, "Error: --queue-size must be a positive integer\n");
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "--exclude-from") == 0 && i + 1 < argc) {
+      if (read_patterns_from_file(argv[++i], &config->exclude_patterns, &config->exclude_count) !=
+          0) {
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "--include-from") == 0 && i + 1 < argc) {
+      if (read_patterns_from_file(argv[++i], &config->include_patterns, &config->include_count) !=
+          0) {
+        exit_code = 1;
+        goto cleanup;
+      }
+    } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
+      set_log_level(LOG_LEVEL_DEBUG);
+    } else if (argv[i][0] == '-') {
+      fprintf(stderr, "Unknown option: %s\n", argv[i]);
+      print_usage();
       exit_code = 1;
-    goto cleanup;
+      goto cleanup;
+    } else {
+      if (positional_count < 2)
+        positional_args[positional_count++] = i;
+      else {
+        fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
+        print_usage();
+        exit_code = 1;
+        goto cleanup;
+      }
+    }
   }
 
-  /* Handle positional arguments or fall back to environment variables */
   if (positional_count == 2) {
     free(config->send_directory);
     free(config->receive_root_directory);
     config->send_directory = str_dup(argv[positional_args[0]]);
-    if (!config->send_directory) {
-      fprintf(stderr, "Error: memory allocation failed\n");
-      exit_code = 1;
-      goto cleanup;
-    }
     config->receive_root_directory = str_dup(argv[positional_args[1]]);
-    if (!config->receive_root_directory) {
-      fprintf(stderr, "Error: memory allocation failed\n");
-      exit_code = 1;
-      goto cleanup;
-    }
     config->save_to_disk = true;
+
     config_parse_ssh_dest(config);
   } else if (positional_count == 1) {
     fprintf(stderr, "Error: missing destination argument\n");
@@ -641,46 +334,73 @@ int main(int argc, char* argv[]) {
     exit_code = 1;
     goto cleanup;
   } else {
-    if (!config->send_directory && env_source) {
-      config->send_directory = str_dup(env_source);
-      if (!config->send_directory) {
-        fprintf(stderr, "Error: memory allocation failed\n");
-        exit_code = 1;
-        goto cleanup;
-      }
-    }
-    if (!config->receive_root_directory && env_dest) {
-      config->receive_root_directory = str_dup(env_dest);
-      if (!config->receive_root_directory) {
-        fprintf(stderr, "Error: memory allocation failed\n");
-        exit_code = 1;
-        goto cleanup;
-      }
-    }
+    if (!config->send_directory && env_source)
+      config->send_directory = str_dup((char*)env_source);
+    if (!config->receive_root_directory && env_dest)
+      config->receive_root_directory = str_dup((char*)env_dest);
   }
 
-  if (!validate_config(config)) {
+  if (!config->send_directory || !config->receive_root_directory) {
+    fprintf(stderr, "Error: source and destination directories are required\n");
+    print_usage();
+    exit_code = 1;
+    goto cleanup;
+  }
+  if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
+    fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
+                    "serialization)\n");
+    exit_code = 1;
+    goto cleanup;
+  }
+
+  if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
+    fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
+    exit_code = 1;
+    goto cleanup;
+  }
+
+  if (config->use_incremental && config->use_chunk_serialization) {
+    fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
     exit_code = 1;
     goto cleanup;
   }
 
-  /* Enable implicit flags */
   if (config->use_incremental && !config->use_metadata) {
     log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --incremental");
     config->use_metadata = true;
   }
+
+  if (config->use_delta && !config->use_incremental) {
+    fprintf(stderr, "Error: --delta requires --incremental\n");
+    exit_code = 1;
+    goto cleanup;
+  }
+  if (config->use_delta && config->use_chunk_serialization) {
+    fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
+    exit_code = 1;
+    goto cleanup;
+  }
+  if (config->use_delta && config->use_sendfile) {
+    fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
+    exit_code = 1;
+    goto cleanup;
+  }
   if (config->use_delta && !config->use_metadata) {
     log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --delta");
     config->use_metadata = true;
   }
 
-  /* Initialize TLS if needed */
-  if (config->use_tls)
+  if (config->use_tls) {
+    if (!config->tls_cert || !config->tls_key) {
+      fprintf(stderr, "Error: --tls requires --cert and --key\n");
+      exit_code = 1;
+      goto cleanup;
+    }
     tls_global_init();
+  }
 
   tcp_set_timeouts(config->timeout, config->contimeout);
 
-  /* Execute transfer */
   if (config->use_multithreading) {
     config_owned_by_pipeline = true;
     exit_code = send_files_multithreaded(config);
@@ -689,11 +409,9 @@ int main(int argc, char* argv[]) {
   }
 
 cleanup:
-  if (config) {
-    if (config->log_file)
-      fclose(config->log_file);
-    if (!config_owned_by_pipeline)
-      config_delete(config);
-  }
+  if (config->log_file)
+    fclose(config->log_file);
+  if (!config_owned_by_pipeline)
+    config_delete(config);
   return exit_code;
 }

src/client/client_send.c

@@ -16,53 +16,22 @@
 #include "transport_ssh.h"
 #include "transport_tls.h"
 #include "utils.h"
+#include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <threads.h>
 #include <time.h>
-#include <unistd.h>
 
-#define STREAM_THRESHOLD (64ULL * 1024 * 1024)
+static volatile sig_atomic_t g_abort_requested = 0;
+static int g_abort_fd = -1;
 
-/* Print dry-run manifest showing files that would be transferred. Returns 0 on success. */
-static int send_dry_run_manifest(Config* config) {
-  DirectoryScanner* scanner = directory_scanner_create(
-      config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
-      config->exclude_count, config->include_patterns, config->include_count, config->max_size,
-      config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
-      config->safe_links, config->copy_unsafe_links);
-  if (!scanner)
-    return -1;
-  Chunk* chunk;
-  int file_count = 0;
-  unsigned long long total_bytes = 0;
-  printf("Dry run: files to be transferred\n");
-  while ((chunk = directory_scanner_next(scanner)) != NULL) {
-    for (int i = 0; i < chunk->element_count; i++) {
-      printf("  %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
-      total_bytes += chunk->items[i]->data->size;
-      file_count++;
-    }
-    chunk_destroy(chunk);
-  }
-  directory_scanner_destroy(scanner);
-  printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
-  return 0;
+static void handle_sigint(int sig) {
+  (void)sig;
+  g_abort_requested = 1;
 }
 
-/* Send the delete manifest (list of files) to the server. Returns 0 on success, -1 on failure. */
-static int send_delete_manifest(int fd, ArrayList* manifest) {
-  if (!send_status(fd, STATUS_MANIFEST))
-    return -1;
-  if (!send_int(fd, manifest->size))
-    return -1;
-  for (int i = 0; i < manifest->size; i++) {
-    if (!send_str(fd, (char*)manifest->items[i]))
-      return -1;
-  }
-  return 0;
-}
+#define KEEPALIVE_INTERVAL 30
 
 static int incremental_check(Client* client, File* file, DeltaSignature** out_sig) {
   *out_sig = NULL;
@@ -138,6 +107,35 @@ static int send_delta(Client* client, File* file, DeltaSignature* sig, Config* c
   return ok ? 0 : -1;
 }
 
+static bool batch_incremental_check(Client* client, ArrayList* files) {
+  if (!send_status(client->file_descriptor, STATUS_CHECK_BATCH))
+    return false;
+  if (!send_int(client->file_descriptor, files->size))
+    return false;
+  for (int i = 0; i < files->size; i++) {
+    File* file = (File*)files->items[i];
+    if (!send_str(client->file_descriptor, file->path))
+      return false;
+    unsigned long long fsize = file->data ? file->data->size : 0;
+    long long mtime = file->metadata ? file->metadata->mtime_sec : 0;
+    if (!send_n_data(client->file_descriptor, &fsize, sizeof(fsize)))
+      return false;
+    if (!send_n_data(client->file_descriptor, &mtime, sizeof(mtime)))
+      return false;
+  }
+  for (int i = 0; i < files->size; i++) {
+    Status s;
+    if (!receive_status(client->file_descriptor, &s))
+      return false;
+    File* file = (File*)files->items[i];
+    if (s == STATUS_OK)
+      file->skip = true;
+    else if (s == STATUS_ERROR)
+      return false;
+  }
+  return true;
+}
+
 typedef bool (*file_send_fn)(File*, int, bool, int, bool);
 
 // Send a single file directly (non-incremental path).
@@ -160,6 +158,9 @@ static int send_single_file(Client* client, File* file, Config* config, bool use
                             bool use_sendfile) {
   int compression_level = config->use_compression ? config->compression_level : 0;
 
+  if (file->skip)
+    return 1;
+
   if (!use_incremental) {
     if (use_sendfile) {
       return send_file_direct_sendfile(file, client->file_descriptor, config->use_metadata) ? 0
@@ -250,13 +251,10 @@ int send_chunk(Client* client, Chunk* chunk, Config* config) {
     return 0;
   }
 
+  bool use_sendfile = config->use_sendfile && !config->use_compression;
   for (int i = 0; i < chunk->element_count; i++) {
-    File* f = chunk->items[i];
-    if (f == NULL)
-      continue;
-    bool stream = f->data->data == NULL && f->data->size > 0;
-    bool use_sendfile = (config->use_sendfile && !config->use_compression) || stream;
-    int rc = send_single_file(client, f, config, config->use_incremental, use_sendfile);
+    int rc =
+        send_single_file(client, chunk->items[i], config, config->use_incremental, use_sendfile);
     if (rc == 1)
       continue;
     if (rc < 0)
@@ -273,8 +271,7 @@ static int send_chunks_multithreaded(void* pipeline_context) {
       fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
       return 1;
     }
-    client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port,
-                                context->config->fastsync_server_path);
+    client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port);
   } else if (context->config->use_tls) {
     client = client_create();
     if (!client || !client_connect_tls(client, context->config->server_host,
@@ -301,14 +298,43 @@ static int send_chunks_multithreaded(void* pipeline_context) {
     return thrd_error;
   }
 
+  g_abort_fd = client->file_descriptor;
+  time_t last_activity = time(NULL);
   while (true) {
+    if (g_abort_requested) {
+      send_status(client->file_descriptor, STATUS_ABORT);
+      client_disconnect(client);
+      client_delete(client);
+      return thrd_error;
+    }
+    time_t now = time(NULL);
+    if (now - last_activity >= KEEPALIVE_INTERVAL) {
+      if (!send_status(client->file_descriptor, STATUS_KEEPALIVE)) {
+        client_disconnect(client);
+        client_delete(client);
+        return thrd_error;
+      }
+      Status s;
+      if (!receive_status(client->file_descriptor, &s)) {
+        client_disconnect(client);
+        client_delete(client);
+        return thrd_error;
+      }
+      last_activity = now;
+    }
     Chunk* current_chunk = queue_dequeue_multithreaded(
         context->queue_loader, &context->mutex_loader, &context->condition_not_empty_loader,
         &context->condition_not_full_loader, &context->loader_done);
     if (current_chunk == NULL) {
       if (context->config->use_delete) {
-        if (send_delete_manifest(client->file_descriptor, context->manifest) != 0)
+        if (!send_status(client->file_descriptor, STATUS_MANIFEST))
           goto send_fail;
+        if (!send_int(client->file_descriptor, context->manifest->size))
+          goto send_fail;
+        for (int i = 0; i < context->manifest->size; i++) {
+          if (!send_str(client->file_descriptor, (char*)context->manifest->items[i]))
+            goto send_fail;
+        }
       }
       if (!send_status(client->file_descriptor, STATUS_FINISHED))
         goto send_fail;
@@ -335,15 +361,16 @@ static int send_chunks_multithreaded(void* pipeline_context) {
 
 static int scan_directory_multithreaded(void* pipeline_context) {
   PipelineContextSender* context = (PipelineContextSender*)pipeline_context;
-  ParallelScanner* scanner = parallel_scanner_create(
+  mtx_lock(&context->mutex_scanner);
+  DirectoryScanner* scanner = directory_scanner_create(
       context->config->send_directory, context->config->use_metadata, context->config->chunk_size,
       context->config->exclude_patterns, context->config->exclude_count,
       context->config->include_patterns, context->config->include_count, context->config->max_size,
-      context->config->min_size, context->config->max_depth, 4, context->config->follow_symlinks,
-      context->config->copy_links, context->config->safe_links, context->config->copy_unsafe_links);
+      context->config->min_size, context->config->max_depth);
+  mtx_unlock(&context->mutex_scanner);
 
   Chunk* current_chunk;
-  while ((current_chunk = parallel_scanner_next(scanner)) != NULL) {
+  while ((current_chunk = directory_scanner_next(scanner)) != NULL) {
     if (context->config->use_delete) {
       mtx_lock(&context->mutex_scanner);
       for (int i = 0; i < current_chunk->element_count; i++) {
@@ -363,7 +390,7 @@ static int scan_directory_multithreaded(void* pipeline_context) {
   cnd_signal(&context->condition_not_empty_scanner);
   mtx_unlock(&context->mutex_scanner);
 
-  parallel_scanner_destroy(scanner);
+  directory_scanner_destroy(scanner);
   return thrd_success;
 }
 
@@ -382,12 +409,9 @@ static int load_files_multithreaded(void* pipeline_context) {
     }
     if (!context->config->use_sendfile) {
       for (int i = 0; i < chunk->element_count; i++) {
-        File* f = chunk->items[i];
-        if (f->data->size > STREAM_THRESHOLD)
-          continue;
-        if (!file_load_data(f)) {
+        if (!file_load_data(chunk->items[i])) {
           log_message(LOG_LEVEL_ERROR, "Failed to load file data, skipping");
-          file_destroy(f);
+          file_destroy(chunk->items[i]);
           chunk->items[i] = NULL;
         }
       }
@@ -399,8 +423,30 @@ static int load_files_multithreaded(void* pipeline_context) {
 }
 
 int send_files(Config* config) {
-  if (config->dry_run)
-    return send_dry_run_manifest(config);
+  if (config->dry_run) {
+    DirectoryScanner* scanner = directory_scanner_create(
+        config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
+        config->exclude_count, config->include_patterns, config->include_count, config->max_size,
+        config->min_size, config->max_depth);
+    Chunk* chunk;
+    int file_count = 0;
+    unsigned long long total_bytes = 0;
+    if (!config->quiet)
+      printf("Dry run: files to be transferred\n");
+    while ((chunk = directory_scanner_next(scanner)) != NULL) {
+      for (int i = 0; i < chunk->element_count; i++) {
+        if (!config->quiet)
+          printf("  %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
+        total_bytes += chunk->items[i]->data->size;
+        file_count++;
+      }
+      chunk_destroy(chunk);
+    }
+    directory_scanner_destroy(scanner);
+    if (!config->quiet)
+      printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
+    return 0;
+  }
 
   Client* client;
   if (config->transport == TRANSPORT_SSH) {
@@ -408,8 +454,7 @@ int send_files(Config* config) {
       fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
       return 1;
     }
-    client =
-        client_connect_ssh(config->ssh_destination, config->ssh_port, config->fastsync_server_path);
+    client = client_connect_ssh(config->ssh_destination, config->ssh_port);
     if (!client)
       return 1;
   } else if (config->use_tls) {
@@ -435,46 +480,98 @@ int send_files(Config* config) {
     client_delete(client);
     return 1;
   }
+
+  g_abort_fd = client->file_descriptor;
+  struct sigaction sa;
+  memset(&sa, 0, sizeof(sa));
+  sa.sa_handler = handle_sigint;
+  sigaction(SIGINT, &sa, NULL);
+  sigaction(SIGTERM, &sa, NULL);
+
   DirectoryScanner* scanner = directory_scanner_create(
       config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
       config->exclude_count, config->include_patterns, config->include_count, config->max_size,
-      config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
-      config->safe_links, config->copy_unsafe_links);
-  Chunk* current_chunk;
-  unsigned long long total_bytes = 0;
-  time_t last_progress = 0;
-  time_t start = time(NULL);
+      config->min_size, config->max_depth);
+  ArrayList* all_files = array_list_create(NULL);
   ArrayList* manifest = config->use_delete ? array_list_create(free) : NULL;
+  Chunk* current_chunk;
   while ((current_chunk = directory_scanner_next(scanner)) != NULL) {
-    unsigned long long chunk_bytes = 0;
     for (int i = 0; i < current_chunk->element_count; i++) {
-      chunk_bytes += current_chunk->items[i]->data->size;
+      File* f = current_chunk->items[i];
+      array_list_add(all_files, f);
+      current_chunk->items[i] = NULL;
       if (manifest) {
-        const char* p = current_chunk->items[i]->path;
+        const char* p = f->path;
         if (*p == '/')
           p++;
         array_list_add(manifest, str_dup(p));
       }
     }
-    if (!config->use_sendfile) {
-      for (int i = 0; i < current_chunk->element_count; i++) {
-        File* f = current_chunk->items[i];
-        if (f->data->size > STREAM_THRESHOLD)
-          continue;
-        if (!file_load_data(f)) {
-          log_message(LOG_LEVEL_ERROR, "Failed to load file data");
-          continue;
-        }
-      }
+    chunk_destroy(current_chunk);
+  }
+  directory_scanner_destroy(scanner);
+  scanner = NULL;
+
+  bool batch_ok = true;
+  if (config->use_incremental && all_files->size > 0) {
+    if (!batch_incremental_check(client, all_files)) {
+      log_message(LOG_LEVEL_ERROR, "Batch incremental check failed");
+      batch_ok = false;
     }
-    if (send_chunk(client, current_chunk, config) != 0) {
-      log_message(LOG_LEVEL_ERROR, "Failed to send chunk");
-      chunk_destroy(current_chunk);
+  }
+
+  unsigned long long total_bytes = 0;
+  time_t last_progress = 0;
+  time_t last_activity = 0;
+  time_t start = time(NULL);
+  bool use_sendfile = config->use_sendfile && !config->use_compression;
+  for (int i = 0; i < all_files->size; i++) {
+    File* file = (File*)all_files->items[i];
+    if (file->skip)
+      continue;
+    if (g_abort_requested) {
+      send_status(client->file_descriptor, STATUS_ABORT);
+      batch_ok = false;
       break;
     }
+    time_t now = time(NULL);
+    if (now - last_activity >= KEEPALIVE_INTERVAL) {
+      if (!send_status(client->file_descriptor, STATUS_KEEPALIVE)) {
+        batch_ok = false;
+        break;
+      }
+      Status s;
+      if (!receive_status(client->file_descriptor, &s)) {
+        batch_ok = false;
+        break;
+      }
+      last_activity = now;
+    }
+    int compression_level = config->use_compression ? config->compression_level : 0;
+    if (!send_status(client->file_descriptor, STATUS_NEXT)) {
+      batch_ok = false;
+      break;
+    }
+    if (use_sendfile) {
+      if (!file_send_sendfile(file, client->file_descriptor, config->use_metadata, 0, true)) {
+        log_message(LOG_LEVEL_ERROR, "Failed to send file via sendfile");
+        batch_ok = false;
+        break;
+      }
+    } else {
+      if (!file_load_data(file)) {
+        log_message(LOG_LEVEL_ERROR, "Failed to load file data");
+        continue;
+      }
+      if (!file_send_single_calls(file, client->file_descriptor, config->use_metadata,
+                                  compression_level, true)) {
+        log_message(LOG_LEVEL_ERROR, "Failed to send file");
+        batch_ok = false;
+        break;
+      }
+    }
+    total_bytes += file->data ? file->data->size : 0;
     if (config->show_progress) {
-      total_bytes += chunk_bytes;
-      time_t now = time(NULL);
       if (now - last_progress >= 1) {
         last_progress = now;
         double elapsed = difftime(now, start);
@@ -483,52 +580,69 @@ int send_files(Config* config) {
         fflush(stderr);
       }
     }
-    chunk_destroy(current_chunk);
   }
-  if (config->use_delete) {
-    if (send_delete_manifest(client->file_descriptor, manifest) != 0) {
-      array_list_delete(manifest);
-      goto send_fail;
+
+  if (batch_ok && config->use_delete && manifest) {
+    if (!send_status(client->file_descriptor, STATUS_MANIFEST))
+      batch_ok = false;
+    else if (!send_int(client->file_descriptor, manifest->size))
+      batch_ok = false;
+    else {
+      for (int i = 0; i < manifest->size && batch_ok; i++) {
+        if (!send_str(client->file_descriptor, (char*)manifest->items[i]))
+          batch_ok = false;
+      }
     }
-    array_list_delete(manifest);
   }
-  if (!send_status(client->file_descriptor, STATUS_FINISHED))
-    goto send_fail;
+  array_list_delete(manifest);
+
+  if (batch_ok && !send_status(client->file_descriptor, STATUS_FINISHED))
+    batch_ok = false;
   Status s;
-  int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
+  int ok = 0;
+  if (batch_ok)
+    ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
   if (config->show_progress) {
     double elapsed = difftime(time(NULL), start);
     double rate = elapsed > 0 ? total_bytes / (1048576.0 * elapsed) : 0;
     fprintf(stderr, "\rSent %.1f MB  (%.1f MB/s)  Done.\n", total_bytes / 1048576.0, rate);
   }
-  directory_scanner_destroy(scanner);
+  for (int i = 0; i < all_files->size; i++)
+    file_destroy(all_files->items[i]);
+  array_list_delete(all_files);
   client_disconnect(client);
   client_delete(client);
-  return ok ? 0 : 1;
-
-send_fail:
-  directory_scanner_destroy(scanner);
-  client_disconnect(client);
-  client_delete(client);
-  return 1;
+  return (batch_ok && ok) ? 0 : -1;
 }
 
 int send_files_multithreaded(Config* config) {
-  if (config->dry_run)
-    return send_dry_run_manifest(config);
-
-  long pages = sysconf(_SC_AVPHYS_PAGES);
-  long page_size = sysconf(_SC_PAGE_SIZE);
-  unsigned long long available_memory =
-      pages > 0 && page_size > 0 ? (unsigned long long)pages * (unsigned long long)page_size
-                                 : 512ULL * 1024 * 1024;
-  unsigned long long avg_file_size = 1024 * 1024;
-  int qsize = (int)(available_memory / avg_file_size);
-  if (qsize < 10)
-    qsize = 10;
-  if (qsize > 1000)
-    qsize = 1000;
+  time_t start_time = time(NULL);
+  if (config->dry_run) {
+    DirectoryScanner* scanner = directory_scanner_create(
+        config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
+        config->exclude_count, config->include_patterns, config->include_count, config->max_size,
+        config->min_size, config->max_depth);
+    Chunk* chunk;
+    int file_count = 0;
+    unsigned long long total_bytes = 0;
+    if (!config->quiet)
+      printf("Dry run: files to be transferred\n");
+    while ((chunk = directory_scanner_next(scanner)) != NULL) {
+      for (int i = 0; i < chunk->element_count; i++) {
+        if (!config->quiet)
+          printf("  %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
+        total_bytes += chunk->items[i]->data->size;
+        file_count++;
+      }
+      chunk_destroy(chunk);
+    }
+    directory_scanner_destroy(scanner);
+    if (!config->quiet)
+      printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
+    return 0;
+  }
 
+  int qsize = config->queue_size > 0 ? config->queue_size : 100;
   Queue* q1 = queue_create(qsize, chunk_destroy);
   Queue* q2 = queue_create(qsize, chunk_destroy);
   if (!q1 || !q2) {
@@ -561,6 +675,12 @@ int send_files_multithreaded(Config* config) {
   thrd_join(loader, NULL);
   thrd_join(sender, &sender_result);
 
+  if (config->stats && !config->quiet) {
+    double elapsed = difftime(time(NULL), start_time);
+    printf("\nTransfer statistics:\n");
+    printf("  Elapsed time: %.1f sec\n", elapsed);
+  }
+
   pipeline_context_sender_destroy(context);
-  return sender_result == thrd_success ? 0 : 1;
+  return sender_result == thrd_success ? 0 : -1;
 }

src/client/scanner.c

@@ -9,7 +9,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
-#include <threads.h>
 #include <unistd.h>
 
 typedef struct {
@@ -38,9 +37,7 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
                                            unsigned long long chunk_size, char** exclude_patterns,
                                            int exclude_count, char** include_patterns,
                                            int include_count, unsigned long long max_size,
-                                           unsigned long long min_size, int max_depth,
-                                           bool follow_symlinks, bool copy_links, bool safe_links,
-                                           bool copy_unsafe_links) {
+                                           unsigned long long min_size, int max_depth) {
   DirectoryScanner* scanner = malloc(sizeof(DirectoryScanner));
   if (scanner == NULL)
     return NULL;
@@ -57,10 +54,6 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
   scanner->min_size = min_size;
   scanner->max_depth = max_depth;
   scanner->current_depth = 0;
-  scanner->follow_symlinks = follow_symlinks;
-  scanner->copy_links = copy_links;
-  scanner->safe_links = safe_links;
-  scanner->copy_unsafe_links = copy_unsafe_links;
   queue_enqueue(scanner->directories, dir_entry_create(root_directory, 0));
   return scanner;
 }
@@ -86,6 +79,7 @@ static Chunk* chunk_data_to_chunk(ArrayList* chunk_data) {
   return chunk;
 }
 
+// Returns: 1 on success, 0 if no more directories in queue, -1 on opendir failure
 static int open_next_directory(DirectoryScanner* scanner) {
   if (scanner->current_dir) {
     closedir(scanner->current_dir);
@@ -137,67 +131,17 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
 
     char* cur_path = path_cat(scanner->current_path, entry->d_name);
     struct stat stats;
-    struct stat lstats;
-    bool is_symlink = false;
-    if (lstat(cur_path, &lstats) != 0) {
+    if (stat(cur_path, &stats) != 0) {
       free(cur_path);
       continue;
     }
-    is_symlink = S_ISLNK(lstats.st_mode);
-
-    if (is_symlink && !scanner->follow_symlinks && !scanner->copy_links && !scanner->safe_links &&
-        !scanner->copy_unsafe_links) {
-      free(cur_path);
-      continue;
-    }
-
-    if (is_symlink && scanner->safe_links) {
-      char link_target[4096];
-      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
-      if (len < 0) {
-        free(cur_path);
-        continue;
-      }
-      link_target[len] = '\0';
-      if (link_target[0] == '/') {
-        free(cur_path);
-        continue;
-      }
-    }
-
-    if (is_symlink && scanner->copy_unsafe_links && !scanner->copy_links) {
-      char link_target[4096];
-      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
-      if (len < 0) {
-        free(cur_path);
-        continue;
-      }
-      link_target[len] = '\0';
-      bool unsafe = (link_target[0] == '/');
-      if (!unsafe) {
-        free(cur_path);
-        continue;
-      }
-    }
-
-    bool use_lstat = is_symlink && scanner->follow_symlinks && !scanner->copy_links;
-    if (use_lstat) {
-      stats = lstats;
-    } else {
-      if (stat(cur_path, &stats) != 0) {
-        free(cur_path);
-        continue;
-      }
-    }
 
     if (S_ISDIR(stats.st_mode)) {
       int next_depth = scanner->current_depth + 1;
-      if (scanner->max_depth <= 0 || next_depth < scanner->max_depth) {
-        DirEntry* de = dir_entry_create(cur_path, next_depth);
-        if (!queue_enqueue(scanner->directories, de))
-          dir_entry_destroy(de);
-      }
-      free(cur_path);
+      if (scanner->max_depth <= 0 || next_depth < scanner->max_depth)
+        queue_enqueue(scanner->directories, dir_entry_create(cur_path, next_depth));
+      else
+        free(cur_path);
     } else {
       if (scanner->max_depth > 0 && scanner->current_depth + 1 > scanner->max_depth) {
         free(cur_path);
@@ -258,318 +202,3 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
   array_list_delete(chunk_data);
   return NULL;
 }
-
-typedef struct {
-  ParallelScanner* ps;
-  char** dirs;
-  int dir_count;
-  bool use_metadata;
-  unsigned long long chunk_size;
-  char** exclude_patterns;
-  int exclude_count;
-  char** include_patterns;
-  int include_count;
-  unsigned long long max_size;
-  unsigned long long min_size;
-  int max_depth;
-  bool follow_symlinks;
-  bool copy_links;
-  bool safe_links;
-  bool copy_unsafe_links;
-} ParallelWorkerArg;
-
-static int parallel_worker_thread(void* arg) {
-  ParallelWorkerArg* wa = (ParallelWorkerArg*)arg;
-  for (int i = 0; i < wa->dir_count; i++) {
-    DirectoryScanner* ds = directory_scanner_create(
-        wa->dirs[i], wa->use_metadata, wa->chunk_size, wa->exclude_patterns, wa->exclude_count,
-        wa->include_patterns, wa->include_count, wa->max_size, wa->min_size, wa->max_depth,
-        wa->follow_symlinks, wa->copy_links, wa->safe_links, wa->copy_unsafe_links);
-    Chunk* chunk;
-    while ((chunk = directory_scanner_next(ds)) != NULL) {
-      queue_enqueue_multithreaded(wa->ps->result_queue, chunk, &wa->ps->result_mutex,
-                                  &wa->ps->result_not_empty, &wa->ps->result_not_full);
-    }
-    directory_scanner_destroy(ds);
-    free(wa->dirs[i]);
-  }
-  ParallelScanner* ps = wa->ps;
-  free(wa->dirs);
-  free(wa);
-  mtx_lock(&ps->result_mutex);
-  ps->completed++;
-  if (ps->completed >= ps->num_threads) {
-    ps->done = true;
-    cnd_signal(&ps->result_not_empty);
-  }
-  mtx_unlock(&ps->result_mutex);
-  return thrd_success;
-}
-
-ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata,
-                                         unsigned long long chunk_size, char** exclude_patterns,
-                                         int exclude_count, char** include_patterns,
-                                         int include_count, unsigned long long max_size,
-                                         unsigned long long min_size, int max_depth,
-                                         int num_threads, bool follow_symlinks, bool copy_links,
-                                         bool safe_links, bool copy_unsafe_links) {
-  ParallelScanner* ps = calloc(1, sizeof(ParallelScanner));
-  if (!ps)
-    return NULL;
-  ps->result_queue = queue_create(100, chunk_destroy);
-  if (!ps->result_queue) {
-    free(ps);
-    return NULL;
-  }
-  if (mtx_init(&ps->result_mutex, mtx_plain) != thrd_success ||
-      cnd_init(&ps->result_not_empty) != thrd_success ||
-      cnd_init(&ps->result_not_full) != thrd_success) {
-    queue_destroy(ps->result_queue);
-    free(ps);
-    return NULL;
-  }
-
-  DIR* dir = opendir(root_directory);
-  if (!dir) {
-    perror("Could not open root directory for parallel scan");
-    parallel_scanner_destroy(ps);
-    return NULL;
-  }
-
-  ArrayList* root_files = array_list_create(file_destroy);
-  ArrayList* subdirs = array_list_create(free);
-  struct dirent* entry;
-  while ((entry = readdir(dir)) != NULL) {
-    if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
-      continue;
-    char* cur_path = path_cat(root_directory, entry->d_name);
-    if (!cur_path)
-      continue;
-    struct stat lstats;
-    if (lstat(cur_path, &lstats) != 0) {
-      free(cur_path);
-      continue;
-    }
-    bool is_symlink = S_ISLNK(lstats.st_mode);
-
-    // Skip symlinks unless the user explicitly enabled following/copying them.
-    if (is_symlink && !follow_symlinks && !copy_links && !safe_links &&
-        !copy_unsafe_links) {
-      free(cur_path);
-      continue;
-    }
-
-    // --safe-links: reject symlinks pointing outside the source tree.
-    if (is_symlink && safe_links) {
-      char link_target[4096];
-      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
-      if (len < 0) {
-        free(cur_path);
-        continue;
-      }
-      link_target[len] = '';
-      if (link_target[0] == '/') {
-        free(cur_path);
-        continue;
-      }
-    }
-
-    // --copy-unsafe-links (without --copy-links): only copy absolute symlinks.
-    if (is_symlink && copy_unsafe_links && !copy_links) {
-      char link_target[4096];
-      ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
-      if (len < 0) {
-        free(cur_path);
-        continue;
-      }
-      link_target[len] = '';
-      bool unsafe = (link_target[0] == '/');
-      if (!unsafe) {
-        free(cur_path);
-        continue;
-      }
-    }
-
-    // Determine whether to use lstat or stat results for the entry.
-    struct stat st;
-    bool use_lstat_res = is_symlink && follow_symlinks && !copy_links;
-    if (use_lstat_res) {
-      st = lstats;
-    } else {
-      if (stat(cur_path, &st) != 0) {
-        free(cur_path);
-        continue;
-      }
-    }
-
-    if (S_ISDIR(st.st_mode)) {
-      array_list_add(subdirs, cur_path);
-    } else {
-      bool excluded = false;
-      for (int i = 0; i < exclude_count; i++) {
-        if (glob_match(exclude_patterns[i], entry->d_name)) {
-          excluded = true;
-          break;
-        }
-      }
-      if (excluded) {
-        free(cur_path);
-        continue;
-      }
-      if (include_count > 0) {
-        bool included = false;
-        for (int i = 0; i < include_count; i++) {
-          if (glob_match(include_patterns[i], entry->d_name)) {
-            included = true;
-            break;
-          }
-        }
-        if (!included) {
-          free(cur_path);
-          continue;
-        }
-      }
-      if ((max_size > 0 && (unsigned long long)st.st_size > max_size) ||
-          (min_size > 0 && (unsigned long long)st.st_size < min_size)) {
-        free(cur_path);
-        continue;
-      }
-      File* file = file_create(cur_path);
-      free(cur_path);
-      if (!file)
-        continue;
-      file->data->size = st.st_size;
-      if (use_metadata)
-        file->metadata = file_metadata_create(&st);
-      array_list_add(root_files, file);
-    }
-  }
-  closedir(dir);
-
-  unsigned long long cs = chunk_size > 0 ? chunk_size : DESIRED_CHUNK_SIZE;
-  if (root_files->size > 0) {
-    ArrayList* batch = array_list_create(NULL);
-    unsigned long long batch_size = 0;
-    Chunk* first = NULL;
-    for (int i = 0; i < root_files->size; i++) {
-      File* f = (File*)root_files->items[i];
-      array_list_add(batch, f);
-      batch_size += f->data->size;
-      if (batch_size >= cs || i == root_files->size - 1) {
-        void** items = array_list_to_array(batch);
-        Chunk* c = chunk_create((File**)items, batch->size);
-        free(items);
-        batch->item_destroyer = NULL;
-        array_list_delete(batch);
-        batch = NULL;
-        if (!first) {
-          first = c;
-        } else {
-          queue_enqueue_multithreaded(ps->result_queue, c, &ps->result_mutex, &ps->result_not_empty,
-                                      &ps->result_not_full);
-        }
-        if (i < root_files->size - 1) {
-          batch = array_list_create(NULL);
-          batch_size = 0;
-        }
-      }
-    }
-    if (batch) {
-      batch->item_destroyer = NULL;
-      array_list_delete(batch);
-    }
-    ps->initial_chunk = first;
-    root_files->item_destroyer = NULL;
-  }
-  array_list_delete(root_files);
-
-  int n = num_threads > 0 ? num_threads : 4;
-  if (n > subdirs->size)
-    n = subdirs->size > 0 ? subdirs->size : 1;
-
-  if (subdirs->size > 0) {
-    ps->num_threads = n;
-    ps->threads = calloc(n, sizeof(thrd_t));
-    if (!ps->threads) {
-      array_list_delete(subdirs);
-      parallel_scanner_destroy(ps);
-      return NULL;
-    }
-    int dirs_per_thread = subdirs->size / n;
-    int remainder = subdirs->size % n;
-    int start = 0;
-    for (int t = 0; t < n; t++) {
-      int count = dirs_per_thread + (t < remainder ? 1 : 0);
-      if (count == 0)
-        break;
-      ParallelWorkerArg* wa = calloc(1, sizeof(ParallelWorkerArg));
-      if (!wa)
-        break;
-      wa->ps = ps;
-      wa->dirs = calloc(count, sizeof(char*));
-      if (!wa->dirs) {
-        free(wa);
-        break;
-      }
-      for (int j = 0; j < count; j++)
-        wa->dirs[j] = str_dup((char*)subdirs->items[start + j]);
-      wa->dir_count = count;
-      wa->use_metadata = use_metadata;
-      wa->chunk_size = cs;
-      wa->exclude_patterns = exclude_patterns;
-      wa->exclude_count = exclude_count;
-      wa->include_patterns = include_patterns;
-      wa->include_count = include_count;
-      wa->max_size = max_size;
-      wa->min_size = min_size;
-      wa->max_depth = max_depth;
-      wa->follow_symlinks = follow_symlinks;
-      wa->copy_links = copy_links;
-      wa->safe_links = safe_links;
-      wa->copy_unsafe_links = copy_unsafe_links;
-      start += count;
-      if (thrd_create(&ps->threads[t], parallel_worker_thread, wa) != thrd_success) {
-        for (int j = 0; j < count; j++)
-          free(wa->dirs[j]);
-        free(wa->dirs);
-        free(wa);
-        ps->num_threads = t;
-        break;
-      }
-    }
-  }
-  array_list_delete(subdirs);
-  return ps;
-}
-
-Chunk* parallel_scanner_next(ParallelScanner* ps) {
-  if (ps->initial_chunk) {
-    Chunk* c = ps->initial_chunk;
-    ps->initial_chunk = NULL;
-    return c;
-  }
-  if (ps->num_threads == 0) {
-    ps->done = true;
-    return NULL;
-  }
-  Chunk* chunk = queue_dequeue_multithreaded(
-      ps->result_queue, &ps->result_mutex, &ps->result_not_empty, &ps->result_not_full, &ps->done);
-  return chunk;
-}
-
-void parallel_scanner_destroy(ParallelScanner* ps) {
-  if (!ps)
-    return;
-  ps->done = true;
-  cnd_signal(&ps->result_not_empty);
-  for (int i = 0; i < ps->num_threads; i++)
-    thrd_join(ps->threads[i], NULL);
-  free(ps->threads);
-  if (ps->initial_chunk)
-    chunk_destroy(ps->initial_chunk);
-  queue_destroy(ps->result_queue);
-  mtx_destroy(&ps->result_mutex);
-  cnd_destroy(&ps->result_not_empty);
-  cnd_destroy(&ps->result_not_full);
-  free(ps);
-}

src/client/scanner.h

@@ -5,7 +5,6 @@
 #include "queue.h"
 #include <dirent.h>
 #include <stdbool.h>
-#include <threads.h>
 
 typedef struct {
   Queue* directories;
@@ -21,42 +20,14 @@ typedef struct {
   unsigned long long min_size;
   int max_depth;
   int current_depth;
-  bool follow_symlinks;
-  bool copy_links;
-  bool safe_links;
-  bool copy_unsafe_links;
 } DirectoryScanner;
 
-typedef struct {
-  Queue* result_queue;
-  mtx_t result_mutex;
-  cnd_t result_not_empty;
-  cnd_t result_not_full;
-  int num_threads;
-  thrd_t* threads;
-  bool done;
-  int completed;
-  Chunk* initial_chunk;
-} ParallelScanner;
-
 DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_metadata,
                                            unsigned long long chunk_size, char** exclude_patterns,
                                            int exclude_count, char** include_patterns,
                                            int include_count, unsigned long long max_size,
-                                           unsigned long long min_size, int max_depth,
-                                           bool follow_symlinks, bool copy_links, bool safe_links,
-                                           bool copy_unsafe_links);
+                                           unsigned long long min_size, int max_depth);
 Chunk* directory_scanner_next(DirectoryScanner* scanner);
 void directory_scanner_destroy(DirectoryScanner* scanner);
 
-ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata,
-                                         unsigned long long chunk_size, char** exclude_patterns,
-                                         int exclude_count, char** include_patterns,
-                                         int include_count, unsigned long long max_size,
-                                         unsigned long long min_size, int max_depth,
-                                         int num_threads, bool follow_symlinks, bool copy_links,
-                                         bool safe_links, bool copy_unsafe_links);
-Chunk* parallel_scanner_next(ParallelScanner* scanner);
-void parallel_scanner_destroy(ParallelScanner* scanner);
-
 #endif

src/server/server.c

@@ -69,7 +69,7 @@ int receive_files(Config* config, int fd) {
         }
         char* full_path = path_cat(config->receive_root_directory, check_path);
         struct stat st;
-        bool has_old = full_path && lstat(full_path, &st) == 0;
+        bool has_old = full_path && stat(full_path, &st) == 0;
         bool match = has_old && (unsigned long long)st.st_size == check_size &&
                      (long long)st.st_mtime == check_mtime;
         if (match)
@@ -112,7 +112,6 @@ int receive_files(Config* config, int fd) {
 }
 
 void handler(int file_descriptor) {
-  SSL* ssl = io_get_ssl();
   Config* config = config_receive(file_descriptor);
   if (config == NULL) {
     log_message(LOG_LEVEL_ERROR, "Failed to receive config");
@@ -126,8 +125,7 @@ void handler(int file_descriptor) {
       close(file_descriptor);
       return;
     }
-    PipelineContextReceiver* context =
-        pipeline_context_receiver_create(config, q, file_descriptor, ssl);
+    PipelineContextReceiver* context = pipeline_context_receiver_create(config, q, file_descriptor);
     if (context == NULL) {
       queue_destroy(q);
       config_delete(config);
@@ -146,14 +144,11 @@ void handler(int file_descriptor) {
     thrd_join(writer, NULL);
     send_status(file_descriptor, STATUS_OK);
     pipeline_context_receiver_destroy(context);
-  } else {
+  } else
     receive_files(config, file_descriptor);
-    config_delete(config);
-  }
   close(file_descriptor);
 }
 
-#ifndef FASTSYNC_SERVER_AS_LIB
 static Server* g_server = NULL;
 
 static void cleanup(int sig) {
@@ -249,4 +244,3 @@ int main(int argc, char* argv[]) {
   }
   return 0;
 }
-#endif /* !FASTSYNC_SERVER_AS_LIB */

src/shared/chunk.c

@@ -12,9 +12,6 @@
 #include "metadata.h"
 #include "protocol.h"
 
-/* Maximum individual file data size within a chunk (64 MB) */
-#define MAX_FILE_DATA_SIZE (64ULL * 1024 * 1024)
-
 Chunk* chunk_create(File** items, int element_count) {
   Chunk* chunk = (Chunk*)malloc(sizeof(Chunk));
   if (chunk == NULL) {
@@ -160,14 +157,6 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
       return NULL;
     }
 
-    // Reject individual file data larger than the maximum allowed size.
-    if (file_data_size > MAX_FILE_DATA_SIZE) {
-      log_message(LOG_LEVEL_ERROR, "File data size %zu exceeds maximum %llu",
-                  file_data_size, (unsigned long long)MAX_FILE_DATA_SIZE);
-      array_list_delete(files);
-      return NULL;
-    }
-
     void* file_data = malloc(file_data_size);
     if (file_data == NULL) {
       perror("Could not allocate memory for file data");
@@ -221,15 +210,6 @@ Chunk* receive_chunk_data(int fd, const Config* config) {
       return NULL;
     }
   }
-
-  // Reject chunks larger than the maximum allowed size to prevent OOM.
-  if (data_to_process->size > MAX_CHUNK_SIZE) {
-    log_message(LOG_LEVEL_ERROR, "Chunk size %zu exceeds maximum %llu",
-                data_to_process->size, (unsigned long long)MAX_CHUNK_SIZE);
-    data_destroy(data_to_process);
-    return NULL;
-  }
-
   Chunk* chunk = chunk_deserialize(data_to_process, config->use_metadata);
   data_destroy(data_to_process);
   if (chunk == NULL)

src/shared/compression.c

@@ -2,28 +2,10 @@
 #include "data.h"
 #include "log.h"
 #include "stdlib.h"
-#include "string.h"
-#include <strings.h>
 #include "zstd.h"
 
 #define INITIAL_DECOMPRESS_BUF_SIZE (1024 * 1024)
 
-static const char* SKIP_COMPRESSION_EXTENSIONS[] = {".jpg", ".jpeg", ".png", ".gif", ".mp4", ".mkv",
-                                                    ".zip", ".gz",   ".xz",  ".zst", NULL};
-
-bool compression_should_skip(const char* path) {
-  if (!path)
-    return false;
-  const char* dot = strrchr(path, '.');
-  if (!dot)
-    return false;
-  for (int i = 0; SKIP_COMPRESSION_EXTENSIONS[i]; i++) {
-    if (strcasecmp(dot, SKIP_COMPRESSION_EXTENSIONS[i]) == 0)
-      return true;
-  }
-  return false;
-}
-
 Data* data_compress(Data* data_to_compress, int compression_level) {
   log_message(LOG_LEVEL_DEBUG, "Starting to compress data");
   size_t dst_size = ZSTD_compressBound(data_to_compress->size);
@@ -78,21 +60,14 @@ Data* data_decompress(Data* compressed_data) {
     return NULL;
   }
 
-  // ZSTD_CONTENTSIZE_UNKNOWN (~2^64) can cause massive allocation;
-  // fall back to a conservative estimate (3x compressed size) when unknown.
-  if (dst_size == ZSTD_CONTENTSIZE_UNKNOWN) {
-    dst_size = compressed_data->size * 3;
-    if (dst_size < INITIAL_DECOMPRESS_BUF_SIZE)
-      dst_size = INITIAL_DECOMPRESS_BUF_SIZE;
-  }
-
   ZSTD_DCtx* dctx = ZSTD_createDCtx();
   if (!dctx) {
     log_message(LOG_LEVEL_ERROR, "Failed to create ZSTD decompression context");
     return NULL;
   }
 
-  size_t buf_size = (dst_size > 0) ? (size_t)dst_size : INITIAL_DECOMPRESS_BUF_SIZE;
+  size_t buf_size =
+      (!ZSTD_isError(dst_size) && dst_size > 0) ? (size_t)dst_size : INITIAL_DECOMPRESS_BUF_SIZE;
   Data* uncompressed_data = data_create_empty(buf_size);
   if (!uncompressed_data) {
     log_message(LOG_LEVEL_ERROR, "Failed to allocate decompression buffer");

src/shared/compression.h

@@ -2,10 +2,8 @@
 #define COMPRESSION_H
 
 #include "data.h"
-#include <stdbool.h>
 
 Data* data_compress(Data* data_to_compress, int compression_level);
 Data* data_decompress(Data* compressed_data);
-bool compression_should_skip(const char* path);
 
 #endif

src/shared/config.c

@@ -8,28 +8,29 @@
 #include <stdlib.h>
 #include <string.h>
 
-Config* config_create(void) {
+Config* config_create(char* version, char* send_directory, char* receive_directory,
+                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
+                      bool use_compression, bool use_metadata, int compression_level,
+                      bool use_sendfile, unsigned long long chunk_size) {
+
   Config* config = malloc(sizeof(Config));
-  if (!config)
-    return NULL;
-  config->version = str_dup(PROTOCOL_VERSION);
-  config->send_directory = NULL;
-  config->receive_root_directory = NULL;
-  config->save_to_disk = false;
-  config->use_multithreading = false;
-  config->use_chunk_serialization = false;
-  config->use_compression = false;
-  config->use_metadata = false;
+  config->version = version;
+  config->send_directory = send_directory;
+  config->receive_root_directory = receive_directory;
+  config->save_to_disk = save_to_disk;
+  config->use_multithreading = use_multithreading;
+  config->use_chunk_serialization = use_chunk_serialization;
+  config->use_compression = use_compression;
+  config->use_metadata = use_metadata;
   config->show_progress = false;
   config->dry_run = false;
   config->use_delete = false;
-  config->compression_level = 5;
-  config->use_sendfile = false;
-  config->chunk_size = DEFAULT_CHUNK_SIZE;
+  config->compression_level = compression_level;
+  config->use_sendfile = use_sendfile;
+  config->chunk_size = chunk_size > 0 ? chunk_size : DEFAULT_CHUNK_SIZE;
   config->ssh_port = 22;
   config->transport = TRANSPORT_TCP;
   config->ssh_destination = NULL;
-  config->fastsync_server_path = NULL;
   config->exclude_patterns = NULL;
   config->exclude_count = 0;
   config->include_patterns = NULL;
@@ -55,40 +56,6 @@ Config* config_create(void) {
   config->max_depth = 0;
   config->log_file = NULL;
   config->queue_size = 100;
-  config->follow_symlinks = false;
-  config->partial = false;
-  config->copy_links = false;
-  config->safe_links = false;
-  config->copy_unsafe_links = false;
-  config->preserve_hard_links = false;
-  config->preserve_acls = false;
-  config->preserve_xattrs = false;
-  config->preserve_devices = false;
-  config->preserve_sparse = false;
-  config->itemize_changes = false;
-  config->out_format = NULL;
-  config->info_level = 0;
-  config->debug_level = 0;
-  config->list_only = false;
-  config->human_readable = false;
-  config->update = false;
-  config->inplace = false;
-  config->append = false;
-  config->append_verify = false;
-  config->delete_excluded = false;
-  config->delete_after = false;
-  config->max_delete = 0;
-  config->filters = NULL;
-  config->files_from = NULL;
-  config->cvs_exclude = false;
-  config->prune_empty_dirs = false;
-  config->relative = false;
-  config->rsh_command = NULL;
-  config->rsync_path = NULL;
-  config->temp_dir = NULL;
-  config->compare_dest = NULL;
-  config->copy_dest = NULL;
-  config->link_dest = NULL;
   return config;
 }
 
@@ -123,7 +90,6 @@ void config_delete(Config* config) {
   free(config->send_directory);
   free(config->receive_root_directory);
   free(config->ssh_destination);
-  free(config->fastsync_server_path);
   for (int i = 0; i < config->exclude_count; i++)
     free(config->exclude_patterns[i]);
   free(config->exclude_patterns);
@@ -135,17 +101,6 @@ void config_delete(Config* config) {
   free(config->tls_ca);
   free(config->backup_dir);
   free(config->server_host);
-  free(config->out_format);
-  free(config->files_from);
-  free(config->rsh_command);
-  free(config->rsync_path);
-  free(config->temp_dir);
-  free(config->compare_dest);
-  free(config->copy_dest);
-  free(config->link_dest);
-  if (config->filters) {
-    array_list_delete(config->filters);
-  }
   free(config);
 }
 
@@ -186,44 +141,6 @@ bool config_send(int file_descriptor, const Config* config) {
     return false;
   if (!send_str(file_descriptor, config->backup_dir ? config->backup_dir : ""))
     return false;
-  if (!send_int(file_descriptor, config->follow_symlinks))
-    return false;
-  if (!send_int(file_descriptor, config->copy_links))
-    return false;
-  if (!send_int(file_descriptor, config->safe_links))
-    return false;
-  if (!send_int(file_descriptor, config->copy_unsafe_links))
-    return false;
-  if (!send_int(file_descriptor, config->preserve_hard_links))
-    return false;
-  if (!send_int(file_descriptor, config->preserve_acls))
-    return false;
-  if (!send_int(file_descriptor, config->preserve_xattrs))
-    return false;
-  if (!send_int(file_descriptor, config->preserve_devices))
-    return false;
-  if (!send_int(file_descriptor, config->preserve_sparse))
-    return false;
-  if (!send_int(file_descriptor, config->update))
-    return false;
-  if (!send_int(file_descriptor, config->inplace))
-    return false;
-  if (!send_int(file_descriptor, config->append))
-    return false;
-  if (!send_int(file_descriptor, config->append_verify))
-    return false;
-  if (!send_int(file_descriptor, config->delete_excluded))
-    return false;
-  if (!send_int(file_descriptor, config->delete_after))
-    return false;
-  if (!send_n_data(file_descriptor, &config->max_delete, sizeof(config->max_delete)))
-    return false;
-  if (!send_int(file_descriptor, config->relative))
-    return false;
-  if (!send_int(file_descriptor, config->prune_empty_dirs))
-    return false;
-  if (!send_str(file_descriptor, config->temp_dir ? config->temp_dir : ""))
-    return false;
   Status status;
   if (!receive_status(file_descriptor, &status))
     return false;
@@ -308,7 +225,6 @@ Config* config_receive(int file_descriptor) {
   config->ssh_port = 22;
   config->transport = TRANSPORT_TCP;
   config->ssh_destination = NULL;
-  config->fastsync_server_path = NULL;
   config->exclude_patterns = NULL;
   config->exclude_count = 0;
   config->include_patterns = NULL;
@@ -326,101 +242,12 @@ Config* config_receive(int file_descriptor) {
   config->max_depth = 0;
   config->log_file = NULL;
   config->queue_size = 100;
-  config->follow_symlinks = false;
-  config->copy_links = false;
-  config->safe_links = false;
-  config->copy_unsafe_links = false;
-  config->preserve_hard_links = false;
-  config->preserve_acls = false;
-  config->preserve_xattrs = false;
-  config->preserve_devices = false;
-  config->preserve_sparse = false;
-  config->itemize_changes = false;
-  config->out_format = NULL;
-  config->info_level = 0;
-  config->debug_level = 0;
-  config->list_only = false;
-  config->human_readable = false;
-  config->update = false;
-  config->inplace = false;
-  config->append = false;
-  config->append_verify = false;
-  config->delete_excluded = false;
-  config->delete_after = false;
-  config->max_delete = 0;
-  config->filters = NULL;
-  config->files_from = NULL;
-  config->cvs_exclude = false;
-  config->prune_empty_dirs = false;
-  config->relative = false;
-  config->rsh_command = NULL;
-  config->rsync_path = NULL;
-  config->temp_dir = NULL;
-  config->compare_dest = NULL;
-  config->copy_dest = NULL;
-  config->link_dest = NULL;
   if (!receive_int(file_descriptor, &tmp))
     goto error;
   config->backup = tmp;
   config->backup_dir = receive_str(file_descriptor);
   if (config->backup_dir == NULL)
     goto error;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->follow_symlinks = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->copy_links = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->safe_links = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->copy_unsafe_links = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->preserve_hard_links = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->preserve_acls = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->preserve_xattrs = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->preserve_devices = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->preserve_sparse = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->update = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->inplace = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->append = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->append_verify = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->delete_excluded = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->delete_after = tmp;
-  if (!receive_n_data(file_descriptor, &config->max_delete, sizeof(config->max_delete)))
-    goto error;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->relative = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->prune_empty_dirs = tmp;
-  config->temp_dir = receive_str(file_descriptor);
-  if (config->temp_dir == NULL)
-    goto error;
   config->server_host = str_dup("127.0.0.1");
   config->server_port = 8080;
   if (!send_status(file_descriptor, STATUS_OK))
@@ -432,8 +259,6 @@ error:
   free(config->send_directory);
   free(config->receive_root_directory);
   free(config->server_host);
-  free(config->backup_dir);
-  free(config->temp_dir);
   free(config);
   return NULL;
 }

src/shared/config.h

@@ -1,7 +1,6 @@
 #ifndef CONFIG_H
 #define CONFIG_H
 
-#include "array_list.h"
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdio.h>
@@ -26,7 +25,6 @@ typedef struct Config {
   int ssh_port;
   TransportType transport;
   char* ssh_destination;
-  char* fastsync_server_path;
   char** exclude_patterns;
   int exclude_count;
   char** include_patterns;
@@ -52,60 +50,15 @@ typedef struct Config {
   int max_depth;
   FILE* log_file;
   int queue_size;
-  bool follow_symlinks;
-  bool partial;
-
-  // Issue #120: Symlink handling
-  bool copy_links;
-  bool safe_links;
-  bool copy_unsafe_links;
-
-  // Issue #121: Extended metadata preservation
-  bool preserve_hard_links;
-  bool preserve_acls;
-  bool preserve_xattrs;
-  bool preserve_devices;
-  bool preserve_sparse;
-
-  // Issue #122: Output/logging options
-  bool itemize_changes;
-  char* out_format;
-  int info_level;
-  int debug_level;
-  bool list_only;
-  bool human_readable;
-
-  // Issue #127: Transfer modes
-  bool update;
-  bool inplace;
-  bool append;
-  bool append_verify;
-
-  // Issue #128: Extended delete options
-  bool delete_excluded;
-  bool delete_after;
-  int max_delete;
-
-  // Issue #129: Advanced file selection
-  ArrayList* filters;
-  char* files_from;
-  bool cvs_exclude;
-  bool prune_empty_dirs;
-  bool relative;
-
-  // Issue #130: Remote shell/connection options
-  char* rsh_command;
-  char* rsync_path;
-  char* temp_dir;
-  char* compare_dest;
-  char* copy_dest;
-  char* link_dest;
 } Config;
 
 #define PROTOCOL_VERSION "1.3.0"
 #define DEFAULT_CHUNK_SIZE (10 * 1024 * 1024)
 
-Config* config_create(void);
+Config* config_create(char* version, char* send_directory, char* receive_directory,
+                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
+                      bool use_compression, bool use_metadata, int compression_level,
+                      bool use_sendfile, unsigned long long chunk_size);
 void config_delete(Config* config);
 bool config_send(int file_descriptor, const Config* config);
 Config* config_receive(int file_descriptor);

src/shared/data.c

@@ -1,11 +1,9 @@
 #include "data.h"
 #include "log.h"
-#include <stdlib.h>
+#include "stdlib.h"
 
 Data* data_create_empty(size_t data_size) {
-  /* malloc(0) is UB; allocate at least 1 byte but preserve requested size */
-  size_t alloc_size = data_size > 0 ? data_size : 1;
-  void* data = malloc(alloc_size);
+  void* data = malloc(data_size);
   if (data == NULL) {
     log_message(LOG_LEVEL_ERROR, "Could not allocate memory for empty data");
     return NULL;

src/shared/data.h

@@ -1,7 +1,7 @@
 #ifndef DATA_H
 #define DATA_H
 
-#include <stdlib.h>
+#include "stdlib.h"
 
 typedef struct {
   void* data;

src/shared/delta.c

@@ -1,6 +1,5 @@
 #include "delta.h"
 #include "log.h"
-#include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -8,10 +7,6 @@
 #define XXH_IMPLEMENTATION
 #include <xxhash.h>
 
-/* Maximum number of blocks/instructions allowed from the wire to prevent OOM */
-#define MAX_DELTA_BLOCKS (1024U * 1024U)       /* 1M signature blocks */
-#define MAX_DELTA_INSTRUCTIONS (1024U * 1024U) /* 1M delta instructions */
-
 uint32_t delta_adler32(const void* data, uint32_t len) {
   const uint8_t* p = (const uint8_t*)data;
   uint32_t s1 = 1;
@@ -106,14 +101,6 @@ DeltaSignature* delta_signature_deserialize(const Data* data) {
   memcpy(&sig->block_count, buf + pos, sizeof(uint32_t));
   pos += sizeof(uint32_t);
 
-  // Reject unreasonably large block counts to prevent OOM
-  if (sig->block_count > MAX_DELTA_BLOCKS) {
-    log_message(LOG_LEVEL_ERROR, "Delta signature block count %u exceeds maximum %u",
-                sig->block_count, MAX_DELTA_BLOCKS);
-    free(sig);
-    return NULL;
-  }
-
   uint64_t expected = sizeof(uint64_t) + sizeof(uint32_t) + sizeof(uint32_t) +
                       (uint64_t)sig->block_count * (sizeof(uint32_t) + sizeof(uint32_t));
   if (data->size < expected) {
@@ -353,14 +340,6 @@ Delta* delta_deserialize(const Data* data) {
   memcpy(&delta->instruction_count, buf + pos, sizeof(uint32_t));
   pos += sizeof(uint32_t);
 
-  // Reject unreasonably large instruction counts to prevent OOM
-  if (delta->instruction_count > MAX_DELTA_INSTRUCTIONS) {
-    log_message(LOG_LEVEL_ERROR, "Delta instruction count %u exceeds maximum %u",
-                delta->instruction_count, MAX_DELTA_INSTRUCTIONS);
-    free(delta);
-    return NULL;
-  }
-
   delta->instructions = malloc(delta->instruction_count * sizeof(DeltaInstruction));
   if (!delta->instructions) {
     free(delta);

src/shared/file.c

@@ -104,7 +104,7 @@ bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
                             int compression_level, bool send_path) {
   const Data* data_to_send = file->data;
   Data* compressed_data = NULL;
-  if (compression_level > 0 && !compression_should_skip(file->path)) {
+  if (compression_level > 0) {
     compressed_data = data_compress(file->data, compression_level);
     if (compressed_data == NULL) {
       log_message(LOG_LEVEL_ERROR, "Failed to compress file data");
@@ -134,65 +134,9 @@ bool file_save_to_disk(const char* root_directory, File* file, const Config* con
     log_message(LOG_LEVEL_ERROR, "Path traversal detected in file path: %s", file->path);
     return false;
   }
-
-  // Resolve the destination root to its real path, preventing symlink-based escapes.
-  // If the root does not yet exist, try to create it so realpath can succeed.
-  char* resolved_root = realpath(root_directory, NULL);
-  if (resolved_root == NULL) {
-    if (mkdir_r(root_directory)) {
-      resolved_root = realpath(root_directory, NULL);
-    }
-  }
-  if (resolved_root == NULL) {
-    log_message(LOG_LEVEL_ERROR, "Failed to resolve destination root: %s", root_directory);
+  char* disk_path = path_cat((char*)root_directory, file->path);
+  if (disk_path == NULL)
     return false;
-  }
-
-  char* disk_path = path_cat(resolved_root, file->path);
-  if (disk_path == NULL) {
-    free(resolved_root);
-    return false;
-  }
-
-  // Ensure the target directory exists so the parent can be resolved for path safety.
-  char* dir_dup = str_dup(disk_path);
-  if (!dir_dup) {
-    free(resolved_root);
-    free(disk_path);
-    return false;
-  }
-  char* dir_str = dirname(dir_dup);
-  // Create the directory if needed (no-op if it already exists) so realpath can resolve it.
-  if (!mkdir_r(dir_str)) {
-    free(dir_dup);
-    free(resolved_root);
-    free(disk_path);
-    return false;
-  }
-  char* resolved_dir = realpath(dir_str, NULL);
-  free(dir_dup);
-  if (resolved_dir == NULL) {
-    log_message(LOG_LEVEL_ERROR, "Failed to resolve directory for: %s", disk_path);
-    free(resolved_root);
-    free(disk_path);
-    return false;
-  }
-
-  // Verify that the resolved directory is inside the resolved root.
-  // Both are canonical absolute paths — this prevents symlink-based escapes.
-  size_t root_len = strlen(resolved_root);
-  if (strncmp(resolved_dir, resolved_root, root_len) != 0 ||
-      (resolved_dir[root_len] != '\0' && resolved_dir[root_len] != '/')) {
-    log_message(LOG_LEVEL_ERROR, "Path escape detected: %s is outside %s", disk_path,
-                root_directory);
-    free(resolved_dir);
-    free(resolved_root);
-    free(disk_path);
-    return false;
-  }
-  free(resolved_dir);
-  free(resolved_root);
-
   bool ok = to_disk(disk_path, file->data->data, file->data->size);
   if (ok)
     file_restore_metadata(disk_path, file->metadata);
@@ -397,7 +341,7 @@ File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
 
   char* full_path = path_cat(config->receive_root_directory, check_path);
   struct stat st;
-  bool has_old_file = (full_path && lstat(full_path, &st) == 0);
+  bool has_old_file = (full_path && stat(full_path, &st) == 0);
   unsigned long long old_size = has_old_file ? (unsigned long long)st.st_size : 0;
 
   bool match = has_old_file && (unsigned long long)st.st_size == check_size &&
@@ -566,8 +510,6 @@ bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int
   while ((unsigned long long)offset < file_size) {
     ssize_t sent = sendfile(file_descriptor, fd, &offset, file_size - offset);
     if (sent == -1) {
-      if (errno == EAGAIN || errno == EINTR)
-        continue;
       perror("sendfile failed");
       close(fd);
       return false;

src/shared/file.h

@@ -6,8 +6,6 @@
 #include <stdbool.h>
 #include <sys/stat.h>
 
-typedef enum { FILE_TYPE_REGULAR, FILE_TYPE_SYMLINK, FILE_TYPE_DIR } FileType;
-
 typedef struct {
   mode_t mode;
   uid_t uid;

src/shared/log.c

@@ -15,7 +15,7 @@ void log_set_file(FILE* fp) {
   log_fp = fp;
 }
 
-void log_message(LogLevel log_level, const char* format, ...) {
+void log_message(LogLevel log_level, char* format, ...) {
   if (log_level < current_log_level)
     return;
   time_t now = time(NULL);

src/shared/log.h

@@ -5,7 +5,7 @@
 
 typedef enum { LOG_LEVEL_DEBUG, LOG_LEVEL_INFO, LOG_LEVEL_WARNING, LOG_LEVEL_ERROR } LogLevel;
 
-void log_message(LogLevel log_level, const char* message, ...);
+void log_message(LogLevel log_level, char* message, ...);
 void set_log_level(LogLevel level);
 void log_set_file(FILE* fp);
 

src/shared/metadata.c

@@ -4,103 +4,67 @@
 #include "protocol.h"
 #include <errno.h>
 #include <fcntl.h>
-#include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
 #include <time.h>
 #include <unistd.h>
 
-/*
- * Wire format serialization (protocol version 2.0.0+):
- * All metadata fields are serialized as fixed-width integers (int32_t / int64_t)
- * to ensure cross-platform binary compatiblity.  See metadata.h for the
- * exact wire layout.
- *
- * Compile-time assertions verify that the native platform types fit within
- * the chosen fixed-width representations.
- */
-typedef char static_assert_mode_t_fits[(sizeof(mode_t) <= sizeof(int32_t)) ? 1 : -1];
-typedef char static_assert_uid_t_fits[(sizeof(uid_t) <= sizeof(int32_t)) ? 1 : -1];
-typedef char static_assert_gid_t_fits[(sizeof(gid_t) <= sizeof(int32_t)) ? 1 : -1];
-
 void metadata_to_buf(char** buf, const FileMetadata* m) {
-  int32_t present = (m != NULL) ? 1 : 0;
-  memcpy(*buf, &present, sizeof(present));
-  *buf += sizeof(present);
+  int present = (m != NULL) ? 1 : 0;
+  memcpy(*buf, &present, sizeof(int));
+  *buf += sizeof(int);
   if (m == NULL)
     return;
-  int32_t mode = (int32_t)m->mode;
-  memcpy(*buf, &mode, sizeof(mode));
-  *buf += sizeof(mode);
-  int32_t uid = (int32_t)m->uid;
-  memcpy(*buf, &uid, sizeof(uid));
-  *buf += sizeof(uid);
-  int32_t gid = (int32_t)m->gid;
-  memcpy(*buf, &gid, sizeof(gid));
-  *buf += sizeof(gid);
-  int64_t mtime_sec = (int64_t)m->mtime_sec;
-  memcpy(*buf, &mtime_sec, sizeof(mtime_sec));
-  *buf += sizeof(mtime_sec);
-  int64_t mtime_nsec = (int64_t)m->mtime_nsec;
-  memcpy(*buf, &mtime_nsec, sizeof(mtime_nsec));
-  *buf += sizeof(mtime_nsec);
+  memcpy(*buf, &m->mode, sizeof(mode_t));
+  *buf += sizeof(mode_t);
+  memcpy(*buf, &m->uid, sizeof(uid_t));
+  *buf += sizeof(uid_t);
+  memcpy(*buf, &m->gid, sizeof(gid_t));
+  *buf += sizeof(gid_t);
+  memcpy(*buf, &m->mtime_sec, sizeof(time_t));
+  *buf += sizeof(time_t);
+  memcpy(*buf, &m->mtime_nsec, sizeof(long));
+  *buf += sizeof(long);
 }
 
 FileMetadata* metadata_from_buf(char** buf) {
-  int32_t present;
-  memcpy(&present, *buf, sizeof(present));
-  *buf += sizeof(present);
+  int present;
+  memcpy(&present, *buf, sizeof(int));
+  *buf += sizeof(int);
   if (!present)
     return NULL;
   FileMetadata* m = malloc(sizeof(FileMetadata));
-  if (m == NULL)
-    return NULL;
-  int32_t mode;
-  memcpy(&mode, *buf, sizeof(mode));
-  *buf += sizeof(mode);
-  m->mode = (mode_t)mode;
-  int32_t uid;
-  memcpy(&uid, *buf, sizeof(uid));
-  *buf += sizeof(uid);
-  m->uid = (uid_t)uid;
-  int32_t gid;
-  memcpy(&gid, *buf, sizeof(gid));
-  *buf += sizeof(gid);
-  m->gid = (gid_t)gid;
-  int64_t mtime_sec;
-  memcpy(&mtime_sec, *buf, sizeof(mtime_sec));
-  *buf += sizeof(mtime_sec);
-  m->mtime_sec = (time_t)mtime_sec;
-  int64_t mtime_nsec;
-  memcpy(&mtime_nsec, *buf, sizeof(mtime_nsec));
-  *buf += sizeof(mtime_nsec);
-  m->mtime_nsec = (long)mtime_nsec;
+  memcpy(&m->mode, *buf, sizeof(mode_t));
+  *buf += sizeof(mode_t);
+  memcpy(&m->uid, *buf, sizeof(uid_t));
+  *buf += sizeof(uid_t);
+  memcpy(&m->gid, *buf, sizeof(gid_t));
+  *buf += sizeof(gid_t);
+  memcpy(&m->mtime_sec, *buf, sizeof(time_t));
+  *buf += sizeof(time_t);
+  memcpy(&m->mtime_nsec, *buf, sizeof(long));
+  *buf += sizeof(long);
   return m;
 }
 
 bool metadata_send(int file_descriptor, FileMetadata* m) {
   if (m == NULL) {
-    int32_t zero = 0;
-    return send_n_data(file_descriptor, &zero, sizeof(zero));
+    int zero = 0;
+    return send_n_data(file_descriptor, &zero, sizeof(int));
   }
-  int32_t present = 1;
-  int32_t mode = (int32_t)m->mode;
-  int32_t uid = (int32_t)m->uid;
-  int32_t gid = (int32_t)m->gid;
-  int64_t mtime_sec = (int64_t)m->mtime_sec;
-  int64_t mtime_nsec = (int64_t)m->mtime_nsec;
-  return send_n_data(file_descriptor, &present, sizeof(present)) &&
-         send_n_data(file_descriptor, &mode, sizeof(mode)) &&
-         send_n_data(file_descriptor, &uid, sizeof(uid)) &&
-         send_n_data(file_descriptor, &gid, sizeof(gid)) &&
-         send_n_data(file_descriptor, &mtime_sec, sizeof(mtime_sec)) &&
-         send_n_data(file_descriptor, &mtime_nsec, sizeof(mtime_nsec));
+  int present = 1;
+  return send_n_data(file_descriptor, &present, sizeof(int)) &&
+         send_n_data(file_descriptor, &m->mode, sizeof(mode_t)) &&
+         send_n_data(file_descriptor, &m->uid, sizeof(uid_t)) &&
+         send_n_data(file_descriptor, &m->gid, sizeof(gid_t)) &&
+         send_n_data(file_descriptor, &m->mtime_sec, sizeof(time_t)) &&
+         send_n_data(file_descriptor, &m->mtime_nsec, sizeof(long));
 }
 
 FileMetadata* metadata_receive(int file_descriptor, int* ok) {
-  int32_t present;
-  if (!receive_n_data(file_descriptor, &present, sizeof(present))) {
+  int present;
+  if (!receive_n_data(file_descriptor, &present, sizeof(int))) {
     if (ok)
       *ok = 0;
     return NULL;
@@ -116,46 +80,16 @@ FileMetadata* metadata_receive(int file_descriptor, int* ok) {
       *ok = 0;
     return NULL;
   }
-  int32_t mode;
-  if (!receive_n_data(file_descriptor, &mode, sizeof(mode))) {
+  if (!receive_n_data(file_descriptor, &m->mode, sizeof(mode_t)) ||
+      !receive_n_data(file_descriptor, &m->uid, sizeof(uid_t)) ||
+      !receive_n_data(file_descriptor, &m->gid, sizeof(gid_t)) ||
+      !receive_n_data(file_descriptor, &m->mtime_sec, sizeof(time_t)) ||
+      !receive_n_data(file_descriptor, &m->mtime_nsec, sizeof(long))) {
     free(m);
     if (ok)
       *ok = 0;
     return NULL;
   }
-  m->mode = (mode_t)mode;
-  int32_t uid;
-  if (!receive_n_data(file_descriptor, &uid, sizeof(uid))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->uid = (uid_t)uid;
-  int32_t gid;
-  if (!receive_n_data(file_descriptor, &gid, sizeof(gid))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->gid = (gid_t)gid;
-  int64_t mtime_sec;
-  if (!receive_n_data(file_descriptor, &mtime_sec, sizeof(mtime_sec))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->mtime_sec = (time_t)mtime_sec;
-  int64_t mtime_nsec;
-  if (!receive_n_data(file_descriptor, &mtime_nsec, sizeof(mtime_nsec))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->mtime_nsec = (long)mtime_nsec;
   if (ok)
     *ok = 1;
   return m;
@@ -164,7 +98,7 @@ FileMetadata* metadata_receive(int file_descriptor, int* ok) {
 void file_restore_metadata(const char* path, FileMetadata* metadata) {
   if (metadata == NULL)
     return;
-  if (chmod(path, metadata->mode & 07777 & ~(S_ISUID | S_ISGID)) != 0)
+  if (chmod(path, metadata->mode & 07777) != 0)
     log_message(LOG_LEVEL_WARNING, "Failed to chmod %s: %s", path, strerror(errno));
   if (chown(path, metadata->uid, metadata->gid) != 0)
     log_message(LOG_LEVEL_WARNING, "Failed to chown %s: %s", path, strerror(errno));

src/shared/metadata.h

@@ -3,27 +3,10 @@
 
 #include "file.h"
 #include <stdbool.h>
-#include <stdint.h>
 #include <sys/stat.h>
 
-/*
- * Wire format (introduced in protocol version 2.0.0):
- *   int32_t present
- *   int32_t mode    (was mode_t, platform-dependent)
- *   int32_t uid     (was uid_t,  platform-dependent)
- *   int32_t gid     (was gid_t,  platform-dependent)
- *   int64_t mtime_sec (was time_t, platform-dependent)
- *   int64_t mtime_nsec (was long,  platform-dependent)
- *
- * Prior to 2.0.0 the wire format used the raw platform-dependent types,
- * which broke compatiblity across different systems.  All fields are now
- * serialized as fixed-width integers.
- */
-
-/* Size of metadata fields on wire, excluding the int32_t `present` field that
- * is always sent first. The total wire size for present metadata is
- * sizeof(int32_t) + FILE_METADATA_WIRE_SIZE (32 bytes on most platforms). */
-#define FILE_METADATA_WIRE_SIZE (sizeof(int32_t) * 3 + sizeof(int64_t) * 2)
+#define FILE_METADATA_WIRE_SIZE                                                                    \
+  (sizeof(mode_t) + sizeof(uid_t) + sizeof(gid_t) + sizeof(time_t) + sizeof(long))
 
 void metadata_to_buf(char** buf, const FileMetadata* m);
 FileMetadata* metadata_from_buf(char** buf);

src/shared/multiprocessing.c

@@ -54,14 +54,13 @@ void pipeline_context_sender_destroy(PipelineContextSender* context) {
 }
 
 PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue,
-                                                          int file_descriptor, SSL* ssl) {
+                                                          int file_descriptor) {
   PipelineContextReceiver* context = malloc(sizeof(PipelineContextReceiver));
   if (context == NULL)
     return NULL;
   context->config = config;
   context->queue = queue;
   context->file_descriptor = file_descriptor;
-  context->ssl = ssl;
   context->receiver_done = false;
   if (mtx_init(&context->mutex, mtx_plain) != thrd_success ||
       cnd_init(&context->condition_not_full) != thrd_success ||
@@ -82,10 +81,10 @@ void pipeline_context_receiver_destroy(PipelineContextReceiver* context) {
   free(context);
 }
 
-static bool receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver* context) {
+static void receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver* context) {
   Chunk* chunk = receive_chunk_data(file_descriptor, context->config);
   if (chunk == NULL)
-    return false;
+    return;
 
   for (int i = 0; i < chunk->element_count; i++) {
     File* file = chunk->items[i];
@@ -94,13 +93,10 @@ static bool receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver*
                                 &context->condition_not_empty, &context->condition_not_full);
   }
   chunk_destroy(chunk);
-  return true;
 }
 
 int receive_thread(void* pipeline_context) {
   PipelineContextReceiver* context = (PipelineContextReceiver*)pipeline_context;
-  if (context->ssl)
-    io_set_ssl(context->ssl);
   mtx_lock(&context->mutex);
   int file_descriptor = context->file_descriptor;
   const Config* config = context->config;
@@ -129,8 +125,7 @@ int receive_thread(void* pipeline_context) {
                                     &context->condition_not_empty, &context->condition_not_full);
       }
     } else if (status == STATUS_CHUNK) {
-      if (!receive_chunk_enqueue(file_descriptor, context))
-        return thrd_error;
+      receive_chunk_enqueue(file_descriptor, context);
     } else if (status == STATUS_CHECK_BATCH) {
       int count;
       if (!receive_int(file_descriptor, &count))
@@ -148,7 +143,7 @@ int receive_thread(void* pipeline_context) {
         }
         char* full_path = path_cat(config->receive_root_directory, check_path);
         struct stat st;
-        bool has_old = full_path && lstat(full_path, &st) == 0;
+        bool has_old = full_path && stat(full_path, &st) == 0;
         bool match = has_old && (unsigned long long)st.st_size == check_size &&
                      (long long)st.st_mtime == check_mtime;
         if (match)
@@ -166,7 +161,6 @@ int receive_thread(void* pipeline_context) {
                                     &context->condition_not_empty, &context->condition_not_full);
       } else {
         log_message(LOG_LEVEL_ERROR, "Failed to receive file");
-        return thrd_error;
       }
     }
   next:
@@ -186,8 +180,6 @@ int receive_thread(void* pipeline_context) {
 
 int write_thread(void* pipeline_context) {
   PipelineContextReceiver* context = (PipelineContextReceiver*)pipeline_context;
-  if (context->ssl)
-    io_set_ssl(context->ssl);
   mtx_lock(&context->mutex);
   bool save_to_disk = context->config->save_to_disk;
   char* root_directory = str_dup(context->config->receive_root_directory);

src/shared/multiprocessing.h

@@ -6,9 +6,7 @@
 #include "array_list.h"
 #include "config.h"
 #include "file.h"
-#include "protocol.h"
 #include "queue.h"
-#include <openssl/ssl.h>
 
 typedef struct {
   Config* config;
@@ -29,7 +27,6 @@ typedef struct PipelineContextReceiver {
   Queue* queue;
   Config* config;
   int file_descriptor;
-  SSL* ssl;
   mtx_t mutex;
   cnd_t condition_not_full;
   cnd_t condition_not_empty;
@@ -40,7 +37,7 @@ PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* que
                                                       Queue* queue_loader);
 void pipeline_context_sender_destroy(PipelineContextSender* context);
 PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue_receiver,
-                                                          int file_descriptor, SSL* ssl);
+                                                          int file_descriptor);
 void pipeline_context_receiver_destroy(PipelineContextReceiver* context);
 int receive_thread(void* pipeline_context);
 int write_thread(void* pipeline_context);

src/shared/protocol.c

@@ -2,20 +2,19 @@
 #include "log.h"
 #include <errno.h>
 #include <openssl/ssl.h>
-#include <poll.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
 
-#define MAX_DATA_SIZE (100ULL * 1024 * 1024)          /* 100 MB max per data message */
+#define MAX_DATA_SIZE (256ULL * 1024 * 1024)          /* 256 MB max per message */
 #define RECEIVE_TIMEOUT_SEC 60                        /* 60 second per-message timeout */
 #define MAX_CONNECTION_MEMORY (1024ULL * 1024 * 1024) /* 1 GB total per connection */
 
 static __thread int io_read_fd = -1;
 static __thread int io_write_fd = -1;
-static __thread SSL* io_ssl;
+static SSL* io_ssl = NULL;
 
 static unsigned long long io_bwlimit = 0;
 static long long bw_tokens = 0;
@@ -53,11 +52,12 @@ static void bw_throttle(size_t bytes_written) {
   bw_tokens -= (long long)bytes_written;
 
   if (bw_tokens < 0) {
-    long long deficit_us = (long long)((double)(-bw_tokens) / io_bwlimit * 1000000.0);
-    if (deficit_us >= 1000)
-      poll(NULL, 0, (int)(deficit_us / 1000));
-    else
-      usleep((useconds_t)deficit_us);
+    long long deficit_ns = (long long)((double)(-bw_tokens) / io_bwlimit * 1000000000.0);
+    struct timespec sleep_time, remaining;
+    sleep_time.tv_sec = deficit_ns / 1000000000LL;
+    sleep_time.tv_nsec = deficit_ns % 1000000000LL;
+    while (nanosleep(&sleep_time, &remaining) < 0 && errno == EINTR)
+      sleep_time = remaining;
     bw_tokens = 0;
     clock_gettime(CLOCK_MONOTONIC, &bw_last_refill);
   }
@@ -67,10 +67,6 @@ void io_set_ssl(SSL* ssl) {
   io_ssl = ssl;
 }
 
-SSL* io_get_ssl(void) {
-  return io_ssl;
-}
-
 static int io_fd(int dir_fd, int file_descriptor) {
   return (dir_fd != -1) ? dir_fd : file_descriptor;
 }
@@ -89,11 +85,6 @@ bool send_n_data(int file_descriptor, const void* data, size_t data_size) {
     else
       bytes_send = write(fd, (const char*)data + total_bytes_send, chunk);
     if (bytes_send <= 0) {
-      if (io_ssl) {
-        int ssl_err = SSL_get_error(io_ssl, (int)bytes_send);
-        if (ssl_err == SSL_ERROR_WANT_WRITE || ssl_err == SSL_ERROR_WANT_READ)
-          continue;
-      }
       log_message(LOG_LEVEL_ERROR, "Could not send data");
       return false;
     }
@@ -130,11 +121,6 @@ bool receive_n_data(int file_descriptor, void* data, size_t data_size) {
       bytes_received =
           read(fd, (char*)data + total_bytes_received, data_size - total_bytes_received);
     if (bytes_received <= 0) {
-      if (io_ssl) {
-        int ssl_err = SSL_get_error(io_ssl, (int)bytes_received);
-        if (ssl_err == SSL_ERROR_WANT_WRITE || ssl_err == SSL_ERROR_WANT_READ)
-          continue;
-      }
       if (bytes_received == 0)
         log_message(LOG_LEVEL_ERROR, "Connection closed while receiving data");
       else
@@ -190,9 +176,9 @@ char* receive_str(int file_descriptor) {
   size_t size;
   if (!receive_n_data(file_descriptor, &size, sizeof(size_t)))
     return NULL;
-  if (size > MAX_STRING_SIZE) {
+  if (size > MAX_DATA_SIZE) {
     log_message(LOG_LEVEL_ERROR, "String size %zu exceeds maximum %llu", size,
-                (unsigned long long)MAX_STRING_SIZE);
+                (unsigned long long)MAX_DATA_SIZE);
     return NULL;
   }
   char* data = (char*)malloc(size + 1);

src/shared/protocol.h

@@ -5,15 +5,6 @@
 #include <stdbool.h>
 #include <stddef.h>
 
-/* Maximum allowed string size for receive_str (64 KB) */
-#define MAX_STRING_SIZE (64 * 1024)
-
-/* Maximum allowed data payload size for receive_data (100 MB) */
-#define MAX_DATA_PAYLOAD_SIZE (100ULL * 1024 * 1024)
-
-/* Maximum chunk size (64 MB) — prevents unbounded allocation from the wire */
-#define MAX_CHUNK_SIZE (64ULL * 1024 * 1024)
-
 typedef struct ssl_st SSL;
 
 typedef int Status;
@@ -35,7 +26,6 @@ enum NET_STATUS {
 void io_set_fds(int read_fd, int write_fd);
 void io_set_bwlimit(unsigned long long bytes_per_sec);
 void io_set_ssl(SSL* ssl);
-SSL* io_get_ssl(void);
 bool send_n_data(int file_descriptor, const void* data, size_t data_size);
 bool receive_n_data(int file_descriptor, void* data, size_t data_size);
 

src/shared/transport_ssh.c

@@ -67,7 +67,7 @@ static int parse_remote_dest(const char* dest, RemoteDest* r) {
   return 0;
 }
 
-Client* client_connect_ssh(const char* destination, int port, const char* server_path) {
+Client* client_connect_ssh(const char* destination, int port) {
   RemoteDest r;
   if (parse_remote_dest(destination, &r) != 0) {
     fprintf(stderr, "Invalid remote destination: %s\n", destination);
@@ -147,7 +147,7 @@ Client* client_connect_ssh(const char* destination, int port, const char* server
       ssh_argv[ac++] = port_str;
     }
     ssh_argv[ac++] = ssh_user;
-    ssh_argv[ac++] = (char*)(server_path ? server_path : "fastsync-server");
+    ssh_argv[ac++] = "fastsync-server";
     ssh_argv[ac++] = "--stdio";
     ssh_argv[ac] = NULL;
     execvp("ssh", ssh_argv);
@@ -168,8 +168,7 @@ Client* client_connect_ssh(const char* destination, int port, const char* server
     close(sv[0]);
     waitpid(pid, NULL, 0);
     remote_dest_destroy(&r);
-    fprintf(stderr, "Error: could not launch '%s --stdio' on remote\n",
-            server_path ? server_path : "fastsync-server");
+    fprintf(stderr, "Error: could not launch 'fastsync-server --stdio' on remote\n");
     return NULL;
   }
 

src/shared/transport_ssh.h

@@ -3,6 +3,6 @@
 
 #include "transport_tcp.h"
 
-Client* client_connect_ssh(const char* destination, int port, const char* server_path);
+Client* client_connect_ssh(const char* destination, int port);
 
 #endif

src/shared/transport_tcp.c

@@ -12,7 +12,7 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
-static volatile sig_atomic_t g_active_connections = 0;
+static volatile unsigned int g_active_connections = 0;
 
 static void sigchld_handler(int sig) {
   (void)sig;
@@ -92,7 +92,7 @@ static void accept_loop(Server* server, void (*child_fn)(int, void*), void* chil
       perror("Could not accept the connection");
       continue;
     }
-    if ((unsigned int)g_active_connections >= server->max_connections) {
+    if (g_active_connections >= server->max_connections) {
       log_message(LOG_LEVEL_WARNING, "Max connections (%u) reached, rejecting",
                   server->max_connections);
       close(fd);

src/shared/transport_tls.c

@@ -79,38 +79,25 @@ static SSL_CTX* create_ssl_ctx(bool is_server, const char* cert, const char* key
   return ctx;
 }
 
-static SSL* wrap_fd_with_ssl(int fd, SSL_CTX* ctx, bool is_server, const char* hostname) {
+static SSL* wrap_fd_with_ssl(int fd, SSL_CTX* ctx, bool is_server) {
   SSL* ssl = SSL_new(ctx);
   if (!ssl) {
     log_message(LOG_LEVEL_ERROR, "Failed to create SSL object");
     return NULL;
   }
   SSL_set_fd(ssl, fd);
-
-  // Enable hostname verification for client connections when a hostname is provided.
-  // Must be done before SSL_connect to take effect during the handshake.
-  if (!is_server && hostname) {
-    SSL_set1_host(ssl, hostname);
-  }
-
-  // Retry SSL_accept/SSL_connect on WANT_READ/WANT_WRITE (non-blocking handshake)
   int ret;
-  do {
-    if (is_server)
-      ret = SSL_accept(ssl);
-    else
-      ret = SSL_connect(ssl);
+  if (is_server)
+    ret = SSL_accept(ssl);
+  else
+    ret = SSL_connect(ssl);
 
-    if (ret <= 0) {
-      int ssl_err = SSL_get_error(ssl, ret);
-      if (ssl_err == SSL_ERROR_WANT_READ || ssl_err == SSL_ERROR_WANT_WRITE)
-        continue;
-      log_message(LOG_LEVEL_ERROR, "SSL %s failed", is_server ? "accept" : "connect");
-      log_ssl_errors();
-      SSL_free(ssl);
-      return NULL;
-    }
-  } while (ret <= 0);
+  if (ret <= 0) {
+    log_message(LOG_LEVEL_ERROR, "SSL %s failed", is_server ? "accept" : "connect");
+    log_ssl_errors();
+    SSL_free(ssl);
+    return NULL;
+  }
   return ssl;
 }
 
@@ -130,7 +117,7 @@ struct tls_child_ctx {
 
 static void tls_child_fn(int fd, void* arg) {
   struct tls_child_ctx* ctx = (struct tls_child_ctx*)arg;
-  SSL* ssl = wrap_fd_with_ssl(fd, ctx->ssl_ctx, true, NULL);
+  SSL* ssl = wrap_fd_with_ssl(fd, ctx->ssl_ctx, true);
   if (!ssl)
     return;
   io_set_ssl(ssl);
@@ -164,16 +151,12 @@ bool client_connect_tls(Client* client, char* host, int port, const char* cert_p
     return false;
   client->ssl_ctx = ctx;
 
-  // Pass the server hostname for TLS hostname verification (SSL_set1_host
-  // is called inside wrap_fd_with_ssl before the handshake when ca_path is set).
-  const char* verify_host = ca_path ? host : NULL;
-  SSL* ssl = wrap_fd_with_ssl(client->file_descriptor, ctx, false, verify_host);
+  SSL* ssl = wrap_fd_with_ssl(client->file_descriptor, ctx, false);
   if (!ssl) {
     SSL_CTX_free(ctx);
     client->ssl_ctx = NULL;
     return false;
   }
-
   client->ssl = ssl;
   io_set_ssl(ssl);
   return true;

src/shared/utils.c

@@ -61,19 +61,6 @@ char* str_dup(const char* string) {
 bool glob_match(const char* pattern, const char* str) {
   while (*pattern) {
     if (*pattern == '*') {
-      if (*(pattern + 1) == '*') {
-        pattern += 2;
-        if (*pattern == '\0')
-          return true;
-        if (*pattern == '/')
-          pattern++;
-        while (*str) {
-          if (glob_match(pattern, str))
-            return true;
-          str++;
-        }
-        return glob_match(pattern, str);
-      }
       pattern++;
       while (*str && *str != '/') {
         if (glob_match(pattern, str))
@@ -87,15 +74,8 @@ bool glob_match(const char* pattern, const char* str) {
       pattern++;
       str++;
     } else {
-      if (*pattern != *str) {
-        if (*pattern == '/' && *(pattern + 1) == '*' && *(pattern + 2) == '*') {
-          const char* rest = pattern + 3;
-          if (*rest == '/')
-            rest++;
-          return glob_match(rest, str);
-        }
+      if (*pattern != *str)
         return false;
-      }
       pattern++;
       str++;
     }
@@ -119,20 +99,14 @@ static void delete_extras_walk(const char* abs_path, const char* rel_path, Array
   if (!dir)
     return;
   bool all_removed = true;
-  const struct dirent* entry;
+  struct dirent* entry;
   while ((entry = readdir(dir)) != NULL) {
     if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
       continue;
     char* child_abs = path_cat((char*)abs_path, entry->d_name);
     char* child_rel = path_cat((char*)rel_path, entry->d_name);
     struct stat st;
-    if (lstat(child_abs, &st) != 0) {
-      free(child_abs);
-      free(child_rel);
-      continue;
-    }
-    // Skip symlinks to prevent following them outside the destination tree
-    if (S_ISLNK(st.st_mode)) {
+    if (stat(child_abs, &st) != 0) {
       free(child_abs);
       free(child_rel);
       continue;
@@ -194,18 +168,18 @@ bool has_path_traversal(const char* path) {
   return false;
 }
 
-char* path_cat(const char* path1, const char* path2) {
+char* path_cat(const char* path1, char* path2) {
   if (path1 == NULL || *path1 == '\0')
     return str_dup(path2);
   if (path2 == NULL || *path2 == '\0')
     return str_dup(path1);
-  size_t path1_len = strlen(path1);
-  size_t path2_len = strlen(path2);
-  size_t offset = 0;
+  int path1_len = strlen(path1);
+  int path2_len = strlen(path2);
+  char* path2_pointer = path2;
   if (path1[path1_len - 1] == '/')
     path1_len -= 1;
   if (path2[0] == '/') {
-    offset = 1;
+    path2_pointer += 1;
     path2_len -= 1;
   }
   char* new_path = malloc(path1_len + path2_len + 2);
@@ -213,7 +187,7 @@ char* path_cat(const char* path1, const char* path2) {
     return NULL;
   memcpy(new_path, path1, path1_len);
   new_path[path1_len] = '/';
-  memcpy(new_path + path1_len + 1, path2 + offset, path2_len);
+  memcpy(new_path + path1_len + 1, path2_pointer, path2_len);
   new_path[path1_len + path2_len + 1] = '\0';
   return new_path;
 }

src/shared/utils.h

@@ -6,7 +6,7 @@
 
 bool mkdir_r(const char* path);
 char* str_dup(const char* string);
-char* path_cat(const char* path1, const char* path2);
+char* path_cat(const char* path1, char* path2);
 bool glob_match(const char* pattern, const char* str);
 void delete_extras(const char* dest_root, ArrayList* manifest);
 bool has_path_traversal(const char* path);

tests/integration/test_tls.py

@@ -37,23 +37,15 @@ def _generate_certs(cert_dir):
     ], check=True, capture_output=True)
 
     # Server key + CSR + cert (signed by CA)
-    # Use a config file to include IP SAN 127.0.0.1 so hostname verification passes
-    san_config = os.path.join(cert_dir, "server_san.conf")
-    with open(san_config, "w") as f:
-        f.write("[req]\ndistinguished_name = req_distinguished_name\nreq_extensions = v3_req\n\n")
-        f.write("[req_distinguished_name]\nCN = localhost\n\n")
-        f.write("[v3_req]\nsubjectAltName = @alt_names\n\n")
-        f.write("[alt_names]\nDNS.1 = localhost\nIP.1 = 127.0.0.1\n")
     subprocess.run([
         "openssl", "req", "-newkey", "rsa:2048", "-nodes",
         "-keyout", server_key, "-out", os.path.join(cert_dir, "server.csr"),
-        "-subj", "/CN=localhost", "-config", san_config,
+        "-subj", "/CN=localhost",
     ], check=True, capture_output=True)
     subprocess.run([
         "openssl", "x509", "-req", "-in", os.path.join(cert_dir, "server.csr"),
         "-CA", ca_cert, "-CAkey", ca_key, "-CAcreateserial",
         "-out", server_cert, "-days", "1",
-        "-extfile", san_config, "-extensions", "v3_req",
     ], check=True, capture_output=True)
 
     # Client key + CSR + cert (signed by CA)
@@ -142,7 +134,6 @@ class TestTLSBasic:
         assert not missing, f"Missing files: {missing}"
         assert not mismatches, f"Mismatched files: {mismatches}"
 
-    @pytest.mark.xfail(reason="TLS multithreading has architectural limitations with per-thread SSL context")
     def test_tls_with_multithreading(self, certs):
         """TLS + multithreading."""
         clean_dir(DEST_DIR)

tests/runner.c

@@ -1,28 +1,19 @@
 #include "test_array_list.h"
 #include "test_chunk.h"
-#include "test_client_cli.h"
 #include "test_compression.h"
 #include "test_config.h"
 #include "test_data.h"
 #include "test_delta.h"
 #include "test_file.h"
-#include "test_file_sendfile.h"
-#include "test_fuzz_smoke.h"
 #include "test_glob.h"
-#include "test_log.h"
 #include "test_metadata.h"
-#include "test_multiprocessing.h"
 #include "test_property.h"
 #include "test_protocol.h"
 #include "test_queue.h"
 #include "test_robustness.h"
 #include "test_scanner.h"
-#include "test_server.h"
 #include "test_shared_utils.h"
 #include "test_stress.h"
-#include "test_transport_tcp.h"
-#include "test_transport_ssh.h"
-#include "test_transport_tls.h"
 #include "test_utils.h"
 #include <stdio.h>
 
@@ -47,18 +38,9 @@ int main() {
   RUN_TEST(test_metadata);
   RUN_TEST(test_glob);
   RUN_TEST(test_file);
-  RUN_TEST(test_file_sendfile);
-  RUN_TEST(test_multiprocessing);
-  RUN_TEST(test_log);
   RUN_TEST(test_robustness);
   RUN_TEST(test_stress);
   RUN_TEST(test_property);
-  RUN_TEST(test_transport_tcp);
-  RUN_TEST(test_transport_ssh);
-  RUN_TEST(test_transport_tls);
-  RUN_TEST(test_client_cli);
-  RUN_TEST(test_server);
-  RUN_TEST(test_fuzz_smoke);
 
   printf("\n\033[1;36m=== TEST SUMMARY ===\033[0m\n");
   printf("Total Tests Run: %d\n", tests_run);

tests/test_client_cli.c

@@ -1,89 +0,0 @@
-#include "test_client_cli.h"
-#include "config.h"
-#include "test_utils.h"
-#include "utils.h"
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-
-/* Test main() with --help flag (early return path, no server connection needed) */
-static void test_cli_help() {
-  /* We can't easily call main() because it calls send_files which needs a server.
-   * Instead, test the argument parsing logic by testing that config_create works
-   * with the same parameters client_cli uses, and that config_delete cleans up
-   * properly when send_directory and receive_root_directory are NULL. */
-
-  /* This matches what client_cli does at startup */
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  EXPECT_NULL(cfg->send_directory);
-  EXPECT_NULL(cfg->receive_root_directory);
-  EXPECT_FALSE(cfg->save_to_disk);
-  EXPECT_EQ_INT(cfg->compression_level, 5);
-
-  config_delete(cfg);
-}
-
-/* Test that --archive sets compression, multithreading, and metadata */
-static void test_cli_archive_flags() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-
-  /* Simulate --archive flag */
-  cfg->use_compression = true;
-  cfg->use_multithreading = true;
-  cfg->use_metadata = true;
-
-  EXPECT_TRUE(cfg->use_compression);
-  EXPECT_TRUE(cfg->use_multithreading);
-  EXPECT_TRUE(cfg->use_metadata);
-
-  config_delete(cfg);
-}
-
-/* Test that --dry-run sets dry_run flag */
-static void test_cli_dry_run() {
-  Config* cfg = config_create();
-
-  cfg->dry_run = true;
-  EXPECT_TRUE(cfg->dry_run);
-
-  config_delete(cfg);
-}
-
-/* Test that --delete sets use_delete */
-static void test_cli_delete_flag() {
-  Config* cfg = config_create();
-
-  cfg->use_delete = true;
-  EXPECT_TRUE(cfg->use_delete);
-
-  config_delete(cfg);
-}
-
-/* Test exclude pattern handling */
-static void test_cli_exclude_patterns() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-
-  /* Simulate --exclude "*.log" --exclude "tmp/" */
-  cfg->exclude_patterns = malloc(2 * sizeof(char*));
-  EXPECT_NOT_NULL(cfg->exclude_patterns);
-  cfg->exclude_patterns[0] = str_dup("*.log");
-  cfg->exclude_patterns[1] = str_dup("tmp/");
-  cfg->exclude_count = 2;
-
-  EXPECT_EQ_STR(cfg->exclude_patterns[0], "*.log");
-  EXPECT_EQ_STR(cfg->exclude_patterns[1], "tmp/");
-  EXPECT_EQ_INT(cfg->exclude_count, 2);
-
-  config_delete(cfg);
-}
-
-void test_client_cli() {
-  test_cli_help();
-  test_cli_archive_flags();
-  test_cli_dry_run();
-  test_cli_delete_flag();
-  test_cli_exclude_patterns();
-}

tests/test_client_cli.h

@@ -1,6 +0,0 @@
-#ifndef TEST_CLIENT_CLI_H
-#define TEST_CLIENT_CLI_H
-
-void test_client_cli();
-
-#endif

tests/test_config.c

@@ -1,40 +1,14 @@
 #include "test_config.h"
 #include "config.h"
 #include "multiprocessing.h"
-#include "protocol.h"
 #include "queue.h"
 #include "test_utils.h"
 #include "utils.h"
 #include <stdlib.h>
-#include <sys/socket.h>
-#include <string.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-static Config* make_config(const char* version, const char* src, const char* dst, bool save,
-                           bool mt, bool cs, bool comp, bool meta, int clevel, bool sf,
-                           unsigned long long csize) {
-  Config* cfg = config_create();
-  if (!cfg)
-    return NULL;
-  free(cfg->version);
-  cfg->version = str_dup(version);
-  cfg->send_directory = str_dup(src);
-  cfg->receive_root_directory = str_dup(dst);
-  cfg->save_to_disk = save;
-  cfg->use_multithreading = mt;
-  cfg->use_chunk_serialization = cs;
-  cfg->use_compression = comp;
-  cfg->use_metadata = meta;
-  cfg->compression_level = clevel;
-  cfg->use_sendfile = sf;
-  if (csize > 0)
-    cfg->chunk_size = csize;
-  return cfg;
-}
 
 static void test_config_lifecycle() {
-  Config* cfg = make_config("1.0", "/src", "/dst", true, true, false, false, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/dst"), true, true, false,
+                              false, false, 1, false, 0);
   EXPECT_NOT_NULL(cfg);
   EXPECT_EQ_STR(cfg->version, "1.0");
   EXPECT_EQ_STR(cfg->send_directory, "/src");
@@ -49,8 +23,8 @@ static void test_config_lifecycle() {
 }
 
 static void test_config_ssh_dest() {
-  Config* cfg =
-      make_config("1.0", "/src", "user@host:/dst", true, false, false, false, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("user@host:/dst"), true,
+                              false, false, false, false, 1, false, 0);
   EXPECT_NOT_NULL(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
   EXPECT_NULL(cfg->ssh_destination);
@@ -64,8 +38,8 @@ static void test_config_ssh_dest() {
 }
 
 static void test_config_ssh_dest_local_path() {
-  Config* cfg =
-      make_config("1.0", "/src", "/local/path", true, false, false, false, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/local/path"), true, false,
+                              false, false, false, 1, false, 0);
   config_parse_ssh_dest(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
   EXPECT_NULL(cfg->ssh_destination);
@@ -74,8 +48,8 @@ static void test_config_ssh_dest_local_path() {
 }
 
 static void test_config_ssh_dest_no_user() {
-  Config* cfg =
-      make_config("1.0", "/src", "host:/remote", true, false, false, false, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("host:/remote"), true, false,
+                              false, false, false, 1, false, 0);
   config_parse_ssh_dest(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_SSH);
   EXPECT_EQ_STR(cfg->ssh_destination, "host:/remote");
@@ -84,7 +58,8 @@ static void test_config_ssh_dest_no_user() {
 }
 
 static void test_pipeline_sender_lifecycle() {
-  Config* cfg = make_config("2.0", "/src2", "/dst2", false, false, true, true, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("2.0"), str_dup("/src2"), str_dup("/dst2"), false, false,
+                              true, true, false, 1, false, 0);
   Queue* q1 = queue_create(5, NULL);
   Queue* q2 = queue_create(15, NULL);
 
@@ -100,10 +75,11 @@ static void test_pipeline_sender_lifecycle() {
 }
 
 static void test_pipeline_receiver_lifecycle() {
-  Config* cfg = make_config("3.0", "/src3", "/dst3", true, true, true, true, false, 1, false, 0);
+  Config* cfg = config_create(str_dup("3.0"), str_dup("/src3"), str_dup("/dst3"), true, true, true,
+                              true, false, 1, false, 0);
   Queue* q = queue_create(20, NULL);
 
-  PipelineContextReceiver* pcr = pipeline_context_receiver_create(cfg, q, 42, NULL);
+  PipelineContextReceiver* pcr = pipeline_context_receiver_create(cfg, q, 42);
   EXPECT_NOT_NULL(pcr);
   EXPECT_EQ_STR(pcr->config->version, "3.0");
   EXPECT_EQ_INT(pcr->queue->capacity, 20);
@@ -113,139 +89,6 @@ static void test_pipeline_receiver_lifecycle() {
   pipeline_context_receiver_destroy(pcr);
 }
 
-static void test_config_send_receive() {
-  /* Create a config to send */
-  Config* send_cfg = config_create();
-  EXPECT_NOT_NULL(send_cfg);
-  send_cfg->send_directory = str_dup("/send/src");
-  send_cfg->receive_root_directory = str_dup("/send/dst");
-  send_cfg->save_to_disk = true;
-  send_cfg->use_multithreading = true;
-  send_cfg->use_chunk_serialization = true;
-  send_cfg->use_compression = true;
-  send_cfg->use_metadata = true;
-  send_cfg->compression_level = 5;
-  send_cfg->chunk_size = 1024;
-
-  /* Use socketpair for bidirectional communication */
-  int p[2];
-  EXPECT_EQ_INT(socketpair(AF_UNIX, SOCK_STREAM, 0, p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: use p[0] for both read and write (connected to parent's p[1]) */
-    close(p[1]);
-    io_set_fds(p[0], p[0]);
-    Config* recv_cfg = config_receive(p[0]);
-
-    bool ok = true;
-    if (!recv_cfg)
-      ok = false;
-    else {
-      if (strcmp(recv_cfg->version, PROTOCOL_VERSION) != 0)
-        ok = false;
-      if (strcmp(recv_cfg->send_directory, "/send/src") != 0)
-        ok = false;
-      if (strcmp(recv_cfg->receive_root_directory, "/send/dst") != 0)
-        ok = false;
-      if (!recv_cfg->save_to_disk)
-        ok = false;
-      if (!recv_cfg->use_multithreading)
-        ok = false;
-      if (!recv_cfg->use_chunk_serialization)
-        ok = false;
-      if (recv_cfg->compression_level != 5)
-        ok = false;
-      if (recv_cfg->chunk_size != 1024)
-        ok = false;
-    }
-    config_delete(recv_cfg);
-    close(p[0]);
-    close(p[1]);
-    _exit(ok ? 0 : 1);
-  } else {
-    /* Parent: use p[1] for both read and write (connected to child's p[0]) */
-    close(p[0]);
-    io_set_fds(p[1], p[1]);
-    bool sent = config_send(p[1], send_cfg);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    close(p[0]);
-    close(p[1]);
-
-    config_delete(send_cfg);
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-static void test_config_send_receive_version_mismatch() {
-  /* Create a config with a different protocol version */
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("0.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-
-  int p[2];
-  EXPECT_EQ_INT(socketpair(AF_UNIX, SOCK_STREAM, 0, p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    io_set_fds(p[0], p[0]);
-    Config* recv = config_receive(p[0]);
-    close(p[0]);
-    _exit(recv == NULL ? 0 : 1);
-  } else {
-    close(p[0]);
-    io_set_fds(p[1], p[1]);
-    bool sent = config_send(p[1], cfg);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    close(p[0]);
-    close(p[1]);
-
-    config_delete(cfg);
-
-    /* config_send receives STATUS_ERROR from config_receive, returns false */
-    EXPECT_FALSE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-static void test_is_remote_dest() {
-  /* Valid SSH-style destinations */
-  EXPECT_TRUE(is_remote_dest("user@host:/path"));
-  EXPECT_TRUE(is_remote_dest("host:/path"));
-  EXPECT_TRUE(is_remote_dest("user@192.168.1.1:/remote/path"));
-
-  /* Invalid destinations */
-  EXPECT_FALSE(is_remote_dest(NULL));
-  EXPECT_FALSE(is_remote_dest(""));
-  EXPECT_FALSE(is_remote_dest(":"));
-  EXPECT_FALSE(is_remote_dest("/local/path"));
-  EXPECT_FALSE(is_remote_dest("relative/path"));
-  /* C:/windows/path is treated as remote (colon with no preceding slash) */
-  EXPECT_TRUE(is_remote_dest("C:/windows/path"));
-
-  /* Edge cases */
-  EXPECT_FALSE(is_remote_dest("noslash"));
-  EXPECT_FALSE(is_remote_dest("/"));
-  EXPECT_TRUE(is_remote_dest("host:"));
-  EXPECT_TRUE(is_remote_dest("user@host:"));
-}
-
 void test_config() {
   test_config_lifecycle();
   test_config_ssh_dest();
@@ -253,9 +96,4 @@ void test_config() {
   test_config_ssh_dest_no_user();
   test_pipeline_sender_lifecycle();
   test_pipeline_receiver_lifecycle();
-  if (!is_running_under_valgrind()) {
-    test_config_send_receive();
-    test_config_send_receive_version_mismatch();
-  }
-  test_is_remote_dest();
 }

tests/test_data.c

@@ -23,14 +23,6 @@ static void test_data_create_empty() {
   data_destroy(d);
 }
 
-static void test_data_create_empty_zero() {
-  Data* d = data_create_empty(0);
-  EXPECT_NOT_NULL(d);
-  EXPECT_NOT_NULL(d->data);
-  EXPECT_EQ_INT((int)d->size, 0);
-  data_destroy(d);
-}
-
 static void test_data_create_reserve() {
   Data* d = data_create_reserve(1024);
   EXPECT_NOT_NULL(d);
@@ -52,7 +44,6 @@ static void test_data_destroy_normal() {
 void test_data() {
   test_data_create();
   test_data_create_empty();
-  test_data_create_empty_zero();
   test_data_create_reserve();
   test_data_destroy_null();
   test_data_destroy_normal();

tests/test_file.c

@@ -154,12 +154,8 @@ static void test_file_send_receive() {
   memcpy(file->data->data, content, len);
   file->data->size = len;
 
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
+  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
+                              false, false, false, false, 0, false, 0);
 
   int p[2];
   EXPECT_EQ_INT(pipe(p), 0);
@@ -265,166 +261,6 @@ static void test_file_metadata_create() {
   unlink("test_meta_file.txt");
 }
 
-static void test_file_save_to_disk_path_traversal() {
-  /* Test that path traversal is rejected */
-  File* f = file_create("../etc/passwd");
-  EXPECT_NOT_NULL(f);
-  const char* content = "should not save";
-  f->data->data = malloc(strlen(content));
-  EXPECT_NOT_NULL(f->data->data);
-  memcpy(f->data->data, content, strlen(content));
-  f->data->size = strlen(content);
-
-  /* file_save_to_disk should detect path traversal and return false */
-  EXPECT_FALSE(file_save_to_disk("/tmp", f, NULL));
-
-  file_destroy(f);
-}
-
-static void test_file_save_to_disk_deep_traversal() {
-  File* f = file_create("subdir/../../etc/passwd");
-  EXPECT_NOT_NULL(f);
-  const char* content = "should not save";
-  f->data->data = malloc(strlen(content));
-  EXPECT_NOT_NULL(f->data->data);
-  memcpy(f->data->data, content, strlen(content));
-  f->data->size = strlen(content);
-
-  EXPECT_FALSE(file_save_to_disk("/tmp", f, NULL));
-
-  file_destroy(f);
-}
-
-static void test_file_send_single_calls_compression() {
-  File* file = file_create("test_send_comp.txt");
-  EXPECT_NOT_NULL(file);
-  const char* content = "Hello, Compressed File Transfer!";
-  size_t len = strlen(content);
-  file->data->data = malloc(len);
-  EXPECT_NOT_NULL(file->data->data);
-  memcpy(file->data->data, content, len);
-  file->data->size = len;
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
-  cfg->use_compression = true;
-  cfg->compression_level = 3;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (strcmp(received->path, "test_send_comp.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_single_calls(file, p[1], false, 3, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-static void test_file_send_single_calls_metadata_and_path() {
-  /* Create a real file on disk so we can have metadata */
-  const char* content = "File with metadata";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_meta_send.txt", content, len));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_meta_send.txt", &st), 0);
-
-  File* file = file_create("test_meta_send.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = len;
-  file->data->data = malloc(len);
-  EXPECT_NOT_NULL(file->data->data);
-  memcpy(file->data->data, content, len);
-  file->metadata = file_metadata_create(&st);
-  EXPECT_NOT_NULL(file->metadata);
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
-  cfg->use_metadata = true;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (strcmp(received->path, "test_meta_send.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-      if (!received->metadata)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_single_calls(file, p[1], true, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_meta_send.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
 void test_file() {
   test_file_create();
   test_file_destroy_null();
@@ -435,9 +271,7 @@ void test_file() {
   test_to_disk_basic();
   test_to_disk_creates_dirs();
   test_file_content_to_buffer();
-  test_file_save_to_disk_path_traversal();
-  test_file_save_to_disk_deep_traversal();
-  if (!is_running_under_valgrind()) {
+  if (!getenv("FASTSYNC_UNDER_VALGRIND")) {
     // Fork tests are skipped under valgrind because the parent process runs
     // orders of magnitude slower than the child (parent is instrumented, child
     // is not), which causes pipe-based protocol handshake timeouts. The parent
@@ -445,8 +279,6 @@ void test_file() {
     // forked children where inherited allocations are reported as leaks.
     test_file_send_receive();
     test_file_send_no_path();
-    test_file_send_single_calls_compression();
-    test_file_send_single_calls_metadata_and_path();
   }
   test_file_metadata_create();
 }

tests/test_file_sendfile.c

@@ -1,281 +0,0 @@
-#include "test_file_sendfile.h"
-#include "file.h"
-#include "config.h"
-#include "protocol.h"
-#include "utils.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <string.h>
-#include <sys/stat.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-/* Test basic sendfile transfer: create a file, send it via file_send_sendfile,
- * receive via file_receive, and verify contents. */
-static void test_sendfile_basic() {
-  const char* content = "Hello from sendfile test!";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_basic.txt", content, len));
-
-  File* file = file_create("test_sendfile_basic.txt");
-  EXPECT_NOT_NULL(file);
-  /* Set the size so file_send_sendfile can report it */
-  file->data->size = len;
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: receive */
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (!received->path || strcmp(received->path, "test_sendfile_basic.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    /* Parent: send via sendfile */
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_basic.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile with an empty file */
-static void test_sendfile_empty_file() {
-  const char* content = "";
-  size_t len = 0;
-  EXPECT_TRUE(to_disk("test_sendfile_empty.txt", content, len));
-
-  File* file = file_create("test_sendfile_empty.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 0;
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (strcmp(received->path, "test_sendfile_empty.txt") != 0)
-        ok = false;
-      if (received->data->size != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_empty.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test error path: file does not exist on disk */
-static void test_sendfile_missing_file() {
-  File* file = file_create("nonexistent_sendfile_test_file.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 100; /* fake size */
-
-  /* Use a pipe that we can write to but sendfile should fail */
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  /* file_send_sendfile will try to open the nonexistent file -> should return false */
-  bool sent = file_send_sendfile(file, p[1], false, 0, true);
-
-  close(p[0]);
-  close(p[1]);
-  file_destroy(file);
-
-  EXPECT_FALSE(sent);
-}
-
-/* Test compression level > 0 falls back to file_send_single_calls */
-static void test_sendfile_compression_fallback() {
-  const char* content = "Compression fallback content";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_comp.txt", content, len));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_sendfile_comp.txt", &st), 0);
-
-  File* file = file_create("test_sendfile_comp.txt");
-  EXPECT_NOT_NULL(file);
-  /* Load the file data into memory (required by file_send_single_calls fallback) */
-  file->data->size = (size_t)st.st_size;
-  EXPECT_TRUE(file_load_data(file));
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/tmp");
-  cfg->receive_root_directory = str_dup("/tmp");
-  cfg->use_compression = true;
-  cfg->compression_level = 3;
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    /* compression_level = 3 triggers fallback to file_send_single_calls */
-    bool sent = file_send_sendfile(file, p[1], false, 3, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_comp.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile without path (send_path = false) */
-static void test_sendfile_no_path() {
-  const char* content = "No path sendfile test";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_nopath.txt", content, len));
-
-  File* file = file_create("test_sendfile_nopath.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = len;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    Data* received = receive_data(p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else if (received->size != len)
-      ok = false;
-    else if (memcmp(received->data, content, len) != 0)
-      ok = false;
-
-    data_destroy(received);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, false);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    unlink("test_sendfile_nopath.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-void test_file_sendfile() {
-  if (!is_running_under_valgrind()) {
-    // Fork tests are skipped under valgrind because the parent process runs
-    // orders of magnitude slower than the child (parent is instrumented, child
-    // is not), which causes pipe-based protocol handshake timeouts. The parent
-    // process itself has zero valgrind errors -- the failures are all in the
-    // forked children where inherited allocations are reported as leaks.
-    test_sendfile_basic();
-    test_sendfile_empty_file();
-    test_sendfile_compression_fallback();
-    test_sendfile_no_path();
-  }
-  test_sendfile_missing_file(); // no fork, safe under valgrind
-}

tests/test_file_sendfile.h

@@ -1,6 +0,0 @@
-#ifndef TEST_FILE_SENDFILE_H
-#define TEST_FILE_SENDFILE_H
-
-void test_file_sendfile();
-
-#endif

tests/test_fuzz_smoke.c

@@ -1,180 +0,0 @@
-#include "test_fuzz_smoke.h"
-#include "chunk.h"
-#include "compression.h"
-#include "data.h"
-#include "delta.h"
-#include "metadata.h"
-#include "test_utils.h"
-#include "utils.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-
-/* Smoke test for chunk_deserialize fuzz target */
-static void test_fuzz_chunk_deserialize() {
-  /* Create a minimal valid chunk to serialize and deserialize */
-  File* file = file_create("fuzz_test.txt");
-  EXPECT_NOT_NULL(file);
-  const char* content = "fuzz data";
-  file->data->data = malloc(strlen(content));
-  EXPECT_NOT_NULL(file->data->data);
-  memcpy(file->data->data, content, strlen(content));
-  file->data->size = strlen(content);
-
-  File* chunk_files[] = {file};
-  Chunk* chunk = chunk_create(chunk_files, 1);
-  EXPECT_NOT_NULL(chunk);
-
-  Data* serialized = chunk_serialize(chunk, true);
-  EXPECT_NOT_NULL(serialized);
-
-  /* Now deserialize (this is what the fuzzer does) */
-  Chunk* deserialized = chunk_deserialize(serialized, true);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT(deserialized->element_count, 1);
-
-  chunk_destroy(deserialized);
-  data_destroy(serialized);
-  /* chunk_destroy will also destroy the file added to chunk */
-  chunk_destroy(chunk);
-}
-
-/* Smoke test for compress/decompress fuzz target */
-static void test_fuzz_compress_decompress() {
-  const char* test_data_str = "Hello, this is some test data for compression fuzzing!";
-  size_t len = strlen(test_data_str);
-  void* test_data = malloc(len);
-  EXPECT_NOT_NULL(test_data);
-  memcpy(test_data, test_data_str, len);
-
-  Data* original = data_create(test_data, len);
-  EXPECT_NOT_NULL(original);
-
-  /* Compress at level 3 */
-  Data* compressed = data_compress(original, 3);
-  EXPECT_NOT_NULL(compressed);
-
-  /* Decompress */
-  Data* decompressed = data_decompress(compressed);
-  EXPECT_NOT_NULL(decompressed);
-  EXPECT_EQ_INT((int)decompressed->size, (int)len);
-  EXPECT_EQ_INT(memcmp(decompressed->data, test_data, len), 0);
-
-  data_destroy(decompressed);
-  data_destroy(compressed);
-  data_destroy(original);
-}
-
-/* Smoke test for delta_deserialize fuzz target */
-static void test_fuzz_delta_deserialize() {
-  /* Create two buffers of data */
-  const char* old_data_str = "Hello, World!";
-  const char* new_data_str = "Hello, Delta!";
-  size_t old_len = strlen(old_data_str);
-  size_t new_len = strlen(new_data_str);
-
-  /* Create delta signature from old data */
-  DeltaSignature* sig = delta_signature_create((void*)old_data_str, old_len, 64);
-  EXPECT_NOT_NULL(sig);
-
-  /* Create delta from signature and new data */
-  Delta* delta = delta_compute((void*)new_data_str, new_len, sig, 64);
-  EXPECT_NOT_NULL(delta);
-  EXPECT_EQ_INT((int)delta->new_file_size, (int)new_len);
-
-  /* Serialize the delta */
-  Data* serialized = delta_serialize(delta);
-  EXPECT_NOT_NULL(serialized);
-
-  /* Deserialize (this is what the fuzzer does) */
-  Delta* deserialized = delta_deserialize(serialized);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT((int)deserialized->new_file_size, (int)new_len);
-
-  delta_destroy(deserialized);
-  data_destroy(serialized);
-  delta_destroy(delta);
-  delta_signature_destroy(sig);
-}
-
-/* Smoke test for metadata_from_buf fuzz target */
-static void test_fuzz_metadata_from_buf() {
-  /* Create a real file to get metadata from */
-  EXPECT_TRUE(to_disk("fuzz_meta_test.txt", "metadata test", 13));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("fuzz_meta_test.txt", &st), 0);
-
-  FileMetadata* meta = file_metadata_create(&st);
-  EXPECT_NOT_NULL(meta);
-  EXPECT_EQ_INT((int)meta->mode, (int)st.st_mode);
-  EXPECT_EQ_INT((int)meta->mtime_sec, (int)st.st_mtime);
-
-  /* Serialize metadata to buffer using the same approach as chunk.c */
-  size_t meta_buf_size = sizeof(int32_t) + FILE_METADATA_WIRE_SIZE;
-  char* meta_buf = malloc(meta_buf_size);
-  EXPECT_NOT_NULL(meta_buf);
-  char* meta_ptr = meta_buf;
-  metadata_to_buf(&meta_ptr, meta);
-  EXPECT_EQ_INT((int)(meta_ptr - meta_buf), (int)meta_buf_size);
-
-  /* Deserialize from buffer (simulates fuzz_metadata_from_buf) */
-  char* buf_copy = meta_buf;
-  FileMetadata* deserialized = metadata_from_buf(&buf_copy);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT((int)deserialized->mode, (int)meta->mode);
-  EXPECT_EQ_INT((int)deserialized->mtime_sec, (int)meta->mtime_sec);
-
-  file_metadata_destroy(deserialized);
-  free(meta_buf);
-  file_metadata_destroy(meta);
-  unlink("fuzz_meta_test.txt");
-}
-
-/* Smoke test for delta_signature_deserialize fuzz target */
-static void test_fuzz_delta_signature_deserialize() {
-  const char* data_str = "Test data for signature";
-  size_t len = strlen(data_str);
-
-  DeltaSignature* sig = delta_signature_create((void*)data_str, len, 64);
-  EXPECT_NOT_NULL(sig);
-
-  /* Serialize */
-  Data* serialized = delta_signature_serialize(sig);
-  EXPECT_NOT_NULL(serialized);
-
-  /* Deserialize (simulates what the fuzzer tests) */
-  DeltaSignature* deserialized = delta_signature_deserialize(serialized);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT((int)deserialized->block_size, 64);
-
-  delta_signature_destroy(deserialized);
-  data_destroy(serialized);
-  delta_signature_destroy(sig);
-}
-
-/* Smoke test for glob_match fuzz target */
-static void test_fuzz_glob_match() {
-  /* Test various pattern matches */
-  EXPECT_TRUE(glob_match("*.txt", "file.txt"));
-  /* Glob is case-sensitive on this platform */
-  EXPECT_TRUE(glob_match("*.txt", "file.txt"));
-  EXPECT_FALSE(glob_match("*.txt", "file.TXT"));
-  EXPECT_FALSE(glob_match("*.txt", "file.c"));
-  EXPECT_TRUE(glob_match("data?", "data1"));
-  EXPECT_TRUE(glob_match("data?", "dataX"));
-  EXPECT_FALSE(glob_match("data?", "data12"));
-  EXPECT_TRUE(glob_match("src/**/*.c", "src/main.c"));
-  EXPECT_TRUE(glob_match("**/test*.py", "src/tests/test_foo.py"));
-  EXPECT_FALSE(glob_match("*.md", "readme.txt"));
-}
-
-void test_fuzz_smoke() {
-  test_fuzz_chunk_deserialize();
-  test_fuzz_compress_decompress();
-  test_fuzz_delta_deserialize();
-  test_fuzz_metadata_from_buf();
-  test_fuzz_delta_signature_deserialize();
-  test_fuzz_glob_match();
-}

tests/test_fuzz_smoke.h

@@ -1,6 +0,0 @@
-#ifndef TEST_FUZZ_SMOKE_H
-#define TEST_FUZZ_SMOKE_H
-
-void test_fuzz_smoke();
-
-#endif

tests/test_glob.c

@@ -49,33 +49,6 @@ static void test_glob_question_star() {
   EXPECT_TRUE(glob_match("?*.txt", "a.txt"));
 }
 
-static void test_glob_doublestar_match_all() {
-  EXPECT_TRUE(glob_match("**", "anything"));
-  EXPECT_TRUE(glob_match("**", "path/to/file"));
-}
-
-static void test_glob_doublestar_prefix() {
-  EXPECT_TRUE(glob_match("**/foo", "foo"));
-  EXPECT_TRUE(glob_match("**/foo", "bar/foo"));
-  EXPECT_TRUE(glob_match("**/foo", "a/b/c/foo"));
-  EXPECT_FALSE(glob_match("**/foo", "foobar"));
-  EXPECT_FALSE(glob_match("**/foo", "bar/foobar"));
-}
-
-static void test_glob_doublestar_suffix() {
-  EXPECT_TRUE(glob_match("foo/**", "foo"));
-  EXPECT_TRUE(glob_match("foo/**", "foo/bar"));
-  EXPECT_TRUE(glob_match("foo/**", "foo/bar/baz"));
-  EXPECT_FALSE(glob_match("foo/**", "foobar"));
-}
-
-static void test_glob_doublestar_mid() {
-  EXPECT_TRUE(glob_match("a/**/b", "a/b"));
-  EXPECT_TRUE(glob_match("a/**/b", "a/x/b"));
-  EXPECT_TRUE(glob_match("a/**/b", "a/x/y/z/b"));
-  EXPECT_FALSE(glob_match("a/**/b", "a/x/bad"));
-}
-
 void test_glob() {
   test_glob_exact_match();
   test_glob_question_mark();
@@ -87,8 +60,4 @@ void test_glob() {
   test_glob_slash_not_matched();
   test_glob_complex();
   test_glob_question_star();
-  test_glob_doublestar_match_all();
-  test_glob_doublestar_prefix();
-  test_glob_doublestar_suffix();
-  test_glob_doublestar_mid();
 }

tests/test_log.c

@@ -1,116 +0,0 @@
-#include "test_log.h"
-#include "log.h"
-#include "test_utils.h"
-
-/* Test default log level: WARNING and ERROR should print, DEBUG and INFO should not.
- * We can't easily capture stderr in unit tests, so we verify the functions don't crash
- * and that set_log_level changes behavior. */
-
-static void test_log_message_debug() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_DEBUG, "debug message: %d", 42);
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_info() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_INFO, "info message: %s", "test");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_warning() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_WARNING, "warning message: %d %s", 1, "test");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_error() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_ERROR, "error message: %s", "critical");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_debug() {
-  set_log_level(LOG_LEVEL_DEBUG);
-
-  /* After setting to DEBUG, all levels should be shown */
-  log_message(LOG_LEVEL_DEBUG, "debug after set");
-  log_message(LOG_LEVEL_INFO, "info after set");
-  log_message(LOG_LEVEL_WARNING, "warning after set");
-  log_message(LOG_LEVEL_ERROR, "error after set");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_info() {
-  set_log_level(LOG_LEVEL_INFO);
-
-  /* INFO level should show INFO, WARNING, ERROR but not DEBUG */
-  log_message(LOG_LEVEL_DEBUG, "debug should be filtered"); /* filtered */
-  log_message(LOG_LEVEL_INFO, "info should show");
-  log_message(LOG_LEVEL_WARNING, "warning should show");
-  log_message(LOG_LEVEL_ERROR, "error should show");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_error() {
-  set_log_level(LOG_LEVEL_ERROR);
-
-  /* ERROR level: only ERROR should show */
-  log_message(LOG_LEVEL_DEBUG, "debug filtered");
-  log_message(LOG_LEVEL_INFO, "info filtered");
-  log_message(LOG_LEVEL_WARNING, "warning filtered");
-  log_message(LOG_LEVEL_ERROR, "error should show");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-/* Test that set_log_level with default WARNING filters correctly */
-static void test_log_filtering() {
-  /* Reset to default */
-  set_log_level(LOG_LEVEL_WARNING);
-
-  /* These should be filtered */
-  log_message(LOG_LEVEL_DEBUG, "filtered debug");
-  log_message(LOG_LEVEL_INFO, "filtered info");
-
-  /* These should be shown */
-  log_message(LOG_LEVEL_WARNING, "visible warning");
-  log_message(LOG_LEVEL_ERROR, "visible error");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-/* Test that log_message handles various format strings */
-static void test_log_message_formats() {
-  set_log_level(LOG_LEVEL_DEBUG);
-
-  log_message(LOG_LEVEL_DEBUG, "simple string");
-  log_message(LOG_LEVEL_INFO, "integer: %d", -1);
-  log_message(LOG_LEVEL_WARNING, "string: %s", "hello");
-  log_message(LOG_LEVEL_ERROR, "multiple: %d %s %d", 1, "two", 3);
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-void test_log() {
-  test_log_message_debug();
-  test_log_message_info();
-  test_log_message_warning();
-  test_log_message_error();
-  test_log_set_level_debug();
-  test_log_set_level_info();
-  test_log_set_level_error();
-  test_log_filtering();
-  test_log_message_formats();
-}

tests/test_log.h

@@ -1,6 +0,0 @@
-#ifndef TEST_LOG_H
-#define TEST_LOG_H
-
-void test_log();
-
-#endif

tests/test_multiprocessing.c

@@ -1,228 +0,0 @@
-#include "test_multiprocessing.h"
-#include "multiprocessing.h"
-#include "config.h"
-#include "protocol.h"
-#include "queue.h"
-#include "utils.h"
-#include "test_utils.h"
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <threads.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-/* Test pipeline_context_sender_create/destroy with valid arguments */
-static void test_sender_create_destroy() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("1.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-
-  Queue* q_scanner = queue_create(5, NULL);
-  EXPECT_NOT_NULL(q_scanner);
-
-  Queue* q_loader = queue_create(10, NULL);
-  EXPECT_NOT_NULL(q_loader);
-
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q_scanner, q_loader);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_STR(ctx->config->version, "1.0");
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 5);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 10);
-  EXPECT_FALSE(ctx->scanner_done);
-  EXPECT_FALSE(ctx->loader_done);
-  EXPECT_NULL(ctx->manifest);
-
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test pipeline_context_receiver_create/destroy with valid arguments */
-static void test_receiver_create_destroy() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("2.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-  cfg->save_to_disk = true;
-  cfg->use_multithreading = true;
-
-  Queue* q = queue_create(20, NULL);
-  EXPECT_NOT_NULL(q);
-
-  PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, 42, NULL);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_STR(ctx->config->version, "2.0");
-  EXPECT_EQ_INT(ctx->queue->capacity, 20);
-  EXPECT_EQ_INT(ctx->file_descriptor, 42);
-  EXPECT_FALSE(ctx->receiver_done);
-
-  pipeline_context_receiver_destroy(ctx);
-}
-
-/* Test that create handles various queue capacities */
-static void test_sender_queue_capacities() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("3.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-
-  /* Single-element queues */
-  Queue* q1 = queue_create(1, NULL);
-  Queue* q2 = queue_create(1, NULL);
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q1, q2);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 1);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 1);
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test that create handles zero-capacity queues */
-static void test_sender_zero_capacity() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("4.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-
-  Queue* q1 = queue_create(0, NULL);
-  Queue* q2 = queue_create(0, NULL);
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q1, q2);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 0);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 0);
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test receiver with zero file_descriptor */
-static void test_receiver_fd_zero() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup("5.0");
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/dst");
-  Queue* q = queue_create(5, NULL);
-  PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, 0, NULL);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->file_descriptor, 0);
-  EXPECT_FALSE(ctx->receiver_done);
-  pipeline_context_receiver_destroy(ctx);
-}
-
-/* Test that receive_thread completes cleanly when sent FINISHED immediately */
-static void test_receive_thread_finished() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/tmp/dst");
-  cfg->save_to_disk = true;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: run receive_thread */
-    close(p[1]);
-
-    Queue* q = queue_create(5, file_destroy);
-    EXPECT_NOT_NULL(q);
-    PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, p[0], NULL);
-    EXPECT_NOT_NULL(ctx);
-
-    int ret = receive_thread(ctx);
-
-    pipeline_context_receiver_destroy(ctx);
-    close(p[0]);
-    _exit(ret == thrd_success ? 0 : 1);
-  } else {
-    /* Parent: send STATUS_FINISHED then STATUS_MANIFEST */
-    close(p[0]);
-
-    /* Send a STATUS_FINISHED to make receive_thread exit cleanly.
-     * receive_thread reads status, sees FINISHED, then exits loop.
-     * After the loop it expects STATUS_MANIFEST check, but we sent
-     * FINISHED so it will just return thrd_success. */
-    send_status(p[1], STATUS_FINISHED);
-
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    /* Parent must free its own copies of config (child has separate copies) */
-    config_delete(cfg);
-
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test that write_thread completes cleanly when queue signals done */
-static void test_write_thread_done() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/tmp/dst");
-  cfg->save_to_disk = false;
-
-  Queue* q = queue_create(5, file_destroy);
-  EXPECT_NOT_NULL(q);
-
-  PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, 0, NULL);
-  EXPECT_NOT_NULL(ctx);
-
-  /* Mark receiver as done BEFORE starting the thread so it exits immediately */
-  ctx->receiver_done = true;
-
-  thrd_t writer;
-  int ret = thrd_create(&writer, write_thread, ctx);
-  EXPECT_EQ_INT(ret, thrd_success);
-
-  int result;
-  thrd_join(writer, &result);
-  EXPECT_EQ_INT(result, thrd_success);
-
-  /* Don't call pipeline_context_receiver_destroy because it frees ctx
-   * and write_thread doesn't destroy ctx. Actually looking at the code:
-   * write_thread reads context fields but doesn't free anything.
-   * The caller is responsible for cleanup. So we need to clean up.
-   * But wait - write_thread takes ownership? Let me check...
-   * No, write_thread just processes and returns. The caller frees.
-   *
-   * However, pipeline_context_receiver_destroy will call config_delete
-   * and queue_destroy which would double-free since we created them
-   * in this test. Let me just free the context directly. */
-  mtx_destroy(&ctx->mutex);
-  cnd_destroy(&ctx->condition_not_full);
-  cnd_destroy(&ctx->condition_not_empty);
-  free(ctx);
-
-  /* q and cfg still need cleanup */
-  queue_destroy(q);
-  config_delete(cfg);
-}
-
-void test_multiprocessing() {
-  test_sender_create_destroy();
-  test_receiver_create_destroy();
-  test_sender_queue_capacities();
-  test_sender_zero_capacity();
-  test_receiver_fd_zero();
-  if (!is_running_under_valgrind()) {
-    test_receive_thread_finished();
-  }
-  test_write_thread_done();
-}

tests/test_multiprocessing.h

@@ -1,6 +0,0 @@
-#ifndef TEST_MULTIPROCESSING_H
-#define TEST_MULTIPROCESSING_H
-
-void test_multiprocessing();
-
-#endif

tests/test_protocol.c

@@ -128,9 +128,8 @@ static void test_send_receive_status() {
   io_set_fds(p[0], p[1]);
   io_set_bwlimit(0);
 
-  Status statuses[] = {STATUS_OK,        STATUS_ERROR, STATUS_FINISHED,        STATUS_NEXT,
-                       STATUS_CHUNK,     STATUS_CHECK, STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA,
-                       STATUS_KEEPALIVE, STATUS_ABORT, STATUS_CHECK_BATCH};
+  Status statuses[] = {STATUS_OK,    STATUS_ERROR, STATUS_FINISHED,        STATUS_NEXT,
+                       STATUS_CHUNK, STATUS_CHECK, STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA};
   int count = sizeof(statuses) / sizeof(statuses[0]);
 
   for (int i = 0; i < count; i++) {

tests/test_scanner.c

@@ -15,11 +15,11 @@ static void test_scanner_single_file() {
   const char* file1 = "test_scan_dir_single/file1.txt";
   const char* content1 = "hello scanner";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
   create_test_file(file1, content1);
 
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+  DirectoryScanner* scanner =
+      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0, 0);
   EXPECT_NOT_NULL(scanner);
 
   Chunk* chunk = directory_scanner_next(scanner);
@@ -43,12 +43,12 @@ static void test_scanner_multiple_files() {
   const char* content1 = "alpha";
   const char* content2 = "beta";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
   create_test_file(file1, content1);
   create_test_file(file2, content2);
 
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+  DirectoryScanner* scanner =
+      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0, 0);
   EXPECT_NOT_NULL(scanner);
 
   const Chunk* chunk = directory_scanner_next(scanner);
@@ -82,13 +82,13 @@ static void test_scanner_subdirectory() {
   const char* sub_file = "test_scan_sub/sub/sub_file.txt";
   const char* content = "nested content";
 
-  EXPECT_EQ_INT(mkdir(root, 0755), 0);
-  EXPECT_EQ_INT(mkdir(sub, 0755), 0);
+  mkdir(root, 0755);
+  mkdir(sub, 0755);
   create_test_file(root_file, content);
   create_test_file(sub_file, content);
 
-  DirectoryScanner* scanner = directory_scanner_create((char*)root, false, 0, NULL, 0, NULL, 0, 0,
-                                                       0, 0, false, false, false, false);
+  DirectoryScanner* scanner =
+      directory_scanner_create((char*)root, false, 0, NULL, 0, NULL, 0, 0, 0, 0);
   EXPECT_NOT_NULL(scanner);
 
   int total_files = 0;
@@ -109,10 +109,10 @@ static void test_scanner_subdirectory() {
 static void test_scanner_empty_directory() {
   const char* dir = "test_scan_empty";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
 
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
+  DirectoryScanner* scanner =
+      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0, 0);
   EXPECT_NOT_NULL(scanner);
 
   const Chunk* chunk = directory_scanner_next(scanner);
@@ -122,281 +122,9 @@ static void test_scanner_empty_directory() {
   rmdir(dir);
 }
 
-/* --- Exclude/include pattern and size filter edge cases (Issue #56) --- */
-
-static void test_scanner_exclude_pattern() {
-  const char* dir = "test_scan_excl";
-  const char* f_txt = "test_scan_excl/keep.txt";
-  const char* f_tmp = "test_scan_excl/remove.tmp";
-  const char* content = "data";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f_txt, content);
-  create_test_file(f_tmp, content);
-
-  char* exclude[] = {"*.tmp"};
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, NULL, 0, 0,
-                                                       0, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, f_txt);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f_txt);
-  unlink(f_tmp);
-  rmdir(dir);
-}
-
-static void test_scanner_exclude_subdirectory() {
-  const char* root = "test_scan_excl_sub";
-  const char* sub = "test_scan_excl_sub/sub";
-  const char* root_txt = "test_scan_excl_sub/root.txt";
-  const char* sub_txt = "test_scan_excl_sub/sub/data.txt";
-  const char* sub_tmp = "test_scan_excl_sub/sub/temp.tmp";
-  const char* content = "data";
-
-  EXPECT_EQ_INT(mkdir(root, 0755), 0);
-  EXPECT_EQ_INT(mkdir(sub, 0755), 0);
-  create_test_file(root_txt, content);
-  create_test_file(sub_txt, content);
-  create_test_file(sub_tmp, content);
-
-  char* exclude[] = {"*.tmp"};
-  DirectoryScanner* scanner = directory_scanner_create((char*)root, false, 0, exclude, 1, NULL, 0,
-                                                       0, 0, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  int total = 0;
-  Chunk* chunk;
-  while ((chunk = directory_scanner_next(scanner)) != NULL) {
-    total += chunk->element_count;
-    for (int i = 0; i < chunk->element_count; i++) {
-      size_t len = strlen(chunk->items[i]->path);
-      EXPECT_TRUE(len < 4 || strcmp(chunk->items[i]->path + len - 4, ".tmp") != 0);
-    }
-    chunk_destroy(chunk);
-  }
-  EXPECT_EQ_INT(total, 2);
-
-  directory_scanner_destroy(scanner);
-  unlink(root_txt);
-  unlink(sub_txt);
-  unlink(sub_tmp);
-  rmdir(sub);
-  rmdir(root);
-}
-
-static void test_scanner_include_and_exclude() {
-  const char* dir = "test_scan_inc_exc";
-  const char* f_txt = "test_scan_inc_exc/a.txt";
-  const char* f_log = "test_scan_inc_exc/b.log";
-  const char* f_bak = "test_scan_inc_exc/c.bak";
-  const char* content = "filter";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f_txt, content);
-  create_test_file(f_log, content);
-  create_test_file(f_bak, content);
-
-  char* exclude[] = {"*.bak"};
-  char* include[] = {"*.txt", "*.log"};
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 2,
-                                                       0, 0, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  int found_txt = 0, found_log = 0;
-  for (int i = 0; i < chunk->element_count; i++) {
-    if (strstr(chunk->items[i]->path, "a.txt"))
-      found_txt = 1;
-    if (strstr(chunk->items[i]->path, "b.log"))
-      found_log = 1;
-  }
-  EXPECT_TRUE(found_txt);
-  EXPECT_TRUE(found_log);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f_txt);
-  unlink(f_log);
-  unlink(f_bak);
-  rmdir(dir);
-}
-
-static void test_scanner_max_size() {
-  const char* dir = "test_scan_max";
-  const char* small = "test_scan_max/small.txt";
-  const char* large = "test_scan_max/large.txt";
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(small, "tiny");
-  create_test_file(large, "this_content_is_longer_than_ten_chars");
-
-  /* max_size = 10 — only files <= 10 bytes */
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 10,
-                                                       0, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, small);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(small);
-  unlink(large);
-  rmdir(dir);
-}
-
-static void test_scanner_min_size() {
-  const char* dir = "test_scan_min";
-  const char* empty_f = "test_scan_min/empty.txt";
-  const char* data_f = "test_scan_min/data.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(empty_f, "");
-  create_test_file(data_f, "some content here");
-
-  /* min_size = 1 — only files >= 1 byte */
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 1,
-                                                       0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, data_f);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(empty_f);
-  unlink(data_f);
-  rmdir(dir);
-}
-
-static void test_scanner_size_range() {
-  const char* dir = "test_scan_range";
-  const char* tiny = "test_scan_range/tiny.txt";
-  const char* medium = "test_scan_range/med.txt";
-  const char* huge = "test_scan_range/huge.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(tiny, "ab");
-  create_test_file(medium, "hello world");
-  create_test_file(huge, "this is a much larger file for testing size filters");
-
-  /* Only files between 3 and 20 bytes */
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 20,
-                                                       3, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, medium);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(tiny);
-  unlink(medium);
-  unlink(huge);
-  rmdir(dir);
-}
-
-static void test_scanner_mixed_patterns() {
-  /* Combine exclude, include, and size filters together */
-  const char* dir = "test_scan_mixed";
-  const char* a_txt = "test_scan_mixed/a.txt"; /* size ~= 5  */
-  const char* b_bin = "test_scan_mixed/b.bin"; /* size ~= 13 */
-  const char* c_txt = "test_scan_mixed/c.txt"; /* size ~= 5  */
-  const char* d_bak = "test_scan_mixed/d.bak"; /* size ~= 42 */
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(a_txt, "aaaaa");
-  create_test_file(b_bin, "bbbbbbbbbbbbb");
-  create_test_file(c_txt, "ccccc");
-  create_test_file(d_bak, "dddddddddddddddddddddddddddddddddddddddddd");
-
-  /* Exclude *.bak, include *.txt, min_size=3, max_size=10 */
-  char* exclude[] = {"*.bak"};
-  char* include[] = {"*.txt"};
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 1,
-                                                       10, 3, 0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  /* Both a.txt and c.txt meet the criteria: .txt extension, size 5 <= 10 and >= 3 */
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(a_txt);
-  unlink(b_bin);
-  unlink(c_txt);
-  unlink(d_bak);
-  rmdir(dir);
-}
-
-static void test_scanner_no_patterns() {
-  /* Explicit test with no exclude/include patterns and no size filters.
-   * This verifies that NULL/0 for all pattern parameters works correctly. */
-  const char* dir = "test_scan_none";
-  const char* f1 = "test_scan_none/f1.txt";
-  const char* f2 = "test_scan_none/f2.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f1, "first");
-  create_test_file(f2, "second");
-
-  DirectoryScanner* scanner = directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0,
-                                                       0, false, false, false, false);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f1);
-  unlink(f2);
-  rmdir(dir);
-}
-
 void test_scanner() {
   test_scanner_single_file();
   test_scanner_multiple_files();
   test_scanner_subdirectory();
   test_scanner_empty_directory();
-  /* Issue #56: scanner pattern edge cases */
-  test_scanner_exclude_pattern();
-  test_scanner_exclude_subdirectory();
-  test_scanner_include_and_exclude();
-  test_scanner_max_size();
-  test_scanner_min_size();
-  test_scanner_size_range();
-  test_scanner_mixed_patterns();
-  test_scanner_no_patterns();
 }

tests/test_server.c

@@ -1,180 +0,0 @@
-#include "test_server.h"
-#include "config.h"
-#include "file.h"
-#include "protocol.h"
-#include "test_utils.h"
-#include "utils.h"
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/socket.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-/* Include server.c but rename main to avoid conflict with test runner's main */
-#define main server_main_
-#define FASTSYNC_SERVER_AS_LIB
-#include "server.c"
-#undef main
-
-/* Test receive_files with immediate FINISHED status */
-static void test_receive_files_finished() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/tmp/dst");
-
-  int p[2];
-  EXPECT_EQ_INT(socketpair(AF_UNIX, SOCK_STREAM, 0, p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: use p[0] for both read and write */
-    close(p[1]);
-    io_set_fds(p[0], p[0]);
-    int ret = receive_files(cfg, p[0]);
-    close(p[0]);
-    config_delete(cfg);
-    _exit(ret == 0 ? 0 : 1);
-  } else {
-    /* Parent: use p[1] for both read and write */
-    close(p[0]);
-    io_set_fds(p[1], p[1]);
-    send_status(p[1], STATUS_FINISHED);
-    /* receive_files expects an initial status, then loops.
-     * If we send STATUS_FINISHED first, it won't enter the loop body
-     * (status == STATUS_FINISHED doesn't match any case).
-     * After the loop, it checks if status == STATUS_FINISHED -> yes.
-     * Then sends STATUS_OK and returns 0. */
-    /* receive_files will send STATUS_OK back, read it */
-    Status resp;
-    receive_status(p[1], &resp);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    close(p[1]);
-
-    config_delete(cfg);
-
-    EXPECT_EQ_INT(resp, STATUS_OK);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test receive_files with STATUS_NEXT + file data */
-static void test_receive_files_single_file() {
-  const char* content = "Hello from server test!";
-  size_t len = strlen(content);
-
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/tmp/dst");
-
-  int p[2];
-  EXPECT_EQ_INT(socketpair(AF_UNIX, SOCK_STREAM, 0, p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: use p[0] for both read and write */
-    close(p[1]);
-    io_set_fds(p[0], p[0]);
-    int ret = receive_files(cfg, p[0]);
-    close(p[0]);
-    config_delete(cfg);
-    _exit(ret == 0 ? 0 : 1);
-  } else {
-    /* Parent: use p[1] for both read and write */
-    close(p[0]);
-    io_set_fds(p[1], p[1]);
-
-    /* Send initial status = STATUS_NEXT */
-    send_status(p[1], STATUS_NEXT);
-
-    /* Now send the file data */
-    File* file = file_create("test_server_file.txt");
-    EXPECT_NOT_NULL(file);
-    file->data->data = malloc(len);
-    EXPECT_NOT_NULL(file->data->data);
-    memcpy(file->data->data, content, len);
-    file->data->size = len;
-
-    /* Send path, then data (no metadata since config has use_metadata=false) */
-    send_str(p[1], file->path);
-    send_data(p[1], file->data);
-
-    file_destroy(file);
-
-    /* Now send FINISHED to complete */
-    send_status(p[1], STATUS_FINISHED);
-    Status resp;
-    receive_status(p[1], &resp);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    close(p[1]);
-
-    config_delete(cfg);
-
-    EXPECT_EQ_INT(resp, STATUS_OK);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test receive_files with STATUS_ABORT */
-static void test_receive_files_abort() {
-  Config* cfg = config_create();
-  EXPECT_NOT_NULL(cfg);
-  free(cfg->version);
-  cfg->version = str_dup(PROTOCOL_VERSION);
-  cfg->send_directory = str_dup("/src");
-  cfg->receive_root_directory = str_dup("/tmp/dst");
-
-  int p[2];
-  EXPECT_EQ_INT(socketpair(AF_UNIX, SOCK_STREAM, 0, p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    io_set_fds(p[0], p[0]);
-    int ret = receive_files(cfg, p[0]);
-    close(p[0]);
-    config_delete(cfg);
-    /* Should return -1 on abort */
-    _exit(ret == -1 ? 0 : 1);
-  } else {
-    close(p[0]);
-    io_set_fds(p[1], p[1]);
-    /* Send STATUS_ABORT */
-    send_status(p[1], STATUS_ABORT);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    close(p[1]);
-
-    config_delete(cfg);
-
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-void test_server() {
-  if (!is_running_under_valgrind()) {
-    test_receive_files_finished();
-    test_receive_files_single_file();
-    test_receive_files_abort();
-  }
-}

tests/test_server.h

@@ -1,6 +0,0 @@
-#ifndef TEST_SERVER_H
-#define TEST_SERVER_H
-
-void test_server();
-
-#endif

tests/test_transport_ssh.c

@@ -1,47 +0,0 @@
-#include "test_transport_ssh.h"
-#include "test_utils.h"
-#include "transport_ssh.h"
-
-static void test_ssh_connect_invalid_dest_no_colon() {
-  /* cppcheck-suppress constVariablePointer */
-  Client* client = client_connect_ssh("invalid-destination-no-colon", 22, NULL);
-  EXPECT_NULL(client);
-}
-
-static void test_ssh_connect_invalid_dest_empty() {
-  /* cppcheck-suppress constVariablePointer */
-  Client* client = client_connect_ssh("", 22, NULL);
-  EXPECT_NULL(client);
-}
-
-/* Test client_connect_ssh with malformed destination (just a colon).
- * parse_remote_dest succeeds, ssh is exec'd and fails, but the function
- * creates a Client that must be cleaned up. */
-static void test_ssh_connect_malformed() {
-  Client* client = client_connect_ssh(":", 22, NULL);
-  /* ssh binary exists, so exec succeeds; the function returns a Client.
-   * We just verify it doesn't crash and clean up properly. */
-  if (client != NULL) {
-    client_disconnect(client);
-    client_delete(client);
-  }
-  EXPECT_TRUE(true);
-}
-
-/* Test client_connect_ssh with valid format but unreachable host.
- * The function launches ssh which will fail to connect, returns a Client. */
-static void test_ssh_connect_unreachable() {
-  Client* client = client_connect_ssh("nonexistent.invalid:/remote/path", 22, NULL);
-  if (client != NULL) {
-    client_disconnect(client);
-    client_delete(client);
-  }
-  EXPECT_TRUE(true);
-}
-
-void test_transport_ssh() {
-  test_ssh_connect_invalid_dest_no_colon();
-  test_ssh_connect_invalid_dest_empty();
-  test_ssh_connect_malformed();
-  test_ssh_connect_unreachable();
-}

tests/test_transport_ssh.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_SSH_H
-#define TEST_TRANSPORT_SSH_H
-
-void test_transport_ssh();
-
-#endif

tests/test_transport_tcp.c

@@ -1,102 +0,0 @@
-#include "test_transport_tcp.h"
-#include "protocol.h"
-#include "test_utils.h"
-#include "transport_tcp.h"
-#include <string.h>
-#include <unistd.h>
-
-static void test_server_create_ephemeral() {
-  Server* s = server_create(0);
-  EXPECT_NOT_NULL(s);
-  EXPECT_TRUE(s->file_descriptor >= 0);
-  EXPECT_EQ_INT(s->address.sin_family, AF_INET);
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-static void test_server_delete_null() {
-  Server* s = NULL;
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-static void test_client_create() {
-  Client* c = client_create();
-  EXPECT_NOT_NULL(c);
-  EXPECT_TRUE(c->file_descriptor >= 0);
-  EXPECT_EQ_INT(c->address.sin_family, AF_INET);
-  EXPECT_EQ_INT(c->ssh_child_pid, -1);
-  EXPECT_NULL(c->ssl);
-  EXPECT_NULL(c->ssl_ctx);
-  client_disconnect(c);
-  client_delete(c);
-}
-
-static void test_client_delete_null() {
-  Client* c = NULL;
-  client_delete(c);
-}
-
-/* Test tcp_set_timeouts with valid values */
-static void test_tcp_set_timeouts() {
-  /* Just verify the function doesn't crash with edge cases */
-  tcp_set_timeouts(0, 0);   /* zero means "don't change" */
-  tcp_set_timeouts(60, 20); /* normal values */
-  tcp_set_timeouts(-1, -1); /* negative means "don't change" */
-  /* If we got here without crashing, the test passes */
-  EXPECT_TRUE(true);
-}
-
-/* Test client_connect with an invalid host (should fail gracefully) */
-static void test_client_connect_invalid_host() {
-  Client* c = client_create();
-  EXPECT_NOT_NULL(c);
-
-  /* Use a non-routable IP that will fail connect quickly */
-  bool ok = client_connect(c, "10.255.255.1", 9999);
-  EXPECT_FALSE(ok);
-
-  client_disconnect(c);
-  client_delete(c);
-}
-
-/* Test server_create with a specific port */
-static void test_server_create_specific_port() {
-  /* Port 0 = ephemeral, but try 0 and verify bind works */
-  Server* s = server_create(0);
-  EXPECT_NOT_NULL(s);
-  EXPECT_TRUE(s->file_descriptor >= 0);
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-/* Test server_create with invalid port (0 is valid for ephemeral) */
-static void test_server_delete_double() {
-  Server* s = server_create(0);
-  EXPECT_NOT_NULL(s);
-  server_delete(&s);
-  EXPECT_NULL(s);
-  /* Deleting again should be safe - pointer is already NULL */
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-/* Test client_disconnect followed by client_delete */
-static void test_client_disconnect_delete() {
-  Client* c = client_create();
-  EXPECT_NOT_NULL(c);
-  client_disconnect(c);
-  client_delete(c);
-}
-
-void test_transport_tcp() {
-  test_server_create_ephemeral();
-  test_server_delete_null();
-  test_client_create();
-  test_client_delete_null();
-  test_tcp_set_timeouts();
-  test_client_connect_invalid_host();
-  test_server_create_specific_port();
-  test_server_delete_double();
-  test_client_disconnect_delete();
-}

tests/test_transport_tcp.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_TCP_H
-#define TEST_TRANSPORT_TCP_H
-
-void test_transport_tcp();
-
-#endif

tests/test_transport_tls.c

@@ -1,61 +0,0 @@
-#include "test_transport_tls.h"
-#include "protocol.h"
-#include "test_utils.h"
-#include "transport_tcp.h"
-#include "transport_tls.h"
-#include <string.h>
-#include <unistd.h>
-
-static void test_tls_global_init() {
-  bool ok = tls_global_init();
-  EXPECT_TRUE(ok);
-}
-
-static void test_server_create_tls_without_certs() {
-  Server* s = server_create(0);
-  EXPECT_NOT_NULL(s);
-  bool ok = server_create_tls(s, NULL, NULL, NULL);
-  EXPECT_TRUE(ok);
-  EXPECT_NOT_NULL(s->ssl_ctx);
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-/* Test client_connect_tls with no server listening (should fail gracefully) */
-static void test_client_connect_tls_fail() {
-  /* Create a client to localhost on a high port with no server */
-  Client* c = client_create();
-  EXPECT_NOT_NULL(c);
-
-  /* connect to localhost:1 (no server) - should fail as connect() fails first */
-  bool ok = client_connect_tls(c, "127.0.0.1", 1, NULL, NULL, NULL);
-  EXPECT_FALSE(ok);
-
-  /* Note: client_connect_tls internally calls connect() which sets up the socket.
-   * On failure it returns false but does NOT close the socket - we need to
-   * disconnect/delete the client. The socket fd may be in an undefined state
-   * after a failed connect, so we just call client_delete which closes it. */
-  client_disconnect(c);
-  client_delete(c);
-}
-
-/* Test server_create_tls with missing cert file paths (should still create ctx without certs) */
-static void test_server_create_tls_empty_certs() {
-  Server* s = server_create(0);
-  EXPECT_NOT_NULL(s);
-
-  /* Empty string paths - SSL_CTX_use_certificate_file will fail, but function returns false */
-  bool ok = server_create_tls(s, "", "", NULL);
-  EXPECT_FALSE(ok);
-  EXPECT_NULL(s->ssl_ctx);
-
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-void test_transport_tls() {
-  test_tls_global_init();
-  test_server_create_tls_without_certs();
-  test_client_connect_tls_fail();
-  test_server_create_tls_empty_certs();
-}

tests/test_transport_tls.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_TLS_H
-#define TEST_TRANSPORT_TLS_H
-
-void test_transport_tls();
-
-#endif

tests/test_utils.h

@@ -2,24 +2,9 @@
 #define TEST_UTILS_H
 
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
 
-// Detect if running under valgrind by checking /proc/self/maps for vgpreload.
-// This is used to skip fork-based tests that are incompatible with valgrind
-// (the instrumented parent runs too slowly, causing pipe timeouts).
-static inline bool is_running_under_valgrind(void) {
-  FILE* f = fopen("/proc/self/maps", "r");
-  if (!f)
-    return false;
-  char buf[4096];
-  size_t n = fread(buf, 1, sizeof(buf) - 1, f);
-  fclose(f);
-  buf[n] = '\0';
-  return strstr(buf, "vgpreload") != NULL;
-}
-
 // Global test suite status
 extern int tests_run;
 extern int tests_failed;