Compare commits
21 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 80768d64d4 | |||
| e876055167 | |||
| 3d2eb97205 | |||
| da20bb4d37 | |||
| 3e4c571355 | |||
| 05dab758cf | |||
| 8cc587b79e | |||
| 896ff05250 | |||
| 29a6b5fd84 | |||
| dff15110e8 | |||
| 7d8f593844 | |||
| 348e72e706 | |||
| 58af932b30 | |||
| 5e9f594af9 | |||
| afe6f4144b | |||
| 016c4030c5 | |||
| 95be50fead | |||
| 7eeaeea84a | |||
| 4f383cc5a5 | |||
| 8ad91b8b87 | |||
| 69773bd16a |
@@ -60,48 +60,6 @@ python3 -m pytest tests/ # integration tests
|
|||||||
|
|
||||||
When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.
|
When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.
|
||||||
|
|
||||||
## Branch Strategy
|
|
||||||
|
|
||||||
Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch before making changes:
|
|
||||||
```bash
|
|
||||||
git checkout -b <feature-branch-name>
|
|
||||||
```
|
|
||||||
After committing changes, push the branch and create a PR:
|
|
||||||
```bash
|
|
||||||
git push -u origin <feature-branch-name>
|
|
||||||
gh pr create --fill
|
|
||||||
```
|
|
||||||
Wait for CI to pass on the PR before merging.
|
|
||||||
|
|
||||||
## Batch PR Workflow
|
|
||||||
|
|
||||||
When handling multiple issues split across several PRs that target the same files:
|
|
||||||
|
|
||||||
1. **Group issues by logical category** into separate PR branches (e.g., memory-safety, refactoring, test-coverage).
|
|
||||||
2. **Fix and push** each branch independently. Let CI run on each PR.
|
|
||||||
3. **Run all 3 reviewer types** on each PR and post results to Gitea via `tea pr approve/reject` or the Gitea API:
|
|
||||||
- `reviewer` — general code correctness
|
|
||||||
- `code-quality-guardian` — code quality, duplication, complexity
|
|
||||||
- `security-auditor` — vulnerability assessment
|
|
||||||
4. **Iterate**: if any reviewer requests changes, fix, push, re-review. Repeat until all 3 approve.
|
|
||||||
5. **Merge approved PRs** one at a time into `main`.
|
|
||||||
6. **Create a combined merge branch** for the remaining PRs that conflict with the new `main`:
|
|
||||||
```bash
|
|
||||||
git checkout -b merge-all origin/main
|
|
||||||
for branch in branch1 branch2 branch3; do
|
|
||||||
git merge origin/$branch --no-edit || true
|
|
||||||
# Resolve conflicts, build, test
|
|
||||||
done
|
|
||||||
```
|
|
||||||
7. **Run review again** on the combined branch. Fix issues, push, re-review until approved.
|
|
||||||
8. **Merge** the combined PR, **close** the redundant individual PRs, and **close all resolved issues** via the Gitea API:
|
|
||||||
```bash
|
|
||||||
curl -s -X PATCH -H "Authorization: token $TOKEN" \
|
|
||||||
-H "Content-Type: application/json" \
|
|
||||||
-d '{"state":"closed"}' \
|
|
||||||
"https://gitea.tap-tap.win/api/v1/repos/owner/repo/issues/<number>"
|
|
||||||
```
|
|
||||||
|
|
||||||
## CI Troubleshooting
|
## CI Troubleshooting
|
||||||
|
|
||||||
### If lint (clang-format) fails
|
### If lint (clang-format) fails
|
||||||
@@ -124,6 +82,99 @@ Run locally before pushing:
|
|||||||
python3 -m pytest tests/ -v --tb=short
|
python3 -m pytest tests/ -v --tb=short
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Branch Strategy
|
||||||
|
|
||||||
|
Two main branches: `dev` (integration) and `main` (stable releases).
|
||||||
|
|
||||||
|
### Rules
|
||||||
|
- **All PRs target `dev`** — never target `main` directly
|
||||||
|
- **`dev` is the default branch** in Gitea repo settings
|
||||||
|
- **`main` is protected** — only merged from `dev` via PR with 2 approvals + full CI pass
|
||||||
|
- **Feature/bug branches** branch from `dev`, PR back to `dev`
|
||||||
|
- **`dev` → `main` merges** happen on-demand or weekly, requiring full CI + review
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Start a new feature
|
||||||
|
git checkout dev && git pull
|
||||||
|
git checkout -b feat/my-feature
|
||||||
|
# ... work, commit, push
|
||||||
|
git push -u origin feat/my-feature
|
||||||
|
# Create PR targeting dev
|
||||||
|
```
|
||||||
|
|
||||||
|
### Creating the `dev` branch (one-time setup)
|
||||||
|
```bash
|
||||||
|
git checkout main && git pull
|
||||||
|
git checkout -b dev
|
||||||
|
git push origin dev
|
||||||
|
# Then in Gitea: Settings → Repository → Default Branch → dev
|
||||||
|
```
|
||||||
|
|
||||||
|
### Branch protection (Gitea repo settings)
|
||||||
|
**For `dev`:**
|
||||||
|
- ✅ Require PR for merging
|
||||||
|
- ✅ Require 1 approval
|
||||||
|
- ✅ Require status checks (all CI jobs must pass)
|
||||||
|
- ✅ Delete branch after merge
|
||||||
|
|
||||||
|
**For `main`:**
|
||||||
|
- ✅ Require PR from `dev` only
|
||||||
|
- ✅ Require CI
|
||||||
|
- ✅ Require 2 approvals
|
||||||
|
- ✅ No direct pushes
|
||||||
|
|
||||||
|
## Automated Agent Workflows
|
||||||
|
|
||||||
|
All agents run locally via the opencode CLI. There is no CI-based agent automation — agents are invoked on-demand by the developer or by this assistant.
|
||||||
|
|
||||||
|
### One-command batch workflow
|
||||||
|
|
||||||
|
For fixing a set of issues and creating one integration PR:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# 1. Run each subagent on its category
|
||||||
|
opencode run --agent security-auditor "Fix all open security issues"
|
||||||
|
opencode run --agent debugger "Fix all open bugs"
|
||||||
|
opencode run --agent test-writer "Add missing test coverage"
|
||||||
|
|
||||||
|
# 2. The assistant handles: merging branches, fixing CI failures,
|
||||||
|
# pushing, creating the integration PR, waiting for CI, iterating.
|
||||||
|
# The developer only reviews the final PR.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Issue triage loop
|
||||||
|
When you want to fix a batch of issues autonomously:
|
||||||
|
|
||||||
|
1. Tell the assistant: *"Fix all open issues and create one big PR"*
|
||||||
|
2. The assistant delegates to subagents in parallel
|
||||||
|
3. Merges their branches, handles CI failures iteratively
|
||||||
|
4. Pushes and opens the final PR
|
||||||
|
5. You review the PR once CI passes — no intermediate check-ins
|
||||||
|
|
||||||
|
### Scheduling
|
||||||
|
For periodic maintenance (security audits, code quality scans), run:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
opencode run --agent security-auditor "Audit the codebase for vulnerabilities"
|
||||||
|
opencode run --agent code-quality-guardian "Scan for code quality issues"
|
||||||
|
```
|
||||||
|
|
||||||
|
This can be cron'd locally if desired (e.g., `crontab -e` with `opencode run`).
|
||||||
|
|
||||||
|
## Is opencode a good option?
|
||||||
|
|
||||||
|
**Yes, for FastSync's needs.** The hybrid model works well:
|
||||||
|
- opencode's 17 specialized agents handle deep code analysis, fixes, tests, and reviews
|
||||||
|
- The assistant orchestrates subagents, merges branches, and iterates on CI
|
||||||
|
- You only review the final output
|
||||||
|
|
||||||
|
The key limitation: opencode is session-based, not a persistent daemon. But for the "fix all issues, one PR" workflow, this is fine — the assistant runs the full pipeline in one shot. Persistent webhook-driven automation isn't available for Gitea, but the one-shot batch approach is simpler and gives you full control over what gets merged.
|
||||||
|
|
||||||
|
### Recommendations for this project
|
||||||
|
- **Do** use the batch pattern: delegate to subagents, let the assistant merge + iterate CI, review once
|
||||||
|
- **Don't** try to run opencode in Gitea Actions — the CI container doesn't have your LLM keys or the interactive context agents need
|
||||||
|
- **If** you want fully hands-off periodic scans, set up a local cron job or systemd timer that runs `opencode run` and posts results to Gitea via API
|
||||||
|
|
||||||
## Gitea API & tea CLI
|
## Gitea API & tea CLI
|
||||||
|
|
||||||
### Check CI status via API
|
### Check CI status via API
|
||||||
|
|||||||
+511
-336
@@ -12,6 +12,454 @@
|
|||||||
#include <stdlib.h>
|
#include <stdlib.h>
|
||||||
#include <string.h>
|
#include <string.h>
|
||||||
|
|
||||||
|
/* Parse environment variables for source/destination directories and save-to-disk flag. */
|
||||||
|
static void parse_environment(const char** out_env_source, const char** out_env_dest,
|
||||||
|
bool* out_save_to_disk) {
|
||||||
|
*out_env_source = getenv("FASTSYNC_SOURCE_DIR");
|
||||||
|
*out_env_dest = getenv("FASTSYNC_DEST_DIR");
|
||||||
|
const char* env_save = getenv("FASTSYNC_SAVE_TO_DISK");
|
||||||
|
*out_save_to_disk = false;
|
||||||
|
if (env_save && (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0))
|
||||||
|
*out_save_to_disk = true;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Parse a string as a positive integer, returning true on success. */
|
||||||
|
static bool parse_positive_int(const char* s, int* out_val) {
|
||||||
|
if (!s || *s == '\0')
|
||||||
|
return false;
|
||||||
|
char* endptr;
|
||||||
|
errno = 0;
|
||||||
|
long val = strtol(s, &endptr, 10);
|
||||||
|
if (errno != 0 || *endptr != '\0' || val <= 0 || val > INT_MAX)
|
||||||
|
return false;
|
||||||
|
*out_val = (int)val;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Parse a string as a non-negative integer, returning true on success. */
|
||||||
|
static bool parse_nonneg_int(const char* s, int* out_val) {
|
||||||
|
if (!s || *s == '\0')
|
||||||
|
return false;
|
||||||
|
char* endptr;
|
||||||
|
errno = 0;
|
||||||
|
long val = strtol(s, &endptr, 10);
|
||||||
|
if (errno != 0 || *endptr != '\0' || val < 0 || val > INT_MAX)
|
||||||
|
return false;
|
||||||
|
*out_val = (int)val;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
static void print_usage(void);
|
||||||
|
static int read_patterns_from_file(const char* filepath, char*** patterns, int* count);
|
||||||
|
|
||||||
|
/* Parse CLI arguments into config. Returns 0 on success, -1 on error, 1 for help/clean-exit. */
|
||||||
|
static int parse_args(Config* config, int argc, char* argv[], int* positional_args,
|
||||||
|
int* positional_count) {
|
||||||
|
for (int i = 1; i < argc; i++) {
|
||||||
|
if (strcmp(argv[i], "--help") == 0) {
|
||||||
|
print_usage();
|
||||||
|
return 1;
|
||||||
|
} else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
|
||||||
|
config->use_compression = true;
|
||||||
|
config->use_multithreading = true;
|
||||||
|
config->use_metadata = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled archive mode (-c -m -M)");
|
||||||
|
} else if (strcmp(argv[i], "-n") == 0 || strcmp(argv[i], "--dry-run") == 0) {
|
||||||
|
config->dry_run = true;
|
||||||
|
} else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
|
||||||
|
if (!parse_positive_int(argv[++i], &config->ssh_port)) {
|
||||||
|
fprintf(stderr, "Error: invalid --port/-p value: %s\n", argv[i]);
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
} else if (strcmp(argv[i], "--delete") == 0) {
|
||||||
|
config->use_delete = true;
|
||||||
|
} else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
|
||||||
|
char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
|
||||||
|
if (!tmp) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --exclude\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->exclude_patterns = tmp;
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --exclude\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->exclude_patterns[config->exclude_count++] = dup;
|
||||||
|
} else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
|
||||||
|
char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
|
||||||
|
if (!tmp) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --include\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->include_patterns = tmp;
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --include\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->include_patterns[config->include_count++] = dup;
|
||||||
|
} else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
|
||||||
|
config->max_size = strtoull(argv[++i], NULL, 10);
|
||||||
|
} else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
|
||||||
|
config->min_size = strtoull(argv[++i], NULL, 10);
|
||||||
|
} else if (strcmp(argv[i], "--incremental") == 0) {
|
||||||
|
config->use_incremental = true;
|
||||||
|
} else if (strcmp(argv[i], "--delta") == 0) {
|
||||||
|
config->use_delta = true;
|
||||||
|
} else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
|
||||||
|
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
||||||
|
if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
|
||||||
|
config->delta_block_size = (uint32_t)val;
|
||||||
|
else
|
||||||
|
fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
|
||||||
|
} else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
|
||||||
|
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
||||||
|
if (val >= DELTA_MIN_FILE_SIZE)
|
||||||
|
config->delta_max_file_size = val;
|
||||||
|
else
|
||||||
|
fprintf(stderr, "Warning: --delta-max value %llu too small, using default\n", val);
|
||||||
|
} else if (strcmp(argv[i], "-c") == 0 || strcmp(argv[i], "-z") == 0) {
|
||||||
|
config->use_compression = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled Compression");
|
||||||
|
if (i + 1 < argc) {
|
||||||
|
char* end_ptr;
|
||||||
|
long level = strtol(argv[i + 1], &end_ptr, 10);
|
||||||
|
if (*end_ptr == '\0') {
|
||||||
|
config->compression_level = (int)level;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Set Compression level to %ld", level);
|
||||||
|
i++;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else if (strcmp(argv[i], "--source-dir") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --source-dir\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->send_directory);
|
||||||
|
config->send_directory = dup;
|
||||||
|
} else if (strcmp(argv[i], "--dest-dir") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --dest-dir\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->receive_root_directory);
|
||||||
|
config->receive_root_directory = dup;
|
||||||
|
} else if (strcmp(argv[i], "--save-to-disk") == 0) {
|
||||||
|
config->save_to_disk = true;
|
||||||
|
} else if (strcmp(argv[i], "-M") == 0 || strcmp(argv[i], "--preserve") == 0) {
|
||||||
|
config->use_metadata = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled metadata preservation");
|
||||||
|
} else if (strcmp(argv[i], "-f") == 0 || strcmp(argv[i], "--sendfile") == 0) {
|
||||||
|
config->use_sendfile = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled sendfile");
|
||||||
|
} else if (strcmp(argv[i], "-m") == 0) {
|
||||||
|
config->use_multithreading = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled Multithreading");
|
||||||
|
} else if (strcmp(argv[i], "-s") == 0) {
|
||||||
|
config->use_chunk_serialization = true;
|
||||||
|
log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
|
||||||
|
} else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --server-host\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->server_host);
|
||||||
|
config->server_host = dup;
|
||||||
|
} else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
|
||||||
|
if (!parse_positive_int(argv[++i], &config->server_port)) {
|
||||||
|
fprintf(stderr, "Error: invalid --server-port value: %s\n", argv[i]);
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
} else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
|
||||||
|
char* end;
|
||||||
|
errno = 0;
|
||||||
|
unsigned long long kbps = strtoull(argv[++i], &end, 10);
|
||||||
|
if (errno != 0 || *end != '\0' || kbps == 0) {
|
||||||
|
fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
if (kbps > ULLONG_MAX / 1024) {
|
||||||
|
fprintf(stderr, "Error: --bwlimit value too large\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
io_set_bwlimit(kbps * 1024);
|
||||||
|
log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
|
||||||
|
} else if (strcmp(argv[i], "--progress") == 0) {
|
||||||
|
config->show_progress = true;
|
||||||
|
} else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
|
||||||
|
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
||||||
|
if (val > 0)
|
||||||
|
config->chunk_size = val;
|
||||||
|
} else if (strcmp(argv[i], "--tls") == 0) {
|
||||||
|
config->use_tls = true;
|
||||||
|
} else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --cert\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->tls_cert);
|
||||||
|
config->tls_cert = dup;
|
||||||
|
} else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --key\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->tls_key);
|
||||||
|
config->tls_key = dup;
|
||||||
|
} else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --ca\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->tls_ca);
|
||||||
|
config->tls_ca = dup;
|
||||||
|
} else if (strcmp(argv[i], "--timeout") == 0 && i + 1 < argc) {
|
||||||
|
int val;
|
||||||
|
if (!parse_positive_int(argv[++i], &val)) {
|
||||||
|
fprintf(stderr, "Error: --timeout must be a positive integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->timeout = val;
|
||||||
|
} else if (strcmp(argv[i], "--contimeout") == 0 && i + 1 < argc) {
|
||||||
|
int val;
|
||||||
|
if (!parse_positive_int(argv[++i], &val)) {
|
||||||
|
fprintf(stderr, "Error: --contimeout must be a positive integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->contimeout = val;
|
||||||
|
} else if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--quiet") == 0 ||
|
||||||
|
strcmp(argv[i], "--silent") == 0) {
|
||||||
|
config->quiet = true;
|
||||||
|
} else if (strcmp(argv[i], "--backup") == 0) {
|
||||||
|
config->backup = true;
|
||||||
|
} else if (strcmp(argv[i], "--backup-dir") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --backup-dir\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->backup_dir);
|
||||||
|
config->backup_dir = dup;
|
||||||
|
} else if (strcmp(argv[i], "--stats") == 0) {
|
||||||
|
config->stats = true;
|
||||||
|
} else if (strcmp(argv[i], "--max-depth") == 0 && i + 1 < argc) {
|
||||||
|
if (!parse_nonneg_int(argv[++i], &config->max_depth)) {
|
||||||
|
fprintf(stderr, "Error: --max-depth must be a non-negative integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
} else if (strcmp(argv[i], "--log-file") == 0 && i + 1 < argc) {
|
||||||
|
FILE* lf = fopen(argv[++i], "a");
|
||||||
|
if (!lf) {
|
||||||
|
fprintf(stderr, "Error: could not open log file '%s': %s\n", argv[i], strerror(errno));
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->log_file = lf;
|
||||||
|
log_set_file(lf);
|
||||||
|
} else if (strcmp(argv[i], "--queue-size") == 0 && i + 1 < argc) {
|
||||||
|
int val;
|
||||||
|
if (!parse_positive_int(argv[++i], &val)) {
|
||||||
|
fprintf(stderr, "Error: --queue-size must be a positive integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->queue_size = val;
|
||||||
|
} else if (strcmp(argv[i], "--exclude-from") == 0 && i + 1 < argc) {
|
||||||
|
if (read_patterns_from_file(argv[++i], &config->exclude_patterns, &config->exclude_count) !=
|
||||||
|
0)
|
||||||
|
return -1;
|
||||||
|
} else if (strcmp(argv[i], "--include-from") == 0 && i + 1 < argc) {
|
||||||
|
if (read_patterns_from_file(argv[++i], &config->include_patterns, &config->include_count) !=
|
||||||
|
0)
|
||||||
|
return -1;
|
||||||
|
} else if (strcmp(argv[i], "--partial") == 0) {
|
||||||
|
config->partial = true;
|
||||||
|
} else if (strcmp(argv[i], "--fastsync-server-path") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup) {
|
||||||
|
fprintf(stderr, "Error: memory allocation failed for --fastsync-server-path\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
free(config->fastsync_server_path);
|
||||||
|
config->fastsync_server_path = dup;
|
||||||
|
} else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
|
||||||
|
set_log_level(LOG_LEVEL_DEBUG);
|
||||||
|
} else if (strcmp(argv[i], "-l") == 0 || strcmp(argv[i], "--links") == 0) {
|
||||||
|
config->follow_symlinks = true;
|
||||||
|
} else if (strcmp(argv[i], "--copy-links") == 0) {
|
||||||
|
config->copy_links = true;
|
||||||
|
} else if (strcmp(argv[i], "--safe-links") == 0) {
|
||||||
|
config->safe_links = true;
|
||||||
|
} else if (strcmp(argv[i], "--copy-unsafe-links") == 0) {
|
||||||
|
config->copy_unsafe_links = true;
|
||||||
|
} else if (strcmp(argv[i], "-H") == 0 || strcmp(argv[i], "--hard-links") == 0) {
|
||||||
|
config->preserve_hard_links = true;
|
||||||
|
} else if (strcmp(argv[i], "-A") == 0 || strcmp(argv[i], "--acls") == 0) {
|
||||||
|
config->preserve_acls = true;
|
||||||
|
} else if (strcmp(argv[i], "-X") == 0 || strcmp(argv[i], "--xattrs") == 0) {
|
||||||
|
config->preserve_xattrs = true;
|
||||||
|
} else if (strcmp(argv[i], "-D") == 0 || strcmp(argv[i], "--devices") == 0) {
|
||||||
|
config->preserve_devices = true;
|
||||||
|
} else if (strcmp(argv[i], "-S") == 0 || strcmp(argv[i], "--sparse") == 0) {
|
||||||
|
config->preserve_sparse = true;
|
||||||
|
} else if (strcmp(argv[i], "-i") == 0 || strcmp(argv[i], "--itemize-changes") == 0) {
|
||||||
|
config->itemize_changes = true;
|
||||||
|
} else if (strcmp(argv[i], "--out-format") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->out_format);
|
||||||
|
config->out_format = dup;
|
||||||
|
} else if (strcmp(argv[i], "--info") == 0 && i + 1 < argc) {
|
||||||
|
config->info_level = atoi(argv[++i]);
|
||||||
|
} else if (strcmp(argv[i], "--debug") == 0 && i + 1 < argc) {
|
||||||
|
config->debug_level = atoi(argv[++i]);
|
||||||
|
} else if (strcmp(argv[i], "--list-only") == 0) {
|
||||||
|
config->list_only = true;
|
||||||
|
} else if (strcmp(argv[i], "-h") == 0 || strcmp(argv[i], "--human-readable") == 0) {
|
||||||
|
config->human_readable = true;
|
||||||
|
} else if (strcmp(argv[i], "-u") == 0 || strcmp(argv[i], "--update") == 0) {
|
||||||
|
config->update = true;
|
||||||
|
} else if (strcmp(argv[i], "--inplace") == 0) {
|
||||||
|
config->inplace = true;
|
||||||
|
} else if (strcmp(argv[i], "--append") == 0) {
|
||||||
|
config->append = true;
|
||||||
|
} else if (strcmp(argv[i], "--append-verify") == 0) {
|
||||||
|
config->append_verify = true;
|
||||||
|
} else if (strcmp(argv[i], "--delete-excluded") == 0) {
|
||||||
|
config->delete_excluded = true;
|
||||||
|
} else if (strcmp(argv[i], "--delete-after") == 0) {
|
||||||
|
config->delete_after = true;
|
||||||
|
} else if (strcmp(argv[i], "--max-delete") == 0 && i + 1 < argc) {
|
||||||
|
int val;
|
||||||
|
if (!parse_nonneg_int(argv[++i], &val)) {
|
||||||
|
fprintf(stderr, "Error: --max-delete must be a non-negative integer\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
config->max_delete = val;
|
||||||
|
} else if (strcmp(argv[i], "--filter") == 0 && i + 1 < argc) {
|
||||||
|
if (!config->filters)
|
||||||
|
config->filters = array_list_create(free);
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
array_list_add(config->filters, dup);
|
||||||
|
} else if (strcmp(argv[i], "--files-from") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->files_from);
|
||||||
|
config->files_from = dup;
|
||||||
|
} else if (strcmp(argv[i], "--cvs-exclude") == 0) {
|
||||||
|
config->cvs_exclude = true;
|
||||||
|
} else if (strcmp(argv[i], "--prune-empty-dirs") == 0) {
|
||||||
|
config->prune_empty_dirs = true;
|
||||||
|
} else if (strcmp(argv[i], "-R") == 0 || strcmp(argv[i], "--relative") == 0) {
|
||||||
|
config->relative = true;
|
||||||
|
} else if (strcmp(argv[i], "-e") == 0 || strcmp(argv[i], "--rsh") == 0) {
|
||||||
|
if (i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->rsh_command);
|
||||||
|
config->rsh_command = dup;
|
||||||
|
} else {
|
||||||
|
fprintf(stderr, "Error: -e/--rsh requires a command argument\n");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
} else if (strcmp(argv[i], "--rsync-path") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->rsync_path);
|
||||||
|
config->rsync_path = dup;
|
||||||
|
} else if (strcmp(argv[i], "--temp-dir") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->temp_dir);
|
||||||
|
config->temp_dir = dup;
|
||||||
|
} else if (strcmp(argv[i], "--compare-dest") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->compare_dest);
|
||||||
|
config->compare_dest = dup;
|
||||||
|
} else if (strcmp(argv[i], "--copy-dest") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->copy_dest);
|
||||||
|
config->copy_dest = dup;
|
||||||
|
} else if (strcmp(argv[i], "--link-dest") == 0 && i + 1 < argc) {
|
||||||
|
char* dup = str_dup(argv[++i]);
|
||||||
|
if (!dup)
|
||||||
|
return -1;
|
||||||
|
free(config->link_dest);
|
||||||
|
config->link_dest = dup;
|
||||||
|
} else if (argv[i][0] == '-') {
|
||||||
|
fprintf(stderr, "Unknown option: %s\n", argv[i]);
|
||||||
|
print_usage();
|
||||||
|
return -1;
|
||||||
|
} else {
|
||||||
|
if (*positional_count < 2)
|
||||||
|
positional_args[(*positional_count)++] = i;
|
||||||
|
else {
|
||||||
|
fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
|
||||||
|
print_usage();
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Validate config after parsing. Returns true if valid. */
|
||||||
|
static bool validate_config(const Config* config) {
|
||||||
|
if (!config->send_directory || !config->receive_root_directory) {
|
||||||
|
fprintf(stderr, "Error: source and destination directories are required\n");
|
||||||
|
print_usage();
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
|
||||||
|
fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
|
||||||
|
"serialization)\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
|
||||||
|
fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_incremental && config->use_chunk_serialization) {
|
||||||
|
fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_delta && !config->use_incremental) {
|
||||||
|
fprintf(stderr, "Error: --delta requires --incremental\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_delta && config->use_chunk_serialization) {
|
||||||
|
fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_delta && config->use_sendfile) {
|
||||||
|
fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (config->use_tls) {
|
||||||
|
if (!config->tls_cert || !config->tls_key) {
|
||||||
|
fprintf(stderr, "Error: --tls requires --cert and --key\n");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
static void print_usage(void) {
|
static void print_usage(void) {
|
||||||
printf("Usage:\n");
|
printf("Usage:\n");
|
||||||
printf(" fastsync [options] <source> <destination>\n");
|
printf(" fastsync [options] <source> <destination>\n");
|
||||||
@@ -71,6 +519,39 @@ static void print_usage(void) {
|
|||||||
printf(" --partial Keep partial files on interrupted transfer\n");
|
printf(" --partial Keep partial files on interrupted transfer\n");
|
||||||
printf(" --fastsync-server-path <path>\n");
|
printf(" --fastsync-server-path <path>\n");
|
||||||
printf(" Path to fastsync-server on remote (default: fastsync-server)\n");
|
printf(" Path to fastsync-server on remote (default: fastsync-server)\n");
|
||||||
|
printf(" -l, --links Copy symlinks as symlinks\n");
|
||||||
|
printf(" --copy-links Transform symlinks into referent files\n");
|
||||||
|
printf(" --safe-links Skip symlinks that point outside transfer tree\n");
|
||||||
|
printf(" --copy-unsafe-links Only transform unsafe symlinks into referent files\n");
|
||||||
|
printf(" -H, --hard-links Preserve hard links\n");
|
||||||
|
printf(" -A, --acls Preserve ACLs\n");
|
||||||
|
printf(" -X, --xattrs Preserve extended attributes\n");
|
||||||
|
printf(" -D, --devices Preserve device files\n");
|
||||||
|
printf(" -S, --sparse Handle sparse files efficiently\n");
|
||||||
|
printf(" -i, --itemize-changes Show per-file change summary\n");
|
||||||
|
printf(" --out-format <fmt> Custom output format string\n");
|
||||||
|
printf(" --info <flags> Info verbosity level\n");
|
||||||
|
printf(" --debug <flags> Debug verbosity level\n");
|
||||||
|
printf(" --list-only List files without transferring\n");
|
||||||
|
printf(" -h, --human-readable Human-readable numbers\n");
|
||||||
|
printf(" -u, --update Skip files newer on destination\n");
|
||||||
|
printf(" --inplace Update files in-place (no temp+rename)\n");
|
||||||
|
printf(" --append Append data to shorter files\n");
|
||||||
|
printf(" --append-verify Append with verify\n");
|
||||||
|
printf(" --delete-excluded Also delete excluded files\n");
|
||||||
|
printf(" --delete-after Delete after transfer, not before\n");
|
||||||
|
printf(" --max-delete <n> Maximum number of files to delete\n");
|
||||||
|
printf(" --filter <rule> Add file filtering rule\n");
|
||||||
|
printf(" --files-from <file> Read file list from file\n");
|
||||||
|
printf(" --cvs-exclude Auto-ignore CVS files\n");
|
||||||
|
printf(" --prune-empty-dirs Omit empty directories from transfer\n");
|
||||||
|
printf(" -R, --relative Use relative paths\n");
|
||||||
|
printf(" -e, --rsh <cmd> Specify remote shell\n");
|
||||||
|
printf(" --rsync-path <path> Path to remote binary\n");
|
||||||
|
printf(" --temp-dir <dir> Temporary directory for files\n");
|
||||||
|
printf(" --compare-dest <dir> Compare destination\n");
|
||||||
|
printf(" --copy-dest <dir> Copy destination\n");
|
||||||
|
printf(" --link-dest <dir> Link destination\n");
|
||||||
printf(" --help Show this help\n");
|
printf(" --help Show this help\n");
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -99,327 +580,60 @@ static int read_patterns_from_file(const char* filepath, char*** patterns, int*
|
|||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
*patterns = tmp;
|
*patterns = tmp;
|
||||||
(*patterns)[*count] = str_dup(p);
|
char* dup = str_dup(p);
|
||||||
if (!(*patterns)[*count]) {
|
if (!dup) {
|
||||||
fprintf(stderr, "Error: memory allocation failed for pattern\n");
|
fprintf(stderr, "Error: memory allocation failed for pattern file\n");
|
||||||
fclose(fp);
|
fclose(fp);
|
||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
(*count)++;
|
(*patterns)[(*count)++] = dup;
|
||||||
}
|
}
|
||||||
fclose(fp);
|
fclose(fp);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
int main(int argc, char* argv[]) {
|
int main(int argc, char* argv[]) {
|
||||||
const char* env_source = getenv("FASTSYNC_SOURCE_DIR");
|
const char* env_source = NULL;
|
||||||
const char* env_dest = getenv("FASTSYNC_DEST_DIR");
|
const char* env_dest = NULL;
|
||||||
const char* env_save = getenv("FASTSYNC_SAVE_TO_DISK");
|
|
||||||
|
|
||||||
bool save_to_disk = false;
|
bool save_to_disk = false;
|
||||||
if (env_save && (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0)) {
|
parse_environment(&env_source, &env_dest, &save_to_disk);
|
||||||
save_to_disk = true;
|
|
||||||
}
|
|
||||||
|
|
||||||
int exit_code = 0;
|
int exit_code = 0;
|
||||||
Config* config = NULL;
|
|
||||||
bool config_owned_by_pipeline = false;
|
bool config_owned_by_pipeline = false;
|
||||||
|
Config* config = config_create();
|
||||||
char* config_version = str_dup(PROTOCOL_VERSION);
|
if (!config) {
|
||||||
if (!config_version) {
|
fprintf(stderr, "Error: failed to allocate config\n");
|
||||||
exit_code = 1;
|
return 1;
|
||||||
goto cleanup;
|
|
||||||
}
|
}
|
||||||
config = config_create(config_version, NULL, NULL, save_to_disk, false, false, false, false, 5,
|
config->save_to_disk = save_to_disk;
|
||||||
false, 0);
|
|
||||||
|
|
||||||
int positional_args[2];
|
int positional_args[2];
|
||||||
int positional_count = 0;
|
int positional_count = 0;
|
||||||
|
|
||||||
for (int i = 1; i < argc; i++) {
|
int parse_ret = parse_args(config, argc, argv, positional_args, &positional_count);
|
||||||
if (strcmp(argv[i], "--help") == 0) {
|
if (parse_ret != 0) {
|
||||||
print_usage();
|
if (parse_ret < 0)
|
||||||
goto cleanup;
|
|
||||||
} else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
|
|
||||||
config->use_compression = true;
|
|
||||||
config->use_multithreading = true;
|
|
||||||
config->use_metadata = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled archive mode (-c -m -M)");
|
|
||||||
} else if (strcmp(argv[i], "-n") == 0 || strcmp(argv[i], "--dry-run") == 0) {
|
|
||||||
config->dry_run = true;
|
|
||||||
} else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
|
|
||||||
char* end;
|
|
||||||
errno = 0;
|
|
||||||
long val = strtol(argv[++i], &end, 10);
|
|
||||||
if (errno != 0 || *end != '\0' || val <= 0 || val > 65535) {
|
|
||||||
fprintf(stderr, "Error: -p must be a valid port number (1-65535)\n");
|
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
config->ssh_port = (int)val;
|
|
||||||
} else if (strcmp(argv[i], "--delete") == 0) {
|
/* Handle positional arguments or fall back to environment variables */
|
||||||
config->use_delete = true;
|
if (positional_count == 2) {
|
||||||
} else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
|
|
||||||
char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
|
|
||||||
if (!tmp) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed for --exclude\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->exclude_patterns = tmp;
|
|
||||||
config->exclude_patterns[config->exclude_count] = str_dup(argv[++i]);
|
|
||||||
if (!config->exclude_patterns[config->exclude_count]) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed for exclude pattern\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->exclude_count++;
|
|
||||||
} else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
|
|
||||||
char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
|
|
||||||
if (!tmp) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed for --include\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->include_patterns = tmp;
|
|
||||||
config->include_patterns[config->include_count] = str_dup(argv[++i]);
|
|
||||||
if (!config->include_patterns[config->include_count]) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed for include pattern\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->include_count++;
|
|
||||||
} else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
|
|
||||||
char* end;
|
|
||||||
errno = 0;
|
|
||||||
config->max_size = strtoull(argv[++i], &end, 10);
|
|
||||||
if (errno != 0 || *end != '\0') {
|
|
||||||
fprintf(stderr, "Error: --max-size must be a valid non-negative integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
|
|
||||||
char* end;
|
|
||||||
errno = 0;
|
|
||||||
config->min_size = strtoull(argv[++i], &end, 10);
|
|
||||||
if (errno != 0 || *end != '\0') {
|
|
||||||
fprintf(stderr, "Error: --min-size must be a valid non-negative integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--incremental") == 0) {
|
|
||||||
config->use_incremental = true;
|
|
||||||
} else if (strcmp(argv[i], "--delta") == 0) {
|
|
||||||
config->use_delta = true;
|
|
||||||
} else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
|
|
||||||
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
|
||||||
if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
|
|
||||||
config->delta_block_size = (uint32_t)val;
|
|
||||||
else
|
|
||||||
fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
|
|
||||||
} else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
|
|
||||||
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
|
||||||
if (val >= DELTA_MIN_FILE_SIZE)
|
|
||||||
config->delta_max_file_size = val;
|
|
||||||
else
|
|
||||||
fprintf(stderr, "Warning: --delta-max value %llu too small, using default\n", val);
|
|
||||||
} else if (strcmp(argv[i], "-c") == 0 || strcmp(argv[i], "-z") == 0) {
|
|
||||||
config->use_compression = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled Compression");
|
|
||||||
if (i + 1 < argc) {
|
|
||||||
char* end_ptr;
|
|
||||||
int level = strtol(argv[i + 1], &end_ptr, 10);
|
|
||||||
if (*end_ptr == '\0') {
|
|
||||||
config->compression_level = level;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Set Compression level to %d", config->compression_level);
|
|
||||||
i++;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--source-dir") == 0 && i + 1 < argc) {
|
|
||||||
free(config->send_directory);
|
free(config->send_directory);
|
||||||
config->send_directory = str_dup(argv[++i]);
|
free(config->receive_root_directory);
|
||||||
|
config->send_directory = str_dup(argv[positional_args[0]]);
|
||||||
if (!config->send_directory) {
|
if (!config->send_directory) {
|
||||||
fprintf(stderr, "Error: memory allocation failed\n");
|
fprintf(stderr, "Error: memory allocation failed\n");
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
} else if (strcmp(argv[i], "--dest-dir") == 0 && i + 1 < argc) {
|
config->receive_root_directory = str_dup(argv[positional_args[1]]);
|
||||||
free(config->receive_root_directory);
|
|
||||||
config->receive_root_directory = str_dup(argv[++i]);
|
|
||||||
if (!config->receive_root_directory) {
|
if (!config->receive_root_directory) {
|
||||||
fprintf(stderr, "Error: memory allocation failed\n");
|
fprintf(stderr, "Error: memory allocation failed\n");
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
} else if (strcmp(argv[i], "--save-to-disk") == 0) {
|
|
||||||
config->save_to_disk = true;
|
config->save_to_disk = true;
|
||||||
} else if (strcmp(argv[i], "-M") == 0 || strcmp(argv[i], "--preserve") == 0) {
|
|
||||||
config->use_metadata = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled metadata preservation");
|
|
||||||
} else if (strcmp(argv[i], "-f") == 0 || strcmp(argv[i], "--sendfile") == 0) {
|
|
||||||
config->use_sendfile = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled sendfile");
|
|
||||||
} else if (strcmp(argv[i], "-m") == 0) {
|
|
||||||
config->use_multithreading = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled Multithreading");
|
|
||||||
} else if (strcmp(argv[i], "-s") == 0) {
|
|
||||||
config->use_chunk_serialization = true;
|
|
||||||
log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
|
|
||||||
} else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
|
|
||||||
free(config->server_host);
|
|
||||||
config->server_host = str_dup(argv[++i]);
|
|
||||||
if (!config->server_host) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
|
|
||||||
char* end;
|
|
||||||
errno = 0;
|
|
||||||
long val = strtol(argv[++i], &end, 10);
|
|
||||||
if (errno != 0 || *end != '\0' || val <= 0 || val > 65535) {
|
|
||||||
fprintf(stderr, "Error: --server-port must be a valid port number (1-65535)\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->server_port = (int)val;
|
|
||||||
} else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
|
|
||||||
char* end;
|
|
||||||
errno = 0;
|
|
||||||
unsigned long long kbps = strtoull(argv[++i], &end, 10);
|
|
||||||
if (errno != 0 || *end != '\0' || kbps == 0) {
|
|
||||||
fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
if (kbps > ULLONG_MAX / 1024) {
|
|
||||||
fprintf(stderr, "Error: --bwlimit value too large\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
io_set_bwlimit(kbps * 1024);
|
|
||||||
log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
|
|
||||||
} else if (strcmp(argv[i], "--progress") == 0) {
|
|
||||||
config->show_progress = true;
|
|
||||||
} else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
|
|
||||||
unsigned long long val = strtoull(argv[++i], NULL, 10);
|
|
||||||
if (val > 0)
|
|
||||||
config->chunk_size = val;
|
|
||||||
} else if (strcmp(argv[i], "--tls") == 0) {
|
|
||||||
config->use_tls = true;
|
|
||||||
} else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
|
|
||||||
free(config->tls_cert);
|
|
||||||
config->tls_cert = str_dup(argv[++i]);
|
|
||||||
} else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
|
|
||||||
free(config->tls_key);
|
|
||||||
config->tls_key = str_dup(argv[++i]);
|
|
||||||
} else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
|
|
||||||
free(config->tls_ca);
|
|
||||||
config->tls_ca = str_dup(argv[++i]);
|
|
||||||
} else if (strcmp(argv[i], "--timeout") == 0 && i + 1 < argc) {
|
|
||||||
config->timeout = atoi(argv[++i]);
|
|
||||||
if (config->timeout <= 0) {
|
|
||||||
fprintf(stderr, "Error: --timeout must be a positive integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--contimeout") == 0 && i + 1 < argc) {
|
|
||||||
config->contimeout = atoi(argv[++i]);
|
|
||||||
if (config->contimeout <= 0) {
|
|
||||||
fprintf(stderr, "Error: --contimeout must be a positive integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--quiet") == 0 ||
|
|
||||||
strcmp(argv[i], "--silent") == 0) {
|
|
||||||
config->quiet = true;
|
|
||||||
} else if (strcmp(argv[i], "--backup") == 0) {
|
|
||||||
config->backup = true;
|
|
||||||
} else if (strcmp(argv[i], "--backup-dir") == 0 && i + 1 < argc) {
|
|
||||||
config->backup_dir = str_dup(argv[++i]);
|
|
||||||
if (!config->backup_dir) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--stats") == 0) {
|
|
||||||
config->stats = true;
|
|
||||||
} else if (strcmp(argv[i], "--max-depth") == 0 && i + 1 < argc) {
|
|
||||||
config->max_depth = atoi(argv[++i]);
|
|
||||||
if (config->max_depth < 0) {
|
|
||||||
fprintf(stderr, "Error: --max-depth must be a non-negative integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--log-file") == 0 && i + 1 < argc) {
|
|
||||||
FILE* lf = fopen(argv[++i], "a");
|
|
||||||
if (!lf) {
|
|
||||||
fprintf(stderr, "Error: could not open log file '%s': %s\n", argv[i], strerror(errno));
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->log_file = lf;
|
|
||||||
log_set_file(lf);
|
|
||||||
} else if (strcmp(argv[i], "--queue-size") == 0 && i + 1 < argc) {
|
|
||||||
config->queue_size = atoi(argv[++i]);
|
|
||||||
if (config->queue_size <= 0) {
|
|
||||||
fprintf(stderr, "Error: --queue-size must be a positive integer\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--exclude-from") == 0 && i + 1 < argc) {
|
|
||||||
if (read_patterns_from_file(argv[++i], &config->exclude_patterns, &config->exclude_count) !=
|
|
||||||
0) {
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--include-from") == 0 && i + 1 < argc) {
|
|
||||||
if (read_patterns_from_file(argv[++i], &config->include_patterns, &config->include_count) !=
|
|
||||||
0) {
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "--partial") == 0) {
|
|
||||||
config->partial = true;
|
|
||||||
} else if (strcmp(argv[i], "--fastsync-server-path") == 0 && i + 1 < argc) {
|
|
||||||
free(config->fastsync_server_path);
|
|
||||||
config->fastsync_server_path = str_dup(argv[++i]);
|
|
||||||
if (!config->fastsync_server_path) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
} else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
|
|
||||||
set_log_level(LOG_LEVEL_DEBUG);
|
|
||||||
} else if (argv[i][0] == '-') {
|
|
||||||
fprintf(stderr, "Unknown option: %s\n", argv[i]);
|
|
||||||
print_usage();
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
} else {
|
|
||||||
if (positional_count < 2)
|
|
||||||
positional_args[positional_count++] = i;
|
|
||||||
else {
|
|
||||||
fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
|
|
||||||
print_usage();
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (positional_count == 2) {
|
|
||||||
free(config->send_directory);
|
|
||||||
free(config->receive_root_directory);
|
|
||||||
config->send_directory = str_dup(argv[positional_args[0]]);
|
|
||||||
config->receive_root_directory = str_dup(argv[positional_args[1]]);
|
|
||||||
if (!config->send_directory || !config->receive_root_directory) {
|
|
||||||
fprintf(stderr, "Error: memory allocation failed for directory paths\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
config->save_to_disk = true;
|
|
||||||
|
|
||||||
config_parse_ssh_dest(config);
|
config_parse_ssh_dest(config);
|
||||||
} else if (positional_count == 1) {
|
} else if (positional_count == 1) {
|
||||||
fprintf(stderr, "Error: missing destination argument\n");
|
fprintf(stderr, "Error: missing destination argument\n");
|
||||||
@@ -428,84 +642,45 @@ int main(int argc, char* argv[]) {
|
|||||||
goto cleanup;
|
goto cleanup;
|
||||||
} else {
|
} else {
|
||||||
if (!config->send_directory && env_source) {
|
if (!config->send_directory && env_source) {
|
||||||
config->send_directory = str_dup((char*)env_source);
|
config->send_directory = str_dup(env_source);
|
||||||
if (!config->send_directory) {
|
if (!config->send_directory) {
|
||||||
fprintf(stderr, "Error: memory allocation failed for source directory\n");
|
fprintf(stderr, "Error: memory allocation failed\n");
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (!config->receive_root_directory && env_dest) {
|
if (!config->receive_root_directory && env_dest) {
|
||||||
config->receive_root_directory = str_dup((char*)env_dest);
|
config->receive_root_directory = str_dup(env_dest);
|
||||||
if (!config->receive_root_directory) {
|
if (!config->receive_root_directory) {
|
||||||
fprintf(stderr, "Error: memory allocation failed for destination directory\n");
|
fprintf(stderr, "Error: memory allocation failed\n");
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!config->send_directory || !config->receive_root_directory) {
|
if (!validate_config(config)) {
|
||||||
fprintf(stderr, "Error: source and destination directories are required\n");
|
|
||||||
print_usage();
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
|
|
||||||
fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
|
|
||||||
"serialization)\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
|
|
||||||
fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (config->use_incremental && config->use_chunk_serialization) {
|
|
||||||
fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
|
|
||||||
exit_code = 1;
|
exit_code = 1;
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Enable implicit flags */
|
||||||
if (config->use_incremental && !config->use_metadata) {
|
if (config->use_incremental && !config->use_metadata) {
|
||||||
log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --incremental");
|
log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --incremental");
|
||||||
config->use_metadata = true;
|
config->use_metadata = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (config->use_delta && !config->use_incremental) {
|
|
||||||
fprintf(stderr, "Error: --delta requires --incremental\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
if (config->use_delta && config->use_chunk_serialization) {
|
|
||||||
fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
if (config->use_delta && config->use_sendfile) {
|
|
||||||
fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
if (config->use_delta && !config->use_metadata) {
|
if (config->use_delta && !config->use_metadata) {
|
||||||
log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --delta");
|
log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --delta");
|
||||||
config->use_metadata = true;
|
config->use_metadata = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (config->use_tls) {
|
/* Initialize TLS if needed */
|
||||||
if (!config->tls_cert || !config->tls_key) {
|
if (config->use_tls)
|
||||||
fprintf(stderr, "Error: --tls requires --cert and --key\n");
|
|
||||||
exit_code = 1;
|
|
||||||
goto cleanup;
|
|
||||||
}
|
|
||||||
tls_global_init();
|
tls_global_init();
|
||||||
}
|
|
||||||
|
|
||||||
tcp_set_timeouts(config->timeout, config->contimeout);
|
tcp_set_timeouts(config->timeout, config->contimeout);
|
||||||
|
|
||||||
|
/* Execute transfer */
|
||||||
if (config->use_multithreading) {
|
if (config->use_multithreading) {
|
||||||
config_owned_by_pipeline = true;
|
config_owned_by_pipeline = true;
|
||||||
exit_code = send_files_multithreaded(config);
|
exit_code = send_files_multithreaded(config);
|
||||||
|
|||||||
+52
-65
@@ -25,6 +25,45 @@
|
|||||||
|
|
||||||
#define STREAM_THRESHOLD (64ULL * 1024 * 1024)
|
#define STREAM_THRESHOLD (64ULL * 1024 * 1024)
|
||||||
|
|
||||||
|
/* Print dry-run manifest showing files that would be transferred. Returns 0 on success. */
|
||||||
|
static int send_dry_run_manifest(Config* config) {
|
||||||
|
DirectoryScanner* scanner = directory_scanner_create(
|
||||||
|
config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
|
||||||
|
config->exclude_count, config->include_patterns, config->include_count, config->max_size,
|
||||||
|
config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
|
||||||
|
config->safe_links, config->copy_unsafe_links);
|
||||||
|
if (!scanner)
|
||||||
|
return -1;
|
||||||
|
Chunk* chunk;
|
||||||
|
int file_count = 0;
|
||||||
|
unsigned long long total_bytes = 0;
|
||||||
|
printf("Dry run: files to be transferred\n");
|
||||||
|
while ((chunk = directory_scanner_next(scanner)) != NULL) {
|
||||||
|
for (int i = 0; i < chunk->element_count; i++) {
|
||||||
|
printf(" %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
|
||||||
|
total_bytes += chunk->items[i]->data->size;
|
||||||
|
file_count++;
|
||||||
|
}
|
||||||
|
chunk_destroy(chunk);
|
||||||
|
}
|
||||||
|
directory_scanner_destroy(scanner);
|
||||||
|
printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Send the delete manifest (list of files) to the server. Returns 0 on success, -1 on failure. */
|
||||||
|
static int send_delete_manifest(int fd, ArrayList* manifest) {
|
||||||
|
if (!send_status(fd, STATUS_MANIFEST))
|
||||||
|
return -1;
|
||||||
|
if (!send_int(fd, manifest->size))
|
||||||
|
return -1;
|
||||||
|
for (int i = 0; i < manifest->size; i++) {
|
||||||
|
if (!send_str(fd, (char*)manifest->items[i]))
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
static int incremental_check(Client* client, File* file, DeltaSignature** out_sig) {
|
static int incremental_check(Client* client, File* file, DeltaSignature** out_sig) {
|
||||||
*out_sig = NULL;
|
*out_sig = NULL;
|
||||||
if (!send_status(client->file_descriptor, STATUS_CHECK))
|
if (!send_status(client->file_descriptor, STATUS_CHECK))
|
||||||
@@ -268,14 +307,8 @@ static int send_chunks_multithreaded(void* pipeline_context) {
|
|||||||
&context->condition_not_full_loader, &context->loader_done);
|
&context->condition_not_full_loader, &context->loader_done);
|
||||||
if (current_chunk == NULL) {
|
if (current_chunk == NULL) {
|
||||||
if (context->config->use_delete) {
|
if (context->config->use_delete) {
|
||||||
if (!send_status(client->file_descriptor, STATUS_MANIFEST))
|
if (send_delete_manifest(client->file_descriptor, context->manifest) != 0)
|
||||||
goto send_fail;
|
goto send_fail;
|
||||||
if (!send_int(client->file_descriptor, context->manifest->size))
|
|
||||||
goto send_fail;
|
|
||||||
for (int i = 0; i < context->manifest->size; i++) {
|
|
||||||
if (!send_str(client->file_descriptor, (char*)context->manifest->items[i]))
|
|
||||||
goto send_fail;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
if (!send_status(client->file_descriptor, STATUS_FINISHED))
|
if (!send_status(client->file_descriptor, STATUS_FINISHED))
|
||||||
goto send_fail;
|
goto send_fail;
|
||||||
@@ -306,7 +339,8 @@ static int scan_directory_multithreaded(void* pipeline_context) {
|
|||||||
context->config->send_directory, context->config->use_metadata, context->config->chunk_size,
|
context->config->send_directory, context->config->use_metadata, context->config->chunk_size,
|
||||||
context->config->exclude_patterns, context->config->exclude_count,
|
context->config->exclude_patterns, context->config->exclude_count,
|
||||||
context->config->include_patterns, context->config->include_count, context->config->max_size,
|
context->config->include_patterns, context->config->include_count, context->config->max_size,
|
||||||
context->config->min_size, context->config->max_depth, 4);
|
context->config->min_size, context->config->max_depth, 4, context->config->follow_symlinks,
|
||||||
|
context->config->copy_links, context->config->safe_links, context->config->copy_unsafe_links);
|
||||||
|
|
||||||
Chunk* current_chunk;
|
Chunk* current_chunk;
|
||||||
while ((current_chunk = parallel_scanner_next(scanner)) != NULL) {
|
while ((current_chunk = parallel_scanner_next(scanner)) != NULL) {
|
||||||
@@ -365,27 +399,8 @@ static int load_files_multithreaded(void* pipeline_context) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
int send_files(Config* config) {
|
int send_files(Config* config) {
|
||||||
if (config->dry_run) {
|
if (config->dry_run)
|
||||||
DirectoryScanner* scanner = directory_scanner_create(
|
return send_dry_run_manifest(config);
|
||||||
config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
|
|
||||||
config->exclude_count, config->include_patterns, config->include_count, config->max_size,
|
|
||||||
config->min_size, config->max_depth);
|
|
||||||
Chunk* chunk;
|
|
||||||
int file_count = 0;
|
|
||||||
unsigned long long total_bytes = 0;
|
|
||||||
printf("Dry run: files to be transferred\n");
|
|
||||||
while ((chunk = directory_scanner_next(scanner)) != NULL) {
|
|
||||||
for (int i = 0; i < chunk->element_count; i++) {
|
|
||||||
printf(" %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
|
|
||||||
total_bytes += chunk->items[i]->data->size;
|
|
||||||
file_count++;
|
|
||||||
}
|
|
||||||
chunk_destroy(chunk);
|
|
||||||
}
|
|
||||||
directory_scanner_destroy(scanner);
|
|
||||||
printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
Client* client;
|
Client* client;
|
||||||
if (config->transport == TRANSPORT_SSH) {
|
if (config->transport == TRANSPORT_SSH) {
|
||||||
@@ -423,7 +438,8 @@ int send_files(Config* config) {
|
|||||||
DirectoryScanner* scanner = directory_scanner_create(
|
DirectoryScanner* scanner = directory_scanner_create(
|
||||||
config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
|
config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
|
||||||
config->exclude_count, config->include_patterns, config->include_count, config->max_size,
|
config->exclude_count, config->include_patterns, config->include_count, config->max_size,
|
||||||
config->min_size, config->max_depth);
|
config->min_size, config->max_depth, config->follow_symlinks, config->copy_links,
|
||||||
|
config->safe_links, config->copy_unsafe_links);
|
||||||
Chunk* current_chunk;
|
Chunk* current_chunk;
|
||||||
unsigned long long total_bytes = 0;
|
unsigned long long total_bytes = 0;
|
||||||
time_t last_progress = 0;
|
time_t last_progress = 0;
|
||||||
@@ -470,20 +486,10 @@ int send_files(Config* config) {
|
|||||||
chunk_destroy(current_chunk);
|
chunk_destroy(current_chunk);
|
||||||
}
|
}
|
||||||
if (config->use_delete) {
|
if (config->use_delete) {
|
||||||
if (!send_status(client->file_descriptor, STATUS_MANIFEST)) {
|
if (send_delete_manifest(client->file_descriptor, manifest) != 0) {
|
||||||
array_list_delete(manifest);
|
array_list_delete(manifest);
|
||||||
goto send_fail;
|
goto send_fail;
|
||||||
}
|
}
|
||||||
if (!send_int(client->file_descriptor, manifest->size)) {
|
|
||||||
array_list_delete(manifest);
|
|
||||||
goto send_fail;
|
|
||||||
}
|
|
||||||
for (int i = 0; i < manifest->size; i++) {
|
|
||||||
if (!send_str(client->file_descriptor, (char*)manifest->items[i])) {
|
|
||||||
array_list_delete(manifest);
|
|
||||||
goto send_fail;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
array_list_delete(manifest);
|
array_list_delete(manifest);
|
||||||
}
|
}
|
||||||
if (!send_status(client->file_descriptor, STATUS_FINISHED))
|
if (!send_status(client->file_descriptor, STATUS_FINISHED))
|
||||||
@@ -498,37 +504,18 @@ int send_files(Config* config) {
|
|||||||
directory_scanner_destroy(scanner);
|
directory_scanner_destroy(scanner);
|
||||||
client_disconnect(client);
|
client_disconnect(client);
|
||||||
client_delete(client);
|
client_delete(client);
|
||||||
return ok ? 0 : -1;
|
return ok ? 0 : 1;
|
||||||
|
|
||||||
send_fail:
|
send_fail:
|
||||||
directory_scanner_destroy(scanner);
|
directory_scanner_destroy(scanner);
|
||||||
client_disconnect(client);
|
client_disconnect(client);
|
||||||
client_delete(client);
|
client_delete(client);
|
||||||
return -1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
int send_files_multithreaded(Config* config) {
|
int send_files_multithreaded(Config* config) {
|
||||||
if (config->dry_run) {
|
if (config->dry_run)
|
||||||
DirectoryScanner* scanner = directory_scanner_create(
|
return send_dry_run_manifest(config);
|
||||||
config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
|
|
||||||
config->exclude_count, config->include_patterns, config->include_count, config->max_size,
|
|
||||||
config->min_size, config->max_depth);
|
|
||||||
Chunk* chunk;
|
|
||||||
int file_count = 0;
|
|
||||||
unsigned long long total_bytes = 0;
|
|
||||||
printf("Dry run: files to be transferred\n");
|
|
||||||
while ((chunk = directory_scanner_next(scanner)) != NULL) {
|
|
||||||
for (int i = 0; i < chunk->element_count; i++) {
|
|
||||||
printf(" %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
|
|
||||||
total_bytes += chunk->items[i]->data->size;
|
|
||||||
file_count++;
|
|
||||||
}
|
|
||||||
chunk_destroy(chunk);
|
|
||||||
}
|
|
||||||
directory_scanner_destroy(scanner);
|
|
||||||
printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
long pages = sysconf(_SC_AVPHYS_PAGES);
|
long pages = sysconf(_SC_AVPHYS_PAGES);
|
||||||
long page_size = sysconf(_SC_PAGE_SIZE);
|
long page_size = sysconf(_SC_PAGE_SIZE);
|
||||||
@@ -575,5 +562,5 @@ int send_files_multithreaded(Config* config) {
|
|||||||
thrd_join(sender, &sender_result);
|
thrd_join(sender, &sender_result);
|
||||||
|
|
||||||
pipeline_context_sender_destroy(context);
|
pipeline_context_sender_destroy(context);
|
||||||
return sender_result == thrd_success ? 0 : -1;
|
return sender_result == thrd_success ? 0 : 1;
|
||||||
}
|
}
|
||||||
|
|||||||
+119
-3
@@ -38,7 +38,9 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
|
|||||||
unsigned long long chunk_size, char** exclude_patterns,
|
unsigned long long chunk_size, char** exclude_patterns,
|
||||||
int exclude_count, char** include_patterns,
|
int exclude_count, char** include_patterns,
|
||||||
int include_count, unsigned long long max_size,
|
int include_count, unsigned long long max_size,
|
||||||
unsigned long long min_size, int max_depth) {
|
unsigned long long min_size, int max_depth,
|
||||||
|
bool follow_symlinks, bool copy_links, bool safe_links,
|
||||||
|
bool copy_unsafe_links) {
|
||||||
DirectoryScanner* scanner = malloc(sizeof(DirectoryScanner));
|
DirectoryScanner* scanner = malloc(sizeof(DirectoryScanner));
|
||||||
if (scanner == NULL)
|
if (scanner == NULL)
|
||||||
return NULL;
|
return NULL;
|
||||||
@@ -55,6 +57,10 @@ DirectoryScanner* directory_scanner_create(const char* root_directory, bool use_
|
|||||||
scanner->min_size = min_size;
|
scanner->min_size = min_size;
|
||||||
scanner->max_depth = max_depth;
|
scanner->max_depth = max_depth;
|
||||||
scanner->current_depth = 0;
|
scanner->current_depth = 0;
|
||||||
|
scanner->follow_symlinks = follow_symlinks;
|
||||||
|
scanner->copy_links = copy_links;
|
||||||
|
scanner->safe_links = safe_links;
|
||||||
|
scanner->copy_unsafe_links = copy_unsafe_links;
|
||||||
queue_enqueue(scanner->directories, dir_entry_create(root_directory, 0));
|
queue_enqueue(scanner->directories, dir_entry_create(root_directory, 0));
|
||||||
return scanner;
|
return scanner;
|
||||||
}
|
}
|
||||||
@@ -131,10 +137,58 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
|
|||||||
|
|
||||||
char* cur_path = path_cat(scanner->current_path, entry->d_name);
|
char* cur_path = path_cat(scanner->current_path, entry->d_name);
|
||||||
struct stat stats;
|
struct stat stats;
|
||||||
|
struct stat lstats;
|
||||||
|
bool is_symlink = false;
|
||||||
|
if (lstat(cur_path, &lstats) != 0) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
is_symlink = S_ISLNK(lstats.st_mode);
|
||||||
|
|
||||||
|
if (is_symlink && !scanner->follow_symlinks && !scanner->copy_links && !scanner->safe_links &&
|
||||||
|
!scanner->copy_unsafe_links) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (is_symlink && scanner->safe_links) {
|
||||||
|
char link_target[4096];
|
||||||
|
ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
|
||||||
|
if (len < 0) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
link_target[len] = '\0';
|
||||||
|
if (link_target[0] == '/') {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (is_symlink && scanner->copy_unsafe_links && !scanner->copy_links) {
|
||||||
|
char link_target[4096];
|
||||||
|
ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
|
||||||
|
if (len < 0) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
link_target[len] = '\0';
|
||||||
|
bool unsafe = (link_target[0] == '/');
|
||||||
|
if (!unsafe) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
bool use_lstat = is_symlink && scanner->follow_symlinks && !scanner->copy_links;
|
||||||
|
if (use_lstat) {
|
||||||
|
stats = lstats;
|
||||||
|
} else {
|
||||||
if (stat(cur_path, &stats) != 0) {
|
if (stat(cur_path, &stats) != 0) {
|
||||||
free(cur_path);
|
free(cur_path);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (S_ISDIR(stats.st_mode)) {
|
if (S_ISDIR(stats.st_mode)) {
|
||||||
int next_depth = scanner->current_depth + 1;
|
int next_depth = scanner->current_depth + 1;
|
||||||
@@ -218,6 +272,10 @@ typedef struct {
|
|||||||
unsigned long long max_size;
|
unsigned long long max_size;
|
||||||
unsigned long long min_size;
|
unsigned long long min_size;
|
||||||
int max_depth;
|
int max_depth;
|
||||||
|
bool follow_symlinks;
|
||||||
|
bool copy_links;
|
||||||
|
bool safe_links;
|
||||||
|
bool copy_unsafe_links;
|
||||||
} ParallelWorkerArg;
|
} ParallelWorkerArg;
|
||||||
|
|
||||||
static int parallel_worker_thread(void* arg) {
|
static int parallel_worker_thread(void* arg) {
|
||||||
@@ -225,7 +283,8 @@ static int parallel_worker_thread(void* arg) {
|
|||||||
for (int i = 0; i < wa->dir_count; i++) {
|
for (int i = 0; i < wa->dir_count; i++) {
|
||||||
DirectoryScanner* ds = directory_scanner_create(
|
DirectoryScanner* ds = directory_scanner_create(
|
||||||
wa->dirs[i], wa->use_metadata, wa->chunk_size, wa->exclude_patterns, wa->exclude_count,
|
wa->dirs[i], wa->use_metadata, wa->chunk_size, wa->exclude_patterns, wa->exclude_count,
|
||||||
wa->include_patterns, wa->include_count, wa->max_size, wa->min_size, wa->max_depth);
|
wa->include_patterns, wa->include_count, wa->max_size, wa->min_size, wa->max_depth,
|
||||||
|
wa->follow_symlinks, wa->copy_links, wa->safe_links, wa->copy_unsafe_links);
|
||||||
Chunk* chunk;
|
Chunk* chunk;
|
||||||
while ((chunk = directory_scanner_next(ds)) != NULL) {
|
while ((chunk = directory_scanner_next(ds)) != NULL) {
|
||||||
queue_enqueue_multithreaded(wa->ps->result_queue, chunk, &wa->ps->result_mutex,
|
queue_enqueue_multithreaded(wa->ps->result_queue, chunk, &wa->ps->result_mutex,
|
||||||
@@ -252,7 +311,8 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
|
|||||||
int exclude_count, char** include_patterns,
|
int exclude_count, char** include_patterns,
|
||||||
int include_count, unsigned long long max_size,
|
int include_count, unsigned long long max_size,
|
||||||
unsigned long long min_size, int max_depth,
|
unsigned long long min_size, int max_depth,
|
||||||
int num_threads) {
|
int num_threads, bool follow_symlinks, bool copy_links,
|
||||||
|
bool safe_links, bool copy_unsafe_links) {
|
||||||
ParallelScanner* ps = calloc(1, sizeof(ParallelScanner));
|
ParallelScanner* ps = calloc(1, sizeof(ParallelScanner));
|
||||||
if (!ps)
|
if (!ps)
|
||||||
return NULL;
|
return NULL;
|
||||||
@@ -285,11 +345,63 @@ ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata
|
|||||||
char* cur_path = path_cat(root_directory, entry->d_name);
|
char* cur_path = path_cat(root_directory, entry->d_name);
|
||||||
if (!cur_path)
|
if (!cur_path)
|
||||||
continue;
|
continue;
|
||||||
|
struct stat lstats;
|
||||||
|
if (lstat(cur_path, &lstats) != 0) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
bool is_symlink = S_ISLNK(lstats.st_mode);
|
||||||
|
|
||||||
|
// Skip symlinks unless the user explicitly enabled following/copying them.
|
||||||
|
if (is_symlink && !follow_symlinks && !copy_links && !safe_links &&
|
||||||
|
!copy_unsafe_links) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// --safe-links: reject symlinks pointing outside the source tree.
|
||||||
|
if (is_symlink && safe_links) {
|
||||||
|
char link_target[4096];
|
||||||
|
ssize_t len = readlink(cur_path, link_target, sizeof(link_target) - 1);
|
||||||
|
if (len < 0) {
|
||||||
|
free(cur_path);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
link_target[len] = ' | ||||||