Compare commits

...

12 Commits

Author SHA1 Message Date
TapTap 017c119472 fix: initialize ssl/ssl_ctx in client_connect_ssh to prevent use-after-free 2026-07-17 10:47:46 +02:00
TapTap ff3e02e977 fix: io_set_ssl NULL in client_disconnect, SSL* type safety in protocol.h 2026-07-17 10:27:27 +02:00
TapTap 431065976d Fix re-review: remove __thread from io_ssl (breaks -m), strtol port parsing, --ca warning 2026-07-17 10:26:43 +02:00
TapTap 64be95a57f Fix TLS code review issues: SSL cleanup, TLS 1.2 min, CA verify, deprecation guards, server --help, port validation, __thread io_ssl, shared accept loop 2026-07-17 10:26:42 +02:00
TapTap c5d739d160 TLS transport: OpenSSL-based encrypted TCP
- New transport_tls.h/c: TLS server (server_create_tls, server_listen_tls)
  and client (client_connect_tls) using OpenSSL
- protocol.c: io_set_ssl() + SSL_read/SSL_write in send_n_data/receive_n_data
- transport_tcp.h: ssl/ssl_ctx fields added to Server/Client structs
- config.h/c: use_tls, tls_cert, tls_key fields
- client_cli.c: --tls, --cert, --key flags
- server.c: --tls, --cert, --key, -p flags with TLS support
- CMakeLists.txt: OpenSSL::SSL + OpenSSL::Crypto linkage
- shell.nix: openssl added to buildInputs
2026-07-17 10:26:21 +02:00
TapTap 45dd62f568 Merge pull request 'Bandwidth throttling: --bwlimit <KB/s> with token bucket' (#15) from bwlimit into main
Reviewed-on: #15
2026-07-17 10:22:46 +02:00
TapTap 4f8ae5bb70 fix: bw_tokens initialized to io_bwlimit, overflow check for --bwlimit 2026-07-17 10:07:18 +02:00
TapTap e2dac589a8 Merge pull request 'Add custom opencode agents for FastSync development' (#16) from add-custom-agents into main
Reviewed-on: #16
2026-07-17 10:02:04 +02:00
TapTap 1b87131e82 Add pr-review and pr-build skills
- pr-review: read-only code review of PR branches, outputs findings report
- pr-build: builds, tests, and fixes PR branches, commits fixes
2026-07-16 17:07:44 +02:00
TapTap 3dcaf0b79d Fix bwlimit review: remove __thread (breaks -m), validate >0, handle nanosleep EINTR 2026-07-16 17:00:14 +02:00
TapTap ef6aa143d0 Add custom opencode agents for FastSync development
- c-reviewer: memory/thread safety, style review for C11 code
- test-writer: unit test generation using custom test framework
- cmake-expert: CMake build system management
- perf-analyst: transfer pipeline performance analysis
- protocol-designer: wire protocol design and extension
- doc-generator: API docs, protocol specs, usage examples
2026-07-16 16:58:22 +02:00
TapTap 09a76e2a9a Bandwidth throttling: --bwlimit <KB/s> with token bucket
- protocol.h/c: io_set_bwlimit() + token bucket in send_n_data
  (64KB chunks, nanosleep-based deficit compensation)
- client_cli.c: --bwlimit <KB/s> flag
- test.py: bandwidth limit test case
2026-07-16 15:42:16 +02:00
23 changed files with 1232 additions and 26 deletions
+75
View File
@@ -0,0 +1,75 @@
---
description: Reviews C code for memory safety, thread safety, null checks, buffer overflows, and style conventions specific to the FastSync codebase.
mode: subagent
---
You are a C code reviewer for the FastSync project — a high-performance file synchronization system written in C11.
## Your Role
Review C source files for correctness, safety, and style. You have deep knowledge of this codebase's patterns and conventions.
## Codebase Context
### Project Structure
- `src/shared/` — shared libraries (protocol, compression, queue, config, data, metadata, transport, etc.)
- `src/client/` — client CLI, file sending, scanner
- `src/server/` — TCP server
- `tests/` — unit tests with custom framework
### Key Data Types
- `Data` — generic buffer (`void *data`, `size_t size`). Always use `data_create()` / `data_destroy()`.
- `Queue` — thread-safe bounded queue with optional `item_destroyer` callback. Use `queue_create()` / `queue_destroy()`.
- `Config` — runtime configuration struct. Use `config_create()` / `config_delete()`.
- `Chunk` — collection of files for batch transfer.
- `FileMetadata` — mode, uid, gid, mtime fields.
- `Server` / `Client` — TCP transport structs.
### Threading
- Uses C11 `<threads.h>` (`thrd_t`, `mtx_t`, `cnd_t`), NOT pthreads directly.
- Producer-consumer pattern with `queue_enqueue_multithreaded()` / `queue_dequeue_multithreaded()`.
- Bounded queues use condition variables for signaling.
### Memory Conventions
- All heap allocations use `malloc`/`calloc`/`realloc` + `free`.
- Destroy functions (`data_destroy`, `queue_destroy`, `config_delete`, etc.) handle cleanup.
- Ownership is transferred at function boundaries — document who owns what.
## Review Checklist
### Memory Safety
- Every `malloc`/`calloc` has a corresponding `free` on all code paths (including error paths).
- No use-after-free: check that pointers aren't used after their destroy function is called.
- No double-free: ensure destroy functions aren't called twice on the same object.
- Null checks after allocation before use.
- Buffer sizes are correct — no off-by-one in string operations (`strlen` + 1 for null terminator).
- `Data` objects created with `data_create()` and freed with `data_destroy()`.
### Thread Safety
- Shared state accessed under proper mutex protection.
- No race conditions on queue operations — using `_multithreaded` variants when threads are involved.
- Condition variable signals happen under the lock.
- No deadlock potential — consistent lock ordering.
- `done` flags checked properly in consumer loops.
### Protocol Safety
- `send_n_data` / `receive_n_data` return values checked.
- Status codes validated before use.
- Config serialization/deserialization handles partial reads.
### Style
- Header guards: `#ifndef FILENAME_H` / `#define FILENAME_H` / `#endif`
- Function naming: `snake_case`, prefixed by module (`queue_create`, `data_compress`, `config_send`).
- `static` for file-local functions.
- Consistent pointer style: `Type *name` (space before asterisk).
- Error handling: return `false`/`NULL` on failure, log when appropriate.
## Output Format
For each issue found, report:
1. **File and line** — exact location
2. **Severity** — critical / warning / style
3. **Category** — memory / thread / protocol / style
4. **Description** — what's wrong and how to fix it
If the code is clean, say so explicitly. Be concise — don't pad with fluff.
+91
View File
@@ -0,0 +1,91 @@
---
description: Manages the CMake build system for FastSync — adding targets, source files, dependencies, compiler flags, and sanitizer configurations.
mode: subagent
---
You are a CMake expert for the FastSync project — a high-performance file synchronization system built with CMake 4.1+ and C11.
## Your Role
Manage the CMake build system: add new targets, configure dependencies, set compiler flags, and handle build configurations.
## Current Build Setup
### `CMakeLists.txt` (project root)
```cmake
cmake_minimum_required(VERSION 4.1)
project(FastFileTransfer)
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
set(CMAKE_C_STANDARD 11)
set(CMAKE_C_STANDARD_REQUIRED ON)
add_compile_options(-Wall -g -O3)
set(THREADS_PREFER_PTHREAD_FLAG ON)
find_package(Threads REQUIRED)
find_library(ZSTD_LIBRARY zstd)
# ... error if not found
# Source file collection
file(GLOB SHARED_SRCS "src/shared/*.c")
file(GLOB SERVER_SRCS "src/server/*.c")
file(GLOB CLIENT_SRCS "src/client/*.c")
file(GLOB TEST_SRCS "tests/*.c")
# Targets
add_executable(server ${SERVER_SRCS} ${SHARED_SRCS})
target_include_directories(server PRIVATE src/shared src/server src/client)
target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY})
add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS})
target_include_directories(client PRIVATE src/shared src/server src/client)
target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY})
add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c)
target_include_directories(tests PRIVATE tests src/shared src/server src/client)
target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY})
```
### Source Layout
```
src/shared/ — shared libraries (globbed as SHARED_SRCS)
src/client/ — client sources (globbed as CLIENT_SRCS)
src/server/ — server sources (globbed as SERVER_SRCS)
tests/ — test sources (globbed as TEST_SRCS)
```
### Dependencies
- **zstd** — found via `find_library(ZSTD_LIBRARY zstd)`
- **pthreads** — found via `find_package(Threads REQUIRED)`
- **C11 standard** — required
- **CMake 4.1+** — minimum version
## Conventions
- Use `file(GLOB ...)` for source collection (existing pattern).
- All targets link `Threads::Threads` and `${ZSTD_LIBRARY}`.
- Include directories: `src/shared`, `src/server`, `src/client`, `tests` (for test target).
- Sanitizer support is commented out but present (`-fsanitize=address`).
- Build with `cmake -B build -S . && cmake --build build -j$(nproc)`.
## When Making Changes
1. Preserve existing structure and conventions.
2. Use `file(GLOB)` for new source directories (match existing pattern).
3. Add new dependencies with `find_package` or `find_library`.
4. When adding a new executable target, follow the pattern of existing targets.
5. When adding a new library (static/shared), use `add_library` and follow the project's naming.
6. For sanitizer builds, use the commented-out `-fsanitize=address` lines as reference.
7. Always verify the build compiles after changes.
## Build Commands
```bash
cmake -B build -S .
cmake --build build -j$(nproc)
./build/server
./build/client
./build/tests
```
+91
View File
@@ -0,0 +1,91 @@
---
description: Generates and maintains API documentation, protocol specs, and usage examples from the FastSync C source code.
mode: subagent
---
You are a documentation generator for the FastSync project — a high-performance file synchronization system written in C11.
## Your Role
Generate accurate documentation from the actual source code. Maintain API references, protocol specifications, and usage examples.
## Project Structure
### Source Layout
```
src/shared/ — shared libraries (protocol, compression, queue, config, data, metadata, transport, etc.)
src/client/ — client CLI, file sending, scanner
src/server/ — TCP server
tests/ — unit tests
```
### Key Headers to Document
| Header | Purpose |
|--------|---------|
| `data.h` | Generic buffer type (`Data`) |
| `queue.h` | Thread-safe bounded queue |
| `chunk.h` | File chunking for batch transfer |
| `compression.h` | zstd streaming compression |
| `config.h` | Runtime configuration |
| `protocol.h` | Wire protocol (status codes, send/receive) |
| `metadata.h` | File metadata (mode, uid, gid, mtime) |
| `transport_tcp.h` | TCP client/server |
| `transport_ssh.h` | SSH transport with ControlMaster |
| `scanner.h` | Directory traversal and file scanning |
| `file.h` | File representation |
| `array_list.h` | Dynamic array |
| `log.h` | Logging utilities |
| `utils.h` | Shared utilities |
### README
The project README at `README.md` contains:
- Technical overview
- System architecture
- Protocol details
- Command-line arguments
- Environment variables
- Build instructions
- Benchmark results
## Documentation Types
### 1. API Reference (from headers)
For each public function:
- Signature (from the header)
- Brief description
- Parameters and return value
- Memory ownership rules
- Thread safety guarantees
### 2. Protocol Specification
- Wire format byte layouts
- Status code semantics
- Transfer flow diagrams
- Metadata encoding
### 3. Architecture Docs
- Data flow diagrams
- Component interactions
- Threading model
### 4. Usage Examples
- Command-line examples for common use cases
- Build instructions
- Integration scenarios
## Conventions
- Use `file:line` references when pointing to source locations
- Document actual behavior, not intended behavior
- Include error conditions and edge cases
- Keep docs close to the code they describe
- Use markdown formatting suitable for terminal rendering
## When Generating Documentation
1. Read the actual source files first — don't assume behavior
2. Cross-reference headers with implementations
3. Verify examples actually compile and work
4. Update README when adding/changing features
5. Keep protocol docs in sync with code changes
+74
View File
@@ -0,0 +1,74 @@
---
description: Analyzes performance bottlenecks in the FastSync transfer pipeline and suggests concrete optimizations for chunking, compression, threading, and network transport.
mode: subagent
---
You are a performance analyst for the FastSync project — a high-performance file synchronization system written in C11.
## Your Role
Analyze the transfer pipeline for performance bottlenecks and suggest concrete, actionable optimizations. You understand the full data flow from scanner to network.
## Architecture Overview
### Transfer Pipeline
```
DirectoryScanner → Queue(Scanner→Loader) → ChunkBuilder → Queue(Loader→Sender) → Network Send
```
1. **Scanner** — BFS traversal, builds file list, groups into chunks
2. **Loader** — reads file contents into memory
3. **Sender** — compresses + serializes + sends over TCP/SSH
### Key Components
| Component | File | Purpose |
|-----------|------|---------|
| Scanner | `src/client/scanner.c` | BFS directory traversal, exclude patterns, chunk building |
| Chunk | `src/shared/chunk.c` | File grouping (~10MB default), serialization |
| Compression | `src/shared/compression.c` | Streaming zstd (levels 122) |
| Queue | `src/shared/queue.c` | Thread-safe bounded queue with condition variables |
| Transport TCP | `src/shared/transport_tcp.c` | TCP with `sendfile()` zero-copy |
| Transport SSH | `src/shared/transport_ssh.c` | SSH with ControlMaster, socketpair |
| Protocol | `src/shared/protocol.c` | Status codes, data send/receive |
| Config | `src/shared/config.c` | Runtime parameters |
### Performance-Critical Paths
1. **Chunk size** (`DEFAULT_CHUNK_SIZE = 10MB`) — balances memory vs. transfer efficiency
2. **Compression level** (122) — trades CPU for bandwidth
3. **`sendfile()` zero-copy** — bypasses userspace, ~2× faster on loopback
4. **Multithreading** — producer-consumer with thread-safe queues
5. **SSH socketpair buffer** — set to 1MB for pipe throughput
6. **Streaming compression**`ZSTD_compressStream2` / `ZSTD_decompressStream`
## Analysis Framework
### When Analyzing, Consider
1. **CPU-bound vs I/O-bound** — Is the bottleneck CPU (compression) or I/O (disk/network)?
2. **Memory allocation** — Are there excessive malloc/free cycles in hot paths?
3. **Lock contention** — Are mutexes held too long? Is the queue the bottleneck?
4. **Syscall overhead** — Are there unnecessary read/write cycles?
5. **Pipeline stalls** — Is any stage starved or blocked?
6. **Data copying** — Are there unnecessary memcpy operations?
7. **Algorithmic** — Is the chunking/scanning algorithm optimal?
### Benchmark Context
From README benchmarks (25MB mixed files, localhost):
- Best config: `-m -c` (multithread + compression) → 0.20s, 11.2× faster than rsync
- `sendfile()` bypasses userspace → ~2× faster on localhost
- Compression reduces wire data enough that transfer becomes latency-bound on WAN
## Output Format
For each bottleneck found:
1. **Location** — file:line
2. **Impact** — high / medium / low
3. **Type** — CPU / IO / memory / lock / algorithmic
4. **Current behavior** — what's happening
5. **Suggested optimization** — concrete code change or approach
6. **Expected impact** — estimated speedup or resource savings
Also provide profiling guidance when asked (e.g., `perf`, `valgrind`, `gprof` commands).
+86
View File
@@ -0,0 +1,86 @@
---
description: Designs and extends the FastSync wire protocol — status codes, metadata format, chunk serialization, config serialization, and ensures backward compatibility.
mode: subagent
---
You are a protocol designer for the FastSync project — a high-performance file synchronization system with a custom binary wire protocol.
## Your Role
Design, extend, and document the wire protocol. Ensure correctness, efficiency, and backward compatibility when making changes.
## Current Protocol
### Status Codes (`src/shared/protocol.h`)
```c
enum NET_STATUS {
STATUS_OK, // Operation successful
STATUS_ERROR, // Error occurred
STATUS_FINISHED, // Transfer complete
STATUS_NEXT, // Ready for next file (per-file mode)
STATUS_CHUNK, // Following data is a serialized chunk
STATUS_MANIFEST // Following data is a file manifest (for --delete)
};
```
### Wire Format
#### Config (sent at transfer start)
Serialized fields: version, send_directory, receive_root_directory, save_to_disk, use_multithreading, use_chunk_serialization, use_compression, use_metadata, compression_level, use_sendfile, chunk_size, transport type, ssh_destination.
#### Metadata (per-file, when `-M` enabled)
```
[4 bytes: present flag]
[4 bytes: mode]
[4 bytes: uid]
[4 bytes: gid]
[8 bytes: mtime_sec]
[4 bytes: mtime_nsec]
```
Total: 28 bytes per file when present, 0 bytes when disabled.
#### Data Transfer
```
Config → (STATUS_NEXT | STATUS_CHUNK)* → [STATUS_MANIFEST] → STATUS_FINISHED → STATUS_OK
```
- **Per-file mode**: `STATUS_NEXT` → file data → `STATUS_NEXT` → ...
- **Chunk mode**: `STATUS_CHUNK` → serialized chunk data → ...
- **Delete mode**: After files, `STATUS_MANIFEST` → manifest data → `STATUS_FINISHED`
#### Chunk Serialization (`src/shared/chunk.c`)
Files grouped into chunks (~10MB default). Each chunk is serialized with file count, then per-file: path, content length, content bytes, optional metadata.
### Data Serialization (`src/shared/data.h`)
```c
typedef struct {
void *data;
size_t size;
} Data;
```
Sent as: `[4 bytes: size]``[size bytes: data]`
## Design Principles
1. **Efficiency** — minimize wire overhead; batch when possible
2. **Backward compatibility** — version field in config for negotiation
3. **Simplicity** — status-code-driven exchange, no complex state machines
4. **Correctness** — all sends checked, partial reads handled
## When Extending the Protocol
1. **Add new status codes** — append to enum, update protocol documentation
2. **Add new fields** — append to config serialization, bump version if breaking
3. **Add new metadata** — extend metadata format with new optional fields
4. **Wire format changes** — document exact byte layout
5. **Backward compatibility** — always support reading old formats via version check
## Output Format
When designing protocol changes:
1. **Motivation** — why the change is needed
2. **Wire format** — exact byte-level layout (hex offsets if complex)
3. **Status code changes** — new/modified codes
4. **Serialization code** — changes to `protocol.c`, `config.c`, `chunk.c`
5. **Compatibility notes** — how old clients/servers handle the change
6. **Testing strategy** — how to verify the protocol change works
+124
View File
@@ -0,0 +1,124 @@
---
description: Writes unit tests for the FastSync C codebase using the custom test framework. Creates test_*.c, test_*.h, and registers tests in runner.c.
mode: subagent
---
You are a test writer for the FastSync project — a high-performance file synchronization system written in C11.
## Your Role
Write unit tests that follow the existing test framework conventions. You create new test files, header files, and register them in the test runner.
## Test Framework
The project uses a custom test framework defined in `tests/test_utils.h`.
### Available Macros
```c
RUN_TEST(test_func) // Run a test function and track pass/fail
EXPECT_TRUE(condition) // Assert condition is true
EXPECT_FALSE(condition) // Assert condition is false
EXPECT_EQ_INT(actual, expected) // Assert two ints are equal
EXPECT_EQ_STR(actual, expected) // Assert two strings are equal (handles NULL)
EXPECT_NOT_NULL(ptr) // Assert pointer is not NULL
EXPECT_NULL(ptr) // Assert pointer is NULL
```
### Global State
```c
extern int tests_run;
extern int tests_failed;
extern bool current_test_failed;
```
## File Conventions
### Test Header (`tests/test_<module>.h`)
```c
#ifndef TEST_<MODULE>_H
#define TEST_<MODULE>_H
void test_<module>();
#endif
```
### Test Source (`tests/test_<module>.c`)
```c
#include "test_<module>.h"
#include "<module>.h" // The header being tested
#include "test_utils.h"
#include <stdlib.h>
#include <stdio.h>
static void test_<module>_<specific_case>() {
// Arrange
// Act
// Assert using EXPECT_* macros
// IMPORTANT: return immediately on failure (macros do this)
}
void test_<module>() {
test_<module>_<case1>();
test_<module>_<case2>();
// ...
}
```
### Registration in `tests/runner.c`
Add the `#include` and `RUN_TEST()` call:
```c
#include "test_<module>.h"
// ...
RUN_TEST(test_<module>);
```
## Patterns to Follow
### Memory Management in Tests
- `malloc` test data, `free` after assertions.
- Use destroy functions (`data_destroy`, `queue_destroy`, etc.) for framework objects.
- Don't leak — every allocation must be freed.
### Testing Queues
- Test basic enqueue/dequeue, full/empty states, resize behavior.
- Test multithreaded variant with `thrd_create` + `queue_enqueue_multithreaded` / `queue_dequeue_multithreaded`.
- Use `mtx_t` and `cnd_t` for thread synchronization in tests.
### Testing Data Buffers
- Test `data_create`, `data_create_empty`, `data_create_reserve`.
- Verify size and content after creation.
### Testing Compression
- Compress data, decompress, verify round-trip.
- Test with various compression levels.
### Testing Config
- Test `config_create` and `config_delete`.
- Test serialization round-trip (`config_send` + `config_receive`).
### Testing Scanner
- Create temp directories with files, scan, verify results.
- Test exclude pattern matching.
### Edge Cases to Always Cover
- NULL inputs
- Empty collections (size 0)
- Single element
- At capacity boundaries
- Invalid parameters
## Build & Run
```bash
cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests
```
## Output
When asked to write tests, produce:
1. The test header file content
2. The test source file content
3. The runner.c modification needed
4. Verify with a build and test run
+107
View File
@@ -0,0 +1,107 @@
---
name: pr-build
description: Builds and tests a pull request branch, fixing compilation errors and test failures. Use when the user says "build PR", "fix PR build", "run PR build", or wants to compile and test a PR branch.
---
# PR Build Skill
Builds, tests, and fixes a pull request branch. This skill CAN edit files, commit, and push.
## Workflow
### Step 1: Identify the PR branch
If the user specifies a PR number, check it out:
```bash
tea pr checkout <number>
```
If already on a PR branch, verify with:
```bash
git branch --show-current
git log main..HEAD --oneline
```
### Step 2: Clean build
```bash
rm -rf build
cmake -B build -S . 2>&1
cmake --build build -j$(nproc) 2>&1
```
Capture both stdout and stderr.
### Step 3: Handle build failures
If the build fails, read the error output carefully. Common issues:
**Missing include / undefined reference:**
- Check if the new `.c` file is in the right `file(GLOB ...)` directory
- Check if the new `.h` file is included properly
- Check if CMakeLists.txt needs updating (new target, new source file, new dependency)
**Type errors / implicit declarations:**
- Check function signatures match between `.h` and `.c`
- Check struct field names and types
**Linker errors:**
- Check if all required libraries are linked in CMakeLists.txt
- Check if all source files are included in the target
Use the cmake-expert agent to diagnose and fix CMake issues.
### Step 4: Run unit tests
If build succeeds:
```bash
./build/tests
```
### Step 5: Handle test failures
If tests fail:
- Read the test output carefully
- Check which test function failed and the assertion line
- Read the test source file and the module being tested
- Use the test-writer agent to investigate and fix
### Step 6: Run integration tests (optional)
```bash
python3 test.py
```
This runs the integration + benchmark suite. It takes longer — only run if the user asks or if unit tests pass.
### Step 7: Fix and commit
If fixes were needed:
```bash
git add -A
git commit -m "Fix build: <brief description of what was fixed>"
git push
```
### Step 8: Report results
Print a summary:
```
=== PR BUILD SUMMARY ===
Branch: <branch-name>
Build: [PASS/FAIL]
Unit tests: [PASS/FAIL] (<passed>/<total>)
Integration tests: [PASS/FAIL/SKIPPED]
Fixes applied: <count>
<list of fixes with commit hashes>
```
## Rules
- DO edit source files and CMakeLists.txt to fix issues
- DO commit and push fixes
- Always build from clean state (rm -rf build)
- Read error messages carefully before fixing
- Don't change functionality — only fix build/test issues
- Preserve existing code style when making fixes
+119
View File
@@ -0,0 +1,119 @@
---
name: pr-review
description: Reviews a pull request for bugs, memory safety, thread safety, and style issues. Use when the user says "review PR", "review this PR", "review pull request", or wants a code review of changes.
---
# PR Review Skill
Read-only code review of a pull request branch. Produces a report — does NOT edit files.
## Workflow
### Step 1: Identify the PR branch
If the user specifies a PR number, check it out:
```bash
tea pr checkout <number>
```
If already on a PR branch, verify with:
```bash
git branch --show-current
git log main..HEAD --oneline
```
### Step 2: Get changed files
```bash
git diff main --name-only -- '*.c' '*.h'
```
This gives the list of C source and header files changed in the PR.
### Step 3: Read all changed files
Use the Read tool to read every changed `.c` and `.h` file. Read full files — don't skip any.
### Step 4: Review each file
For each changed file, review for:
**Memory Safety**
- Every `malloc`/`calloc` has a matching `free` on all code paths (including error paths)
- No use-after-free (pointers used after `*_destroy()` is called)
- No double-free
- Null checks after allocation before use
- Correct buffer sizes (strlen + 1 for null terminators)
- `Data` objects created/destroyed properly
**Thread Safety**
- Shared state accessed under mutex
- No race conditions on queue operations
- Condition variable signals under lock
- No deadlock potential (consistent lock ordering)
- `done` flags checked properly in consumer loops
**Protocol Safety**
- `send_n_data` / `receive_n_data` return values checked
- Status codes validated before use
- Config serialization handles partial reads
**Logic Errors**
- Off-by-one in loops/buffers
- Incorrect size calculations
- Wrong enum values or comparisons
- Missing break statements in switch
**Error Handling**
- Resources freed on error paths (no leaks)
- Functions return appropriate error values
- Error messages are useful
### Step 5: Categorize findings
For each issue:
1. **File:line** — exact location
2. **Severity** — critical / warning / style
3. **Category** — memory / thread / protocol / logic / error
4. **Description** — what's wrong and how to fix it
### Step 6: Output report
Print a formatted summary:
```
=== PR REVIEW SUMMARY ===
Branch: <branch-name>
Files reviewed: <count>
Issues found: <count>
CRITICAL: <count>
WARNING: <count>
STYLE: <count>
=== ISSUES ===
[1] src/shared/compression.c:42 — CRITICAL (memory)
Potential leak: data returned from data_compress() not freed on error path
Fix: Add data_destroy(compressed) before return false
...
=== VERDICT ===
[PASS] No critical issues found
— or —
[FAIL] <N> critical issues must be fixed before merge
```
### Step 7: Optional PR comment
If the user wants to post the review as a PR comment:
```bash
tea pr comment <number> --comment "<review report>"
```
## Rules
- Do NOT edit any source files
- Do NOT run builds or tests
- Do NOT commit or push
- Report ALL issues — don't filter or minimize
- Be specific about line numbers and fix suggestions
+5 -3
View File
@@ -19,6 +19,8 @@ if(NOT ZSTD_LIBRARY)
message(FATAL_ERROR "zstd library not found. Ensure it is in your nix-shell!") message(FATAL_ERROR "zstd library not found. Ensure it is in your nix-shell!")
endif() endif()
find_package(OpenSSL REQUIRED)
file(GLOB SHARED_SRCS "src/shared/*.c") file(GLOB SHARED_SRCS "src/shared/*.c")
file(GLOB SERVER_SRCS "src/server/*.c") file(GLOB SERVER_SRCS "src/server/*.c")
file(GLOB CLIENT_SRCS "src/client/*.c") file(GLOB CLIENT_SRCS "src/client/*.c")
@@ -26,13 +28,13 @@ file(GLOB TEST_SRCS "tests/*.c")
add_executable(server ${SERVER_SRCS} ${SHARED_SRCS}) add_executable(server ${SERVER_SRCS} ${SHARED_SRCS})
target_include_directories(server PRIVATE src/shared src/server src/client) target_include_directories(server PRIVATE src/shared src/server src/client)
target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY}) target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto)
add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS}) add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS})
target_include_directories(client PRIVATE src/shared src/server src/client) target_include_directories(client PRIVATE src/shared src/server src/client)
target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY}) target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto)
add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c) add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c)
target_include_directories(tests PRIVATE tests src/shared src/server src/client) target_include_directories(tests PRIVATE tests src/shared src/server src/client)
target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY}) target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto)
+1
View File
@@ -13,6 +13,7 @@ pkgs.mkShell {
buildInputs = with pkgs; [ buildInputs = with pkgs; [
zstd zstd
openssl
]; ];
NIX_ENFORCE_PURITY = 0; NIX_ENFORCE_PURITY = 0;
+42
View File
@@ -1,7 +1,11 @@
#include "client_send.h" #include "client_send.h"
#include "config.h" #include "config.h"
#include "log.h" #include "log.h"
#include "protocol.h"
#include "transport_tls.h"
#include "utils.h" #include "utils.h"
#include <errno.h>
#include <limits.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
@@ -42,6 +46,11 @@ static void print_usage(void) {
printf(" --save-to-disk Write received files to disk\n"); printf(" --save-to-disk Write received files to disk\n");
printf(" --server-host <ip> Server IP address (default: 127.0.0.1)\n"); printf(" --server-host <ip> Server IP address (default: 127.0.0.1)\n");
printf(" --server-port <n> Server port (default: 8080)\n"); printf(" --server-port <n> Server port (default: 8080)\n");
printf(" --bwlimit <KB/s> Bandwidth limit in kilobytes per second\n");
printf(" --tls Enable TLS encryption\n");
printf(" --cert <path> TLS certificate file (PEM)\n");
printf(" --key <path> TLS private key file (PEM)\n");
printf(" --ca <path> TLS CA certificate file (PEM)\n");
printf(" --help Show this help\n"); printf(" --help Show this help\n");
} }
@@ -127,12 +136,37 @@ int main(int argc, char *argv[]) {
server_host = str_dup(argv[++i]); server_host = str_dup(argv[++i]);
} else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) { } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
server_port = atoi(argv[++i]); server_port = atoi(argv[++i]);
} else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
char *end;
errno = 0;
unsigned long long kbps = strtoull(argv[++i], &end, 10);
if (errno != 0 || *end != '\0' || kbps == 0) {
fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
return 1;
}
if (kbps > ULLONG_MAX / 1024) {
fprintf(stderr, "Error: --bwlimit value too large\n");
return 1;
}
io_set_bwlimit(kbps * 1024);
log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
} else if (strcmp(argv[i], "--progress") == 0) { } else if (strcmp(argv[i], "--progress") == 0) {
config->show_progress = true; config->show_progress = true;
} else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) { } else if (strcmp(argv[i], "--chunk-size") == 0 && i + 1 < argc) {
unsigned long long val = strtoull(argv[++i], NULL, 10); unsigned long long val = strtoull(argv[++i], NULL, 10);
if (val > 0) if (val > 0)
config->chunk_size = val; config->chunk_size = val;
} else if (strcmp(argv[i], "--tls") == 0) {
config->use_tls = true;
} else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
free(config->tls_cert);
config->tls_cert = str_dup(argv[++i]);
} else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
free(config->tls_key);
config->tls_key = str_dup(argv[++i]);
} else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
free(config->tls_ca);
config->tls_ca = str_dup(argv[++i]);
} else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) { } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
set_log_level(LOG_LEVEL_DEBUG); set_log_level(LOG_LEVEL_DEBUG);
} else if (argv[i][0] == '-') { } else if (argv[i][0] == '-') {
@@ -184,6 +218,14 @@ int main(int argc, char *argv[]) {
return 1; return 1;
} }
if (config->use_tls) {
if (!config->tls_cert || !config->tls_key) {
fprintf(stderr, "Error: --tls requires --cert and --key\n");
return 1;
}
tls_global_init();
}
if (config->use_multithreading) if (config->use_multithreading)
return send_files_multithreaded(config); return send_files_multithreaded(config);
return send_files(config); return send_files(config);
+20
View File
@@ -11,6 +11,7 @@
#include "scanner.h" #include "scanner.h"
#include "transport_tcp.h" #include "transport_tcp.h"
#include "transport_ssh.h" #include "transport_ssh.h"
#include "transport_tls.h"
#include "utils.h" #include "utils.h"
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
@@ -57,6 +58,16 @@ static int send_chunks_multithreaded(void *pipeline_context) {
return 1; return 1;
} }
client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port); client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port);
} else if (context->config->use_tls) {
client = client_create();
if (!client || !client_connect_tls(client, server_host, server_port,
context->config->tls_cert,
context->config->tls_key,
context->config->tls_ca)) {
if (client) client_delete(client);
fprintf(stderr, "Error: could not connect to server via TLS\n");
return thrd_error;
}
} else { } else {
client = client_create(); client = client_create();
if (!client || !client_connect(client, server_host, server_port)) { if (!client || !client_connect(client, server_host, server_port)) {
@@ -201,6 +212,15 @@ int send_files(Config *config) {
} }
client = client_connect_ssh(config->ssh_destination, config->ssh_port); client = client_connect_ssh(config->ssh_destination, config->ssh_port);
if (!client) return 1; if (!client) return 1;
} else if (config->use_tls) {
client = client_create();
if (!client || !client_connect_tls(client, server_host, server_port,
config->tls_cert, config->tls_key,
config->tls_ca)) {
if (client) client_delete(client);
fprintf(stderr, "Error: could not connect to server via TLS\n");
return 1;
}
} else { } else {
client = client_create(); client = client_create();
if (!client || !client_connect(client, server_host, server_port)) { if (!client || !client_connect(client, server_host, server_port)) {
+68 -3
View File
@@ -10,6 +10,7 @@
#include "protocol.h" #include "protocol.h"
#include "queue.h" #include "queue.h"
#include "transport_tcp.h" #include "transport_tcp.h"
#include "transport_tls.h"
#include "unistd.h" #include "unistd.h"
#include "utils.h" #include "utils.h"
#include <signal.h> #include <signal.h>
@@ -152,24 +153,88 @@ static void cleanup(int sig) {
_exit(0); _exit(0);
} }
static void print_server_usage(void) {
printf("FastSync Server\n");
printf("Usage: fastsync-server [options]\n");
printf("\n");
printf("Options:\n");
printf(" --stdio Run in stdio mode (SSH transport)\n");
printf(" -p <port> TCP port (default: 8080, range: 1-65535)\n");
printf(" --tls Enable TLS encryption\n");
printf(" --cert <path> TLS certificate file (PEM)\n");
printf(" --key <path> TLS private key file (PEM)\n");
printf(" --ca <path> TLS CA certificate file (PEM)\n");
printf(" -v, --verbose Enable debug logging\n");
printf(" --help Show this help\n");
}
int main(int argc, char *argv[]) { int main(int argc, char *argv[]) {
bool use_tls = false;
char *tls_cert = NULL;
char *tls_key = NULL;
char *tls_ca = NULL;
int port = 8080;
signal(SIGPIPE, SIG_IGN); signal(SIGPIPE, SIG_IGN);
for (int i = 1; i < argc; i++) { for (int i = 1; i < argc; i++) {
if (strcmp(argv[i], "--stdio") == 0) { if (strcmp(argv[i], "--help") == 0) {
print_server_usage();
return 0;
} else if (strcmp(argv[i], "--stdio") == 0) {
io_set_fds(STDIN_FILENO, STDOUT_FILENO); io_set_fds(STDIN_FILENO, STDOUT_FILENO);
handler(STDIN_FILENO); handler(STDIN_FILENO);
return 0; return 0;
} else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) { } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
set_log_level(LOG_LEVEL_DEBUG); set_log_level(LOG_LEVEL_DEBUG);
} else if (strcmp(argv[i], "--tls") == 0) {
use_tls = true;
} else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
tls_cert = argv[++i];
} else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
tls_key = argv[++i];
} else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
tls_ca = argv[++i];
} else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
char *end;
long p = strtol(argv[++i], &end, 10);
if (*end || p <= 0 || p > 65535) {
fprintf(stderr, "Error: invalid port '%s' (must be 1-65535)\n", argv[i]);
return 1;
}
port = (int)p;
} else if (argv[i][0] == '-') {
fprintf(stderr, "Unknown option: %s\n", argv[i]);
print_server_usage();
return 1;
} }
} }
if (tls_ca && !use_tls) {
log_message(LOG_LEVEL_WARNING, "--ca has no effect without --tls");
}
signal(SIGINT, cleanup); signal(SIGINT, cleanup);
signal(SIGTERM, cleanup); signal(SIGTERM, cleanup);
g_server = server_create(8080); g_server = server_create(port);
if (g_server == NULL) { if (g_server == NULL) {
log_message(LOG_LEVEL_ERROR, "Failed to create server"); log_message(LOG_LEVEL_ERROR, "Failed to create server");
return 1; return 1;
} }
server_listen(g_server, handler); if (use_tls) {
if (!tls_cert || !tls_key) {
fprintf(stderr, "Error: --tls requires --cert and --key\n");
server_delete(&g_server);
return 1;
}
tls_global_init();
if (!server_create_tls(g_server, tls_cert, tls_key, tls_ca)) {
log_message(LOG_LEVEL_ERROR, "Failed to set up TLS");
server_delete(&g_server);
return 1;
}
server_listen_tls(g_server, handler);
} else {
server_listen(g_server, handler);
}
return 0; return 0;
} }
+11
View File
@@ -38,6 +38,10 @@ Config *config_create(char *version, char *send_directory,
config->include_count = 0; config->include_count = 0;
config->max_size = 0; config->max_size = 0;
config->min_size = 0; config->min_size = 0;
config->use_tls = false;
config->tls_cert = NULL;
config->tls_key = NULL;
config->tls_ca = NULL;
return config; return config;
} }
@@ -73,6 +77,9 @@ void config_delete(Config *config) {
for (int i = 0; i < config->include_count; i++) for (int i = 0; i < config->include_count; i++)
free(config->include_patterns[i]); free(config->include_patterns[i]);
free(config->include_patterns); free(config->include_patterns);
free(config->tls_cert);
free(config->tls_key);
free(config->tls_ca);
free(config); free(config);
} }
@@ -145,6 +152,10 @@ Config *config_receive(int file_descriptor) {
config->include_count = 0; config->include_count = 0;
config->max_size = 0; config->max_size = 0;
config->min_size = 0; config->min_size = 0;
config->use_tls = false;
config->tls_cert = NULL;
config->tls_key = NULL;
config->tls_ca = NULL;
if (!send_status(file_descriptor, STATUS_OK)) goto error; if (!send_status(file_descriptor, STATUS_OK)) goto error;
return config; return config;
+4
View File
@@ -32,6 +32,10 @@ typedef struct Config {
int include_count; int include_count;
unsigned long long max_size; unsigned long long max_size;
unsigned long long min_size; unsigned long long min_size;
bool use_tls;
char *tls_cert;
char *tls_key;
char *tls_ca;
} Config; } Config;
#define PROTOCOL_VERSION "1.0.0" #define PROTOCOL_VERSION "1.0.0"
+63 -4
View File
@@ -1,18 +1,65 @@
#include "protocol.h" #include "protocol.h"
#include "log.h" #include "log.h"
#include <errno.h>
#include <openssl/ssl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <time.h>
#include <unistd.h> #include <unistd.h>
static __thread int io_read_fd = -1; static __thread int io_read_fd = -1;
static __thread int io_write_fd = -1; static __thread int io_write_fd = -1;
static SSL *io_ssl = NULL;
static unsigned long long io_bwlimit = 0;
static long long bw_tokens = 0;
static struct timespec bw_last_refill = {0, 0};
void io_set_fds(int read_fd, int write_fd) { void io_set_fds(int read_fd, int write_fd) {
io_read_fd = read_fd; io_read_fd = read_fd;
io_write_fd = write_fd; io_write_fd = write_fd;
} }
void io_set_bwlimit(unsigned long long bytes_per_sec) {
io_bwlimit = bytes_per_sec;
bw_tokens = (long long)io_bwlimit;
clock_gettime(CLOCK_MONOTONIC, &bw_last_refill);
}
static void bw_throttle(size_t bytes_written) {
if (io_bwlimit == 0) return;
struct timespec now;
clock_gettime(CLOCK_MONOTONIC, &now);
long long elapsed_ns = (now.tv_sec - bw_last_refill.tv_sec) * 1000000000LL +
(now.tv_nsec - bw_last_refill.tv_nsec);
bw_last_refill = now;
long long tokens_to_add = (long long)((double)io_bwlimit * elapsed_ns / 1000000000.0);
bw_tokens += tokens_to_add;
if (bw_tokens > (long long)io_bwlimit)
bw_tokens = (long long)io_bwlimit;
bw_tokens -= (long long)bytes_written;
if (bw_tokens < 0) {
long long deficit_ns = (long long)((double)(-bw_tokens) / io_bwlimit * 1000000000.0);
struct timespec sleep_time, remaining;
sleep_time.tv_sec = deficit_ns / 1000000000LL;
sleep_time.tv_nsec = deficit_ns % 1000000000LL;
while (nanosleep(&sleep_time, &remaining) < 0 && errno == EINTR)
sleep_time = remaining;
bw_tokens = 0;
clock_gettime(CLOCK_MONOTONIC, &bw_last_refill);
}
}
void io_set_ssl(SSL *ssl) {
io_ssl = ssl;
}
static int io_fd(int dir_fd, int file_descriptor) { static int io_fd(int dir_fd, int file_descriptor) {
return (dir_fd != -1) ? dir_fd : file_descriptor; return (dir_fd != -1) ? dir_fd : file_descriptor;
} }
@@ -22,12 +69,19 @@ bool send_n_data(int file_descriptor, void *data, size_t data_size) {
int fd = io_fd(io_write_fd, file_descriptor); int fd = io_fd(io_write_fd, file_descriptor);
ssize_t total_bytes_send = 0; ssize_t total_bytes_send = 0;
while (total_bytes_send < data_size) { while (total_bytes_send < data_size) {
ssize_t bytes_send = size_t chunk = data_size - total_bytes_send;
write(fd, (char *)data + total_bytes_send, data_size - total_bytes_send); if (io_bwlimit > 0 && chunk > 65536)
chunk = 65536;
ssize_t bytes_send;
if (io_ssl)
bytes_send = SSL_write(io_ssl, (char *)data + total_bytes_send, chunk);
else
bytes_send = write(fd, (char *)data + total_bytes_send, chunk);
if (bytes_send <= 0) { if (bytes_send <= 0) {
log_message(LOG_LEVEL_ERROR, "Could not send data"); log_message(LOG_LEVEL_ERROR, "Could not send data");
return false; return false;
} }
bw_throttle((size_t)bytes_send);
total_bytes_send += bytes_send; total_bytes_send += bytes_send;
} }
log_message(LOG_LEVEL_DEBUG, " Send n Data: %zu", total_bytes_send); log_message(LOG_LEVEL_DEBUG, " Send n Data: %zu", total_bytes_send);
@@ -39,8 +93,13 @@ bool receive_n_data(int file_descriptor, void *data, size_t data_size) {
int fd = io_fd(io_read_fd, file_descriptor); int fd = io_fd(io_read_fd, file_descriptor);
size_t total_bytes_received = 0; size_t total_bytes_received = 0;
while (total_bytes_received < data_size) { while (total_bytes_received < data_size) {
ssize_t bytes_received = ssize_t bytes_received;
read(fd, (char *)data + total_bytes_received, data_size - total_bytes_received); if (io_ssl)
bytes_received = SSL_read(io_ssl, (char *)data + total_bytes_received,
data_size - total_bytes_received);
else
bytes_received = read(fd, (char *)data + total_bytes_received,
data_size - total_bytes_received);
if (bytes_received <= 0) { if (bytes_received <= 0) {
if (bytes_received == 0) if (bytes_received == 0)
log_message(LOG_LEVEL_ERROR, "Connection closed while receiving data"); log_message(LOG_LEVEL_ERROR, "Connection closed while receiving data");
+5
View File
@@ -5,10 +5,15 @@
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h> #include <stddef.h>
typedef struct ssl_st SSL;
typedef int Status; typedef int Status;
enum NET_STATUS { STATUS_OK, STATUS_ERROR, STATUS_FINISHED, STATUS_NEXT, STATUS_CHUNK, STATUS_MANIFEST }; enum NET_STATUS { STATUS_OK, STATUS_ERROR, STATUS_FINISHED, STATUS_NEXT, STATUS_CHUNK, STATUS_MANIFEST };
void io_set_fds(int read_fd, int write_fd); void io_set_fds(int read_fd, int write_fd);
void io_set_bwlimit(unsigned long long bytes_per_sec);
typedef struct ssl_st SSL;
void io_set_ssl(SSL *ssl);
bool send_n_data(int file_descriptor, void *data, size_t data_size); bool send_n_data(int file_descriptor, void *data, size_t data_size);
bool receive_n_data(int file_descriptor, void *data, size_t data_size); bool receive_n_data(int file_descriptor, void *data, size_t data_size);
+2
View File
@@ -143,5 +143,7 @@ Client *client_connect_ssh(char *destination, int port) {
client->address.sin_family = AF_UNIX; client->address.sin_family = AF_UNIX;
client->address_length = 0; client->address_length = 0;
client->ssh_child_pid = pid; client->ssh_child_pid = pid;
client->ssl = NULL;
client->ssl_ctx = NULL;
return client; return client;
} }
+50 -16
View File
@@ -1,6 +1,8 @@
#include "transport_tcp.h" #include "transport_tcp.h"
#include "log.h" #include "log.h"
#include "protocol.h"
#include <arpa/inet.h> #include <arpa/inet.h>
#include <openssl/ssl.h>
#include <signal.h> #include <signal.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
@@ -36,6 +38,7 @@ Server *server_create(int port) {
server->address.sin_addr.s_addr = INADDR_ANY; server->address.sin_addr.s_addr = INADDR_ANY;
server->address.sin_port = htons(port); server->address.sin_port = htons(port);
server->address_length = sizeof(server->address); server->address_length = sizeof(server->address);
server->ssl_ctx = NULL;
if (bind(server->file_descriptor, (struct sockaddr *)&server->address, if (bind(server->file_descriptor, (struct sockaddr *)&server->address,
server->address_length) < 0) { server->address_length) < 0) {
@@ -51,43 +54,63 @@ Server *server_create(int port) {
void server_delete(Server **server) { void server_delete(Server **server) {
if (server == NULL || *server == NULL) return; if (server == NULL || *server == NULL) return;
close((*server)->file_descriptor); close((*server)->file_descriptor);
if ((*server)->ssl_ctx) {
SSL_CTX_free((*server)->ssl_ctx);
(*server)->ssl_ctx = NULL;
}
free(*server); free(*server);
*server = NULL; *server = NULL;
} }
bool server_listen(Server *server, void (*handler)(int file_descriptor)) { static void accept_loop(Server *server, void (*child_fn)(int, void *),
log_message(LOG_LEVEL_INFO, "Start Listening on Port: %d", void *child_ctx, const char *log_fmt) {
server->address.sin_port);
if (listen(server->file_descriptor, SOMAXCONN) < 0) { if (listen(server->file_descriptor, SOMAXCONN) < 0) {
perror("Could not listen on port!"); perror("Could not listen on port!");
return false; return;
} }
signal(SIGCHLD, SIG_IGN); signal(SIGCHLD, SIG_IGN);
while (1) { while (1) {
struct sockaddr_in client_addr; struct sockaddr_in client_addr;
socklen_t client_len = sizeof(client_addr); socklen_t client_len = sizeof(client_addr);
int file_descriptor = int fd = accept(server->file_descriptor, (struct sockaddr *)&client_addr,
accept(server->file_descriptor, (struct sockaddr *)&client_addr, &client_len);
&client_len); if (fd < 0) {
if (file_descriptor < 0) {
perror("Could not accept the connection"); perror("Could not accept the connection");
continue; continue;
} }
log_message(LOG_LEVEL_INFO, "Received Connection"); log_message(LOG_LEVEL_INFO, "%s", log_fmt);
pid_t pid = fork(); pid_t pid = fork();
if (pid == 0) { if (pid == 0) {
close(server->file_descriptor); close(server->file_descriptor);
handler(file_descriptor); child_fn(fd, child_ctx);
close(file_descriptor); close(fd);
_exit(0); _exit(0);
} }
close(file_descriptor); close(fd);
} }
}
struct plain_ctx { void (*handler)(int); };
static void plain_child_fn(int fd, void *ctx) {
((struct plain_ctx *)ctx)->handler(fd);
}
bool server_listen(Server *server, void (*handler)(int file_descriptor)) {
log_message(LOG_LEVEL_INFO, "Start Listening on Port: %d",
ntohs(server->address.sin_port));
struct plain_ctx ctx = {handler};
accept_loop(server, plain_child_fn, &ctx, "Received Connection");
return true; return true;
} }
void server_accept_loop(Server *server, void (*child_fn)(int, void *),
void *child_ctx, const char *log_fmt) {
log_message(LOG_LEVEL_INFO, "Start TLS Listening on Port: %d",
ntohs(server->address.sin_port));
accept_loop(server, child_fn, child_ctx, log_fmt);
}
Client *client_create() { Client *client_create() {
int file_descriptor = socket(AF_INET, SOCK_STREAM, 0); int file_descriptor = socket(AF_INET, SOCK_STREAM, 0);
if (file_descriptor < 0) { if (file_descriptor < 0) {
@@ -104,6 +127,8 @@ Client *client_create() {
client->address.sin_family = AF_INET; client->address.sin_family = AF_INET;
client->address_length = sizeof(client->address); client->address_length = sizeof(client->address);
client->ssh_child_pid = -1; client->ssh_child_pid = -1;
client->ssl = NULL;
client->ssl_ctx = NULL;
return client; return client;
} }
@@ -124,6 +149,12 @@ bool client_connect(Client *client, char *host, int port) {
} }
void client_disconnect(Client *client) { void client_disconnect(Client *client) {
if (client->ssl) {
SSL_shutdown(client->ssl);
SSL_free(client->ssl);
client->ssl = NULL;
io_set_ssl(NULL);
}
close(client->file_descriptor); close(client->file_descriptor);
if (client->ssh_child_pid > 0) { if (client->ssh_child_pid > 0) {
int status; int status;
@@ -133,7 +164,10 @@ void client_disconnect(Client *client) {
} }
void client_delete(Client *client) { void client_delete(Client *client) {
if (client == NULL) if (client == NULL) return;
return; if (client->ssl_ctx) {
SSL_CTX_free(client->ssl_ctx);
client->ssl_ctx = NULL;
}
free(client); free(client);
} }
+5
View File
@@ -9,6 +9,7 @@ typedef struct Server {
struct sockaddr_in address; struct sockaddr_in address;
unsigned int address_length; unsigned int address_length;
int file_descriptor; int file_descriptor;
void *ssl_ctx;
} Server; } Server;
typedef struct Client { typedef struct Client {
@@ -16,10 +17,14 @@ typedef struct Client {
unsigned int address_length; unsigned int address_length;
int file_descriptor; int file_descriptor;
pid_t ssh_child_pid; pid_t ssh_child_pid;
void *ssl;
void *ssl_ctx;
} Client; } Client;
Server *server_create(int port); Server *server_create(int port);
bool server_listen(Server *server, void (*handler)(int file_descriptor)); bool server_listen(Server *server, void (*handler)(int file_descriptor));
void server_accept_loop(Server *server, void (*child_fn)(int, void *),
void *child_ctx, const char *log_fmt);
void server_delete(Server **server); void server_delete(Server **server);
Client *client_create(); Client *client_create();
bool client_connect(Client *client, char *host, int port); bool client_connect(Client *client, char *host, int port);
+162
View File
@@ -0,0 +1,162 @@
#include "transport_tls.h"
#include "log.h"
#include "protocol.h"
#include "transport_tcp.h"
#include <arpa/inet.h>
#include <openssl/err.h>
#include <openssl/ssl.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/socket.h>
#include <sys/wait.h>
#include <unistd.h>
bool tls_global_init(void) {
#if OPENSSL_VERSION_NUMBER < 0x10100000L
SSL_library_init();
OpenSSL_add_all_algorithms();
SSL_load_error_strings();
#endif
return true;
}
static void log_ssl_errors(void) {
unsigned long err;
char buf[256];
while ((err = ERR_get_error()) != 0) {
ERR_error_string_n(err, buf, sizeof(buf));
log_message(LOG_LEVEL_ERROR, "SSL error: %s", buf);
}
}
static SSL_CTX *create_ssl_ctx(bool is_server, const char *cert,
const char *key, const char *ca_path) {
const SSL_METHOD *method =
is_server ? TLS_server_method() : TLS_client_method();
SSL_CTX *ctx = SSL_CTX_new(method);
if (!ctx) {
log_message(LOG_LEVEL_ERROR, "Unable to create SSL context");
log_ssl_errors();
return NULL;
}
SSL_CTX_set_min_proto_version(ctx, TLS1_2_VERSION);
if (cert && key) {
if (SSL_CTX_use_certificate_file(ctx, cert, SSL_FILETYPE_PEM) <= 0) {
log_message(LOG_LEVEL_ERROR, "Failed to load certificate: %s", cert);
log_ssl_errors();
SSL_CTX_free(ctx);
return NULL;
}
if (SSL_CTX_use_PrivateKey_file(ctx, key, SSL_FILETYPE_PEM) <= 0) {
log_message(LOG_LEVEL_ERROR, "Failed to load private key: %s", key);
log_ssl_errors();
SSL_CTX_free(ctx);
return NULL;
}
if (!SSL_CTX_check_private_key(ctx)) {
log_message(LOG_LEVEL_ERROR,
"Private key does not match certificate");
SSL_CTX_free(ctx);
return NULL;
}
}
if (ca_path) {
if (!SSL_CTX_load_verify_locations(ctx, ca_path, NULL)) {
log_message(LOG_LEVEL_ERROR, "Failed to load CA: %s", ca_path);
log_ssl_errors();
SSL_CTX_free(ctx);
return NULL;
}
SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);
SSL_CTX_set_verify_depth(ctx, 4);
}
return ctx;
}
static SSL *wrap_fd_with_ssl(int fd, SSL_CTX *ctx, bool is_server) {
SSL *ssl = SSL_new(ctx);
if (!ssl) {
log_message(LOG_LEVEL_ERROR, "Failed to create SSL object");
return NULL;
}
SSL_set_fd(ssl, fd);
int ret;
if (is_server)
ret = SSL_accept(ssl);
else
ret = SSL_connect(ssl);
if (ret <= 0) {
log_message(LOG_LEVEL_ERROR, "SSL %s failed",
is_server ? "accept" : "connect");
log_ssl_errors();
SSL_free(ssl);
return NULL;
}
return ssl;
}
bool server_create_tls(Server *server, const char *cert_path,
const char *key_path, const char *ca_path) {
SSL_CTX *ctx = create_ssl_ctx(true, cert_path, key_path, ca_path);
if (!ctx) return false;
server->ssl_ctx = ctx;
return true;
}
struct tls_child_ctx {
void (*handler)(int);
SSL_CTX *ssl_ctx;
};
static void tls_child_fn(int fd, void *arg) {
struct tls_child_ctx *ctx = (struct tls_child_ctx *)arg;
SSL *ssl = wrap_fd_with_ssl(fd, ctx->ssl_ctx, true);
if (!ssl) return;
io_set_ssl(ssl);
ctx->handler(fd);
SSL_shutdown(ssl);
SSL_free(ssl);
io_set_ssl(NULL);
}
bool server_listen_tls(Server *server, void (*handler)(int file_descriptor)) {
struct tls_child_ctx ctx = {handler, (SSL_CTX *)server->ssl_ctx};
server_accept_loop(server, tls_child_fn, &ctx, "Received TLS Connection");
return true;
}
bool client_connect_tls(Client *client, char *host, int port,
const char *cert_path, const char *key_path,
const char *ca_path) {
client->address.sin_port = htons(port);
if (inet_pton(AF_INET, host, &client->address.sin_addr) <= 0) {
perror("Could not convert host address!");
return false;
}
if (connect(client->file_descriptor, (struct sockaddr *)&client->address,
client->address_length) < 0) {
perror("Could not connect to Server!");
return false;
}
SSL_CTX *ctx = create_ssl_ctx(false, cert_path, key_path, ca_path);
if (!ctx) return false;
client->ssl_ctx = ctx;
SSL *ssl = wrap_fd_with_ssl(client->file_descriptor, ctx, false);
if (!ssl) {
SSL_CTX_free(ctx);
client->ssl_ctx = NULL;
return false;
}
client->ssl = ssl;
io_set_ssl(ssl);
return true;
}
+16
View File
@@ -0,0 +1,16 @@
#ifndef TRANSPORT_TLS_H
#define TRANSPORT_TLS_H
#include "transport_tcp.h"
#include <stdbool.h>
bool tls_global_init(void);
bool server_create_tls(Server *server, const char *cert_path,
const char *key_path, const char *ca_path);
bool server_listen_tls(Server *server, void (*handler)(int file_descriptor));
bool client_connect_tls(Client *client, char *host, int port,
const char *cert_path, const char *key_path,
const char *ca_path);
#endif
+11
View File
@@ -383,6 +383,17 @@ def run_profile(profile_name, source_dir, dest_dir):
except Exception as e: except Exception as e:
results.append({"name": "Progress (--progress)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)}) results.append({"name": "Progress (--progress)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
# Bandwidth limit (--bwlimit 10240 = 10 MB/s)
feature_flags = BASE_CLIENT_FLAGS + ["--bwlimit", "10240"]
cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags
print(f"\n --- Bandwidth limit (--bwlimit 10240 KB/s) ---\n Running: {' '.join(cmd)}")
try:
r = run_single_test(cmd, "Bandwidth limit (--bwlimit 10240)", source_dir, dest_dir)
r["suite"] = profile_name
results.append(r)
except Exception as e:
results.append({"name": "Bandwidth limit (--bwlimit 10240)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
# Chunk size (--chunk-size 5242880) # Chunk size (--chunk-size 5242880)
feature_flags = BASE_CLIENT_FLAGS + ["--chunk-size", "5242880"] feature_flags = BASE_CLIENT_FLAGS + ["--chunk-size", "5242880"]
cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags