196 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
TapTap	ed6242cfc5	ci: bump CI image to v9 with libclang-rt-18-dev ... v8 had cached image without libclang-rt-18-dev on CI runner. v9 forces a fresh pull and includes all fuzzer runtime libraries.	2026-07-20 14:44:41 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	7c6e69ad81	ci: install lcov and valgrind in CI jobs ... The fastsync-ci:v7 container does not include lcov or valgrind. Add apt-get install steps to the coverage and valgrind jobs. Also update lcov flags for lcov 2.x compatibility: --rc lcov_branch_coverage=1 -> --branch-coverage	2026-07-20 14:44:41 +02:00
TapTap	66d994f01b	fix: resolve cppcheck warnings in new test files ... - Remove unused ConsumerCtx struct in test_stress.c - Add const qualifiers to variables only checked for NULL in test_metadata.c, test_protocol.c, test_robustness.c	2026-07-20 14:44:35 +02:00
TapTap	44d0f99de9	style: fix clang-format violations in test files ... Fix line wrapping and designated initializer alignment in test_file.c, test_protocol.c, and test_stress.c to pass CI clang-format check.	2026-07-20 14:44:35 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00
TapTap	afa5aeca37	Merge pull request 'feat: update AI automation agents, add reviewer agent, enhance CI' (#26) from feat/ai-automation-updates into main ... Reviewed-on: #26	2026-07-20 14:38:51 +02:00
TapTap	5c686b0655	fix: address PR review — doc accuracy, clang-tidy info, config leak fix ... Review findings addressed: Critical: - cmake-expert.md: replace commented-out sanitizer lines with actual SANITIZER cache variable block, fix ENABLE_ASAN/TSAN/UBSAN pattern - integrator.md: update YAML example to v7, use -DSANITIZER= instead of raw flags, add symlink + LSAN suppression steps Warnings: - ci.yaml: rename clang-tidy step to 'informational, non-blocking', add ::warning:: workflow command for visibility - client_cli.c: add goto cleanup pattern to free config on error paths (skip for multithreaded path where pipeline_context_sender_destroy already owns config) Suggestions: - test-writer.md: clarify conftest.py is at tests/conftest.py - .lsan-suppressions.txt: remove config_create suppression (leak fixed)	2026-07-20 14:28:42 +02:00
TapTap	c7f34eaf9d	ci: symlink build dir for sanitizer integration tests	2026-07-20 14:22:27 +02:00
TapTap	bd17f50f9b	feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI ... Agents: - cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps - integrator: fix stale test.py references to tests/integration/, update CI docs - test-writer: update integration test patterns for modular test structure - reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality) Bug fixes: - delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize - scanner.c: free ArrayList when directory_scanner_next returns NULL CI: - Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks - Add clang-tidy job with proper warning/error detection - Remove || true masking (fixes now make sanitizer useful) Cleanup: - gitignore build-asan/ - .lsan-suppressions.txt for known CLI config leaks	2026-07-20 14:22:27 +02:00
TapTap	a4b35e136b	Merge pull request 'docs: add AGENTS.md with custom-image dependency install rule' (#27) from feat/custom-image-deps-rule into main ... Reviewed-on: #27	2026-07-19 22:57:15 +02:00
TapTap	02ceb6828b	fix: re-review cleanup — deps/conventions/sanitizer sections in cmake-expert, AGENTS.md notes	2026-07-19 22:54:02 +02:00
TapTap	0f9e689e39	fix: address PR review — lcov/valgrind in Dockerfile, correct cmake-expert.md, expand AGENTS.md	2026-07-19 22:37:26 +02:00
TapTap	a7bb6454a4	docs: add AGENTS.md with custom-image dependency install rule	2026-07-19 20:43:54 +02:00
TapTap	8a222bffa6	Merge pull request 'ci: add static analysis, sanitizers, and formatting enforcement' (#24) from ci/tier1-review-automation into main ... Reviewed-on: #24	2026-07-19 18:10:06 +02:00
TapTap	4982f9f47d	chore: remove build-asan from tracking, add to .gitignore	2026-07-19 17:15:58 +02:00
TapTap	8531f9e4c1	fix: set DELTA_INSTR_LITERAL type in deserialize and fix error path leaks	2026-07-19 17:15:43 +02:00
TapTap	413f69de90	fix: const-correct delta.c and use unread variable in test for cppcheck	2026-07-19 17:07:14 +02:00
TapTap	d7b9d4dbbc	fix: apply clang-format to merged code from main	2026-07-19 17:04:05 +02:00
TapTap	b9840b123d	Merge remote-tracking branch 'origin/main' into ci/tier1-review-automation ... # Conflicts: # src/client/client_send.c # src/shared/config.c # src/shared/file.c # src/shared/file.h # src/shared/protocol.h	2026-07-19 16:58:53 +02:00
TapTap	971a070b65	fix: const-correct config_send and file_send_single_calls for cppcheck	2026-07-19 16:44:01 +02:00
TapTap	dc7ada552b	fix: const-correct protocol send functions, remove duplicate typedef, null check ... - send_n_data: void* data → const void* data - send_str: char* data → const char* data - send_data: Data* data → const Data* data - Remove duplicate typedef struct ssl_st SSL in protocol.h - Add NULL check after malloc in directory_scanner_create	2026-07-19 16:40:47 +02:00
TapTap	5dfc262cf7	fix: scanner leak, remove TSan (Docker incompatible) ... - Fix ArrayList leak in directory_scanner_next when no files found - Remove TSan from CI matrix (Docker 'unexpected memory mapping') - Keep ASan which now passes clean	2026-07-19 16:22:16 +02:00
TapTap	ba6d42ea2d	fix: const-correct local Config* in multiprocessing.c for cppcheck	2026-07-19 16:16:28 +02:00
TapTap	256e1d7567	fix: const-correct receive_incremental_check for cppcheck	2026-07-19 16:13:47 +02:00
TapTap	f6eeb69d77	ci: use find|xargs for clang-format to fix directory handling	2026-07-19 16:09:13 +02:00
TapTap	f899085de4	fix: reformat queue.c/queue.h after const-correctness change	2026-07-19 16:06:57 +02:00
TapTap	5ede5c8bec	ci: use fastsync-ci:v7 image with cppcheck and clang-format pre-installed	2026-07-19 16:01:48 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	1078b47955	Merge pull request 'feat: add delta transfer for incremental sync' (#22) from feature/delta-transfer into main ... Reviewed-on: #22	2026-07-19 15:51:27 +02:00
TapTap	02266710fb	ci: add static analysis, sanitizers, and formatting enforcement ... Add Tier 1 review automation to catch issues before human review: - Add cppcheck and clang-format to CI lint job - Add sanitizer matrix (ASan + TSan) CI job - Enable -Wextra -Wpedantic -Werror in CI build - Add SANITIZER and STRICT_WARNINGS CMake options - Add .clang-format for consistent code style - Update Dockerfile with cppcheck and clang-format - Fix sign-compare and unused-parameter warnings for -Werror	2026-07-19 15:37:18 +02:00
TapTap	12557c351c	refactor: replace vendored xxhash.h with CMake FetchContent dependency ... Remove 7490-line vendored xxhash.h, use FetchContent to pull xxHash v0.8.3 at CMake configure time (SOURCE_SUBDIR cmake_unofficial). Links as static library via the xxhash target.	2026-07-19 15:21:35 +02:00
TapTap	d73d5c9d85	Merge pull request 'refactor: split test.py into modular pytest integration tests + benchmark tool' (#21) from refactor-tests into main ... Reviewed-on: #21	2026-07-19 15:11:29 +02:00
TapTap	045965f74c	benchmark: add --progress flag with progress bar and ETA	2026-07-19 15:07:53 +02:00
TapTap	784c57bd13	shell: add pytest to nix-shell environment	2026-07-19 15:03:23 +02:00
TapTap	1fec43be0e	Merge pull request 'feat: add opencode agents and skills for development workflows' (#23) from feat/opencode-agents-and-skills into main ... Reviewed-on: #23	2026-07-19 14:54:47 +02:00
TapTap	8141158a3d	feat: add opencode agents and skills for development workflows ... New agents: - architect: system design, module interactions, data flow - debugger: crash/memory/thread debugging with ASan, TSan, valgrind, gdb - security-auditor: TLS, input validation, buffer safety, crypto audit - refactorer: DRY, separation of concerns, API simplification - integrator: integration tests, CI/CD pipeline, end-to-end verification - code-explainer: architecture walkthrough, code explanation New skills: - debug-workflow: structured debugging workflow - refactor: code restructuring with test verification - security-audit: full security review with checklist - benchmark: performance benchmarking with multi-run medians - release: version bump, tests, tagging Improved existing: - c-reviewer: added security checklist - cmake-expert: added ASan/TSan/UBSan configs, ccache, cross-compilation - perf-analyst: added perf/valgrind/gprof commands - test-writer: added fuzzing harnesses, integration test patterns - pr-build: added sanitizer build variants - pr-review: added security review, performance impact assessment	2026-07-19 14:50:02 +02:00
TapTap	598e4e7514	fix: address PR review - rolling adler32, extract helpers, configurable max file size ... - Fix rolling adler32: add missing -1 in s2 update formula (was producing wrong checksums, causing zero block matches) - Fix file_send_sendfile signature to match typedef (add unused compression_level param) - Extract receive_delta_file() from receive_incremental_check() to reduce nesting depth - Extract send_file_incremental() helper in client_send.c - Add delta_max_file_size to Config, serialized over wire - Add --delta-max CLI flag - Add test_large_file_delta (200KB) and extra delta_should_attempt cases - Remove unused pos_in_block variable from delta_compute	2026-07-19 02:02:28 +02:00
TapTap	4ed514ad1b	benchmark: fix rsync network throttling via rsync daemon ... rsync local-to-local copies bypass the network stack entirely, making tc/netem ineffective. Start an rsync daemon on TCP so both tools see the same network conditions.	2026-07-18 20:08:54 +02:00
TapTap	e16db56580	feat: add delta transfer for incremental sync ... Implement rsync-style delta transfer using rolling checksums (Adler-32 + xxHash32). When a file exists on both sides but has changed, only the changed blocks are transmitted instead of the entire file. - New status codes: STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA - Protocol version bumped to 1.2.0 - Server generates block signature, client computes delta - Auto-fallback to whole-file when delta >= 70% of file size - Works with zstd compression on delta stream - Configurable block size (default 8KB, --delta-block flag) - 13 unit tests covering hashing, signature roundtrip, delta compute/apply, file growth/shrink, and decision logic	2026-07-18 20:00:15 +02:00
TapTap	f0c7bb791a	benchmark: add rsync comparison, configurable data mix, custom network limits ... - Add rsync and rsync+zstd as baseline comparisons - --random-ratio controls fraction of incompressible data (default 0.75) - --delay, --jitter, --throughput, --loss for custom network simulation - --no-rsync to skip rsync comparison - Grouped output: FastSync vs rsync with speedup calculations	2026-07-18 19:55:43 +02:00
TapTap	34b46a92db	tests: share server across tests, suppress probe noise ... - Add session-scoped shared_server fixture to avoid 27+ server start/stop cycles - Refactor test_tcp.py and test_features.py to use shared server - Suppress server health-check probe stderr noise in common.py	2026-07-18 19:48:19 +02:00
TapTap	51f20d1c91	benchmark: suppress server probe noise in output	2026-07-18 19:32:48 +02:00
TapTap	b28bac9f41	refactor: split test.py into modular pytest integration tests + benchmark tool ... - tests/integration/common.py: ServerManager (reuses server across tests), run_client, test data generation, verification utilities - tests/integration/test_tcp.py: 14 TCP transport correctness tests - tests/integration/test_ssh.py: 10 SSH transport tests (skip when unavailable) - tests/integration/test_tls.py: 5 TLS encryption tests (new coverage!) - tests/integration/test_features.py: 13 feature tests (incremental, delete, exclude, include, max/min size, bwlimit, dry run, archive, progress) - tests/integration/test_preflight.py: 7 CLI validation/error tests - benchmark/bench.py: standalone benchmark with JSON output, p50/p95, multi-run - Updated Dockerfile with python3-pytest, openssl, openssh-client - Updated CI to use pytest (gitea.tap-tap.win/taptap/fastsync-ci:v6) - Removed old monolithic test.py	2026-07-18 19:19:33 +02:00
TapTap	43ba149ad5	Merge pull request 'docs: update README with TLS, incremental sync, server CLI, and corrected build requirements' (#20) from update-readme into main ... Reviewed-on: #20	2026-07-18 18:27:34 +02:00
TapTap	293ba5191e	docs: update README with TLS, incremental sync, bandwidth limiting, server CLI, and corrected build requirements	2026-07-18 18:20:54 +02:00
TapTap	0642a43c2c	Merge pull request 'TLS transport: OpenSSL-based encrypted TCP' (#13) from tls-transport into main	2026-07-18 17:54:25 +02:00
TapTap	fed77f6ce0	ci: use v5 Docker image to force runner to pull updated image with libssl-dev	2026-07-18 17:53:08 +02:00