100 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
TapTap	1b67f5ffcf	docs: clarify %b semantics, temper thread-safety claim, harden %M scan; add -m coverage ... Address c-review nits on the itemize/output feature: - RSYNC_COMPAT.md: state that %b is the source length (always == %l) because no wire-byte counter exists; keep Summary equal to the matrix (recounted: 54 implemented / 84 not-implemented, 147 rows total - four rows flipped). - change_list.h/.c: document bytes_sent == size; note itemize/out-format lines never interleave with each other but may interleave with legacy log messages sharing the stream; mark the %M stat() path best-effort. - change_render_format scan in format_uses_mtime now mirrors the tokenizer (skips '%%' and unknown '%X' pairs) so a literal '%%M' no longer triggers the stat() fallback. - Integration tests: --list-only under -m; a changed file on a second --incremental run emits exactly one '>f' line while unchanged files print nothing; --log-file + --log-file-format under -m.	2026-09-06 12:49:49 +02:00
TapTap	7f5547e900	feat: add structured per-file change output model (-i, --list-only, --out-format, --log-file-format) ... Implement rsync-style itemized output backed by one shared change-event engine (src/client/change_list.c): - -i/--itemize-changes prints ">f+++++++++ <path>" for files actually sent (single-threaded and -m); unchanged files print nothing. - --list-only prints an ls-style listing of files that would be transferred without contacting the server or writing anything. - --out-format=FORMAT prints a printf-style template per changed file (tokens %%f %%n %%l %%b %%M %%%%; unknown escapes preserved). - --log-file-format=FMT logs each transferred file when --log-file is set. Events are emitted from the per-file sender path shared by both transfer modes, so the single sender thread is the only reporter (no races).	2026-09-06 12:34:10 +02:00
TapTap	06e83f2402	Merge docs: document missing rsync flags and add phased implementation plan ... Reconcile the security-fixes branch's RSYNC_COMPAT.md updates onto dev: - Keep dev's implemented statuses as authoritative and port the previously undocumented rsync 3.4.1 rows (one-file-system, -F, temp-dir/-T, identity mapping options, remote-option/-M, max-alloc) with code-verified statuses. - Add the Implementation Difficulty Plan (Phases 1-6 + delivery order) as the sequencing roadmap; note that it is a superset snapshot and the Summary matrix is authoritative for shipped features. - Recomputed the Summary counts from the table (was stale on dev): 51 implemented / 3 alt-arg / 5 partial / 1 no-op / 87 not implemented.	2026-09-06 11:42:37 +02:00
TapTap	f7c6c91e13	fix: set *failed on delta oversize branch; add -m RSF skip test ... Review nits from independent review of the four fix branches: - receive_delta_file STATUS_NEXT oversize branch now sets *failed=true - receive_incremental_check oversize branch returns NULL (receiver sends the single STATUS_ERROR) instead of double-sending - add multithreaded -m --ignore-existing --remove-source-files integration coverage so the writer-thread outcome path is exercised	2026-09-05 13:16:42 +02:00
TapTap	39805e4eee	Merge fix/quality-cleanup into dev ... fixes #260 (dead code, CLI =form/missing-arg diagnostics)	2026-09-05 13:12:33 +02:00
TapTap	9ef78ef48b	Merge fix/perf-delta into dev ... fixes #259 (delta_compute hash index)	2026-09-05 13:12:33 +02:00
TapTap	68e7ed57d0	Merge fix/security-hardening into dev ... fixes #254 (receiver queue byte-budget) #258 (inplace setuid/truncate) # Conflicts: # src/shared/multiprocessing.c	2026-09-05 13:12:31 +02:00
TapTap	11c591c5aa	Merge fix/receiver-correctness into dev ... fixes #251 #252 #253 #255 #256 #257 (remove-source-files skips, backup NULL-empty, partial-dir install, lazy STATUS_CHECK, delta *failed, >64MiB files)	2026-09-05 13:11:41 +02:00
TapTap	1d61a1426e	fix: #260 accept --opt=value uniformly and report missing arguments ... - Correct misleading doc comments on set_string_option / set_positive_int_option / set_nonneg_int_option (they return 0/-1, not true/false). - find_table_option_with_equals() now matches every OPTION_TABLE value option (OPT_STRING/OPT_POS_INT/OPT_NONNEG_INT/OPT_ULL), so forms such as --max-size=2G, --min-size=1K, --suffix=.bak, --timeout=30, --max-depth=5, --backup-dir=X parse instead of dying as 'Unknown option'. --max-size/--min-size now accept rsync-style binary suffixes (0 remains a valid 'no limit' byte count). Existing special handling for --compress-choice, --compress-level, --modify-window=, --chmod=, --skip-compress=, --compress-threads= is preserved. - Options that require a separate value (-p, --exclude, --include, --delta-block, --delta-max, --server-port, --bwlimit, --chunk-size, --log-file, --exclude-from, --include-from, -T, --skip-compress, --compress-threads) now emit an explicit 'missing argument' diagnostic instead of falling through to the generic 'Unknown option' branch when given as the final argv entry. - Add unit tests covering the = forms (--max-size=2G, --min-size=1K, --suffix=.bak, --timeout=30, --max-depth=5, --backup-dir=X) and a clean 'missing argument' (not 'Unknown option') diagnostic for trailing --exclude/--server-port/--skip-compress/-T.	2026-09-05 12:58:30 +02:00
TapTap	beb681c2dc	fix: #260 remove dead receive_files() and mkdir_r() ... receive_files() in src/server/server.c was a non-static, unprototyped, zero-caller duplicate of receiver_process()/receiver_receive_files() in src/server/receiver.c. Delete it along with the includes it uniquely pulled (chunk.h, metadata.h, sys/stat.h, duplicate quoted unistd.h); remaining code still uses file.h/config.h/protocol.h (via multiprocessing.h) directly. mkdir_r() in src/shared/utils.c had zero callers in src/ and tests/; remove the function and its declaration in utils.h, plus the unused libgen.h include.	2026-09-05 12:58:25 +02:00
TapTap	3704a6adaa	test: integration coverage for #251 #252 #253 #257 ... - remove-source-files keeps sources skipped by --existing/--ignore-existing/ --update (rsync reference behavior) - --backup keeps <file>~, --suffix .bak, and --backup-dir backups - --partial --partial-dir installs completed files in the destination - a 100 MB file transfers end to end (>64 MiB whole-file cap regression)	2026-09-05 12:46:47 +02:00
TapTap	14c064a093	fix: #251 #252 #253 #255 #256 #257 receiver & remove-source correctness ... #251 --remove-source-files deletes sources that were skipped receiver-side (--existing/--ignore-existing/--update). The receiver now reports a per-file outcome for every processed data file when the sender requests removal; the client only unlinks sources the receiver actually wrote. add remove_source_files to the wire config and bump the protocol to 2.5.0. #252 --backup/--suffix/--backup-dir broken by NULL-vs-empty wire loss. Receivers canonicalize the empty wire string back to NULL for backup_dir, temp_dir, partial_dir and suffix, and --suffix is received unconditionally. #253 --partial --partial-dir never installed completed files. file_save_to_disk now renames a fully written partial-dir file into the real destination. #255 STATUS_CHECK read the entire old file before the size/mtime quick check. Old contents are only read when a checksum compare or delta needs them. #256 receive_delta_file failure paths did not set *failed, so the caller sent STATUS_NEXT and waited for a body that never came. Every NULL return now marks the transfer failed. #257 files >64 MiB could not transfer. Whole-file receive caps raised to the 256 MiB connection/allocation ceiling (chunk caps stay 64 MiB) and the client ignores SIGPIPE so a server-side close surfaces as a clean error. Unit tests added: config NULL-vs-empty round trip, incremental quick-check skip/NEXT paths, delta oversize failure, partial-dir install, save-result skip reporting.	2026-09-05 12:46:44 +02:00
TapTap	2234879b2f	fix: #258 normalize mode and truncate on --inplace overwrite ... The --inplace branch opened the destination with O_WRONLY|O_CREAT (no O_TRUNC) and only restored metadata when the sender supplied it. Two flaws resulted: 1. An existing destination file kept its original mode when no metadata was sent, so setuid/setgid/sticky bits survived an overwrite (a root sync could leave a root-owned setuid binary controlled by a client). 2. A shorter payload left stale trailing bytes from the previous version because the file was never truncated to the new length. In the inplace branch of file_to_disk_secure_impl: - Always trim the file to the new payload length (ftruncate after the write) so stale trailing bytes can never survive; sparse targets keep their pre-size ftruncate. - Always normalize the mode after a successful overwrite: apply the metadata-derived safe mode when metadata is present (as before), else fchmod to a safe default 0644, so setuid/setgid/sticky are cleared in both cases. - The --update newer-destination check still runs before any truncation or chmod, preserving the skip semantics. Adds unit tests in test_file.c: (a) setuid/sticky bits on an existing destination are cleared after an inplace write with and without metadata, (b) a shorter inplace payload leaves no trailing stale bytes.	2026-09-05 12:29:46 +02:00
TapTap	98120fc722	fix: #254 bound receiver queue by aggregate payload bytes ... The per-connection memory budget (MAX_CONNECTION_MEMORY, 256 MiB) only charged wire buffers via receive_data_limited. Decompression buffers and per-file chunk copies were not accounted for, and the multithreaded receiver could enqueue up to 100 files (each up to 64 MiB uncompressed) ahead of a slow disk writer, retaining ~6.4 GiB per connection. A client sending highly compressible chunks with little bandwidth could OOM the host while the reserve never tripped. Bound the receive pipeline by aggregate payload bytes instead of item count alone: - Export MAX_CONNECTION_MEMORY from protocol.h. - PipelineContextReceiver tracks queued_bytes (payload bytes received but not yet released by the disk writer, i.e. queued or in the writer's hand) under the existing mutex. - receiver enqueue now blocks while the queue is full by count OR when adding the file would push queued_bytes over the configured byte limit, applying backpressure to the sender instead of failing the transfer. - The disk writer releases the byte budget after each file is freed and signals the not-full condition. - The server sets the byte ceiling to MAX_CONNECTION_MEMORY - 2*MAX_CHUNK_SIZE so that the queued payloads plus the transient wire/decompression buffers of the one in-flight chunk stay within the per-connection budget. The single-threaded receive path is already bounded: it writes files to disk before reading the next chunk, so its transient is at most one chunk's wire + decompressed + copied payload (~3 * MAX_CHUNK_SIZE, below the budget). Wire buffers remain charged exactly once by receive_data_limited; this change does not double charge them. Adds a deterministic unit test in test_multiprocessing.c proving that an enqueue which would exceed the byte budget blocks until the writer releases bytes.	2026-09-05 12:29:41 +02:00
TapTap	5fed0888aa	perf: #259 delta_compute hash index over signature blocks	2026-09-05 12:21:26 +02:00
TapTap	9f8b58893b	Apply clang-format 18 to merge-conflict resolution code ... The Phase 1 merge conflict resolutions introduced formatting that failed the CI lint job (clang-format 18.1.3). Reformatted with the exact CI version; no functional changes.	2026-09-05 10:57:41 +02:00
TapTap	48dfd5dfa0	Fix incremental skip regression from modify-window nsec comparison ... metadata_mtime_matches() required exact nanosecond equality at the default modify_window=0, but destination write-time nsecs never match source creation-time nsecs unless -M preserves metadata. Compare whole seconds (rsync's default quick-check) at window 0; keep the subsecond-refined tolerance for explicit window values.	2026-09-05 10:43:58 +02:00
TapTap	8384a1997b	Merge remote-tracking branch 'origin/feat/rsync-delete-during-alias' into dev	2026-09-05 02:53:59 +02:00
TapTap	a1981a78ad	Merge remote-tracking branch 'origin/feat/rsync-old-dirs-aliases' into dev	2026-09-05 02:48:48 +02:00
TapTap	b5646a0b9e	Merge remote-tracking branch 'origin/feat/rsync-checksum-choice-alias' into dev	2026-09-05 02:44:04 +02:00
TapTap	c6a341bd1e	Merge remote-tracking branch 'origin/feat/rsync-partial-progress' into dev	2026-09-05 02:39:03 +02:00
TapTap	c1e9509f16	Merge remote-tracking branch 'origin/feat/rsync-old-args' into dev	2026-09-05 02:34:29 +02:00
TapTap	8689778233	Merge remote-tracking branch 'origin/feat/rsync-no-options' into dev	2026-09-05 02:30:50 +02:00
TapTap	cf0d10fccb	Merge remote-tracking branch 'origin/feat/rsync-info' into dev	2026-09-05 02:25:36 +02:00
TapTap	90112a7585	Merge remote-tracking branch 'origin/feat/max-alloc' into dev	2026-09-05 02:13:35 +02:00
TapTap	3304541337	Merge remote-tracking branch 'origin/feat/compress-threads' into dev	2026-09-05 02:01:43 +02:00
TapTap	6a95efbe41	Merge remote-tracking branch 'origin/feat/skip-compress' into dev	2026-09-04 18:35:19 +02:00
TapTap	3b013bf9d2	Merge remote-tracking branch 'origin/feat/rsync-compression-aliases' into dev	2026-09-04 18:24:21 +02:00
TapTap	4f21498ee6	Merge remote-tracking branch 'origin/feat/chmod' into dev	2026-09-04 18:20:08 +02:00
TapTap	315e572d18	Merge remote-tracking branch 'origin/feat/executability' into dev	2026-09-04 18:13:34 +02:00
TapTap	55172ff6de	Merge remote-tracking branch 'origin/feat/ignore-existing' into dev	2026-09-04 17:59:50 +02:00
TapTap	c650f9a3d0	Merge remote-tracking branch 'origin/feat/existing' into dev	2026-09-04 17:50:55 +02:00
TapTap	192aff8c46	Merge remote-tracking branch 'origin/feat/update' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/shared/file.c # src/shared/file.h # src/shared/file_receive.c # tests/test_client_cli.c	2026-09-04 17:44:07 +02:00
TapTap	6d10116d50	Merge remote-tracking branch 'origin/feat/modify-window' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # src/shared/file_receive.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:40:16 +02:00
TapTap	e42df1bde3	Merge remote-tracking branch 'origin/feat/size-only' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # tests/integration/test_features.py # tests/test_config.c	2026-09-04 17:30:14 +02:00
TapTap	9fc1e72972	Merge remote-tracking branch 'origin/feat/ignore-times' into dev ... # Conflicts: # src/shared/config.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:27:04 +02:00
TapTap	71f1529222	Merge remote-tracking branch 'origin/feat/whole-file' into dev ... # Conflicts: # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:24:22 +02:00
TapTap	2adfa5a03b	Merge remote-tracking branch 'origin/feat/rsync-secluded-args' into dev ... # Conflicts: # RSYNC_COMPAT.md # tests/test_client_cli.c	2026-09-04 17:22:53 +02:00
TapTap	47d1cbdae8	Merge remote-tracking branch 'origin/feat/rsync-debug' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/shared/log.h # src/shared/protocol.c	2026-09-04 17:21:48 +02:00
TapTap	b59139589d	Merge remote-tracking branch 'origin/feat/rsync-stderr-mode' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/shared/log.c # src/shared/log.h # tests/test_client_cli.c	2026-09-04 17:20:36 +02:00
TapTap	49e4af275f	Merge remote-tracking branch 'origin/feat/8-bit-output' into dev ... # Conflicts: # src/client/client_cli.c # src/client/client_send.c # src/shared/config.c # tests/test_client_cli.c # tests/test_config.c # tests/test_shared_utils.c	2026-09-04 17:18:01 +02:00
TapTap	8e1bc9bb9c	Merge remote-tracking branch 'origin/feat/human-readable' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_send.c # tests/test_client_cli.c	2026-09-04 17:16:24 +02:00
TapTap	421a94773f	Merge remote-tracking branch 'origin/feat/quiet' into dev ... # Conflicts: # src/client/client_send.c	2026-09-04 17:14:45 +02:00
TapTap	ead4651d12	Merge remote-tracking branch 'origin/feat/remove-source-files' into dev	2026-09-04 17:14:23 +02:00
TapTap	638d953b1d	fix: bump protocol version for max alloc wire format	2026-09-04 02:29:06 +02:00
TapTap	04cea295b5	fix: enforce max alloc in delta deserialization	2026-09-04 02:25:26 +02:00
TapTap	820afd334a	fix: reject malformed max-alloc sizes	2026-09-04 02:22:00 +02:00
TapTap	2f553a2a43	fix: honor explicit protocol allocation sessions	2026-09-04 02:18:44 +02:00
TapTap	f990e86309	fix: make protocol allocation accounting atomic	2026-09-04 02:12:22 +02:00
TapTap	0d306940e1	fix: bind allocation sessions in worker threads	2026-09-04 01:56:34 +02:00
TapTap	552c19d3fe	fix: guard skip-compress cleanup	2026-09-04 01:49:38 +02:00
TapTap	14c5da98d8	fix: free old snapshot on full transfer fallback	2026-09-03 22:51:42 +02:00
TapTap	aab45873ac	test: cover compression option equals forms	2026-09-03 22:47:41 +02:00
TapTap	605f79a450	fix: make rsync info none override verbose	2026-09-03 22:44:44 +02:00
TapTap	066c7ed1af	fix: address 8-bit output re-review findings	2026-09-03 22:40:30 +02:00
TapTap	97a628c3fd	docs: document delete-during aliases	2026-09-03 22:34:52 +02:00
TapTap	9f23b23893	fix: clarify unsupported directory option diagnostics	2026-09-03 22:32:09 +02:00
TapTap	2ace6416a7	test: cover configured fsync save path	2026-09-03 22:29:40 +02:00
TapTap	e491e811e3	fix: enforce max alloc across protocol workers	2026-09-03 22:26:29 +02:00
TapTap	ec02ee6dde	fix: bound compression worker threads	2026-09-03 22:22:04 +02:00
TapTap	98cbf3495d	fix: complete skip-compress protocol handling	2026-09-03 22:19:00 +02:00
TapTap	245a34fa11	fix: guard source removal against file replacement	2026-09-03 22:11:18 +02:00
TapTap	68aaf89da7	fix: address update option review findings	2026-09-03 21:59:55 +02:00
TapTap	e37d5b9438	fix: address modify-window review findings	2026-09-03 21:54:46 +02:00
TapTap	5b8cdf457b	fix: bump protocol version for size-only field	2026-09-03 21:51:29 +02:00
TapTap	1ebe261e05	fix: complete ignore-times incremental handling	2026-09-03 21:49:10 +02:00
TapTap	05313f00ea	fix: prioritize whole-file validation	2026-09-03 21:46:50 +02:00
TapTap	4152bf379e	fix: honor compression choice aliases	2026-09-03 21:44:21 +02:00
TapTap	f8291d895d	fix: classify partial progress as incomplete	2026-09-03 21:40:07 +02:00
TapTap	ba236d5b2e	fix: clarify secluded args compatibility semantics	2026-09-03 21:37:45 +02:00
TapTap	ec6160a8b9	fix: propagate SSH child setup failures	2026-09-03 21:34:32 +02:00
TapTap	302c3cb664	fix: preserve explicit rsync option negations	2026-09-03 21:30:55 +02:00
TapTap	caabd2e314	fix: reject unsupported rsync debug categories	2026-09-03 21:28:21 +02:00
TapTap	21e6b1c1bc	fix: address rsync info review findings	2026-09-03 21:25:56 +02:00
TapTap	5350290f52	fix: reject unsupported rsync client stderr mode	2026-09-03 21:21:22 +02:00
TapTap	5b997d5d25	fix: complete 8-bit output negotiation	2026-09-03 21:18:35 +02:00
TapTap	fb96c21d93	test: complete human-readable progress coverage	2026-09-03 21:14:49 +02:00
TapTap	17b5b31845	fix: complete quiet option handling	2026-09-03 21:12:43 +02:00
TapTap	48a36b0038	feat: add rsync delete-during alias	2026-09-03 18:34:06 +02:00
TapTap	ce64fcd4b1	feat: recognize rsync old-dirs aliases	2026-09-03 18:31:09 +02:00
TapTap	4982e15969	feat: add rsync-compatible fsync	2026-09-03 18:28:02 +02:00
TapTap	d69f5db652	feat: add rsync-compatible max-alloc limit	2026-09-03 18:23:45 +02:00
TapTap	f443b2986d	feat: add compression worker threads	2026-09-03 18:15:14 +02:00
TapTap	2a08a7ba5c	feat: add skip-compress option	2026-09-03 17:56:27 +02:00
TapTap	36a373ff5d	Add executability preservation option	2026-09-03 17:39:50 +02:00
TapTap	3b85658024	Add remove-source-files option	2026-09-03 17:33:52 +02:00
TapTap	5e67a721a4	feat: add rsync-compatible update option	2026-09-03 17:07:02 +02:00
TapTap	0b5b1a8643	feat: add rsync modify-window option	2026-09-03 17:01:45 +02:00
TapTap	2afb1d9649	feat: add rsync-compatible size-only option	2026-09-03 16:54:07 +02:00
TapTap	230401c629	feat: add ignore-times incremental option	2026-09-03 16:50:07 +02:00
TapTap	c91db3266a	feat: add whole-file transfer mode	2026-09-03 16:47:02 +02:00
TapTap	44ce154e37	feat: add checksum choice alias	2026-09-03 16:42:29 +02:00
TapTap	cd27886dde	feat: add rsync compression aliases	2026-09-03 16:38:12 +02:00
TapTap	a0aff000ad	feat: add rsync partial progress alias	2026-09-03 16:34:18 +02:00
TapTap	50f9ebb55b	feat: add secluded args compatibility option	2026-09-03 16:31:37 +02:00
TapTap	393a440c78	feat: add rsync old-args compatibility mode	2026-09-03 16:27:45 +02:00
TapTap	2ff2688ef1	feat: support rsync no-option handling	2026-09-03 16:22:18 +02:00
TapTap	5c7d82b79c	feat: add rsync debug flags	2026-09-03 16:18:46 +02:00
TapTap	4872d425a3	feat: add rsync info flags	2026-09-03 16:13:56 +02:00
TapTap	60eb7f11fe	feat: add rsync stderr output modes	2026-09-03 16:07:51 +02:00