TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main"
CI / lint (pull_request) Successful in 7s
Details
CI / sanitizers (address) (pull_request) Successful in 14s
Details
CI / sanitizers (undefined) (pull_request) Successful in 13s
Details
CI / fuzz-build (pull_request) Successful in 12s
Details
CI / coverage (pull_request) Successful in 9s
Details
CI / build-and-test (pull_request) Successful in 53s
Details
CI / valgrind (pull_request) Successful in 12s
Details

Browse Source 
This reverts commit ddfdb3825a, reversing
changes made to 504a3a4d4f.
This commit is contained in:
TapTap
2026-07-20 19:36:09 +02:00
parent 5049a7bbf0
commit bcf5ffcf40
9 changed files with 18 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/transport_ssh.c
+1 -13
View File
@@ -124,10 +124,7 @@ Client* client_connect_ssh(const char* destination, int port) {
else
snprintf(ssh_user, sizeof(ssh_user), "%s", r.host);
size_t ssh_argv_max = 32;
char** ssh_argv = calloc(ssh_argv_max, sizeof(char*));
if (ssh_argv == NULL)
_exit(1);
char* ssh_argv[16];
int ac = 0;
char port_str[16];
ssh_argv[ac++] = "ssh";
@@ -138,24 +135,15 @@ Client* client_connect_ssh(const char* destination, int port) {
ssh_argv[ac++] = "-o";
ssh_argv[ac++] = "ControlPath=~/.cache/fastsync-%r@%h:%p";
if (port > 0 && port != 22) {
if ((size_t)ac + 2 >= ssh_argv_max) {
free(ssh_argv);
_exit(1);
}
ssh_argv[ac++] = "-p";
snprintf(port_str, sizeof(port_str), "%d", port);
ssh_argv[ac++] = port_str;
}
if ((size_t)ac + 3 >= ssh_argv_max) {
free(ssh_argv);
_exit(1);
}
ssh_argv[ac++] = ssh_user;
ssh_argv[ac++] = "fastsync-server";
ssh_argv[ac++] = "--stdio";
ssh_argv[ac] = NULL;
execvp("ssh", ssh_argv);
free(ssh_argv);
perror("exec of ssh failed");
ssize_t wret = write(exec_pipe[1], "x", 1);
(void)wret;