fix: resolve all bug issues (#158, #163, #164, #165, #166, #167, #168, #169)

src/shared/config.c

@@ -8,28 +8,24 @@
 #include <stdlib.h>
 #include <string.h>
 
-Config* config_create(char* version, char* send_directory, char* receive_directory,
-                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
-                      bool use_compression, bool use_metadata, int compression_level,
-                      bool use_sendfile, unsigned long long chunk_size) {
-
+Config* config_create(void) {
   Config* config = malloc(sizeof(Config));
   if (!config)
     return NULL;
-  config->version = version;
-  config->send_directory = send_directory;
-  config->receive_root_directory = receive_directory;
-  config->save_to_disk = save_to_disk;
-  config->use_multithreading = use_multithreading;
-  config->use_chunk_serialization = use_chunk_serialization;
-  config->use_compression = use_compression;
-  config->use_metadata = use_metadata;
+  config->version = str_dup(PROTOCOL_VERSION);
+  config->send_directory = NULL;
+  config->receive_root_directory = NULL;
+  config->save_to_disk = false;
+  config->use_multithreading = false;
+  config->use_chunk_serialization = false;
+  config->use_compression = false;
+  config->use_metadata = false;
   config->show_progress = false;
   config->dry_run = false;
   config->use_delete = false;
-  config->compression_level = compression_level;
-  config->use_sendfile = use_sendfile;
-  config->chunk_size = chunk_size > 0 ? chunk_size : DEFAULT_CHUNK_SIZE;
+  config->compression_level = 5;
+  config->use_sendfile = false;
+  config->chunk_size = DEFAULT_CHUNK_SIZE;
   config->ssh_port = 22;
   config->transport = TRANSPORT_TCP;
   config->ssh_destination = NULL;
@@ -59,6 +55,8 @@ Config* config_create(char* version, char* send_directory, char* receive_directo
   config->max_depth = 0;
   config->log_file = NULL;
   config->queue_size = 100;
+  config->follow_symlinks = false;
+  config->partial = false;
   return config;
 }
 

src/shared/config.h

@@ -58,10 +58,7 @@ typedef struct Config {
 #define PROTOCOL_VERSION "1.3.0"
 #define DEFAULT_CHUNK_SIZE (10 * 1024 * 1024)
 
-Config* config_create(char* version, char* send_directory, char* receive_directory,
-                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
-                      bool use_compression, bool use_metadata, int compression_level,
-                      bool use_sendfile, unsigned long long chunk_size);
+Config* config_create(void);
 void config_delete(Config* config);
 bool config_send(int file_descriptor, const Config* config);
 Config* config_receive(int file_descriptor);

src/shared/file.c

@@ -510,6 +510,8 @@ bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int
   while ((unsigned long long)offset < file_size) {
     ssize_t sent = sendfile(file_descriptor, fd, &offset, file_size - offset);
     if (sent == -1) {
+      if (errno == EAGAIN || errno == EINTR)
+        continue;
       perror("sendfile failed");
       close(fd);
       return false;

src/shared/multiprocessing.c

@@ -81,10 +81,10 @@ void pipeline_context_receiver_destroy(PipelineContextReceiver* context) {
   free(context);
 }
 
-static void receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver* context) {
+static bool receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver* context) {
   Chunk* chunk = receive_chunk_data(file_descriptor, context->config);
   if (chunk == NULL)
-    return;
+    return false;
 
   for (int i = 0; i < chunk->element_count; i++) {
     File* file = chunk->items[i];
@@ -93,6 +93,7 @@ static void receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver*
                                 &context->condition_not_empty, &context->condition_not_full);
   }
   chunk_destroy(chunk);
+  return true;
 }
 
 int receive_thread(void* pipeline_context) {
@@ -125,7 +126,8 @@ int receive_thread(void* pipeline_context) {
                                     &context->condition_not_empty, &context->condition_not_full);
       }
     } else if (status == STATUS_CHUNK) {
-      receive_chunk_enqueue(file_descriptor, context);
+      if (!receive_chunk_enqueue(file_descriptor, context))
+        return thrd_error;
     } else if (status == STATUS_CHECK_BATCH) {
       int count;
       if (!receive_int(file_descriptor, &count))
@@ -161,6 +163,7 @@ int receive_thread(void* pipeline_context) {
                                     &context->condition_not_empty, &context->condition_not_full);
       } else {
         log_message(LOG_LEVEL_ERROR, "Failed to receive file");
+        return thrd_error;
       }
     }
   next:

src/shared/protocol.c

@@ -15,7 +15,7 @@
 
 static __thread int io_read_fd = -1;
 static __thread int io_write_fd = -1;
-static SSL* io_ssl;
+static __thread SSL* io_ssl;
 
 static unsigned long long io_bwlimit = 0;
 static long long bw_tokens = 0;