TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap pushed to dev at TapTap/FastSync 2026-07-30 18:23:19 +02:00
TapTap created branch dev in TapTap/FastSync 2026-07-30 18:23:19 +02:00
TapTap commented on pull request TapTap/FastSync#153 2026-07-30 18:18:53 +02:00
fix: add NULL-checks and input validation in CLI argument parsing (#152)

=== PR REVIEW SUMMARY === Branch: fix/null-checks-cli (PR #153) Files: 1 (src/client/client_cli.c) Issues: 8 (0 critical, 2 warning, 6 style)

=== VERDICT === [PASS] All 22 tests pass, build…

TapTap closed issue TapTap/FastSync#170 2026-07-30 18:17:32 +02:00
Security: Delta and chunk deserialization don't validate array counts/sizes from network
TapTap closed issue TapTap/FastSync#169 2026-07-30 18:17:32 +02:00
Bug/Security: chown() failures during metadata restoration are silently ignored
TapTap closed issue TapTap/FastSync#168 2026-07-30 18:17:32 +02:00
Bug/Performance: sendfile() loop treats EAGAIN / EINTR as fatal errors
TapTap closed issue TapTap/FastSync#167 2026-07-30 18:17:31 +02:00
Bug: Server receive_thread doesn't propagate file_receive / chunk receive errors
TapTap closed issue TapTap/FastSync#166 2026-07-30 18:17:31 +02:00
Bug: client_cli.c may free() a string literal for server_host
TapTap closed issue TapTap/FastSync#165 2026-07-30 18:17:31 +02:00
Bug/Quality: Protocol layer uses global I/O state; io_ssl is not thread-local
TapTap closed issue TapTap/FastSync#164 2026-07-30 18:17:31 +02:00
Bug: Transfer functions return -1, causing implementation-defined exit status
TapTap closed issue TapTap/FastSync#163 2026-07-30 18:17:31 +02:00
Bug: --delete manifest sending ignores send_status / send_int / send_str failures
TapTap closed issue TapTap/FastSync#162 2026-07-30 18:17:31 +02:00
Security: --delete follows symlinks and may delete outside destination tree
TapTap closed issue TapTap/FastSync#161 2026-07-30 18:17:31 +02:00
Security: TLS client lacks hostname verification
TapTap closed issue TapTap/FastSync#160 2026-07-30 18:17:31 +02:00
Security: TLS I/O doesn't handle SSL_ERROR_WANT_READ / SSL_ERROR_WANT_WRITE
TapTap closed issue TapTap/FastSync#159 2026-07-30 18:17:31 +02:00
Security: zstd decompression may allocate ZSTD_CONTENTSIZE_UNKNOWN bytes
TapTap closed issue TapTap/FastSync#158 2026-07-30 18:17:31 +02:00
Bug: Server leaks Config in non-multithreaded handler path
TapTap closed issue TapTap/FastSync#157 2026-07-30 18:17:30 +02:00
Security: Metadata restoration applies arbitrary mode bits including setuid/setgid
TapTap closed issue TapTap/FastSync#156 2026-07-30 18:17:30 +02:00
Security: Unbounded wire sizes enable OOM denial of service
TapTap closed issue TapTap/FastSync#152 2026-07-30 18:17:30 +02:00
Bug: Missing NULL-checks and weak input validation in CLI argument parsing
TapTap closed issue TapTap/FastSync#151 2026-07-30 18:17:30 +02:00
Refactor: send_files() and send_files_multithreaded() share massive code duplication