TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap commented on pull request TapTap/FastSync#14 2026-07-16 17:33:52 +02:00
Incremental sync: --incremental to skip unchanged files

Re-review after commit 3fc9b1a

Addressed from previous review

  • file_send_single_calls_no_path — now uses a local data_to_send pointer instead of mutating file->data. Proper…
TapTap commented on pull request TapTap/FastSync#16 2026-07-16 17:21:11 +02:00
Add custom opencode agents for FastSync development

PR Review Summary

Verdict: PASS — No issues found

Files reviewed: 8 (6 agent definitions + 2 skill definitions)

Assessment

All files are well-structured, internally…

TapTap commented on pull request TapTap/FastSync#15 2026-07-16 17:21:05 +02:00
Bandwidth throttling: --bwlimit <KB/s> with token bucket

PR Review Summary

Verdict: FAIL — 1 critical issue must be fixed before merge

Files reviewed: 3 Issues found: 6 (1 critical, 4 warning, 1 style)

CRITICAL Issue

**[1]…

TapTap commented on pull request TapTap/FastSync#14 2026-07-16 17:20:52 +02:00
Incremental sync: --incremental to skip unchanged files

PR Review Summary

Verdict: PASS — No critical issues

Files reviewed: 10 Issues found: 3 (0 critical, 2 warning, 1 style)

Warnings

**[1] `src/shared/multiprocessing.c:13…

TapTap commented on pull request TapTap/FastSync#13 2026-07-16 17:20:41 +02:00
TLS transport: OpenSSL-based encrypted TCP

PR Review Summary

Verdict: FAIL — 3 critical issues must be fixed before merge

Files reviewed: 13 Issues found: 11 (3 critical, 6 warning, 2 style)

CRITICAL Issues

**[1…

TapTap commented on pull request TapTap/FastSync#14 2026-07-16 17:10:07 +02:00
Incremental sync: --incremental to skip unchanged files

Re-review of 3fc9b1a

All six issues from the previous review are fixed:

  1. file_send_sendfile_no_path — new function sends metadata + size + data (no path). Matches server's STATUS_CHEC…
TapTap commented on pull request TapTap/FastSync#15 2026-07-16 17:10:02 +02:00
Bandwidth throttling: --bwlimit <KB/s> with token bucket

Re-review of 3dcaf0b

All three issues from the previous review are fixed:

  1. __thread removed from bwlimit variables — io_bwlimit, bw_tokens, bw_last_refill are now plain…
TapTap pushed to tls-transport at TapTap/FastSync 2026-07-16 17:08:18 +02:00
df85509812 Fix re-review: remove __thread from io_ssl (breaks -m), strtol port parsing, --ca warning
TapTap pushed to add-custom-agents at TapTap/FastSync 2026-07-16 17:07:45 +02:00
1b87131e82 Add pr-review and pr-build skills
TapTap commented on pull request TapTap/FastSync#13 2026-07-16 17:05:14 +02:00
TLS transport: OpenSSL-based encrypted TCP

Re-review of 7a314b8

Great update — most of the original issues are resolved. Here's a summary:

Fixed from previous review

  • SSL/SSL cleanup in client_disconnect, client_delete,…
TapTap pushed to incremental-sync at TapTap/FastSync 2026-07-16 17:02:18 +02:00
3fc9b1a61f Fix incremental-sync review: sendfile_no_path, reject -s+incremental, no data mutation, auto -M, STATUS_ERROR handling, PROTOCOL_VERSION bump
TapTap created pull request TapTap/FastSync#16 2026-07-16 17:01:37 +02:00
Add custom opencode agents for FastSync development
TapTap pushed to bwlimit at TapTap/FastSync 2026-07-16 17:00:17 +02:00
3dcaf0b79d Fix bwlimit review: remove __thread (breaks -m), validate >0, handle nanosleep EINTR
TapTap created branch add-custom-agents in TapTap/FastSync 2026-07-16 16:58:25 +02:00
TapTap pushed to add-custom-agents at TapTap/FastSync 2026-07-16 16:58:25 +02:00
ef6aa143d0 Add custom opencode agents for FastSync development
TapTap pushed to tls-transport at TapTap/FastSync 2026-07-16 16:56:38 +02:00
7a314b8391 Fix TLS code review issues: SSL cleanup, TLS 1.2 min, CA verify, deprecation guards, server --help, port validation, __thread io_ssl, shared accept loop
TapTap commented on pull request TapTap/FastSync#15 2026-07-16 16:55:39 +02:00
Bandwidth throttling: --bwlimit <KB/s> with token bucket

Code Review: Bandwidth throttling

Token bucket in send_n_data is a clean approach. Below are the issues I found.

CRITICAL

**1. __thread breaks bwlimit for multithreaded…

TapTap commented on pull request TapTap/FastSync#14 2026-07-16 16:49:40 +02:00
Incremental sync: --incremental to skip unchanged files

Code Review: Incremental sync

Overall the approach is solid — per-file SIZE+mtime check before transfer is the right design. Below are the issues I found.

BUGS

**1. Protocol…

TapTap commented on pull request TapTap/FastSync#13 2026-07-16 16:42:56 +02:00
TLS transport: OpenSSL-based encrypted TCP

Code Review: TLS transport

Overall this is a solid first TLS implementation. The architecture is clean and the integration with existing transport abstractions is well thought out. Below are…

TapTap created pull request TapTap/FastSync#15 2026-07-16 16:29:05 +02:00
Bandwidth throttling: --bwlimit <KB/s> with token bucket