TapTap
0 Followers · 0 Following
  • Joined on 2026-07-08
Repositories
4
 Projects Packages Public Activity Starred Repositories
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:48:06 +02:00
6a5a61b59f fix: address all remaining review warnings and style issues
TapTap commented on pull request TapTap/FastSync#47 2026-07-20 17:41:25 +02:00
Fix 11 Gitea issues — bugs, quality, security, and refactoring

=== PR RE-REVIEW SUMMARY === Branch: fix/gitea-issues (PR #47) Head commit: fd7e98c (1 new commit since last review) 5 critical issues from previous review: ALL FIXED ✓

=== REMAINING FINDINGS…

TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:32:54 +02:00
fd7e98cb25 fix: config_receive uninitialized server_host (CRITICAL-2) & protocol desync on sendfile+delta (CRITICAL-5)
TapTap deleted branch fix/ci-double-trigger from TapTap/FastSync 2026-07-20 17:32:11 +02:00
TapTap merged pull request TapTap/FastSync#75 2026-07-20 17:32:04 +02:00
ci: fix double CI runs on PR pushes
TapTap pushed to main at TapTap/FastSync 2026-07-20 17:32:04 +02:00
b71d132b17 Merge pull request 'ci: fix double CI runs on PR pushes' (#75) from fix/ci-double-trigger into main
e7634f6581 chore: load AGENTS.md as instructions and block direct pushes to main
00b6f2064b ci: only trigger push on main to avoid double CI runs
Compare 3 commits »
TapTap commented on pull request TapTap/FastSync#75 2026-07-20 17:30:39 +02:00
ci: fix double CI runs on PR pushes

=== PR REVIEW SUMMARY === Branch: fix/ci-double-trigger → main PR: #75 Files reviewed: 2 (own commits) Dimensions checked: code, build, CI, docs, quality

=== COMMITS REVIEWED === [1/2] 00b6f20…

TapTap commented on pull request TapTap/FastSync#47 2026-07-20 17:30:03 +02:00
Fix 11 Gitea issues — bugs, quality, security, and refactoring

=== PR REVIEW SUMMARY === Branch: fix/gitea-issues (PR #47) Head commit: 38be7c0 Files reviewed: 17 (13 .c files, 3 .h files, CMakeLists.txt, tests/runner.c, etc.)

=== FINDINGS SUMMARY === CRITICA…

TapTap pushed to fix/ci-double-trigger at TapTap/FastSync 2026-07-20 17:27:35 +02:00
e7634f6581 chore: load AGENTS.md as instructions and block direct pushes to main
TapTap created pull request TapTap/FastSync#75 2026-07-20 17:27:13 +02:00
ci: fix double CI runs on PR pushes
TapTap created branch fix/ci-double-trigger in TapTap/FastSync 2026-07-20 17:27:01 +02:00
TapTap pushed to fix/ci-double-trigger at TapTap/FastSync 2026-07-20 17:27:01 +02:00
00b6f2064b ci: only trigger push on main to avoid double CI runs
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:21:28 +02:00
41e814ad97 fix: cppcheck const warning & update architect agent with CI-wait instructions
9e1afd0764 fix: const-qualify dir_result to fix cppcheck style warning
Compare 2 commits »
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:18:01 +02:00
e2d8659d94 fix: clang-format formatting issues in client_send.c and file.c
TapTap pushed to fix/gitea-issues at TapTap/FastSync 2026-07-20 17:15:02 +02:00
0d7cb7230d fix: remove use-after-free in transport_ssh.c child process
TapTap opened issue TapTap/FastSync#70 2026-07-20 17:14:37 +02:00
TCP connections lack timeout/keepalive configuration
TapTap opened issue TapTap/FastSync#71 2026-07-20 17:14:37 +02:00
No test coverage for sendfile zero-copy transfer path
TapTap opened issue TapTap/FastSync#72 2026-07-20 17:14:37 +02:00
receive_str() has no size limit — potential memory exhaustion DoS
TapTap opened issue TapTap/FastSync#73 2026-07-20 17:14:37 +02:00
send_n_data SSL path does not handle SSL_ERROR_WANT_WRITE properly
TapTap opened issue TapTap/FastSync#74 2026-07-20 17:14:37 +02:00
data_create_empty with size 0 calls malloc(0) — undefined behavior per C standard