• Joined on 2026-07-08
TapTap pushed to merge-all-v2 at TapTap/FastSync 2026-07-21 18:09:11 +02:00
0bee82e863 fix: cppcheck const qualifiers
TapTap pushed to merge-all-v2 at TapTap/FastSync 2026-07-21 18:07:59 +02:00
bfc2b1f6eb fix: clang-format
TapTap pushed to merge-all-v2 at TapTap/FastSync 2026-07-21 18:07:04 +02:00
7436b3b148 chore: add build2/ to gitignore and remove from tracking
TapTap pushed to merge-all-v2 at TapTap/FastSync 2026-07-21 18:06:51 +02:00
a70ce5c4af fix: address all 7 review issues
TapTap commented on pull request TapTap/FastSync#143 2026-07-21 18:04:22 +02:00
Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs

Full Code Review — PR #143 (merge-all-v2)

Verdict: APPROVED (with critical issues to fix)

Build: PASSES (all 25 unit tests pass)


🔴 Critical Issues

CRIT-1: SSL…

TapTap closed pull request TapTap/FastSync#138 2026-07-21 18:01:14 +02:00
Security hardening: path traversal, TLS verification, DOS protections (#112-#118)
TapTap closed pull request TapTap/FastSync#139 2026-07-21 18:01:14 +02:00
CLI features: timeout, quiet, backup, stats, exclude-from, max-depth, log-file, queue-size (#95-#99, #103-#105)
TapTap closed pull request TapTap/FastSync#140 2026-07-21 18:01:14 +02:00
Protocol improvements: keepalive, abort, atomic writes, batch incremental check (#100-#102, #106)
TapTap closed pull request TapTap/FastSync#141 2026-07-21 18:01:14 +02:00
Performance: multi-threaded scanner, adaptive queue, compression skip, streaming, bw throttle (#107-#111)
TapTap closed pull request TapTap/FastSync#142 2026-07-21 18:01:14 +02:00
Tests: add transport module unit tests; Docs: update README (#39, #119)
TapTap created pull request TapTap/FastSync#143 2026-07-21 18:01:08 +02:00
Merge all 5 batch PRs: security, CLI features, protocol, performance, tests/docs
TapTap created branch merge-all-v2 in TapTap/FastSync 2026-07-21 18:01:04 +02:00
TapTap pushed to merge-all-v2 at TapTap/FastSync 2026-07-21 18:01:04 +02:00
415adf2077 Merge all 5 PRs: security, CLI features, protocol, performance, tests/docs
3b5d89fdb9 Merge remote-tracking branch 'origin/fix/tests-and-docs' into merge-all-v2
2e73c6dc13 Merge remote-tracking branch 'origin/fix/performance' into merge-all-v2
909d84b36e Merge remote-tracking branch 'origin/fix/protocol-improvements' into merge-all-v2
959e5eb959 Merge remote-tracking branch 'origin/fix/cli-features' into merge-all-v2
Compare 6 commits »
TapTap pushed to fix/protocol-improvements at TapTap/FastSync 2026-07-21 17:46:15 +02:00
6c730c9775 fix: const qualifier for scanner root_directory parameter
TapTap pushed to fix/cli-features at TapTap/FastSync 2026-07-21 17:46:14 +02:00
a6c471a97a fix: const qualifier for scanner root_directory parameter
TapTap pushed to fix/tests-and-docs at TapTap/FastSync 2026-07-21 17:46:07 +02:00
ab4bb84ed6 fix: const qualifier in test_transport_ssh.c
TapTap pushed to fix/protocol-improvements at TapTap/FastSync 2026-07-21 17:45:42 +02:00
8d38913e87 fix: const qualifier for scanner root_directory parameter
TapTap pushed to fix/cli-features at TapTap/FastSync 2026-07-21 17:45:41 +02:00
ca30d978f8 fix: const qualifier for scanner root_directory parameter
TapTap pushed to fix/security-hardening at TapTap/FastSync 2026-07-21 17:45:40 +02:00
7d14d2b672 fix: const qualifier for scanner root_directory parameter
TapTap pushed to fix/protocol-improvements at TapTap/FastSync 2026-07-21 17:45:31 +02:00
e9e50bb48a fix: const qualifier for scanner root_directory parameter