• Joined on 2026-07-08
TapTap closed issue TapTap/FastSync#326 2026-09-24 03:26:42 +02:00
quality: name remaining magic constants
TapTap commented on issue TapTap/FastSync#326 2026-09-24 03:26:42 +02:00
quality: name remaining magic constants

Fixed in PR #329. Named IDENTITY_MAX_NAME_LEN (255), SCANNER_RESULT_QUEUE_CAP (100), and SERVER_DEFAULT_MAX_CONNECTIONS (100) in the relevant headers. Closing as completed.

TapTap closed issue TapTap/FastSync#325 2026-09-24 03:26:42 +02:00
quality: decompose delete_walk_fd and delete_missing_args_budgeted_observed
TapTap commented on issue TapTap/FastSync#325 2026-09-24 03:26:42 +02:00
quality: decompose delete_walk_fd and delete_missing_args_budgeted_observed

Fixed in PR #329. delete_walk_fd is now a thin driver over delete_walk_child/with_trailing_slash/pass helpers; delete_missing_args_budgeted_observed is a thin loop over `delete_one_missing_…

TapTap closed issue TapTap/FastSync#324 2026-09-24 03:26:41 +02:00
quality: decompose server.c main()
TapTap commented on issue TapTap/FastSync#324 2026-09-24 03:26:41 +02:00
quality: decompose server.c main()

Fixed in PR #329. server.c main() reduced from 265 to 27 lines as a dispatcher over configure_server_process/run_hash_credentials_tool/run_stdio_server/run_daemon_server/`load_daemon_po…

TapTap closed issue TapTap/FastSync#323 2026-09-24 03:26:41 +02:00
quality: extract shared client connect/session setup and delete preamble
TapTap commented on issue TapTap/FastSync#323 2026-09-24 03:26:41 +02:00
quality: extract shared client connect/session setup and delete preamble

Fixed in PR #329. client_connect_and_bind_session() + client_prepare_files_from() replace the three copy-pasted session-setup blocks and the duplicated files-from preamble (client_send.c/client…

TapTap closed issue TapTap/FastSync#322 2026-09-24 03:26:41 +02:00
quality: share file-entry construction between the sequential and parallel scanners
TapTap commented on issue TapTap/FastSync#322 2026-09-24 03:26:41 +02:00
quality: share file-entry construction between the sequential and parallel scanners

Fixed in PR #329. A shared scanner_build_file_entry() now backs both scanners; scan_root_entry is split per node kind with a single goto done cleanup. A review caught a critical error-propaga…

TapTap closed issue TapTap/FastSync#321 2026-09-24 03:26:41 +02:00
quality: decompose receive_delta_file (236-line god function)
TapTap commented on issue TapTap/FastSync#321 2026-09-24 03:26:41 +02:00
quality: decompose receive_delta_file (236-line god function)

Fixed in PR #329. receive_delta_file is now a 43-line dispatcher over receive_delta_data_branch/receive_next_branch, each with a NULL-guarded fail: teardown replacing the ~12 repeated…

TapTap commented on issue TapTap/FastSync#319 2026-09-24 03:26:40 +02:00
parity: --fake-super faking for directories

Fixed in PR #329. --fake-super now records a directory's full stat in user.rsync.%stat on the directory itself and restores it (permission bits on disk, never real-chown), rsync 3.4.1-interoper…

TapTap deleted branch quality/refactor from TapTap/FastSync 2026-09-24 03:17:45 +02:00
TapTap pushed to dev at TapTap/FastSync 2026-09-24 03:17:44 +02:00
b7e95b8d96 Merge PR #329: quality cycle
13627e82fc fix: scan-root error propagation, link_target leak, delta guard, meta leak (review)
09ab81120e refactor(scanner): make cur_path const (cppcheck)
2a7afbda0a Merge branch 'quality/g325' into quality/refactor
bab6fcc706 Merge branch 'quality/g324' into quality/refactor
Compare 15 commits »
TapTap closed issue TapTap/FastSync#319 2026-09-24 03:17:42 +02:00
parity: --fake-super faking for directories
TapTap merged pull request TapTap/FastSync#329 2026-09-24 03:17:42 +02:00
quality: refactors (#321-#326) + fake-super directories (#319)
TapTap pushed to quality/refactor at TapTap/FastSync 2026-09-24 03:12:31 +02:00
13627e82fc fix: scan-root error propagation, link_target leak, delta guard, meta leak (review)
09ab81120e refactor(scanner): make cur_path const (cppcheck)
2a7afbda0a Merge branch 'quality/g325' into quality/refactor
bab6fcc706 Merge branch 'quality/g324' into quality/refactor
6a426cffa8 Merge branch 'quality/g323' into quality/refactor
Compare 10 commits »
TapTap created branch quality/refactor in TapTap/FastSync 2026-09-24 03:12:31 +02:00
TapTap created pull request TapTap/FastSync#329 2026-09-24 03:12:30 +02:00
quality: refactors (#321-#326) + fake-super directories (#319)