TapTap
3eec5a4cc3
#289 checksum/compression: - -c/--checksum now implies the incremental content quick-check (without implying -t), so an unchanged file is skipped like rsync. - --checksum-choice/--cc accepts xxh64/xxhash, xxh3, xxh128, md5 and auto; md4/sha1/none and the two-name form are rejected by name. - --compress-choice/--zc rejects lz4/zlib/zlibx by name (zstd/none/auto kept). - --checksum-seed=0 is randomized per transfer and sent on the wire. - --skip-compress uses rsync 3.4.1's default suffix list; slash separators and dot-less suffixes are accepted. - add --no-whole-file. #295 timeouts/alloc/temp-dir: - --timeout default 0 (disabled), --contimeout default 60; 0 disables both, plus --no-timeout/--no-contimeout. - --max-alloc=0 means no allocation limit (was rejected). - --temp-dir accepts any dir, requires it to exist, and falls back to a non-atomic copy on EXDEV instead of aborting. #296 connectivity/daemon: - -M/--remote-option is rejected for daemon/TCP destinations (SSH-only). - --trust-sender clarified as receiver-local; server-path tests added. - --stop-at accepts rsync's full date form (y-m-dTh:m etc.). Adds unit and integration coverage; no wire-field change, PROTOCOL_VERSION stays 2.22.0.
197 lines
7.6 KiB
C
197 lines
7.6 KiB
C
#include "test_stop.h"
|
|
#include "stop_condition.h"
|
|
#include "test_utils.h"
|
|
#include <limits.h>
|
|
#include <time.h>
|
|
|
|
static void test_stop_after_parse_valid() {
|
|
int minutes = 0;
|
|
EXPECT_TRUE(stop_parse_after_minutes("5", &minutes));
|
|
EXPECT_EQ_INT(minutes, 5);
|
|
EXPECT_TRUE(stop_parse_after_minutes("1", &minutes));
|
|
EXPECT_EQ_INT(minutes, 1);
|
|
EXPECT_TRUE(stop_parse_after_minutes("1440", &minutes));
|
|
EXPECT_EQ_INT(minutes, 1440);
|
|
EXPECT_TRUE(stop_parse_after_minutes("2147483647", &minutes));
|
|
EXPECT_EQ_INT(minutes, INT_MAX);
|
|
}
|
|
|
|
static void test_stop_after_parse_invalid() {
|
|
int minutes = 0;
|
|
EXPECT_FALSE(stop_parse_after_minutes("0", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("-1", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("abc", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("5x", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("1.5", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes(" 5", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes(" 5 ", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("+5", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes("2147483648", &minutes));
|
|
EXPECT_FALSE(stop_parse_after_minutes(NULL, &minutes));
|
|
}
|
|
|
|
static void test_stop_at_parse_hhmm() {
|
|
time_t now = 1700000000;
|
|
time_t deadline = 0;
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("12:30", now, &deadline));
|
|
struct tm t;
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_hour, 12);
|
|
EXPECT_EQ_INT(t.tm_min, 30);
|
|
EXPECT_EQ_INT(t.tm_sec, 0);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("12:30:59", now, &deadline));
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_hour, 12);
|
|
EXPECT_EQ_INT(t.tm_min, 30);
|
|
EXPECT_EQ_INT(t.tm_sec, 59);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("00:00", now, &deadline));
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_hour, 0);
|
|
EXPECT_EQ_INT(t.tm_min, 0);
|
|
EXPECT_EQ_INT(t.tm_sec, 0);
|
|
}
|
|
|
|
static void test_stop_at_parse_now_plus() {
|
|
time_t now = 1700000000;
|
|
time_t deadline = 0;
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("now+90s", now, &deadline));
|
|
EXPECT_EQ_INT(deadline, now + 90);
|
|
EXPECT_TRUE(stop_parse_at_time("now+5m", now, &deadline));
|
|
EXPECT_EQ_INT(deadline, now + 300);
|
|
EXPECT_TRUE(stop_parse_at_time("now+2h", now, &deadline));
|
|
EXPECT_EQ_INT(deadline, now + 7200);
|
|
EXPECT_TRUE(stop_parse_at_time("now+1d", now, &deadline));
|
|
EXPECT_EQ_INT(deadline, now + 86400);
|
|
EXPECT_TRUE(stop_parse_at_time("now+0s", now, &deadline));
|
|
EXPECT_EQ_INT(deadline, now);
|
|
}
|
|
|
|
static void test_stop_at_parse_invalid() {
|
|
time_t now = 1700000000;
|
|
time_t deadline = 0;
|
|
EXPECT_FALSE(stop_parse_at_time("1234", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("12:30:5", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("12:30:5x", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("24:00", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("12:60", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("12:30:61", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("12;00", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now+", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now+5", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now+5x", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now-5m", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now+1w", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now+ 5s", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("now++5s", now, &deadline));
|
|
/* Signed overflow of the destination deadline must be rejected, not wrap. */
|
|
EXPECT_FALSE(stop_parse_at_time("now+9223372036854775807s", now, &deadline));
|
|
/* 10^15 days is well beyond LONG_MAX/86400, so the amount itself is rejected. */
|
|
EXPECT_FALSE(stop_parse_at_time("now+1000000000000000d", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("abc", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time("", now, &deadline));
|
|
EXPECT_FALSE(stop_parse_at_time(NULL, now, &deadline));
|
|
}
|
|
|
|
/* rsync's flexible date form for --stop-at (y-m-dTh:m, with / separators and
|
|
* abbreviable fields). */
|
|
static void test_stop_at_parse_date_forms() {
|
|
time_t now = 1700000000;
|
|
time_t deadline = 0;
|
|
struct tm t;
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("2030-12-31T23:59", now, &deadline));
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_year + 1900, 2030);
|
|
EXPECT_EQ_INT(t.tm_mon + 1, 12);
|
|
EXPECT_EQ_INT(t.tm_mday, 31);
|
|
EXPECT_EQ_INT(t.tm_hour, 23);
|
|
EXPECT_EQ_INT(t.tm_min, 59);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("2030/12/31T23:59", now, &deadline));
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_year + 1900, 2030);
|
|
EXPECT_EQ_INT(t.tm_mon + 1, 12);
|
|
EXPECT_EQ_INT(t.tm_mday, 31);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("2030-12-31", now, &deadline));
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_year + 1900, 2030);
|
|
EXPECT_EQ_INT(t.tm_hour, 0);
|
|
EXPECT_EQ_INT(t.tm_min, 0);
|
|
|
|
/* Partial forms resolve to the next matching point in the future. */
|
|
EXPECT_TRUE(stop_parse_at_time(":59", now, &deadline));
|
|
EXPECT_TRUE(deadline > now);
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_min, 59);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("1-30", now, &deadline));
|
|
EXPECT_TRUE(deadline > now);
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_mon + 1, 1);
|
|
EXPECT_EQ_INT(t.tm_mday, 30);
|
|
|
|
EXPECT_TRUE(stop_parse_at_time("1", now, &deadline));
|
|
EXPECT_TRUE(deadline > now);
|
|
EXPECT_NOT_NULL(localtime_r(&deadline, &t));
|
|
EXPECT_EQ_INT(t.tm_mday, 1);
|
|
|
|
/* Seconds are not part of rsync's date form. */
|
|
EXPECT_FALSE(stop_parse_at_time("2030-12-31T23:59:59", now, &deadline));
|
|
}
|
|
|
|
static void test_stop_deadline_latency() {
|
|
struct timespec now;
|
|
EXPECT_EQ_INT(clock_gettime(CLOCK_MONOTONIC, &now), 0);
|
|
|
|
StopCondition future = stop_condition_make(true, 60, false, 0, now);
|
|
EXPECT_TRUE(future.has_monotonic);
|
|
EXPECT_EQ_INT(future.monotonic_deadline.tv_sec, now.tv_sec + 3600);
|
|
EXPECT_EQ_INT(future.monotonic_deadline.tv_nsec, now.tv_nsec);
|
|
EXPECT_FALSE(future.has_wall);
|
|
EXPECT_FALSE(stop_condition_reached(&future));
|
|
|
|
/* Move the 60-minute deadline into the past: the check now reports reached. */
|
|
StopCondition past = stop_condition_make(true, 60, false, 0, now);
|
|
past.monotonic_deadline.tv_sec -= 7200;
|
|
EXPECT_TRUE(stop_condition_reached(&past));
|
|
|
|
StopCondition no_after = stop_condition_make(false, 0, false, 0, now);
|
|
EXPECT_FALSE(no_after.has_monotonic);
|
|
EXPECT_FALSE(no_after.has_wall);
|
|
EXPECT_FALSE(stop_condition_reached(&no_after));
|
|
|
|
/* An invalid (non-positive) after_minutes never arms the monotonic half. */
|
|
StopCondition zero_after = stop_condition_make(true, 0, false, 0, now);
|
|
EXPECT_FALSE(zero_after.has_monotonic);
|
|
StopCondition neg_after = stop_condition_make(true, -5, false, 0, now);
|
|
EXPECT_FALSE(neg_after.has_monotonic);
|
|
|
|
/* --stop-at: a wall-clock deadline in the past/now is reached; one in the
|
|
future is not, and it stays independent of the monotonic half. */
|
|
StopCondition wall_future = stop_condition_make(false, 0, true, time(NULL) + 3600, now);
|
|
EXPECT_TRUE(wall_future.has_wall);
|
|
EXPECT_FALSE(wall_future.has_monotonic);
|
|
EXPECT_FALSE(stop_condition_reached(&wall_future));
|
|
|
|
StopCondition wall_past = stop_condition_make(false, 0, true, time(NULL) - 1, now);
|
|
EXPECT_TRUE(stop_condition_reached(&wall_past));
|
|
|
|
EXPECT_FALSE(stop_condition_reached(NULL));
|
|
}
|
|
|
|
void test_stop(void) {
|
|
test_stop_after_parse_valid();
|
|
test_stop_after_parse_invalid();
|
|
test_stop_at_parse_hhmm();
|
|
test_stop_at_parse_now_plus();
|
|
test_stop_at_parse_date_forms();
|
|
test_stop_at_parse_invalid();
|
|
test_stop_deadline_latency();
|
|
} |