CI / lint (pull_request) Successful in 52s
CI / sanitizers (address) (pull_request) Skipped
CI / sanitizers (undefined) (pull_request) Skipped
CI / fuzz-build (pull_request) Skipped
CI / coverage (pull_request) Skipped
CI / valgrind (pull_request) Skipped
CI / build-and-test (pull_request) Successful in 1m19s
Capture+transmit source atime (pre-read stat; O_NOATIME sender guard) and birth time (statx STATX_BTIME); receiver restores atime with mtime (crtime not settable portably -> transmitted, explicitly not applied). --open-noatime is client-only. -O/-J documented as accepted no-ops (FastSync never preserves dir/symlink times). Wire: metadata frame gains atime/crtime val+sec+nsec; PROTOCOL_VERSION 2.11.0->2.12.0. Review fixes: gate atime capture to Linux (no epoch clobber on non-Linux), close fd on fdopen failure, honest -O/-J status (Compat no-op).
320 lines
9.4 KiB
C
320 lines
9.4 KiB
C
#include "test_metadata.h"
|
|
#include "chmod.h"
|
|
#include "metadata.h"
|
|
#include "protocol.h"
|
|
#include "test_utils.h"
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
static void test_metadata_to_from_buf_roundtrip() {
|
|
FileMetadata original;
|
|
original.mode = 0755;
|
|
original.uid = 1000;
|
|
original.gid = 1000;
|
|
original.mtime_sec = 1234567890;
|
|
original.mtime_nsec = 500000000;
|
|
original.atime_valid = true;
|
|
original.atime_sec = 1234567000;
|
|
original.atime_nsec = 250000000;
|
|
original.crtime_valid = true;
|
|
original.crtime_sec = 1200000000;
|
|
original.crtime_nsec = 750000000;
|
|
|
|
char* buf = malloc(FILE_METADATA_WIRE_SIZE + sizeof(int));
|
|
EXPECT_NOT_NULL(buf);
|
|
char* write_ptr = buf;
|
|
metadata_to_buf(&write_ptr, &original);
|
|
|
|
char* read_ptr = buf;
|
|
FileMetadata* result = metadata_from_buf(&read_ptr);
|
|
|
|
EXPECT_NOT_NULL(result);
|
|
EXPECT_EQ_INT(result->mode, 0755);
|
|
EXPECT_EQ_INT(result->uid, 1000);
|
|
EXPECT_EQ_INT(result->gid, 1000);
|
|
EXPECT_EQ_INT(result->mtime_sec, 1234567890);
|
|
EXPECT_EQ_INT(result->mtime_nsec, 500000000);
|
|
EXPECT_TRUE(result->atime_valid);
|
|
EXPECT_EQ_INT(result->atime_sec, 1234567000);
|
|
EXPECT_EQ_INT(result->atime_nsec, 250000000);
|
|
EXPECT_TRUE(result->crtime_valid);
|
|
EXPECT_EQ_INT(result->crtime_sec, 1200000000);
|
|
EXPECT_EQ_INT(result->crtime_nsec, 750000000);
|
|
|
|
EXPECT_EQ_INT((int)(read_ptr - buf), (int)FILE_METADATA_WIRE_SIZE + (int)sizeof(int));
|
|
|
|
free(result);
|
|
free(buf);
|
|
}
|
|
|
|
static void test_metadata_to_buf_null() {
|
|
char* buf = malloc(FILE_METADATA_WIRE_SIZE + sizeof(int));
|
|
EXPECT_NOT_NULL(buf);
|
|
char* write_ptr = buf;
|
|
metadata_to_buf(&write_ptr, NULL);
|
|
|
|
char* read_ptr = buf;
|
|
int present;
|
|
memcpy(&present, read_ptr, sizeof(int));
|
|
EXPECT_EQ_INT(present, 0);
|
|
|
|
free(buf);
|
|
}
|
|
|
|
static void test_metadata_from_buf_null() {
|
|
char* buf = malloc(FILE_METADATA_WIRE_SIZE + sizeof(int));
|
|
EXPECT_NOT_NULL(buf);
|
|
int present = 0;
|
|
memcpy(buf, &present, sizeof(int));
|
|
|
|
char* read_ptr = buf;
|
|
const FileMetadata* result = metadata_from_buf(&read_ptr);
|
|
|
|
EXPECT_NULL(result);
|
|
|
|
free(buf);
|
|
}
|
|
|
|
static void test_metadata_send_receive_roundtrip() {
|
|
io_set_bwlimit(0);
|
|
int p[2];
|
|
EXPECT_EQ_INT(pipe(p), 0);
|
|
io_set_fds(p[0], p[1]);
|
|
|
|
FileMetadata original;
|
|
original.mode = 0755;
|
|
original.uid = 1000;
|
|
original.gid = 1000;
|
|
original.mtime_sec = 1234567890;
|
|
original.mtime_nsec = 500000000;
|
|
original.atime_valid = false;
|
|
original.atime_sec = 0;
|
|
original.atime_nsec = 0;
|
|
original.crtime_valid = true;
|
|
original.crtime_sec = 1200000000;
|
|
original.crtime_nsec = 750000000;
|
|
|
|
EXPECT_TRUE(metadata_send(p[1], &original));
|
|
|
|
int ok = 0;
|
|
FileMetadata* received = metadata_receive(p[0], &ok);
|
|
EXPECT_NOT_NULL(received);
|
|
EXPECT_EQ_INT(ok, 1);
|
|
EXPECT_EQ_INT(received->mode, 0755);
|
|
EXPECT_EQ_INT(received->uid, 1000);
|
|
EXPECT_EQ_INT(received->gid, 1000);
|
|
EXPECT_EQ_INT(received->mtime_sec, 1234567890);
|
|
EXPECT_EQ_INT(received->mtime_nsec, 500000000);
|
|
EXPECT_FALSE(received->atime_valid);
|
|
EXPECT_TRUE(received->crtime_valid);
|
|
EXPECT_EQ_INT(received->crtime_sec, 1200000000);
|
|
EXPECT_EQ_INT(received->crtime_nsec, 750000000);
|
|
|
|
free(received);
|
|
close(p[0]);
|
|
close(p[1]);
|
|
}
|
|
|
|
static void test_metadata_send_null() {
|
|
io_set_bwlimit(0);
|
|
int p[2];
|
|
EXPECT_EQ_INT(pipe(p), 0);
|
|
io_set_fds(p[0], p[1]);
|
|
|
|
EXPECT_TRUE(metadata_send(p[1], NULL));
|
|
|
|
int ok = 0;
|
|
const FileMetadata* received = metadata_receive(p[0], &ok);
|
|
EXPECT_NULL(received);
|
|
EXPECT_EQ_INT(ok, 1);
|
|
|
|
close(p[0]);
|
|
close(p[1]);
|
|
}
|
|
|
|
static void test_metadata_rejects_invalid_values() {
|
|
int p[2];
|
|
EXPECT_EQ_INT(pipe(p), 0);
|
|
io_set_fds(p[0], p[1]);
|
|
int32_t present = 2;
|
|
EXPECT_TRUE(send_n_data(p[1], &present, sizeof(present)));
|
|
int ok = 1;
|
|
EXPECT_NULL(metadata_receive(p[0], &ok));
|
|
EXPECT_EQ_INT(ok, 0);
|
|
close(p[0]);
|
|
close(p[1]);
|
|
}
|
|
|
|
/* metadata_receive must reject an out-of-range atime/crtime nsec even when the
|
|
* flag would otherwise be valid (defense-in-depth on the -U/-N wire fields). */
|
|
static void test_metadata_receive_rejects_bad_optional_times() {
|
|
int p[2];
|
|
EXPECT_EQ_INT(pipe(p), 0);
|
|
io_set_fds(p[0], p[1]);
|
|
|
|
int32_t present = 1;
|
|
int32_t mode = 0644;
|
|
int32_t uid = 1000;
|
|
int32_t gid = 1000;
|
|
int64_t mtime_sec = 1;
|
|
int64_t mtime_nsec = 0;
|
|
int32_t atime_valid = 1;
|
|
int64_t atime_sec = 1;
|
|
int64_t atime_nsec = 2000000000; /* invalid: >= 1e9 */
|
|
EXPECT_TRUE(send_n_data(p[1], &present, sizeof(present)));
|
|
EXPECT_TRUE(send_n_data(p[1], &mode, sizeof(mode)));
|
|
EXPECT_TRUE(send_n_data(p[1], &uid, sizeof(uid)));
|
|
EXPECT_TRUE(send_n_data(p[1], &gid, sizeof(gid)));
|
|
EXPECT_TRUE(send_n_data(p[1], &mtime_sec, sizeof(mtime_sec)));
|
|
EXPECT_TRUE(send_n_data(p[1], &mtime_nsec, sizeof(mtime_nsec)));
|
|
EXPECT_TRUE(send_n_data(p[1], &atime_valid, sizeof(atime_valid)));
|
|
EXPECT_TRUE(send_n_data(p[1], &atime_sec, sizeof(atime_sec)));
|
|
EXPECT_TRUE(send_n_data(p[1], &atime_nsec, sizeof(atime_nsec)));
|
|
int32_t crtime_valid = 0;
|
|
int64_t crtime_sec = 0;
|
|
int64_t crtime_nsec = 0;
|
|
EXPECT_TRUE(send_n_data(p[1], &crtime_valid, sizeof(crtime_valid)));
|
|
EXPECT_TRUE(send_n_data(p[1], &crtime_sec, sizeof(crtime_sec)));
|
|
EXPECT_TRUE(send_n_data(p[1], &crtime_nsec, sizeof(crtime_nsec)));
|
|
int ok = 1;
|
|
EXPECT_NULL(metadata_receive(p[0], &ok));
|
|
EXPECT_EQ_INT(ok, 0);
|
|
close(p[0]);
|
|
close(p[1]);
|
|
}
|
|
|
|
/* file_restore_metadata applies the source atime alongside mtime when -U
|
|
* captured it (atime_valid set). */
|
|
static void test_file_restore_metadata_applies_atime() {
|
|
const char* path = "temp_meta_atime_test.txt";
|
|
EXPECT_TRUE(file_write_to_disk(path, "atime", 5, false, false));
|
|
|
|
FileMetadata m;
|
|
m.mode = 0644;
|
|
m.uid = getuid();
|
|
m.gid = getgid();
|
|
m.mtime_sec = 1234567890;
|
|
m.mtime_nsec = 0;
|
|
m.atime_valid = true;
|
|
m.atime_sec = 999999999;
|
|
m.atime_nsec = 123456789;
|
|
m.crtime_valid = false;
|
|
m.crtime_sec = 0;
|
|
m.crtime_nsec = 0;
|
|
|
|
file_restore_metadata(path, &m, false);
|
|
|
|
struct stat st;
|
|
EXPECT_EQ_INT(stat(path, &st), 0);
|
|
EXPECT_EQ_INT((int)st.st_mtime, 1234567890);
|
|
#ifdef __linux__
|
|
EXPECT_EQ_INT((int)st.st_atime, 999999999);
|
|
#else
|
|
EXPECT_EQ_INT((int)st.st_atime, 999999999);
|
|
#endif
|
|
|
|
unlink(path);
|
|
}
|
|
|
|
static void test_metadata_mtime_window() {
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 100000000, 101, 600000000, 2));
|
|
EXPECT_FALSE(metadata_mtime_matches(100, 100000000, 102, 600000000, 2));
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 100000000, 102, 100000000, 2));
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 900000000, 102, 100000000, 2));
|
|
EXPECT_FALSE(metadata_mtime_matches(100, 100000000, 102, 900000000, 2));
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 900000000, 102, 900000000, 2));
|
|
EXPECT_FALSE(metadata_mtime_matches(100, 900000000, 101, 100000001, 0));
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 100000000, 100, 100000001, 0));
|
|
EXPECT_TRUE(metadata_mtime_matches(100, 100000000, 100, 100000000, 0));
|
|
}
|
|
|
|
static void test_file_restore_metadata() {
|
|
const char* path = "temp_meta_restore_test.txt";
|
|
const char* content = "test content";
|
|
EXPECT_TRUE(file_write_to_disk(path, content, strlen(content), false, false));
|
|
|
|
FileMetadata m;
|
|
m.mode = 0644;
|
|
m.uid = getuid();
|
|
m.gid = getgid();
|
|
m.mtime_sec = 1234567890;
|
|
m.mtime_nsec = 0;
|
|
|
|
file_restore_metadata(path, &m, false);
|
|
|
|
struct stat st;
|
|
EXPECT_EQ_INT(stat(path, &st), 0);
|
|
EXPECT_EQ_INT(st.st_mode & 07777, 0644);
|
|
EXPECT_EQ_INT((int)st.st_mtime, 1234567890);
|
|
|
|
unlink(path);
|
|
}
|
|
|
|
static void test_file_restore_executability_only() {
|
|
const char* path = "temp_exec_restore_test.txt";
|
|
EXPECT_TRUE(file_write_to_disk(path, "x", 1, false, false));
|
|
EXPECT_EQ_INT(chmod(path, 0644), 0);
|
|
|
|
FileMetadata m = {
|
|
.mode = 0751, .uid = getuid(), .gid = getgid(), .mtime_sec = 0, .mtime_nsec = 0};
|
|
file_restore_metadata(path, &m, true);
|
|
|
|
struct stat st;
|
|
EXPECT_EQ_INT(stat(path, &st), 0);
|
|
EXPECT_EQ_INT(st.st_mode & 0777, 0755);
|
|
unlink(path);
|
|
}
|
|
|
|
static void test_directory_restore_executability_only() {
|
|
const char* path = "temp_exec_restore_test_dir";
|
|
EXPECT_EQ_INT(mkdir(path, 0700), 0);
|
|
|
|
FileMetadata m = {
|
|
.mode = 0755, .uid = getuid(), .gid = getgid(), .mtime_sec = 0, .mtime_nsec = 0};
|
|
file_restore_metadata(path, &m, true);
|
|
|
|
struct stat st;
|
|
EXPECT_EQ_INT(stat(path, &st), 0);
|
|
EXPECT_EQ_INT(st.st_mode & 0777, 0711);
|
|
rmdir(path);
|
|
}
|
|
|
|
static void test_chmod_changes() {
|
|
mode_t result;
|
|
EXPECT_TRUE(chmod_apply(0777, "u=rw,go=r", &result));
|
|
EXPECT_EQ_INT(result, 0644);
|
|
EXPECT_TRUE(chmod_apply(0644, "a+x", &result));
|
|
EXPECT_EQ_INT(result, 0755);
|
|
result = 0777;
|
|
EXPECT_TRUE(chmod_apply(0777, "0000", &result));
|
|
EXPECT_EQ_INT(result, 0000);
|
|
result = 0777;
|
|
EXPECT_TRUE(chmod_apply(0777, "7777", &result));
|
|
EXPECT_EQ_INT(result, 07777);
|
|
result = 0777;
|
|
EXPECT_TRUE(chmod_apply(0777, "755", &result));
|
|
EXPECT_EQ_INT(result, 0755);
|
|
EXPECT_FALSE(chmod_apply(0777, "888", &result));
|
|
EXPECT_FALSE(chmod_apply(0777, "10000", &result));
|
|
EXPECT_FALSE(chmod_apply(0777, "a+X", &result));
|
|
EXPECT_FALSE(chmod_apply(0777, "a+r,", &result));
|
|
}
|
|
|
|
void test_metadata() {
|
|
test_metadata_to_from_buf_roundtrip();
|
|
test_metadata_to_buf_null();
|
|
test_metadata_from_buf_null();
|
|
test_metadata_send_receive_roundtrip();
|
|
test_metadata_send_null();
|
|
test_metadata_rejects_invalid_values();
|
|
test_metadata_receive_rejects_bad_optional_times();
|
|
test_metadata_mtime_window();
|
|
test_file_restore_metadata();
|
|
test_file_restore_metadata_applies_atime();
|
|
test_file_restore_executability_only();
|
|
test_directory_restore_executability_only();
|
|
test_chmod_changes();
|
|
}
|