quality: name remaining magic constants #326

Closed
opened 2026-09-23 02:10:50 +02:00 by TapTap · 1 comment
Owner

Unnamed literals: strlen(map->to_name) > 255 in src/shared/identity.c:279; scanner queue cap 100 duplicated in both scanners; server->max_connections = 100.

Work: define IDENTITY_MAX_NAME_LEN 255, SCANNER_RESULT_QUEUE_CAP 100, SERVER_DEFAULT_MAX_CONNECTIONS 100 in the relevant headers.

Unnamed literals: `strlen(map->to_name) > 255` in `src/shared/identity.c:279`; scanner queue cap `100` duplicated in both scanners; `server->max_connections = 100`. **Work:** define `IDENTITY_MAX_NAME_LEN 255`, `SCANNER_RESULT_QUEUE_CAP 100`, `SERVER_DEFAULT_MAX_CONNECTIONS 100` in the relevant headers.
TapTap added the quality label 2026-09-23 02:10:50 +02:00
Author
Owner

Fixed in PR #329. Named IDENTITY_MAX_NAME_LEN (255), SCANNER_RESULT_QUEUE_CAP (100), and SERVER_DEFAULT_MAX_CONNECTIONS (100) in the relevant headers. Closing as completed.

Fixed in PR #329. Named `IDENTITY_MAX_NAME_LEN` (255), `SCANNER_RESULT_QUEUE_CAP` (100), and `SERVER_DEFAULT_MAX_CONNECTIONS` (100) in the relevant headers. Closing as completed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#326