Fixed in PR #329. delete_walk_fd is now a thin driver over delete_walk_child/with_trailing_slash/pass helpers; delete_missing_args_budgeted_observed is a thin loop over delete_one_missing_arg/delete_nonempty_missing_dir with a MissingArgStep preserving the original control flow. Behavior-preserving. Closing as completed.
Fixed in PR #329. `delete_walk_fd` is now a thin driver over `delete_walk_child`/`with_trailing_slash`/pass helpers; `delete_missing_args_budgeted_observed` is a thin loop over `delete_one_missing_arg`/`delete_nonempty_missing_dir` with a `MissingArgStep` preserving the original control flow. Behavior-preserving. Closing as completed.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
src/shared/delete.c:197-415(delete_walk_fd, 219 lines) duplicates the child-walk block and the trailing-slash construction;src/shared/delete_commit.c:218-376(delete_missing_args_budgeted_observed, 159 lines) mixes validation, skip-prefix protection, secure parent walking,--max-deleteaccounting, removal, recursion, and observers.Work: extract
delete_walk_child(), awith_trailing_slash()helper,delete_one_missing_arg(), anddelete_nonempty_missing_dir().Fixed in PR #329.
delete_walk_fdis now a thin driver overdelete_walk_child/with_trailing_slash/pass helpers;delete_missing_args_budgeted_observedis a thin loop overdelete_one_missing_arg/delete_nonempty_missing_dirwith aMissingArgSteppreserving the original control flow. Behavior-preserving. Closing as completed.