src/shared/incremental_check.c:47-282 handles both delta-data and next branches plus signing/deserialization/decompression/metadata/xattr/size validation, with the trio free(old_data); delta_signature_destroy(sig); *failed = true; return NULL; repeated ~12x.
Work: introduce a fail: label doing common teardown (NULL-guarded), split the two branches into helpers, and drop the dead if (!old_data) check at 49-53.
`src/shared/incremental_check.c:47-282` handles both delta-data and next branches plus signing/deserialization/decompression/metadata/xattr/size validation, with the trio `free(old_data); delta_signature_destroy(sig); *failed = true; return NULL;` repeated ~12x.
**Work:** introduce a `fail:` label doing common teardown (NULL-guarded), split the two branches into helpers, and drop the dead `if (!old_data)` check at 49-53.
Fixed in PR #329. receive_delta_file is now a 43-line dispatcher over receive_delta_data_branch/receive_next_branch, each with a NULL-guarded fail: teardown replacing the ~12 repeated cleanup blocks; the dead !old_data check was removed (and a missing basis guard restored in review). Behavior-preserving. Closing as completed.
Fixed in PR #329. `receive_delta_file` is now a 43-line dispatcher over `receive_delta_data_branch`/`receive_next_branch`, each with a NULL-guarded `fail:` teardown replacing the ~12 repeated cleanup blocks; the dead `!old_data` check was removed (and a missing basis guard restored in review). Behavior-preserving. Closing as completed.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
src/shared/incremental_check.c:47-282handles both delta-data and next branches plus signing/deserialization/decompression/metadata/xattr/size validation, with the triofree(old_data); delta_signature_destroy(sig); *failed = true; return NULL;repeated ~12x.Work: introduce a
fail:label doing common teardown (NULL-guarded), split the two branches into helpers, and drop the deadif (!old_data)check at 49-53.Fixed in PR #329.
receive_delta_fileis now a 43-line dispatcher overreceive_delta_data_branch/receive_next_branch, each with a NULL-guardedfail:teardown replacing the ~12 repeated cleanup blocks; the dead!old_datacheck was removed (and a missing basis guard restored in review). Behavior-preserving. Closing as completed.