Docs: RSYNC_COMPAT.md/README overclaim parity and stale facts #297

Closed
opened 2026-09-15 19:33:35 +02:00 by TapTap · 1 comment
Owner

Audit findings (documentation only).

  • Summary claims 143 ✅ / 0 divergence / 0 partial, which is misleading: many ✅ rows embed documented rsync divergences, and some (e.g. -r, -b, -L shorts) are not parsed at all.
  • The §8 row labeled -M, --preserve conflates two flags: -M is --remote-option; --preserve is FastSync-only (-p+-t).
  • §15 "1 GB per connection" is wrong: MAX_CONNECTION_MEMORY is 256 MiB.
  • --rsync-path is claimed to cross the wire; fastsync_server_path is client-only.
  • -p row should state the group/other-write (and file setuid/setgid/sticky) masking divergence.
  • -D is ✅ but implies the --specials socket case.
  • Fake-super row text elsewhere says "no replay" while replay exists.

Fix: correct these statements and reclassify rows that are not true parity.

Audit findings (documentation only). - Summary claims 143 ✅ / 0 divergence / 0 partial, which is misleading: many ✅ rows embed documented rsync divergences, and some (e.g. `-r`, `-b`, `-L` shorts) are not parsed at all. - The §8 row labeled `-M, --preserve` conflates two flags: `-M` is `--remote-option`; `--preserve` is FastSync-only (`-p`+`-t`). - §15 "1 GB per connection" is wrong: `MAX_CONNECTION_MEMORY` is 256 MiB. - `--rsync-path` is claimed to cross the wire; `fastsync_server_path` is client-only. - `-p` row should state the group/other-write (and file setuid/setgid/sticky) masking divergence. - `-D` is ✅ but implies the `--specials` socket case. - Fake-super row text elsewhere says "no replay" while replay exists. Fix: correct these statements and reclassify rows that are not true parity.
TapTap added the needs-triage label 2026-09-15 19:33:35 +02:00
Author
Owner

Fixed. The summary tally is now accurate (117 ✅ / 13 ⚠️ / 27 ❌), -M/--preserve are separate rows, §15 says 256 MiB, --rsync-path is client-only, the -p masking divergence is stated, -D sockets are covered, fake-super replay is described, -F and -i were reclassified ✅ → ⚠️, and stale --bwlimit/munge/checksum bullets were corrected. Closing as completed.

Fixed. The summary tally is now accurate (117 ✅ / 13 ⚠️ / 27 ❌), `-M`/`--preserve` are separate rows, §15 says 256 MiB, `--rsync-path` is client-only, the `-p` masking divergence is stated, `-D` sockets are covered, fake-super replay is described, `-F` and `-i` were reclassified ✅ → ⚠️, and stale `--bwlimit`/munge/checksum bullets were corrected. Closing as completed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#297