Identity maps/chown/fake-super parity #294

Closed
opened 2026-09-15 19:33:35 +02:00 by TapTap · 1 comment
Owner

Audit findings.

  • --usermap/--groupmap accept only FROM:TO with */@N/names resolved on the sender; rsync supports ranges (0-99), globs, empty-FROM (:nobody), and receiver-side names. Documented partly.
  • --chown mixed with a prior --usermap is silently accepted (usermap wins); rsync errors on the conflict.
  • --fake-super: FastSync real-chowns the recorded source owner in addition to storing the xattr (rsync never real-chowns — that is the point), and clobbers an explicit --chown/--usermap result applied earlier by the normal path, unless --copy-as is active.

Fix: document/align; ensure --fake-super honors the resolved mapping or skips the redundant live chown; add combination tests.

Audit findings. - `--usermap`/`--groupmap` accept only `FROM:TO` with `*`/`@N`/names resolved on the sender; rsync supports ranges (`0-99`), globs, empty-FROM (`:nobody`), and receiver-side names. Documented partly. - `--chown` mixed with a prior `--usermap` is silently accepted (usermap wins); rsync errors on the conflict. - `--fake-super`: FastSync real-chowns the recorded source owner in addition to storing the xattr (rsync never real-chowns — that is the point), and clobbers an explicit `--chown`/`--usermap` result applied earlier by the normal path, unless `--copy-as` is active. Fix: document/align; ensure `--fake-super` honors the resolved mapping or skips the redundant live chown; add combination tests.
TapTap added the needs-triage label 2026-09-15 19:33:35 +02:00
Author
Owner

Fixed. --usermap/--groupmap support ranges, empty-FROM, @N, *, receiver-resolved TO names, and (PR #308) FROM name globs expanded sender-side against the passwd/group DB, bounded by MAX_IDENTITY_MAP; --chown + same-side map is now a hard error; --fake-super never real-chowns and honors the resolved mapping. Closing as completed.

Fixed. `--usermap`/`--groupmap` support ranges, empty-FROM, `@N`, `*`, receiver-resolved TO names, and (PR #308) FROM **name globs** expanded sender-side against the passwd/group DB, bounded by `MAX_IDENTITY_MAP`; `--chown` + same-side map is now a hard error; `--fake-super` never real-chowns and honors the resolved mapping. Closing as completed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TapTap/FastSync#294