Merge pull request 'Comprehensive fix: security, bugs, refactoring, tests, and rsync parity features' (#173) from integration/all-fixes into main

src/server/server.c

@@ -126,7 +126,8 @@ void handler(int file_descriptor) {
       close(file_descriptor);
       return;
     }
-    PipelineContextReceiver* context = pipeline_context_receiver_create(config, q, file_descriptor, ssl);
+    PipelineContextReceiver* context =
+        pipeline_context_receiver_create(config, q, file_descriptor, ssl);
     if (context == NULL) {
       queue_destroy(q);
       config_delete(config);

src/shared/multiprocessing.c

@@ -54,7 +54,7 @@ void pipeline_context_sender_destroy(PipelineContextSender* context) {
 }
 
 PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue,
-                                                           int file_descriptor, SSL* ssl) {
+                                                          int file_descriptor, SSL* ssl) {
   PipelineContextReceiver* context = malloc(sizeof(PipelineContextReceiver));
   if (context == NULL)
     return NULL;
@@ -148,7 +148,7 @@ int receive_thread(void* pipeline_context) {
         }
         char* full_path = path_cat(config->receive_root_directory, check_path);
         struct stat st;
-        bool has_old = full_path && stat(full_path, &st) == 0;
+        bool has_old = full_path && lstat(full_path, &st) == 0;
         bool match = has_old && (unsigned long long)st.st_size == check_size &&
                      (long long)st.st_mtime == check_mtime;
         if (match)

src/shared/multiprocessing.h

@@ -40,7 +40,7 @@ PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* que
                                                       Queue* queue_loader);
 void pipeline_context_sender_destroy(PipelineContextSender* context);
 PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue_receiver,
-                                                           int file_descriptor, SSL* ssl);
+                                                          int file_descriptor, SSL* ssl);
 void pipeline_context_receiver_destroy(PipelineContextReceiver* context);
 int receive_thread(void* pipeline_context);
 int write_thread(void* pipeline_context);

tests/test_multiprocessing.c

@@ -116,7 +116,6 @@ static void test_receiver_fd_zero() {
   pipeline_context_receiver_destroy(ctx);
 }
 
-
 /* Test that receive_thread completes cleanly when sent FINISHED immediately */
 static void test_receive_thread_finished() {
   Config* cfg = config_create();