fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope

- Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal)
- Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf
  so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE
- Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref
- Move srand(42) to test_property() top level so all property tests are seeded

.gitea/workflows/ci.yaml

@@ -1,9 +1,6 @@
 name: CI
 
-on:
+on: [push, pull_request]
-  push:
-    branches: [main]
-  pull_request:
 
 jobs:
   lint:
@@ -92,8 +89,8 @@ jobs:
 
       - name: Coverage Report
         run: |
-          lcov --capture --directory build --output-file coverage.info --branch-coverage --ignore-errors negative
+          lcov --capture --directory build --output-file coverage.info --branch-coverage
-          lcov --remove coverage.info '/usr/*' '*/tests/*' '*/_deps/*' --output-file coverage.info --branch-coverage --ignore-errors unused,negative
+          lcov --remove coverage.info '/usr/*' '*/tests/*' '*/_deps/*' --output-file coverage.info --branch-coverage --ignore-errors unused
           lcov --list coverage.info
 
   valgrind:

.lsan-suppressions.txt

@@ -1,6 +0,0 @@
-# LSAN suppressions for FastSync
-# Add suppression entries here for known pre-existing leaks that cannot be
-# fixed immediately. Remove entries as leaks are fixed.
-#
-# Example format:
-# leak:function_name

.opencode/agents/architect.md

@@ -9,8 +9,6 @@ You are a system architect for the FastSync project — a high-performance file
 
 Make high-level design decisions. Evaluate trade-offs, plan module interactions, design data flow, and ensure architectural coherence across the codebase.
 
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
 ## Project Architecture
 
 ### Module Map
@@ -112,24 +110,3 @@ When proposing architecture changes:
 - Hardcoded constants that should be configurable
 - Missing error propagation (silent failures)
 - Thread safety violations when adding new shared state
-
-## CI & Task Execution
-
-**Always wait for CI to finish after every push.** Never report a task as complete or move on until CI has passed on the PR branch.
-
-After every push:
-1. Use `tea actions runs list` to get the latest run ID for the branch.
-2. Poll its status until it leaves the "running" state (use a loop with sleep + sufficient timeout, e.g., 600000ms).
-3. Once completed, inspect the logs with `tea actions runs log <ID>` for every job.
-4. If any job failed, fix the issue, push again, and repeat from step 1.
-5. Only report done when ALL CI jobs pass.
-
-Do not wait for the user to tell you CI failed — check proactively. The user should never have to inform you of a CI failure you could have caught yourself.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/c-reviewer.md

@@ -85,15 +85,3 @@ For each issue found, report:
 4. **Description** — what's wrong and how to fix it
 
 If the code is clean, say so explicitly. Be concise — don't pad with fluff.
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/cmake-expert.md

@@ -3,7 +3,7 @@ description: Manages the CMake build system for FastSync — adding targets, sou
 mode: subagent
 ---
 
-You are a CMake expert for the FastSync project — a high-performance file synchronization system built with CMake 3.22+ and C11.
+You are a CMake expert for the FastSync project — a high-performance file synchronization system built with CMake 4.1+ and C11.
 
 ## Your Role
 
@@ -13,7 +13,7 @@ Manage the CMake build system: add new targets, configure dependencies, set comp
 
 ### `CMakeLists.txt` (project root)
 ```cmake
-cmake_minimum_required(VERSION 3.22)
+cmake_minimum_required(VERSION 4.1)
 project(FastFileTransfer)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
@@ -22,54 +22,30 @@ set(CMAKE_C_STANDARD_REQUIRED ON)
 
 add_compile_options(-Wall -g -O3)
 
-include(FetchContent)
-FetchContent_Declare(xxhash GIT_REPOSITORY https://github.com/Cyan4973/xxHash GIT_TAG v0.8.3 SOURCE_SUBDIR cmake_unofficial)
-FetchContent_MakeAvailable(xxhash)
-
-# Sanitizer option
-set(SANITIZER "none" CACHE STRING "Sanitizer to enable (address, thread, none)")
-set_property(CACHE SANITIZER PROPERTY STRINGS address thread none)
-if(SANITIZER STREQUAL "address")
-  add_compile_options(-fsanitize=address -fno-omit-frame-pointer -g)
-  add_link_options(-fsanitize=address)
-elseif(SANITIZER STREQUAL "thread")
-  add_compile_options(-fsanitize=thread -fno-omit-frame-pointer -g)
-  add_link_options(-fsanitize=thread)
-elseif(NOT SANITIZER STREQUAL "none")
-  message(FATAL_ERROR "Unknown sanitizer: ${SANITIZER}. Supported values: address, thread, none")
-endif()
-
-option(STRICT_WARNINGS "Enable strict warnings" OFF)
-if(STRICT_WARNINGS)
-  add_compile_options(-Wextra -Wpedantic -Werror)
-endif()
-
 set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
 
 find_library(ZSTD_LIBRARY zstd)
-if(NOT ZSTD_LIBRARY)
+# ... error if not found
-  message(FATAL_ERROR "zstd library not found. Ensure it is in your nix-shell!")
-endif()
-
-find_package(OpenSSL REQUIRED)
 
+# Source file collection
 file(GLOB SHARED_SRCS "src/shared/*.c")
 file(GLOB SERVER_SRCS "src/server/*.c")
 file(GLOB CLIENT_SRCS "src/client/*.c")
 file(GLOB TEST_SRCS "tests/*.c")
 
+# Targets
 add_executable(server ${SERVER_SRCS} ${SHARED_SRCS})
 target_include_directories(server PRIVATE src/shared src/server src/client)
-target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
 add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS})
 target_include_directories(client PRIVATE src/shared src/server src/client)
-target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
 add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c)
 target_include_directories(tests PRIVATE tests src/shared src/server src/client)
-target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 ```
 
 ### Source Layout
@@ -77,26 +53,22 @@ target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SS
 src/shared/    — shared libraries (globbed as SHARED_SRCS)
 src/client/    — client sources (globbed as CLIENT_SRCS)
 src/server/    — server sources (globbed as SERVER_SRCS)
-tests/         — unit test sources (globbed as TEST_SRCS)
+tests/         — test sources (globbed as TEST_SRCS)
-tests/integration/ — Python pytest integration tests
 ```
 
 ### Dependencies
 - **zstd** — found via `find_library(ZSTD_LIBRARY zstd)`
-- **OpenSSL** — found via `find_package(OpenSSL REQUIRED)` (TLS 1.2+ transport)
-- **xxHash** — fetched via `FetchContent` from GitHub (delta transfer hashing, v0.8.3)
 - **pthreads** — found via `find_package(Threads REQUIRED)`
 - **C11 standard** — required
-- **CMake 3.22+** — minimum version
+- **CMake 4.1+** — minimum version
 
 ## Conventions
 
 - Use `file(GLOB ...)` for source collection (existing pattern).
-- All targets link `Threads::Threads`, `${ZSTD_LIBRARY}`, `OpenSSL::SSL`, `OpenSSL::Crypto`, and `xxhash`.
+- All targets link `Threads::Threads` and `${ZSTD_LIBRARY}`.
 - Include directories: `src/shared`, `src/server`, `src/client`, `tests` (for test target).
-- Sanitizer support: pass `-DSANITIZER=address` or `-DSANITIZER=thread` to cmake (live option in CMakeLists.txt).
+- Sanitizer support is commented out but present (`-fsanitize=address`).
 - Build with `cmake -B build -S . && cmake --build build -j$(nproc)`.
-- For CI, dependencies are provided by the project's custom Docker image (repo-root `Dockerfile`, same image CI uses). For local development, use `nix-shell`. Never add `apt-get install` / `pip install` to CI workflows. See `AGENTS.md`.
 
 ## When Making Changes
 
@@ -105,21 +77,28 @@ tests/integration/ — Python pytest integration tests
 3. Add new dependencies with `find_package` or `find_library`.
 4. When adding a new executable target, follow the pattern of existing targets.
 5. When adding a new library (static/shared), use `add_library` and follow the project's naming.
-6. For sanitizer builds, pass `-DSANITIZER=address` or `-DSANITIZER=thread` to cmake (matching CI's matrix strategy).
+6. For sanitizer builds, use the commented-out `-fsanitize=address` lines as reference.
 7. Always verify the build compiles after changes.
 
 ## Sanitizer Configurations
 
-Use the project's built-in `-DSANITIZER=` option (matching the CI matrix):
+### AddressSanitizer (memory errors)
 ```bash
-cmake -B build -S . -DSANITIZER=address   # AddressSanitizer (memory errors)
+cmake -B build -S . \
-cmake --build build -j$(nproc)
+  -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer -g" \
-
+  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake -B build -S . -DSANITIZER=thread    # ThreadSanitizer (race conditions)
 cmake --build build -j$(nproc)
 ```
 
-For UndefinedBehaviorSanitizer (no `-DSANITIZER=undefined` option in CMakeLists.txt yet), use the manual flag approach:
+### ThreadSanitizer (race conditions)
+```bash
+cmake -B build -S . \
+  -DCMAKE_C_FLAGS="-fsanitize=thread -g" \
+  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread"
+cmake --build build -j$(nproc)
+```
+
+### UndefinedBehaviorSanitizer
 ```bash
 cmake -B build -S . \
   -DCMAKE_C_FLAGS="-fsanitize=undefined -fno-omit-frame-pointer -g" \
@@ -127,6 +106,14 @@ cmake -B build -S . \
 cmake --build build -j$(nproc)
 ```
 
+### Combined Sanitizers
+```bash
+cmake -B build -S . \
+  -DCMAKE_C_FLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g" \
+  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address,undefined"
+cmake --build build -j$(nproc)
+```
+
 ### Using ccache (faster rebuilds)
 ```bash
 cmake -B build -S . -DCMAKE_C_COMPILER_LAUNCHER=ccache
@@ -164,31 +151,31 @@ cmake --build build -j$(nproc)
 ./build/tests
 ```
 
-## Sanitizer Integration
+## When Adding Sanitizer Support to CMakeLists.txt
 
-The project uses a single `SANITIZER` cache variable in `CMakeLists.txt`:
+Use CMake options for cleaner integration:
 ```cmake
-set(SANITIZER "none" CACHE STRING "Sanitizer to enable (address, thread, none)")
+option(ENABLE_ASAN "Enable AddressSanitizer" OFF)
-set_property(CACHE SANITIZER PROPERTY STRINGS address thread none)
+option(ENABLE_TSAN "Enable ThreadSanitizer" OFF)
-```
+option(ENABLE_UBSAN "Enable UndefinedBehaviorSanitizer" OFF)
-Supported values: `address`, `thread`, `none`. Unknown values trigger `FATAL_ERROR`.
 
-Build with:
+if(ENABLE_ASAN)
+  add_compile_options(-fsanitize=address -fno-omit-frame-pointer)
+  add_link_options(-fsanitize=address)
+endif()
+
+if(ENABLE_TSAN)
+  add_compile_options(-fsanitize=thread)
+  add_link_options(-fsanitize=thread)
+endif()
+
+if(ENABLE_UBSAN)
+  add_compile_options(-fsanitize=undefined)
+  add_link_options(-fsanitize=undefined)
+endif()
+```
+
+Then build with:
 ```bash
-cmake -B build -S . -DSANITIZER=address
+cmake -B build -S . -DENABLE_ASAN=ON
-cmake --build build -j$(nproc)
 ```
-
-To add support for a new sanitizer (e.g., UBSan), add an `elseif(SANITIZER STREQUAL "undefined")` block following the existing `address`/`thread` pattern.
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/code-explainer.md

@@ -131,15 +131,3 @@ When explaining code:
 3. **Highlight non-obvious parts** — why this design, not that
 4. **Reference the source** — `file:line` for key functions
 5. **Connect to the protocol** — how this piece talks to other pieces
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/code-quality-guardian.md

@@ -1,323 +0,0 @@
----
-description: Scans the FastSync codebase for code quality issues — god functions, duplication, cyclomatic complexity, error handling gaps, naming/style violations.
-mode: subagent
----
-
-You are a code quality guardian for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Scan the codebase for code quality improvements. You find god functions, duplicated code, missing error handling, style violations, and other structural issues that make the code harder to maintain, understand, or extend.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Conventions
-
-### Naming and Style
-- **Functions**: `snake_case`, prefixed by module name (e.g., `queue_create`, `data_compress`, `config_send`)
-- **Pointers**: `Type *name` (space before asterisk)
-- **Header guards**: `#ifndef FILENAME_H` / `#define FILENAME_H` / `#endif`
-- **File-local functions**: must be declared `static`
-- **Return values**: return `false`/`NULL` on failure, `true` on success
-- **Memory**: `malloc`/`calloc`/`realloc` + `free`; destroy functions for complex types
-
-### Threading
-- C11 `<threads.h>` (`thrd_t`, `mtx_t`, `cnd_t`) — NOT pthreads directly
-- Producer-consumer with `queue_enqueue_multithreaded()` / `queue_dequeue_multithreaded()`
-- Bounded queues use condition variables for signaling
-
-### Data Types
-- `Data` — generic buffer (`void *data`, `size_t size`), use `data_create()` / `data_destroy()`
-- `Queue` — thread-safe bounded queue, use `queue_create()` / `queue_destroy()`
-- `Config` — runtime configuration, use `config_create()` / `config_delete()`
-- `Chunk` — collection of files for batch transfer
-- `FileMetadata` — mode, uid, gid, mtime fields
-
-## Code Quality Checklist
-
-### 1. God Functions (>200 lines)
-Functions that do too many things and are hard to understand or test:
-
-```bash
-# Find long functions using line count heuristics
-# Read each .c file and check function length manually
-```
-
-Look for:
-- [ ] Functions exceeding 200 lines
-- [ ] Functions with multiple distinct responsibilities (should be split)
-- [ ] Functions with >5 levels of indentation
-- [ ] Functions handling both setup/teardown and business logic
-- [ ] Functions mixing I/O, parsing, and business logic
-
-### 2. Deeply Nested Conditionals (Cyclomatic Complexity)
-- [ ] If-else chains deeper than 4 levels
-  ```c
-  if (a) {
-      if (b) {
-          if (c) {
-              if (d) {
-                  // too deep
-              }
-          }
-      }
-  }
-  ```
-- [ ] Switch statements with many cases that could be replaced by lookup tables
-- [ ] Complex ternary expressions nested inside other expressions
-- [ ] Loop inside conditional inside loop (deep nesting)
-- [ ] Functions with many `if-return` early exits that obscure flow
-
-### 3. Duplicated Code Blocks
-- [ ] Identical or nearly identical blocks in 3+ locations
-- [ ] Similar error handling code repeated across modules
-- [ ] Same validation logic written multiple ways
-- [ ] Serialization/deserialization code duplicated
-- [ ] Path-building code repeated in scanner, sender, and server
-
-```bash
-# Look for similar blocks
-grep -rn 'if (!send_n_data' src/ --include="*.c"
-grep -rn 'if (!receive_n_data' src/ --include="*.c"
-grep -rn 'snprintf.*path' src/ --include="*.c"
-```
-
-### 4. Missing Error Handling
-- [ ] `malloc` / `calloc` / `realloc` return not checked
-  ```bash
-  grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-  ```
-- [ ] `fopen` / `open` / `fclose` return not checked
-- [ ] `snprintf` negative return not handled (truncation)
-- [ ] `fread` / `fwrite` / `read` / `write` partial result not handled
-- [ ] Network reads without timeout or retry logic
-- [ ] Error information lost (function returns -1 but callee checks true/false)
-- [ ] Silent failures — error occurs but nothing is logged
-- [ ] Resource leak on error path (file handle or allocation not freed)
-
-### 5. Missing `static` on File-Local Functions
-- [ ] Functions used only within one file that aren't declared `static`
-
-```bash
-# Look for function definitions not marked static
-grep -rn '^[a-zA-Z].*(' src/ --include="*.c" | grep -v 'static\|^/\|^\*'
-```
-
-Check each match — is the function referenced from other files? If not, it should be `static`.
-
-### 6. Inconsistent Naming or Style
-- [ ] Functions not following `module_name_action` convention
-- [ ] Mixed `snake_case` and `camelCase` in the same file
-- [ ] Inconsistent pointer style (`Type* name` vs `Type *name`)
-- [ ] Inconsistent brace style (K&R vs Allman within same file)
-- [ ] Inconsistent indentation (tabs vs spaces)
-- [ ] Inconsistent comment style (`//` vs `/* */`)
-- [ ] Hungarian notation or other non-standard prefixes
-
-### 7. Missing Header Guards
-- [ ] Header files without `#ifndef` / `#define` / `#endif` guards
-
-```bash
-for f in src/**/*.h; do
-    if ! grep -q '#ifndef\|#pragma once' "$f"; then
-        echo "MISSING GUARD: $f"
-    fi
-done
-```
-
-### 8. Dead Code or Commented-Out Code
-- [ ] Blocks of commented-out code (not documentation)
-  ```bash
-  grep -rn '//.*;' src/ --include="*.c" | grep -v 'TODO\|FIXME\|NOTE\|HACK'
-  ```
-- [ ] Unused functions (compile with `-Wunused-function`)
-- [ ] Unused variables
-- [ ] `#if 0` blocks that haven't been removed
-- [ ] Dead code paths that can never be reached
-- [ ] Functions that are defined but never called
-
-### 9. Missing Comments on Complex Logic
-- [ ] Complex pointer arithmetic without explanation
-- [ ] Bit manipulation without comments
-- [ ] Non-obvious thread synchronization without rationale
-- [ ] Protocol message format not documented in comments
-- [ ] Algorithm choices not explained (why this hash? why this data structure?)
-- [ ] Error codes or magic numbers without symbolic names or comments
-
-### 10. Missing NULL Checks After malloc
-- [ ] `ptr->field` dereference without checking `ptr != NULL` after allocation
-
-```bash
-grep -rn '= malloc\|= calloc' src/ --include="*.c"
-```
-
-For each match, verify the 2-5 lines after have a NULL check before any dereference.
-
-### 11. Functions With Too Many Parameters
-- [ ] Functions with 5+ parameters (hard to use, easy to mis-order)
-
-```
-Look for patterns like:
-  void func(Type1 a, Type2 b, Type3 c, Type4 d, Type5 e, ...)
-```
-
-Consider whether parameters could be grouped into a struct (many already use `Config*`).
-
-### 12. Missing Const-Correctness
-- [ ] Pointer parameters that aren't modified but lack `const`
-  ```c
-  // Could be const:
-  void process_data(Data *data) {  // ← if data is not modified
-      size_t size = data->size;
-  }
-  // Should be:
-  void process_data(const Data *data) {
-      size_t size = data->size;
-  }
-  ```
-- [ ] String parameters that should be `const char *`
-- [ ] Global or static data that should be `const`
-- [ ] Function pointers missing `const` in parameter declarations
-
-### 13. Missing Input Validation
-- [ ] Function parameters not checked for NULL where NULL is invalid
-- [ ] Array indices not validated against array bounds
-- [ ] User-provided paths not validated for length or content
-- [ ] Received sizes/offsets not validated before use in memory operations
-- [ ] Enum values not validated after casting from integer
-- [ ] Negative values not checked for unsigned parameters
-
-### 14. Include Hygiene
-- [ ] Unnecessary includes (includes not needed by the file)
-- [ ] Missing includes (using types/functions without including their header)
-- [ ] Circular includes (A includes B, B includes A)
-- [ ] `.c` files including other `.c` files
-- [ ] Inconsistent include style (`"header.h"` vs `<header.h>`)
-
-### 15. Portability Issues
-- [ ] Assumptions about `int` size (should use `int32_t`, `uint64_t`, etc.)
-- [ ] Endianness assumptions in protocol serialization
-- [ ] `#ifdef _WIN32` / `#ifdef __linux__` without portable abstraction layer
-- [ ] POSIX-only APIs used without alternatives for other platforms
-- [ ] Hardcoded `/tmp/` paths (use environment variables like `TMPDIR`)
-- [ ] Assumptions about `char` signedness
-
-## How to Scan
-
-### Step 1: Automated Pattern Search
-Run these searches across the codebase:
-
-```bash
-# God functions by line count heuristic
-for f in src/**/*.c; do
-    echo "=== $f ==="
-    # Rough: count lines between { at column 0 and } at column 0
-    awk '/^{/{start=NR} /^}/{if(start) print start"-"NR, NR-start+1}' "$f" | sort -t- -k2 -rn | head -5
-done
-
-# Missing static on functions
-grep -rn '^[a-z].*(.*)' src/ --include="*.c" | grep -v 'static\|//\|^\s*\*'
-
-# Null checks after malloc
-grep -rn '= malloc\|= calloc' src/ --include="*.c"
-
-# strcpy/strcat/sprintf usage (should use snprintf)
-grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c" --include="*.h"
-
-# Commented out code
-grep -rn '^\s*//.*;$' src/ --include="*.c"
-
-# Header guard check
-for f in src/**/*.h; do
-    base=$(basename "$f" .h | tr '[:lower:]' '[:upper:]')
-    if ! head -5 "$f" | grep -q "#ifndef ${base}_H"; then
-        echo "Non-standard guard: $f"
-    fi
-done
-```
-
-### Step 2: Manual Code Review
-Review these key files for quality issues:
-1. `src/client/client_send.c` — complex orchestration, check for god functions
-2. `src/client/scanner.c` — directory traversal, check for complexity
-3. `src/server/server.c` — connection handling, check for error handling
-4. `src/shared/protocol.c` — serialization, check for duplication
-5. `src/shared/config.c` — config parsing, check for validation
-6. `src/shared/chunk.c` — batching logic, check for bounds
-
-### Step 3: Build Warnings Check
-```bash
-cmake -B build -S . -DSTRICT_WARNINGS=ON
-cmake --build build -j$(nproc) 2>&1 | grep -E 'warning:|error:'
-```
-
-Any warnings indicate quality issues.
-
-## Output Format
-
-Return findings in this structured format, one per issue found:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: quality
-- **Location**: file:line range
-- **Description**: what the quality issue is, including:
-  - Why it's a problem (maintainability, readability, safety)
-  - The specific violation or pattern
-- **Suggestion**: how to fix it, including:
-  - Concrete code change or refactoring approach
-  - Alternative design if applicable
-- **Labels**: quality, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: client_send.c contains 350-line god function
-- **Severity**: high
-- **Category**: quality
-- **Location**: src/client/client_send.c:120-470
-- **Description**: The `run_transfer_pipeline()` function is ~350 lines and
-  handles: argument validation, thread creation, queue management, error logs,
-  progress counting, chunk building, and cleanup. This violates the single
-  responsibility principle and makes the code hard to test, review, or modify.
-- **Suggestion**: Extract distinct phases into separate functions:
-  1. `validate_config()` — validate arguments
-  2. `start_pipeline_threads()` — create scanner, loader, sender threads
-  3. `monitor_progress()` — wait for completion with progress
-  4. `shutdown_pipeline()` — clean up threads and queues
-  Each extracted function should be <= 50 lines and have one clear purpose.
-- **Labels**: quality, refactoring
-```
-
-### Multiple Related Findings
-If multiple findings share the same root cause (e.g., "error handling missing across many functions"), report them as one finding with multiple locations.
-
-### Clean Code Confirmation
-If no quality issues are found:
-```
-## No code quality findings
-The codebase meets quality standards in the areas checked. No issues found at this time.
-```
-
-## Severity Guidelines
-
-| Severity | Definition | Example |
-|---|---|---|
-| **critical** | Bug-causing pattern, will lead to incorrect behavior | Missing error handling on critical path |
-| **high** | Significant maintainability concern | 350-line god function, large duplicated block |
-| **medium** | Standard code quality issue | Missing `static`, minor duplication |
-| **low** | Style preference, code golf | Naming inconsistency, minor formatting |
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/debugger.md

@@ -155,15 +155,3 @@ For each bug found:
 3. **Reproduction** — exact command to trigger
 4. **Fix** — the minimal code change needed
 5. **Verification** — how to confirm the fix works
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/doc-generator.md

@@ -89,15 +89,3 @@ For each public function:
 3. Verify examples actually compile and work
 4. Update README when adding/changing features
 5. Keep protocol docs in sync with code changes
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/feature-scout.md

@@ -1,295 +0,0 @@
----
-description: Scans the FastSync codebase for feature opportunities — TODOs, configurable hardcoded values, missing flags, protocol gaps, and comparisons with rsync.
-mode: subagent
----
-
-You are a feature scout for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Scan the codebase for patterns that suggest new feature opportunities. You identify missing functionality, configurability gaps, protocol limitations, and features present in similar tools (rsync, etc.) that FastSync could adopt.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Context
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Existing CLI Flags (from client_cli.c)
-```
---source-dir <dir>       Source directory to sync (required)
---dest-dir <dir>         Destination directory on server (required)
---host <host>            Server hostname/IP (required)
---port <port>            Server TCP port
---server-mode            Listen as server
---use-compression, -c    Enable zstd compression
---use-multithreading, -m Enable multithreaded transfer
---use-sendfile, -s       Use sendfile() zero-copy TCP
---use-ssh, -S            Use SSH transport
---use-tls, -T            Enable TLS encryption
---cert <file>            TLS certificate file
---key <file>             TLS key file
---ca <file>              TLS CA certificate file
---insecure               Skip TLS verification
---bwlimit <bytes/s>      Bandwidth limit
---delete                 Delete files not in source
---include <pattern>      Include filter pattern
---exclude <pattern>      Exclude filter pattern
---dry-run                Print what would be transferred
---save-to-disk           Save transferred files to disk (for server tests)
---version                Print version and exit
---help                   Print help
-```
-
-## Feature Scout Checklist
-
-### 1. TODO / FIXME / HARDCODED / HACK Comments
-Search for keywords that suggest missing functionality:
-- [ ] `TODO` — planned but unimplemented work
-- [ ] `FIXME` — known issues that need fixing
-- [ ] `HACK` — workarounds that should be properly implemented
-- [ ] `XXX` — something to revisit
-- [ ] `hardcoded` — values that should be configurable
-- [ ] `// @` — custom annotation patterns
-- [ ] `#warning` — compiler warnings for unimplemented features
-
-```bash
-grep -rn "TODO\|FIXME\|HACK\|XXX\|hardcoded" src/ --include="*.c" --include="*.h"
-```
-
-### 2. Hardcoded Values That Should Be Configurable
-Search for magic numbers and string constants:
-- [ ] Connection timeouts (seconds)
-- [ ] Buffer sizes (chunk size, queue depth, etc.)
-- [ ] Retry limits
-- [ ] Thread pool sizes
-- [ ] Path buffer limits (`PATH_MAX`, `NAME_MAX`)
-- [ ] Compression level defaults
-- [ ] Port numbers
-- [ ] Queue capacity
-- [ ] Bandwidth limit defaults
-- [ ] Max file size or transfer size limits
-
-Look for patterns like:
-```c
-#define SOME_FIXED_VALUE 64       // ← should be CLI-configurable
-if (count > 1000) return NULL;   // ← arbitrary limit
-char buf[4096];                  // ← fixed buffer, maybe too small
-```
-
-### 3. Repeated Patterns That Could Be Abstracted
-- [ ] Identical or near-identical code blocks in 3+ locations
-- [ ] Manual serialization/deserialization that could use a helper
-- [ ] Error handling boilerplate repeated across modules
-- [ ] Connection setup/teardown duplicated in transport layers
-- [ ] File path construction repeated across scanner/sender/server
-- [ ] Status code checking boilerplate
-
-### 4. Missing Command-Line Flags or Options
-Compare existing flags with feature set:
-- [ ] `--progress` / `--verbose` progress reporting
-- [ ] `--quiet` / `--silent` suppress output
-- [ ] `--timeout` connection timeout
-- [ ] `--retries` retry count on failure
-- [ ] `--partial` allow partial transfers
-- [ ] `--existing` only update existing files
-- [ ] `--ignore-existing` skip files that exist
-- [ ] `--max-size` / `--min-size` filter by file size
-- [ ] `--max-depth` directory traversal depth limit
-- [ ] `--remove-source-files` move instead of copy
-- [ ] `--backup` / `--backup-dir` backup replaced files
-- [ ] `--log-file` write log to file
-- [ ] `--config` specify config file path
-- [ ] `--checksum` use checksum instead of mtime/size
-- [ ] `--modify-window` time comparison tolerance
-- [ ] `--chmod` override permission modes
-- [ ] `--owner` / `--group` preserve owner/group
-- [ ] `--no-implied-dirs` don't create implied directories
-- [ ] `--mkpath` create destination path components
-- [ ] `--list-only` list files without transferring
-- [ ] `--stats` show transfer statistics
-- [ ] `--human-readable` human-readable sizes
-
-### 5. Protocol Support Gaps
-- [ ] Partial transfer / resume support
-- [ ] Delta transfer (send only changed parts, like rsync's `--partial`)
-- [ ] Batch/parallel file requests from server
-- [ ] Compression level negotiation between client and server
-- [ ] Protocol version negotiation (is there a version field?)
-- [ ] Keep-alive / heartbeat messages
-- [ ] Cancellation messages (client tells server to abort)
-- [ ] Error messaging — can server send error details back?
-- [ ] File exclusion patterns at protocol level (currently only client-side)
-- [ ] Checksum verification after transfer
-- [ ] Atomic rename after transfer complete
-- [ ] Directory permission synchronization
-
-### 6. Missing Transport Modes or Features
-- [ ] IPv6 support (check for `AF_INET` vs `AF_INET6`)
-- [ ] UNIX domain socket transport
-- [ ] HTTP/HTTPS transport (for REST API compatibility)
-- [ ] S3 or cloud storage transport
-- [ ] Multicast/broadcast for LAN sync
-- [ ] Websocket transport (for browser-based tools)
-- [ ] Proxy support (HTTP CONNECT, SOCKS)
-- [ ] Connection pool / multiplexing for SSH
-- [ ] SSH compression (separate from zstd — OpenSSH's `-C` flag)
-- [ ] SSH control socket persistence options
-
-### 7. Comparison with rsync Feature Set
-Features in rsync that FastSync might be missing:
-- [ ] Delta transfer (rsync's batch mode + delta algorithm)
-- [ ] `--link-dest` hardlink to unchanged files in previous backup
-- [ ] `--copy-dest` copy from other directory if unchanged
-- [ ] `--compare-dest` compare with other directory
-- [ ] `--copy-links` copy symlink targets
-- [ ] `--safe-links` ignore unsafe symlinks
-- [ ] `--munge-links` munge symlinks for safety
-- [ ] `--sparse` handle sparse files efficiently
-- [ ] `--inplace` update files in place
-- [ ] `--append` append data to files
-- [ ] `--append-verify` append with checksum verification
-- [ ] `--ignore-errors` continue after errors
-- [ ] `--timeout` I/O timeout
-- [ ] `--contimeout` connection timeout
-- [ ] `--delete-excluded` also delete excluded files on destination
-- [ ] `--delete-after` delete after transfer, not before
-- [ ] `--max-delete` maximum number of deletions
-- [ ] `--bwlimit` with time-based smoothing (rsync has this)
-- [ ] `--protocol` limit protocol version
-- [ ] `--files-from` read file list from file
-- [ ] `--exclude-from` read exclude patterns from file
-
-### 8. Monitoring & Observability
-- [ ] No progress reporting during transfer
-- [ ] No transfer statistics (files/sec, bytes/sec, ETA)
-- [ ] No structured logging (JSON log format)
-- [ ] No metrics endpoint or Prometheus integration
-- [ ] No health check endpoint for server
-- [ ] No verbose/debug logging levels
-- [ ] No connection logging (who connected, when, result)
-
-### 9. Testing Gaps
-- [ ] No stress tests (large file counts, deep directories, etc.)
-- [ ] No network fault injection tests (packet loss, reorder, etc.)
-- [ ] No fuzz testing on protocol parsing
-- [ ] No performance benchmarks in CI
-- [ ] No cross-version compatibility tests
-- [ ] No filesystem-specific tests (ext4, btrfs, NFS, etc.)
-
-## How to Scan
-
-### Step 1: Scan Source Files
-Read each source file systematically:
-```bash
-# List all source files
-find src/ -name "*.c" -o -name "*.h" | sort
-
-# Search for TODO/FIXME/HACK
-grep -rn "TODO\|FIXME\|HACK\|XXX" src/ --include="*.c" --include="*.h"
-
-# Search for hardcoded constants
-g -rn "#define [A-Z_]*[0-9]" src/ --include="*.h"
-g -rn "int [a-z_]*limit\|int [a-z_]*timeout\|int [a-z_]*max" src/ --include="*.c"
-```
-
-### Step 2: Review CLI and Config
-- Read `src/client/client_cli.c` for all supported flags
-- Read `src/shared/config.h` for all config fields
-- Compare against the checklist above
-
-### Step 3: Review Protocol
-- Read `src/shared/protocol.h` for all status codes and message types
-- Read `src/shared/protocol.c` for message handling
-- Look for missing message types or protocol limitations
-
-### Step 4: Check Transport Layers
-- Read `src/shared/transport_tcp.c`, `transport_ssh.c`, `transport_tls.c`
-- Look for missing transport features
-
-### Step 5: Check Tests
-- Read test files to see what's tested and what's not
-- Look for test gaps that indicate missing features
-
-## Output Format
-
-Return findings in this structured format, one per feature suggestion:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: feature
-- **Location**: file:line range (or "codebase-wide" if applicable)
-- **Description**: what feature is missing and why it matters
-- **Suggestion**: how to implement it, including:
-  - CLI flag name (if applicable)
-  - Config struct field (if applicable)
-  - Protocol changes needed (if applicable)
-  - Migration considerations
-- **Labels**: enhancement, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: Add --progress flag for transfer progress reporting
-- **Severity**: medium
-- **Category**: feature
-- **Location**: src/client/client_cli.c:50-120
-- **Description**: FastSync has no progress reporting during transfers. Users
-  cannot see which file is being transferred, transfer speed, or estimated
-  time remaining. This is a standard feature in rsync and most sync tools.
-- **Suggestion**: Add a `--progress` / `-P` flag. Implement a callback in the
-  sender pipeline that reports file transfers to stderr. Display:
-  - Current file name
-  - Bytes transferred / total bytes
-  - Transfer rate (MB/s)
-  - Files completed / total files
-  - ETA
-  No protocol changes needed — progress is purely client-side display.
-- **Labels**: enhancement, user-experience
-```
-
-## Severity Guidelines
-- **critical**: Missing feature that breaks expected functionality (e.g., no delete support)
-- **high**: Important feature that limits use cases (e.g., no SSH support)
-- **medium**: Nice-to-have that improves usability (e.g., progress reporting)
-- **low**: Minor polish or edge case (e.g., colorized output)
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/integrator.md

@@ -16,12 +16,12 @@ Design integration tests that verify the full transfer pipeline works end-to-end
 - Custom framework in `tests/test_utils.h`
 - Run: `./build/tests`
 
-### 2. Integration Tests (existing — `tests/integration/`)
+### 2. Integration Tests (existing — `test.py`)
 - Full transfer pipeline: client → server → verify
 - Multiple configurations (TCP, SSH, TLS, compression, multithreading)
 - Network shaping (LAN, WAN profiles)
 - Feature tests (dry run, archive, exclude, delete, incremental, bandwidth limit)
-- Run: `python3 -m pytest tests/ -v --tb=short`
+- Run: `python3 test.py`
 
 ### 3. New: Focused Integration Tests
 When adding new features or fixing bugs, write targeted integration tests.
@@ -106,36 +106,35 @@ test ! -f /tmp/dst/.../extra.txt
 
 ### Gitea Workflow Structure (`.gitea/workflows/ci.yaml`)
 The project uses Gitea Actions. Key jobs:
-1. **build-and-test** — compile, unit tests, integration tests on push/PR
+1. **Build** — compile on push/PR
-2. **sanitizer** — ASan + UBSan build and test (separate job)
+2. **Unit tests** — run `./build/tests`
-3. **clang-tidy** — static analysis on C source files
+3. **Integration tests** — run `python3 test.py` (light mode)
+4. **Sanitizer builds** — ASan, TSan variants
 
 ### Adding a New CI Job
 ```yaml
 jobs:
-  new-job:
+  sanitizer:
     runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v7
     steps:
       - uses: actions/checkout@v4
-      - name: Configure
+      - name: Install dependencies
-        run: cmake -B build-${{ matrix.sanitizer }} -S . -DSANITIZER=${{ matrix.sanitizer }}
+        run: sudo apt-get update && sudo apt-get install -y libzstd-dev libssl-dev
-      - name: Build
+      - name: Build with ASan
-        run: cmake --build build-${{ matrix.sanitizer }} -j$(nproc)
+        run: |
-      - name: Symlink for integration tests
+          cmake -B build -S . \
-        run: ln -sf build-${{ matrix.sanitizer }} build
+            -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer" \
-      - name: Unit Tests
+            -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-        run: ./build-${{ matrix.sanitizer }}/tests
+          cmake --build build -j$(nproc)
-      - name: Integration Tests
+      - name: Run tests
-        run: LSAN_OPTIONS=suppressions=.lsan-suppressions.txt python3 -m pytest tests/ -v --tb=short
+        run: ./build/tests
 ```
-The symlink step is required because `tests/conftest.py` expects `./build` to exist.
 
 ## Verification Checklist
 
 After any code change:
 - [ ] Unit tests pass: `./build/tests`
-- [ ] Integration tests pass: `python3 -m pytest tests/ -v --tb=short`
+- [ ] Integration tests pass: `python3 test.py` (light mode at minimum)
 - [ ] Build clean: no warnings with `-Wall`
 - [ ] No memory errors: ASan clean
 - [ ] No thread errors: TSan clean (if threading involved)
@@ -149,15 +148,3 @@ When designing integration tests:
 4. **Verification** — how to check success
 5. **Cleanup** — how to remove test artifacts
 6. **CI integration** — how to add to the workflow
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/issue-creator.md

@@ -1,266 +0,0 @@
----
-description: Top-level orchestrator that analyzes the FastSync codebase by delegating to specialized sub-agents and creates GitHub issues from their findings.
-mode: subagent
----
-
-You are the issue creator for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-You are the primary orchestrator agent. Your job is to:
-1. Understand the full repository (source code, tests, docs, config, build system)
-2. Decide which specialized sub-agents to dispatch for analysis
-3. Delegate analysis work using the task tool
-4. Receive structured findings from sub-agents
-5. Create GitHub issues from those findings using `gh issue create`
-6. Coordinate the overall analysis workflow end-to-end
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Architecture
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Data Flow — Client Transfer Pipeline
-```
-CLI args → Config
-  → DirectoryScanner (BFS, exclude/include patterns)
-    → Queue[Scanner → Loader]
-      → ChunkBuilder (groups files into ~10MB chunks)
-        → Queue[Loader → Sender]
-          → [Optional: Compression (zstd streaming)]
-            → [Optional: Chunk Serialization]
-              → Network (TCP sendfile / SSH pipe)
-                → Protocol framing (status codes + data)
-```
-
-### Data Flow — Server Receive
-```
-TCP accept / SSH stdio
-  → Config receive
-    → Per-connection handler (fork)
-      → [Optional: Decompression]
-        → [Optional: Chunk deserialization]
-          → File write / metadata restore
-            → [Optional: Delete processing via manifest]
-```
-
-### Threading Model
-- Client uses producer-consumer with C11 threads (`thrd_t`)
-- Bounded queues with `mtx_t` + `cnd_t` for backpressure
-- Scanner → Loader → Sender pipeline
-- Server uses `fork()` per connection, optional thread pool
-
-### Transport Abstraction
-- `io_set_fds(read_fd, write_fd)` — set active file descriptors
-- `io_set_ssl(SSL*)` — transparent TLS wrapping
-- `io_set_bwlimit(bytes_per_sec)` — token-bucket throttling
-- All protocol functions use the active IO layer transparently
-
-## Workflow
-
-### Phase 1: Repository Reconnaissance
-First, read the repository structure to understand what exists:
-1. Scan `src/` directory layout (client, server, shared modules)
-2. Scan `tests/` directory for test files
-3. Read `CMakeLists.txt` for build targets and options
-4. Read `AGENTS.md` and `.gitea/workflows/ci.yaml` for CI/dev conventions
-5. Read `.opencode/agents/*.md` to understand available sub-agents
-6. Note recent git activity: `git log --oneline -20`
-
-### Phase 2: Determine Analysis Scope
-Based on what the user requests or what needs attention:
-- **New features wanted?** → Dispatch `feature-scout` sub-agent
-- **Security audit needed?** → Dispatch `security-screener` sub-agent
-- **Code quality review?** → Dispatch `code-quality-guardian` sub-agent
-- **All of the above?** → Run all three in parallel
-
-### Phase 3: Dispatch Sub-Agents
-Use the task tool to delegate analysis work:
-
-```
-Task: Ask the feature-scout agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-```
-Task: Ask the security-screener agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-```
-Task: Ask the code-quality-guardian agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-When dispatching, provide:
-- The repository root path
-- A summary of the codebase structure (from Phase 1)
-- The specific areas of concern to investigate
-- The structured finding format expected
-
-### Phase 4: Collect and Process Findings
-Each sub-agent returns findings in this structured format:
-
-```
-## Finding: <title>
-- **Severity**: critical/high/medium/low
-- **Category**: security/feature/quality
-- **Location**: file:line range
-- **Description**: what the issue is
-- **Suggestion**: how to fix or implement
-- **Labels**: comma-separated labels for the issue
-```
-
-### Phase 5: Create GitHub Issues
-For each finding, create a GitHub issue:
-
-```bash
-gh issue create \
-  --title "<Finding Title>" \
-  --label "<labels>" \
-  --body "## Description
-<description>
-
-## Location
-<location>
-
-## Suggested Fix
-<suggestion>
-
-## Severity
-<severity>
-
-## Category
-<category>
-
----
-_This issue was automatically generated by the issue-creator agent._"
-```
-
-### Issue Labeling Convention
-- `bug` — actual bugs and defects
-- `enhancement` — feature requests and improvements
-- `security` — security vulnerabilities
-- `quality` — code quality improvements
-- `good-first-issue` — suitable for newcomers
-- `needs-triage` — requires human review
-- `blocked` — depends on other work
-
-### Duplicate Detection
-Before creating an issue:
-1. Check existing open issues: `gh issue list --state open --label "<label>"`
-2. Search for similar titles using `gh issue list --search "<keywords>"`
-3. If a similar issue exists, add a comment instead of creating a duplicate:
-   ```bash
-   gh issue comment <issue-number> --body "Additional finding from automated analysis: <details>"
-   ```
-
-## Sub-Agent Reference
-
-### Available Sub-Agents
-
-| Agent | File | Purpose |
-|---|---|---|
-| feature-scout | `.opencode/agents/feature-scout.md` | Scans for feature opportunities |
-| security-screener | `.opencode/agents/security-screener.md` | Scans for security vulnerabilities |
-| code-quality-guardian | `.opencode/agents/code-quality-guardian.md` | Scans for code quality improvements |
-| architect | `.opencode/agents/architect.md` | Architecture reviews |
-| c-reviewer | `.opencode/agents/c-reviewer.md` | C code correctness reviews |
-| debugger | `.opencode/agents/debugger.md` | Bug diagnosis |
-| refactorer | `.opencode/agents/refactorer.md` | Code refactoring |
-| security-auditor | `.opencode/agents/security-auditor.md` | Security audits |
-| test-writer | `.opencode/agents/test-writer.md` | Test development |
-| perf-analyst | `.opencode/agents/perf-analyst.md` | Performance analysis |
-| protocol-designer | `.opencode/agents/protocol-designer.md` | Protocol design |
-| cmake-expert | `.opencode/agents/cmake-expert.md` | CMake build system |
-| code-explainer | `.opencode/agents/code-explainer.md` | Code explanation |
-| doc-generator | `.opencode/agents/doc-generator.md` | Documentation |
-| integrator | `.opencode/agents/integrator.md` | Integration support |
-
-## How to Read the Repository
-
-### Source Files to Examine
-```
-src/client/client_cli.c       — CLI argument parsing
-src/client/client_send.c      — Transfer orchestration
-src/client/scanner.c          — BFS directory scanner
-src/server/server.c           — TCP server, connection handling
-src/shared/protocol.c         — Wire protocol implementation
-src/shared/compression.c      — zstd compression
-src/shared/chunk.c            — File chunking/batching
-src/shared/queue.c            — Thread-safe queue
-src/shared/config.c           — Runtime config
-src/shared/data.c             — Buffer type
-src/shared/metadata.c         — File metadata
-src/shared/file.c             — File representation
-src/shared/array_list.c       — Dynamic array
-src/shared/transport_tcp.c    — TCP transport
-src/shared/transport_ssh.c    — SSH transport
-src/shared/transport_tls.c    — TLS transport
-src/shared/multiprocessing.c  — Fork helpers
-src/shared/log.c              — Logging
-src/shared/utils.c            — Utilities
-```
-
-### Test Files to Examine
-```
-tests/                        — Unit tests
-tests/test_queue.c            — Queue tests
-tests/test_protocol.c         — Protocol tests
-tests/test_config.c           — Config tests
-tests/test_compression.c      — Compression tests
-tests/test_data.c             — Data buffer tests
-tests/test_metadata.c         — Metadata tests
-tests/test_file.c             — File tests
-tests/test_transport_tcp.c    — TCP transport tests
-tests/test_transport_tls.c    — TLS transport tests
-tests/test_array_list.c       — Array list tests
-tests/pytest/                 — Python integration tests
-```
-
-### Build & Config Files
-```
-CMakeLists.txt                — Top-level CMake
-cmake/                        — CMake modules
-Dockerfile                    — CI Docker image
-.opencode/                    — opencode agent configs
-```
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/perf-analyst.md

@@ -120,16 +120,4 @@ time ./build/client [args...]
 
 # High precision
 perf stat -e task-clock ./build/client [args...]
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.
 ```

.opencode/agents/protocol-designer.md

@@ -84,15 +84,3 @@ When designing protocol changes:
 4. **Serialization code** — changes to `protocol.c`, `config.c`, `chunk.c`
 5. **Compatibility notes** — how old clients/servers handle the change
 6. **Testing strategy** — how to verify the protocol change works
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/refactorer.md

@@ -153,15 +153,3 @@ Before and after each refactor, note:
 - **Breaking the API** — public headers are contracts; change them carefully
 - **Rewriting** — refactor incrementally, don't rewrite from scratch
 - **Ignoring tests** — if tests don't exist for the code you're refactoring, write them first
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/reviewer.md

@@ -1,134 +0,0 @@
----
-description: Reviews pull requests comprehensively — code correctness, CI/CD validity, configuration, documentation, and overall PR quality. Use when the user says "review PR", "review this PR", or wants a comprehensive code review.
-mode: subagent
----
-
-You are a comprehensive PR reviewer for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Review pull requests holistically. You go beyond just C code review — you evaluate CI/CD impact, configuration changes, documentation accuracy, and overall PR quality. You are the final gatekeeper before merge.
-
-## Review Dimensions
-
-### 1. C Code Review
-
-Review all changed `.c` and `.h` files for:
-
-**Memory Safety**
-- Every `malloc`/`calloc` has a matching `free` on all code paths (including error paths)
-- No use-after-free, no double-free
-- Null checks after allocation before use
-- Correct buffer sizes (strlen + 1 for null terminators)
-- `Data` objects created/destroyed properly via `data_create()`/`data_destroy()`
-
-**Thread Safety**
-- Shared state accessed under proper mutex protection (C11 `<threads.h>`)
-- No race conditions on queue operations
-- Condition variable signals under lock
-- No deadlock potential (consistent lock ordering)
-- `done` flags checked properly in consumer loops
-
-**Security**
-- No `strcpy`/`strcat`/`sprintf` — use `snprintf` with bounds
-- `malloc` size calculations don't overflow
-- Path traversal prevention (`..` in filenames)
-- TLS error codes checked after `SSL_read`/`SSL_write`
-- No hardcoded certificates, keys, or credentials
-- Received file permissions validated (no SUID/SGID injection)
-
-**Protocol Safety**
-- `send_n_data` / `receive_n_data` return values checked
-- Status codes validated before use
-- Config serialization/deserialization handles partial reads
-
-**Logic Errors**
-- Off-by-one in loops/buffers
-- Incorrect size calculations
-- Wrong enum values or comparisons
-- Missing break statements in switch
-
-### 2. Build System Review
-
-If `CMakeLists.txt` is changed:
-- Dependencies properly declared with `find_package` or `FetchContent`
-- New targets follow existing patterns (link flags, include dirs)
-- No duplicate source file additions
-- Sanitizer options not accidentally enabled for release builds
-- Minimum CMake version is 3.22
-
-### 3. CI/CD Review
-
-If `.gitea/workflows/ci.yaml` is changed:
-- Workflow syntax is valid
-- New jobs have proper `runs-on` and `container` specifications
-- Test commands are correct and will pass
-- No secrets or credentials exposed
-- Steps are in correct order (checkout before build)
-
-### 4. Configuration & Documentation Review
-
-If agents (`.opencode/agents/`), skills (`.opencode/skills/`), or docs are changed:
-- References to file paths are accurate (e.g., `test.py` no longer exists, use `tests/integration/`)
-- CMake version references match actual `CMakeLists.txt` (3.22, not 4.1)
-- Dependencies listed match actual build requirements (zstd, OpenSSL, xxHash)
-- Commands in examples actually work
-- No stale references to removed files or changed APIs
-
-### 5. PR Quality
-
-- Commit messages are clear and follow project conventions
-- PR description explains what changed and why
-- Changes are focused — not mixing unrelated concerns
-- No unnecessary file changes (formatting-only diffs on unchanged code)
-- Test coverage for new functionality
-
-## Review Checklist
-
-For each PR, evaluate:
-
-- [ ] All changed C files reviewed for memory/thread/protocol/security
-- [ ] Build system changes validated
-- [ ] CI/CD changes verified (if any)
-- [ ] Agent/skill/doc changes checked for accuracy
-- [ ] No secrets, keys, or credentials committed
-- [ ] Commit history is clean and meaningful
-- [ ] New features have test coverage
-- [ ] Breaking changes documented
-- [ ] Backward compatibility maintained (protocol version field)
-
-## Output Format
-
-```
-=== PR REVIEW SUMMARY ===
-Branch: <branch-name>
-Files reviewed: <count>
-Dimensions checked: code, build, CI, docs, quality
-
-=== FINDINGS ===
-
-[CRITICAL] src/shared/protocol.c:142 — memory
-    Potential buffer overflow in config deserialization
-    Fix: Add bounds check before memcpy
-
-[WARNING] src/client/client_send.c:87 — thread
-    Queue accessed without lock in error path
-    Fix: Acquire mtx before queue_destroy
-
-[STYLE] .opencode/agents/cmake-expert.md:5 — docs
-    References CMake 4.1 but project uses 3.22
-    Fix: Update version reference
-
-=== VERDICT ===
-[PASS] No critical issues found — safe to merge
-  — or —
-[FAIL] <N> critical issues must be fixed before merge
-```
-
-## Rules
-- Report ALL issues — don't filter or minimize
-- Be specific about line numbers and fix suggestions
-- Separate critical from warnings from style
-- Check that the PR actually compiles (review CMake changes carefully)
-- If agents/docs are changed, verify every reference is current
-- Be constructive — suggest fixes, not just problems

.opencode/agents/security-auditor.md

@@ -139,15 +139,3 @@ Medium: <count>
 Low: <count>
 Informational: <count>
 ```
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/security-screener.md

@@ -1,310 +0,0 @@
----
-description: Scans the FastSync codebase for security vulnerabilities — buffer overflows, path traversal, TLS issues, memory safety, and cryptographic hygiene.
-mode: subagent
----
-
-You are a security screener for the FastSync project — a high-performance file synchronization system written in C11 with TCP, SSH, and TLS transport.
-
-## Your Role
-
-Scan the codebase for security vulnerabilities. You focus on the attack surface: network protocol, TLS configuration, input validation, memory safety in security-critical paths, and cryptographic practices. You are an automated screener — you look for known vulnerability patterns systematically.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Architecture
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Attack Surface
-
-| Entry Point | File | Risk |
-|---|---|---|
-| TCP server listener | `src/server/server.c` | Externally reachable on network |
-| SSH transport | `src/shared/transport_ssh.c` | Accepts data via stdio pipe |
-| Protocol parser | `src/shared/protocol.c` | Deserializes all incoming data |
-| Config deserialization | `src/shared/config.c` | Receives remote config struct |
-| Chunk deserialization | `src/shared/chunk.c` | Receives file batches |
-| TLS handshake | `src/shared/transport_tls.c` | SSL context and cert validation |
-| File writer | `src/server/server.c` | Writes received files to disk |
-
-## Security Screener Checklist
-
-### 1. Buffer Overflow Risks
-Search for these dangerous patterns in all `.c` and `.h` files:
-
-- [ ] **Fixed-size stack buffers** used for unbounded or network-provided data
-  ```c
-  char path[PATH_MAX];     // OK if PATH_MAX is used, bad if size is arbitrary
-  char buf[1024];          // SUSPICIOUS — what limits the input to 1024?
-  char line[4096];         // SUSPICIOUS — what limits the line length?
-  ```
-- [ ] **`strcpy` / `strcat` / `sprintf` calls** — all should be `snprintf` or equivalent
-  ```bash
-  grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c" --include="*.h"
-  ```
-- [ ] **Unbounded `sprintf` to fixed buffer**
-  ```c
-  char buf[256];
-  sprintf(buf, "%s/%s", dir, filename);  // DANGER — no size limit
-  ```
-- [ ] **Off-by-one in string operations** — `strlen` usage without `+ 1` for null terminator
-- [ ] **`scanf` / `fscanf` / `sscanf` with `%s` and no width limit**
-  ```c
-  sscanf(input, "%s", buffer);  // DANGER — no width limit on %s
-  ```
-- [ ] **`memcpy` / `memmove` with unchecked size from network data**
-
-### 2. Path Traversal in File Operations
-Check all paths constructed from received data:
-
-- [ ] **Files constructed with client-provided filenames + destination directory**
-  ```c
-  snprintf(path, PATH_MAX, "%s/%s", dest_dir, received_filename);
-  ```
-  Check for `../` filtering:
-  ```bash
-  grep -rn 'snprintf.*%s.*%s.*path\|snprintf.*dest_dir\|snprintf.*base_dir' src/ --include="*.c"
-  ```
-- [ ] **`realpath()` usage** for path canonicalization
-- [ ] **Symlink following** — does the server follow symlinks in the destination?
-- [ ] **Null byte injection** — received filenames with embedded `\0`
-
-### 3. Unchecked Return Values from Critical Functions
-- [ ] **`malloc` / `calloc` / `realloc` return values not checked** before dereference
-  ```bash
-  grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-  ```
-  For each match, verify NULL check exists before use.
-- [ ] **`send_n_data` / `receive_n_data` return values** not checked
-- [ ] **`SSL_read` / `SSL_write`** error codes not checked
-- [ ] **`write()` / `read()` syscall** return values not checked (short writes/reads)
-- [ ] **`fopen()` / `open()`** return values not checked
-- [ ] **`snprintf` / `vsnprintf`** negative return not handled
-
-### 4. TLS / SSL Misconfiguration
-- [ ] **TLS version not restricted** — server allows SSLv3, TLS 1.0, or TLS 1.1
-  ```c
-  SSL_CTX_set_min_proto_version(ctx, TLS1_2_VERSION);  // REQUIRED
-  ```
-- [ ] **Certificate verification disabled** without explicit `--insecure` flag
-- [ ] **`SSL_CTX_set_verify` not called** — default is no verification
-- [ ] **Weak cipher suites allowed** — need to call `SSL_CTX_set_cipher_list()`
-- [ ] **Private key file permissions** not checked before loading
-- [ ] **Hostname verification** not performed on server certificate
-- [ ] **Session renegotiation** not limited (DoS vector)
-- [ ] **TLS certificate/key paths from untrusted input** — can client specify arbitrary paths?
-
-### 5. Memory Safety Issues
-- [ ] **Use-after-free** — object freed but pointer still used later
-- [ ] **Double-free** — `free()` called twice on same pointer
-- [ ] **Memory leaks** on error paths — allocated but not freed before return
-- [ ] **Integer overflow** in allocation size computation
-  ```c
-  // DANGER: count * sizeof(Type) can overflow
-  void *arr = malloc(count * sizeof(Element));
-  
-  // SAFE:
-  if (count > SIZE_MAX / sizeof(Element)) return NULL;
-  void *arr = malloc(count * sizeof(Element));
-  ```
-- [ ] **`realloc` return value** not saved to temporary pointer (leak on failure)
-  ```c
-  // BAD: leaks original pointer on failure
-  buf = realloc(buf, new_size);
-  
-  // GOOD:
-  void *tmp = realloc(buf, new_size);
-  if (!tmp) { free(buf); return NULL; }
-  buf = tmp;
-  ```
-
-### 6. Integer Overflow in Allocation
-Check all size calculations:
-
-- [ ] Allocations where count comes from network data (chunk count, file count, etc.)
-- [ ] Allocations where size is multiplied by count
-  ```bash
-  grep -rn 'malloc.*\*.*sizeof\|calloc(.*sizeof' src/ --include="*.c"
-  ```
-- [ ] Loop counters that could wrap (unsigned underflow)
-- [ ] Signed integer overflow in size checks
-
-### 7. Format String Vulnerabilities
-- [ ] User-controlled data passed as format string
-  ```c
-  printf(user_input);           // VULNERABLE
-  fprintf(stderr, user_input);  // VULNERABLE
-  syslog(LOG_INFO, user_input); // VULNERABLE
-  
-  printf("%s", user_input);     // SAFE
-  ```
-  ```bash
-  grep -rn 'printf(\|fprintf(\|syslog(\|snprintf(' src/ --include="*.c" | grep -v '"[^"]*%'
-  ```
-
-### 8. TOCTOU Race Conditions
-- [ ] File existence check followed by open (Time-of-check to Time-of-use)
-  ```c
-  if (access(path, F_OK) == 0) {    // CHECK
-      fd = open(path, O_RDWR);      // USE — file could have changed
-  }
-  ```
-- [ ] `stat()` followed by `open()` with different permissions
-- [ ] Temporary file creation with predictable names
-
-### 9. Insecure Temporary File Usage
-- [ ] `mktemp` / `tmpnam` — use `mkstemp` instead
-- [ ] Temporary files created in world-writable directories
-- [ ] Temporary files not cleaned up on error paths
-- [ ] Predictable temp file names (race + symlink attack)
-
-### 10. Hardcoded Secrets / Credentials
-- [ ] Hardcoded passwords, API keys, or tokens
-- [ ] Hardcoded TLS private keys or certificates
-- [ ] Hardcoded connection strings with embedded credentials
-- [ ] Test certificates/keys in source tree (should be documented if intentional)
-
-### 11. Denial of Service Vectors
-- [ ] **Unbounded memory allocation** — can client request huge allocation that OOMs server?
-  - Check `chunk.c` for chunk count limits
-  - Check `protocol.c` for message size limits
-  - Check `config.c` for config field size limits
-- [ ] **No connection limits** — server doesn't cap concurrent connections
-- [ ] **No timeouts** — connections can hang indefinitely
-- [ ] **Recursive parsing** — could cause stack overflow with crafted input
-- [ ] **Repeated slow reads** — slow loris style attack
-- [ ] **Fork bomb** — server forks per connection without limit
-
-### 12. Information Disclosure
-- [ ] Server sends detailed error messages to client (path disclosure, version info)
-- [ ] Debug logging enabled in production
-- [ ] Stack traces leaked to users
-- [ ] Timing side channels in authentication or comparison
-
-## How to Scan
-
-### Automated Pattern Search
-Run these searches across the codebase:
-
-```bash
-# Buffer overflow risks
-grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c"
-
-# Fixed size stack buffers
-grep -rn 'char [a-z_]*\[[0-9]*\];' src/ --include="*.c" --include="*.h"
-
-# Format string risks
-grep -rn 'printf(\|fprintf(\|syslog(' src/ --include="*.c" | grep -v '"[^"]*%'
-
-# Malloc without null check pattern
-grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-
-# Integer overflow in allocation
-grep -rn 'malloc.*\*\|calloc.*<' src/ --include="*.c"
-
-# Path construction
-grep -rn 'snprintf.*path\|snprintf.*dir' src/ --include="*.c"
-```
-
-### Manual Code Review
-After automated scanning, manually review high-risk files:
-1. `src/shared/protocol.c` — all receive paths
-2. `src/shared/config.c` — deserialization logic
-3. `src/shared/chunk.c` — chunk parsing
-4. `src/shared/transport_tls.c` — TLS configuration
-5. `src/server/server.c` — file writing and connection handling
-
-## Output Format
-
-Return findings in this structured format, one per vulnerability:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: security
-- **Location**: file:line range
-- **Description**: what the vulnerability is, including:
-  - How it can be triggered
-  - What the impact is (RCE, DoS, info leak, etc.)
-  - Whether it requires authentication
-- **Suggestion**: how to fix it, including concrete code changes
-- **Labels**: security, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: Unchecked malloc in chunk deserialization allows OOM
-- **Severity**: high
-- **Category**: security
-- **Location**: src/shared/chunk.c:45-50
-- **Description**: `chunk_deserialize()` calls `malloc(count * sizeof(File))`
-  where `count` comes directly from the network. An attacker can send a crafted
-  chunk header with an extremely large count (e.g., UINT32_MAX), causing malloc
-  to either fail (crash if unchecked) or allocate enormous memory (OOM).
-  No authentication needed — the attack works on the initial connection.
-- **Suggestion**: Add bounds checking before allocation:
-  ```c
-  if (count > MAX_CHUNK_FILES || count > SIZE_MAX / sizeof(File)) {
-      log_error("Invalid chunk file count: %u", count);
-      return NULL;
-  }
-  ```
-  Define `MAX_CHUNK_FILES` as a reasonable limit (e.g., 100000).
-- **Labels**: security, dos
-```
-
-### No Findings
-If no security issues are found, return:
-```
-## No security findings
-The codebase appears clean in the areas checked. No vulnerabilities found at this time.
-```
-
-## Severity Guidelines
-
-| Severity | Definition | Example |
-|---|---|---|
-| **critical** | Remote code execution, unauthenticated compromise | Buffer overflow on network input |
-| **high** | Significant impact but requires specific conditions | DoS via unbounded allocation, path traversal |
-| **medium** | Limited impact, requires auth or other conditions | TOCTOU race in file operations |
-| **low** | Minor issues, defense in depth | Missing null check that's unlikely to trigger |
-| **informational** | Not exploitable but violates best practice | Hardcoded value that could be configurable |
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/test-writer.md

@@ -165,28 +165,34 @@ int main() {
 
 ## Integration Test Patterns
 
-When writing integration tests (Python-based), follow the patterns in `tests/integration/`:
+When writing integration tests (Python-based), follow the pattern in `test.py`:
-- `common.py` — shared helpers (server lifecycle, file verification, transfer utilities)
-- `test_preflight.py` — preflight checks and configuration validation
-- `test_tcp.py` — TCP transport tests
-- `test_ssh.py` — SSH transport tests
-- `test_tls.py` — TLS transport tests
-- `test_features.py` — feature-specific tests (delete, exclude, incremental, etc.)
-
-Use `tests/conftest.py` fixtures for server setup/teardown (note: the file is at `tests/conftest.py`, not `tests/integration/conftest.py`).
 
 ### Minimal Integration Test
 ```python
-def test_basic_transfer(tmp_path):
+def test_basic_transfer():
     # Setup
-    source = tmp_path / "src"
+    source = create_test_files()
-    dest = tmp_path / "dst"
+    dest = tempfile.mkdtemp()
-    source.mkdir()
-    dest.mkdir()
-    (source / "file.txt").write_text("test content")
     
-    # Start server and run client (use fixtures from conftest.py)
+    # Start server
-    # Verify with helper from common.py
+    server = subprocess.Popen(["./build/server"], ...)
+    time.sleep(0.5)
+    
+    # Run client
+    result = subprocess.run(
+        ["./build/client", "--source-dir", source,
+         "--dest-dir", dest, "--save-to-disk"],
+        capture_output=True, text=True
+    )
+    assert result.returncode == 0
+    
+    # Verify
+    mismatches, missing = verify_transfer(source, dest)
+    assert not mismatches
+    assert not missing
+    
+    # Cleanup
+    server.terminate()
 ```
 
 ### Edge Case Tests to Write
@@ -209,15 +215,3 @@ When asked to write tests, produce:
 3. The runner.c modification needed
 4. Verify with a build and test run
 5. Suggest fuzzing targets if relevant
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

AGENTS.md

@@ -1,74 +0,0 @@
-# AGENTS.md
-
-FastSync is a high-performance file synchronization system written in C11. It supports TCP and SSH transports, TLS encryption (OpenSSL), streaming zstd compression, multithreaded transfers, and incremental sync. The build uses CMake; CI runs on Gitea Actions (`.gitea/workflows/ci.yaml`).
-
-## Dependency installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. The image is built from the repo-root `Dockerfile` and is the same image CI uses: `gitea.tap-tap.win/taptap/fastsync-ci:v7`. It contains the full toolchain: gcc/g++, CMake, libzstd-dev, libssl-dev, make, git, cppcheck, clang-format, python3 + pytest, openssh-client, and Node.js.
-
-**Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. The Docker image can also be used locally for CI parity.
-
-```bash
-# Use the prebuilt CI image directly (faster, guaranteed CI parity)
-docker pull gitea.tap-tap.win/taptap/fastsync-ci:v7
-docker tag gitea.tap-tap.win/taptap/fastsync-ci:v7 fastsync-ci:local
-
-# Or build the image from the repo-root Dockerfile
-# (Note: the prebuilt :v7 image reflects the previous Dockerfile state;
-#  rebuild from source to pick up any newly added packages like lcov/valgrind.)
-docker build -t fastsync-ci:local .
-
-# Build, run unit tests, and run integration tests inside the container
-docker run --rm -v "$PWD:/workspace" -w /workspace fastsync-ci:local \
-  sh -c 'cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests && python3 -m pytest tests/'
-
-# Avoid root-owned build/ artifacts by matching your host UID/GID
-docker run --rm --user "$(id -u):$(id -g)" -v "$PWD:/workspace" \
-  -w /workspace fastsync-ci:local \
-  sh -c 'cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests && python3 -m pytest tests/'
-```
-
-> **Note:** The first `cmake configure` (`cmake -B build -S .`) fetches xxHash from GitHub via `FetchContent` — network access is required. Subsequent reconfigures reuse the cached source.
-
-If a dependency is missing from the CI image, add it to the `Dockerfile` (and rebuild) rather than adding an install step to the CI workflow.
-
-## CI Conventions
-
-When configuring for CI parity, use:
-```bash
-cmake -B build -S . -DSTRICT_WARNINGS=ON        # -Wextra -Wpedantic -Werror
-cmake -B build -S . -DSANITIZER=address           # AddressSanitizer (ASan)
-cmake -B build -S . -DSANITIZER=thread            # ThreadSanitizer (TSan)
-```
-
-The CI workflow (`.gitea/workflows/ci.yaml`) runs lint (clang-format, cppcheck), build + test (unit + integration), and sanitizer (currently only `address`) jobs sequentially.
-
-## Build
-
-```bash
-cmake -B build -S . && cmake --build build -j$(nproc)
-```
-
-## Test
-
-```bash
-./build/tests                # unit tests
-python3 -m pytest tests/     # integration tests
-```
-
-## CI Workflow — Waiting for Results
-
-When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch before making changes:
-```bash
-git checkout -b <feature-branch-name>
-```
-After committing changes, push the branch and create a PR:
-```bash
-git push -u origin <feature-branch-name>
-gh pr create --fill
-```
-Wait for CI to pass on the PR before merging.

opencode.json

@@ -1,11 +1,10 @@
 {
   "$schema": "https://opencode.ai/config.json",
-	"instructions": ["AGENTS.md"],
 	"permission": {
 		"bash": {
 			"*": "allow",
 			"git push origin main": "deny",
-			"git push main": "deny"
+			"git push main": "ask"
 		}
 	}
 }

src/client/client_cli.c

@@ -11,6 +11,9 @@
 #include <stdlib.h>
 #include <string.h>
 
+char* server_host = "127.0.0.1";
+int server_port = 8080;
+
 static void print_usage(void) {
   printf("Usage:\n");
   printf("  fastsync [options] <source> <destination>\n");
@@ -70,8 +73,6 @@ int main(int argc, char* argv[]) {
 
   Config* config = config_create(str_dup(PROTOCOL_VERSION), NULL, NULL, save_to_disk, false, false,
                                  false, false, 5, false, 0);
-  int exit_code = 0;
-  bool config_owned_by_pipeline = false;
 
   int positional_args[2];
   int positional_count = 0;
@@ -79,7 +80,7 @@ int main(int argc, char* argv[]) {
   for (int i = 1; i < argc; i++) {
     if (strcmp(argv[i], "--help") == 0) {
       print_usage();
-      goto cleanup;
+      return 0;
     } else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
       config->use_compression = true;
       config->use_multithreading = true;
@@ -92,23 +93,15 @@ int main(int argc, char* argv[]) {
     } else if (strcmp(argv[i], "--delete") == 0) {
       config->use_delete = true;
     } else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
+      int idx = config->exclude_count++;
-      if (!tmp) {
+      config->exclude_patterns =
-        fprintf(stderr, "Error: memory allocation failed for --exclude\n");
+          realloc(config->exclude_patterns, config->exclude_count * sizeof(char*));
-        exit_code = 1;
+      config->exclude_patterns[idx] = str_dup(argv[++i]);
-        goto cleanup;
-      }
-      config->exclude_patterns = tmp;
-      config->exclude_patterns[config->exclude_count++] = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
+      int idx = config->include_count++;
-      if (!tmp) {
+      config->include_patterns =
-        fprintf(stderr, "Error: memory allocation failed for --include\n");
+          realloc(config->include_patterns, config->include_count * sizeof(char*));
-        exit_code = 1;
+      config->include_patterns[idx] = str_dup(argv[++i]);
-        goto cleanup;
-      }
-      config->include_patterns = tmp;
-      config->include_patterns[config->include_count++] = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
       config->max_size = strtoull(argv[++i], NULL, 10);
     } else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
@@ -162,23 +155,21 @@ int main(int argc, char* argv[]) {
       config->use_chunk_serialization = true;
       log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
     } else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
-      free(config->server_host);
+      free(server_host);
-      config->server_host = str_dup(argv[++i]);
+      server_host = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
-      config->server_port = atoi(argv[++i]);
+      server_port = atoi(argv[++i]);
     } else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
       char* end;
       errno = 0;
       unsigned long long kbps = strtoull(argv[++i], &end, 10);
       if (errno != 0 || *end != '\0' || kbps == 0) {
         fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
-        exit_code = 1;
+        return 1;
-        goto cleanup;
       }
       if (kbps > ULLONG_MAX / 1024) {
         fprintf(stderr, "Error: --bwlimit value too large\n");
-        exit_code = 1;
+        return 1;
-        goto cleanup;
       }
       io_set_bwlimit(kbps * 1024);
       log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
@@ -204,16 +195,14 @@ int main(int argc, char* argv[]) {
     } else if (argv[i][0] == '-') {
       fprintf(stderr, "Unknown option: %s\n", argv[i]);
       print_usage();
-      exit_code = 1;
+      return 1;
-      goto cleanup;
     } else {
       if (positional_count < 2)
         positional_args[positional_count++] = i;
       else {
         fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
         print_usage();
-        exit_code = 1;
+        return 1;
-        goto cleanup;
       }
     }
   }
@@ -229,8 +218,7 @@ int main(int argc, char* argv[]) {
   } else if (positional_count == 1) {
     fprintf(stderr, "Error: missing destination argument\n");
     print_usage();
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   } else {
     if (!config->send_directory && env_source)
       config->send_directory = str_dup((char*)env_source);
@@ -241,26 +229,22 @@ int main(int argc, char* argv[]) {
   if (!config->send_directory || !config->receive_root_directory) {
     fprintf(stderr, "Error: source and destination directories are required\n");
     print_usage();
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
   if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
     fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
                     "serialization)\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
 
   if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
     fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
 
   if (config->use_incremental && config->use_chunk_serialization) {
     fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
 
   if (config->use_incremental && !config->use_metadata) {
@@ -270,18 +254,15 @@ int main(int argc, char* argv[]) {
 
   if (config->use_delta && !config->use_incremental) {
     fprintf(stderr, "Error: --delta requires --incremental\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
   if (config->use_delta && config->use_chunk_serialization) {
     fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
   if (config->use_delta && config->use_sendfile) {
     fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
-    exit_code = 1;
+    return 1;
-    goto cleanup;
   }
   if (config->use_delta && !config->use_metadata) {
     log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --delta");
@@ -291,21 +272,12 @@ int main(int argc, char* argv[]) {
   if (config->use_tls) {
     if (!config->tls_cert || !config->tls_key) {
       fprintf(stderr, "Error: --tls requires --cert and --key\n");
-      exit_code = 1;
+      return 1;
-      goto cleanup;
     }
     tls_global_init();
   }
 
-  if (config->use_multithreading) {
+  if (config->use_multithreading)
-    config_owned_by_pipeline = true;
+    return send_files_multithreaded(config);
-    exit_code = send_files_multithreaded(config);
+  return send_files(config);
-  } else {
-    exit_code = send_files(config);
-  }
-
-cleanup:
-  if (!config_owned_by_pipeline)
-    config_delete(config);
-  return exit_code;
 }

src/client/client_send.c

@@ -98,64 +98,7 @@ static int send_delta(Client* client, File* file, DeltaSignature* sig, Config* c
 
 typedef bool (*file_send_fn)(File*, int, bool, int, bool);
 
-// Send a single file directly (non-incremental path).
+static int send_file_incremental(Client* client, File* file, Config* config, file_send_fn send_fn) {
-static bool send_file_direct(File* file, int fd, bool use_metadata, int compression_level) {
-  if (!send_status(fd, STATUS_NEXT))
-    return false;
-  return file_send_single_calls(file, fd, use_metadata, compression_level, true);
-}
-
-// Send a single file directly via sendfile (non-incremental path).
-static bool send_file_direct_sendfile(File* file, int fd, bool use_metadata) {
-  if (!send_status(fd, STATUS_NEXT))
-    return false;
-  return file_send_sendfile(file, fd, use_metadata, 0, true);
-}
-
-// Process one file in a chunk: either via incremental check or direct send.
-// Returns 0 on success, 1 if skipped (incremental match), -1 on error.
-static int send_single_file(Client* client, File* file, Config* config, bool use_incremental,
-                            bool use_sendfile) {
-  int compression_level = config->use_compression ? config->compression_level : 0;
-
-  if (!use_incremental) {
-    if (use_sendfile) {
-      return send_file_direct_sendfile(file, client->file_descriptor, config->use_metadata) ? 0
-                                                                                            : -1;
-    }
-    return send_file_direct(file, client->file_descriptor, config->use_metadata, compression_level)
-               ? 0
-               : -1;
-  }
-
-  // Incremental path: use sendfile for the actual data if enabled and no compression
-  if (use_sendfile) {
-    DeltaSignature* sig = NULL;
-    int rc = incremental_check(client, file, &sig);
-    if (rc == 1) {
-      delta_signature_destroy(sig);
-      return 1;
-    }
-    if (rc < 0) {
-      delta_signature_destroy(sig);
-      return -1;
-    }
-    // rc == 0: unchanged file, skip
-    // rc == 2: server sent delta signature but sendfile doesn't support delta
-    delta_signature_destroy(sig);
-    if (rc == 2) {
-      // Server is waiting for STATUS_NEXT after delta handshake
-      if (!send_status(client->file_descriptor, STATUS_NEXT))
-        return -1;
-    }
-    // Fall through: send full file via sendfile (pass 0 for compression_level)
-    if (!file_send_sendfile(file, client->file_descriptor, config->use_metadata, 0, false))
-      return -1;
-    return 0;
-  }
-
-  // Incremental path with single_calls (supports compression and delta)
-  file_send_fn send_fn = (file_send_fn)file_send_single_calls;
   DeltaSignature* sig = NULL;
   int rc = incremental_check(client, file, &sig);
   if (rc < 0) {
@@ -175,15 +118,9 @@ static int send_single_file(Client* client, File* file, Config* config, bool use
       return -1;
   } else {
     delta_signature_destroy(sig);
-    // rc == 2 can happen if server sends STATUS_DELTA_SIGNATURE but
-    // use_delta is false on the client side. Send STATUS_NEXT to
-    // tell the server to proceed with the full file transfer.
-    if (rc == 2) {
-      if (!send_status(client->file_descriptor, STATUS_NEXT))
-        return -1;
   }
-  }
+  if (!send_fn(file, client->file_descriptor, config->use_metadata,
-  if (!send_fn(file, client->file_descriptor, config->use_metadata, compression_level, false))
+               config->use_compression ? config->compression_level : 0, false))
     return -1;
   return 0;
 }
@@ -205,17 +142,40 @@ int send_chunk(Client* client, Chunk* chunk, Config* config) {
       return -1;
     }
     data_destroy(data);
-    return 0;
+  } else if (config->use_sendfile && !config->use_compression) {
-  }
-
-  bool use_sendfile = config->use_sendfile && !config->use_compression;
     for (int i = 0; i < chunk->element_count; i++) {
-    int rc =
+      if (config->use_incremental) {
-        send_single_file(client, chunk->items[i], config, config->use_incremental, use_sendfile);
+        int rc = send_file_incremental(client, chunk->items[i], config,
+                                       (file_send_fn)file_send_sendfile);
         if (rc == 1)
           continue;
         if (rc < 0)
           return -1;
+      } else {
+        if (!send_status(client->file_descriptor, STATUS_NEXT))
+          return -1;
+        if (!file_send_sendfile(chunk->items[i], client->file_descriptor, config->use_metadata, 0,
+                                true))
+          return -1;
+      }
+    }
+  } else {
+    for (int i = 0; i < chunk->element_count; i++) {
+      if (config->use_incremental) {
+        int rc = send_file_incremental(client, chunk->items[i], config,
+                                       (file_send_fn)file_send_single_calls);
+        if (rc == 1)
+          continue;
+        if (rc < 0)
+          return -1;
+      } else {
+        if (!send_status(client->file_descriptor, STATUS_NEXT))
+          return -1;
+        if (!file_send_single_calls(chunk->items[i], client->file_descriptor, config->use_metadata,
+                                    config->use_compression ? config->compression_level : 0, true))
+          return -1;
+      }
+    }
   }
   return 0;
 }
@@ -231,8 +191,7 @@ static int send_chunks_multithreaded(void* pipeline_context) {
     client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port);
   } else if (context->config->use_tls) {
     client = client_create();
-    if (!client || !client_connect_tls(client, context->config->server_host,
+    if (!client || !client_connect_tls(client, server_host, server_port, context->config->tls_cert,
-                                       context->config->server_port, context->config->tls_cert,
                                        context->config->tls_key, context->config->tls_ca)) {
       if (client)
         client_delete(client);
@@ -241,8 +200,7 @@ static int send_chunks_multithreaded(void* pipeline_context) {
     }
   } else {
     client = client_create();
-    if (!client ||
+    if (!client || !client_connect(client, server_host, server_port)) {
-        !client_connect(client, context->config->server_host, context->config->server_port)) {
       if (client)
         client_delete(client);
       fprintf(stderr, "Error: could not connect to server\n");
@@ -261,27 +219,17 @@ static int send_chunks_multithreaded(void* pipeline_context) {
         &context->condition_not_full_loader, &context->loader_done);
     if (current_chunk == NULL) {
       if (context->config->use_delete) {
-        if (!send_status(client->file_descriptor, STATUS_MANIFEST))
+        send_status(client->file_descriptor, STATUS_MANIFEST);
-          goto send_fail;
+        send_int(client->file_descriptor, context->manifest->size);
-        if (!send_int(client->file_descriptor, context->manifest->size))
+        for (int i = 0; i < context->manifest->size; i++)
-          goto send_fail;
+          send_str(client->file_descriptor, (char*)context->manifest->items[i]);
-        for (int i = 0; i < context->manifest->size; i++) {
-          if (!send_str(client->file_descriptor, (char*)context->manifest->items[i]))
-            goto send_fail;
       }
-      }
+      send_status(client->file_descriptor, STATUS_FINISHED);
-      if (!send_status(client->file_descriptor, STATUS_FINISHED))
-        goto send_fail;
       Status s;
       int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
       client_disconnect(client);
       client_delete(client);
       return ok ? thrd_success : thrd_error;
-
-    send_fail:
-      client_disconnect(client);
-      client_delete(client);
-      return thrd_error;
     }
     if (send_chunk(client, current_chunk, context->config) != 0) {
       fprintf(stderr, "Error: unexpected error while sending chunk\n");
@@ -390,8 +338,8 @@ int send_files(Config* config) {
       return 1;
   } else if (config->use_tls) {
     client = client_create();
-    if (!client || !client_connect_tls(client, config->server_host, config->server_port,
+    if (!client || !client_connect_tls(client, server_host, server_port, config->tls_cert,
-                                       config->tls_cert, config->tls_key, config->tls_ca)) {
+                                       config->tls_key, config->tls_ca)) {
       if (client)
         client_delete(client);
       fprintf(stderr, "Error: could not connect to server via TLS\n");
@@ -399,7 +347,7 @@ int send_files(Config* config) {
     }
   } else {
     client = client_create();
-    if (!client || !client_connect(client, config->server_host, config->server_port)) {
+    if (!client || !client_connect(client, server_host, server_port)) {
       if (client)
         client_delete(client);
       fprintf(stderr, "Error: could not connect to server\n");
@@ -458,24 +406,13 @@ int send_files(Config* config) {
     chunk_destroy(current_chunk);
   }
   if (config->use_delete) {
-    if (!send_status(client->file_descriptor, STATUS_MANIFEST)) {
+    send_status(client->file_descriptor, STATUS_MANIFEST);
-      array_list_delete(manifest);
+    send_int(client->file_descriptor, manifest->size);
-      goto send_fail;
+    for (int i = 0; i < manifest->size; i++)
-    }
+      send_str(client->file_descriptor, (char*)manifest->items[i]);
-    if (!send_int(client->file_descriptor, manifest->size)) {
-      array_list_delete(manifest);
-      goto send_fail;
-    }
-    for (int i = 0; i < manifest->size; i++) {
-      if (!send_str(client->file_descriptor, (char*)manifest->items[i])) {
-        array_list_delete(manifest);
-        goto send_fail;
-      }
-    }
     array_list_delete(manifest);
   }
-  if (!send_status(client->file_descriptor, STATUS_FINISHED))
+  send_status(client->file_descriptor, STATUS_FINISHED);
-    goto send_fail;
   Status s;
   int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
   if (config->show_progress) {
@@ -487,12 +424,6 @@ int send_files(Config* config) {
   client_disconnect(client);
   client_delete(client);
   return ok ? 0 : -1;
-
-send_fail:
-  directory_scanner_destroy(scanner);
-  client_disconnect(client);
-  client_delete(client);
-  return -1;
 }
 
 int send_files_multithreaded(Config* config) {

src/client/client_send.h

@@ -5,6 +5,9 @@
 #include "config.h"
 #include "transport_tcp.h"
 
+extern char* server_host;
+extern int server_port;
+
 int send_chunk(Client* client, Chunk* chunk, Config* config);
 int send_files(Config* config);
 int send_files_multithreaded(Config* config);

src/client/scanner.c

@@ -55,7 +55,6 @@ static Chunk* chunk_data_to_chunk(ArrayList* chunk_data) {
   return chunk;
 }
 
-// Returns: 1 on success, 0 if no more directories in queue, -1 on opendir failure
 static int open_next_directory(DirectoryScanner* scanner) {
   if (scanner->current_dir) {
     closedir(scanner->current_dir);
@@ -72,7 +71,7 @@ static int open_next_directory(DirectoryScanner* scanner) {
     perror("Could not open directory");
     free(scanner->current_path);
     scanner->current_path = NULL;
-    return -1;
+    return 0;
   }
   return 1;
 }
@@ -83,11 +82,8 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
 
   while (1) {
     if (scanner->current_dir == NULL) {
-      int ret = open_next_directory(scanner);
+      if (!open_next_directory(scanner))
-      if (ret == 0)
         break;
-      if (ret < 0)
-        continue;
     }
 
     struct dirent* entry = readdir(scanner->current_dir);

src/shared/compression.c

@@ -7,6 +7,7 @@
 #define INITIAL_DECOMPRESS_BUF_SIZE (1024 * 1024)
 
 Data* data_compress(Data* data_to_compress, int compression_level) {
+  (void)compression_level;
   log_message(LOG_LEVEL_DEBUG, "Starting to compress data");
   size_t dst_size = ZSTD_compressBound(data_to_compress->size);
   Data* compressed_data = data_create_empty(dst_size);
@@ -20,14 +21,6 @@ Data* data_compress(Data* data_to_compress, int compression_level) {
     return NULL;
   }
 
-  size_t zret = ZSTD_CCtx_setParameter(cctx, ZSTD_c_compressionLevel, compression_level);
-  if (ZSTD_isError(zret)) {
-    log_message(LOG_LEVEL_ERROR, "Failed to set compression level: %s", ZSTD_getErrorName(zret));
-    ZSTD_freeCCtx(cctx);
-    data_destroy(compressed_data);
-    return NULL;
-  }
-
   ZSTD_inBuffer input = {data_to_compress->data, data_to_compress->size, 0};
   ZSTD_outBuffer output = {compressed_data->data, dst_size, 0};
 

src/shared/config.c

@@ -45,8 +45,6 @@ Config* config_create(char* version, char* send_directory, char* receive_directo
   config->tls_cert = NULL;
   config->tls_key = NULL;
   config->tls_ca = NULL;
-  config->server_host = str_dup("127.0.0.1");
-  config->server_port = 8080;
   return config;
 }
 
@@ -90,7 +88,6 @@ void config_delete(Config* config) {
   free(config->tls_cert);
   free(config->tls_key);
   free(config->tls_ca);
-  free(config->server_host);
   free(config);
 }
 
@@ -113,7 +110,7 @@ bool config_send(int file_descriptor, const Config* config) {
     return false;
   if (!send_int(file_descriptor, config->compression_level))
     return false;
-  if (!send_n_data(file_descriptor, &config->chunk_size, sizeof(config->chunk_size)))
+  if (!send_int(file_descriptor, (int)config->chunk_size))
     return false;
   if (!send_int(file_descriptor, config->use_sendfile))
     return false;
@@ -141,7 +138,6 @@ Config* config_receive(int file_descriptor) {
   Config* config = (Config*)malloc(sizeof(Config));
   if (config == NULL)
     return NULL;
-  memset(config, 0, sizeof(*config));
   config->version = receive_str(file_descriptor);
   if (!config->version) {
     free(config);
@@ -187,8 +183,9 @@ Config* config_receive(int file_descriptor) {
   if (!receive_int(file_descriptor, &tmp))
     goto error;
   config->compression_level = tmp;
-  if (!receive_n_data(file_descriptor, &config->chunk_size, sizeof(config->chunk_size)))
+  if (!receive_int(file_descriptor, &tmp))
     goto error;
+  config->chunk_size = (unsigned long long)tmp;
   if (!receive_int(file_descriptor, &tmp))
     goto error;
   config->use_sendfile = tmp;
@@ -221,8 +218,6 @@ Config* config_receive(int file_descriptor) {
   config->tls_cert = NULL;
   config->tls_key = NULL;
   config->tls_ca = NULL;
-  config->server_host = str_dup("127.0.0.1");
-  config->server_port = 8080;
   if (!send_status(file_descriptor, STATUS_OK))
     goto error;
   return config;
@@ -231,7 +226,6 @@ error:
   free(config->version);
   free(config->send_directory);
   free(config->receive_root_directory);
-  free(config->server_host);
   free(config);
   return NULL;
 }

src/shared/config.h

@@ -35,14 +35,12 @@ typedef struct Config {
   uint32_t delta_block_size;
   unsigned long long delta_max_file_size;
   bool use_tls;
-  char* server_host;
-  int server_port;
   char* tls_cert;
   char* tls_key;
   char* tls_ca;
 } Config;
 
-#define PROTOCOL_VERSION "1.4.0"
+#define PROTOCOL_VERSION "1.2.0"
 #define DEFAULT_CHUNK_SIZE (10 * 1024 * 1024)
 
 Config* config_create(char* version, char* send_directory, char* receive_directory,

src/shared/file.c

@@ -118,11 +118,6 @@ bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
     data_destroy(compressed_data);
     return false;
   }
-  int ft = 0; // FILE_TYPE_REGULAR
-  if (!send_int(file_descriptor, ft)) {
-    data_destroy(compressed_data);
-    return false;
-  }
   if (!send_data(file_descriptor, data_to_send)) {
     data_destroy(compressed_data);
     return false;
@@ -162,21 +157,17 @@ static void* old_data_from_path(const char* full_path, unsigned long long old_si
 
 static File* receive_delta_file(int fd, const Config* config, const char* check_path,
                                 void* old_data, unsigned long long old_size) {
-  if (!old_data) {
+  if (!old_data)
-    send_status(fd, STATUS_ERROR);
     return NULL;
-  }
 
   DeltaSignature* sig = delta_signature_create(old_data, old_size, config->delta_block_size);
   if (!sig) {
-    send_status(fd, STATUS_ERROR);
     free(old_data);
     return NULL;
   }
 
   Data* sig_data = delta_signature_serialize(sig);
   if (!sig_data) {
-    send_status(fd, STATUS_ERROR);
     delta_signature_destroy(sig);
     free(old_data);
     return NULL;
@@ -394,13 +385,6 @@ File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
     }
   }
 
-  int file_type;
-  if (!receive_int(fd, &file_type)) {
-    file_destroy(file);
-    send_status(fd, STATUS_ERROR);
-    return NULL;
-  }
-
   Data* file_data = receive_data(fd);
   if (file_data == NULL) {
     file_destroy(file);
@@ -425,63 +409,38 @@ File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
 }
 
 bool to_disk(const char* path, const void* data, unsigned long long data_size) {
-  // dirname() may modify its argument and may return a pointer to static storage.
+  char* directory = str_dup(path);
-  // We must use a copy of the result to be safe.
+  char* dir_to_free = directory;
-  char* path_dup = str_dup(path);
+  directory = dirname(directory);
-  if (!path_dup)
-    return false;
-  const char* dir_result = dirname(path_dup);
-  char* directory = str_dup(dir_result);
-  free(path_dup);
-  if (!directory)
-    return false;
-
-  bool ok = true;
   if (!mkdir_r(directory)) {
-    ok = false;
+    free(dir_to_free);
-    goto done;
+    return false;
   }
   FILE* file_pointer = fopen(path, "wb");
   if (file_pointer == NULL) {
     perror("Could not open File");
-    ok = false;
+    free(dir_to_free);
-    goto done;
+    return false;
   }
   if (fwrite(data, 1, data_size, file_pointer) != data_size) {
     perror("Failed to write all data to disk");
     fclose(file_pointer);
-    ok = false;
+    free(dir_to_free);
-    goto done;
+    return false;
   }
   fclose(file_pointer);
-
+  free(dir_to_free);
-done:
+  return true;
-  free(directory);
-  return ok;
 }
 
 bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level,
                         bool send_path) {
-  // sendfile is incompatible with compression (kernel zero-copy).
+  (void)compression_level;
-  // If compression is requested, fall back to the regular send path.
-  // NOTE: This is a safety net only — callers must ensure compression_level == 0
-  // before calling file_send_sendfile. The fallback to file_send_single_calls
-  // preserves the send_path contract, but callers should not rely on it for
-  // correctness (the --sendfile flag is validated to be mutually exclusive with
-  // -c/--compress at the CLI layer).
-  if (compression_level > 0)
-    return file_send_single_calls(file, file_descriptor, use_metadata, compression_level,
-                                  send_path);
-
   if (send_path && !send_str(file_descriptor, file->path))
     return false;
   if (use_metadata && !metadata_send(file_descriptor, file->metadata))
     return false;
 
-  int ft = 0; // FILE_TYPE_REGULAR
-  if (!send_int(file_descriptor, ft))
-    return false;
-
   int fd = open(file->path, O_RDONLY);
   if (fd == -1) {
     perror("Could not open file for sendfile");
@@ -524,11 +483,6 @@ File* file_receive(const Config* config, int file_descriptor) {
       return NULL;
     }
   }
-  int file_type;
-  if (!receive_int(file_descriptor, &file_type)) {
-    file_destroy(file);
-    return NULL;
-  }
   Data* file_data = receive_data(file_descriptor);
   if (file_data == NULL) {
     file_destroy(file);

src/shared/metadata.c

@@ -1,8 +1,6 @@
 #include "metadata.h"
 #include "file.h"
-#include "log.h"
 #include "protocol.h"
-#include <errno.h>
 #include <fcntl.h>
 #include <stdlib.h>
 #include <string.h>
@@ -98,15 +96,13 @@ FileMetadata* metadata_receive(int file_descriptor, int* ok) {
 void file_restore_metadata(const char* path, FileMetadata* metadata) {
   if (metadata == NULL)
     return;
-  if (chmod(path, metadata->mode & 07777) != 0)
+  chmod(path, metadata->mode & 07777);
-    log_message(LOG_LEVEL_WARNING, "Failed to chmod %s: %s", path, strerror(errno));
+  int chown_ret = chown(path, metadata->uid, metadata->gid);
-  if (chown(path, metadata->uid, metadata->gid) != 0)
+  (void)chown_ret;
-    log_message(LOG_LEVEL_WARNING, "Failed to chown %s: %s", path, strerror(errno));
   struct timespec times[2];
   times[0].tv_sec = 0;
   times[0].tv_nsec = UTIME_OMIT;
   times[1].tv_sec = metadata->mtime_sec;
   times[1].tv_nsec = metadata->mtime_nsec;
-  if (utimensat(AT_FDCWD, path, times, 0) != 0)
+  utimensat(AT_FDCWD, path, times, 0);
-    log_message(LOG_LEVEL_WARNING, "Failed to set timestamps on %s: %s", path, strerror(errno));
 }

src/shared/transport_ssh.c

@@ -1,5 +1,4 @@
 #include "transport_ssh.h"
-#include "utils.h"
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -9,58 +8,39 @@
 #include <unistd.h>
 
 typedef struct {
-  char* user;
+  char user[256];
-  char* host;
+  char host[256];
-  char* remote_path;
+  char remote_path[4096];
 } RemoteDest;
 
-static void remote_dest_destroy(RemoteDest* r) {
-  free(r->user);
-  free(r->host);
-  free(r->remote_path);
-}
-
 static int parse_remote_dest(const char* dest, RemoteDest* r) {
-  memset(r, 0, sizeof(*r));
   const char* colon = strchr(dest, ':');
   if (!colon)
     return -1;
 
-  r->remote_path = str_dup(colon + 1);
+  size_t remote_path_len = strlen(colon + 1);
-  if (!r->remote_path)
+  if (remote_path_len >= sizeof(r->remote_path))
     return -1;
+  memcpy(r->remote_path, colon + 1, remote_path_len + 1);
 
   const char* at = memchr(dest, '@', colon - dest);
   if (at) {
     size_t user_len = at - dest;
-    r->user = malloc(user_len + 1);
+    if (user_len >= sizeof(r->user))
-    if (!r->user) {
-      remote_dest_destroy(r);
       return -1;
-    }
     memcpy(r->user, dest, user_len);
     r->user[user_len] = '\0';
 
     size_t host_len = colon - at - 1;
-    r->host = malloc(host_len + 1);
+    if (host_len >= sizeof(r->host))
-    if (!r->host) {
-      remote_dest_destroy(r);
       return -1;
-    }
     memcpy(r->host, at + 1, host_len);
     r->host[host_len] = '\0';
   } else {
-    r->user = str_dup("");
+    r->user[0] = '\0';
-    if (!r->user) {
-      remote_dest_destroy(r);
-      return -1;
-    }
     size_t host_len = colon - dest;
-    r->host = malloc(host_len + 1);
+    if (host_len >= sizeof(r->host))
-    if (!r->host) {
-      remote_dest_destroy(r);
       return -1;
-    }
     memcpy(r->host, dest, host_len);
     r->host[host_len] = '\0';
   }
@@ -77,7 +57,6 @@ Client* client_connect_ssh(const char* destination, int port) {
   int sv[2];
   if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv) < 0) {
     perror("socketpair failed");
-    remote_dest_destroy(&r);
     return NULL;
   }
 
@@ -92,7 +71,6 @@ Client* client_connect_ssh(const char* destination, int port) {
     perror("pipe failed");
     close(sv[0]);
     close(sv[1]);
-    remote_dest_destroy(&r);
     return NULL;
   }
 
@@ -103,7 +81,6 @@ Client* client_connect_ssh(const char* destination, int port) {
     close(sv[1]);
     close(exec_pipe[0]);
     close(exec_pipe[1]);
-    remote_dest_destroy(&r);
     return NULL;
   }
 
@@ -111,6 +88,7 @@ Client* client_connect_ssh(const char* destination, int port) {
     close(sv[0]);
     close(exec_pipe[0]);
     fcntl(exec_pipe[1], F_SETFD, FD_CLOEXEC);
+
     if (sv[1] != STDIN_FILENO)
       dup2(sv[1], STDIN_FILENO);
     if (sv[1] != STDOUT_FILENO)
@@ -119,7 +97,7 @@ Client* client_connect_ssh(const char* destination, int port) {
       close(sv[1]);
 
     char ssh_user[512];
-    if (r.user && r.user[0] != '\0')
+    if (r.user[0] != '\0')
       snprintf(ssh_user, sizeof(ssh_user), "%s@%s", r.user, r.host);
     else
       snprintf(ssh_user, sizeof(ssh_user), "%s", r.host);
@@ -160,13 +138,10 @@ Client* client_connect_ssh(const char* destination, int port) {
   if (n > 0) {
     close(sv[0]);
     waitpid(pid, NULL, 0);
-    remote_dest_destroy(&r);
     fprintf(stderr, "Error: could not launch 'fastsync-server --stdio' on remote\n");
     return NULL;
   }
 
-  remote_dest_destroy(&r);
-
   Client* client = malloc(sizeof(Client));
   if (client == NULL) {
     close(sv[0]);

src/shared/utils.c

@@ -2,7 +2,6 @@
 #include "array_list.h"
 #include "libgen.h"
 #include <dirent.h>
-#include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -27,8 +26,7 @@ bool mkdir_r(const char* path) {
     path_current[0] = '\0';
   }
   const char* delimiter = "/";
-  char* saveptr;
+  const char* part = strtok(path_duplicate, delimiter);
-  const char* part = strtok_r(path_duplicate, delimiter, &saveptr);
   bool ok = true;
   while (part != NULL) {
     strcpy(path_current_position, part);
@@ -43,7 +41,7 @@ bool mkdir_r(const char* path) {
         break;
       }
     }
-    part = strtok_r(NULL, delimiter, &saveptr);
+    part = strtok(NULL, delimiter);
   }
   free(path_duplicate);
   free(path_current);
@@ -83,22 +81,10 @@ bool glob_match(const char* pattern, const char* str) {
   return *str == '\0';
 }
 
-static bool is_dir_in_manifest(const char* rel_path, ArrayList* manifest) {
-  size_t len = strlen(rel_path);
-  for (int i = 0; i < manifest->size; i++) {
-    const char* entry = (const char*)manifest->items[i];
-    // Check if entry starts with rel_path + '/' or matches exactly
-    if (strncmp(entry, rel_path, len) == 0 && (entry[len] == '/' || entry[len] == '\0'))
-      return true;
-  }
-  return false;
-}
-
 static void delete_extras_walk(const char* abs_path, const char* rel_path, ArrayList* manifest) {
   DIR* dir = opendir(abs_path);
   if (!dir)
     return;
-  bool all_removed = true;
   struct dirent* entry;
   while ((entry = readdir(dir)) != NULL) {
     if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
@@ -113,11 +99,6 @@ static void delete_extras_walk(const char* abs_path, const char* rel_path, Array
     }
     if (S_ISDIR(st.st_mode)) {
       delete_extras_walk(child_abs, child_rel, manifest);
-      // After recursion, try to remove the subdirectory if it's now empty.
-      // Ignore ENOENT: the recursive call may have already removed it.
-      if (rmdir(child_abs) != 0 && errno != ENOENT) {
-        all_removed = false;
-      }
     } else {
       // Check if relative path is in manifest
       bool found = false;
@@ -130,20 +111,14 @@ static void delete_extras_walk(const char* abs_path, const char* rel_path, Array
       if (!found) {
         unlink(child_abs);
         fprintf(stderr, "  Deleted: %s\n", child_rel);
-      } else {
-        all_removed = false;
       }
     }
     free(child_abs);
     free(child_rel);
   }
   closedir(dir);
-  // Only remove the directory itself if it is not in the manifest
-  // and contained no kept entries.
-  if (all_removed && rel_path[0] != '\0' && !is_dir_in_manifest(rel_path, manifest)) {
   rmdir(abs_path);
 }
-}
 
 void delete_extras(const char* dest_root, ArrayList* manifest) {
   delete_extras_walk(dest_root, "", manifest);

tests/runner.c

@@ -5,11 +5,8 @@
 #include "test_data.h"
 #include "test_delta.h"
 #include "test_file.h"
-#include "test_file_sendfile.h"
 #include "test_glob.h"
-#include "test_log.h"
 #include "test_metadata.h"
-#include "test_multiprocessing.h"
 #include "test_property.h"
 #include "test_protocol.h"
 #include "test_queue.h"
@@ -17,9 +14,6 @@
 #include "test_scanner.h"
 #include "test_shared_utils.h"
 #include "test_stress.h"
-#include "test_transport_tcp.h"
-#include "test_transport_ssh.h"
-#include "test_transport_tls.h"
 #include "test_utils.h"
 #include <stdio.h>
 
@@ -44,12 +38,6 @@ int main() {
   RUN_TEST(test_metadata);
   RUN_TEST(test_glob);
   RUN_TEST(test_file);
-  RUN_TEST(test_file_sendfile);
-  RUN_TEST(test_multiprocessing);
-  RUN_TEST(test_log);
-  RUN_TEST(test_transport_tcp);
-  RUN_TEST(test_transport_ssh);
-  RUN_TEST(test_transport_tls);
   RUN_TEST(test_robustness);
   RUN_TEST(test_stress);
   RUN_TEST(test_property);

tests/test_file.c

@@ -217,9 +217,6 @@ static void test_file_send_no_path() {
   pid_t pid = fork();
   if (pid == 0) {
     close(p[1]);
-    int file_type;
-    EXPECT_TRUE(receive_int(p[0], &file_type));
-    EXPECT_EQ_INT(file_type, 0); /* FILE_TYPE_REGULAR */
     Data* received = receive_data(p[0]);
     close(p[0]);
 
@@ -274,7 +271,7 @@ void test_file() {
   test_to_disk_basic();
   test_to_disk_creates_dirs();
   test_file_content_to_buffer();
-  if (!is_running_under_valgrind()) {
+  if (!getenv("FASTSYNC_UNDER_VALGRIND")) {
     // Fork tests are skipped under valgrind because the parent process runs
     // orders of magnitude slower than the child (parent is instrumented, child
     // is not), which causes pipe-based protocol handshake timeouts. The parent

tests/test_file_sendfile.c

@@ -1,269 +0,0 @@
-#include "test_file_sendfile.h"
-#include "file.h"
-#include "config.h"
-#include "protocol.h"
-#include "utils.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <string.h>
-#include <sys/stat.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-/* Test basic sendfile transfer: create a file, send it via file_send_sendfile,
- * receive via file_receive, and verify contents. */
-static void test_sendfile_basic() {
-  const char* content = "Hello from sendfile test!";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_basic.txt", content, len));
-
-  File* file = file_create("test_sendfile_basic.txt");
-  EXPECT_NOT_NULL(file);
-  /* Set the size so file_send_sendfile can report it */
-  file->data->size = len;
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: receive */
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (!received->path || strcmp(received->path, "test_sendfile_basic.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    /* Parent: send via sendfile */
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_basic.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile with an empty file */
-static void test_sendfile_empty_file() {
-  const char* content = "";
-  size_t len = 0;
-  EXPECT_TRUE(to_disk("test_sendfile_empty.txt", content, len));
-
-  File* file = file_create("test_sendfile_empty.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 0;
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (strcmp(received->path, "test_sendfile_empty.txt") != 0)
-        ok = false;
-      if (received->data->size != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_empty.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test error path: file does not exist on disk */
-static void test_sendfile_missing_file() {
-  File* file = file_create("nonexistent_sendfile_test_file.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 100; /* fake size */
-
-  /* Use a pipe that we can write to but sendfile should fail */
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  /* file_send_sendfile will try to open the nonexistent file -> should return false */
-  bool sent = file_send_sendfile(file, p[1], false, 0, true);
-
-  close(p[0]);
-  close(p[1]);
-  file_destroy(file);
-
-  EXPECT_FALSE(sent);
-}
-
-/* Test compression level > 0 falls back to file_send_single_calls */
-static void test_sendfile_compression_fallback() {
-  const char* content = "Compression fallback content";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_comp.txt", content, len));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_sendfile_comp.txt", &st), 0);
-
-  File* file = file_create("test_sendfile_comp.txt");
-  EXPECT_NOT_NULL(file);
-  /* Load the file data into memory (required by file_send_single_calls fallback) */
-  file->data->size = (size_t)st.st_size;
-  EXPECT_TRUE(file_load_data(file));
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, true, false, 3, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    /* compression_level = 3 triggers fallback to file_send_single_calls */
-    bool sent = file_send_sendfile(file, p[1], false, 3, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_comp.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile without path (send_path = false) */
-static void test_sendfile_no_path() {
-  const char* content = "No path sendfile test";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_nopath.txt", content, len));
-
-  File* file = file_create("test_sendfile_nopath.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = len;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    /* When send_path is false, the sender sends file_type + raw data (size + bytes).
-     * Read file_type first with assertion, then receive data. */
-    int file_type;
-    EXPECT_TRUE(receive_int(p[0], &file_type));
-    EXPECT_EQ_INT(file_type, 0); /* FILE_TYPE_REGULAR */
-    Data* received = receive_data(p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else if (received->size != len)
-      ok = false;
-    else if (memcmp(received->data, content, len) != 0)
-      ok = false;
-
-    data_destroy(received);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, false);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    unlink("test_sendfile_nopath.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-void test_file_sendfile() {
-  test_sendfile_missing_file(); // no fork, always runs
-  if (!getenv("FASTSYNC_UNDER_VALGRIND")) {
-    test_sendfile_basic();
-    test_sendfile_empty_file();
-    test_sendfile_compression_fallback();
-    test_sendfile_no_path();
-  }
-}

tests/test_file_sendfile.h

@@ -1,6 +0,0 @@
-#ifndef TEST_FILE_SENDFILE_H
-#define TEST_FILE_SENDFILE_H
-
-void test_file_sendfile();
-
-#endif

tests/test_log.c

@@ -1,116 +0,0 @@
-#include "test_log.h"
-#include "log.h"
-#include "test_utils.h"
-
-/* Test default log level: WARNING and ERROR should print, DEBUG and INFO should not.
- * We can't easily capture stderr in unit tests, so we verify the functions don't crash
- * and that set_log_level changes behavior. */
-
-static void test_log_message_debug() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_DEBUG, "debug message: %d", 42);
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_info() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_INFO, "info message: %s", "test");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_warning() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_WARNING, "warning message: %d %s", 1, "test");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_message_error() {
-  set_log_level(LOG_LEVEL_WARNING);
-  log_message(LOG_LEVEL_ERROR, "error message: %s", "critical");
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_debug() {
-  set_log_level(LOG_LEVEL_DEBUG);
-
-  /* After setting to DEBUG, all levels should be shown */
-  log_message(LOG_LEVEL_DEBUG, "debug after set");
-  log_message(LOG_LEVEL_INFO, "info after set");
-  log_message(LOG_LEVEL_WARNING, "warning after set");
-  log_message(LOG_LEVEL_ERROR, "error after set");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_info() {
-  set_log_level(LOG_LEVEL_INFO);
-
-  /* INFO level should show INFO, WARNING, ERROR but not DEBUG */
-  log_message(LOG_LEVEL_DEBUG, "debug should be filtered"); /* filtered */
-  log_message(LOG_LEVEL_INFO, "info should show");
-  log_message(LOG_LEVEL_WARNING, "warning should show");
-  log_message(LOG_LEVEL_ERROR, "error should show");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-static void test_log_set_level_error() {
-  set_log_level(LOG_LEVEL_ERROR);
-
-  /* ERROR level: only ERROR should show */
-  log_message(LOG_LEVEL_DEBUG, "debug filtered");
-  log_message(LOG_LEVEL_INFO, "info filtered");
-  log_message(LOG_LEVEL_WARNING, "warning filtered");
-  log_message(LOG_LEVEL_ERROR, "error should show");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-/* Test that set_log_level with default WARNING filters correctly */
-static void test_log_filtering() {
-  /* Reset to default */
-  set_log_level(LOG_LEVEL_WARNING);
-
-  /* These should be filtered */
-  log_message(LOG_LEVEL_DEBUG, "filtered debug");
-  log_message(LOG_LEVEL_INFO, "filtered info");
-
-  /* These should be shown */
-  log_message(LOG_LEVEL_WARNING, "visible warning");
-  log_message(LOG_LEVEL_ERROR, "visible error");
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-/* Test that log_message handles various format strings */
-static void test_log_message_formats() {
-  set_log_level(LOG_LEVEL_DEBUG);
-
-  log_message(LOG_LEVEL_DEBUG, "simple string");
-  log_message(LOG_LEVEL_INFO, "integer: %d", -1);
-  log_message(LOG_LEVEL_WARNING, "string: %s", "hello");
-  log_message(LOG_LEVEL_ERROR, "multiple: %d %s %d", 1, "two", 3);
-
-  /* crash regression test — stderr capture would need infrastructure changes */
-  EXPECT_TRUE(true);
-}
-
-void test_log() {
-  test_log_message_debug();
-  test_log_message_info();
-  test_log_message_warning();
-  test_log_message_error();
-  test_log_set_level_debug();
-  test_log_set_level_info();
-  test_log_set_level_error();
-  test_log_filtering();
-  test_log_message_formats();
-}

tests/test_log.h

@@ -1,6 +0,0 @@
-#ifndef TEST_LOG_H
-#define TEST_LOG_H
-
-void test_log();
-
-#endif

tests/test_multiprocessing.c

@@ -1,101 +0,0 @@
-#include "test_multiprocessing.h"
-#include "multiprocessing.h"
-#include "config.h"
-#include "queue.h"
-#include "utils.h"
-#include "test_utils.h"
-#include <stdlib.h>
-
-/* Test pipeline_context_sender_create/destroy with valid arguments */
-static void test_sender_create_destroy() {
-  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/dst"), false, false, false,
-                              false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  Queue* q_scanner = queue_create(5, NULL);
-  EXPECT_NOT_NULL(q_scanner);
-
-  Queue* q_loader = queue_create(10, NULL);
-  EXPECT_NOT_NULL(q_loader);
-
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q_scanner, q_loader);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_STR(ctx->config->version, "1.0");
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 5);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 10);
-  EXPECT_FALSE(ctx->scanner_done);
-  EXPECT_FALSE(ctx->loader_done);
-  EXPECT_NULL(ctx->manifest);
-
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test pipeline_context_receiver_create/destroy with valid arguments */
-static void test_receiver_create_destroy() {
-  Config* cfg = config_create(str_dup("2.0"), str_dup("/src"), str_dup("/dst"), true, true, false,
-                              false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  Queue* q = queue_create(20, NULL);
-  EXPECT_NOT_NULL(q);
-
-  PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, 42);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_STR(ctx->config->version, "2.0");
-  EXPECT_EQ_INT(ctx->queue->capacity, 20);
-  EXPECT_EQ_INT(ctx->file_descriptor, 42);
-  EXPECT_FALSE(ctx->receiver_done);
-
-  pipeline_context_receiver_destroy(ctx);
-}
-
-/* Test that create handles various queue capacities */
-static void test_sender_queue_capacities() {
-  Config* cfg = config_create(str_dup("3.0"), str_dup("/src"), str_dup("/dst"), false, false, false,
-                              false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  /* Single-element queues */
-  Queue* q1 = queue_create(1, NULL);
-  Queue* q2 = queue_create(1, NULL);
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q1, q2);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 1);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 1);
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test that create handles zero-capacity queues */
-static void test_sender_zero_capacity() {
-  Config* cfg = config_create(str_dup("4.0"), str_dup("/src"), str_dup("/dst"), false, false, false,
-                              false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  Queue* q1 = queue_create(0, NULL);
-  Queue* q2 = queue_create(0, NULL);
-  PipelineContextSender* ctx = pipeline_context_sender_create(cfg, q1, q2);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->queue_scanner->capacity, 0);
-  EXPECT_EQ_INT(ctx->queue_loader->capacity, 0);
-  pipeline_context_sender_destroy(ctx);
-}
-
-/* Test receiver with zero file_descriptor */
-static void test_receiver_fd_zero() {
-  Config* cfg = config_create(str_dup("5.0"), str_dup("/src"), str_dup("/dst"), false, false, false,
-                              false, false, 0, false, 0);
-  Queue* q = queue_create(5, NULL);
-  PipelineContextReceiver* ctx = pipeline_context_receiver_create(cfg, q, 0);
-  EXPECT_NOT_NULL(ctx);
-  EXPECT_EQ_INT(ctx->file_descriptor, 0);
-  EXPECT_FALSE(ctx->receiver_done);
-  pipeline_context_receiver_destroy(ctx);
-}
-
-void test_multiprocessing() {
-  test_sender_create_destroy();
-  test_receiver_create_destroy();
-  test_sender_queue_capacities();
-  test_sender_zero_capacity();
-  test_receiver_fd_zero();
-}

tests/test_multiprocessing.h

@@ -1,6 +0,0 @@
-#ifndef TEST_MULTIPROCESSING_H
-#define TEST_MULTIPROCESSING_H
-
-void test_multiprocessing();
-
-#endif

tests/test_protocol.c

@@ -46,7 +46,6 @@ static void test_send_receive_str() {
 
   EXPECT_TRUE(send_str(0, ""));
 
-  /* cppcheck-suppress constVariablePointer */
   char* received = receive_str(0);
   EXPECT_NOT_NULL(received);
   EXPECT_EQ_STR(received, "");
@@ -64,7 +63,6 @@ static void test_send_receive_str_normal() {
 
   EXPECT_TRUE(send_str(0, "Hello, Protocol!"));
 
-  /* cppcheck-suppress constVariablePointer */
   char* received = receive_str(0);
   EXPECT_NOT_NULL(received);
   EXPECT_EQ_STR(received, "Hello, Protocol!");
@@ -80,7 +78,6 @@ static void test_send_receive_data() {
   io_set_fds(p[0], p[1]);
   io_set_bwlimit(0);
 
-  /* cppcheck-suppress constVariablePointer */
   unsigned char bin[] = {0xDE, 0xAD, 0xBE, 0xEF, 0x00, 0xFF};
   void* buf = malloc(sizeof(bin));
   EXPECT_NOT_NULL(buf);
@@ -131,7 +128,6 @@ static void test_send_receive_status() {
   io_set_fds(p[0], p[1]);
   io_set_bwlimit(0);
 
-  /* cppcheck-suppress constVariablePointer */
   Status statuses[] = {STATUS_OK,    STATUS_ERROR, STATUS_FINISHED,        STATUS_NEXT,
                        STATUS_CHUNK, STATUS_CHECK, STATUS_DELTA_SIGNATURE, STATUS_DELTA_DATA};
   int count = sizeof(statuses) / sizeof(statuses[0]);

tests/test_scanner.c

@@ -15,7 +15,7 @@ static void test_scanner_single_file() {
   const char* file1 = "test_scan_dir_single/file1.txt";
   const char* content1 = "hello scanner";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
   create_test_file(file1, content1);
 
   DirectoryScanner* scanner =
@@ -43,7 +43,7 @@ static void test_scanner_multiple_files() {
   const char* content1 = "alpha";
   const char* content2 = "beta";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
   create_test_file(file1, content1);
   create_test_file(file2, content2);
 
@@ -82,8 +82,8 @@ static void test_scanner_subdirectory() {
   const char* sub_file = "test_scan_sub/sub/sub_file.txt";
   const char* content = "nested content";
 
-  EXPECT_EQ_INT(mkdir(root, 0755), 0);
+  mkdir(root, 0755);
-  EXPECT_EQ_INT(mkdir(sub, 0755), 0);
+  mkdir(sub, 0755);
   create_test_file(root_file, content);
   create_test_file(sub_file, content);
 
@@ -109,7 +109,7 @@ static void test_scanner_subdirectory() {
 static void test_scanner_empty_directory() {
   const char* dir = "test_scan_empty";
 
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
+  mkdir(dir, 0755);
 
   DirectoryScanner* scanner =
       directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
@@ -122,291 +122,9 @@ static void test_scanner_empty_directory() {
   rmdir(dir);
 }
 
-/* --- Exclude/include pattern and size filter edge cases (Issue #56) --- */
-
-static void test_scanner_exclude_pattern() {
-  const char* dir = "test_scan_excl";
-  const char* f_txt = "test_scan_excl/keep.txt";
-  const char* f_tmp = "test_scan_excl/remove.tmp";
-  const char* content = "data";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f_txt, content);
-  create_test_file(f_tmp, content);
-
-  char* exclude[] = {"*.tmp"};
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, exclude, 1, NULL, 0, 0, 0);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, f_txt);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f_txt);
-  unlink(f_tmp);
-  rmdir(dir);
-}
-
-static void test_scanner_exclude_subdirectory() {
-  /* Exclude patterns match filenames only (via entry->d_name).
-   * Files inside subdirectories are also matched by filename. */
-  const char* root = "test_scan_excl_sub";
-  const char* sub = "test_scan_excl_sub/sub";
-  const char* root_txt = "test_scan_excl_sub/root.txt";
-  const char* sub_txt = "test_scan_excl_sub/sub/data.txt";
-  const char* sub_tmp = "test_scan_excl_sub/sub/temp.tmp";
-  const char* content = "data";
-
-  EXPECT_EQ_INT(mkdir(root, 0755), 0);
-  EXPECT_EQ_INT(mkdir(sub, 0755), 0);
-  create_test_file(root_txt, content);
-  create_test_file(sub_txt, content);
-  create_test_file(sub_tmp, content);
-
-  /* Exclude *.tmp — should exclude sub/temp.tmp but keep root.txt and sub/data.txt */
-  char* exclude[] = {"*.tmp"};
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)root, false, 0, exclude, 1, NULL, 0, 0, 0);
-  EXPECT_NOT_NULL(scanner);
-
-  int total = 0;
-  Chunk* chunk;
-  while ((chunk = directory_scanner_next(scanner)) != NULL) {
-    total += chunk->element_count;
-    for (int i = 0; i < chunk->element_count; i++) {
-      /* No path should end in .tmp */
-      size_t len = strlen(chunk->items[i]->path);
-      EXPECT_TRUE(len < 4 || strcmp(chunk->items[i]->path + len - 4, ".tmp") != 0);
-    }
-    chunk_destroy(chunk);
-  }
-  EXPECT_EQ_INT(total, 2);
-
-  directory_scanner_destroy(scanner);
-  unlink(root_txt);
-  unlink(sub_txt);
-  unlink(sub_tmp);
-  rmdir(sub);
-  rmdir(root);
-}
-
-static void test_scanner_include_and_exclude() {
-  /* In the scanner, exclude is checked first and takes precedence.
-   * Include patterns act as an additional filter: if include_count > 0,
-   * the file must match one of the include patterns (after not being excluded).
-   * This test uses non-overlapping exclude and include patterns. */
-  const char* dir = "test_scan_inc_exc";
-  const char* f_txt = "test_scan_inc_exc/a.txt";
-  const char* f_log = "test_scan_inc_exc/b.log";
-  const char* f_bak = "test_scan_inc_exc/c.bak";
-  const char* content = "filter";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f_txt, content);
-  create_test_file(f_log, content);
-  create_test_file(f_bak, content);
-
-  /* Exclude *.bak. Include *.txt and *.log. */
-  char* exclude[] = {"*.bak"};
-  char* include[] = {"*.txt", "*.log"};
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 2, 0, 0);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  int found_txt = 0, found_log = 0;
-  for (int i = 0; i < chunk->element_count; i++) {
-    if (strstr(chunk->items[i]->path, "a.txt"))
-      found_txt = 1;
-    if (strstr(chunk->items[i]->path, "b.log"))
-      found_log = 1;
-  }
-  /* a.txt included by *.txt, b.log included by *.log, c.bak excluded by *.bak */
-  EXPECT_TRUE(found_txt);
-  EXPECT_TRUE(found_log);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f_txt);
-  unlink(f_log);
-  unlink(f_bak);
-  rmdir(dir);
-}
-
-static void test_scanner_max_size() {
-  const char* dir = "test_scan_max";
-  const char* small = "test_scan_max/small.txt";
-  const char* large = "test_scan_max/large.txt";
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(small, "tiny");
-  create_test_file(large, "this_content_is_longer_than_ten_chars");
-
-  /* max_size = 10 — only files <= 10 bytes */
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 10, 0);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, small);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(small);
-  unlink(large);
-  rmdir(dir);
-}
-
-static void test_scanner_min_size() {
-  const char* dir = "test_scan_min";
-  const char* empty_f = "test_scan_min/empty.txt";
-  const char* data_f = "test_scan_min/data.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(empty_f, "");
-  create_test_file(data_f, "some content here");
-
-  /* min_size = 1 — only files >= 1 byte */
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 1);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, data_f);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(empty_f);
-  unlink(data_f);
-  rmdir(dir);
-}
-
-static void test_scanner_size_range() {
-  const char* dir = "test_scan_range";
-  const char* tiny = "test_scan_range/tiny.txt";
-  const char* medium = "test_scan_range/med.txt";
-  const char* huge = "test_scan_range/huge.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(tiny, "ab");
-  create_test_file(medium, "hello world");
-  create_test_file(huge, "this is a much larger file for testing size filters");
-
-  /* Only files between 3 and 20 bytes */
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 20, 3);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 1);
-  EXPECT_EQ_STR(chunk->items[0]->path, medium);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(tiny);
-  unlink(medium);
-  unlink(huge);
-  rmdir(dir);
-}
-
-static void test_scanner_mixed_patterns() {
-  /* Combine exclude, include, and size filters together */
-  const char* dir = "test_scan_mixed";
-  const char* a_txt = "test_scan_mixed/a.txt"; /* size ~= 5  */
-  const char* b_bin = "test_scan_mixed/b.bin"; /* size ~= 13 */
-  const char* c_txt = "test_scan_mixed/c.txt"; /* size ~= 5  */
-  const char* d_bak = "test_scan_mixed/d.bak"; /* size ~= 42 */
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(a_txt, "aaaaa");
-  create_test_file(b_bin, "bbbbbbbbbbbbb");
-  create_test_file(c_txt, "ccccc");
-  create_test_file(d_bak, "dddddddddddddddddddddddddddddddddddddddddd");
-
-  /* Exclude *.bak, include *.txt, min_size=3, max_size=10 */
-  char* exclude[] = {"*.bak"};
-  char* include[] = {"*.txt"};
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, exclude, 1, include, 1, 10, 3);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  /* Both a.txt and c.txt meet the criteria: .txt extension, size 5 <= 10 and >= 3 */
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(a_txt);
-  unlink(b_bin);
-  unlink(c_txt);
-  unlink(d_bak);
-  rmdir(dir);
-}
-
-static void test_scanner_no_patterns() {
-  /* Explicit test with no exclude/include patterns and no size filters.
-   * This verifies that NULL/0 for all pattern parameters works correctly. */
-  const char* dir = "test_scan_none";
-  const char* f1 = "test_scan_none/f1.txt";
-  const char* f2 = "test_scan_none/f2.txt";
-
-  EXPECT_EQ_INT(mkdir(dir, 0755), 0);
-  create_test_file(f1, "first");
-  create_test_file(f2, "second");
-
-  DirectoryScanner* scanner =
-      directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
-  EXPECT_NOT_NULL(scanner);
-
-  Chunk* chunk = directory_scanner_next(scanner);
-  EXPECT_NOT_NULL(chunk);
-  EXPECT_EQ_INT(chunk->element_count, 2);
-
-  chunk_destroy(chunk);
-  EXPECT_NULL(directory_scanner_next(scanner));
-
-  directory_scanner_destroy(scanner);
-  unlink(f1);
-  unlink(f2);
-  rmdir(dir);
-}
-
 void test_scanner() {
   test_scanner_single_file();
   test_scanner_multiple_files();
   test_scanner_subdirectory();
   test_scanner_empty_directory();
-  /* Issue #56: scanner pattern edge cases */
-  test_scanner_exclude_pattern();
-  test_scanner_exclude_subdirectory();
-  test_scanner_include_and_exclude();
-  test_scanner_max_size();
-  test_scanner_min_size();
-  test_scanner_size_range();
-  test_scanner_mixed_patterns();
-  test_scanner_no_patterns();
 }

tests/test_transport_ssh.c

@@ -1,53 +0,0 @@
-#include "test_transport_ssh.h"
-#include "transport_ssh.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <unistd.h>
-#include <sys/wait.h>
-
-/* Test client_connect_ssh with invalid destination (missing colon) */
-static void test_ssh_connect_invalid_dest() {
-  /* Missing colon — parse_remote_dest should fail and return NULL */
-  /* cppcheck-suppress constVariablePointer */
-  Client* client = client_connect_ssh("invalid-destination-no-colon", 22);
-  EXPECT_NULL(client);
-}
-
-/* Test client_connect_ssh with empty destination */
-static void test_ssh_connect_empty_dest() {
-  /* cppcheck-suppress constVariablePointer */
-  Client* client = client_connect_ssh("", 22);
-  EXPECT_NULL(client);
-}
-
-/* Test client_connect_ssh with malformed destination (just a colon).
- * parse_remote_dest succeeds, ssh is exec'd and fails, but the function
- * creates a Client that must be cleaned up. */
-static void test_ssh_connect_malformed() {
-  Client* client = client_connect_ssh(":", 22);
-  /* ssh binary exists, so exec succeeds; the function returns a Client.
-   * We just verify it doesn't crash and clean up properly. */
-  if (client != NULL) {
-    client_disconnect(client);
-    client_delete(client);
-  }
-  EXPECT_TRUE(true);
-}
-
-/* Test client_connect_ssh with valid format but unreachable host.
- * The function launches ssh which will fail to connect, returns a Client. */
-static void test_ssh_connect_unreachable() {
-  Client* client = client_connect_ssh("nonexistent.invalid:/remote/path", 22);
-  if (client != NULL) {
-    client_disconnect(client);
-    client_delete(client);
-  }
-  EXPECT_TRUE(true);
-}
-
-void test_transport_ssh() {
-  test_ssh_connect_invalid_dest();
-  test_ssh_connect_empty_dest();
-  test_ssh_connect_malformed();
-  test_ssh_connect_unreachable();
-}

tests/test_transport_ssh.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_SSH_H
-#define TEST_TRANSPORT_SSH_H
-
-void test_transport_ssh();
-
-#endif

tests/test_transport_tcp.c

@@ -1,90 +0,0 @@
-#include "test_transport_tcp.h"
-#include "transport_tcp.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <unistd.h>
-
-/* Test client_create and client_delete lifecycle */
-static void test_client_create_delete() {
-  Client* client = client_create();
-  EXPECT_NOT_NULL(client);
-  EXPECT_TRUE(client->file_descriptor >= 0);
-  EXPECT_EQ_INT(client->address.sin_family, AF_INET);
-  EXPECT_EQ_INT(client->ssh_child_pid, -1);
-  EXPECT_NULL(client->ssl);
-  EXPECT_NULL(client->ssl_ctx);
-
-  /* Delete should clean up without error */
-  client_delete(client);
-}
-
-/* Test client_delete with NULL (safety) */
-static void test_client_delete_null() {
-  client_delete(NULL);
-  EXPECT_TRUE(true);
-}
-
-/* Test server_create and server_delete lifecycle */
-static void test_server_create_delete() {
-  /* Use port 0 to let the OS assign a port */
-  Server* server = server_create(0);
-  EXPECT_NOT_NULL(server);
-  EXPECT_TRUE(server->file_descriptor >= 0);
-  EXPECT_EQ_INT(server->address.sin_family, AF_INET);
-  EXPECT_NULL(server->ssl_ctx);
-
-  /* Clean up */
-  server_delete(&server);
-  EXPECT_NULL(server);
-}
-
-/* Test server_delete with NULL pointer */
-static void test_server_delete_null_ptr() {
-  server_delete(NULL);
-  EXPECT_TRUE(true);
-}
-
-/* Test server_delete with NULL server */
-static void test_server_delete_null_server() {
-  Server* s = NULL;
-  server_delete(&s);
-  EXPECT_NULL(s);
-}
-
-/* Test client_create can be called multiple times */
-static void test_client_create_multiple() {
-  Client* c1 = client_create();
-  Client* c2 = client_create();
-  EXPECT_NOT_NULL(c1);
-  EXPECT_NOT_NULL(c2);
-  EXPECT_TRUE(c1->file_descriptor >= 0);
-  EXPECT_TRUE(c2->file_descriptor >= 0);
-  EXPECT_TRUE(c1->file_descriptor != c2->file_descriptor);
-
-  client_delete(c1);
-  client_delete(c2);
-}
-
-/* Test client_disconnect on a fresh client (should close socket) */
-static void test_client_disconnect_fresh() {
-  Client* client = client_create();
-  EXPECT_NOT_NULL(client);
-
-  /* Disconnect should close the file descriptor */
-  client_disconnect(client);
-  /* The fd should now be invalid */
-  /* Verify by trying to use close() on it - should fail */
-  EXPECT_EQ_INT(close(client->file_descriptor), -1);
-
-  client_delete(client);
-}
-
-void test_transport_tcp() {
-  test_client_create_delete();
-  test_client_delete_null();
-  test_server_create_delete();
-  test_server_delete_null_ptr();
-  test_server_delete_null_server();
-  test_client_create_multiple();
-  test_client_disconnect_fresh();
-}

tests/test_transport_tcp.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_TCP_H
-#define TEST_TRANSPORT_TCP_H
-
-void test_transport_tcp();
-
-#endif

tests/test_transport_tls.c

@@ -1,81 +0,0 @@
-#include "test_transport_tls.h"
-#include "transport_tls.h"
-#include "transport_tcp.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <unistd.h>
-
-/* Test tls_global_init succeeds */
-static void test_tls_global_init() {
-  bool ok = tls_global_init();
-  EXPECT_TRUE(ok);
-}
-
-/* Test tls_global_init can be called multiple times */
-static void test_tls_global_init_twice() {
-  bool ok1 = tls_global_init();
-  bool ok2 = tls_global_init();
-  EXPECT_TRUE(ok1);
-  EXPECT_TRUE(ok2);
-}
-
-/* Test client_connect_tls with bad certificate path.
- * The function will create a socket, try to connect to localhost,
- * fail to connect (since nothing is listening), and return false.
- * We don't need a server to verify the error path. */
-static void test_tls_connect_bad_cert() {
-  /* First, init TLS globally */
-  tls_global_init();
-
-  Client* client = client_create();
-  EXPECT_NOT_NULL(client);
-
-  /* Attempt to connect to a non-existent server with bad cert paths.
-   * client_connect_tls will try to connect first, fail, and return false.
-   * Note: we use an invalid host to ensure connection failure,
-   * which exercises the error path before cert loading. */
-  bool ok = client_connect_tls(client, "127.0.0.1", 1, "/nonexistent/cert.pem",
-                               "/nonexistent/key.pem", "/nonexistent/ca.pem");
-  EXPECT_FALSE(ok);
-
-  client_delete(client);
-}
-
-/* Test client_connect_tls with NULL cert paths (should still attempt connection).
- * Cert/key/ca being NULL is valid — the function will attempt to create an
- * SSL context without client certificates. */
-static void test_tls_connect_null_paths() {
-  tls_global_init();
-
-  Client* client = client_create();
-  EXPECT_NOT_NULL(client);
-
-  /* Connect to invalid address — will fail at connect() step */
-  bool ok = client_connect_tls(client, "127.0.0.1", 1, NULL, NULL, NULL);
-  EXPECT_FALSE(ok);
-
-  client_delete(client);
-}
-
-/* Test server_create_tls with bad cert paths.
- * The function should fail gracefully. */
-static void test_tls_server_bad_cert() {
-  tls_global_init();
-
-  Server* server = server_create(0);
-  EXPECT_NOT_NULL(server);
-
-  /* Load bad cert paths — should fail and return false */
-  bool ok = server_create_tls(server, "/nonexistent/cert.pem", "/nonexistent/key.pem", NULL);
-  EXPECT_FALSE(ok);
-
-  server_delete(&server);
-}
-
-void test_transport_tls() {
-  test_tls_global_init();
-  test_tls_global_init_twice();
-  test_tls_connect_bad_cert();
-  test_tls_connect_null_paths();
-  test_tls_server_bad_cert();
-}

tests/test_transport_tls.h

@@ -1,6 +0,0 @@
-#ifndef TEST_TRANSPORT_TLS_H
-#define TEST_TRANSPORT_TLS_H
-
-void test_transport_tls();
-
-#endif

tests/test_utils.h

@@ -2,24 +2,9 @@
 #define TEST_UTILS_H
 
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
 
-// Detect if running under valgrind by checking /proc/self/maps for vgpreload.
-// This is used to skip fork-based tests that are incompatible with valgrind
-// (the instrumented parent runs too slowly, causing pipe timeouts).
-static inline bool is_running_under_valgrind(void) {
-  FILE* f = fopen("/proc/self/maps", "r");
-  if (!f)
-    return false;
-  char buf[4096];
-  size_t n = fread(buf, 1, sizeof(buf) - 1, f);
-  fclose(f);
-  buf[n] = '\0';
-  return strstr(buf, "vgpreload") != NULL;
-}
-
 // Global test suite status
 extern int tests_run;
 extern int tests_failed;