refactor: consolidate _no_path file send variants

Add bool send_path parameter to file_send_single_calls and
file_send_sendfile, remove the _no_path variants. Callers in
client_send.c pass true (send path) or false (skip path) based
on whether an incremental check already transmitted the path.

.clang-format

@@ -1,10 +0,0 @@
-BasedOnStyle: LLVM
-IndentWidth: 2
-ColumnLimit: 100
-PointerAlignment: Left
-AllowShortFunctionsOnASingleLine: None
-SortIncludes: false
-AllowShortIfStatementsOnASingleLine: false
-AllowShortLoopsOnASingleLine: false
-BinPackArguments: true
-BinPackParameters: true

.gitea/workflows/ci.yaml

@@ -1,116 +1,23 @@
 name: CI
 
-on:
-  push:
-    branches: [main]
-  pull_request:
+on: [push, pull_request]
 
 jobs:
-  lint:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: clang-format check
-        run: find src/ tests/ -name '*.c' -o -name '*.h' | xargs clang-format --dry-run --Werror
-
-      - name: cppcheck
-        run: cppcheck --enable=warning,style,performance,portability --suppress=missingIncludeSystem --error-exitcode=1 --inline-suppr src/ tests/
-
   build-and-test:
     runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    needs: lint
+    container: gitea.tap-tap.win/taptap/fastsync-ci:v4
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
       - name: Configure
-        run: cmake -B build -S . -DSTRICT_WARNINGS=ON
+        run: cmake -B build -S .
 
       - name: Build
         run: cmake --build build -j$(nproc)
 
       - name: Unit Tests
-        run: ctest --test-dir build --output-on-failure -j$(nproc)
+        run: ./build/tests
 
       - name: Integration Tests
-        run: python3 -m pytest tests/integration/ -v --tb=short
-
-  sanitizers:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    needs: lint
-    strategy:
-      matrix:
-        sanitizer: [address, undefined]
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure
-        run: cmake -B build-${{ matrix.sanitizer }} -S . -DSANITIZER=${{ matrix.sanitizer }}
-
-      - name: Build
-        run: cmake --build build-${{ matrix.sanitizer }} -j$(nproc)
-
-      - name: Unit Tests
-        run: ctest --test-dir build-${{ matrix.sanitizer }} --output-on-failure
-
-  fuzz-build:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    needs: lint
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure (clang + fuzz)
-        run: CC=clang CXX=clang++ cmake -B build-fuzz -S . -DENABLE_FUZZ=ON
-
-      - name: Build fuzz targets
-        run: cmake --build build-fuzz -j$(nproc)
-
-  coverage:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    needs: lint
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure
-        run: cmake -B build -S . -DENABLE_COVERAGE=ON
-
-      - name: Build
-        run: cmake --build build -j$(nproc)
-
-      - name: Unit Tests
-        run: ctest --test-dir build --output-on-failure
-
-      - name: Coverage Report
-        run: |
-          lcov --capture --directory build --output-file coverage.info --branch-coverage --ignore-errors negative
-          lcov --remove coverage.info '/usr/*' '*/tests/*' '*/_deps/*' --output-file coverage.info --branch-coverage --ignore-errors unused,negative
-          lcov --list coverage.info
-
-  valgrind:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v9
-    needs: lint
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure
-        run: cmake -B build -S . -DSTRICT_WARNINGS=ON
-
-      - name: Build
-        run: cmake --build build -j$(nproc)
-
-      - name: Valgrind Memcheck
-        run: valgrind --leak-check=full --show-leak-kinds=definite --error-exitcode=1 ./build/tests
-        env:
-          FASTSYNC_UNDER_VALGRIND: "1"
+        run: python3 test.py

.gitignore

@@ -2,6 +2,3 @@ build
 data_copied
 test_data/
 __pycache__/
-build-asan
-coverage.info
-build-*/

.lsan-suppressions.txt

@@ -1,6 +0,0 @@
-# LSAN suppressions for FastSync
-# Add suppression entries here for known pre-existing leaks that cannot be
-# fixed immediately. Remove entries as leaks are fixed.
-#
-# Example format:
-# leak:function_name

.opencode/agents/architect.md

@@ -1,135 +0,0 @@
----
-description: Designs system architecture, module interactions, data flow, and makes high-level design decisions for FastSync.
-mode: subagent
----
-
-You are a system architect for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Make high-level design decisions. Evaluate trade-offs, plan module interactions, design data flow, and ensure architectural coherence across the codebase.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Architecture
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Data Flow — Client Transfer Pipeline
-```
-CLI args → Config
-  → DirectoryScanner (BFS, exclude/include patterns)
-    → Queue[Scanner → Loader]
-      → ChunkBuilder (groups files into ~10MB chunks)
-        → Queue[Loader → Sender]
-          → [Optional: Compression (zstd streaming)]
-            → [Optional: Chunk Serialization]
-              → Network (TCP sendfile / SSH pipe)
-                → Protocol framing (status codes + data)
-```
-
-### Data Flow — Server Receive
-```
-TCP accept / SSH stdio
-  → Config receive
-    → Per-connection handler (fork)
-      → [Optional: Decompression]
-        → [Optional: Chunk deserialization]
-          → File write / metadata restore
-            → [Optional: Delete processing via manifest]
-```
-
-### Threading Model
-- Client uses producer-consumer with C11 threads (`thrd_t`)
-- Bounded queues with `mtx_t` + `cnd_t` for backpressure
-- Scanner → Loader → Sender pipeline
-- Server uses `fork()` per connection, optional thread pool
-
-### Transport Abstraction
-- `io_set_fds(read_fd, write_fd)` — set active file descriptors
-- `io_set_ssl(SSL*)` — transparent TLS wrapping
-- `io_set_bwlimit(bytes_per_sec)` — token-bucket throttling
-- All protocol functions use the active IO layer transparently
-
-## Design Principles
-
-1. **Performance first** — zero-copy where possible, streaming compression, multithreading
-2. **Simplicity** — status-code-driven protocol, no complex state machines
-3. **Composability** — features enabled via flags (-c, -m, -s, -f, -M)
-4. **Backward compatibility** — version field in config for negotiation
-5. **Unix philosophy** — do one thing well, compose via CLI flags
-
-## When Making Design Decisions
-
-### Evaluate
-1. **Performance impact** — Will this slow down the hot path?
-2. **Complexity cost** — Does this add state, protocol changes, or new failure modes?
-3. **Backward compatibility** — Can old clients/servers handle this?
-4. **Testability** — Can this be unit tested independently?
-5. **Composability** — Does this compose with existing flags/features?
-
-### Output Format
-
-When proposing architecture changes:
-1. **Problem** — what needs to be solved or improved
-2. **Current behavior** — how it works now
-3. **Proposed design** — new architecture with data flow diagrams
-4. **Trade-offs** — what's gained vs what's lost
-5. **Migration path** — how to get from current to proposed
-6. **Affected modules** — which files need changes
-7. **Testing strategy** — how to verify the change works
-
-### Anti-patterns to Watch For
-- God functions (>200 lines, doing too many things)
-- Circular dependencies between modules
-- Leaking transport details into application logic
-- Hardcoded constants that should be configurable
-- Missing error propagation (silent failures)
-- Thread safety violations when adding new shared state
-
-## CI & Task Execution
-
-**Always wait for CI to finish after every push.** Never report a task as complete or move on until CI has passed on the PR branch.
-
-After every push:
-1. Use `tea actions runs list` to get the latest run ID for the branch.
-2. Poll its status until it leaves the "running" state (use a loop with sleep + sufficient timeout, e.g., 600000ms).
-3. Once completed, inspect the logs with `tea actions runs log <ID>` for every job.
-4. If any job failed, fix the issue, push again, and repeat from step 1.
-5. Only report done when ALL CI jobs pass.
-
-Do not wait for the user to tell you CI failed — check proactively. The user should never have to inform you of a CI failure you could have caught yourself.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/c-reviewer.md

@@ -52,18 +52,6 @@ Review C source files for correctness, safety, and style. You have deep knowledg
 - No deadlock potential — consistent lock ordering.
 - `done` flags checked properly in consumer loops.
 
-### Security
-- No `strcpy`/`strcat`/`sprintf` — use `snprintf` with bounds.
-- `malloc` size calculations don't overflow (`count * sizeof(...)` checked).
-- Path traversal prevention: no `..` in received filenames.
-- No fixed-size stack buffers for unbounded network input.
-- TLS error codes checked after `SSL_read`/`SSL_write`.
-- No hardcoded certificates, keys, or credentials.
-- Private key file permissions checked.
-- Received file permissions validated (no SUID/SGID injection).
-- Symlink attack prevention in destination directory.
-- Denial of service: bounded memory allocation, malformed messages handled gracefully.
-
 ### Protocol Safety
 - `send_n_data` / `receive_n_data` return values checked.
 - Status codes validated before use.
@@ -81,19 +69,7 @@ Review C source files for correctness, safety, and style. You have deep knowledg
 For each issue found, report:
 1. **File and line** — exact location
 2. **Severity** — critical / warning / style
-3. **Category** — memory / thread / protocol / security / style
+3. **Category** — memory / thread / protocol / style
 4. **Description** — what's wrong and how to fix it
 
 If the code is clean, say so explicitly. Be concise — don't pad with fluff.
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/cmake-expert.md

@@ -3,7 +3,7 @@ description: Manages the CMake build system for FastSync — adding targets, sou
 mode: subagent
 ---
 
-You are a CMake expert for the FastSync project — a high-performance file synchronization system built with CMake 3.22+ and C11.
+You are a CMake expert for the FastSync project — a high-performance file synchronization system built with CMake 4.1+ and C11.
 
 ## Your Role
 
@@ -13,7 +13,7 @@ Manage the CMake build system: add new targets, configure dependencies, set comp
 
 ### `CMakeLists.txt` (project root)
 ```cmake
-cmake_minimum_required(VERSION 3.22)
+cmake_minimum_required(VERSION 4.1)
 project(FastFileTransfer)
 
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
@@ -22,54 +22,30 @@ set(CMAKE_C_STANDARD_REQUIRED ON)
 
 add_compile_options(-Wall -g -O3)
 
-include(FetchContent)
-FetchContent_Declare(xxhash GIT_REPOSITORY https://github.com/Cyan4973/xxHash GIT_TAG v0.8.3 SOURCE_SUBDIR cmake_unofficial)
-FetchContent_MakeAvailable(xxhash)
-
-# Sanitizer option
-set(SANITIZER "none" CACHE STRING "Sanitizer to enable (address, thread, none)")
-set_property(CACHE SANITIZER PROPERTY STRINGS address thread none)
-if(SANITIZER STREQUAL "address")
-  add_compile_options(-fsanitize=address -fno-omit-frame-pointer -g)
-  add_link_options(-fsanitize=address)
-elseif(SANITIZER STREQUAL "thread")
-  add_compile_options(-fsanitize=thread -fno-omit-frame-pointer -g)
-  add_link_options(-fsanitize=thread)
-elseif(NOT SANITIZER STREQUAL "none")
-  message(FATAL_ERROR "Unknown sanitizer: ${SANITIZER}. Supported values: address, thread, none")
-endif()
-
-option(STRICT_WARNINGS "Enable strict warnings" OFF)
-if(STRICT_WARNINGS)
-  add_compile_options(-Wextra -Wpedantic -Werror)
-endif()
-
 set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
 
 find_library(ZSTD_LIBRARY zstd)
-if(NOT ZSTD_LIBRARY)
-  message(FATAL_ERROR "zstd library not found. Ensure it is in your nix-shell!")
-endif()
-
-find_package(OpenSSL REQUIRED)
+# ... error if not found
 
+# Source file collection
 file(GLOB SHARED_SRCS "src/shared/*.c")
 file(GLOB SERVER_SRCS "src/server/*.c")
 file(GLOB CLIENT_SRCS "src/client/*.c")
 file(GLOB TEST_SRCS "tests/*.c")
 
+# Targets
 add_executable(server ${SERVER_SRCS} ${SHARED_SRCS})
 target_include_directories(server PRIVATE src/shared src/server src/client)
-target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
 add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS})
 target_include_directories(client PRIVATE src/shared src/server src/client)
-target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
 add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c)
 target_include_directories(tests PRIVATE tests src/shared src/server src/client)
-target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 ```
 
 ### Source Layout
@@ -77,26 +53,22 @@ target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SS
 src/shared/    — shared libraries (globbed as SHARED_SRCS)
 src/client/    — client sources (globbed as CLIENT_SRCS)
 src/server/    — server sources (globbed as SERVER_SRCS)
-tests/         — unit test sources (globbed as TEST_SRCS)
-tests/integration/ — Python pytest integration tests
+tests/         — test sources (globbed as TEST_SRCS)
 ```
 
 ### Dependencies
 - **zstd** — found via `find_library(ZSTD_LIBRARY zstd)`
-- **OpenSSL** — found via `find_package(OpenSSL REQUIRED)` (TLS 1.2+ transport)
-- **xxHash** — fetched via `FetchContent` from GitHub (delta transfer hashing, v0.8.3)
 - **pthreads** — found via `find_package(Threads REQUIRED)`
 - **C11 standard** — required
-- **CMake 3.22+** — minimum version
+- **CMake 4.1+** — minimum version
 
 ## Conventions
 
 - Use `file(GLOB ...)` for source collection (existing pattern).
-- All targets link `Threads::Threads`, `${ZSTD_LIBRARY}`, `OpenSSL::SSL`, `OpenSSL::Crypto`, and `xxhash`.
+- All targets link `Threads::Threads` and `${ZSTD_LIBRARY}`.
 - Include directories: `src/shared`, `src/server`, `src/client`, `tests` (for test target).
-- Sanitizer support: pass `-DSANITIZER=address` or `-DSANITIZER=thread` to cmake (live option in CMakeLists.txt).
+- Sanitizer support is commented out but present (`-fsanitize=address`).
 - Build with `cmake -B build -S . && cmake --build build -j$(nproc)`.
-- For CI, dependencies are provided by the project's custom Docker image (repo-root `Dockerfile`, same image CI uses). For local development, use `nix-shell`. Never add `apt-get install` / `pip install` to CI workflows. See `AGENTS.md`.
 
 ## When Making Changes
 
@@ -105,55 +77,9 @@ tests/integration/ — Python pytest integration tests
 3. Add new dependencies with `find_package` or `find_library`.
 4. When adding a new executable target, follow the pattern of existing targets.
 5. When adding a new library (static/shared), use `add_library` and follow the project's naming.
-6. For sanitizer builds, pass `-DSANITIZER=address` or `-DSANITIZER=thread` to cmake (matching CI's matrix strategy).
+6. For sanitizer builds, use the commented-out `-fsanitize=address` lines as reference.
 7. Always verify the build compiles after changes.
 
-## Sanitizer Configurations
-
-Use the project's built-in `-DSANITIZER=` option (matching the CI matrix):
-```bash
-cmake -B build -S . -DSANITIZER=address   # AddressSanitizer (memory errors)
-cmake --build build -j$(nproc)
-
-cmake -B build -S . -DSANITIZER=thread    # ThreadSanitizer (race conditions)
-cmake --build build -j$(nproc)
-```
-
-For UndefinedBehaviorSanitizer (no `-DSANITIZER=undefined` option in CMakeLists.txt yet), use the manual flag approach:
-```bash
-cmake -B build -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=undefined -fno-omit-frame-pointer -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=undefined"
-cmake --build build -j$(nproc)
-```
-
-### Using ccache (faster rebuilds)
-```bash
-cmake -B build -S . -DCMAKE_C_COMPILER_LAUNCHER=ccache
-cmake --build build -j$(nproc)
-```
-
-### Cross-Compilation
-```bash
-# ARM cross-compile example
-cmake -B build-arm -S . \
-  -DCMAKE_SYSTEM_NAME=Linux \
-  -DCMAKE_SYSTEM_PROCESSOR=aarch64 \
-  -DCMAKE_C_COMPILER=aarch64-linux-gnu-gcc
-```
-
-### Release vs Debug Builds
-```bash
-# Release (optimized)
-cmake -B build -S . -DCMAKE_BUILD_TYPE=Release
-
-# Debug (with symbols, no optimization)
-cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug
-
-# RelWithDebInfo (optimized + debug symbols)
-cmake -B build -S . -DCMAKE_BUILD_TYPE=RelWithDebInfo
-```
-
 ## Build Commands
 
 ```bash
@@ -163,32 +89,3 @@ cmake --build build -j$(nproc)
 ./build/client
 ./build/tests
 ```
-
-## Sanitizer Integration
-
-The project uses a single `SANITIZER` cache variable in `CMakeLists.txt`:
-```cmake
-set(SANITIZER "none" CACHE STRING "Sanitizer to enable (address, thread, none)")
-set_property(CACHE SANITIZER PROPERTY STRINGS address thread none)
-```
-Supported values: `address`, `thread`, `none`. Unknown values trigger `FATAL_ERROR`.
-
-Build with:
-```bash
-cmake -B build -S . -DSANITIZER=address
-cmake --build build -j$(nproc)
-```
-
-To add support for a new sanitizer (e.g., UBSan), add an `elseif(SANITIZER STREQUAL "undefined")` block following the existing `address`/`thread` pattern.
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/code-explainer.md

@@ -1,145 +0,0 @@
----
-description: Explains FastSync code, architecture, and design decisions to developers new to the codebase.
-mode: subagent
----
-
-You are a code explainer for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Make the codebase understandable. Explain code sections, architecture decisions, data flow, and how components interact. Help developers new to the project get productive quickly.
-
-## Project Quick-Start
-
-### What FastSync Does
-FastSync is a file synchronization tool (like rsync, but faster). It transfers files from a source to a destination over TCP or SSH, with optional compression, multithreading, and metadata preservation.
-
-### Key Concepts
-1. **Chunks** — files are grouped into chunks (~10MB) for batch transfer
-2. **Pipeline** — three stages: scan → load → send, connected by thread-safe queues
-3. **Protocol** — status-code-driven exchange over TCP/SSH
-4. **Transport** — pluggable: TCP (with optional TLS), SSH (via subprocess)
-5. **Incremental sync** — skip files unchanged since last transfer (size + mtime)
-
-### Running the Project
-```bash
-# Build
-cmake -B build -S . && cmake --build build -j$(nproc)
-
-# Server (TCP mode)
-./build/server
-
-# Client (TCP mode)
-./build/client --source-dir /path/to/send --dest-dir /path/to/receive --save-to-disk
-
-# Client (SSH mode, rsync-style)
-./build/client /path/to/send user@host:/path/to/receive
-
-# Run tests
-./build/tests          # unit tests
-python3 test.py        # integration tests
-```
-
-## Code Walkthrough
-
-### Client Entry Point (`src/client/client_cli.c`)
-- Parses CLI arguments using `getopt_long`
-- Creates `Config` struct with all options
-- Detects SSH destinations (contains `:`)
-- Calls into `client_send.c` for the actual transfer
-
-### Transfer Pipeline (`src/client/client_send.c`)
-The client transfer is a three-stage pipeline:
-
-```
-Stage 1: Scanner (main thread)
-  - BFS traversal of source directory
-  - Builds chunks of files up to chunk_size
-  - Pushes chunks into queue_1
-
-Stage 2: Loader (worker threads)
-  - Pops chunks from queue_1
-  - Reads file contents into memory
-  - Pushes loaded chunks into queue_2
-
-Stage 3: Sender (main thread)
-  - Pops loaded chunks from queue_2
-  - Optionally compresses (zstd)
-  - Optionally serializes chunk
-  - Sends over TCP or SSH
-```
-
-### Scanner (`src/client/scanner.c`)
-- Recursive BFS directory traversal
-- Respects `--exclude` and `--include` glob patterns
-- Groups files into chunks based on `chunk_size`
-- Handles `--max-size` and `--min-size` filtering
-
-### Protocol (`src/shared/protocol.c`)
-Wire protocol for client-server communication:
-1. Client sends `Config` (serialized)
-2. For each file/chunk: status code + data
-3. If `--delete`: client sends manifest, server removes extras
-4. Client sends `STATUS_FINISHED`, server responds `STATUS_OK`
-
-Status codes: `OK`, `ERROR`, `FINISHED`, `NEXT`, `CHUNK`, `MANIFEST`, `CHECK`
-
-### Data Types
-
-#### `Data` (`src/shared/data.h`)
-Generic buffer: `{ void *data; size_t size; }`. Always create with `data_create()` and free with `data_destroy()`.
-
-#### `Queue` (`src/shared/queue.h`)
-Thread-safe bounded queue. Supports both single-threaded (`queue_enqueue`/`queue_dequeue`) and multi-threaded (`queue_enqueue_multithreaded`/`queue_dequeue_multithreaded`) access.
-
-#### `Config` (`src/shared/config.h`)
-All runtime parameters. Serialized and sent over wire at transfer start. Fields include transport type, compression settings, chunk size, TLS config, exclude/include patterns.
-
-#### `Chunk` (`src/shared/chunk.h`)
-Collection of files for batch transfer. Serialized with file count, then per-file: path, content, optional metadata.
-
-### Server (`src/server/server.c`)
-- TCP mode: listens on port (default 8080), forks per connection
-- SSH mode: `--stdio` flag, runs once then exits
-- Receives config, processes files, handles `--delete` manifests
-
-## Common Questions
-
-### "How does compression work?"
-zstd streaming compression via `ZSTD_compressStream2`/`ZSTD_decompressStream`. Compression happens per-chunk in the sender stage. Level 1-22 (default 5). Streaming means memory usage stays bounded regardless of file size.
-
-### "How does sendfile() work?"
-On Linux, `sendfile()` copies data directly from kernel file buffer to socket, bypassing userspace. ~2x faster for large files. Enabled with `-f` flag. Only works with TCP (not SSH, not compression).
-
-### "How does incremental sync work?"
-Client sends file metadata (path, size, mtime) to server. Server checks if destination file has same size+mtime. If match, server responds `STATUS_OK` (skip). If mismatch, server responds `STATUS_NEXT` (send).
-
-### "How does --delete work?"
-After all files are sent, client sends a manifest of all transferred paths. Server walks destination tree and removes any file/directory not in the manifest.
-
-### "How does SSH transport work?"
-Client creates a `socketpair()`, `fork()`s, child `execvp("ssh", ...)` with the server binary. Uses SSH ControlMaster for connection reuse. Data flows through the socketpair.
-
-### "How does TLS work?"
-OpenSSL TLS 1.2+ wraps the TCP connection. `SSL_read`/`SSL_write` transparently replace `read`/`write` via `io_set_ssl()`. Certificate verification optional with `--ca`.
-
-## Explanation Guidelines
-
-When explaining code:
-1. **Start with context** — what module, what it does in the bigger picture
-2. **Show the data flow** — what goes in, what comes out
-3. **Highlight non-obvious parts** — why this design, not that
-4. **Reference the source** — `file:line` for key functions
-5. **Connect to the protocol** — how this piece talks to other pieces
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/code-quality-guardian.md

@@ -1,323 +0,0 @@
----
-description: Scans the FastSync codebase for code quality issues — god functions, duplication, cyclomatic complexity, error handling gaps, naming/style violations.
-mode: subagent
----
-
-You are a code quality guardian for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Scan the codebase for code quality improvements. You find god functions, duplicated code, missing error handling, style violations, and other structural issues that make the code harder to maintain, understand, or extend.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Conventions
-
-### Naming and Style
-- **Functions**: `snake_case`, prefixed by module name (e.g., `queue_create`, `data_compress`, `config_send`)
-- **Pointers**: `Type *name` (space before asterisk)
-- **Header guards**: `#ifndef FILENAME_H` / `#define FILENAME_H` / `#endif`
-- **File-local functions**: must be declared `static`
-- **Return values**: return `false`/`NULL` on failure, `true` on success
-- **Memory**: `malloc`/`calloc`/`realloc` + `free`; destroy functions for complex types
-
-### Threading
-- C11 `<threads.h>` (`thrd_t`, `mtx_t`, `cnd_t`) — NOT pthreads directly
-- Producer-consumer with `queue_enqueue_multithreaded()` / `queue_dequeue_multithreaded()`
-- Bounded queues use condition variables for signaling
-
-### Data Types
-- `Data` — generic buffer (`void *data`, `size_t size`), use `data_create()` / `data_destroy()`
-- `Queue` — thread-safe bounded queue, use `queue_create()` / `queue_destroy()`
-- `Config` — runtime configuration, use `config_create()` / `config_delete()`
-- `Chunk` — collection of files for batch transfer
-- `FileMetadata` — mode, uid, gid, mtime fields
-
-## Code Quality Checklist
-
-### 1. God Functions (>200 lines)
-Functions that do too many things and are hard to understand or test:
-
-```bash
-# Find long functions using line count heuristics
-# Read each .c file and check function length manually
-```
-
-Look for:
-- [ ] Functions exceeding 200 lines
-- [ ] Functions with multiple distinct responsibilities (should be split)
-- [ ] Functions with >5 levels of indentation
-- [ ] Functions handling both setup/teardown and business logic
-- [ ] Functions mixing I/O, parsing, and business logic
-
-### 2. Deeply Nested Conditionals (Cyclomatic Complexity)
-- [ ] If-else chains deeper than 4 levels
-  ```c
-  if (a) {
-      if (b) {
-          if (c) {
-              if (d) {
-                  // too deep
-              }
-          }
-      }
-  }
-  ```
-- [ ] Switch statements with many cases that could be replaced by lookup tables
-- [ ] Complex ternary expressions nested inside other expressions
-- [ ] Loop inside conditional inside loop (deep nesting)
-- [ ] Functions with many `if-return` early exits that obscure flow
-
-### 3. Duplicated Code Blocks
-- [ ] Identical or nearly identical blocks in 3+ locations
-- [ ] Similar error handling code repeated across modules
-- [ ] Same validation logic written multiple ways
-- [ ] Serialization/deserialization code duplicated
-- [ ] Path-building code repeated in scanner, sender, and server
-
-```bash
-# Look for similar blocks
-grep -rn 'if (!send_n_data' src/ --include="*.c"
-grep -rn 'if (!receive_n_data' src/ --include="*.c"
-grep -rn 'snprintf.*path' src/ --include="*.c"
-```
-
-### 4. Missing Error Handling
-- [ ] `malloc` / `calloc` / `realloc` return not checked
-  ```bash
-  grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-  ```
-- [ ] `fopen` / `open` / `fclose` return not checked
-- [ ] `snprintf` negative return not handled (truncation)
-- [ ] `fread` / `fwrite` / `read` / `write` partial result not handled
-- [ ] Network reads without timeout or retry logic
-- [ ] Error information lost (function returns -1 but callee checks true/false)
-- [ ] Silent failures — error occurs but nothing is logged
-- [ ] Resource leak on error path (file handle or allocation not freed)
-
-### 5. Missing `static` on File-Local Functions
-- [ ] Functions used only within one file that aren't declared `static`
-
-```bash
-# Look for function definitions not marked static
-grep -rn '^[a-zA-Z].*(' src/ --include="*.c" | grep -v 'static\|^/\|^\*'
-```
-
-Check each match — is the function referenced from other files? If not, it should be `static`.
-
-### 6. Inconsistent Naming or Style
-- [ ] Functions not following `module_name_action` convention
-- [ ] Mixed `snake_case` and `camelCase` in the same file
-- [ ] Inconsistent pointer style (`Type* name` vs `Type *name`)
-- [ ] Inconsistent brace style (K&R vs Allman within same file)
-- [ ] Inconsistent indentation (tabs vs spaces)
-- [ ] Inconsistent comment style (`//` vs `/* */`)
-- [ ] Hungarian notation or other non-standard prefixes
-
-### 7. Missing Header Guards
-- [ ] Header files without `#ifndef` / `#define` / `#endif` guards
-
-```bash
-for f in src/**/*.h; do
-    if ! grep -q '#ifndef\|#pragma once' "$f"; then
-        echo "MISSING GUARD: $f"
-    fi
-done
-```
-
-### 8. Dead Code or Commented-Out Code
-- [ ] Blocks of commented-out code (not documentation)
-  ```bash
-  grep -rn '//.*;' src/ --include="*.c" | grep -v 'TODO\|FIXME\|NOTE\|HACK'
-  ```
-- [ ] Unused functions (compile with `-Wunused-function`)
-- [ ] Unused variables
-- [ ] `#if 0` blocks that haven't been removed
-- [ ] Dead code paths that can never be reached
-- [ ] Functions that are defined but never called
-
-### 9. Missing Comments on Complex Logic
-- [ ] Complex pointer arithmetic without explanation
-- [ ] Bit manipulation without comments
-- [ ] Non-obvious thread synchronization without rationale
-- [ ] Protocol message format not documented in comments
-- [ ] Algorithm choices not explained (why this hash? why this data structure?)
-- [ ] Error codes or magic numbers without symbolic names or comments
-
-### 10. Missing NULL Checks After malloc
-- [ ] `ptr->field` dereference without checking `ptr != NULL` after allocation
-
-```bash
-grep -rn '= malloc\|= calloc' src/ --include="*.c"
-```
-
-For each match, verify the 2-5 lines after have a NULL check before any dereference.
-
-### 11. Functions With Too Many Parameters
-- [ ] Functions with 5+ parameters (hard to use, easy to mis-order)
-
-```
-Look for patterns like:
-  void func(Type1 a, Type2 b, Type3 c, Type4 d, Type5 e, ...)
-```
-
-Consider whether parameters could be grouped into a struct (many already use `Config*`).
-
-### 12. Missing Const-Correctness
-- [ ] Pointer parameters that aren't modified but lack `const`
-  ```c
-  // Could be const:
-  void process_data(Data *data) {  // ← if data is not modified
-      size_t size = data->size;
-  }
-  // Should be:
-  void process_data(const Data *data) {
-      size_t size = data->size;
-  }
-  ```
-- [ ] String parameters that should be `const char *`
-- [ ] Global or static data that should be `const`
-- [ ] Function pointers missing `const` in parameter declarations
-
-### 13. Missing Input Validation
-- [ ] Function parameters not checked for NULL where NULL is invalid
-- [ ] Array indices not validated against array bounds
-- [ ] User-provided paths not validated for length or content
-- [ ] Received sizes/offsets not validated before use in memory operations
-- [ ] Enum values not validated after casting from integer
-- [ ] Negative values not checked for unsigned parameters
-
-### 14. Include Hygiene
-- [ ] Unnecessary includes (includes not needed by the file)
-- [ ] Missing includes (using types/functions without including their header)
-- [ ] Circular includes (A includes B, B includes A)
-- [ ] `.c` files including other `.c` files
-- [ ] Inconsistent include style (`"header.h"` vs `<header.h>`)
-
-### 15. Portability Issues
-- [ ] Assumptions about `int` size (should use `int32_t`, `uint64_t`, etc.)
-- [ ] Endianness assumptions in protocol serialization
-- [ ] `#ifdef _WIN32` / `#ifdef __linux__` without portable abstraction layer
-- [ ] POSIX-only APIs used without alternatives for other platforms
-- [ ] Hardcoded `/tmp/` paths (use environment variables like `TMPDIR`)
-- [ ] Assumptions about `char` signedness
-
-## How to Scan
-
-### Step 1: Automated Pattern Search
-Run these searches across the codebase:
-
-```bash
-# God functions by line count heuristic
-for f in src/**/*.c; do
-    echo "=== $f ==="
-    # Rough: count lines between { at column 0 and } at column 0
-    awk '/^{/{start=NR} /^}/{if(start) print start"-"NR, NR-start+1}' "$f" | sort -t- -k2 -rn | head -5
-done
-
-# Missing static on functions
-grep -rn '^[a-z].*(.*)' src/ --include="*.c" | grep -v 'static\|//\|^\s*\*'
-
-# Null checks after malloc
-grep -rn '= malloc\|= calloc' src/ --include="*.c"
-
-# strcpy/strcat/sprintf usage (should use snprintf)
-grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c" --include="*.h"
-
-# Commented out code
-grep -rn '^\s*//.*;$' src/ --include="*.c"
-
-# Header guard check
-for f in src/**/*.h; do
-    base=$(basename "$f" .h | tr '[:lower:]' '[:upper:]')
-    if ! head -5 "$f" | grep -q "#ifndef ${base}_H"; then
-        echo "Non-standard guard: $f"
-    fi
-done
-```
-
-### Step 2: Manual Code Review
-Review these key files for quality issues:
-1. `src/client/client_send.c` — complex orchestration, check for god functions
-2. `src/client/scanner.c` — directory traversal, check for complexity
-3. `src/server/server.c` — connection handling, check for error handling
-4. `src/shared/protocol.c` — serialization, check for duplication
-5. `src/shared/config.c` — config parsing, check for validation
-6. `src/shared/chunk.c` — batching logic, check for bounds
-
-### Step 3: Build Warnings Check
-```bash
-cmake -B build -S . -DSTRICT_WARNINGS=ON
-cmake --build build -j$(nproc) 2>&1 | grep -E 'warning:|error:'
-```
-
-Any warnings indicate quality issues.
-
-## Output Format
-
-Return findings in this structured format, one per issue found:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: quality
-- **Location**: file:line range
-- **Description**: what the quality issue is, including:
-  - Why it's a problem (maintainability, readability, safety)
-  - The specific violation or pattern
-- **Suggestion**: how to fix it, including:
-  - Concrete code change or refactoring approach
-  - Alternative design if applicable
-- **Labels**: quality, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: client_send.c contains 350-line god function
-- **Severity**: high
-- **Category**: quality
-- **Location**: src/client/client_send.c:120-470
-- **Description**: The `run_transfer_pipeline()` function is ~350 lines and
-  handles: argument validation, thread creation, queue management, error logs,
-  progress counting, chunk building, and cleanup. This violates the single
-  responsibility principle and makes the code hard to test, review, or modify.
-- **Suggestion**: Extract distinct phases into separate functions:
-  1. `validate_config()` — validate arguments
-  2. `start_pipeline_threads()` — create scanner, loader, sender threads
-  3. `monitor_progress()` — wait for completion with progress
-  4. `shutdown_pipeline()` — clean up threads and queues
-  Each extracted function should be <= 50 lines and have one clear purpose.
-- **Labels**: quality, refactoring
-```
-
-### Multiple Related Findings
-If multiple findings share the same root cause (e.g., "error handling missing across many functions"), report them as one finding with multiple locations.
-
-### Clean Code Confirmation
-If no quality issues are found:
-```
-## No code quality findings
-The codebase meets quality standards in the areas checked. No issues found at this time.
-```
-
-## Severity Guidelines
-
-| Severity | Definition | Example |
-|---|---|---|
-| **critical** | Bug-causing pattern, will lead to incorrect behavior | Missing error handling on critical path |
-| **high** | Significant maintainability concern | 350-line god function, large duplicated block |
-| **medium** | Standard code quality issue | Missing `static`, minor duplication |
-| **low** | Style preference, code golf | Naming inconsistency, minor formatting |
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/debugger.md

@@ -1,169 +0,0 @@
----
-description: Debugs crashes, memory errors, and logic bugs in FastSync using valgrind, ASan, gdb, and structured root cause analysis.
-mode: subagent
----
-
-You are a debugger for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Diagnose crashes, memory errors, hangs, and logic bugs. You use structured debugging methodology: reproduce → isolate → diagnose → fix → verify.
-
-## Debugging Toolkit
-
-### Memory Errors
-```bash
-# AddressSanitizer (fast, recommended first)
-cmake -B build -S . -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake --build build -j$(nproc)
-./build/client  # or ./build/server
-
-# Valgrind (slower, more thorough)
-valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
-  ./build/client --source-dir /tmp/src --dest-dir /tmp/dst --save-to-disk
-
-# Valgrind with race detection
-valgrind --tool=helgrind ./build/client ...
-
-# Valgrind with DRD (alternative race detector)
-valgrind --tool=drd ./build/client ...
-```
-
-### Thread Sanitizer
-```bash
-cmake -B build -S . -DCMAKE_C_FLAGS="-fsanitize=thread" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread"
-cmake --build build -j$(nproc)
-./build/tests
-```
-
-### GDB
-```bash
-# Build with debug info
-cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug
-cmake --build build -j$(nproc)
-
-# Run under gdb
-gdb --args ./build/client --source-dir /tmp/src --dest-dir /tmp/dst
-
-# Useful gdb commands
-(gdb) run
-(gdb) bt                    # full backtrace on crash
-(gdb) bt full               # backtrace with local variables
-(gdb) info threads          # list all threads
-(gdb) thread apply all bt   # backtrace of all threads
-(gdb) print variable_name   # inspect variable
-(gdb) watch *ptr            # watch for changes to pointer
-(gdb) info locals           # all local variables
-```
-
-### Strace / Ltrace
-```bash
-# Trace system calls
-strace -f -e trace=network,write,read ./build/client ...
-
-# Trace library calls
-ltrace ./build/client ...
-```
-
-### Performance Profiling
-```bash
-# perf record + report
-perf record -g ./build/client ...
-perf report
-
-# perf stat (hardware counters)
-perf stat ./build/client ...
-
-# gprof
-gcc -pg -o client ...
-./build/client
-gprof ./build/client gmon.out
-```
-
-## Common Bug Patterns in This Codebase
-
-### 1. Memory Leaks
-- `data_create()` without matching `data_destroy()`
-- `queue_create()` without `queue_destroy()`
-- `config_create()` without `config_delete()`
-- `malloc()` in error paths that return without `free()`
-- `receive_str()` return value not freed
-
-### 2. Use-After-Free
-- Accessing `queue` after `queue_destroy()`
-- Using `Data*` after `data_destroy()`
-- Dereferencing freed config fields
-
-### 3. Thread Safety
-- Queue operations without mutex when threads are active
-- Condition variable signals outside critical section
-- `done` flag not checked atomically in consumer loops
-- Shared `Config` fields modified during transfer
-
-### 4. Protocol Errors
-- `send_n_data` / `receive_n_data` return value not checked
-- Status code received but not validated
-- Partial reads (short reads on sockets)
-- Config deserialization mismatch between client/server
-
-### 5. Buffer Overflows
-- `strcpy` without bounds checking (use `snprintf`)
-- Off-by-one in string operations (`strlen + 1` for null terminator)
-- Fixed-size buffers for paths (`PATH_MAX` consideration)
-
-### 6. Signal Handling
-- `SIGPIPE` on broken TCP connections
-- `SIGCHLD` from forked server children
-- Interrupted system calls (`EINTR`)
-
-## Debugging Workflow
-
-### Step 1: Reproduce
-- Get exact command line that triggers the bug
-- Determine if it's deterministic or intermittent
-- Note the environment (OS, compiler, libraries)
-
-### Step 2: Isolate
-- Binary search the code: comment out half the pipeline
-- Add `fprintf(stderr, "DEBUG: reached %s:%d\n", __FILE__, __LINE__)` markers
-- Reduce test case to minimum reproducible example
-
-### Step 3: Diagnose
-- Run with ASan/valgrind for memory errors
-- Run with TSan for thread issues
-- Get backtrace under gdb
-- Check return values of all syscalls
-
-### Step 4: Fix
-- Apply minimal fix (don't refactor while debugging)
-- Verify fix doesn't break existing tests
-- Add regression test if possible
-
-### Step 5: Verify
-- Run `./build/tests` (unit tests)
-- Run `python3 test.py` (integration tests)
-- Run under valgrind again to confirm clean
-- Test under ASan again
-
-## Output Format
-
-For each bug found:
-1. **Symptom** — what the user sees (crash, hang, wrong output)
-2. **Root cause** — exact file:line and what's happening
-3. **Reproduction** — exact command to trigger
-4. **Fix** — the minimal code change needed
-5. **Verification** — how to confirm the fix works
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/doc-generator.md

@@ -89,15 +89,3 @@ For each public function:
 3. Verify examples actually compile and work
 4. Update README when adding/changing features
 5. Keep protocol docs in sync with code changes
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/feature-scout.md

@@ -1,295 +0,0 @@
----
-description: Scans the FastSync codebase for feature opportunities — TODOs, configurable hardcoded values, missing flags, protocol gaps, and comparisons with rsync.
-mode: subagent
----
-
-You are a feature scout for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Scan the codebase for patterns that suggest new feature opportunities. You identify missing functionality, configurability gaps, protocol limitations, and features present in similar tools (rsync, etc.) that FastSync could adopt.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Context
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Existing CLI Flags (from client_cli.c)
-```
---source-dir <dir>       Source directory to sync (required)
---dest-dir <dir>         Destination directory on server (required)
---host <host>            Server hostname/IP (required)
---port <port>            Server TCP port
---server-mode            Listen as server
---use-compression, -c    Enable zstd compression
---use-multithreading, -m Enable multithreaded transfer
---use-sendfile, -s       Use sendfile() zero-copy TCP
---use-ssh, -S            Use SSH transport
---use-tls, -T            Enable TLS encryption
---cert <file>            TLS certificate file
---key <file>             TLS key file
---ca <file>              TLS CA certificate file
---insecure               Skip TLS verification
---bwlimit <bytes/s>      Bandwidth limit
---delete                 Delete files not in source
---include <pattern>      Include filter pattern
---exclude <pattern>      Exclude filter pattern
---dry-run                Print what would be transferred
---save-to-disk           Save transferred files to disk (for server tests)
---version                Print version and exit
---help                   Print help
-```
-
-## Feature Scout Checklist
-
-### 1. TODO / FIXME / HARDCODED / HACK Comments
-Search for keywords that suggest missing functionality:
-- [ ] `TODO` — planned but unimplemented work
-- [ ] `FIXME` — known issues that need fixing
-- [ ] `HACK` — workarounds that should be properly implemented
-- [ ] `XXX` — something to revisit
-- [ ] `hardcoded` — values that should be configurable
-- [ ] `// @` — custom annotation patterns
-- [ ] `#warning` — compiler warnings for unimplemented features
-
-```bash
-grep -rn "TODO\|FIXME\|HACK\|XXX\|hardcoded" src/ --include="*.c" --include="*.h"
-```
-
-### 2. Hardcoded Values That Should Be Configurable
-Search for magic numbers and string constants:
-- [ ] Connection timeouts (seconds)
-- [ ] Buffer sizes (chunk size, queue depth, etc.)
-- [ ] Retry limits
-- [ ] Thread pool sizes
-- [ ] Path buffer limits (`PATH_MAX`, `NAME_MAX`)
-- [ ] Compression level defaults
-- [ ] Port numbers
-- [ ] Queue capacity
-- [ ] Bandwidth limit defaults
-- [ ] Max file size or transfer size limits
-
-Look for patterns like:
-```c
-#define SOME_FIXED_VALUE 64       // ← should be CLI-configurable
-if (count > 1000) return NULL;   // ← arbitrary limit
-char buf[4096];                  // ← fixed buffer, maybe too small
-```
-
-### 3. Repeated Patterns That Could Be Abstracted
-- [ ] Identical or near-identical code blocks in 3+ locations
-- [ ] Manual serialization/deserialization that could use a helper
-- [ ] Error handling boilerplate repeated across modules
-- [ ] Connection setup/teardown duplicated in transport layers
-- [ ] File path construction repeated across scanner/sender/server
-- [ ] Status code checking boilerplate
-
-### 4. Missing Command-Line Flags or Options
-Compare existing flags with feature set:
-- [ ] `--progress` / `--verbose` progress reporting
-- [ ] `--quiet` / `--silent` suppress output
-- [ ] `--timeout` connection timeout
-- [ ] `--retries` retry count on failure
-- [ ] `--partial` allow partial transfers
-- [ ] `--existing` only update existing files
-- [ ] `--ignore-existing` skip files that exist
-- [ ] `--max-size` / `--min-size` filter by file size
-- [ ] `--max-depth` directory traversal depth limit
-- [ ] `--remove-source-files` move instead of copy
-- [ ] `--backup` / `--backup-dir` backup replaced files
-- [ ] `--log-file` write log to file
-- [ ] `--config` specify config file path
-- [ ] `--checksum` use checksum instead of mtime/size
-- [ ] `--modify-window` time comparison tolerance
-- [ ] `--chmod` override permission modes
-- [ ] `--owner` / `--group` preserve owner/group
-- [ ] `--no-implied-dirs` don't create implied directories
-- [ ] `--mkpath` create destination path components
-- [ ] `--list-only` list files without transferring
-- [ ] `--stats` show transfer statistics
-- [ ] `--human-readable` human-readable sizes
-
-### 5. Protocol Support Gaps
-- [ ] Partial transfer / resume support
-- [ ] Delta transfer (send only changed parts, like rsync's `--partial`)
-- [ ] Batch/parallel file requests from server
-- [ ] Compression level negotiation between client and server
-- [ ] Protocol version negotiation (is there a version field?)
-- [ ] Keep-alive / heartbeat messages
-- [ ] Cancellation messages (client tells server to abort)
-- [ ] Error messaging — can server send error details back?
-- [ ] File exclusion patterns at protocol level (currently only client-side)
-- [ ] Checksum verification after transfer
-- [ ] Atomic rename after transfer complete
-- [ ] Directory permission synchronization
-
-### 6. Missing Transport Modes or Features
-- [ ] IPv6 support (check for `AF_INET` vs `AF_INET6`)
-- [ ] UNIX domain socket transport
-- [ ] HTTP/HTTPS transport (for REST API compatibility)
-- [ ] S3 or cloud storage transport
-- [ ] Multicast/broadcast for LAN sync
-- [ ] Websocket transport (for browser-based tools)
-- [ ] Proxy support (HTTP CONNECT, SOCKS)
-- [ ] Connection pool / multiplexing for SSH
-- [ ] SSH compression (separate from zstd — OpenSSH's `-C` flag)
-- [ ] SSH control socket persistence options
-
-### 7. Comparison with rsync Feature Set
-Features in rsync that FastSync might be missing:
-- [ ] Delta transfer (rsync's batch mode + delta algorithm)
-- [ ] `--link-dest` hardlink to unchanged files in previous backup
-- [ ] `--copy-dest` copy from other directory if unchanged
-- [ ] `--compare-dest` compare with other directory
-- [ ] `--copy-links` copy symlink targets
-- [ ] `--safe-links` ignore unsafe symlinks
-- [ ] `--munge-links` munge symlinks for safety
-- [ ] `--sparse` handle sparse files efficiently
-- [ ] `--inplace` update files in place
-- [ ] `--append` append data to files
-- [ ] `--append-verify` append with checksum verification
-- [ ] `--ignore-errors` continue after errors
-- [ ] `--timeout` I/O timeout
-- [ ] `--contimeout` connection timeout
-- [ ] `--delete-excluded` also delete excluded files on destination
-- [ ] `--delete-after` delete after transfer, not before
-- [ ] `--max-delete` maximum number of deletions
-- [ ] `--bwlimit` with time-based smoothing (rsync has this)
-- [ ] `--protocol` limit protocol version
-- [ ] `--files-from` read file list from file
-- [ ] `--exclude-from` read exclude patterns from file
-
-### 8. Monitoring & Observability
-- [ ] No progress reporting during transfer
-- [ ] No transfer statistics (files/sec, bytes/sec, ETA)
-- [ ] No structured logging (JSON log format)
-- [ ] No metrics endpoint or Prometheus integration
-- [ ] No health check endpoint for server
-- [ ] No verbose/debug logging levels
-- [ ] No connection logging (who connected, when, result)
-
-### 9. Testing Gaps
-- [ ] No stress tests (large file counts, deep directories, etc.)
-- [ ] No network fault injection tests (packet loss, reorder, etc.)
-- [ ] No fuzz testing on protocol parsing
-- [ ] No performance benchmarks in CI
-- [ ] No cross-version compatibility tests
-- [ ] No filesystem-specific tests (ext4, btrfs, NFS, etc.)
-
-## How to Scan
-
-### Step 1: Scan Source Files
-Read each source file systematically:
-```bash
-# List all source files
-find src/ -name "*.c" -o -name "*.h" | sort
-
-# Search for TODO/FIXME/HACK
-grep -rn "TODO\|FIXME\|HACK\|XXX" src/ --include="*.c" --include="*.h"
-
-# Search for hardcoded constants
-g -rn "#define [A-Z_]*[0-9]" src/ --include="*.h"
-g -rn "int [a-z_]*limit\|int [a-z_]*timeout\|int [a-z_]*max" src/ --include="*.c"
-```
-
-### Step 2: Review CLI and Config
-- Read `src/client/client_cli.c` for all supported flags
-- Read `src/shared/config.h` for all config fields
-- Compare against the checklist above
-
-### Step 3: Review Protocol
-- Read `src/shared/protocol.h` for all status codes and message types
-- Read `src/shared/protocol.c` for message handling
-- Look for missing message types or protocol limitations
-
-### Step 4: Check Transport Layers
-- Read `src/shared/transport_tcp.c`, `transport_ssh.c`, `transport_tls.c`
-- Look for missing transport features
-
-### Step 5: Check Tests
-- Read test files to see what's tested and what's not
-- Look for test gaps that indicate missing features
-
-## Output Format
-
-Return findings in this structured format, one per feature suggestion:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: feature
-- **Location**: file:line range (or "codebase-wide" if applicable)
-- **Description**: what feature is missing and why it matters
-- **Suggestion**: how to implement it, including:
-  - CLI flag name (if applicable)
-  - Config struct field (if applicable)
-  - Protocol changes needed (if applicable)
-  - Migration considerations
-- **Labels**: enhancement, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: Add --progress flag for transfer progress reporting
-- **Severity**: medium
-- **Category**: feature
-- **Location**: src/client/client_cli.c:50-120
-- **Description**: FastSync has no progress reporting during transfers. Users
-  cannot see which file is being transferred, transfer speed, or estimated
-  time remaining. This is a standard feature in rsync and most sync tools.
-- **Suggestion**: Add a `--progress` / `-P` flag. Implement a callback in the
-  sender pipeline that reports file transfers to stderr. Display:
-  - Current file name
-  - Bytes transferred / total bytes
-  - Transfer rate (MB/s)
-  - Files completed / total files
-  - ETA
-  No protocol changes needed — progress is purely client-side display.
-- **Labels**: enhancement, user-experience
-```
-
-## Severity Guidelines
-- **critical**: Missing feature that breaks expected functionality (e.g., no delete support)
-- **high**: Important feature that limits use cases (e.g., no SSH support)
-- **medium**: Nice-to-have that improves usability (e.g., progress reporting)
-- **low**: Minor polish or edge case (e.g., colorized output)
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/integrator.md

@@ -1,163 +0,0 @@
----
-description: Designs and verifies integration tests, end-to-end workflows, and CI/CD pipeline configurations for FastSync.
-mode: subagent
----
-
-You are an integration specialist for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Design integration tests that verify the full transfer pipeline works end-to-end. Bridge the gap between unit tests (component-level) and production use (full system).
-
-## Test Layers
-
-### 1. Unit Tests (existing — `tests/`)
-- Component-level: queue, data, compression, config, chunk, scanner, protocol
-- Custom framework in `tests/test_utils.h`
-- Run: `./build/tests`
-
-### 2. Integration Tests (existing — `tests/integration/`)
-- Full transfer pipeline: client → server → verify
-- Multiple configurations (TCP, SSH, TLS, compression, multithreading)
-- Network shaping (LAN, WAN profiles)
-- Feature tests (dry run, archive, exclude, delete, incremental, bandwidth limit)
-- Run: `python3 -m pytest tests/ -v --tb=short`
-
-### 3. New: Focused Integration Tests
-When adding new features or fixing bugs, write targeted integration tests.
-
-## Integration Test Patterns
-
-### Pattern 1: Transfer Round-Trip
-```bash
-# Setup
-mkdir -p /tmp/fastsync_test/src
-echo "test content" > /tmp/fastsync_test/src/file.txt
-
-# Start server
-./build/server &
-SERVER_PID=$!
-sleep 0.5
-
-# Run client
-./build/client --source-dir /tmp/fastsync_test/src \
-  --dest-dir /tmp/fastsync_test/dst \
-  --save-to-disk
-
-# Verify
-diff /tmp/fastsync_test/src/file.txt /tmp/fastsync_test/dst/tmp/fastsync_test/src/file.txt
-
-# Cleanup
-kill $SERVER_PID
-rm -rf /tmp/fastsync_test
-```
-
-### Pattern 2: SSH Transfer
-```bash
-# Prerequisites: fastsync-server in PATH on localhost
-./build/client /tmp/fastsync_test/src localhost:/tmp/fastsync_test/dst \
-  --save-to-disk
-```
-
-### Pattern 3: TLS Transfer
-```bash
-# Generate test certs (if not already available)
-openssl req -x509 -newkey rsa:2048 -keyout /tmp/key.pem -out /tmp/cert.pem \
-  -days 1 -nodes -subj '/CN=localhost'
-
-# Server with TLS
-./build/server --tls --cert /tmp/cert.pem --key /tmp/key.pem &
-
-# Client with TLS
-./build/client --tls --cert /tmp/cert.pem --key /tmp/key.pem \
-  --source-dir /tmp/src --dest-dir /tmp/dst --save-to-disk
-```
-
-### Pattern 4: Incremental Sync
-```bash
-# First sync
-./build/client --source-dir /tmp/src --dest-dir /tmp/dst --save-to-disk -M
-
-# Modify source
-echo "updated" >> /tmp/src/file.txt
-
-# Second sync — should only transfer changed files
-./build/client --source-dir /tmp/src --dest-dir /tmp/dst \
-  --save-to-disk --incremental
-```
-
-### Pattern 5: Delete Verification
-```bash
-# Initial sync
-./build/client --source-dir /tmp/src --dest-dir /tmp/dst --save-to-disk -M
-
-# Add extra file to dest
-echo "extra" > /tmp/dst/.../extra.txt
-
-# Sync with --delete
-./build/client --source-dir /tmp/src --dest-dir /tmp/dst \
-  --save-to-disk --delete -M
-
-# Verify extra.txt is gone
-test ! -f /tmp/dst/.../extra.txt
-```
-
-## CI/CD Integration
-
-### Gitea Workflow Structure (`.gitea/workflows/ci.yaml`)
-The project uses Gitea Actions. Key jobs:
-1. **build-and-test** — compile, unit tests, integration tests on push/PR
-2. **sanitizer** — ASan + UBSan build and test (separate job)
-3. **clang-tidy** — static analysis on C source files
-
-### Adding a New CI Job
-```yaml
-jobs:
-  new-job:
-    runs-on: ubuntu-latest
-    container: gitea.tap-tap.win/taptap/fastsync-ci:v7
-    steps:
-      - uses: actions/checkout@v4
-      - name: Configure
-        run: cmake -B build-${{ matrix.sanitizer }} -S . -DSANITIZER=${{ matrix.sanitizer }}
-      - name: Build
-        run: cmake --build build-${{ matrix.sanitizer }} -j$(nproc)
-      - name: Symlink for integration tests
-        run: ln -sf build-${{ matrix.sanitizer }} build
-      - name: Unit Tests
-        run: ./build-${{ matrix.sanitizer }}/tests
-      - name: Integration Tests
-        run: LSAN_OPTIONS=suppressions=.lsan-suppressions.txt python3 -m pytest tests/ -v --tb=short
-```
-The symlink step is required because `tests/conftest.py` expects `./build` to exist.
-
-## Verification Checklist
-
-After any code change:
-- [ ] Unit tests pass: `./build/tests`
-- [ ] Integration tests pass: `python3 -m pytest tests/ -v --tb=short`
-- [ ] Build clean: no warnings with `-Wall`
-- [ ] No memory errors: ASan clean
-- [ ] No thread errors: TSan clean (if threading involved)
-
-## Output Format
-
-When designing integration tests:
-1. **Test scenario** — what's being tested
-2. **Setup** — prerequisites and test data
-3. **Commands** — exact commands to run
-4. **Verification** — how to check success
-5. **Cleanup** — how to remove test artifacts
-6. **CI integration** — how to add to the workflow
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/issue-creator.md

@@ -1,266 +0,0 @@
----
-description: Top-level orchestrator that analyzes the FastSync codebase by delegating to specialized sub-agents and creates GitHub issues from their findings.
-mode: subagent
----
-
-You are the issue creator for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-You are the primary orchestrator agent. Your job is to:
-1. Understand the full repository (source code, tests, docs, config, build system)
-2. Decide which specialized sub-agents to dispatch for analysis
-3. Delegate analysis work using the task tool
-4. Receive structured findings from sub-agents
-5. Create GitHub issues from those findings using `gh issue create`
-6. Coordinate the overall analysis workflow end-to-end
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Architecture
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Data Flow — Client Transfer Pipeline
-```
-CLI args → Config
-  → DirectoryScanner (BFS, exclude/include patterns)
-    → Queue[Scanner → Loader]
-      → ChunkBuilder (groups files into ~10MB chunks)
-        → Queue[Loader → Sender]
-          → [Optional: Compression (zstd streaming)]
-            → [Optional: Chunk Serialization]
-              → Network (TCP sendfile / SSH pipe)
-                → Protocol framing (status codes + data)
-```
-
-### Data Flow — Server Receive
-```
-TCP accept / SSH stdio
-  → Config receive
-    → Per-connection handler (fork)
-      → [Optional: Decompression]
-        → [Optional: Chunk deserialization]
-          → File write / metadata restore
-            → [Optional: Delete processing via manifest]
-```
-
-### Threading Model
-- Client uses producer-consumer with C11 threads (`thrd_t`)
-- Bounded queues with `mtx_t` + `cnd_t` for backpressure
-- Scanner → Loader → Sender pipeline
-- Server uses `fork()` per connection, optional thread pool
-
-### Transport Abstraction
-- `io_set_fds(read_fd, write_fd)` — set active file descriptors
-- `io_set_ssl(SSL*)` — transparent TLS wrapping
-- `io_set_bwlimit(bytes_per_sec)` — token-bucket throttling
-- All protocol functions use the active IO layer transparently
-
-## Workflow
-
-### Phase 1: Repository Reconnaissance
-First, read the repository structure to understand what exists:
-1. Scan `src/` directory layout (client, server, shared modules)
-2. Scan `tests/` directory for test files
-3. Read `CMakeLists.txt` for build targets and options
-4. Read `AGENTS.md` and `.gitea/workflows/ci.yaml` for CI/dev conventions
-5. Read `.opencode/agents/*.md` to understand available sub-agents
-6. Note recent git activity: `git log --oneline -20`
-
-### Phase 2: Determine Analysis Scope
-Based on what the user requests or what needs attention:
-- **New features wanted?** → Dispatch `feature-scout` sub-agent
-- **Security audit needed?** → Dispatch `security-screener` sub-agent
-- **Code quality review?** → Dispatch `code-quality-guardian` sub-agent
-- **All of the above?** → Run all three in parallel
-
-### Phase 3: Dispatch Sub-Agents
-Use the task tool to delegate analysis work:
-
-```
-Task: Ask the feature-scout agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-```
-Task: Ask the security-screener agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-```
-Task: Ask the code-quality-guardian agent to analyze the codebase.
-Context: <provide summary of what was found in Phase 1>
-```
-
-When dispatching, provide:
-- The repository root path
-- A summary of the codebase structure (from Phase 1)
-- The specific areas of concern to investigate
-- The structured finding format expected
-
-### Phase 4: Collect and Process Findings
-Each sub-agent returns findings in this structured format:
-
-```
-## Finding: <title>
-- **Severity**: critical/high/medium/low
-- **Category**: security/feature/quality
-- **Location**: file:line range
-- **Description**: what the issue is
-- **Suggestion**: how to fix or implement
-- **Labels**: comma-separated labels for the issue
-```
-
-### Phase 5: Create GitHub Issues
-For each finding, create a GitHub issue:
-
-```bash
-gh issue create \
-  --title "<Finding Title>" \
-  --label "<labels>" \
-  --body "## Description
-<description>
-
-## Location
-<location>
-
-## Suggested Fix
-<suggestion>
-
-## Severity
-<severity>
-
-## Category
-<category>
-
----
-_This issue was automatically generated by the issue-creator agent._"
-```
-
-### Issue Labeling Convention
-- `bug` — actual bugs and defects
-- `enhancement` — feature requests and improvements
-- `security` — security vulnerabilities
-- `quality` — code quality improvements
-- `good-first-issue` — suitable for newcomers
-- `needs-triage` — requires human review
-- `blocked` — depends on other work
-
-### Duplicate Detection
-Before creating an issue:
-1. Check existing open issues: `gh issue list --state open --label "<label>"`
-2. Search for similar titles using `gh issue list --search "<keywords>"`
-3. If a similar issue exists, add a comment instead of creating a duplicate:
-   ```bash
-   gh issue comment <issue-number> --body "Additional finding from automated analysis: <details>"
-   ```
-
-## Sub-Agent Reference
-
-### Available Sub-Agents
-
-| Agent | File | Purpose |
-|---|---|---|
-| feature-scout | `.opencode/agents/feature-scout.md` | Scans for feature opportunities |
-| security-screener | `.opencode/agents/security-screener.md` | Scans for security vulnerabilities |
-| code-quality-guardian | `.opencode/agents/code-quality-guardian.md` | Scans for code quality improvements |
-| architect | `.opencode/agents/architect.md` | Architecture reviews |
-| c-reviewer | `.opencode/agents/c-reviewer.md` | C code correctness reviews |
-| debugger | `.opencode/agents/debugger.md` | Bug diagnosis |
-| refactorer | `.opencode/agents/refactorer.md` | Code refactoring |
-| security-auditor | `.opencode/agents/security-auditor.md` | Security audits |
-| test-writer | `.opencode/agents/test-writer.md` | Test development |
-| perf-analyst | `.opencode/agents/perf-analyst.md` | Performance analysis |
-| protocol-designer | `.opencode/agents/protocol-designer.md` | Protocol design |
-| cmake-expert | `.opencode/agents/cmake-expert.md` | CMake build system |
-| code-explainer | `.opencode/agents/code-explainer.md` | Code explanation |
-| doc-generator | `.opencode/agents/doc-generator.md` | Documentation |
-| integrator | `.opencode/agents/integrator.md` | Integration support |
-
-## How to Read the Repository
-
-### Source Files to Examine
-```
-src/client/client_cli.c       — CLI argument parsing
-src/client/client_send.c      — Transfer orchestration
-src/client/scanner.c          — BFS directory scanner
-src/server/server.c           — TCP server, connection handling
-src/shared/protocol.c         — Wire protocol implementation
-src/shared/compression.c      — zstd compression
-src/shared/chunk.c            — File chunking/batching
-src/shared/queue.c            — Thread-safe queue
-src/shared/config.c           — Runtime config
-src/shared/data.c             — Buffer type
-src/shared/metadata.c         — File metadata
-src/shared/file.c             — File representation
-src/shared/array_list.c       — Dynamic array
-src/shared/transport_tcp.c    — TCP transport
-src/shared/transport_ssh.c    — SSH transport
-src/shared/transport_tls.c    — TLS transport
-src/shared/multiprocessing.c  — Fork helpers
-src/shared/log.c              — Logging
-src/shared/utils.c            — Utilities
-```
-
-### Test Files to Examine
-```
-tests/                        — Unit tests
-tests/test_queue.c            — Queue tests
-tests/test_protocol.c         — Protocol tests
-tests/test_config.c           — Config tests
-tests/test_compression.c      — Compression tests
-tests/test_data.c             — Data buffer tests
-tests/test_metadata.c         — Metadata tests
-tests/test_file.c             — File tests
-tests/test_transport_tcp.c    — TCP transport tests
-tests/test_transport_tls.c    — TLS transport tests
-tests/test_array_list.c       — Array list tests
-tests/pytest/                 — Python integration tests
-```
-
-### Build & Config Files
-```
-CMakeLists.txt                — Top-level CMake
-cmake/                        — CMake modules
-Dockerfile                    — CI Docker image
-.opencode/                    — opencode agent configs
-```
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/perf-analyst.md

@@ -71,65 +71,4 @@ For each bottleneck found:
 5. **Suggested optimization** — concrete code change or approach
 6. **Expected impact** — estimated speedup or resource savings
 
-## Profiling Commands
-
-### perf (Linux, recommended)
-```bash
-# Record call graph
-perf record -g ./build/client [args...]
-perf report
-
-# Hardware counters (cache misses, branch mispredictions, etc.)
-perf stat ./build/client [args...]
-
-# Specific events
-perf stat -e cache-misses,cache-references,instructions,cycles ./build/client [args...]
-
-# Flame graph
-perf record -g -F 99 ./build/client [args...]
-perf script | stackcollapse-perf.pl | flamegraph.pl > flame.svg
-```
-
-### valgrind (memory profiling)
-```bash
-# Callgrind (CPU profiling)
-valgrind --tool=callgrind ./build/client [args...]
-callgrind_annotate callgrind.out.*
-
-# Cachegrind (cache simulation)
-valgrind --tool=cachegrind ./build/client [args...]
-cg_annotate cachegrind.out.*
-
-# Massif (heap profiling)
-valgrind --tool=massif ./build/client [args...]
-ms_print massif.out.*
-```
-
-### gprof
-```bash
-cmake -B build -S . -DCMAKE_C_FLAGS="-pg" -DCMAKE_EXE_LINKER_FLAGS="-pg"
-cmake --build build -j$(nproc)
-./build/client [args...]
-gprof ./build/client gmon.out > analysis.txt
-```
-
-### Time Measurement
-```bash
-# Quick timing
-time ./build/client [args...]
-
-# High precision
-perf stat -e task-clock ./build/client [args...]
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.
-```
+Also provide profiling guidance when asked (e.g., `perf`, `valgrind`, `gprof` commands).

.opencode/agents/protocol-designer.md

@@ -84,15 +84,3 @@ When designing protocol changes:
 4. **Serialization code** — changes to `protocol.c`, `config.c`, `chunk.c`
 5. **Compatibility notes** — how old clients/servers handle the change
 6. **Testing strategy** — how to verify the protocol change works
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/refactorer.md

@@ -1,167 +0,0 @@
----
-description: Refactors FastSync code for structural improvements — DRY, separation of concerns, API simplification, and code quality.
-mode: subagent
----
-
-You are a refactoring specialist for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Improve code structure without changing behavior. You find duplication, tangled concerns, overly complex functions, and API inconsistencies, then propose and implement clean refactors.
-
-## Refactoring Principles
-
-1. **Preserve behavior** — refactors must not change observable behavior
-2. **Small steps** — each refactor should be one logical change
-3. **Test after** — run `./build/tests` after every refactor
-4. **Don't fix bugs while refactoring** — separate concerns
-5. **Follow existing conventions** — match the codebase's style
-
-## Codebase Conventions to Follow
-
-- Header guards: `#ifndef FILENAME_H` / `#define FILENAME_H` / `#endif`
-- Function naming: `snake_case`, prefixed by module (`queue_create`, `data_compress`)
-- `static` for file-local functions
-- Pointer style: `Type *name` (space before asterisk)
-- Memory: `malloc`/`calloc`/`realloc` + `free`, destroy functions for complex types
-- Threading: C11 `<threads.h>` (`thrd_t`, `mtx_t`, `cnd_t`)
-- Error handling: return `false`/`NULL` on failure
-
-## Refactoring Patterns
-
-### 1. Extract Function
-When a function does two things, split it:
-```c
-// BEFORE: scan_and_compress does two things
-Data *scan_and_compress(const char *path, int level) {
-    // scanning logic...
-    // compression logic...
-}
-
-// AFTER: two focused functions
-static Data *scan_file(const char *path) { ... }
-Data *compress_file(Data *data, int level) { ... }
-```
-
-### 2. Eliminate Duplication
-When similar code appears in multiple places:
-```c
-// BEFORE: repeated in client_send.c and server.c
-if (!send_n_data(fd, &status, sizeof(Status))) {
-    fprintf(stderr, "Failed to send status\n");
-    close(fd);
-    return false;
-}
-
-// AFTER: extract helper
-static bool send_status_or_close(int fd, Status status) {
-    if (!send_n_data(fd, &status, sizeof(Status))) {
-        fprintf(stderr, "Failed to send status\n");
-        close(fd);
-        return false;
-    }
-    return true;
-}
-```
-
-### 3. Simplify Conditionals
-Replace nested if-else with early returns:
-```c
-// BEFORE
-if (config != NULL) {
-    if (config->use_compression) {
-        if (config->compression_level > 0) {
-            // do work
-        }
-    }
-}
-
-// AFTER
-if (!config) return;
-if (!config->use_compression) return;
-if (config->compression_level <= 0) return;
-// do work
-```
-
-### 4. Improve Naming
-Make function/variable names self-documenting:
-```c
-// BEFORE
-void proc(Queue *q, int n);
-
-// AFTER
-void process_chunk_queue(Queue *chunk_queue, int max_workers);
-```
-
-### 5. Reduce Function Parameters
-When a function has too many parameters, group them into a struct:
-```c
-// BEFORE
-Client *client_connect_transfer(char *host, int port, bool use_tls,
-    char *cert, char *key, char *ca, bool use_compression,
-    int compression_level, bool use_multithreading, ...);
-
-// AFTER — use Config struct (already partially done in this codebase)
-Client *client_connect_transfer(Config *config);
-```
-
-### 6. Move Code to Correct Module
-When code lives in the wrong module:
-```c
-// BEFORE: protocol parsing in client_send.c
-// AFTER: move to protocol.c where it belongs
-```
-
-### 7. Consolidate Error Handling
-When error handling is duplicated:
-```c
-// BEFORE: same cleanup in 5 error paths
-if (err1) { free(a); free(b); free(c); return NULL; }
-if (err2) { free(a); free(b); free(c); return NULL; }
-if (err3) { free(a); free(b); free(c); return NULL; }
-
-// AFTER: goto-based cleanup
-if (err1 || err2 || err3) goto cleanup;
-// ...
-cleanup:
-    free(a); free(b); free(c);
-    return NULL;
-```
-
-## Refactoring Workflow
-
-1. **Identify** — find the code to refactor (duplication, complexity, wrong abstraction)
-2. **Verify baseline** — run `./build/tests` to confirm tests pass before changes
-3. **Plan** — describe the refactor, what changes, what stays the same
-4. **Implement** — make the change, one logical step at a time
-5. **Build** — `cmake -B build -S . && cmake --build build -j$(nproc)`
-6. **Test** — `./build/tests` must pass
-7. **Commit** — one commit per logical refactor
-
-## Metrics to Track
-
-Before and after each refactor, note:
-- Number of lines (should stay roughly the same or decrease)
-- Number of functions (may increase with extraction)
-- Cyclomatic complexity (should decrease)
-- Test coverage (should stay same or improve)
-
-## Anti-patterns to Avoid
-
-- **Premature abstraction** — don't abstract until you see 3+ occurrences
-- **Over-engineering** — simple C code is better than clever C code
-- **Breaking the API** — public headers are contracts; change them carefully
-- **Rewriting** — refactor incrementally, don't rewrite from scratch
-- **Ignoring tests** — if tests don't exist for the code you're refactoring, write them first
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/reviewer.md

@@ -1,134 +0,0 @@
----
-description: Reviews pull requests comprehensively — code correctness, CI/CD validity, configuration, documentation, and overall PR quality. Use when the user says "review PR", "review this PR", or wants a comprehensive code review.
-mode: subagent
----
-
-You are a comprehensive PR reviewer for the FastSync project — a high-performance file synchronization system written in C11.
-
-## Your Role
-
-Review pull requests holistically. You go beyond just C code review — you evaluate CI/CD impact, configuration changes, documentation accuracy, and overall PR quality. You are the final gatekeeper before merge.
-
-## Review Dimensions
-
-### 1. C Code Review
-
-Review all changed `.c` and `.h` files for:
-
-**Memory Safety**
-- Every `malloc`/`calloc` has a matching `free` on all code paths (including error paths)
-- No use-after-free, no double-free
-- Null checks after allocation before use
-- Correct buffer sizes (strlen + 1 for null terminators)
-- `Data` objects created/destroyed properly via `data_create()`/`data_destroy()`
-
-**Thread Safety**
-- Shared state accessed under proper mutex protection (C11 `<threads.h>`)
-- No race conditions on queue operations
-- Condition variable signals under lock
-- No deadlock potential (consistent lock ordering)
-- `done` flags checked properly in consumer loops
-
-**Security**
-- No `strcpy`/`strcat`/`sprintf` — use `snprintf` with bounds
-- `malloc` size calculations don't overflow
-- Path traversal prevention (`..` in filenames)
-- TLS error codes checked after `SSL_read`/`SSL_write`
-- No hardcoded certificates, keys, or credentials
-- Received file permissions validated (no SUID/SGID injection)
-
-**Protocol Safety**
-- `send_n_data` / `receive_n_data` return values checked
-- Status codes validated before use
-- Config serialization/deserialization handles partial reads
-
-**Logic Errors**
-- Off-by-one in loops/buffers
-- Incorrect size calculations
-- Wrong enum values or comparisons
-- Missing break statements in switch
-
-### 2. Build System Review
-
-If `CMakeLists.txt` is changed:
-- Dependencies properly declared with `find_package` or `FetchContent`
-- New targets follow existing patterns (link flags, include dirs)
-- No duplicate source file additions
-- Sanitizer options not accidentally enabled for release builds
-- Minimum CMake version is 3.22
-
-### 3. CI/CD Review
-
-If `.gitea/workflows/ci.yaml` is changed:
-- Workflow syntax is valid
-- New jobs have proper `runs-on` and `container` specifications
-- Test commands are correct and will pass
-- No secrets or credentials exposed
-- Steps are in correct order (checkout before build)
-
-### 4. Configuration & Documentation Review
-
-If agents (`.opencode/agents/`), skills (`.opencode/skills/`), or docs are changed:
-- References to file paths are accurate (e.g., `test.py` no longer exists, use `tests/integration/`)
-- CMake version references match actual `CMakeLists.txt` (3.22, not 4.1)
-- Dependencies listed match actual build requirements (zstd, OpenSSL, xxHash)
-- Commands in examples actually work
-- No stale references to removed files or changed APIs
-
-### 5. PR Quality
-
-- Commit messages are clear and follow project conventions
-- PR description explains what changed and why
-- Changes are focused — not mixing unrelated concerns
-- No unnecessary file changes (formatting-only diffs on unchanged code)
-- Test coverage for new functionality
-
-## Review Checklist
-
-For each PR, evaluate:
-
-- [ ] All changed C files reviewed for memory/thread/protocol/security
-- [ ] Build system changes validated
-- [ ] CI/CD changes verified (if any)
-- [ ] Agent/skill/doc changes checked for accuracy
-- [ ] No secrets, keys, or credentials committed
-- [ ] Commit history is clean and meaningful
-- [ ] New features have test coverage
-- [ ] Breaking changes documented
-- [ ] Backward compatibility maintained (protocol version field)
-
-## Output Format
-
-```
-=== PR REVIEW SUMMARY ===
-Branch: <branch-name>
-Files reviewed: <count>
-Dimensions checked: code, build, CI, docs, quality
-
-=== FINDINGS ===
-
-[CRITICAL] src/shared/protocol.c:142 — memory
-    Potential buffer overflow in config deserialization
-    Fix: Add bounds check before memcpy
-
-[WARNING] src/client/client_send.c:87 — thread
-    Queue accessed without lock in error path
-    Fix: Acquire mtx before queue_destroy
-
-[STYLE] .opencode/agents/cmake-expert.md:5 — docs
-    References CMake 4.1 but project uses 3.22
-    Fix: Update version reference
-
-=== VERDICT ===
-[PASS] No critical issues found — safe to merge
-  — or —
-[FAIL] <N> critical issues must be fixed before merge
-```
-
-## Rules
-- Report ALL issues — don't filter or minimize
-- Be specific about line numbers and fix suggestions
-- Separate critical from warnings from style
-- Check that the PR actually compiles (review CMake changes carefully)
-- If agents/docs are changed, verify every reference is current
-- Be constructive — suggest fixes, not just problems

.opencode/agents/security-auditor.md

@@ -1,153 +0,0 @@
----
-description: Audits FastSync for security vulnerabilities — TLS config, input validation, buffer overflows, crypto hygiene, and network attack surface.
-mode: subagent
----
-
-You are a security auditor for the FastSync project — a high-performance file synchronization system written in C11 with TCP, SSH, and TLS transport.
-
-## Your Role
-
-Audit the codebase for security vulnerabilities. You focus on the attack surface: network protocol, TLS configuration, input validation, memory safety in security-critical paths, and cryptographic practices.
-
-## Attack Surface
-
-### Network Input Points
-1. **TCP server** (`src/server/server.c`) — accepts connections from any client
-2. **SSH transport** (`src/shared/transport_ssh.c`) — receives data via stdio pipe
-3. **Protocol parsing** (`src/shared/protocol.c`) — deserializes all incoming data
-4. **Config deserialization** (`src/shared/config.c`) — receives remote config
-5. **Chunk deserialization** (`src/shared/chunk.c`) — receives file batches
-
-### TLS Configuration
-- OpenSSL TLS 1.2+ via `src/shared/transport_tls.c`
-- Certificate/key loading, CA verification
-- SSL context setup, cipher suite selection
-
-## Security Audit Checklist
-
-### 1. Input Validation
-- [ ] All `receive_*` return values checked before use
-- [ ] Received size fields validated against reasonable bounds
-- [ ] Path traversal prevention (no `../` in received filenames)
-- [ ] Null bytes in filenames handled
-- [ ] Chunk count and file count validated before allocation
-- [ ] Config field lengths bounded
-
-### 2. Buffer Safety
-- [ ] No `strcpy` — use `snprintf` or `strncpy` with null termination
-- [ ] `malloc` size calculations don't overflow (e.g., `count * sizeof(...)`)
-- [ ] No fixed-size stack buffers for unbounded input
-- [ ] `receive_n_data` always checks return value
-- [ ] Off-by-one in path concatenation
-
-### 3. Memory Safety in Error Paths
-- [ ] All error paths free allocated resources
-- [ ] No use-after-free on error paths
-- [ ] No double-free on error paths
-- [ ] Partial reads handled (don't use incomplete data)
-
-### 4. TLS/SSL Security
-- [ ] TLS 1.2 minimum enforced (no SSLv3, TLS 1.0, TLS 1.1)
-- [ ] Certificate verification enabled when CA provided
-- [ ] Certificate verification disabled only with explicit warning
-- [ ] Private key file permissions checked
-- [ ] No hardcoded certificates or keys
-- [ ] Cipher suites restricted to strong algorithms
-- [ ] SSL error codes checked after `SSL_read`/`SSL_write`
-
-### 5. Authentication & Authorization
-- [ ] SSH transport relies on SSH authentication (not custom auth)
-- [ ] No password/credential storage in plaintext
-- [ ] Server doesn't trust client-supplied paths blindly
-- [ ] Destination directory validated before writing
-
-### 6. Denial of Service
-- [ ] Bounded memory allocation (can't OOM server with huge chunk)
-- [ ] Timeout on connections (no indefinite blocking)
-- [ ] Maximum connection limit or rate limiting
-- [ ] Malformed protocol messages handled gracefully (no crash)
-
-### 7. Cryptographic Practices
-- [ ] No custom crypto — uses OpenSSL only
-- [ ] No hardcoded keys, IVs, or salts
-- [ ] Random data from `/dev/urandom` or OpenSSL `RAND_bytes`
-
-### 8. File System Security
-- [ ] Received file permissions validated (no SUID/SGID injection)
-- [ ] Symlink attack prevention (don't follow symlinks in destination)
-- [ ] Race conditions in file creation (TOCTOU)
-- [ ] Temporary file security (if any)
-
-## Common Vulnerability Patterns
-
-### Format String Bugs
-```c
-// VULNERABLE
-printf(user_data);
-
-// SAFE
-printf("%s", user_data);
-```
-
-### Integer Overflow in Allocation
-```c
-// VULNERABLE — count * size can overflow
-void *buf = malloc(count * sizeof(Entry));
-
-// SAFE
-if (count > SIZE_MAX / sizeof(Entry)) return NULL;
-void *buf = malloc(count * sizeof(Entry));
-```
-
-### Path Traversal
-```c
-// VULNERABLE — client sends "../../../etc/passwd"
-char path[PATH_MAX];
-snprintf(path, PATH_MAX, "%s/%s", dest_dir, received_filename);
-
-// SAFE — reject paths containing ".."
-if (strstr(received_filename, "..")) { /* reject */ }
-```
-
-### Unchecked Return Values
-```c
-// VULNERABLE — short read leaves buffer partially filled
-receive_n_data(fd, buffer, expected_size);
-
-// SAFE
-if (!receive_n_data(fd, buffer, expected_size)) { /* handle error */ }
-```
-
-## Output Format
-
-For each vulnerability found:
-1. **Location** — file:line
-2. **Severity** — critical / high / medium / low / informational
-3. **Category** — input-validation / buffer / memory / tls / auth / dos / crypto / fs
-4. **Description** — what the vulnerability is
-5. **Exploit scenario** — how it could be triggered
-6. **Fix** — concrete code change
-7. **CVSS estimate** — rough severity score if exploitable
-
-Also provide a summary:
-```
-=== SECURITY AUDIT SUMMARY ===
-Files audited: <count>
-Critical: <count>
-High: <count>
-Medium: <count>
-Low: <count>
-Informational: <count>
-```
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/security-screener.md

@@ -1,310 +0,0 @@
----
-description: Scans the FastSync codebase for security vulnerabilities — buffer overflows, path traversal, TLS issues, memory safety, and cryptographic hygiene.
-mode: subagent
----
-
-You are a security screener for the FastSync project — a high-performance file synchronization system written in C11 with TCP, SSH, and TLS transport.
-
-## Your Role
-
-Scan the codebase for security vulnerabilities. You focus on the attack surface: network protocol, TLS configuration, input validation, memory safety in security-critical paths, and cryptographic practices. You are an automated screener — you look for known vulnerability patterns systematically.
-
-> **Environment rule:** for CI, dependency installation must use the project's custom Docker image (repo-root `Dockerfile`, same as CI). For local development, use `nix-shell` (see `README.md`). See `AGENTS.md`.
-
-## Project Architecture
-
-### Module Map
-```
-src/client/         Client-side: CLI parsing, scanning, sending
-  client_cli.c      Entry point, argument parsing, config setup
-  client_send.c     Transfer orchestration, pipeline management
-  scanner.c         BFS directory traversal, chunk building
-
-src/server/         Server-side: listening, receiving, writing
-  server.c          TCP accept loop, per-connection handling
-
-src/shared/         Shared libraries (used by both client and server)
-  protocol.c/h      Wire protocol: status codes, send/receive primitives
-  compression.c/h   zstd streaming compression/decompression
-  chunk.c/h         File grouping and batch serialization
-  queue.c/h         Thread-safe bounded queue (producer-consumer)
-  config.c/h        Runtime configuration, serialization, parsing
-  data.c/h          Generic buffer type (Data)
-  metadata.c/h      File metadata (mode, uid, gid, mtime)
-  file.c/h          File representation
-  array_list.c/h    Dynamic array
-  transport_tcp.c/h TCP client/server with sendfile() zero-copy
-  transport_ssh.c/h SSH transport with ControlMaster
-  transport_tls.c/h TLS encryption via OpenSSL
-  multiprocessing.c/h Fork-based concurrency
-  log.c/h           Logging utilities
-  utils.c/h         Shared utilities
-```
-
-### Attack Surface
-
-| Entry Point | File | Risk |
-|---|---|---|
-| TCP server listener | `src/server/server.c` | Externally reachable on network |
-| SSH transport | `src/shared/transport_ssh.c` | Accepts data via stdio pipe |
-| Protocol parser | `src/shared/protocol.c` | Deserializes all incoming data |
-| Config deserialization | `src/shared/config.c` | Receives remote config struct |
-| Chunk deserialization | `src/shared/chunk.c` | Receives file batches |
-| TLS handshake | `src/shared/transport_tls.c` | SSL context and cert validation |
-| File writer | `src/server/server.c` | Writes received files to disk |
-
-## Security Screener Checklist
-
-### 1. Buffer Overflow Risks
-Search for these dangerous patterns in all `.c` and `.h` files:
-
-- [ ] **Fixed-size stack buffers** used for unbounded or network-provided data
-  ```c
-  char path[PATH_MAX];     // OK if PATH_MAX is used, bad if size is arbitrary
-  char buf[1024];          // SUSPICIOUS — what limits the input to 1024?
-  char line[4096];         // SUSPICIOUS — what limits the line length?
-  ```
-- [ ] **`strcpy` / `strcat` / `sprintf` calls** — all should be `snprintf` or equivalent
-  ```bash
-  grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c" --include="*.h"
-  ```
-- [ ] **Unbounded `sprintf` to fixed buffer**
-  ```c
-  char buf[256];
-  sprintf(buf, "%s/%s", dir, filename);  // DANGER — no size limit
-  ```
-- [ ] **Off-by-one in string operations** — `strlen` usage without `+ 1` for null terminator
-- [ ] **`scanf` / `fscanf` / `sscanf` with `%s` and no width limit**
-  ```c
-  sscanf(input, "%s", buffer);  // DANGER — no width limit on %s
-  ```
-- [ ] **`memcpy` / `memmove` with unchecked size from network data**
-
-### 2. Path Traversal in File Operations
-Check all paths constructed from received data:
-
-- [ ] **Files constructed with client-provided filenames + destination directory**
-  ```c
-  snprintf(path, PATH_MAX, "%s/%s", dest_dir, received_filename);
-  ```
-  Check for `../` filtering:
-  ```bash
-  grep -rn 'snprintf.*%s.*%s.*path\|snprintf.*dest_dir\|snprintf.*base_dir' src/ --include="*.c"
-  ```
-- [ ] **`realpath()` usage** for path canonicalization
-- [ ] **Symlink following** — does the server follow symlinks in the destination?
-- [ ] **Null byte injection** — received filenames with embedded `\0`
-
-### 3. Unchecked Return Values from Critical Functions
-- [ ] **`malloc` / `calloc` / `realloc` return values not checked** before dereference
-  ```bash
-  grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-  ```
-  For each match, verify NULL check exists before use.
-- [ ] **`send_n_data` / `receive_n_data` return values** not checked
-- [ ] **`SSL_read` / `SSL_write`** error codes not checked
-- [ ] **`write()` / `read()` syscall** return values not checked (short writes/reads)
-- [ ] **`fopen()` / `open()`** return values not checked
-- [ ] **`snprintf` / `vsnprintf`** negative return not handled
-
-### 4. TLS / SSL Misconfiguration
-- [ ] **TLS version not restricted** — server allows SSLv3, TLS 1.0, or TLS 1.1
-  ```c
-  SSL_CTX_set_min_proto_version(ctx, TLS1_2_VERSION);  // REQUIRED
-  ```
-- [ ] **Certificate verification disabled** without explicit `--insecure` flag
-- [ ] **`SSL_CTX_set_verify` not called** — default is no verification
-- [ ] **Weak cipher suites allowed** — need to call `SSL_CTX_set_cipher_list()`
-- [ ] **Private key file permissions** not checked before loading
-- [ ] **Hostname verification** not performed on server certificate
-- [ ] **Session renegotiation** not limited (DoS vector)
-- [ ] **TLS certificate/key paths from untrusted input** — can client specify arbitrary paths?
-
-### 5. Memory Safety Issues
-- [ ] **Use-after-free** — object freed but pointer still used later
-- [ ] **Double-free** — `free()` called twice on same pointer
-- [ ] **Memory leaks** on error paths — allocated but not freed before return
-- [ ] **Integer overflow** in allocation size computation
-  ```c
-  // DANGER: count * sizeof(Type) can overflow
-  void *arr = malloc(count * sizeof(Element));
-  
-  // SAFE:
-  if (count > SIZE_MAX / sizeof(Element)) return NULL;
-  void *arr = malloc(count * sizeof(Element));
-  ```
-- [ ] **`realloc` return value** not saved to temporary pointer (leak on failure)
-  ```c
-  // BAD: leaks original pointer on failure
-  buf = realloc(buf, new_size);
-  
-  // GOOD:
-  void *tmp = realloc(buf, new_size);
-  if (!tmp) { free(buf); return NULL; }
-  buf = tmp;
-  ```
-
-### 6. Integer Overflow in Allocation
-Check all size calculations:
-
-- [ ] Allocations where count comes from network data (chunk count, file count, etc.)
-- [ ] Allocations where size is multiplied by count
-  ```bash
-  grep -rn 'malloc.*\*.*sizeof\|calloc(.*sizeof' src/ --include="*.c"
-  ```
-- [ ] Loop counters that could wrap (unsigned underflow)
-- [ ] Signed integer overflow in size checks
-
-### 7. Format String Vulnerabilities
-- [ ] User-controlled data passed as format string
-  ```c
-  printf(user_input);           // VULNERABLE
-  fprintf(stderr, user_input);  // VULNERABLE
-  syslog(LOG_INFO, user_input); // VULNERABLE
-  
-  printf("%s", user_input);     // SAFE
-  ```
-  ```bash
-  grep -rn 'printf(\|fprintf(\|syslog(\|snprintf(' src/ --include="*.c" | grep -v '"[^"]*%'
-  ```
-
-### 8. TOCTOU Race Conditions
-- [ ] File existence check followed by open (Time-of-check to Time-of-use)
-  ```c
-  if (access(path, F_OK) == 0) {    // CHECK
-      fd = open(path, O_RDWR);      // USE — file could have changed
-  }
-  ```
-- [ ] `stat()` followed by `open()` with different permissions
-- [ ] Temporary file creation with predictable names
-
-### 9. Insecure Temporary File Usage
-- [ ] `mktemp` / `tmpnam` — use `mkstemp` instead
-- [ ] Temporary files created in world-writable directories
-- [ ] Temporary files not cleaned up on error paths
-- [ ] Predictable temp file names (race + symlink attack)
-
-### 10. Hardcoded Secrets / Credentials
-- [ ] Hardcoded passwords, API keys, or tokens
-- [ ] Hardcoded TLS private keys or certificates
-- [ ] Hardcoded connection strings with embedded credentials
-- [ ] Test certificates/keys in source tree (should be documented if intentional)
-
-### 11. Denial of Service Vectors
-- [ ] **Unbounded memory allocation** — can client request huge allocation that OOMs server?
-  - Check `chunk.c` for chunk count limits
-  - Check `protocol.c` for message size limits
-  - Check `config.c` for config field size limits
-- [ ] **No connection limits** — server doesn't cap concurrent connections
-- [ ] **No timeouts** — connections can hang indefinitely
-- [ ] **Recursive parsing** — could cause stack overflow with crafted input
-- [ ] **Repeated slow reads** — slow loris style attack
-- [ ] **Fork bomb** — server forks per connection without limit
-
-### 12. Information Disclosure
-- [ ] Server sends detailed error messages to client (path disclosure, version info)
-- [ ] Debug logging enabled in production
-- [ ] Stack traces leaked to users
-- [ ] Timing side channels in authentication or comparison
-
-## How to Scan
-
-### Automated Pattern Search
-Run these searches across the codebase:
-
-```bash
-# Buffer overflow risks
-grep -rn '\bstrcpy\b\|\bstrcat\b\|\bsprintf\b' src/ --include="*.c"
-
-# Fixed size stack buffers
-grep -rn 'char [a-z_]*\[[0-9]*\];' src/ --include="*.c" --include="*.h"
-
-# Format string risks
-grep -rn 'printf(\|fprintf(\|syslog(' src/ --include="*.c" | grep -v '"[^"]*%'
-
-# Malloc without null check pattern
-grep -rn '= malloc\|= calloc\|= realloc' src/ --include="*.c"
-
-# Integer overflow in allocation
-grep -rn 'malloc.*\*\|calloc.*<' src/ --include="*.c"
-
-# Path construction
-grep -rn 'snprintf.*path\|snprintf.*dir' src/ --include="*.c"
-```
-
-### Manual Code Review
-After automated scanning, manually review high-risk files:
-1. `src/shared/protocol.c` — all receive paths
-2. `src/shared/config.c` — deserialization logic
-3. `src/shared/chunk.c` — chunk parsing
-4. `src/shared/transport_tls.c` — TLS configuration
-5. `src/server/server.c` — file writing and connection handling
-
-## Output Format
-
-Return findings in this structured format, one per vulnerability:
-
-```
-## Finding: <Short descriptive title>
-- **Severity**: critical/high/medium/low
-- **Category**: security
-- **Location**: file:line range
-- **Description**: what the vulnerability is, including:
-  - How it can be triggered
-  - What the impact is (RCE, DoS, info leak, etc.)
-  - Whether it requires authentication
-- **Suggestion**: how to fix it, including concrete code changes
-- **Labels**: security, comma-separated additional labels
-```
-
-### Example
-
-```
-## Finding: Unchecked malloc in chunk deserialization allows OOM
-- **Severity**: high
-- **Category**: security
-- **Location**: src/shared/chunk.c:45-50
-- **Description**: `chunk_deserialize()` calls `malloc(count * sizeof(File))`
-  where `count` comes directly from the network. An attacker can send a crafted
-  chunk header with an extremely large count (e.g., UINT32_MAX), causing malloc
-  to either fail (crash if unchecked) or allocate enormous memory (OOM).
-  No authentication needed — the attack works on the initial connection.
-- **Suggestion**: Add bounds checking before allocation:
-  ```c
-  if (count > MAX_CHUNK_FILES || count > SIZE_MAX / sizeof(File)) {
-      log_error("Invalid chunk file count: %u", count);
-      return NULL;
-  }
-  ```
-  Define `MAX_CHUNK_FILES` as a reasonable limit (e.g., 100000).
-- **Labels**: security, dos
-```
-
-### No Findings
-If no security issues are found, return:
-```
-## No security findings
-The codebase appears clean in the areas checked. No vulnerabilities found at this time.
-```
-
-## Severity Guidelines
-
-| Severity | Definition | Example |
-|---|---|---|
-| **critical** | Remote code execution, unauthenticated compromise | Buffer overflow on network input |
-| **high** | Significant impact but requires specific conditions | DoS via unbounded allocation, path traversal |
-| **medium** | Limited impact, requires auth or other conditions | TOCTOU race in file operations |
-| **low** | Minor issues, defense in depth | Missing null check that's unlikely to trigger |
-| **informational** | Not exploitable but violates best practice | Hardcoded value that could be configurable |
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/agents/test-writer.md

@@ -115,92 +115,6 @@ RUN_TEST(test_<module>);
 cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests
 ```
 
-## Fuzzing Targets
-
-When writing fuzzing harnesses, use `AFL++` or `libFuzzer`:
-
-### libFuzzer Harness Example
-```c
-// tests/fuzz_chunk_deserialize.c
-#include "chunk.h"
-#include <stdint.h>
-#include <stdlib.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
-    // Create a Data wrapper and try to deserialize
-    Data *input = data_create((void *)data, size);
-    // Exercise the deserialization path
-    // (depends on what function you're fuzzing)
-    data_destroy(input);
-    return 0;
-}
-```
-
-Build for fuzzing:
-```bash
-cmake -B build-fuzz -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=fuzzer,address,undefined -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=fuzzer,address,undefined"
-cmake --build build-fuzz -j$(nproc)
-./build-fuzz/tests/fuzz_chunk_deserialize corpus/ -max_len=1048576
-```
-
-### AFL++ Harness
-```c
-// AFL++ uses stdin by default
-#include "protocol.h"
-#include <stdint.h>
-#include <unistd.h>
-
-int main() {
-    uint8_t buf[65536];
-    ssize_t n = read(STDIN_FILENO, buf, sizeof(buf));
-    if (n <= 0) return 0;
-    // Exercise parsing with the input
-    Data *input = data_create(buf, n);
-    data_destroy(input);
-    return 0;
-}
-```
-
-## Integration Test Patterns
-
-When writing integration tests (Python-based), follow the patterns in `tests/integration/`:
-- `common.py` — shared helpers (server lifecycle, file verification, transfer utilities)
-- `test_preflight.py` — preflight checks and configuration validation
-- `test_tcp.py` — TCP transport tests
-- `test_ssh.py` — SSH transport tests
-- `test_tls.py` — TLS transport tests
-- `test_features.py` — feature-specific tests (delete, exclude, incremental, etc.)
-
-Use `tests/conftest.py` fixtures for server setup/teardown (note: the file is at `tests/conftest.py`, not `tests/integration/conftest.py`).
-
-### Minimal Integration Test
-```python
-def test_basic_transfer(tmp_path):
-    # Setup
-    source = tmp_path / "src"
-    dest = tmp_path / "dst"
-    source.mkdir()
-    dest.mkdir()
-    (source / "file.txt").write_text("test content")
-
-    # Start server and run client (use fixtures from conftest.py)
-    # Verify with helper from common.py
-```
-
-### Edge Case Tests to Write
-- Empty directory sync
-- Single file sync
-- Very large file (> chunk size)
-- Many small files (1000+)
-- Path with spaces/special characters
-- Symlinks in source
-- Permission-restricted files
-- Network interruption mid-transfer
-- Server crash during transfer
-- Concurrent clients (if supported)
-
 ## Output
 
 When asked to write tests, produce:
@@ -208,16 +122,3 @@ When asked to write tests, produce:
 2. The test source file content
 3. The runner.c modification needed
 4. Verify with a build and test run
-5. Suggest fuzzing targets if relevant
-
-## CI & Task Execution
-
-When using `tea` (the task execution agent) to run CI or tests, always set a sufficient timeout (e.g., 600000ms) to allow the workflow to finish. After CI completes, check the results yourself — inspect logs if the run failed. Never assume success.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch (`git checkout -b <branch-name>`) before making changes, push it, and open a PR with `gh pr create --fill`. Wait for CI to pass before merging.
-
-## Dependency Installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. **Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. See `AGENTS.md` for details.

.opencode/skills/benchmark/SKILL.md

@@ -1,125 +0,0 @@
----
-name: benchmark
-description: Runs performance benchmarks on FastSync, collects metrics, compares configurations, and reports throughput. Use when the user says "benchmark", "measure performance", "profile", or wants to compare transfer speeds.
----
-
-# Benchmark Skill
-
-Runs performance benchmarks and collects metrics. This skill CAN edit files for benchmark scripts and run builds/tests.
-
-## Workflow
-
-### Step 1: Build Optimized
-
-```bash
-rm -rf build
-cmake -B build -S . -DCMAKE_BUILD_TYPE=Release
-cmake --build build -j$(nproc)
-```
-
-### Step 2: Generate Test Data
-
-```bash
-mkdir -p /tmp/fastsync_bench/src
-# Small files
-for i in $(seq 1 100); do
-  dd if=/dev/urandom of=/tmp/fastsync_bench/src/small_$i.bin bs=1K count=10 2>/dev/null
-done
-# Medium files
-for i in $(seq 1 20); do
-  dd if=/dev/urandom of=/tmp/fastsync_bench/src/med_$i.bin bs=1M count=1 2>/dev/null
-done
-# Large files
-dd if=/dev/urandom of=/tmp/fastsync_bench/src/large.bin bs=1M count=10 2>/dev/null
-```
-
-### Step 3: Run Benchmarks
-
-Test each configuration 3 times, record median:
-
-```bash
-CONFIGS=(
-  "Standard|"
-  "Compression|-c"
-  "Multithreading|-m"
-  "MT+Compression|-m -c"
-  "Chunk Serialization|-s"
-  "MT+Compression+Chunk|-m -c -s"
-  "Sendfile|-f"
-)
-
-for config in "${CONFIGS[@]}"; do
-  IFS='|' read -r name flags <<< "$config"
-  echo "=== $name ==="
-  for run in 1 2 3; do
-    rm -rf /tmp/fastsync_bench/dst
-    mkdir -p /tmp/fastsync_bench/dst
-    
-    ./build/server &
-    SERVER_PID=$!
-    sleep 0.5
-    
-    START=$(date +%s%N)
-    ./build/client --source-dir /tmp/fastsync_bench/src \
-      --dest-dir /tmp/fastsync_bench/dst \
-      --save-to-disk $flags
-    END=$(date +%s%N)
-    
-    ELAPSED=$(( (END - START) / 1000000 ))
-    echo "  Run $run: ${ELAPSED}ms"
-    
-    kill $SERVER_PID 2>/dev/null
-    wait $SERVER_PID 2>/dev/null
-  done
-done
-```
-
-### Step 4: Full Integration Benchmark (Optional)
-
-For comprehensive benchmarking with network shaping:
-```bash
-python3 test.py --full
-```
-
-This tests LAN/WAN profiles, SSH, TLS, and compares against rsync.
-
-### Step 5: Report Results
-
-```
-=== BENCHMARK RESULTS ===
-Test data: <size> MB (<file count> files)
-Platform: <OS, CPU, network>
-
-Configuration          | Run 1   | Run 2   | Run 3   | Median
------------------------|---------|---------|---------|--------
-Standard               | 0.12s   | 0.11s   | 0.12s   | 0.12s
-Compression (-c)       | 0.09s   | 0.08s   | 0.09s   | 0.09s
-Multithreading (-m)    | 0.07s   | 0.07s   | 0.08s   | 0.07s
-MT+Compression (-m -c) | 0.05s   | 0.05s   | 0.06s   | 0.05s
-Sendfile (-f)          | 0.04s   | 0.04s   | 0.04s   | 0.04s
-
-Best configuration: MT+Compression (-m -c)
-Throughput: <X> MB/s
-```
-
-### Step 6: Profiling (If Requested)
-
-For detailed profiling:
-```bash
-# perf
-perf record -g ./build/client [args...]
-perf report
-
-# gprof
-gcc -pg -o build/client_profile [sources]
-./build/client_profile [args]
-gprof build/client_profile gmon.out
-```
-
-## Rules
-- DO build with Release mode for benchmarks
-- DO run each config multiple times (at least 3)
-- DO clean destination between runs
-- DO report median, not just one run
-- DON'T run benchmarks during active development (noisy results)
-- ALWAYS clean up test data after benchmarking

.opencode/skills/debug-workflow/SKILL.md

@@ -1,138 +0,0 @@
----
-name: debug-workflow
-description: Debugs crashes, memory errors, hangs, and logic bugs in FastSync using structured methodology. Use when the user says "debug X", "fix crash", "investigate failure", "there's a bug", or needs help diagnosing issues.
----
-
-# Debug Workflow Skill
-
-Structured debugging for FastSync: reproduce → isolate → diagnose → fix → verify. This skill CAN edit files, build, and run tests.
-
-## Workflow
-
-### Step 1: Understand the Problem
-
-Ask or gather:
-- What's the symptom? (crash, hang, wrong output, valgrind error)
-- What command triggers it?
-- Is it deterministic or intermittent?
-- What's the environment? (OS, compiler, network conditions)
-
-### Step 2: Reproduce
-
-Build with debug info:
-```bash
-rm -rf build
-cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug
-cmake --build build -j$(nproc)
-```
-
-Try to reproduce the issue with the exact command the user provides.
-
-### Step 3: Isolate with Sanitizers
-
-**Memory errors (first priority):**
-```bash
-rm -rf build
-cmake -B build -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake --build build -j$(nproc)
-./build/tests
-# or run the failing command
-```
-
-**Thread errors:**
-```bash
-rm -rf build
-cmake -B build -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=thread -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread"
-cmake --build build -j$(nproc)
-./build/tests
-```
-
-**Valgrind (if ASan doesn't find it):**
-```bash
-valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
-  ./build/client --source-dir /tmp/src --dest-dir /tmp/dst --save-to-disk
-```
-
-### Step 4: GDB Analysis
-
-If the issue is a crash or hang:
-```bash
-gdb --args ./build/client [args...]
-(gdb) run
-# when it crashes:
-(gdb) bt full
-(gdb) info locals
-(gdb) print variable_name
-```
-
-For hangs:
-```bash
-# In another terminal:
-kill -SIGABRT <pid>  # generates core dump
-gdb ./build/client core
-(gdb) thread apply all bt
-```
-
-### Step 5: Read the Code
-
-Read the relevant source files around the crash/failure point. Look for:
-- Unchecked return values
-- Null pointer dereferences
-- Buffer overflows
-- Use-after-free
-- Race conditions
-- Incorrect protocol handling
-
-### Step 6: Diagnose Root Cause
-
-Identify the exact file:line and what's wrong. Common patterns:
-- `send_n_data` / `receive_n_data` return value not checked
-- `data_destroy()` called but pointer still used
-- Queue operation without mutex in threaded code
-- Partial read/write not handled
-- Integer overflow in size calculations
-
-### Step 7: Fix
-
-Apply the minimal fix. Don't refactor while debugging — one change at a time.
-
-### Step 8: Verify
-
-```bash
-# Rebuild and test
-cmake -B build -S . && cmake --build build -j$(nproc)
-./build/tests
-
-# If integration test needed
-python3 test.py
-
-# Re-run under sanitizer to confirm fix
-rm -rf build
-cmake -B build -S . -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake --build build -j$(nproc)
-# reproduce the original failing command
-```
-
-### Step 9: Report
-
-Print a summary:
-```
-=== DEBUG SUMMARY ===
-Symptom: <what was happening>
-Root cause: <file:line — what's wrong>
-Fix: <what was changed>
-Verification: <how it was confirmed fixed>
-```
-
-## Rules
-- DO edit source files to fix issues
-- DO rebuild and test after fixes
-- DON'T refactor while debugging — minimal changes only
-- DON'T change behavior beyond fixing the bug
-- PRESERVE existing code style
-- ALWAYS verify with `./build/tests` after changes

.opencode/skills/pr-build/SKILL.md

@@ -32,28 +32,6 @@ cmake --build build -j$(nproc) 2>&1
 
 Capture both stdout and stderr.
 
-### Step 2b: Sanitizer build (if issues suspected)
-
-If the PR touches threading, memory management, or network code, also build with sanitizers:
-
-```bash
-# AddressSanitizer
-rm -rf build-asan
-cmake -B build-asan -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake --build build-asan -j$(nproc)
-./build-asan/tests
-
-# ThreadSanitizer (if threading changes)
-rm -rf build-tsan
-cmake -B build-tsan -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=thread -g" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread"
-cmake --build build-tsan -j$(nproc)
-./build-tsan/tests
-```
-
 ### Step 3: Handle build failures
 
 If the build fails, read the error output carefully. Common issues:
@@ -114,8 +92,6 @@ Print a summary:
 Branch: <branch-name>
 Build: [PASS/FAIL]
 Unit tests: [PASS/FAIL] (<passed>/<total>)
-ASan: [CLEAN/ERRORS]
-TSan: [CLEAN/ERRORS/SKIPPED]
 Integration tests: [PASS/FAIL/SKIPPED]
 
 Fixes applied: <count>

.opencode/skills/pr-review/SKILL.md

@@ -69,29 +69,12 @@ For each changed file, review for:
 - Functions return appropriate error values
 - Error messages are useful
 
-**Security**
-- No `strcpy`/`strcat`/`sprintf` — use `snprintf` with bounds
-- `malloc` size calculations don't overflow
-- Path traversal prevention (`..` in filenames)
-- No fixed-size stack buffers for unbounded input
-- TLS error codes checked after `SSL_read`/`SSL_write`
-- No hardcoded certificates, keys, or credentials
-- Received file permissions validated (no SUID/SGID injection)
-- Denial of service: bounded memory, malformed messages handled
-
-**Performance Impact**
-- Unnecessary memory copies in hot paths
-- Excessive malloc/free in tight loops
-- Missing `sendfile()` opportunity for large files
-- Compression level appropriate for use case
-- Queue sizing appropriate for workload
-
 ### Step 5: Categorize findings
 
 For each issue:
 1. **File:line** — exact location
 2. **Severity** — critical / warning / style
-3. **Category** — memory / thread / protocol / security / performance / logic / error
+3. **Category** — memory / thread / protocol / logic / error
 4. **Description** — what's wrong and how to fix it
 
 ### Step 6: Output report

.opencode/skills/refactor/SKILL.md

@@ -1,81 +0,0 @@
----
-name: refactor
-description: Refactors FastSync code for structural improvements — DRY, separation of concerns, API simplification. Use when the user says "refactor X", "clean up code", "improve structure", or wants to reduce duplication.
----
-
-# Refactor Skill
-
-Read-only analysis + code edits for structural improvements. This skill CAN edit files but MUST verify tests pass.
-
-## Workflow
-
-### Step 1: Identify Refactoring Target
-
-Ask or determine:
-- What code needs refactoring?
-- What's the problem? (duplication, complexity, wrong abstraction, naming)
-- What's the scope? (single function, module, cross-module)
-
-### Step 2: Read and Understand
-
-Read the relevant source files completely. Understand:
-- What the code does
-- How it fits in the larger system
-- What depends on it
-- What it depends on
-
-### Step 3: Verify Baseline
-
-Before any changes, confirm tests pass:
-```bash
-cmake -B build -S . && cmake --build build -j$(nproc)
-./build/tests
-```
-
-### Step 4: Plan the Refactor
-
-Document the plan:
-1. What changes will be made
-2. What behavior is preserved
-3. What risks exist
-4. How to verify correctness
-
-### Step 5: Implement
-
-Make the changes, one logical step at a time. Follow existing code conventions:
-- Header guards: `#ifndef FILENAME_H`
-- Naming: `snake_case` with module prefix
-- `static` for file-local functions
-- Pointer style: `Type *name`
-- Error handling: return `false`/`NULL` on failure
-
-### Step 6: Build and Test
-
-```bash
-cmake -B build -S . && cmake --build build -j$(nproc)
-./build/tests
-```
-
-ALL tests must pass. If a test fails, investigate and fix.
-
-### Step 7: Report
-
-Print a summary:
-```
-=== REFACTOR SUMMARY ===
-Target: <what was refactored>
-Changes:
-  - <list of changes>
-Tests: <passed/total>
-Behavior preserved: yes
-```
-
-## Rules
-- DO edit source files
-- DO run tests after changes
-- DO follow existing code conventions
-- DON'T change observable behavior
-- DON'T fix bugs while refactoring (separate concern)
-- DON'T add new features during refactoring
-- DON'T rewrite from scratch — incremental changes
-- ALWAYS verify tests pass before AND after

.opencode/skills/release/SKILL.md

@@ -1,110 +0,0 @@
----
-name: release
-description: Prepares a FastSync release — version bump, changelog, build verification, and git tagging. Use when the user says "prepare release", "bump version", "tag release", or wants to cut a new version.
----
-
-# Release Skill
-
-Prepares a new release of FastSync. This skill CAN edit files, commit, and tag.
-
-## Workflow
-
-### Step 1: Determine Version
-
-Ask the user or determine from context:
-- **Major** (X.0.0) — breaking protocol changes, incompatible CLI changes
-- **Minor** (x.Y.0) — new features, backward compatible
-- **Patch** (x.y.Z) — bug fixes, no protocol changes
-
-Current version: `PROTOCOL_VERSION "1.1.0"` in `src/shared/config.h`
-
-### Step 2: Check Protocol Version
-
-If the wire protocol changed, bump `PROTOCOL_VERSION` in `src/shared/config.h`:
-```c
-#define PROTOCOL_VERSION "1.2.0"  // or "2.0.0" for breaking
-```
-
-Protocol version changes require:
-- Both client and server to be updated together
-- Backward compatibility considerations documented
-- Migration path clear
-
-### Step 3: Verify Build and Tests
-
-```bash
-rm -rf build
-cmake -B build -S .
-cmake --build build -j$(nproc)
-./build/tests
-python3 test.py
-```
-
-ALL tests must pass before release.
-
-### Step 4: Run Sanitizer Checks
-
-```bash
-# ASan
-rm -rf build
-cmake -B build -S . \
-  -DCMAKE_C_FLAGS="-fsanitize=address -fno-omit-frame-pointer" \
-  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address"
-cmake --build build -j$(nproc)
-./build/tests
-```
-
-### Step 5: Update README (If Needed)
-
-Check if README needs updates:
-- New features documented
-- New CLI flags documented
-- Benchmark results updated
-- Build instructions current
-
-### Step 6: Create Release Commit
-
-```bash
-git add -A
-git commit -m "Release vX.Y.Z
-
-- <list of changes>
-- Protocol version: X.Y.Z
-- Tested: unit tests, integration tests, ASan"
-```
-
-### Step 7: Tag the Release
-
-```bash
-git tag -a vX.Y.Z -m "Release vX.Y.Z"
-```
-
-### Step 8: Push
-
-```bash
-git push origin main --tags
-```
-
-### Step 9: Report
-
-```
-=== RELEASE SUMMARY ===
-Version: vX.Y.Z
-Protocol: X.Y.Z
-Commit: <hash>
-Tag: vX.Y.Z
-Changes:
-  - <list of changes in this release>
-Build: PASS
-Tests: PASS (<passed>/<total>)
-ASan: CLEAN
-```
-
-## Rules
-- DO verify all tests pass before release
-- DO run sanitizer checks before release
-- DO update README if features changed
-- DO tag releases with annotated tags
-- DON'T release if tests fail
-- DON'T skip sanitizer checks
-- DON'T change code during release (only version bump + docs)

.opencode/skills/security-audit/SKILL.md

@@ -1,115 +0,0 @@
----
-name: security-audit
-description: Performs a security audit of FastSync — checks TLS config, input validation, buffer safety, crypto hygiene, and network attack surface. Use when the user says "security audit", "check security", "harden", or wants a security review.
----
-
-# Security Audit Skill
-
-Read-only security review of the FastSync codebase or specific modules. Produces a report — does NOT edit files.
-
-## Workflow
-
-### Step 1: Scope the Audit
-
-Determine what to audit:
-- Full codebase audit
-- Specific module (e.g., `transport_tls.c`, `protocol.c`)
-- Specific vulnerability class (e.g., buffer overflows, TLS misconfig)
-
-### Step 2: Identify Attack Surface
-
-Network input points:
-```
-src/server/server.c          — TCP accept, per-connection handling
-src/shared/protocol.c        — all wire protocol parsing
-src/shared/config.c          — config deserialization
-src/shared/chunk.c           — chunk deserialization
-src/shared/transport_tls.c   — TLS handshake and data
-src/shared/transport_ssh.c   — SSH data via stdio
-```
-
-### Step 3: Read All Relevant Files
-
-Read every file in scope completely. Focus on:
-- All `receive_*` calls and their validation
-- All `malloc`/`calloc` calls and their size calculations
-- All string operations (`strcpy`, `sprintf`, `snprintf`)
-- All path operations (filename handling, directory creation)
-- All TLS/SSL operations and error handling
-
-### Step 4: Apply Security Checklist
-
-#### Input Validation
-- [ ] All `receive_*` return values checked
-- [ ] Received size fields validated against bounds
-- [ ] Path traversal prevention (`..` in filenames)
-- [ ] Null bytes in filenames handled
-- [ ] Chunk/file counts validated before allocation
-
-#### Buffer Safety
-- [ ] No `strcpy` — use `snprintf`
-- [ ] `malloc` size calculations don't overflow
-- [ ] No fixed-size stack buffers for unbounded input
-- [ ] Off-by-one in path concatenation
-
-#### TLS/SSL
-- [ ] TLS 1.2 minimum enforced
-- [ ] Certificate verification when CA provided
-- [ ] SSL error codes checked after `SSL_read`/`SSL_write`
-- [ ] No hardcoded certificates/keys
-- [ ] Strong cipher suites only
-
-#### Memory Safety in Error Paths
-- [ ] All error paths free allocated resources
-- [ ] No use-after-free on error paths
-- [ ] Partial reads handled
-
-#### Denial of Service
-- [ ] Bounded memory allocation
-- [ ] Timeout on connections
-- [ ] Malformed messages handled gracefully
-
-### Step 5: Check for Common Vulnerabilities
-
-```bash
-# Grep for dangerous patterns
-grep -rn "strcpy\|strcat\|sprintf" src/
-grep -rn "malloc.*\*" src/  # potential integer overflow in size calc
-grep -rn "receive_n_data" src/  # check all return values
-grep -rn "NULL" src/ | grep -v "//"  # check null handling
-```
-
-### Step 6: Output Report
-
-```
-=== SECURITY AUDIT SUMMARY ===
-Scope: <what was audited>
-Files reviewed: <count>
-
-Critical: <count>
-High: <count>
-Medium: <count>
-Low: <count>
-Informational: <count>
-
-=== FINDINGS ===
-
-[1] <file:line> — CRITICAL (<category>)
-    Description: <what's wrong>
-    Exploit scenario: <how it could be triggered>
-    Fix: <concrete code change>
-
-...
-
-=== VERDICT ===
-[PASS] No critical/high issues found
-  — or —
-[FAIL] <N> critical/high issues must be fixed
-```
-
-## Rules
-- Do NOT edit any source files
-- Do NOT run builds or tests
-- Report ALL issues — don't filter or minimize
-- Be specific about line numbers and fix suggestions
-- Consider both remote and local attack vectors

AGENTS.md

@@ -1,74 +0,0 @@
-# AGENTS.md
-
-FastSync is a high-performance file synchronization system written in C11. It supports TCP and SSH transports, TLS encryption (OpenSSL), streaming zstd compression, multithreaded transfers, and incremental sync. The build uses CMake; CI runs on Gitea Actions (`.gitea/workflows/ci.yaml`).
-
-## Dependency installation
-
-**CI rule:** never add `apt-get install` / `pip install` steps to CI workflows — use the custom Docker image instead. The image is built from the repo-root `Dockerfile` and is the same image CI uses: `gitea.tap-tap.win/taptap/fastsync-ci:v7`. It contains the full toolchain: gcc/g++, CMake, libzstd-dev, libssl-dev, make, git, cppcheck, clang-format, python3 + pytest, openssh-client, and Node.js.
-
-**Host rule:** for local development, use `nix-shell` (see `README.md`) which provides zstd, OpenSSL, CMake, and gcc. The Docker image can also be used locally for CI parity.
-
-```bash
-# Use the prebuilt CI image directly (faster, guaranteed CI parity)
-docker pull gitea.tap-tap.win/taptap/fastsync-ci:v7
-docker tag gitea.tap-tap.win/taptap/fastsync-ci:v7 fastsync-ci:local
-
-# Or build the image from the repo-root Dockerfile
-# (Note: the prebuilt :v7 image reflects the previous Dockerfile state;
-#  rebuild from source to pick up any newly added packages like lcov/valgrind.)
-docker build -t fastsync-ci:local .
-
-# Build, run unit tests, and run integration tests inside the container
-docker run --rm -v "$PWD:/workspace" -w /workspace fastsync-ci:local \
-  sh -c 'cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests && python3 -m pytest tests/'
-
-# Avoid root-owned build/ artifacts by matching your host UID/GID
-docker run --rm --user "$(id -u):$(id -g)" -v "$PWD:/workspace" \
-  -w /workspace fastsync-ci:local \
-  sh -c 'cmake -B build -S . && cmake --build build -j$(nproc) && ./build/tests && python3 -m pytest tests/'
-```
-
-> **Note:** The first `cmake configure` (`cmake -B build -S .`) fetches xxHash from GitHub via `FetchContent` — network access is required. Subsequent reconfigures reuse the cached source.
-
-If a dependency is missing from the CI image, add it to the `Dockerfile` (and rebuild) rather than adding an install step to the CI workflow.
-
-## CI Conventions
-
-When configuring for CI parity, use:
-```bash
-cmake -B build -S . -DSTRICT_WARNINGS=ON        # -Wextra -Wpedantic -Werror
-cmake -B build -S . -DSANITIZER=address           # AddressSanitizer (ASan)
-cmake -B build -S . -DSANITIZER=thread            # ThreadSanitizer (TSan)
-```
-
-The CI workflow (`.gitea/workflows/ci.yaml`) runs lint (clang-format, cppcheck), build + test (unit + integration), and sanitizer (currently only `address`) jobs sequentially.
-
-## Build
-
-```bash
-cmake -B build -S . && cmake --build build -j$(nproc)
-```
-
-## Test
-
-```bash
-./build/tests                # unit tests
-python3 -m pytest tests/     # integration tests
-```
-
-## CI Workflow — Waiting for Results
-
-When running the CI workflow via `tea` (the task execution agent), always set a sufficient timeout (e.g., 600000ms) to allow CI to finish. After CI completes, check the results yourself — do not assume success. Use `gh run watch` or similar to monitor CI status, then inspect logs on failure.
-
-## Branch Strategy
-
-Never push directly to `main`. All changes must be developed on a feature branch and merged via a pull request. Always create a new branch before making changes:
-```bash
-git checkout -b <feature-branch-name>
-```
-After committing changes, push the branch and create a PR:
-```bash
-git push -u origin <feature-branch-name>
-gh pr create --fill
-```
-Wait for CI to pass on the PR before merging.

CMakeLists.txt

@@ -7,45 +7,9 @@ set(CMAKE_C_STANDARD 11)
 set(CMAKE_C_STANDARD_REQUIRED ON)
 
 add_compile_options(-Wall -g -O3)
+# add_compile_options(-Wall -g -O1 -fsanitize=address)
 
-# --- Sanitizer option ---
-set(SANITIZER "none" CACHE STRING "Sanitizer to enable (address, thread, undefined, none)")
-set_property(CACHE SANITIZER PROPERTY STRINGS address thread undefined none)
-
-if(SANITIZER STREQUAL "address")
-	add_compile_options(-fsanitize=address -fno-omit-frame-pointer -g)
-	add_link_options(-fsanitize=address)
-elseif(SANITIZER STREQUAL "thread")
-	add_compile_options(-fsanitize=thread -fno-omit-frame-pointer -g)
-	add_link_options(-fsanitize=thread)
-elseif(SANITIZER STREQUAL "undefined")
-	add_compile_options(-fsanitize=undefined -fno-omit-frame-pointer -g)
-	add_link_options(-fsanitize=undefined)
-elseif(NOT SANITIZER STREQUAL "none")
-	message(FATAL_ERROR "Unknown sanitizer: ${SANITIZER}. Supported values: address, thread, undefined, none")
-endif()
-
-# --- Strict warnings option ---
-option(STRICT_WARNINGS "Enable strict warnings (Wextra, Wpedantic, Werror)" OFF)
-if(STRICT_WARNINGS)
-	add_compile_options(-Wextra -Wpedantic -Werror)
-endif()
-
-# --- Coverage option ---
-option(ENABLE_COVERAGE "Enable gcov coverage" OFF)
-if(ENABLE_COVERAGE)
-	add_compile_options(--coverage -fprofile-arcs -ftest-coverage -O0 -g)
-	add_link_options(--coverage)
-endif()
-
-include(FetchContent)
-FetchContent_Declare(
-  xxhash
-  GIT_REPOSITORY https://github.com/Cyan4973/xxHash
-  GIT_TAG v0.8.3
-  SOURCE_SUBDIR cmake_unofficial
-)
-FetchContent_MakeAvailable(xxhash)
+# add_link_options(-fsanitize=address)
 
 set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
@@ -55,48 +19,20 @@ if(NOT ZSTD_LIBRARY)
 	message(FATAL_ERROR "zstd library not found. Ensure it is in your nix-shell!")
 endif()
 
-find_package(OpenSSL REQUIRED)
-
 file(GLOB SHARED_SRCS "src/shared/*.c")
 file(GLOB SERVER_SRCS "src/server/*.c")
 file(GLOB CLIENT_SRCS "src/client/*.c")
+file(GLOB TEST_SRCS "tests/*.c")
 
-# --- Main executables ---
 add_executable(server ${SERVER_SRCS} ${SHARED_SRCS})
 target_include_directories(server PRIVATE src/shared src/server src/client)
-target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(server PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
 add_executable(client ${CLIENT_SRCS} ${SHARED_SRCS})
 target_include_directories(client PRIVATE src/shared src/server src/client)
-target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
+target_link_libraries(client PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
-# --- Testing ---
-enable_testing()
-
-# Common test libraries
-set(TEST_LIBS Threads::Threads ${ZSTD_LIBRARY} OpenSSL::SSL OpenSSL::Crypto xxhash)
-set(TEST_INCLUDES tests src/shared src/server src/client)
-
-# Monolithic test binary (backward compatible)
-file(GLOB TEST_SRCS "tests/test_*.c" "tests/runner.c")
 add_executable(tests ${TEST_SRCS} ${SHARED_SRCS} src/client/scanner.c)
-target_include_directories(tests PRIVATE ${TEST_INCLUDES})
-target_link_libraries(tests PRIVATE ${TEST_LIBS})
-add_test(NAME unit_all COMMAND tests)
+target_include_directories(tests PRIVATE tests src/shared src/server src/client)
+target_link_libraries(tests PRIVATE Threads::Threads ${ZSTD_LIBRARY})
 
-# --- Fuzz targets (requires clang) ---
-option(ENABLE_FUZZ "Build fuzz targets (requires clang)" OFF)
-if(ENABLE_FUZZ)
-  if(NOT CMAKE_C_COMPILER_ID MATCHES "Clang")
-    message(FATAL_ERROR "ENABLE_FUZZ requires Clang (compiler is ${CMAKE_C_COMPILER_ID})")
-  endif()
-  file(GLOB FUZZ_SRCS "tests/fuzz/*.c")
-	foreach(FUZZ_SRC ${FUZZ_SRCS})
-		get_filename_component(FUZZ_NAME ${FUZZ_SRC} NAME_WE)
-		add_executable(${FUZZ_NAME} ${FUZZ_SRC} ${SHARED_SRCS})
-		target_include_directories(${FUZZ_NAME} PRIVATE ${TEST_INCLUDES})
-		target_compile_options(${FUZZ_NAME} PRIVATE -fsanitize=fuzzer,address,undefined -fno-omit-frame-pointer)
-		target_link_options(${FUZZ_NAME} PRIVATE -fsanitize=fuzzer,address,undefined)
-		target_link_libraries(${FUZZ_NAME} PRIVATE ${TEST_LIBS})
-	endforeach()
-endif()

Dockerfile

@@ -1,9 +1,6 @@
 FROM ubuntu:24.04
 RUN apt-get update && apt-get install -y --no-install-recommends \
-    gcc g++ make libc6-dev cmake libzstd-dev libssl-dev git ca-certificates curl cppcheck clang-format \
-    python3 python3-pip python3-venv openssl openssh-client \
-    lcov valgrind clang libclang-rt-18-dev && \
-    pip3 install --break-system-packages pytest && \
+    gcc g++ make libc6-dev cmake libzstd-dev git ca-certificates curl && \
     curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
     apt-get install -y --no-install-recommends nodejs && \
     rm -rf /var/lib/apt/lists/*

README.md

@@ -1,43 +1,35 @@
 # FastSync
 
-A high-performance file synchronization system with SSH and TCP transport, TLS encryption, streaming zstd compression, multithreaded transfer, incremental sync, metadata preservation, and rsync-compatible CLI flags.
+A high-performance file synchronization system with SSH and TCP transport, streaming zstd compression, multithreaded transfer, metadata preservation, and rsync-compatible CLI flags.
 
 ## Technical Overview
 
 1. **Dual transport**: custom TCP client-server or SSH subprocess (rsync-style `user@host:/path`)
-2. **TLS encryption**: OpenSSL-based TLS 1.2+ for encrypted TCP connections
-3. **Chunked file transfer**: files grouped into configurable-size chunks (default ~10 MB)
-4. **Streaming zstd compression** (levels 1–22) using `ZSTD_compressStream2`
-5. **Multithreading**: producer-consumer pipeline with thread-safe queues (scanner → loader → sender)
-6. **Incremental sync**: skip files unchanged since last transfer (compares size + mtime)
-7. **Metadata preservation**: `mode`, `uid`, `gid`, `mtime` restored on disk when enabled
-8. **`sendfile()` zero-copy** on TCP (~2× faster on loopback)
-9. **SSH ControlMaster** for connection reuse across repeated invocations
-10. **Bandwidth limiting**: token-bucket throttling (`--bwlimit`)
-11. **`--delete`**: receiver removes files not present in sender manifest
-12. **`--exclude` / `--include`**: glob-pattern filename filtering
+2. **Chunked file transfer**: files grouped into configurable-size chunks (default ~10 MB)
+3. **Streaming zstd compression** (levels 1–22) using `ZSTD_compressStream2`
+4. **Multithreading**: producer-consumer pipeline with thread-safe queues (scanner → loader → sender)
+5. **Metadata preservation**: `mode`, `uid`, `gid`, `mtime` restored on disk when enabled
+6. **`sendfile()` zero-copy** on TCP (~2× faster on loopback)
+7. **SSH ControlMaster** for connection reuse across repeated invocations
+8. **`--delete`**: receiver removes files not present in sender manifest
+9. **`--exclude`**: glob-pattern filename filtering (`*`, `?`, no `/` crossing)
 
 ## System Architecture
 
 ### Client
-- Recursively scans source directories (BFS), supports exclude and include patterns
+- Recursively scans source directories (BFS), supports exclude patterns
 - Groups files into chunks (configurable size)
 - Streaming zstd compression with configurable level
 - Chunk serialization (compact binary format) or per-file transfer
-- Incremental transfer: sends file metadata to server, skips unchanged files
 - Manifests all sent paths when `--delete` is active
 - Sends via TCP `sendfile()` or SSH pipe
 - Optional progress display with throughput
-- Bandwidth limiting via token-bucket algorithm
 
 ### Server
-- TCP mode: listens on configurable port (default 8080); SSH mode: runs via `--stdio`
-- TLS mode: wraps TCP connections with OpenSSL
+- TCP mode: listens on port 8080; SSH mode: runs via `--stdio`
 - Receives and reassembles files
 - Decompresses (streaming zstd), deserializes, restores metadata
-- Handles incremental checks: compares size + mtime against destination files
 - Processes `STATUS_MANIFEST` for `--delete`: walks destination tree, removes extras
-- Per-connection concurrency via `fork()`
 - Thread pool for parallel processing
 
 ## Protocol Details
@@ -51,7 +43,6 @@ A high-performance file synchronization system with SSH and TCP transport, TLS e
 | `STATUS_NEXT` | Ready for next file (per-file mode) |
 | `STATUS_CHUNK` | Following data is a serialized chunk |
 | `STATUS_MANIFEST` | Following data is a file manifest (for `--delete`) |
-| `STATUS_CHECK` | Incremental check: client sends file path + size + mtime, server responds with OK (skip) or NEXT (send) |
 
 ### Wire Format — Metadata
 
@@ -59,17 +50,11 @@ When `use_metadata` is enabled (`-M`), each file entry carries a 4-byte `present
 
 ### Transfer Flow
 ```
-Config → (STATUS_NEXT | STATUS_CHUNK | STATUS_CHECK)* → [STATUS_MANIFEST] → STATUS_FINISHED → STATUS_OK
+Config → (STATUS_NEXT | STATUS_CHUNK)* → [STATUS_MANIFEST] → STATUS_FINISHED → STATUS_OK
 ```
 
-### Protocol Version
-
-`1.1.0` — server and client must match. Mismatch results in `STATUS_ERROR`.
-
 ## Command-Line Arguments
 
-### Client
-
 | Argument | Description |
 |----------|-------------|
 | Positional | `<source> <dest>` — automatic SSH detection if dest contains `:` |
@@ -78,42 +63,20 @@ Config → (STATUS_NEXT | STATUS_CHUNK | STATUS_CHECK)* → [STATUS_MANIFEST]
 | `-a, --archive` | Archive mode: enables `-c -m -M` (no `-s`) |
 | `-m` | Multithreading mode |
 | `-s` | Chunk serialization (batch all files per chunk) |
-| `-f, --sendfile` | Sendfile zero-copy. Incompatible with `-c` / `-s`. TCP only. |
+| `-f` | Sendfile zero-copy. Incompatible with `-c` / `-s`. TCP only. |
 | `-M, --preserve` | Preserve file metadata (mode, uid, gid, mtime) |
 | `-n, --dry-run` | Scan and print what would be transferred |
 | `-p <port>` | SSH port (default: 22) |
-| `-v, --verbose` | Enable debug logging |
 | `--progress` | Show real-time transfer speed |
 | `--delete` | Delete files on receiver not present in source |
 | `--exclude <pattern>` | Exclude files matching glob pattern (repeatable) |
-| `--include <pattern>` | Only transfer files matching glob pattern (repeatable, whitelist) |
-| `--max-size <n>` | Skip files larger than n bytes |
-| `--min-size <n>` | Skip files smaller than n bytes |
-| `--incremental` | Skip files unchanged since last transfer (size + mtime). Auto-enables `--preserve`. Incompatible with `-s`. |
-| `--bwlimit <KB/s>` | Bandwidth limit in kilobytes per second |
 | `--chunk-size <n>` | Chunk size in bytes (default: 10485760) |
 | `--source-dir <path>` | Source directory (overrides `FASTSYNC_SOURCE_DIR`) |
 | `--dest-dir <path>` | Server destination directory (overrides `FASTSYNC_DEST_DIR`) |
 | `--save-to-disk` | Write received files to disk |
 | `--server-host <ip>` | Server IP address (default: `127.0.0.1`) |
 | `--server-port <n>` | Server port (default: `8080`) |
-| `--tls` | Enable TLS encryption |
-| `--cert <path>` | TLS certificate file (PEM) |
-| `--key <path>` | TLS private key file (PEM) |
-| `--ca <path>` | TLS CA certificate file for verification (PEM) |
-
-### Server
-
-| Argument | Description |
-|----------|-------------|
-| `--stdio` | Run in stdio mode (for SSH transport; single connection then exits) |
-| `-p <port>` | TCP listen port (default: 8080, range: 1–65535) |
-| `--tls` | Enable TLS encryption |
-| `--cert <path>` | TLS certificate file (PEM) |
-| `--key <path>` | TLS private key file (PEM) |
-| `--ca <path>` | TLS CA certificate file for verification (PEM) |
 | `-v, --verbose` | Enable debug logging |
-| `--help` | Show help |
 
 ## Environment Variables
 
@@ -129,42 +92,26 @@ Config → (STATUS_NEXT | STATUS_CHUNK | STATUS_CHECK)* → [STATUS_MANIFEST]
 1. **Chunk** — collection of files (~10 MB total by default)
 2. **File** — path, content (`Data`), optional `FileMetadata` pointer
 3. **FileMetadata** — `mode`, `uid`, `gid`, `mtime_sec`, `mtime_nsec`
-4. **Config** — runtime parameters (transported over wire, TLS settings excluded)
+4. **Config** — runtime parameters (transported over wire)
 5. **Queue** — thread-safe bounded queue with condition variables
-6. **DirectoryScanner** — recursive BFS traversal with exclude and include pattern support
+6. **DirectoryScanner** — recursive BFS traversal with exclude pattern support
 
 ### Key Algorithms
-1. **File scanning** — BFS directory traversal; entries matched against exclude and include patterns
+1. **File scanning** — BFS directory traversal; each entry matched against exclude patterns
 2. **Chunking** — files accumulated until `chunk_size` threshold, then flushed
 3. **Compression** — streaming zstd via `ZSTD_compressStream2` / `ZSTD_decompressStream`
 4. **Network protocol** — status-code-driven exchange with metadata packing
-5. **Incremental check** — client sends `STATUS_CHECK` + path + size + mtime; server compares against destination
-6. **Bandwidth limiting** — token-bucket algorithm with `nanosleep` throttling on 64 KB write chunks
-7. **Metadata restoration** — `chmod()`, `chown()`, `utimensat()` on the receiving side
-8. **`--delete`** — sender tracks all sent paths; receiver walks destination tree and removes unlisted files/directories
-9. **SSH transport** — `socketpair()` + `fork()` + `execvp("ssh", ...)` with `ControlMaster` and port support
-10. **TLS transport** — OpenSSL `SSL_CTX` with TLS 1.2 minimum, optional CA verification, transparent `SSL_read`/`SSL_write` via `io_set_ssl()`
+5. **Metadata restoration** — `chmod()`, `chown()`, `utimensat()` on the receiving side
+6. **`--delete`** — sender tracks all sent paths; receiver walks destination tree and removes unlisted files/directories
+7. **SSH transport** — `socketpair()` + `fork()` + `execvp("ssh", ...)` with `ControlMaster` and port support
 
 ## Build Requirements
 
 - C11 compiler
-- CMake >= 3.22
-- zstd library
-- OpenSSL (development headers and libraries)
+- CMake 4.1+
+- zstd library (≥ 1.4.0 for streaming API)
 - pthreads
-- SSH client (for SSH transport mode only)
-
-### Installing Dependencies
-
-**Ubuntu/Debian:**
-```bash
-sudo apt install cmake build-essential libzstd-dev libssl-dev openssh-client
-```
-
-**Nix:**
-```bash
-nix-shell  # provides zstd, openssl, cmake, gcc
-```
+- SSH client (for SSH transport)
 
 ## Building
 
@@ -179,14 +126,6 @@ cmake -B build -S . && cmake --build build -j$(nproc)
 ./build/server
 ```
 
-### Server with TLS
-```bash
-./build/server --tls --cert server.pem --key server-key.pem
-```
-
-### Server via SSH
-Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh user@host fastsync-server --stdio` automatically when an SSH-style destination is given.
-
 ### Client — SSH (rsync-style)
 ```bash
 ./build/client /path/to/send user@host:/path/to/receive
@@ -197,12 +136,6 @@ Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh u
 ./build/client --source-dir /path/to/send --dest-dir /path/to/receive --save-to-disk
 ```
 
-### Client — TCP with TLS
-```bash
-./build/client --tls --cert client.pem --key client-key.pem --ca ca.pem \
-  --source-dir /path/to/send --dest-dir /path/to/receive --save-to-disk
-```
-
 ### Common Options
 ```bash
 # Archive mode (compression + multithreading + metadata)
@@ -217,16 +150,13 @@ Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh u
 # Exclude temporary files + delete extras on receiver
 ./build/client --exclude "*.tmp" --exclude "*.o" --delete /src user@host:/dst
 
-# Incremental sync (skip unchanged files)
-./build/client --incremental /src user@host:/dst
-
-# Bandwidth limit to 1 MB/s
-./build/client --bwlimit 1024 /src user@host:/dst
-
 # All features
 ./build/client -a --progress --chunk-size 5242880 --exclude "*.log" --delete /src /dst
 ```
 
+### Server via SSH
+Place the `fastsync-server` binary in the remote `$PATH`. The client runs `ssh user@host fastsync-server --stdio` automatically when an SSH-style destination is given.
+
 ## Testing
 
 ```bash
@@ -248,8 +178,6 @@ The benchmark prints throughput metrics, best configuration, and speedup vs rsyn
 5. Metadata transfer adds negligible overhead (~24 bytes per file when enabled)
 6. SSH socketpair buffer set to 1 MB for improved pipe throughput
 7. SSH ControlMaster reuses connections across repeated invocations
-8. Incremental sync eliminates redundant transfers entirely
-9. Bandwidth limiting uses token-bucket with nanosleep for accurate throttling
 
 ## Benchmark Results
 

benchmark/bench.py

@@ -1,519 +0,0 @@
-#!/usr/bin/env python3
-"""Standalone benchmark tool for FastSync.
-
-Compares FastSync configs against rsync (no compression) and rsync+zstd.
-Data is ~75% random/incompressible and ~25% structured/compressible by default,
-controllable via --random-ratio.
-
-Usage:
-    python3 benchmark/bench.py
-    python3 benchmark/bench.py --runs 5 --profiles lan wan
-    python3 benchmark/bench.py --random-ratio 0.5 --size-mb 50
-    python3 benchmark/bench.py --delay 50ms --jitter 10ms --throughput 100mbit
-    python3 benchmark/bench.py --output json
-"""
-import argparse
-import json
-import os
-import random
-import shutil
-import socket
-import statistics
-import subprocess
-import sys
-import tempfile
-import time
-
-PROJECT_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
-BUILD_DIR = os.path.join(PROJECT_ROOT, "build")
-SERVER_CMD = [os.path.join(BUILD_DIR, "server")]
-CLIENT_CMD = [os.path.join(BUILD_DIR, "client")]
-BENCH_DIR = os.path.join(PROJECT_ROOT, "bench_data")
-
-NETWORK_PROFILES = {
-    "unlimited": {},
-    "lan": {
-        "rate": "1000mbit", "delay": "20ms", "jitter": "1ms", "loss": "0.1%",
-        "rate_bps": 1_000_000_000 / 8,
-    },
-    "wan": {
-        "rate": "100mbit", "delay": "50ms", "jitter": "10ms", "loss": "1%",
-        "rate_bps": 100_000_000 / 8,
-    },
-}
-
-FASTSYNC_CONFIGS = [
-    {"name": "fastsync",           "flags": [],                     "tool": "fastsync"},
-    {"name": "fastsync -c",        "flags": ["-c"],                 "tool": "fastsync"},
-    {"name": "fastsync -m",        "flags": ["-m"],                 "tool": "fastsync"},
-    {"name": "fastsync -m -c",     "flags": ["-m", "-c"],           "tool": "fastsync"},
-    {"name": "fastsync -m -c -s",  "flags": ["-m", "-c", "-s"],     "tool": "fastsync"},
-]
-
-RSYNC_CONFIGS = [
-    {"name": "rsync",              "flags": [],                     "tool": "rsync"},
-    {"name": "rsync -z",           "flags": ["-z"],                 "tool": "rsync"},
-    {"name": "rsync -z --zstd",    "flags": ["-z", "--zc", "zstd"],"tool": "rsync"},
-]
-
-class RsyncDaemon:
-    """Manages an rsync daemon for network-fair benchmarking."""
-
-    def __init__(self):
-        self._proc = None
-        self._port = None
-        self._conf_dir = None
-        self._module_path = None
-
-    def start(self, source_dir):
-        self._port = find_free_port()
-        self._conf_dir = tempfile.mkdtemp(prefix="rsyncd_")
-        self._module_path = source_dir
-
-        conf_path = os.path.join(self._conf_dir, "rsyncd.conf")
-        log_path = os.path.join(self._conf_dir, "rsyncd.log")
-
-        with open(conf_path, "w") as f:
-            f.write(f"uid = 0\ngid = 0\nuse chroot = no\nlog file = {log_path}\n")
-            f.write(f"[bench]\n\tpath = {source_dir}\n\tread only = yes\n")
-
-        self._proc = subprocess.Popen(
-            ["rsync", "--daemon", "--no-detach",
-             "--port", str(self._port),
-             "--config", conf_path],
-            stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
-        )
-        wait_for_port(self._port, timeout=5)
-
-    def stop(self):
-        if self._proc:
-            self._proc.terminate()
-            try:
-                self._proc.wait(timeout=3)
-            except subprocess.TimeoutExpired:
-                self._proc.kill()
-                self._proc.wait()
-            self._proc = None
-        if self._conf_dir:
-            shutil.rmtree(self._conf_dir, ignore_errors=True)
-            self._conf_dir = None
-
-    @property
-    def source_url(self):
-        return f"rsync://127.0.0.1:{self._port}/bench/"
-
-    def __enter__(self):
-        return self
-
-    def __exit__(self, *args):
-        self.stop()
-
-
-STRUCTURED_FILES = {
-    "small.txt": b"hello world\n",
-    "medium.txt": b"the quick brown fox jumps over the lazy dog\n" * 5000,
-    "binary.bin": bytes(range(256)) * 1000,
-    "nested/subdir/deep.txt": b"deeply nested file\n",
-    "nested/another.txt": b"another nested file\n" * 50,
-}
-
-
-class Progress:
-    """Simple progress bar with ETA."""
-
-    def __init__(self, total, label="Progress"):
-        self.total = total
-        self.current = 0
-        self.label = label
-        self.start_time = time.monotonic()
-        self._print()
-
-    def tick(self, detail=""):
-        self.current += 1
-        self._print(detail)
-
-    def _print(self, detail=""):
-        elapsed = time.monotonic() - self.start_time
-        if self.current > 0:
-            eta = elapsed / self.current * (self.total - self.current)
-            eta_str = f"ETA {eta:.0f}s"
-        else:
-            eta_str = "ETA ..."
-        pct = self.current / self.total * 100 if self.total else 0
-        bar_len = 30
-        filled = int(bar_len * self.current / self.total) if self.total else 0
-        bar = "#" * filled + "-" * (bar_len - filled)
-        detail_str = f"  {detail}" if detail else ""
-        sys.stderr.write(f"\r  [{bar}] {pct:5.1f}%  {self.current}/{self.total}  {eta_str}{detail_str}  ")
-        sys.stderr.flush()
-        if self.current >= self.total:
-            sys.stderr.write(f"\r  [{'#' * bar_len}] 100.0%  {self.total}/{self.total}  done in {elapsed:.1f}s" + " " * 30 + "\n")
-            sys.stderr.flush()
-
-
-def generate_bench_data(source_dir, size_mb=25, random_ratio=0.75):
-    """Generate test data. ~random_ratio is incompressible, rest is structured."""
-    if os.path.exists(source_dir):
-        shutil.rmtree(source_dir)
-    os.makedirs(source_dir)
-
-    target = size_mb * 1024 * 1024
-    structured_budget = int(target * (1 - random_ratio))
-    written = 0
-
-    for rel_path, content in STRUCTURED_FILES.items():
-        if written >= structured_budget:
-            break
-        full_path = os.path.join(source_dir, rel_path)
-        os.makedirs(os.path.dirname(full_path), exist_ok=True)
-        with open(full_path, "wb") as f:
-            f.write(content)
-        written += len(content)
-
-    os.makedirs(os.path.join(source_dir, "bulk"), exist_ok=True)
-    i = 0
-    while written < target:
-        chunk_size = min(5 * 1024 * 1024, target - written)
-        with open(os.path.join(source_dir, f"bulk/file_{i}.dat"), "wb") as f:
-            f.write(random.randbytes(chunk_size))
-        written += chunk_size
-        i += 1
-
-    return written
-
-
-def find_free_port():
-    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
-        s.bind(("", 0))
-        return s.getsockname()[1]
-
-
-def wait_for_port(port, timeout=5):
-    deadline = time.monotonic() + timeout
-    while time.monotonic() < deadline:
-        try:
-            with socket.create_connection(("127.0.0.1", port), timeout=0.3):
-                return
-        except (ConnectionRefusedError, OSError):
-            time.sleep(0.05)
-    raise RuntimeError(f"Port {port} not ready")
-
-
-def wait_proc(proc, timeout=5):
-    try:
-        proc.wait(timeout=timeout)
-    except subprocess.TimeoutExpired:
-        proc.kill()
-        proc.wait()
-
-
-def netem_apply(delay=None, jitter=None, throughput=None, loss=None):
-    """Apply tc/netem rules to loopback. Pass None to skip a parameter."""
-    netem_reset()
-    cmd = ["sudo", "tc", "qdisc", "add", "dev", "lo", "root", "netem"]
-    if throughput:
-        cmd += ["rate", throughput]
-    if delay:
-        cmd += ["delay", delay, jitter or "0ms"]
-    if loss:
-        cmd += ["loss", loss]
-    if len(cmd) > 6:
-        subprocess.run(cmd, check=True, capture_output=True)
-
-
-def netem_apply_profile(profile_name):
-    params = NETWORK_PROFILES.get(profile_name, {})
-    if not params:
-        netem_reset()
-        return
-    netem_apply(
-        delay=params.get("delay"),
-        jitter=params.get("jitter"),
-        throughput=params.get("rate"),
-        loss=params.get("loss"),
-    )
-
-
-def netem_reset():
-    subprocess.run("sudo tc qdisc del dev lo root".split(), capture_output=True)
-
-
-def run_fastsync(source_dir, dest_dir, flags, port):
-    """Run FastSync client. Returns duration or None."""
-    cmd = CLIENT_CMD + [
-        "--source-dir", source_dir,
-        "--dest-dir", dest_dir,
-        "--server-port", str(port),
-        "--save-to-disk",
-    ] + flags
-    try:
-        start = time.monotonic()
-        result = subprocess.run(cmd, capture_output=True, text=True, timeout=120)
-        duration = time.monotonic() - start
-        if result.returncode == 0:
-            return duration
-    except subprocess.TimeoutExpired:
-        pass
-    return None
-
-
-def run_rsync(source_dir, dest_dir, flags, rsync_daemon=None):
-    """Run rsync. Returns duration or None."""
-    src = source_dir.rstrip("/") + "/"
-    if rsync_daemon:
-        src = rsync_daemon.source_url
-    cmd = ["rsync", "-a", "--delete"] + flags + [src, dest_dir + "/"]
-    try:
-        start = time.monotonic()
-        result = subprocess.run(cmd, capture_output=True, text=True, timeout=120)
-        duration = time.monotonic() - start
-        if result.returncode == 0:
-            return duration
-    except subprocess.TimeoutExpired:
-        pass
-    return None
-
-
-def run_transfer(config, source_dir, dest_dir, port=None, rsync_daemon=None):
-    """Route to the right tool. Returns duration or None."""
-    if config["tool"] == "rsync":
-        return run_rsync(source_dir, dest_dir, config["flags"], rsync_daemon)
-    else:
-        return run_fastsync(source_dir, dest_dir, config["flags"], port)
-
-
-def run_benchmark(source_dir, dest_dir, configs, runs, profile_name, progress=None):
-    """Run benchmark for all configs, returns list of results."""
-    is_limited = profile_name != "unlimited"
-    has_rsync = any(c["tool"] == "rsync" for c in configs)
-    if is_limited:
-        netem_apply_profile(profile_name)
-
-    rsync_daemon = None
-    try:
-        if is_limited and has_rsync:
-            rsync_daemon = RsyncDaemon()
-            rsync_daemon.start(source_dir)
-
-        results = []
-        for config in configs:
-            times = []
-            for run_idx in range(runs):
-                if os.path.exists(dest_dir):
-                    shutil.rmtree(dest_dir)
-                os.makedirs(dest_dir, exist_ok=True)
-
-                port = find_free_port()
-                server = None
-                try:
-                    if config["tool"] == "fastsync":
-                        server = subprocess.Popen(
-                            SERVER_CMD + ["-p", str(port)],
-                            stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
-                        )
-                        wait_for_port(port)
-
-                    t = run_transfer(config, source_dir, dest_dir, port, rsync_daemon)
-                    if t is not None:
-                        times.append(t)
-                finally:
-                    if server:
-                        wait_proc(server)
-
-                if progress:
-                    progress.tick(f"{config['name']} (run {run_idx+1}/{runs})")
-
-            entry = {
-                "config": config["name"],
-                "tool": config["tool"],
-                "profile": profile_name,
-                "runs": len(times),
-                "times": [round(t, 4) for t in times],
-            }
-            if times:
-                entry["p50"] = round(statistics.median(times), 4)
-                entry["p95"] = round(sorted(times)[int(len(times) * 0.95)], 4) if len(times) > 1 else entry["p50"]
-                entry["min"] = round(min(times), 4)
-                entry["max"] = round(max(times), 4)
-                entry["stdev"] = round(statistics.stdev(times), 4) if len(times) > 1 else 0.0
-            results.append(entry)
-        return results
-    finally:
-        if rsync_daemon:
-            rsync_daemon.stop()
-        if is_limited:
-            netem_reset()
-
-
-def print_table(results, total_bytes, random_ratio):
-    """Print results as a human-readable table grouped by profile."""
-    profiles = {}
-    for r in results:
-        profiles.setdefault(r["profile"], []).append(r)
-
-    for profile, entries in profiles.items():
-        params = NETWORK_PROFILES.get(profile, {})
-        print(f"\n{'=' * 85}")
-        print(f" Profile: {profile.upper()}")
-        if params.get("rate"):
-            print(f" Network: {params['rate']}, {params['delay']} +/- {params['jitter']}, loss {params['loss']}")
-        else:
-            print(f" Network: unlimited")
-        print(f" Data: {total_bytes / (1024*1024):.1f} MB  ({random_ratio*100:.0f}% random, {(1-random_ratio)*100:.0f}% compressible)")
-        print(f"{'=' * 85}")
-
-        fs_entries = [e for e in entries if e.get("tool") == "fastsync"]
-        rsync_entries = [e for e in entries if e.get("tool") == "rsync"]
-
-        if fs_entries:
-            print(f"\n FastSync:")
-            print(f" {'Config':<25} {'p50':>8} {'p95':>8} {'min':>8} {'max':>8} {'stdev':>8} {'runs':>5}")
-            print(f" {'-' * 25} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 5}")
-            for e in sorted(fs_entries, key=lambda x: x.get("p50", 999)):
-                _print_entry(e)
-
-        if rsync_entries:
-            print(f"\n rsync:")
-            print(f" {'Config':<25} {'p50':>8} {'p95':>8} {'min':>8} {'max':>8} {'stdev':>8} {'runs':>5}")
-            print(f" {'-' * 25} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 8} {'-' * 5}")
-            for e in sorted(rsync_entries, key=lambda x: x.get("p50", 999)):
-                _print_entry(e)
-
-        if params.get("rate_bps") and fs_entries and rsync_entries:
-            fs_best = min((e["p50"] for e in fs_entries if "p50" in e), default=None)
-            rsync_best = min((e["p50"] for e in rsync_entries if "p50" in e), default=None)
-            theoretical = total_bytes / params["rate_bps"]
-            if fs_best and rsync_best:
-                print(f"\n Theoretical max (line rate): {theoretical:.4f}s")
-                print(f" FastSync best:   {fs_best:.4f}s  ({theoretical/fs_best:.2f}x vs line rate)")
-                print(f" rsync best:      {rsync_best:.4f}s  ({theoretical/rsync_best:.2f}x vs line rate)")
-                print(f" FastSync vs rsync: {rsync_best/fs_best:.2f}x faster")
-
-
-def _print_entry(e):
-    if "p50" in e:
-        print(f" {e['config']:<25} {e['p50']:>7.4f}s {e['p95']:>7.4f}s "
-              f"{e['min']:>7.4f}s {e['max']:>7.4f}s {e['stdev']:>7.4f} {e['runs']:>5}")
-    else:
-        print(f" {e['config']:<25} {'N/A':>8} {'N/A':>8} {'N/A':>8} {'N/A':>8} {'N/A':>8} {e['runs']:>5}")
-
-
-def main():
-    parser = argparse.ArgumentParser(
-        description="FastSync benchmark tool — compares FastSync vs rsync",
-        formatter_class=argparse.RawDescriptionHelpFormatter,
-        epilog="""\
-Network profiles (predefined):
-  unlimited   No artificial limits
-  lan         1 Gbit, 20ms delay, 1ms jitter, 0.1%% loss
-  wan         100 Mbit, 50ms delay, 10ms jitter, 1%% loss
-
-Custom network limits (--delay/--jitter/--throughput) override profiles.
-
-Data mix:
-  Default is ~75%% random/incompressible + ~25%% structured/compressible,
-  reflecting typical real-world file sets.
-
-Examples:
-  %(prog)s --profiles wan --runs 5
-  %(prog)s --throughput 50mbit --delay 30ms --jitter 5ms
-  %(prog)s --random-ratio 0.5 --size-mb 100
-""")
-    parser.add_argument("--runs", type=int, default=3,
-                        help="Number of runs per config (default: 3)")
-    parser.add_argument("--profiles", nargs="+", default=None,
-                        choices=list(NETWORK_PROFILES.keys()),
-                        help="Predefined network profiles (default: unlimited)")
-    parser.add_argument("--configs", nargs="+", default=None,
-                        help="Custom FastSync config flags")
-    parser.add_argument("--size-mb", type=int, default=25,
-                        help="Test data size in MB (default: 25)")
-    parser.add_argument("--random-ratio", type=float, default=0.75,
-                        help="Fraction of data that is random/incompressible (default: 0.75)")
-    parser.add_argument("--delay", default=None,
-                        help="Custom network delay (e.g. 50ms)")
-    parser.add_argument("--jitter", default=None,
-                        help="Custom network jitter (e.g. 10ms)")
-    parser.add_argument("--throughput", default=None,
-                        help="Custom throughput limit (e.g. 100mbit)")
-    parser.add_argument("--loss", default=None,
-                        help="Custom packet loss (e.g. 1%%)")
-    parser.add_argument("--no-rsync", action="store_true",
-                        help="Skip rsync comparison")
-    parser.add_argument("--progress", action="store_true",
-                        help="Show progress bar with ETA")
-    parser.add_argument("--output", choices=["table", "json"], default="table",
-                        help="Output format")
-    parser.add_argument("--keep-data", action="store_true",
-                        help="Don't clean up test data")
-    args = parser.parse_args()
-
-    # Build
-    print("Building...")
-    if os.system(f"cmake -B {BUILD_DIR} -S {PROJECT_ROOT} > /dev/null 2>&1") != 0:
-        print("CMake configure failed"); sys.exit(1)
-    if os.system(f"cmake --build {BUILD_DIR} -j$(nproc) > /dev/null 2>&1") != 0:
-        print("Build failed"); sys.exit(1)
-
-    # Determine active profile for display
-    has_custom_net = args.delay or args.jitter or args.throughput or args.loss
-    if has_custom_net:
-        active_profile = "custom"
-        NETWORK_PROFILES["custom"] = {
-            "rate": args.throughput, "delay": args.delay or "0ms",
-            "jitter": args.jitter or "0ms", "loss": args.loss or "0%",
-        }
-        if args.throughput:
-            parts = args.throughput.replace("mbit", "").replace("mbps", "")
-            try:
-                NETWORK_PROFILES["custom"]["rate_bps"] = float(parts) * 1_000_000 / 8
-            except ValueError:
-                pass
-        profiles_to_run = ["custom"]
-    else:
-        profiles_to_run = args.profiles or ["unlimited"]
-
-    # Generate data
-    source_dir = os.path.join(BENCH_DIR, "source")
-    dest_dir = os.path.join(BENCH_DIR, "dest")
-    total_bytes = generate_bench_data(source_dir, args.size_mb, args.random_ratio)
-    compressible_pct = (1 - args.random_ratio) * 100
-    random_pct = args.random_ratio * 100
-    print(f"Generated {total_bytes / (1024*1024):.1f} MB  "
-          f"({random_pct:.0f}% random, {compressible_pct:.0f}% compressible)")
-
-    # Build config list
-    if args.configs:
-        fastsync_configs = [{"name": c, "flags": c.split(), "tool": "fastsync"} for c in args.configs]
-    else:
-        fastsync_configs = list(FASTSYNC_CONFIGS)
-
-    configs = list(fastsync_configs)
-    if not args.no_rsync:
-        configs += RSYNC_CONFIGS
-
-    # Run benchmarks
-    total_runs = len(configs) * args.runs * len(profiles_to_run)
-    progress = Progress(total_runs, "Benchmarking") if args.progress else None
-    if progress:
-        print(f"Running {total_runs} transfers...")
-
-    all_results = []
-    try:
-        for profile in profiles_to_run:
-            results = run_benchmark(source_dir, dest_dir, configs, args.runs, profile, progress)
-            all_results.extend(results)
-    finally:
-        if not args.keep_data:
-            shutil.rmtree(BENCH_DIR, ignore_errors=True)
-
-    # Output
-    if args.output == "json":
-        print(json.dumps(all_results, indent=2))
-    else:
-        print_table(all_results, total_bytes, args.random_ratio)
-        print()
-
-
-if __name__ == "__main__":
-    main()

opencode.json

@@ -1,11 +1,10 @@
 {
   "$schema": "https://opencode.ai/config.json",
-	"instructions": ["AGENTS.md"],
 	"permission": {
 		"bash": {
 			"*": "allow",
 			"git push origin main": "deny",
-			"git push main": "deny"
+			"git push main": "ask"
 		}
 	}
 }

shell.nix

@@ -14,8 +14,6 @@ pkgs.mkShell {
 
   buildInputs = with pkgs; [
     zstd
-    openssl
-    (python3.withPackages (ps: with ps; [ pytest ]))
   ];
 
   NIX_ENFORCE_PURITY = 0;

src/client/client_cli.c

@@ -1,9 +1,7 @@
 #include "client_send.h"
 #include "config.h"
-#include "delta.h"
 #include "log.h"
 #include "protocol.h"
-#include "transport_tls.h"
 #include "utils.h"
 #include <errno.h>
 #include <limits.h>
@@ -11,6 +9,9 @@
 #include <stdlib.h>
 #include <string.h>
 
+char *server_host = "127.0.0.1";
+int server_port = 8080;
+
 static void print_usage(void) {
   printf("Usage:\n");
   printf("  fastsync [options] <source> <destination>\n");
@@ -34,11 +35,6 @@ static void print_usage(void) {
   printf("  --max-size <n>      Skip files larger than n bytes\n");
   printf("  --min-size <n>      Skip files smaller than n bytes\n");
   printf("  --incremental       Skip files unchanged since last transfer\n");
-  printf("  --delta             Delta transfer for changed files (requires --incremental)\n");
-  printf("  --delta-block <n>   Delta block size in bytes (default: %d)\n",
-         DELTA_BLOCK_SIZE_DEFAULT);
-  printf("  --delta-max <n>     Max file size for delta transfer (default: %llu)\n",
-         DELTA_MAX_FILE_SIZE);
   printf("  -m                  Enable multithreading\n");
   printf("  -s                  Enable chunk serialization\n");
   printf("  -f                  Enable sendfile (TCP only, not with -c or -s)\n");
@@ -51,29 +47,22 @@ static void print_usage(void) {
   printf("  --server-host <ip>  Server IP address (default: 127.0.0.1)\n");
   printf("  --server-port <n>   Server port (default: 8080)\n");
   printf("  --bwlimit <KB/s>    Bandwidth limit in kilobytes per second\n");
-  printf("  --tls               Enable TLS encryption\n");
-  printf("  --cert <path>       TLS certificate file (PEM)\n");
-  printf("  --key <path>        TLS private key file (PEM)\n");
-  printf("  --ca <path>         TLS CA certificate file (PEM)\n");
-  printf("  --partial           Keep partial files on interrupted transfer\n");
   printf("  --help              Show this help\n");
-  printf("  -V, --version       Show version and exit\n");
 }
 
-int main(int argc, char* argv[]) {
-  const char* env_source = getenv("FASTSYNC_SOURCE_DIR");
-  const char* env_dest = getenv("FASTSYNC_DEST_DIR");
-  const char* env_save = getenv("FASTSYNC_SAVE_TO_DISK");
+int main(int argc, char *argv[]) {
+  const char *env_source = getenv("FASTSYNC_SOURCE_DIR");
+  const char *env_dest = getenv("FASTSYNC_DEST_DIR");
+  const char *env_save = getenv("FASTSYNC_SAVE_TO_DISK");
 
   bool save_to_disk = false;
-  if (env_save && (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0)) {
+  if (env_save &&
+      (strcmp(env_save, "true") == 0 || strcmp(env_save, "1") == 0)) {
     save_to_disk = true;
   }
 
-  Config* config = config_create(str_dup(PROTOCOL_VERSION), NULL, NULL, save_to_disk, false, false,
-                                 false, false, 5, false, 0);
-  int exit_code = 0;
-  bool config_owned_by_pipeline = false;
+  Config *config = config_create(str_dup(PROTOCOL_VERSION), NULL, NULL,
+                                 save_to_disk, false, false, false, false, 5, false, 0);
 
   int positional_args[2];
   int positional_count = 0;
@@ -81,10 +70,7 @@ int main(int argc, char* argv[]) {
   for (int i = 1; i < argc; i++) {
     if (strcmp(argv[i], "--help") == 0) {
       print_usage();
-      goto cleanup;
-    } else if (strcmp(argv[i], "-V") == 0 || strcmp(argv[i], "--version") == 0) {
-      printf("fastsync version %s\n", PROTOCOL_VERSION);
-      goto cleanup;
+      return 0;
     } else if (strcmp(argv[i], "-a") == 0 || strcmp(argv[i], "--archive") == 0) {
       config->use_compression = true;
       config->use_multithreading = true;
@@ -93,63 +79,33 @@ int main(int argc, char* argv[]) {
     } else if (strcmp(argv[i], "-n") == 0 || strcmp(argv[i], "--dry-run") == 0) {
       config->dry_run = true;
     } else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
-      char* end;
-      long p = strtol(argv[++i], &end, 10);
-      if (*end != '\0' || p <= 0 || p > 65535) {
-        fprintf(stderr, "Error: invalid SSH port '%s' (must be 1-65535)\n", argv[i]);
-        exit_code = 1;
-        goto cleanup;
-      }
-      config->ssh_port = (int)p;
+      config->ssh_port = atoi(argv[++i]);
     } else if (strcmp(argv[i], "--delete") == 0) {
       config->use_delete = true;
     } else if (strcmp(argv[i], "--exclude") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->exclude_patterns, (config->exclude_count + 1) * sizeof(char*));
-      if (!tmp) {
-        fprintf(stderr, "Error: memory allocation failed for --exclude\n");
-        exit_code = 1;
-        goto cleanup;
-      }
-      config->exclude_patterns = tmp;
-      config->exclude_patterns[config->exclude_count++] = str_dup(argv[++i]);
+      int idx = config->exclude_count++;
+      config->exclude_patterns = realloc(config->exclude_patterns, config->exclude_count * sizeof(char *));
+      config->exclude_patterns[idx] = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--include") == 0 && i + 1 < argc) {
-      char** tmp = realloc(config->include_patterns, (config->include_count + 1) * sizeof(char*));
-      if (!tmp) {
-        fprintf(stderr, "Error: memory allocation failed for --include\n");
-        exit_code = 1;
-        goto cleanup;
-      }
-      config->include_patterns = tmp;
-      config->include_patterns[config->include_count++] = str_dup(argv[++i]);
+      int idx = config->include_count++;
+      config->include_patterns = realloc(config->include_patterns, config->include_count * sizeof(char *));
+      config->include_patterns[idx] = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--max-size") == 0 && i + 1 < argc) {
       config->max_size = strtoull(argv[++i], NULL, 10);
     } else if (strcmp(argv[i], "--min-size") == 0 && i + 1 < argc) {
       config->min_size = strtoull(argv[++i], NULL, 10);
     } else if (strcmp(argv[i], "--incremental") == 0) {
       config->use_incremental = true;
-    } else if (strcmp(argv[i], "--delta") == 0) {
-      config->use_delta = true;
-    } else if (strcmp(argv[i], "--delta-block") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val >= DELTA_BLOCK_SIZE_MIN && val <= DELTA_BLOCK_SIZE_MAX)
-        config->delta_block_size = (uint32_t)val;
-      else
-        fprintf(stderr, "Warning: --delta-block value %llu out of range, using default\n", val);
-    } else if (strcmp(argv[i], "--delta-max") == 0 && i + 1 < argc) {
-      unsigned long long val = strtoull(argv[++i], NULL, 10);
-      if (val >= DELTA_MIN_FILE_SIZE)
-        config->delta_max_file_size = val;
-      else
-        fprintf(stderr, "Warning: --delta-max value %llu too small, using default\n", val);
     } else if (strcmp(argv[i], "-c") == 0 || strcmp(argv[i], "-z") == 0) {
       config->use_compression = true;
       log_message(LOG_LEVEL_INFO, "Enabled Compression");
       if (i + 1 < argc) {
-        char* end_ptr;
+        char *end_ptr;
         int level = strtol(argv[i + 1], &end_ptr, 10);
         if (*end_ptr == '\0') {
           config->compression_level = level;
-          log_message(LOG_LEVEL_INFO, "Set Compression level to %d", config->compression_level);
+          log_message(LOG_LEVEL_INFO, "Set Compression level to %d",
+                      config->compression_level);
           i++;
         }
       }
@@ -174,30 +130,21 @@ int main(int argc, char* argv[]) {
       config->use_chunk_serialization = true;
       log_message(LOG_LEVEL_INFO, "Enabled Chunk Serialization");
     } else if (strcmp(argv[i], "--server-host") == 0 && i + 1 < argc) {
-      free(config->server_host);
-      config->server_host = str_dup(argv[++i]);
+      free(server_host);
+      server_host = str_dup(argv[++i]);
     } else if (strcmp(argv[i], "--server-port") == 0 && i + 1 < argc) {
-      char* end;
-      long p = strtol(argv[++i], &end, 10);
-      if (*end != '\0' || p <= 0 || p > 65535) {
-        fprintf(stderr, "Error: invalid server port '%s' (must be 1-65535)\n", argv[i]);
-        exit_code = 1;
-        goto cleanup;
-      }
-      config->server_port = (int)p;
+      server_port = atoi(argv[++i]);
     } else if (strcmp(argv[i], "--bwlimit") == 0 && i + 1 < argc) {
-      char* end;
+      char *end;
       errno = 0;
       unsigned long long kbps = strtoull(argv[++i], &end, 10);
       if (errno != 0 || *end != '\0' || kbps == 0) {
         fprintf(stderr, "Error: --bwlimit must be a positive integer\n");
-        exit_code = 1;
-        goto cleanup;
+        return 1;
       }
       if (kbps > ULLONG_MAX / 1024) {
         fprintf(stderr, "Error: --bwlimit value too large\n");
-        exit_code = 1;
-        goto cleanup;
+        return 1;
       }
       io_set_bwlimit(kbps * 1024);
       log_message(LOG_LEVEL_INFO, "Set bandwidth limit to %llu KB/s", kbps);
@@ -207,34 +154,19 @@ int main(int argc, char* argv[]) {
       unsigned long long val = strtoull(argv[++i], NULL, 10);
       if (val > 0)
         config->chunk_size = val;
-    } else if (strcmp(argv[i], "--tls") == 0) {
-      config->use_tls = true;
-    } else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
-      free(config->tls_cert);
-      config->tls_cert = str_dup(argv[++i]);
-    } else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
-      free(config->tls_key);
-      config->tls_key = str_dup(argv[++i]);
-    } else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
-      free(config->tls_ca);
-      config->tls_ca = str_dup(argv[++i]);
-    } else if (strcmp(argv[i], "--partial") == 0) {
-      config->partial = true;
     } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
       set_log_level(LOG_LEVEL_DEBUG);
     } else if (argv[i][0] == '-') {
       fprintf(stderr, "Unknown option: %s\n", argv[i]);
       print_usage();
-      exit_code = 1;
-      goto cleanup;
+      return 1;
     } else {
       if (positional_count < 2)
         positional_args[positional_count++] = i;
       else {
         fprintf(stderr, "Unexpected argument: %s\n", argv[i]);
         print_usage();
-        exit_code = 1;
-        goto cleanup;
+        return 1;
       }
     }
   }
@@ -250,38 +182,32 @@ int main(int argc, char* argv[]) {
   } else if (positional_count == 1) {
     fprintf(stderr, "Error: missing destination argument\n");
     print_usage();
-    exit_code = 1;
-    goto cleanup;
+    return 1;
   } else {
     if (!config->send_directory && env_source)
-      config->send_directory = str_dup((char*)env_source);
+      config->send_directory = str_dup((char *)env_source);
     if (!config->receive_root_directory && env_dest)
-      config->receive_root_directory = str_dup((char*)env_dest);
+      config->receive_root_directory = str_dup((char *)env_dest);
   }
 
   if (!config->send_directory || !config->receive_root_directory) {
     fprintf(stderr, "Error: source and destination directories are required\n");
     print_usage();
-    exit_code = 1;
-    goto cleanup;
+    return 1;
   }
   if (config->use_sendfile && (config->use_chunk_serialization || config->use_compression)) {
-    fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk "
-                    "serialization)\n");
-    exit_code = 1;
-    goto cleanup;
+    fprintf(stderr, "Error: -f/--sendfile cannot be combined with -c (compression) or -s (chunk serialization)\n");
+    return 1;
   }
 
   if (config->transport == TRANSPORT_SSH && config->use_sendfile) {
     fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
-    exit_code = 1;
-    goto cleanup;
+    return 1;
   }
 
   if (config->use_incremental && config->use_chunk_serialization) {
     fprintf(stderr, "Error: --incremental is not supported with -s (chunk serialization)\n");
-    exit_code = 1;
-    goto cleanup;
+    return 1;
   }
 
   if (config->use_incremental && !config->use_metadata) {
@@ -289,44 +215,7 @@ int main(int argc, char* argv[]) {
     config->use_metadata = true;
   }
 
-  if (config->use_delta && !config->use_incremental) {
-    fprintf(stderr, "Error: --delta requires --incremental\n");
-    exit_code = 1;
-    goto cleanup;
-  }
-  if (config->use_delta && config->use_chunk_serialization) {
-    fprintf(stderr, "Error: --delta cannot be combined with -s (chunk serialization)\n");
-    exit_code = 1;
-    goto cleanup;
-  }
-  if (config->use_delta && config->use_sendfile) {
-    fprintf(stderr, "Error: --delta cannot be combined with -f (sendfile)\n");
-    exit_code = 1;
-    goto cleanup;
-  }
-  if (config->use_delta && !config->use_metadata) {
-    log_message(LOG_LEVEL_INFO, "Enabling metadata preservation for --delta");
-    config->use_metadata = true;
-  }
-
-  if (config->use_tls) {
-    if (!config->tls_cert || !config->tls_key) {
-      fprintf(stderr, "Error: --tls requires --cert and --key\n");
-      exit_code = 1;
-      goto cleanup;
-    }
-    tls_global_init();
-  }
-
-  if (config->use_multithreading) {
-    config_owned_by_pipeline = true;
-    exit_code = send_files_multithreaded(config);
-  } else {
-    exit_code = send_files(config);
-  }
-
-cleanup:
-  if (!config_owned_by_pipeline)
-    config_delete(config);
-  return exit_code;
+  if (config->use_multithreading)
+    return send_files_multithreaded(config);
+  return send_files(config);
 }

src/client/client_send.c

@@ -1,12 +1,9 @@
 #include "client_send.h"
 #include "array_list.h"
 #include "chunk.h"
-#include "compression.h"
 #include "config.h"
 #include "data.h"
-#include "delta.h"
 #include "file.h"
-#include "metadata.h"
 #include "log.h"
 #include "multiprocessing.h"
 #include "protocol.h"
@@ -14,7 +11,6 @@
 #include "scanner.h"
 #include "transport_tcp.h"
 #include "transport_ssh.h"
-#include "transport_tls.h"
 #include "utils.h"
 #include <stdio.h>
 #include <stdlib.h>
@@ -22,38 +18,20 @@
 #include <threads.h>
 #include <time.h>
 
-static int incremental_check(Client* client, File* file, DeltaSignature** out_sig) {
-  *out_sig = NULL;
-  if (!send_status(client->file_descriptor, STATUS_CHECK))
-    return -1;
-  if (!send_str(client->file_descriptor, file->path))
-    return -1;
+static int incremental_check(Client *client, File *file) {
+  if (!send_status(client->file_descriptor, STATUS_CHECK)) return -1;
+  if (!send_str(client->file_descriptor, file->path)) return -1;
   unsigned long long fsize = file->data->size;
   long long mtime = file->metadata ? file->metadata->mtime_sec : 0;
-  if (!send_n_data(client->file_descriptor, &fsize, sizeof(fsize)))
-    return -1;
-  if (!send_n_data(client->file_descriptor, &mtime, sizeof(mtime)))
-    return -1;
+  if (!send_n_data(client->file_descriptor, &fsize, sizeof(fsize))) return -1;
+  if (!send_n_data(client->file_descriptor, &mtime, sizeof(mtime))) return -1;
   Status s;
-  if (!receive_status(client->file_descriptor, &s))
-    return -1;
+  if (!receive_status(client->file_descriptor, &s)) return -1;
   if (s == STATUS_ERROR) {
     log_message(LOG_LEVEL_ERROR, "Server reported error for file");
     return -1;
   }
-  if (s == STATUS_OK)
-    return 1;
-  if (s == STATUS_DELTA_SIGNATURE) {
-    Data* sig_data = receive_data(client->file_descriptor);
-    if (!sig_data)
-      return -1;
-    DeltaSignature* sig = delta_signature_deserialize(sig_data);
-    data_destroy(sig_data);
-    if (!sig)
-      return -1;
-    *out_sig = sig;
-    return 2;
-  }
+  if (s == STATUS_OK) return 1;
   if (s != STATUS_NEXT) {
     log_message(LOG_LEVEL_ERROR, "Unexpected server status");
     return -1;
@@ -61,190 +39,69 @@ static int incremental_check(Client* client, File* file, DeltaSignature** out_si
   return 0;
 }
 
-static int send_delta(Client* client, File* file, DeltaSignature* sig, Config* config) {
-  Delta* delta = delta_compute(file->data->data, file->data->size, sig, config->delta_block_size);
-  if (!delta)
-    return 1;
-
-  if (!delta_is_worthwhile(delta, file->data->size)) {
-    delta_destroy(delta);
-    if (!send_status(client->file_descriptor, STATUS_NEXT))
-      return -1;
-    return 1;
-  }
-
-  Data* delta_data = delta_serialize(delta);
-  delta_destroy(delta);
-  if (!delta_data)
-    return -1;
-
-  Data* to_send = delta_data;
-  if (config->use_compression) {
-    to_send = data_compress(delta_data, config->compression_level);
-    data_destroy(delta_data);
-    if (!to_send)
-      return -1;
-  }
-
-  bool ok = send_status(client->file_descriptor, STATUS_DELTA_DATA) &&
-            send_data(client->file_descriptor, to_send);
-
-  if (ok && config->use_metadata)
-    ok = metadata_send(client->file_descriptor, file->metadata);
-
-  data_destroy(to_send);
-  return ok ? 0 : -1;
-}
-
-typedef bool (*file_send_fn)(File*, int, bool, int, bool);
-
-// Send a single file directly (non-incremental path).
-static bool send_file_direct(File* file, int fd, bool use_metadata, int compression_level) {
-  if (!send_status(fd, STATUS_NEXT))
-    return false;
-  return file_send_single_calls(file, fd, use_metadata, compression_level, true);
-}
-
-// Send a single file directly via sendfile (non-incremental path).
-static bool send_file_direct_sendfile(File* file, int fd, bool use_metadata) {
-  if (!send_status(fd, STATUS_NEXT))
-    return false;
-  return file_send_sendfile(file, fd, use_metadata, 0, true);
-}
-
-// Process one file in a chunk: either via incremental check or direct send.
-// Returns 0 on success, 1 if skipped (incremental match), -1 on error.
-static int send_single_file(Client* client, File* file, Config* config, bool use_incremental,
-                            bool use_sendfile) {
-  int compression_level = config->use_compression ? config->compression_level : 0;
-
-  if (!use_incremental) {
-    if (use_sendfile) {
-      return send_file_direct_sendfile(file, client->file_descriptor, config->use_metadata) ? 0
-                                                                                            : -1;
-    }
-    return send_file_direct(file, client->file_descriptor, config->use_metadata, compression_level)
-               ? 0
-               : -1;
-  }
-
-  // Incremental path: use sendfile for the actual data if enabled and no compression
-  if (use_sendfile) {
-    DeltaSignature* sig = NULL;
-    int rc = incremental_check(client, file, &sig);
-    if (rc == 1) {
-      delta_signature_destroy(sig);
-      return 1;
-    }
-    if (rc < 0) {
-      delta_signature_destroy(sig);
-      return -1;
-    }
-    // rc == 0: unchanged file, skip
-    // rc == 2: server sent delta signature but sendfile doesn't support delta
-    delta_signature_destroy(sig);
-    if (rc == 2) {
-      // Server is waiting for STATUS_NEXT after delta handshake
-      if (!send_status(client->file_descriptor, STATUS_NEXT))
-        return -1;
-    }
-    // Fall through: send full file via sendfile (pass 0 for compression_level)
-    if (!file_send_sendfile(file, client->file_descriptor, config->use_metadata, 0, false))
-      return -1;
-    return 0;
-  }
-
-  // Incremental path with single_calls (supports compression and delta)
-  file_send_fn send_fn = (file_send_fn)file_send_single_calls;
-  DeltaSignature* sig = NULL;
-  int rc = incremental_check(client, file, &sig);
-  if (rc < 0) {
-    delta_signature_destroy(sig);
-    return -1;
-  }
-  if (rc == 1) {
-    delta_signature_destroy(sig);
-    return 1;
-  }
-  if (rc == 2 && config->use_delta) {
-    int drc = send_delta(client, file, sig, config);
-    delta_signature_destroy(sig);
-    if (drc == 0)
-      return 0;
-    if (drc < 0)
-      return -1;
-  } else {
-    delta_signature_destroy(sig);
-    // rc == 2 can happen if server sends STATUS_DELTA_SIGNATURE but
-    // use_delta is false on the client side. Send STATUS_NEXT to
-    // tell the server to proceed with the full file transfer.
-    if (rc == 2) {
-      if (!send_status(client->file_descriptor, STATUS_NEXT))
-        return -1;
-    }
-  }
-  if (!send_fn(file, client->file_descriptor, config->use_metadata, compression_level, false))
-    return -1;
-  return 0;
-}
-
-int send_chunk(Client* client, Chunk* chunk, Config* config) {
+int send_chunk(Client *client, Chunk *chunk, Config *config) {
   if (config->use_chunk_serialization) {
-    if (!send_status(client->file_descriptor, STATUS_CHUNK))
-      return -1;
-    Data* data;
+    if (!send_status(client->file_descriptor, STATUS_CHUNK)) return -1;
+    Data *data;
     if (config->use_compression) {
       data = chunk_compress(chunk, config->compression_level, config->use_metadata);
     } else {
       data = chunk_serialize(chunk, config->use_metadata);
     }
-    if (data == NULL)
-      return -1;
-    if (!send_data(client->file_descriptor, data)) {
+    if (data == NULL) return -1;
+    if (!send_data(client->file_descriptor, data)) { data_destroy(data); return -1; }
     data_destroy(data);
-      return -1;
-    }
-    data_destroy(data);
-    return 0;
-  }
-
-  bool use_sendfile = config->use_sendfile && !config->use_compression;
+  } else if (config->use_sendfile && !config->use_compression) {
     for (int i = 0; i < chunk->element_count; i++) {
-    int rc =
-        send_single_file(client, chunk->items[i], config, config->use_incremental, use_sendfile);
-    if (rc == 1)
-      continue;
-    if (rc < 0)
+      if (config->use_incremental) {
+        int rc = incremental_check(client, chunk->items[i]);
+        if (rc < 0) return -1;
+        if (rc > 0) continue;
+        if (!file_send_sendfile(chunk->items[i], client->file_descriptor, config->use_metadata, false))
           return -1;
+      } else {
+        if (!send_status(client->file_descriptor, STATUS_NEXT)) return -1;
+        if (!file_send_sendfile(chunk->items[i], client->file_descriptor, config->use_metadata, true))
+          return -1;
+      }
+    }
+  } else {
+    for (int i = 0; i < chunk->element_count; i++) {
+      if (config->use_incremental) {
+        int rc = incremental_check(client, chunk->items[i]);
+        if (rc < 0) return -1;
+        if (rc > 0) continue;
+        if (!file_send_single_calls(chunk->items[i], client->file_descriptor,
+                                   config->use_metadata,
+                                   config->use_compression ? config->compression_level : 0,
+                                   false))
+          return -1;
+      } else {
+        if (!send_status(client->file_descriptor, STATUS_NEXT)) return -1;
+        if (!file_send_single_calls(chunk->items[i], client->file_descriptor,
+                               config->use_metadata,
+                               config->use_compression ? config->compression_level : 0,
+                               true))
+          return -1;
+      }
+    }
   }
   return 0;
 }
 
-static int send_chunks_multithreaded(void* pipeline_context) {
-  PipelineContextSender* context = (PipelineContextSender*)pipeline_context;
-  Client* client;
+static int send_chunks_multithreaded(void *pipeline_context) {
+  PipelineContextSender *context = (PipelineContextSender *)pipeline_context;
+  Client *client;
   if (context->config->transport == TRANSPORT_SSH) {
     if (context->config->use_sendfile) {
       fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
       return 1;
     }
     client = client_connect_ssh(context->config->ssh_destination, context->config->ssh_port);
-  } else if (context->config->use_tls) {
-    client = client_create();
-    if (!client || !client_connect_tls(client, context->config->server_host,
-                                       context->config->server_port, context->config->tls_cert,
-                                       context->config->tls_key, context->config->tls_ca)) {
-      if (client)
-        client_delete(client);
-      fprintf(stderr, "Error: could not connect to server via TLS\n");
-      return thrd_error;
-    }
   } else {
     client = client_create();
-    if (!client ||
-        !client_connect(client, context->config->server_host, context->config->server_port)) {
-      if (client)
-        client_delete(client);
+    if (!client || !client_connect(client, server_host, server_port)) {
+      if (client) client_delete(client);
       fprintf(stderr, "Error: could not connect to server\n");
       return thrd_error;
     }
@@ -256,32 +113,24 @@ static int send_chunks_multithreaded(void* pipeline_context) {
   }
 
   while (true) {
-    Chunk* current_chunk = queue_dequeue_multithreaded(
-        context->queue_loader, &context->mutex_loader, &context->condition_not_empty_loader,
+    Chunk *current_chunk = queue_dequeue_multithreaded(
+        context->queue_loader, &context->mutex_loader,
+        &context->condition_not_empty_loader,
         &context->condition_not_full_loader, &context->loader_done);
     if (current_chunk == NULL) {
       if (context->config->use_delete) {
-        if (!send_status(client->file_descriptor, STATUS_MANIFEST))
-          goto send_fail;
-        if (!send_int(client->file_descriptor, context->manifest->size))
-          goto send_fail;
-        for (int i = 0; i < context->manifest->size; i++) {
-          if (!send_str(client->file_descriptor, (char*)context->manifest->items[i]))
-            goto send_fail;
+        send_status(client->file_descriptor, STATUS_MANIFEST);
+        send_int(client->file_descriptor, context->manifest->size);
+        for (int i = 0; i < context->manifest->size; i++)
+          send_str(client->file_descriptor,
+                   (char *)context->manifest->items[i]);
       }
-      }
-      if (!send_status(client->file_descriptor, STATUS_FINISHED))
-        goto send_fail;
+      send_status(client->file_descriptor, STATUS_FINISHED);
       Status s;
       int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
       client_disconnect(client);
       client_delete(client);
       return ok ? thrd_success : thrd_error;
-
-    send_fail:
-      client_disconnect(client);
-      client_delete(client);
-      return thrd_error;
     }
     if (send_chunk(client, current_chunk, context->config) != 0) {
       fprintf(stderr, "Error: unexpected error while sending chunk\n");
@@ -293,29 +142,30 @@ static int send_chunks_multithreaded(void* pipeline_context) {
   }
 }
 
-static int scan_directory_multithreaded(void* pipeline_context) {
-  PipelineContextSender* context = (PipelineContextSender*)pipeline_context;
+static int scan_directory_multithreaded(void *pipeline_context) {
+  PipelineContextSender *context = (PipelineContextSender *)pipeline_context;
   mtx_lock(&context->mutex_scanner);
-  DirectoryScanner* scanner = directory_scanner_create(
-      context->config->send_directory, context->config->use_metadata, context->config->chunk_size,
-      context->config->exclude_patterns, context->config->exclude_count,
-      context->config->include_patterns, context->config->include_count, context->config->max_size,
+  DirectoryScanner *scanner = directory_scanner_create(
+      context->config->send_directory, context->config->use_metadata,
+      context->config->chunk_size, context->config->exclude_patterns,
+      context->config->exclude_count, context->config->include_patterns,
+      context->config->include_count, context->config->max_size,
       context->config->min_size);
   mtx_unlock(&context->mutex_scanner);
 
-  Chunk* current_chunk;
+  Chunk *current_chunk;
   while ((current_chunk = directory_scanner_next(scanner)) != NULL) {
     if (context->config->use_delete) {
       mtx_lock(&context->mutex_scanner);
       for (int i = 0; i < current_chunk->element_count; i++) {
-        const char* p = current_chunk->items[i]->path;
-        if (*p == '/')
-          p++;
+        const char *p = current_chunk->items[i]->path;
+        if (*p == '/') p++;
         array_list_add(context->manifest, str_dup(p));
       }
       mtx_unlock(&context->mutex_scanner);
     }
-    queue_enqueue_multithreaded(context->queue_scanner, current_chunk, &context->mutex_scanner,
+    queue_enqueue_multithreaded(context->queue_scanner, current_chunk,
+                                &context->mutex_scanner,
                                 &context->condition_not_empty_scanner,
                                 &context->condition_not_full_scanner);
   }
@@ -328,11 +178,12 @@ static int scan_directory_multithreaded(void* pipeline_context) {
   return thrd_success;
 }
 
-static int load_files_multithreaded(void* pipeline_context) {
-  PipelineContextSender* context = (PipelineContextSender*)pipeline_context;
+static int load_files_multithreaded(void *pipeline_context) {
+  PipelineContextSender *context = (PipelineContextSender *)pipeline_context;
   while (true) {
-    Chunk* chunk = queue_dequeue_multithreaded(
-        context->queue_scanner, &context->mutex_scanner, &context->condition_not_empty_scanner,
+    Chunk *chunk = queue_dequeue_multithreaded(
+        context->queue_scanner, &context->mutex_scanner,
+        &context->condition_not_empty_scanner,
         &context->condition_not_full_scanner, &context->scanner_done);
     if (chunk == NULL) {
       mtx_lock(&context->mutex_loader);
@@ -350,58 +201,51 @@ static int load_files_multithreaded(void* pipeline_context) {
         }
       }
     }
-    queue_enqueue_multithreaded(context->queue_loader, chunk, &context->mutex_loader,
+    queue_enqueue_multithreaded(context->queue_loader, chunk,
+                                &context->mutex_loader,
                                 &context->condition_not_empty_loader,
                                 &context->condition_not_full_loader);
   }
 }
 
-int send_files(Config* config) {
+int send_files(Config *config) {
   if (config->dry_run) {
-    DirectoryScanner* scanner = directory_scanner_create(
-        config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
-        config->exclude_count, config->include_patterns, config->include_count, config->max_size,
-        config->min_size);
-    Chunk* chunk;
+    DirectoryScanner *scanner = directory_scanner_create(
+        config->send_directory, config->use_metadata, config->chunk_size,
+        config->exclude_patterns, config->exclude_count,
+        config->include_patterns, config->include_count,
+        config->max_size, config->min_size);
+    Chunk *chunk;
     int file_count = 0;
     unsigned long long total_bytes = 0;
     printf("Dry run: files to be transferred\n");
     while ((chunk = directory_scanner_next(scanner)) != NULL) {
       for (int i = 0; i < chunk->element_count; i++) {
-        printf("  %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
+        printf("  %s (%zu bytes)\n", chunk->items[i]->path,
+               chunk->items[i]->data->size);
         total_bytes += chunk->items[i]->data->size;
         file_count++;
       }
       chunk_destroy(chunk);
     }
     directory_scanner_destroy(scanner);
-    printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
+    printf("Total: %d files, %.1f MB\n", file_count,
+           total_bytes / 1048576.0);
     return 0;
   }
 
-  Client* client;
+  Client *client;
   if (config->transport == TRANSPORT_SSH) {
     if (config->use_sendfile) {
       fprintf(stderr, "Error: -f/--sendfile is not supported with SSH transport\n");
       return 1;
     }
     client = client_connect_ssh(config->ssh_destination, config->ssh_port);
-    if (!client)
-      return 1;
-  } else if (config->use_tls) {
-    client = client_create();
-    if (!client || !client_connect_tls(client, config->server_host, config->server_port,
-                                       config->tls_cert, config->tls_key, config->tls_ca)) {
-      if (client)
-        client_delete(client);
-      fprintf(stderr, "Error: could not connect to server via TLS\n");
-      return 1;
-    }
+    if (!client) return 1;
   } else {
     client = client_create();
-    if (!client || !client_connect(client, config->server_host, config->server_port)) {
-      if (client)
-        client_delete(client);
+    if (!client || !client_connect(client, server_host, server_port)) {
+      if (client) client_delete(client);
       fprintf(stderr, "Error: could not connect to server\n");
       return 1;
     }
@@ -411,23 +255,23 @@ int send_files(Config* config) {
     client_delete(client);
     return 1;
   }
-  DirectoryScanner* scanner = directory_scanner_create(
-      config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
-      config->exclude_count, config->include_patterns, config->include_count, config->max_size,
-      config->min_size);
-  Chunk* current_chunk;
+  DirectoryScanner *scanner = directory_scanner_create(
+      config->send_directory, config->use_metadata, config->chunk_size,
+      config->exclude_patterns, config->exclude_count,
+      config->include_patterns, config->include_count,
+      config->max_size, config->min_size);
+  Chunk *current_chunk;
   unsigned long long total_bytes = 0;
   time_t last_progress = 0;
   time_t start = time(NULL);
-  ArrayList* manifest = config->use_delete ? array_list_create(free) : NULL;
+  ArrayList *manifest = config->use_delete ? array_list_create(free) : NULL;
   while ((current_chunk = directory_scanner_next(scanner)) != NULL) {
     unsigned long long chunk_bytes = 0;
     for (int i = 0; i < current_chunk->element_count; i++) {
       chunk_bytes += current_chunk->items[i]->data->size;
       if (manifest) {
-        const char* p = current_chunk->items[i]->path;
-        if (*p == '/')
-          p++;
+        const char *p = current_chunk->items[i]->path;
+        if (*p == '/') p++;
         array_list_add(manifest, str_dup(p));
       }
     }
@@ -458,24 +302,13 @@ int send_files(Config* config) {
     chunk_destroy(current_chunk);
   }
   if (config->use_delete) {
-    if (!send_status(client->file_descriptor, STATUS_MANIFEST)) {
-      array_list_delete(manifest);
-      goto send_fail;
-    }
-    if (!send_int(client->file_descriptor, manifest->size)) {
-      array_list_delete(manifest);
-      goto send_fail;
-    }
-    for (int i = 0; i < manifest->size; i++) {
-      if (!send_str(client->file_descriptor, (char*)manifest->items[i])) {
-        array_list_delete(manifest);
-        goto send_fail;
-      }
-    }
+    send_status(client->file_descriptor, STATUS_MANIFEST);
+    send_int(client->file_descriptor, manifest->size);
+    for (int i = 0; i < manifest->size; i++)
+      send_str(client->file_descriptor, (char *)manifest->items[i]);
     array_list_delete(manifest);
   }
-  if (!send_status(client->file_descriptor, STATUS_FINISHED))
-    goto send_fail;
+  send_status(client->file_descriptor, STATUS_FINISHED);
   Status s;
   int ok = receive_status(client->file_descriptor, &s) && s == STATUS_OK;
   if (config->show_progress) {
@@ -487,47 +320,43 @@ int send_files(Config* config) {
   client_disconnect(client);
   client_delete(client);
   return ok ? 0 : -1;
-
-send_fail:
-  directory_scanner_destroy(scanner);
-  client_disconnect(client);
-  client_delete(client);
-  return -1;
 }
 
-int send_files_multithreaded(Config* config) {
+int send_files_multithreaded(Config *config) {
   if (config->dry_run) {
-    DirectoryScanner* scanner = directory_scanner_create(
-        config->send_directory, config->use_metadata, config->chunk_size, config->exclude_patterns,
-        config->exclude_count, config->include_patterns, config->include_count, config->max_size,
-        config->min_size);
-    Chunk* chunk;
+    DirectoryScanner *scanner = directory_scanner_create(
+        config->send_directory, config->use_metadata, config->chunk_size,
+        config->exclude_patterns, config->exclude_count,
+        config->include_patterns, config->include_count,
+        config->max_size, config->min_size);
+    Chunk *chunk;
     int file_count = 0;
     unsigned long long total_bytes = 0;
     printf("Dry run: files to be transferred\n");
     while ((chunk = directory_scanner_next(scanner)) != NULL) {
       for (int i = 0; i < chunk->element_count; i++) {
-        printf("  %s (%zu bytes)\n", chunk->items[i]->path, chunk->items[i]->data->size);
+        printf("  %s (%zu bytes)\n", chunk->items[i]->path,
+               chunk->items[i]->data->size);
         total_bytes += chunk->items[i]->data->size;
         file_count++;
       }
       chunk_destroy(chunk);
     }
     directory_scanner_destroy(scanner);
-    printf("Total: %d files, %.1f MB\n", file_count, total_bytes / 1048576.0);
+    printf("Total: %d files, %.1f MB\n", file_count,
+           total_bytes / 1048576.0);
     return 0;
   }
 
-  Queue* q1 = queue_create(100, chunk_destroy);
-  Queue* q2 = queue_create(100, chunk_destroy);
+  Queue *q1 = queue_create(100, chunk_destroy);
+  Queue *q2 = queue_create(100, chunk_destroy);
   if (!q1 || !q2) {
-    if (q1)
-      queue_destroy(q1);
-    if (q2)
-      queue_destroy(q2);
+    if (q1) queue_destroy(q1);
+    if (q2) queue_destroy(q2);
     return 1;
   }
-  PipelineContextSender* context = pipeline_context_sender_create(config, q1, q2);
+  PipelineContextSender *context =
+      pipeline_context_sender_create(config, q1, q2);
   if (!context) {
     queue_destroy(q1);
     queue_destroy(q2);
@@ -537,9 +366,11 @@ int send_files_multithreaded(Config* config) {
     context->manifest = array_list_create(free);
 
   thrd_t scanner, loader, sender;
-  if (thrd_create(&scanner, scan_directory_multithreaded, context) != thrd_success ||
+  if (thrd_create(&scanner, scan_directory_multithreaded, context) !=
+          thrd_success ||
       thrd_create(&loader, load_files_multithreaded, context) != thrd_success ||
-      thrd_create(&sender, send_chunks_multithreaded, context) != thrd_success) {
+      thrd_create(&sender, send_chunks_multithreaded, context) !=
+          thrd_success) {
     perror("Error creating threads.\n");
     pipeline_context_sender_destroy(context);
     return 1;

src/client/client_send.h

@@ -5,8 +5,11 @@
 #include "config.h"
 #include "transport_tcp.h"
 
-int send_chunk(Client* client, Chunk* chunk, Config* config);
-int send_files(Config* config);
-int send_files_multithreaded(Config* config);
+extern char *server_host;
+extern int server_port;
+
+int send_chunk(Client *client, Chunk *chunk, Config *config);
+int send_files(Config *config);
+int send_files_multithreaded(Config *config);
 
 #endif

src/client/scanner.c

@@ -11,91 +11,24 @@
 #include <sys/stat.h>
 #include <unistd.h>
 
-DirectoryScanner* directory_scanner_create(char* root_directory, bool use_metadata,
-                                           unsigned long long chunk_size, char** exclude_patterns,
-                                           int exclude_count, char** include_patterns,
-                                           int include_count, unsigned long long max_size,
-                                           unsigned long long min_size) {
-  return directory_scanner_create_full(root_directory, use_metadata, chunk_size, exclude_patterns,
-                                       exclude_count, include_patterns, include_count, max_size,
-                                       min_size, true);
-}
-
-DirectoryScanner* directory_scanner_create_full(char* root_directory, bool use_metadata,
-                                                unsigned long long chunk_size,
-                                                char** exclude_patterns, int exclude_count,
-                                                char** include_patterns, int include_count,
-                                                unsigned long long max_size,
-                                                unsigned long long min_size, bool follow_symlinks) {
-  DirectoryScanner* scanner = malloc(sizeof(DirectoryScanner));
-  if (scanner == NULL)
-    return NULL;
+DirectoryScanner *directory_scanner_create(char *root_directory, bool use_metadata, unsigned long long chunk_size, char **exclude_patterns, int exclude_count, char **include_patterns, int include_count, unsigned long long max_size, unsigned long long min_size) {
+  DirectoryScanner *scanner = malloc(sizeof(DirectoryScanner));
   scanner->directories = queue_create(100, free);
   scanner->current_dir = NULL;
   scanner->current_path = NULL;
   scanner->use_metadata = use_metadata;
   scanner->chunk_size = chunk_size > 0 ? chunk_size : DESIRED_CHUNK_SIZE;
-  /* Deep-copy exclude patterns */
-  if (exclude_count > 0 && exclude_patterns != NULL) {
-    scanner->exclude_patterns = malloc((size_t)exclude_count * sizeof(char*));
-    if (scanner->exclude_patterns == NULL) {
-      queue_destroy(scanner->directories);
-      free(scanner);
-      return NULL;
-    }
-    for (int i = 0; i < exclude_count; i++) {
-      scanner->exclude_patterns[i] = str_dup(exclude_patterns[i]);
-      if (scanner->exclude_patterns[i] == NULL) {
-        for (int j = 0; j < i; j++)
-          free(scanner->exclude_patterns[j]);
-        free(scanner->exclude_patterns);
-        queue_destroy(scanner->directories);
-        free(scanner);
-        return NULL;
-      }
-    }
-  } else {
-    scanner->exclude_patterns = NULL;
-  }
+  scanner->exclude_patterns = exclude_patterns;
   scanner->exclude_count = exclude_count;
-
-  /* Deep-copy include patterns */
-  if (include_count > 0 && include_patterns != NULL) {
-    scanner->include_patterns = malloc((size_t)include_count * sizeof(char*));
-    if (scanner->include_patterns == NULL) {
-      for (int i = 0; i < exclude_count; i++)
-        free(scanner->exclude_patterns[i]);
-      free(scanner->exclude_patterns);
-      queue_destroy(scanner->directories);
-      free(scanner);
-      return NULL;
-    }
-    for (int i = 0; i < include_count; i++) {
-      scanner->include_patterns[i] = str_dup(include_patterns[i]);
-      if (scanner->include_patterns[i] == NULL) {
-        for (int j = 0; j < i; j++)
-          free(scanner->include_patterns[j]);
-        free(scanner->include_patterns);
-        for (int j = 0; j < exclude_count; j++)
-          free(scanner->exclude_patterns[j]);
-        free(scanner->exclude_patterns);
-        queue_destroy(scanner->directories);
-        free(scanner);
-        return NULL;
-      }
-    }
-  } else {
-    scanner->include_patterns = NULL;
-  }
+  scanner->include_patterns = include_patterns;
   scanner->include_count = include_count;
   scanner->max_size = max_size;
   scanner->min_size = min_size;
-  scanner->follow_symlinks = follow_symlinks;
   queue_enqueue(scanner->directories, str_dup(root_directory));
   return scanner;
 }
 
-void directory_scanner_destroy(DirectoryScanner* scanner) {
+void directory_scanner_destroy(DirectoryScanner *scanner) {
   if (scanner == NULL)
     return;
   if (scanner->current_dir) {
@@ -103,27 +36,20 @@ void directory_scanner_destroy(DirectoryScanner* scanner) {
     scanner->current_dir = NULL;
   }
   free(scanner->current_path);
-  for (int i = 0; i < scanner->exclude_count; i++)
-    free(scanner->exclude_patterns[i]);
-  free(scanner->exclude_patterns);
-  for (int i = 0; i < scanner->include_count; i++)
-    free(scanner->include_patterns[i]);
-  free(scanner->include_patterns);
   queue_destroy(scanner->directories);
   free(scanner);
 }
 
-static Chunk* chunk_data_to_chunk(ArrayList* chunk_data) {
-  void** chunk_items = array_list_to_array(chunk_data);
-  Chunk* chunk = chunk_create((File**)chunk_items, chunk_data->size);
+static Chunk *chunk_data_to_chunk(ArrayList *chunk_data) {
+  void **chunk_items = array_list_to_array(chunk_data);
+  Chunk *chunk = chunk_create((File **)chunk_items, chunk_data->size);
   free(chunk_items);
   chunk_data->item_destroyer = NULL;
   array_list_delete(chunk_data);
   return chunk;
 }
 
-// Returns: 1 on success, 0 if no more directories in queue, -1 on opendir failure
-static int open_next_directory(DirectoryScanner* scanner) {
+static int open_next_directory(DirectoryScanner *scanner) {
   if (scanner->current_dir) {
     closedir(scanner->current_dir);
     scanner->current_dir = NULL;
@@ -133,31 +59,28 @@ static int open_next_directory(DirectoryScanner* scanner) {
   if (queue_is_empty(scanner->directories))
     return 0;
 
-  scanner->current_path = (char*)queue_dequeue(scanner->directories);
+  scanner->current_path = (char *)queue_dequeue(scanner->directories);
   scanner->current_dir = opendir(scanner->current_path);
   if (scanner->current_dir == NULL) {
     perror("Could not open directory");
     free(scanner->current_path);
     scanner->current_path = NULL;
-    return -1;
+    return 0;
   }
   return 1;
 }
 
-Chunk* directory_scanner_next(DirectoryScanner* scanner) {
-  ArrayList* chunk_data = array_list_create(file_destroy);
+Chunk *directory_scanner_next(DirectoryScanner *scanner) {
+  ArrayList *chunk_data = array_list_create(file_destroy);
   unsigned long long chunk_data_size = 0;
 
   while (1) {
     if (scanner->current_dir == NULL) {
-      int ret = open_next_directory(scanner);
-      if (ret == 0)
+      if (!open_next_directory(scanner))
         break;
-      if (ret < 0)
-        continue;
     }
 
-    struct dirent* entry = readdir(scanner->current_dir);
+    struct dirent *entry = readdir(scanner->current_dir);
     if (entry == NULL) {
       closedir(scanner->current_dir);
       scanner->current_dir = NULL;
@@ -169,83 +92,15 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
     if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
       continue;
 
-    char* cur_path = path_cat(scanner->current_path, entry->d_name);
+    char *cur_path = path_cat(scanner->current_path, entry->d_name);
     struct stat stats;
-    // Use lstat to detect symlinks
-    if (lstat(cur_path, &stats) != 0) {
+    if (stat(cur_path, &stats) != 0) {
       free(cur_path);
       continue;
     }
 
-    // If follow_symlinks is enabled and this is a symlink, resolve it
-    if (scanner->follow_symlinks && S_ISLNK(stats.st_mode)) {
-      struct stat target_stats;
-      if (stat(cur_path, &target_stats) != 0) {
-        // Broken symlink, skip
-        free(cur_path);
-        continue;
-      }
-      stats = target_stats;
-    }
-
     if (S_ISDIR(stats.st_mode)) {
-      queue_enqueue(scanner->directories, (void*)cur_path);
-    } else if (S_ISLNK(stats.st_mode)) {
-      // Handle symlink (not following)
-      bool excluded = false;
-      for (int i = 0; i < scanner->exclude_count; i++) {
-        if (glob_match(scanner->exclude_patterns[i], entry->d_name)) {
-          excluded = true;
-          break;
-        }
-      }
-      if (excluded) {
-        free(cur_path);
-        continue;
-      }
-
-      if (scanner->include_count > 0) {
-        bool included = false;
-        for (int i = 0; i < scanner->include_count; i++) {
-          if (glob_match(scanner->include_patterns[i], entry->d_name)) {
-            included = true;
-            break;
-          }
-        }
-        if (!included) {
-          free(cur_path);
-          continue;
-        }
-      }
-
-      File* file = file_create(cur_path);
-      if (file == NULL) {
-        free(cur_path);
-        continue;
-      }
-      file->type = FILE_TYPE_SYMLINK;
-      // Read link target
-      char link_buf[4096];
-      ssize_t link_len = readlink(cur_path, link_buf, sizeof(link_buf) - 1);
-      if (link_len >= 0) {
-        link_buf[link_len] = '\0';
-        file->link_target = str_dup(link_buf);
-        if (file->link_target == NULL) {
-          file_destroy(file);
-          free(cur_path);
-          continue;
-        }
-      }
-      file->data->size = 0;
-      if (scanner->use_metadata)
-        file->metadata = file_metadata_create(&stats);
-      array_list_add(chunk_data, file);
-      chunk_data_size += 1; // small size for symlinks
-      if (chunk_data_size > scanner->chunk_size) {
-        free(cur_path);
-        return chunk_data_to_chunk(chunk_data);
-      }
-      free(cur_path);
+      queue_enqueue(scanner->directories, (void *)cur_path);
     } else {
       bool excluded = false;
       for (int i = 0; i < scanner->exclude_count; i++) {
@@ -279,7 +134,7 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
         continue;
       }
 
-      File* file = file_create(cur_path);
+      File *file = file_create(cur_path);
       if (file == NULL) {
         free(cur_path);
         continue;
@@ -299,6 +154,5 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
 
   if (chunk_data->size > 0)
     return chunk_data_to_chunk(chunk_data);
-  array_list_delete(chunk_data);
   return NULL;
 }

src/client/scanner.h

@@ -7,32 +7,21 @@
 #include <stdbool.h>
 
 typedef struct {
-  Queue* directories;
-  DIR* current_dir;
-  char* current_path;
+  Queue *directories;
+  DIR *current_dir;
+  char *current_path;
   bool use_metadata;
   unsigned long long chunk_size;
-  char** exclude_patterns;
+  char **exclude_patterns;
   int exclude_count;
-  char** include_patterns;
+  char **include_patterns;
   int include_count;
   unsigned long long max_size;
   unsigned long long min_size;
-  bool follow_symlinks;
 } DirectoryScanner;
 
-DirectoryScanner* directory_scanner_create(char* root_directory, bool use_metadata,
-                                           unsigned long long chunk_size, char** exclude_patterns,
-                                           int exclude_count, char** include_patterns,
-                                           int include_count, unsigned long long max_size,
-                                           unsigned long long min_size);
-DirectoryScanner* directory_scanner_create_full(char* root_directory, bool use_metadata,
-                                                unsigned long long chunk_size,
-                                                char** exclude_patterns, int exclude_count,
-                                                char** include_patterns, int include_count,
-                                                unsigned long long max_size,
-                                                unsigned long long min_size, bool follow_symlinks);
-Chunk* directory_scanner_next(DirectoryScanner* scanner);
-void directory_scanner_destroy(DirectoryScanner* scanner);
+DirectoryScanner *directory_scanner_create(char *root_directory, bool use_metadata, unsigned long long chunk_size, char **exclude_patterns, int exclude_count, char **include_patterns, int include_count, unsigned long long max_size, unsigned long long min_size);
+Chunk *directory_scanner_next(DirectoryScanner *scanner);
+void directory_scanner_destroy(DirectoryScanner *scanner);
 
 #endif

src/server/server.c

@@ -8,85 +8,45 @@
 #include "protocol.h"
 #include "queue.h"
 #include "transport_tcp.h"
-#include "transport_tls.h"
 #include "unistd.h"
 #include "utils.h"
-#include <libgen.h>
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-// Check if a file path should be excluded based on config patterns
-static bool is_excluded(const char* path, const Config* config) {
-  // Extract filename from path
-  char* path_dup = str_dup(path);
-  if (!path_dup)
-    return false;
-  char* fname = basename(path_dup);
-
-  // Check exclude patterns
-  for (int i = 0; i < config->exclude_count; i++) {
-    if (glob_match(config->exclude_patterns[i], fname)) {
-      free(path_dup);
-      return true;
-    }
-  }
-
-  // Check include patterns (if any, file must match at least one)
-  if (config->include_count > 0) {
-    bool included = false;
-    for (int i = 0; i < config->include_count; i++) {
-      if (glob_match(config->include_patterns[i], fname)) {
-        included = true;
-        break;
-      }
-    }
-    if (!included) {
-      free(path_dup);
-      return true;
-    }
-  }
-
-  free(path_dup);
-  return false;
-}
-
-int receive_files(Config* config, int fd) {
+int receive_files(Config *config, int fd) {
   Status status;
-  if (!receive_status(fd, &status))
-    return -1;
+  if (!receive_status(fd, &status)) return -1;
 
   while (status == STATUS_NEXT || status == STATUS_CHUNK || status == STATUS_CHECK) {
     if (status == STATUS_CHECK) {
       bool skipped;
-      File* file = receive_incremental_check(fd, config, &skipped);
-      if (skipped)
-        goto next;
-      if (file == NULL && !skipped)
-        return -1;
-      if (config->save_to_disk && !is_excluded(file->path, config))
+      File *file = receive_incremental_check(fd, config, &skipped);
+      if (skipped) goto next;
+      if (file == NULL && !skipped) return -1;
+      if (config->save_to_disk)
         file_save_to_disk(config->receive_root_directory, file);
       file_destroy(file);
     } else if (status == STATUS_CHUNK) {
-      Chunk* chunk = receive_chunk_data(fd, config);
+      Chunk *chunk = receive_chunk_data(fd, config);
       if (chunk == NULL) {
         send_status(fd, STATUS_ERROR);
         return -1;
       }
       for (int i = 0; i < chunk->element_count; i++) {
-        if (config->save_to_disk && !is_excluded(chunk->items[i]->path, config))
+        if (config->save_to_disk)
           file_save_to_disk(config->receive_root_directory, chunk->items[i]);
       }
       chunk_destroy(chunk);
     } else {
-      File* file = file_receive(config, fd);
+      File *file = file_receive(config, fd);
       if (file == NULL) {
         log_message(LOG_LEVEL_ERROR, "Failed to receive file");
         send_status(fd, STATUS_ERROR);
         return -1;
       }
-      if (config->save_to_disk && !is_excluded(file->path, config))
+      if (config->save_to_disk)
         file_save_to_disk(config->receive_root_directory, file);
       file_destroy(file);
     }
@@ -98,8 +58,7 @@ int receive_files(Config* config, int fd) {
   }
 
   if (status == STATUS_MANIFEST) {
-    if (receive_manifest(fd, config, &status) != 0)
-      return -1;
+    if (receive_manifest(fd, config, &status) != 0) return -1;
   }
   if (status != STATUS_FINISHED) {
     log_message(LOG_LEVEL_ERROR, "Did not receive FINISHED Status");
@@ -111,20 +70,21 @@ int receive_files(Config* config, int fd) {
 }
 
 void handler(int file_descriptor) {
-  Config* config = config_receive(file_descriptor);
+  Config *config = config_receive(file_descriptor);
   if (config == NULL) {
     log_message(LOG_LEVEL_ERROR, "Failed to receive config");
     close(file_descriptor);
     return;
   }
   if (config->use_multithreading) {
-    Queue* q = queue_create(100, file_destroy);
+    Queue *q = queue_create(100, file_destroy);
     if (q == NULL) {
       config_delete(config);
       close(file_descriptor);
       return;
     }
-    PipelineContextReceiver* context = pipeline_context_receiver_create(config, q, file_descriptor);
+    PipelineContextReceiver *context = pipeline_context_receiver_create(
+        config, q, file_descriptor);
     if (context == NULL) {
       queue_destroy(q);
       config_delete(config);
@@ -148,107 +108,34 @@ void handler(int file_descriptor) {
   close(file_descriptor);
 }
 
-static Server* g_server = NULL;
-static volatile sig_atomic_t g_server_cleanup_requested = 0;
+static Server *g_server = NULL;
 
 static void cleanup(int sig) {
   (void)sig;
-  server_request_shutdown();
-  g_server_cleanup_requested = 1;
+  if (g_server) {
+    server_delete(&g_server);
+  }
+  _exit(0);
 }
 
-static void print_server_usage(void) {
-  printf("FastSync Server\n");
-  printf("Usage: fastsync-server [options]\n");
-  printf("\n");
-  printf("Options:\n");
-  printf("  --stdio             Run in stdio mode (SSH transport)\n");
-  printf("  -p <port>           TCP port (default: 8080, range: 1-65535)\n");
-  printf("  --tls               Enable TLS encryption\n");
-  printf("  --cert <path>       TLS certificate file (PEM)\n");
-  printf("  --key <path>        TLS private key file (PEM)\n");
-  printf("  --ca <path>         TLS CA certificate file (PEM)\n");
-  printf("  -v, --verbose       Enable debug logging\n");
-  printf("  --help              Show this help\n");
-  printf("  -V, --version       Show version and exit\n");
-}
-
-int main(int argc, char* argv[]) {
-  bool use_tls = false;
-  char* tls_cert = NULL;
-  char* tls_key = NULL;
-  char* tls_ca = NULL;
-  int port = 8080;
-
+int main(int argc, char *argv[]) {
   signal(SIGPIPE, SIG_IGN);
   for (int i = 1; i < argc; i++) {
-    if (strcmp(argv[i], "--help") == 0) {
-      print_server_usage();
-      return 0;
-    } else if (strcmp(argv[i], "-V") == 0 || strcmp(argv[i], "--version") == 0) {
-      printf("fastsync-server version %s\n", PROTOCOL_VERSION);
-      return 0;
-    } else if (strcmp(argv[i], "--stdio") == 0) {
+    if (strcmp(argv[i], "--stdio") == 0) {
       io_set_fds(STDIN_FILENO, STDOUT_FILENO);
       handler(STDIN_FILENO);
       return 0;
     } else if (strcmp(argv[i], "-v") == 0 || strcmp(argv[i], "--verbose") == 0) {
       set_log_level(LOG_LEVEL_DEBUG);
-    } else if (strcmp(argv[i], "--tls") == 0) {
-      use_tls = true;
-    } else if (strcmp(argv[i], "--cert") == 0 && i + 1 < argc) {
-      tls_cert = argv[++i];
-    } else if (strcmp(argv[i], "--key") == 0 && i + 1 < argc) {
-      tls_key = argv[++i];
-    } else if (strcmp(argv[i], "--ca") == 0 && i + 1 < argc) {
-      tls_ca = argv[++i];
-    } else if (strcmp(argv[i], "-p") == 0 && i + 1 < argc) {
-      char* end;
-      long p = strtol(argv[++i], &end, 10);
-      if (*end || p <= 0 || p > 65535) {
-        fprintf(stderr, "Error: invalid port '%s' (must be 1-65535)\n", argv[i]);
-        return 1;
-      }
-      port = (int)p;
-    } else if (argv[i][0] == '-') {
-      fprintf(stderr, "Unknown option: %s\n", argv[i]);
-      print_server_usage();
-      return 1;
     }
   }
-
-  if (tls_ca && !use_tls) {
-    log_message(LOG_LEVEL_WARNING, "--ca has no effect without --tls");
-  }
-
   signal(SIGINT, cleanup);
   signal(SIGTERM, cleanup);
-  g_server = server_create(port);
+  g_server = server_create(8080);
   if (g_server == NULL) {
     log_message(LOG_LEVEL_ERROR, "Failed to create server");
     return 1;
   }
-  if (use_tls) {
-    if (!tls_cert || !tls_key) {
-      fprintf(stderr, "Error: --tls requires --cert and --key\n");
-      server_delete(&g_server);
-      return 1;
-    }
-    tls_global_init();
-    if (!server_create_tls(g_server, tls_cert, tls_key, tls_ca)) {
-      log_message(LOG_LEVEL_ERROR, "Failed to set up TLS");
-      server_delete(&g_server);
-      return 1;
-    }
-    server_listen_tls(g_server, handler);
-  } else {
   server_listen(g_server, handler);
-  }
-
-  /* Graceful shutdown: if a signal requested cleanup, delete the server */
-  if (g_server_cleanup_requested) {
-    log_message(LOG_LEVEL_INFO, "Shutdown requested, cleaning up");
-    server_delete(&g_server);
-  }
   return 0;
 }

src/shared/array_list.c

@@ -3,14 +3,14 @@
 #include <stdlib.h>
 #include <string.h>
 
-ArrayList* array_list_create(void (*item_destroyer)(void* item)) {
-  ArrayList* list = (ArrayList*)malloc(sizeof(ArrayList));
+ArrayList *array_list_create(void (*item_destroyer)(void *item)) {
+  ArrayList *list = (ArrayList *)malloc(sizeof(ArrayList));
   if (list == NULL) {
     perror("ERROR: Could not allocate memory for array list struct");
     return NULL;
   }
 
-  list->items = malloc(INITIAL_ARRAY_SIZE * sizeof(void*));
+  list->items = malloc(INITIAL_ARRAY_SIZE * sizeof(void *));
   if (list->items == NULL) {
     free(list);
     return NULL;
@@ -21,7 +21,7 @@ ArrayList* array_list_create(void (*item_destroyer)(void* item)) {
   return list;
 }
 
-void array_list_delete(ArrayList* array_list) {
+void array_list_delete(ArrayList *array_list) {
   if (array_list == NULL)
     return;
   if (array_list->item_destroyer != NULL) {
@@ -34,13 +34,12 @@ void array_list_delete(ArrayList* array_list) {
   free(array_list);
 }
 
-bool array_list_extend(ArrayList* array_list) {
-  if (array_list == NULL)
-    return false;
+bool array_list_extend(ArrayList *array_list) {
+  if (array_list == NULL) return false;
   int new_capacity = array_list->capacity * 2;
   if (new_capacity == 0)
     new_capacity = INITIAL_ARRAY_SIZE;
-  void* new_items = realloc(array_list->items, new_capacity * sizeof(void*));
+  void *new_items = realloc(array_list->items, new_capacity * sizeof(void *));
   if (new_items == NULL) {
     perror("ERROR: Could not reallocate memory for array list items");
     return false;
@@ -50,9 +49,8 @@ bool array_list_extend(ArrayList* array_list) {
   return true;
 }
 
-bool array_list_add(ArrayList* array_list, void* item) {
-  if (array_list == NULL)
-    return false;
+bool array_list_add(ArrayList *array_list, void *item) {
+  if (array_list == NULL) return false;
   if (array_list->capacity == array_list->size) {
     if (!array_list_extend(array_list))
       return false;
@@ -62,15 +60,15 @@ bool array_list_add(ArrayList* array_list, void* item) {
   return true;
 }
 
-void** array_list_to_array(const ArrayList* array_list) {
+void **array_list_to_array(ArrayList *array_list) {
   if (array_list == NULL) {
     return NULL;
   }
-  void** array = malloc(array_list->size * sizeof(void*));
+  void **array = malloc(array_list->size * sizeof(void *));
   if (array == NULL) {
     perror("Could not malloc space for array from array list!");
     return NULL;
   }
-  memcpy(array, array_list->items, array_list->size * sizeof(void*));
+  memcpy(array, array_list->items, array_list->size * sizeof(void *));
   return array;
 }

src/shared/array_list.h

@@ -6,16 +6,16 @@
 #define INITIAL_ARRAY_SIZE 100
 
 typedef struct ArrayList {
-  void** items;
+  void **items;
   int size;
   int capacity;
-  void (*item_destroyer)(void* item);
+  void (*item_destroyer)(void *item);
 } ArrayList;
 
-ArrayList* array_list_create(void (*item_destroyer)(void* item));
-void array_list_delete(ArrayList* array_list);
-bool array_list_extend(ArrayList* array_list);
-bool array_list_add(ArrayList* array_list, void* item);
-void** array_list_to_array(const ArrayList* array_list);
+ArrayList *array_list_create(void (*item_destroyer)(void *item));
+void array_list_delete(ArrayList *array_list);
+bool array_list_extend(ArrayList *array_list);
+bool array_list_add(ArrayList *array_list, void *item);
+void **array_list_to_array(ArrayList *array_list);
 
 #endif

src/shared/chunk.c

@@ -12,14 +12,14 @@
 #include "metadata.h"
 #include "protocol.h"
 
-Chunk* chunk_create(File** items, int element_count) {
-  Chunk* chunk = (Chunk*)malloc(sizeof(Chunk));
+Chunk *chunk_create(File **items, int element_count) {
+  Chunk *chunk = (Chunk *)malloc(sizeof(Chunk));
   if (chunk == NULL) {
     perror("ERROR: Could not allocate memory for chunk structure");
     return NULL;
   }
 
-  chunk->items = (File**)malloc(element_count * sizeof(File*));
+  chunk->items = (File **)malloc(element_count * sizeof(File *));
   if (chunk->items == NULL) {
     free(chunk);
     return NULL;
@@ -32,11 +32,11 @@ Chunk* chunk_create(File** items, int element_count) {
   return chunk;
 }
 
-void chunk_destroy(void* item) {
+void chunk_destroy(void *item) {
   if (item == NULL) {
     return;
   }
-  Chunk* chunk = (Chunk*)item;
+  Chunk *chunk = (Chunk *)item;
   for (int i = 0; i < chunk->element_count; ++i) {
     if (chunk->items[i] != NULL) {
       file_destroy(chunk->items[i]);
@@ -46,25 +46,26 @@ void chunk_destroy(void* item) {
   free(chunk);
 }
 
-static unsigned long long per_file_serialize_size(File* file, bool use_metadata) {
+static unsigned long long per_file_serialize_size(File *file, bool use_metadata) {
   return sizeof(size_t) + strlen(file->path) +
          (use_metadata ? sizeof(int) + (file->metadata ? FILE_METADATA_WIRE_SIZE : 0) : 0) +
          sizeof(size_t) + file->data->size;
 }
 
-Data* chunk_serialize(Chunk* chunk, bool use_metadata) {
+Data *chunk_serialize(Chunk *chunk, bool use_metadata) {
   unsigned long long data_size = 0;
   for (int i = 0; i < chunk->element_count; i++) {
     data_size += per_file_serialize_size(chunk->items[i], use_metadata);
   }
-  Data* data = data_create_empty(data_size);
+  Data *data = data_create_empty(data_size);
   if (data == NULL) {
-    log_message(LOG_LEVEL_ERROR, "Could not allocate memory for chunk serialization");
+    log_message(LOG_LEVEL_ERROR,
+                "Could not allocate memory for chunk serialization");
     return NULL;
   }
-  char* data_pointer = data->data;
+  char *data_pointer = data->data;
   for (int i = 0; i < chunk->element_count; i++) {
-    File* file = chunk->items[i];
+    File *file = chunk->items[i];
     size_t path_len = strlen(file->path);
     memcpy(data_pointer, &path_len, sizeof(size_t));
     data_pointer += sizeof(size_t);
@@ -83,9 +84,9 @@ Data* chunk_serialize(Chunk* chunk, bool use_metadata) {
   return data;
 }
 
-Chunk* chunk_deserialize(Data* data, bool use_metadata) {
-  ArrayList* files = array_list_create(file_destroy);
-  char* data_pointer = data->data;
+Chunk *chunk_deserialize(Data *data, bool use_metadata) {
+  ArrayList *files = array_list_create(file_destroy);
+  char *data_pointer = data->data;
   size_t remaining_size = data->size;
 
   while (remaining_size > 0) {
@@ -95,8 +96,7 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
       return NULL;
     }
 
-    size_t path_len;
-    memcpy(&path_len, data_pointer, sizeof(size_t));
+    size_t path_len = *(size_t *)data_pointer;
     data_pointer += sizeof(size_t);
     remaining_size -= sizeof(size_t);
 
@@ -106,7 +106,7 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
       return NULL;
     }
 
-    char* path = malloc(path_len + 1);
+    char *path = malloc(path_len + 1);
     if (path == NULL) {
       perror("Could not allocate memory for file path");
       array_list_delete(files);
@@ -117,23 +117,10 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
     data_pointer += path_len;
     remaining_size -= path_len;
 
-    File* file = file_create(path);
+    File *file = file_create(path);
     free(path);
 
     if (use_metadata) {
-      if (remaining_size < sizeof(int)) {
-        log_message(LOG_LEVEL_ERROR, "Invalid chunk format: not enough data for metadata");
-        array_list_delete(files);
-        return NULL;
-      }
-      // Peek at present flag to determine total size needed before reading
-      int present_flag;
-      memcpy(&present_flag, data_pointer, sizeof(int));
-      if (present_flag && remaining_size < sizeof(int) + FILE_METADATA_WIRE_SIZE) {
-        log_message(LOG_LEVEL_ERROR, "Invalid chunk format: not enough data for metadata body");
-        array_list_delete(files);
-        return NULL;
-      }
       file->metadata = metadata_from_buf(&data_pointer);
       remaining_size -= sizeof(int);
       if (file->metadata)
@@ -146,8 +133,7 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
       return NULL;
     }
 
-    size_t file_data_size;
-    memcpy(&file_data_size, data_pointer, sizeof(size_t));
+    size_t file_data_size = *(size_t *)data_pointer;
     data_pointer += sizeof(size_t);
     remaining_size -= sizeof(size_t);
 
@@ -157,7 +143,7 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
       return NULL;
     }
 
-    void* file_data = malloc(file_data_size);
+    void *file_data = malloc(file_data_size);
     if (file_data == NULL) {
       perror("Could not allocate memory for file data");
       array_list_delete(files);
@@ -172,8 +158,8 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
     array_list_add(files, file);
   }
 
-  File** file_array = (File**)array_list_to_array(files);
-  Chunk* chunk = chunk_create(file_array, files->size);
+  File **file_array = (File **)array_list_to_array(files);
+  Chunk *chunk = chunk_create(file_array, files->size);
 
   free(file_array);
   files->item_destroyer = NULL;
@@ -182,26 +168,24 @@ Chunk* chunk_deserialize(Data* data, bool use_metadata) {
   return chunk;
 }
 
-Data* chunk_compress(Chunk* chunk, int compression_level, bool use_metadata) {
+Data *chunk_compress(Chunk *chunk, int compression_level, bool use_metadata) {
   log_message(LOG_LEVEL_DEBUG, "Starting to compress chunk");
-  Data* serialized = chunk_serialize(chunk, use_metadata);
-  if (serialized == NULL)
-    return NULL;
-  Data* compressed = data_compress(serialized, compression_level);
+  Data *serialized = chunk_serialize(chunk, use_metadata);
+  if (serialized == NULL) return NULL;
+  Data *compressed = data_compress(serialized, compression_level);
   data_destroy(serialized);
-  if (compressed == NULL)
-    return NULL;
+  if (compressed == NULL) return NULL;
   log_message(LOG_LEVEL_DEBUG, "Chunk successfully compressed");
   return compressed;
 }
 
-Chunk* receive_chunk_data(int fd, const Config* config) {
-  Data* chunk_data = receive_data(fd);
+Chunk *receive_chunk_data(int fd, Config *config) {
+  Data *chunk_data = receive_data(fd);
   if (chunk_data == NULL) {
     log_message(LOG_LEVEL_ERROR, "Failed to receive chunk data");
     return NULL;
   }
-  Data* data_to_process = chunk_data;
+  Data *data_to_process = chunk_data;
   if (config->use_compression) {
     data_to_process = data_decompress(chunk_data);
     data_destroy(chunk_data);
@@ -210,9 +194,12 @@ Chunk* receive_chunk_data(int fd, const Config* config) {
       return NULL;
     }
   }
-  Chunk* chunk = chunk_deserialize(data_to_process, config->use_metadata);
+  Chunk *chunk = chunk_deserialize(data_to_process, config->use_metadata);
   data_destroy(data_to_process);
   if (chunk == NULL)
     log_message(LOG_LEVEL_ERROR, "Failed to deserialize chunk, skipping");
   return chunk;
 }
+
+
+

src/shared/chunk.h

@@ -10,15 +10,15 @@
 #define DESIRED_CHUNK_SIZE (10 * 1024 * 1024)
 
 typedef struct {
-  File** items;
+  File **items;
   int element_count;
 } Chunk;
 
-Chunk* chunk_create(File** items, int element_count);
-void chunk_destroy(void* chunk);
-Data* chunk_serialize(Chunk* chunk, bool use_metadata);
-Chunk* chunk_deserialize(Data* data, bool use_metadata);
-Data* chunk_compress(Chunk* chunk, int compression_level, bool use_metadata);
-Chunk* receive_chunk_data(int fd, const Config* config);
+Chunk *chunk_create(File **items, int element_count);
+void chunk_destroy(void *chunk);
+Data *chunk_serialize(Chunk *chunk, bool use_metadata);
+Chunk *chunk_deserialize(Data *data, bool use_metadata);
+Data *chunk_compress(Chunk *chunk, int compression_level, bool use_metadata);
+Chunk *receive_chunk_data(int fd, Config *config);
 
 #endif

src/shared/compression.c

@@ -1,46 +1,24 @@
 #include "compression.h"
 #include "data.h"
 #include "log.h"
-#include <stdint.h>
-#include <stdlib.h>
+#include "stdlib.h"
 #include "zstd.h"
 
 #define INITIAL_DECOMPRESS_BUF_SIZE (1024 * 1024)
 
-Data* data_compress(Data* data_to_compress, int compression_level) {
+Data *data_compress(Data *data_to_compress, int compression_level) {
   log_message(LOG_LEVEL_DEBUG, "Starting to compress data");
-
-  /* Clamp compression level to valid zstd range [1, 22] */
-  if (compression_level < 1) {
-    log_message(LOG_LEVEL_WARNING, "compression_level %d out of range [1,22], using 1",
-                compression_level);
-    compression_level = 1;
-  } else if (compression_level > 22) {
-    log_message(LOG_LEVEL_WARNING, "compression_level %d out of range [1,22], using 22",
-                compression_level);
-    compression_level = 22;
-  }
-
   size_t dst_size = ZSTD_compressBound(data_to_compress->size);
-  Data* compressed_data = data_create_empty(dst_size);
-  if (compressed_data == NULL)
-    return NULL;
+  Data *compressed_data = data_create_empty(dst_size);
+  if (compressed_data == NULL) return NULL;
 
-  ZSTD_CCtx* cctx = ZSTD_createCCtx();
+  ZSTD_CCtx *cctx = ZSTD_createCCtx();
   if (!cctx) {
     log_message(LOG_LEVEL_ERROR, "Failed to create ZSTD compression context");
     data_destroy(compressed_data);
     return NULL;
   }
 
-  size_t zret = ZSTD_CCtx_setParameter(cctx, ZSTD_c_compressionLevel, compression_level);
-  if (ZSTD_isError(zret)) {
-    log_message(LOG_LEVEL_ERROR, "Failed to set compression level: %s", ZSTD_getErrorName(zret));
-    ZSTD_freeCCtx(cctx);
-    data_destroy(compressed_data);
-    return NULL;
-  }
-
   ZSTD_inBuffer input = {data_to_compress->data, data_to_compress->size, 0};
   ZSTD_outBuffer output = {compressed_data->data, dst_size, 0};
 
@@ -48,7 +26,8 @@ Data* data_compress(Data* data_to_compress, int compression_level) {
   do {
     ret = ZSTD_compressStream2(cctx, &output, &input, ZSTD_e_end);
     if (ZSTD_isError(ret)) {
-      log_message(LOG_LEVEL_ERROR, "Compression failed: %s", ZSTD_getErrorName(ret));
+      log_message(LOG_LEVEL_ERROR, "Compression failed: %s",
+                  ZSTD_getErrorName(ret));
       ZSTD_freeCCtx(cctx);
       data_destroy(compressed_data);
       return NULL;
@@ -63,33 +42,27 @@ Data* data_compress(Data* data_to_compress, int compression_level) {
   return compressed_data;
 }
 
-Data* data_decompress(Data* compressed_data) {
+Data *data_decompress(Data *compressed_data) {
   log_message(LOG_LEVEL_DEBUG, "Start to decompress data");
-  unsigned long long dst_size =
-      ZSTD_getFrameContentSize(compressed_data->data, compressed_data->size);
+  unsigned long long dst_size = ZSTD_getFrameContentSize(
+      compressed_data->data, compressed_data->size);
   if (ZSTD_isError(dst_size)) {
     log_message(LOG_LEVEL_ERROR, "Failed to get decompressed size: %s",
                 ZSTD_getErrorName(dst_size));
     return NULL;
   }
 
-  ZSTD_DCtx* dctx = ZSTD_createDCtx();
+  ZSTD_DCtx *dctx = ZSTD_createDCtx();
   if (!dctx) {
-    log_message(LOG_LEVEL_ERROR, "Failed to create ZSTD decompression context");
+    log_message(LOG_LEVEL_ERROR,
+                "Failed to create ZSTD decompression context");
     return NULL;
   }
 
-  size_t buf_size = INITIAL_DECOMPRESS_BUF_SIZE;
-  if (!ZSTD_isError(dst_size) && dst_size > 0) {
-    if (dst_size > SIZE_MAX) {
-      log_message(LOG_LEVEL_ERROR,
-                  "Decompressed size %llu exceeds addressable memory, using fallback buffer",
-                  dst_size);
-    } else {
-      buf_size = (size_t)dst_size;
-    }
-  }
-  Data* uncompressed_data = data_create_empty(buf_size);
+  size_t buf_size = (!ZSTD_isError(dst_size) && dst_size > 0)
+                        ? (size_t)dst_size
+                        : INITIAL_DECOMPRESS_BUF_SIZE;
+  Data *uncompressed_data = data_create_empty(buf_size);
   if (!uncompressed_data) {
     log_message(LOG_LEVEL_ERROR, "Failed to allocate decompression buffer");
     ZSTD_freeDCtx(dctx);
@@ -103,14 +76,15 @@ Data* data_decompress(Data* compressed_data) {
   do {
     ret = ZSTD_decompressStream(dctx, &output, &input);
     if (ZSTD_isError(ret)) {
-      log_message(LOG_LEVEL_ERROR, "Decompression failed: %s", ZSTD_getErrorName(ret));
+      log_message(LOG_LEVEL_ERROR, "Decompression failed: %s",
+                  ZSTD_getErrorName(ret));
       ZSTD_freeDCtx(dctx);
       data_destroy(uncompressed_data);
       return NULL;
     }
     if (ret > 0 && output.pos == output.size) {
       buf_size *= 2;
-      void* new_data = realloc(uncompressed_data->data, buf_size);
+      void *new_data = realloc(uncompressed_data->data, buf_size);
       if (!new_data) {
         log_message(LOG_LEVEL_ERROR, "Failed to grow decompression buffer");
         ZSTD_freeDCtx(dctx);

src/shared/compression.h

@@ -3,7 +3,7 @@
 
 #include "data.h"
 
-Data* data_compress(Data* data_to_compress, int compression_level);
-Data* data_decompress(Data* compressed_data);
+Data *data_compress(Data *data_to_compress, int compression_level);
+Data *data_decompress(Data *compressed_data);
 
 #endif

src/shared/config.c

@@ -1,22 +1,20 @@
 #include "config.h"
-#include "delta.h"
 #include "log.h"
 #include "protocol.h"
 #include "utils.h"
 #include <stdbool.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-Config* config_create(char* version, char* send_directory, char* receive_directory,
-                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
-                      bool use_compression, bool use_metadata, int compression_level,
-                      bool use_sendfile, unsigned long long chunk_size) {
+Config *config_create(char *version, char *send_directory,
+                      char *receive_directory, bool save_to_disk,
+                      bool use_multithreading, bool use_chunk_serialization,
+                       bool use_compression, bool use_metadata,
+                       int compression_level, bool use_sendfile,
+                       unsigned long long chunk_size) {
 
-  Config* config = malloc(sizeof(Config));
-  if (config == NULL)
-    return NULL;
+  Config *config = malloc(sizeof(Config));
   config->version = version;
   config->send_directory = send_directory;
   config->receive_root_directory = receive_directory;
@@ -41,47 +39,31 @@ Config* config_create(char* version, char* send_directory, char* receive_directo
   config->max_size = 0;
   config->min_size = 0;
   config->use_incremental = false;
-  config->use_delta = false;
-  config->delta_block_size = DELTA_BLOCK_SIZE_DEFAULT;
-  config->delta_max_file_size = DELTA_MAX_FILE_SIZE;
-  config->use_tls = false;
-  config->tls_cert = NULL;
-  config->tls_key = NULL;
-  config->tls_ca = NULL;
-  config->follow_symlinks = false;
-  config->partial = false;
-  config->server_host = str_dup("127.0.0.1");
-  config->server_port = 8080;
   return config;
 }
 
-bool is_remote_dest(const char* s) {
-  if (s == NULL)
-    return false;
-  const char* colon = strchr(s, ':');
-  if (colon == NULL)
-    return false;
-  if (colon == s)
-    return false;
-  for (const char* p = s; p < colon; p++) {
-    if (*p == '/')
-      return false;
+bool is_remote_dest(const char *s) {
+  if (s == NULL) return false;
+  const char *colon = strchr(s, ':');
+  if (colon == NULL) return false;
+  if (colon == s) return false;
+  for (const char *p = s; p < colon; p++) {
+    if (*p == '/') return false;
   }
   return true;
 }
 
-void config_parse_ssh_dest(Config* config) {
-  if (!is_remote_dest(config->receive_root_directory))
-    return;
+void config_parse_ssh_dest(Config *config) {
+  if (!is_remote_dest(config->receive_root_directory)) return;
   config->transport = TRANSPORT_SSH;
   config->ssh_destination = str_dup(config->receive_root_directory);
-  const char* colon = strchr(config->receive_root_directory, ':');
-  char* path = str_dup(colon + 1);
+  char *colon = strchr(config->receive_root_directory, ':');
+  char *path = str_dup(colon + 1);
   free(config->receive_root_directory);
   config->receive_root_directory = path;
 }
 
-void config_delete(Config* config) {
+void config_delete(Config *config) {
   free(config->version);
   free(config->send_directory);
   free(config->receive_root_directory);
@@ -92,69 +74,25 @@ void config_delete(Config* config) {
   for (int i = 0; i < config->include_count; i++)
     free(config->include_patterns[i]);
   free(config->include_patterns);
-  free(config->tls_cert);
-  free(config->tls_key);
-  free(config->tls_ca);
-  free(config->server_host);
   free(config);
 }
 
-bool config_send(int file_descriptor, const Config* config) {
-  if (!send_str(file_descriptor, config->version))
-    return false;
-  if (!send_str(file_descriptor, config->send_directory))
-    return false;
-  if (!send_str(file_descriptor, config->receive_root_directory))
-    return false;
-  if (!send_int(file_descriptor, config->save_to_disk))
-    return false;
-  if (!send_int(file_descriptor, config->use_multithreading))
-    return false;
-  if (!send_int(file_descriptor, config->use_chunk_serialization))
-    return false;
-  if (!send_int(file_descriptor, config->use_compression))
-    return false;
-  if (!send_int(file_descriptor, config->use_metadata))
-    return false;
-  if (!send_int(file_descriptor, config->compression_level))
-    return false;
-  if (!send_n_data(file_descriptor, &config->chunk_size, sizeof(config->chunk_size)))
-    return false;
-  if (!send_int(file_descriptor, config->use_sendfile))
-    return false;
-  if (!send_int(file_descriptor, config->use_delete))
-    return false;
-  if (!send_int(file_descriptor, config->use_incremental))
-    return false;
-  if (!send_int(file_descriptor, config->use_delta))
-    return false;
-  if (!send_int(file_descriptor, (int)config->delta_block_size))
-    return false;
-  if (!send_n_data(file_descriptor, &config->delta_max_file_size, sizeof(unsigned long long)))
-    return false;
-  if (!send_int(file_descriptor, config->exclude_count))
-    return false;
-  for (int i = 0; i < config->exclude_count; i++) {
-    if (!send_str(file_descriptor, config->exclude_patterns[i]))
-      return false;
-  }
-  if (!send_int(file_descriptor, config->include_count))
-    return false;
-  for (int i = 0; i < config->include_count; i++) {
-    if (!send_str(file_descriptor, config->include_patterns[i]))
-      return false;
-  }
-  if (!send_n_data(file_descriptor, &config->max_size, sizeof(config->max_size)))
-    return false;
-  if (!send_n_data(file_descriptor, &config->min_size, sizeof(config->min_size)))
-    return false;
-  if (!send_int(file_descriptor, config->follow_symlinks))
-    return false;
-  if (!send_int(file_descriptor, config->partial))
-    return false;
+bool config_send(int file_descriptor, Config *config) {
+  if (!send_str(file_descriptor, config->version)) return false;
+  if (!send_str(file_descriptor, config->send_directory)) return false;
+  if (!send_str(file_descriptor, config->receive_root_directory)) return false;
+  if (!send_int(file_descriptor, config->save_to_disk)) return false;
+  if (!send_int(file_descriptor, config->use_multithreading)) return false;
+  if (!send_int(file_descriptor, config->use_chunk_serialization)) return false;
+  if (!send_int(file_descriptor, config->use_compression)) return false;
+  if (!send_int(file_descriptor, config->use_metadata)) return false;
+  if (!send_int(file_descriptor, config->compression_level)) return false;
+  if (!send_int(file_descriptor, (int)config->chunk_size)) return false;
+  if (!send_int(file_descriptor, config->use_sendfile)) return false;
+  if (!send_int(file_descriptor, config->use_delete)) return false;
+  if (!send_int(file_descriptor, config->use_incremental)) return false;
   Status status;
-  if (!receive_status(file_descriptor, &status))
-    return false;
+  if (!receive_status(file_descriptor, &status)) return false;
   if (status != STATUS_OK) {
     log_message(LOG_LEVEL_ERROR, "Error transmitting config");
     return false;
@@ -162,75 +100,44 @@ bool config_send(int file_descriptor, const Config* config) {
   return true;
 }
 
-Config* config_receive(int file_descriptor) {
-  Config* config = (Config*)malloc(sizeof(Config));
-  if (config == NULL)
-    return NULL;
-  memset(config, 0, sizeof(*config));
+Config *config_receive(int file_descriptor) {
+  Config *config = (Config *)malloc(sizeof(Config));
+  if (config == NULL) return NULL;
   config->version = receive_str(file_descriptor);
-  if (!config->version) {
-    free(config);
-    return NULL;
-  }
+  if (!config->version) { free(config); return NULL; }
   if (strcmp(config->version, PROTOCOL_VERSION) != 0) {
-    fprintf(stderr, "Protocol version mismatch: client=%s, server=%s\n", config->version,
-            PROTOCOL_VERSION);
+    fprintf(stderr, "Protocol version mismatch: client=%s, server=%s\n",
+            config->version, PROTOCOL_VERSION);
     free(config->version);
     free(config);
     send_status(file_descriptor, STATUS_ERROR);
     return NULL;
   }
   config->send_directory = receive_str(file_descriptor);
-  if (!config->send_directory) {
-    free(config->version);
-    free(config);
-    return NULL;
-  }
+  if (!config->send_directory) { free(config->version); free(config); return NULL; }
   config->receive_root_directory = receive_str(file_descriptor);
-  if (!config->receive_root_directory) {
-    free(config->version);
-    free(config->send_directory);
-    free(config);
-    return NULL;
-  }
+  if (!config->receive_root_directory) { free(config->version); free(config->send_directory); free(config); return NULL; }
   int tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->save_to_disk = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_multithreading = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_chunk_serialization = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_compression = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_metadata = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->compression_level = tmp;
-  if (!receive_n_data(file_descriptor, &config->chunk_size, sizeof(config->chunk_size)))
-    goto error;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
+  config->chunk_size = (unsigned long long)tmp;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_sendfile = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_delete = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
+  if (!receive_int(file_descriptor, &tmp)) goto error;
   config->use_incremental = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->use_delta = tmp;
-  if (!receive_int(file_descriptor, &tmp))
-    goto error;
-  config->delta_block_size = (uint32_t)tmp;
-  if (!receive_n_data(file_descriptor, &config->delta_max_file_size, sizeof(unsigned long long)))
-    goto error;
   config->show_progress = false;
   config->dry_run = false;
   config->ssh_port = 22;
@@ -242,105 +149,13 @@ Config* config_receive(int file_descriptor) {
   config->include_count = 0;
   config->max_size = 0;
   config->min_size = 0;
-  config->use_tls = false;
-  config->tls_cert = NULL;
-  config->tls_key = NULL;
-  config->tls_ca = NULL;
-  config->follow_symlinks = false;
-  config->partial = false;
-
-#define MAX_PATTERN_COUNT 10000
-
-  // Receive exclude patterns
-  int ec;
-  if (!receive_int(file_descriptor, &ec))
-    goto error;
-  if (ec > MAX_PATTERN_COUNT) {
-    log_message(LOG_LEVEL_ERROR, "Exclude pattern count %d exceeds maximum %d", ec,
-                MAX_PATTERN_COUNT);
-    goto error;
-  }
-  if ((size_t)ec > SIZE_MAX / sizeof(char*)) {
-    log_message(LOG_LEVEL_ERROR, "Exclude pattern count %d would cause integer overflow", ec);
-    goto error;
-  }
-  config->exclude_count = ec;
-  if (ec > 0) {
-    config->exclude_patterns = malloc((size_t)ec * sizeof(char*));
-    if (!config->exclude_patterns) {
-      config->exclude_count = 0;
-      goto error;
-    }
-    for (int i = 0; i < ec; i++) {
-      config->exclude_patterns[i] = receive_str(file_descriptor);
-      if (!config->exclude_patterns[i]) {
-        for (int j = 0; j < i; j++)
-          free(config->exclude_patterns[j]);
-        free(config->exclude_patterns);
-        config->exclude_patterns = NULL;
-        config->exclude_count = 0;
-        goto error;
-      }
-    }
-  }
-
-  // Receive include patterns
-  int ic;
-  if (!receive_int(file_descriptor, &ic))
-    goto error;
-  if (ic > MAX_PATTERN_COUNT) {
-    log_message(LOG_LEVEL_ERROR, "Include pattern count %d exceeds maximum %d", ic,
-                MAX_PATTERN_COUNT);
-    goto error;
-  }
-  if ((size_t)ic > SIZE_MAX / sizeof(char*)) {
-    log_message(LOG_LEVEL_ERROR, "Include pattern count %d would cause integer overflow", ic);
-    goto error;
-  }
-  config->include_count = ic;
-  if (ic > 0) {
-    config->include_patterns = malloc((size_t)ic * sizeof(char*));
-    if (!config->include_patterns) {
-      config->include_count = 0;
-      goto error;
-    }
-    for (int i = 0; i < ic; i++) {
-      config->include_patterns[i] = receive_str(file_descriptor);
-      if (!config->include_patterns[i]) {
-        for (int j = 0; j < i; j++)
-          free(config->include_patterns[j]);
-        free(config->include_patterns);
-        config->include_patterns = NULL;
-        config->include_count = 0;
-        goto error;
-      }
-    }
-  }
-
-  if (!receive_n_data(file_descriptor, &config->max_size, sizeof(config->max_size)))
-    goto error;
-  if (!receive_n_data(file_descriptor, &config->min_size, sizeof(config->min_size)))
-    goto error;
-  int tmp_follow;
-  if (!receive_int(file_descriptor, &tmp_follow))
-    goto error;
-  config->follow_symlinks = tmp_follow;
-  int tmp_partial;
-  if (!receive_int(file_descriptor, &tmp_partial))
-    goto error;
-  config->partial = tmp_partial;
-
-  config->server_host = str_dup("127.0.0.1");
-  config->server_port = 8080;
-  if (!send_status(file_descriptor, STATUS_OK))
-    goto error;
+  if (!send_status(file_descriptor, STATUS_OK)) goto error;
   return config;
 
 error:
   free(config->version);
   free(config->send_directory);
   free(config->receive_root_directory);
-  free(config->server_host);
   free(config);
   return NULL;
 }

src/shared/config.h

@@ -2,14 +2,16 @@
 #define CONFIG_H
 
 #include <stdbool.h>
-#include <stdint.h>
 
-typedef enum { TRANSPORT_TCP, TRANSPORT_SSH } TransportType;
+typedef enum {
+  TRANSPORT_TCP,
+  TRANSPORT_SSH
+} TransportType;
 
 typedef struct Config {
-  char* version;
-  char* send_directory;
-  char* receive_root_directory;
+  char *version;
+  char *send_directory;
+  char *receive_root_directory;
   bool save_to_disk;
   bool use_multithreading;
   bool use_chunk_serialization;
@@ -23,38 +25,29 @@ typedef struct Config {
   unsigned long long chunk_size;
   int ssh_port;
   TransportType transport;
-  char* ssh_destination;
-  char** exclude_patterns;
+  char *ssh_destination;
+  char **exclude_patterns;
   int exclude_count;
-  char** include_patterns;
+  char **include_patterns;
   int include_count;
   unsigned long long max_size;
   unsigned long long min_size;
   bool use_incremental;
-  bool use_delta;
-  uint32_t delta_block_size;
-  unsigned long long delta_max_file_size;
-  bool use_tls;
-  char* server_host;
-  int server_port;
-  char* tls_cert;
-  char* tls_key;
-  char* tls_ca;
-  bool follow_symlinks;
-  bool partial;
 } Config;
 
-#define PROTOCOL_VERSION "1.3.0"
+#define PROTOCOL_VERSION "1.1.0"
 #define DEFAULT_CHUNK_SIZE (10 * 1024 * 1024)
 
-Config* config_create(char* version, char* send_directory, char* receive_directory,
-                      bool save_to_disk, bool use_multithreading, bool use_chunk_serialization,
-                      bool use_compression, bool use_metadata, int compression_level,
-                      bool use_sendfile, unsigned long long chunk_size);
-void config_delete(Config* config);
-bool config_send(int file_descriptor, const Config* config);
-Config* config_receive(int file_descriptor);
-bool is_remote_dest(const char* s);
-void config_parse_ssh_dest(Config* config);
+Config *config_create(char *version, char *send_directory,
+                      char *receive_directory, bool save_to_disk,
+                      bool use_multithreading, bool use_chunk_serialization,
+                       bool use_compression, bool use_metadata,
+                       int compression_level, bool use_sendfile,
+                       unsigned long long chunk_size);
+void config_delete(Config *config);
+bool config_send(int file_descriptor, Config *config);
+Config *config_receive(int file_descriptor);
+bool is_remote_dest(const char *s);
+void config_parse_ssh_dest(Config *config);
 
 #endif

src/shared/data.c

@@ -2,10 +2,8 @@
 #include "log.h"
 #include "stdlib.h"
 
-Data* data_create_empty(size_t data_size) {
-  /* malloc(0) is UB; allocate at least 1 byte but preserve requested size */
-  size_t alloc_size = data_size > 0 ? data_size : 1;
-  void* data = malloc(alloc_size);
+Data *data_create_empty(size_t data_size) {
+  void *data = malloc(data_size);
   if (data == NULL) {
     log_message(LOG_LEVEL_ERROR, "Could not allocate memory for empty data");
     return NULL;
@@ -13,8 +11,8 @@ Data* data_create_empty(size_t data_size) {
   return data_create(data, data_size);
 }
 
-Data* data_create_reserve(size_t size) {
-  Data* d = malloc(sizeof(Data));
+Data *data_create_reserve(size_t size) {
+  Data *d = malloc(sizeof(Data));
   if (d == NULL) {
     log_message(LOG_LEVEL_ERROR, "Could not allocate memory for data");
     return NULL;
@@ -24,8 +22,8 @@ Data* data_create_reserve(size_t size) {
   return d;
 }
 
-Data* data_create(void* data, size_t data_size) {
-  Data* new_data = malloc(sizeof(Data));
+Data *data_create(void *data, size_t data_size) {
+  Data *new_data = malloc(sizeof(Data));
   if (new_data == NULL) {
     log_message(LOG_LEVEL_ERROR, "Could not allocate memory for data");
     free(data);
@@ -36,9 +34,8 @@ Data* data_create(void* data, size_t data_size) {
   return new_data;
 }
 
-void data_destroy(Data* data) {
-  if (data == NULL)
-    return;
+void data_destroy(Data *data) {
+  if (data == NULL) return;
   free(data->data);
   free(data);
 }

src/shared/data.h

@@ -1,16 +1,16 @@
 #ifndef DATA_H
 #define DATA_H
 
-#include <stdlib.h>
+#include "stdlib.h"
 
 typedef struct {
-  void* data;
+  void *data;
   size_t size;
 } Data;
 
-Data* data_create_empty(size_t data_size);
-Data* data_create_reserve(size_t size);
-Data* data_create(void* data, size_t data_size);
-void data_destroy(Data* data);
+Data *data_create_empty(size_t data_size);
+Data *data_create_reserve(size_t size);
+Data *data_create(void *data, size_t data_size);
+void data_destroy(Data *data);
 
 #endif

src/shared/delta.c

@@ -1,503 +0,0 @@
-#include "delta.h"
-#include "log.h"
-#include <stdlib.h>
-#include <string.h>
-
-#define XXH_STATIC_LINKING_ONLY
-#define XXH_IMPLEMENTATION
-#include <xxhash.h>
-
-uint32_t delta_adler32(const void* data, uint32_t len) {
-  const uint8_t* p = (const uint8_t*)data;
-  uint32_t s1 = 1;
-  uint32_t s2 = 0;
-  for (uint32_t i = 0; i < len; i++) {
-    s1 = (s1 + p[i]) % DELTA_ADLER32_MODULUS;
-    s2 = (s2 + s1) % DELTA_ADLER32_MODULUS;
-  }
-  return (s2 << 16) | s1;
-}
-
-uint32_t delta_xxhash32(const void* data, uint32_t len) {
-  return XXH32(data, len, 0);
-}
-
-DeltaSignature* delta_signature_create(const void* old_file_data, uint64_t old_file_size,
-                                       uint32_t block_size) {
-  if (old_file_data == NULL || old_file_size == 0 || block_size == 0)
-    return NULL;
-
-  uint32_t block_count = (uint32_t)((old_file_size + block_size - 1) / block_size);
-
-  DeltaSignature* sig = malloc(sizeof(DeltaSignature));
-  if (!sig)
-    return NULL;
-
-  sig->file_size = old_file_size;
-  sig->block_size = block_size;
-  sig->block_count = block_count;
-  sig->blocks = malloc(block_count * sizeof(DeltaBlockSig));
-  if (!sig->blocks) {
-    free(sig);
-    return NULL;
-  }
-
-  const uint8_t* data = (const uint8_t*)old_file_data;
-  for (uint32_t i = 0; i < block_count; i++) {
-    uint64_t offset = (uint64_t)i * block_size;
-    uint32_t len =
-        (uint32_t)((old_file_size - offset < block_size) ? (old_file_size - offset) : block_size);
-    sig->blocks[i].adler32 = delta_adler32(data + offset, len);
-    sig->blocks[i].xxhash = delta_xxhash32(data + offset, len);
-  }
-
-  return sig;
-}
-
-Data* delta_signature_serialize(const DeltaSignature* sig) {
-  if (!sig)
-    return NULL;
-
-  uint64_t total = sizeof(uint64_t) + sizeof(uint32_t) + sizeof(uint32_t) +
-                   (uint64_t)sig->block_count * (sizeof(uint32_t) + sizeof(uint32_t));
-
-  uint8_t* buf = malloc((size_t)total);
-  if (!buf)
-    return NULL;
-
-  size_t pos = 0;
-  memcpy(buf + pos, &sig->file_size, sizeof(uint64_t));
-  pos += sizeof(uint64_t);
-  memcpy(buf + pos, &sig->block_size, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-  memcpy(buf + pos, &sig->block_count, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-
-  for (uint32_t i = 0; i < sig->block_count; i++) {
-    memcpy(buf + pos, &sig->blocks[i].adler32, sizeof(uint32_t));
-    pos += sizeof(uint32_t);
-    memcpy(buf + pos, &sig->blocks[i].xxhash, sizeof(uint32_t));
-    pos += sizeof(uint32_t);
-  }
-
-  return data_create(buf, (size_t)total);
-}
-
-DeltaSignature* delta_signature_deserialize(const Data* data) {
-  if (!data || data->size < sizeof(uint64_t) + sizeof(uint32_t) + sizeof(uint32_t))
-    return NULL;
-
-  const uint8_t* buf = (const uint8_t*)data->data;
-  size_t pos = 0;
-
-  DeltaSignature* sig = malloc(sizeof(DeltaSignature));
-  if (!sig)
-    return NULL;
-
-  memcpy(&sig->file_size, buf + pos, sizeof(uint64_t));
-  pos += sizeof(uint64_t);
-  memcpy(&sig->block_size, buf + pos, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-  memcpy(&sig->block_count, buf + pos, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-
-  uint64_t expected = sizeof(uint64_t) + sizeof(uint32_t) + sizeof(uint32_t) +
-                      (uint64_t)sig->block_count * (sizeof(uint32_t) + sizeof(uint32_t));
-  if (data->size < expected) {
-    free(sig);
-    return NULL;
-  }
-
-  sig->blocks = malloc(sig->block_count * sizeof(DeltaBlockSig));
-  if (!sig->blocks) {
-    free(sig);
-    return NULL;
-  }
-
-  for (uint32_t i = 0; i < sig->block_count; i++) {
-    memcpy(&sig->blocks[i].adler32, buf + pos, sizeof(uint32_t));
-    pos += sizeof(uint32_t);
-    memcpy(&sig->blocks[i].xxhash, buf + pos, sizeof(uint32_t));
-    pos += sizeof(uint32_t);
-  }
-
-  return sig;
-}
-
-void delta_signature_destroy(DeltaSignature* sig) {
-  if (!sig)
-    return;
-  free(sig->blocks);
-  free(sig);
-}
-
-static bool ensure_capacity(DeltaInstruction** instrs, uint32_t* capacity, uint32_t count) {
-  if (count < *capacity)
-    return true;
-  uint32_t new_cap = *capacity * 2;
-  DeltaInstruction* tmp = realloc(*instrs, new_cap * sizeof(DeltaInstruction));
-  if (!tmp)
-    return false;
-  *instrs = tmp;
-  *capacity = new_cap;
-  return true;
-}
-
-static bool flush_literal(DeltaInstruction** instrs, uint32_t* capacity, uint32_t* count,
-                          const uint8_t* data, uint64_t start, uint64_t end) {
-  if (start >= end)
-    return true;
-  uint32_t lit_len = (uint32_t)(end - start);
-  if (!ensure_capacity(instrs, capacity, *count))
-    return false;
-  uint8_t* lit_data = malloc(lit_len);
-  if (!lit_data)
-    return false;
-  memcpy(lit_data, data + start, lit_len);
-  (*instrs)[*count].type = DELTA_INSTR_LITERAL;
-  (*instrs)[*count].literal.data = lit_data;
-  (*instrs)[*count].literal.length = lit_len;
-  (*count)++;
-  return true;
-}
-
-Delta* delta_compute(const void* new_file_data, uint64_t new_file_size, const DeltaSignature* sig,
-                     uint32_t block_size) {
-  if (!new_file_data || !sig || new_file_size == 0 || block_size == 0)
-    return NULL;
-
-  const uint8_t* new_data = (const uint8_t*)new_file_data;
-
-  uint32_t capacity = 64;
-  uint32_t count = 0;
-  DeltaInstruction* instrs = malloc(capacity * sizeof(DeltaInstruction));
-  if (!instrs)
-    return NULL;
-
-  uint64_t literal_start = 0;
-  bool has_literal = false;
-
-  uint64_t i = 0;
-
-  uint32_t s1 = 1, s2 = 0;
-  bool rolling_valid = false;
-
-  while (i < new_file_size) {
-    uint32_t window_len =
-        (uint32_t)((new_file_size - i < block_size) ? (new_file_size - i) : block_size);
-    bool full_window = (window_len == block_size);
-
-    uint32_t adler;
-    if (rolling_valid && full_window) {
-      uint8_t old_byte = new_data[i - 1];
-      uint8_t new_byte = new_data[i + block_size - 1];
-      s1 = (s1 + DELTA_ADLER32_MODULUS - old_byte + new_byte) % DELTA_ADLER32_MODULUS;
-      s2 = (s2 + DELTA_ADLER32_MODULUS -
-            (uint32_t)((uint64_t)block_size * old_byte % DELTA_ADLER32_MODULUS) + s1 - 1) %
-           DELTA_ADLER32_MODULUS;
-      adler = (s2 << 16) | s1;
-    } else {
-      s1 = 1;
-      s2 = 0;
-      for (uint32_t k = 0; k < window_len; k++) {
-        s1 = (s1 + new_data[i + k]) % DELTA_ADLER32_MODULUS;
-        s2 = (s2 + s1) % DELTA_ADLER32_MODULUS;
-      }
-      adler = (s2 << 16) | s1;
-      rolling_valid = full_window;
-    }
-
-    bool matched = false;
-    for (uint32_t j = 0; j < sig->block_count; j++) {
-      if (adler == sig->blocks[j].adler32 && full_window) {
-        uint32_t xxh = delta_xxhash32(new_data + i, window_len);
-        if (xxh == sig->blocks[j].xxhash) {
-          if (has_literal) {
-            if (!flush_literal(&instrs, &capacity, &count, new_data, literal_start, i)) {
-              free(instrs);
-              return NULL;
-            }
-            has_literal = false;
-          }
-
-          if (!ensure_capacity(&instrs, &capacity, count)) {
-            free(instrs);
-            return NULL;
-          }
-          instrs[count].type = DELTA_INSTR_BLOCK_MATCH;
-          instrs[count].match.block_index = j;
-          instrs[count].match.block_offset = 0;
-          instrs[count].match.length = window_len;
-          count++;
-
-          i += window_len;
-          rolling_valid = false;
-          matched = true;
-          break;
-        }
-      }
-    }
-
-    if (!matched) {
-      if (!has_literal) {
-        literal_start = i;
-        has_literal = true;
-      }
-      i++;
-    }
-  }
-
-  if (has_literal) {
-    if (!flush_literal(&instrs, &capacity, &count, new_data, literal_start, new_file_size)) {
-      free(instrs);
-      return NULL;
-    }
-  }
-
-  Delta* delta = malloc(sizeof(Delta));
-  if (!delta) {
-    for (uint32_t k = 0; k < count; k++) {
-      if (instrs[k].type == DELTA_INSTR_LITERAL)
-        free(instrs[k].literal.data);
-    }
-    free(instrs);
-    return NULL;
-  }
-
-  delta->new_file_size = new_file_size;
-  delta->instruction_count = count;
-  delta->instructions = instrs;
-  delta->delta_size = 0;
-
-  for (uint32_t k = 0; k < count; k++) {
-    delta->delta_size += 1;
-    if (instrs[k].type == DELTA_INSTR_BLOCK_MATCH) {
-      delta->delta_size += sizeof(uint32_t) * 3;
-    } else {
-      delta->delta_size += sizeof(uint32_t) + instrs[k].literal.length;
-    }
-  }
-
-  return delta;
-}
-
-Data* delta_serialize(const Delta* delta) {
-  if (!delta)
-    return NULL;
-
-  uint64_t total = sizeof(uint64_t) + sizeof(uint32_t) + delta->delta_size;
-  uint8_t* buf = malloc((size_t)total);
-  if (!buf)
-    return NULL;
-
-  size_t pos = 0;
-  memcpy(buf + pos, &delta->new_file_size, sizeof(uint64_t));
-  pos += sizeof(uint64_t);
-  memcpy(buf + pos, &delta->instruction_count, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    uint8_t type = (uint8_t)delta->instructions[i].type;
-    memcpy(buf + pos, &type, sizeof(uint8_t));
-    pos += sizeof(uint8_t);
-
-    if (delta->instructions[i].type == DELTA_INSTR_BLOCK_MATCH) {
-      memcpy(buf + pos, &delta->instructions[i].match.block_index, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      memcpy(buf + pos, &delta->instructions[i].match.block_offset, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      memcpy(buf + pos, &delta->instructions[i].match.length, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-    } else {
-      memcpy(buf + pos, &delta->instructions[i].literal.length, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      memcpy(buf + pos, delta->instructions[i].literal.data, delta->instructions[i].literal.length);
-      pos += delta->instructions[i].literal.length;
-    }
-  }
-
-  return data_create(buf, (size_t)total);
-}
-
-Delta* delta_deserialize(const Data* data) {
-  if (!data || data->size < sizeof(uint64_t) + sizeof(uint32_t))
-    return NULL;
-
-  const uint8_t* buf = (const uint8_t*)data->data;
-  size_t pos = 0;
-
-  Delta* delta = malloc(sizeof(Delta));
-  if (!delta)
-    return NULL;
-
-  memcpy(&delta->new_file_size, buf + pos, sizeof(uint64_t));
-  pos += sizeof(uint64_t);
-  memcpy(&delta->instruction_count, buf + pos, sizeof(uint32_t));
-  pos += sizeof(uint32_t);
-
-  delta->instructions = malloc(delta->instruction_count * sizeof(DeltaInstruction));
-  if (!delta->instructions) {
-    free(delta);
-    return NULL;
-  }
-
-  delta->delta_size = 0;
-
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (pos >= data->size) {
-      for (uint32_t k = 0; k < i; k++) {
-        if (delta->instructions[k].type == DELTA_INSTR_LITERAL)
-          free(delta->instructions[k].literal.data);
-      }
-      free(delta->instructions);
-      free(delta);
-      return NULL;
-    }
-
-    uint8_t type;
-    memcpy(&type, buf + pos, sizeof(uint8_t));
-    pos += sizeof(uint8_t);
-
-    delta->delta_size += 1;
-
-    if (type == DELTA_OP_BLOCK_MATCH) {
-      if (pos + sizeof(uint32_t) * 3 > data->size) {
-        free(delta->instructions);
-        free(delta);
-        return NULL;
-      }
-      delta->instructions[i].type = DELTA_INSTR_BLOCK_MATCH;
-      memcpy(&delta->instructions[i].match.block_index, buf + pos, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      memcpy(&delta->instructions[i].match.block_offset, buf + pos, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      memcpy(&delta->instructions[i].match.length, buf + pos, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-      delta->delta_size += sizeof(uint32_t) * 3;
-    } else if (type == DELTA_OP_LITERAL) {
-      if (pos + sizeof(uint32_t) > data->size) {
-        for (uint32_t k = 0; k < i; k++) {
-          if (delta->instructions[k].type == DELTA_INSTR_LITERAL)
-            free(delta->instructions[k].literal.data);
-        }
-        free(delta->instructions);
-        free(delta);
-        return NULL;
-      }
-      delta->instructions[i].type = DELTA_INSTR_LITERAL;
-      memcpy(&delta->instructions[i].literal.length, buf + pos, sizeof(uint32_t));
-      pos += sizeof(uint32_t);
-
-      uint32_t lit_len = delta->instructions[i].literal.length;
-      if (pos + lit_len > data->size) {
-        for (uint32_t k = 0; k < i; k++) {
-          if (delta->instructions[k].type == DELTA_INSTR_LITERAL)
-            free(delta->instructions[k].literal.data);
-        }
-        free(delta->instructions);
-        free(delta);
-        return NULL;
-      }
-      delta->instructions[i].literal.data = malloc(lit_len);
-      if (!delta->instructions[i].literal.data) {
-        free(delta->instructions);
-        free(delta);
-        return NULL;
-      }
-      memcpy(delta->instructions[i].literal.data, buf + pos, lit_len);
-      pos += lit_len;
-      delta->delta_size += sizeof(uint32_t) + lit_len;
-    } else {
-      for (uint32_t k = 0; k < i; k++) {
-        if (delta->instructions[k].type == DELTA_INSTR_LITERAL)
-          free(delta->instructions[k].literal.data);
-      }
-      free(delta->instructions);
-      free(delta);
-      return NULL;
-    }
-  }
-
-  return delta;
-}
-
-void* delta_apply(const void* old_data, uint64_t old_size, const Delta* delta,
-                  uint32_t block_size) {
-  if (!old_data || !delta)
-    return NULL;
-
-  void* output = malloc((size_t)delta->new_file_size);
-  if (!output)
-    return NULL;
-
-  uint8_t* out = (uint8_t*)output;
-  const uint8_t* old = (const uint8_t*)old_data;
-  uint64_t out_pos = 0;
-
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_BLOCK_MATCH) {
-      uint64_t src_offset = (uint64_t)delta->instructions[i].match.block_index * block_size;
-      src_offset += delta->instructions[i].match.block_offset;
-      uint32_t len = delta->instructions[i].match.length;
-
-      if (src_offset + len > old_size) {
-        free(output);
-        return NULL;
-      }
-      memcpy(out + out_pos, old + src_offset, len);
-      out_pos += len;
-    } else {
-      uint32_t len = delta->instructions[i].literal.length;
-      memcpy(out + out_pos, delta->instructions[i].literal.data, len);
-      out_pos += len;
-    }
-  }
-
-  if (out_pos != delta->new_file_size) {
-    free(output);
-    return NULL;
-  }
-
-  return output;
-}
-
-void delta_destroy(Delta* delta) {
-  if (!delta)
-    return;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_LITERAL)
-      free(delta->instructions[i].literal.data);
-  }
-  free(delta->instructions);
-  free(delta);
-}
-
-bool delta_should_attempt(uint64_t old_size, uint64_t new_size, uint64_t max_file_size) {
-  if (old_size < DELTA_MIN_FILE_SIZE || new_size < DELTA_MIN_FILE_SIZE)
-    return false;
-  if (old_size > max_file_size || new_size > max_file_size)
-    return false;
-  double large = (old_size > new_size) ? (double)old_size : (double)new_size;
-  double small = (old_size > new_size) ? (double)new_size : (double)old_size;
-  if (small == 0 || large / small > DELTA_MAX_SIZE_RATIO)
-    return false;
-  return true;
-}
-
-bool delta_is_worthwhile(const Delta* delta, uint64_t new_file_size) {
-  if (!delta || delta->instruction_count == 0)
-    return false;
-
-  bool has_match = false;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_BLOCK_MATCH) {
-      has_match = true;
-      break;
-    }
-  }
-  if (!has_match)
-    return false;
-
-  double ratio = (double)delta->delta_size / (double)new_file_size;
-  return ratio < DELTA_FALLBACK_RATIO;
-}

src/shared/delta.h

@@ -1,76 +0,0 @@
-#ifndef DELTA_H
-#define DELTA_H
-
-#include "data.h"
-#include <stdbool.h>
-#include <stdint.h>
-#include <stddef.h>
-
-#define DELTA_BLOCK_SIZE_DEFAULT 8192U
-#define DELTA_BLOCK_SIZE_MIN 1024U
-#define DELTA_BLOCK_SIZE_MAX 65536U
-#define DELTA_MIN_FILE_SIZE 16384ULL
-#define DELTA_MAX_FILE_SIZE (256ULL * 1024 * 1024)
-#define DELTA_MAX_SIZE_RATIO 10.0
-#define DELTA_FALLBACK_RATIO 0.7
-#define DELTA_ADLER32_MODULUS 65521U
-
-#define DELTA_OP_BLOCK_MATCH 0x01
-#define DELTA_OP_LITERAL 0x02
-
-typedef struct {
-  uint32_t adler32;
-  uint32_t xxhash;
-} DeltaBlockSig;
-
-typedef struct {
-  uint64_t file_size;
-  uint32_t block_size;
-  uint32_t block_count;
-  DeltaBlockSig* blocks;
-} DeltaSignature;
-
-typedef enum { DELTA_INSTR_BLOCK_MATCH = 0x01, DELTA_INSTR_LITERAL = 0x02 } DeltaInstrType;
-
-typedef struct {
-  DeltaInstrType type;
-  union {
-    struct {
-      uint32_t block_index;
-      uint32_t block_offset;
-      uint32_t length;
-    } match;
-    struct {
-      uint8_t* data;
-      uint32_t length;
-    } literal;
-  };
-} DeltaInstruction;
-
-typedef struct {
-  uint64_t new_file_size;
-  uint32_t instruction_count;
-  DeltaInstruction* instructions;
-  uint64_t delta_size;
-} Delta;
-
-DeltaSignature* delta_signature_create(const void* old_file_data, uint64_t old_file_size,
-                                       uint32_t block_size);
-Data* delta_signature_serialize(const DeltaSignature* sig);
-DeltaSignature* delta_signature_deserialize(const Data* data);
-void delta_signature_destroy(DeltaSignature* sig);
-
-Delta* delta_compute(const void* new_file_data, uint64_t new_file_size, const DeltaSignature* sig,
-                     uint32_t block_size);
-Data* delta_serialize(const Delta* delta);
-Delta* delta_deserialize(const Data* data);
-void* delta_apply(const void* old_data, uint64_t old_size, const Delta* delta, uint32_t block_size);
-void delta_destroy(Delta* delta);
-
-bool delta_should_attempt(uint64_t old_size, uint64_t new_size, uint64_t max_file_size);
-bool delta_is_worthwhile(const Delta* delta, uint64_t new_file_size);
-
-uint32_t delta_adler32(const void* data, uint32_t len);
-uint32_t delta_xxhash32(const void* data, uint32_t len);
-
-#endif

src/shared/file.c

@@ -1,5 +1,4 @@
 #include <dirent.h>
-#include <errno.h>
 #include <fcntl.h>
 #include <libgen.h>
 #include <stddef.h>
@@ -11,7 +10,6 @@
 #include <unistd.h>
 
 #include "compression.h"
-#include "delta.h"
 #include "log.h"
 #include "config.h"
 #include "data.h"
@@ -21,24 +19,21 @@
 #include "protocol.h"
 #include "utils.h"
 
-#define STREAM_THRESHOLD (64ULL * 1024 * 1024) /* 64 MB */
-#define STREAM_CHUNK_SIZE (1ULL * 1024 * 1024) /* 1 MB */
-
-File* file_create(const char* path) {
-  File* file = (File*)malloc(sizeof(File));
+File *file_create(const char *path) {
+  File *file = (File *)malloc(sizeof(File));
   if (file == NULL) {
     perror("ERROR: Could not allocate memory for file struct");
     return NULL;
   }
 
   int path_len = strlen(path);
-  file->path = (char*)malloc(path_len + 1);
+  file->path = (char *)malloc(path_len + 1);
   if (file->path == NULL) {
     free(file);
     return NULL;
   }
 
-  memcpy(file->path, path, path_len + 1);
+  strcpy(file->path, path);
   file->data = data_create_reserve(0);
   if (file->data == NULL) {
     free(file->path);
@@ -46,28 +41,24 @@ File* file_create(const char* path) {
     return NULL;
   }
   file->metadata = NULL;
-  file->type = FILE_TYPE_REGULAR;
-  file->link_target = NULL;
   return file;
 }
 
-void file_destroy(void* item) {
+void file_destroy(void *item) {
   if (item == NULL)
     return;
-  File* file = (File*)item;
+  File *file = (File *)item;
   data_destroy(file->data);
   file->data = NULL;
   file_metadata_destroy(file->metadata);
   file->metadata = NULL;
   free(file->path);
   file->path = NULL;
-  free(file->link_target);
-  file->link_target = NULL;
   free(file);
 }
 
-FileMetadata* file_metadata_create(const struct stat* stats) {
-  FileMetadata* m = malloc(sizeof(FileMetadata));
+FileMetadata *file_metadata_create(struct stat *stats) {
+  FileMetadata *m = malloc(sizeof(FileMetadata));
   if (m == NULL) {
     perror("ERROR: Could not allocate memory for file metadata");
     return NULL;
@@ -84,21 +75,12 @@ FileMetadata* file_metadata_create(const struct stat* stats) {
   return m;
 }
 
-void file_metadata_destroy(void* metadata) {
+void file_metadata_destroy(void *metadata) {
   free(metadata);
 }
 
-bool file_load_data(File* file) {
-  if (file == NULL)
-    return false;
-  // Symlinks have no data to load
-  if (file->type == FILE_TYPE_SYMLINK)
-    return true;
-  // For streaming files, just record the size, don't load into memory
-  if (file->data->size > STREAM_THRESHOLD) {
-    // Don't allocate; streaming will read directly from disk
-    return true;
-  }
+bool file_load_data(File *file) {
+  if (file == NULL) return false;
   if (file->data->data == NULL) {
     file->data->data = malloc(file->data->size);
     if (file->data->data == NULL) {
@@ -114,76 +96,9 @@ bool file_load_data(File* file) {
   return true;
 }
 
-// Stream file content in chunks without loading entire file into RAM
-static bool file_send_streaming(File* file, int file_descriptor) {
-  unsigned long long total_size = file->data->size;
-  // Send total size prefix (same wire format as send_data)
-  if (!send_n_data(file_descriptor, &total_size, sizeof(total_size)))
-    return false;
-
-  FILE* fp = fopen(file->path, "rb");
-  if (!fp) {
-    perror("Could not open file for streaming");
-    return false;
-  }
-
-  char* buf = malloc(STREAM_CHUNK_SIZE);
-  if (!buf) {
-    fclose(fp);
-    return false;
-  }
-  unsigned long long remaining = total_size;
-  while (remaining > 0) {
-    size_t to_read = (size_t)((remaining < STREAM_CHUNK_SIZE) ? remaining : STREAM_CHUNK_SIZE);
-    size_t nread = fread(buf, 1, to_read, fp);
-    if (nread != to_read) {
-      if (ferror(fp)) {
-        perror("Read error during streaming");
-      }
-      free(buf);
-      fclose(fp);
-      return false;
-    }
-    if (!send_n_data(file_descriptor, buf, nread)) {
-      free(buf);
-      fclose(fp);
-      return false;
-    }
-    remaining -= (unsigned long long)nread;
-  }
-  free(buf);
-  fclose(fp);
-  return true;
-}
-
-bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
-                            int compression_level, bool send_path) {
-  if (send_path && !send_str(file_descriptor, file->path))
-    return false;
-  if (use_metadata && !metadata_send(file_descriptor, file->metadata))
-    return false;
-
-  // Send file type indicator so receiver can distinguish regular from symlink
-  int ft = (int)file->type;
-  if (!send_int(file_descriptor, ft))
-    return false;
-
-  if (file->type == FILE_TYPE_SYMLINK) {
-    // Send link target, then zero-length data
-    if (!send_str(file_descriptor, file->link_target ? file->link_target : ""))
-      return false;
-    Data empty = {NULL, 0};
-    return send_data(file_descriptor, &empty);
-  }
-
-  const Data* data_to_send = file->data;
-  Data* compressed_data = NULL;
-
-  // Streaming mode: for large files without compression, stream from disk
-  if (file->data->size > STREAM_THRESHOLD && compression_level == 0) {
-    return file_send_streaming(file, file_descriptor);
-  }
-
+bool file_send_single_calls(File *file, int file_descriptor, bool use_metadata, int compression_level, bool send_path) {
+  Data *data_to_send = file->data;
+  Data *compressed_data = NULL;
   if (compression_level > 0) {
     compressed_data = data_compress(file->data, compression_level);
     if (compressed_data == NULL) {
@@ -192,6 +107,14 @@ bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
     }
     data_to_send = compressed_data;
   }
+  if (send_path && !send_str(file_descriptor, file->path)) {
+    data_destroy(compressed_data);
+    return false;
+  }
+  if (use_metadata && !metadata_send(file_descriptor, file->metadata)) {
+    data_destroy(compressed_data);
+    return false;
+  }
   if (!send_data(file_descriptor, data_to_send)) {
     data_destroy(compressed_data);
     return false;
@@ -200,257 +123,18 @@ bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
   return true;
 }
 
-static bool has_path_traversal(const char* path) {
-  // Check if ".." appears as a path component — at start, end, or between '/'
-  const char* p = path;
-  while ((p = strstr(p, "..")) != NULL) {
-    bool at_start = (p == path);
-    bool after_slash = (p > path && p[-1] == '/');
-    bool at_end = (p[2] == '\0');
-    bool before_slash = (p[2] == '/');
-    if ((at_start || after_slash) && (at_end || before_slash))
-      return true;
-    p += 2;
-  }
-  return false;
-}
-
-bool file_save_to_disk(const char* root_directory, File* file) {
-  if (file->type == FILE_TYPE_SYMLINK && file->link_target) {
-    // Validate link_target — reject absolute paths or traversal
-    if (file->link_target[0] == '/' || has_path_traversal(file->link_target)) {
-      log_message(LOG_LEVEL_ERROR, "Path traversal blocked in symlink target: %s",
-                  file->link_target);
-      return false;
-    }
-    char* disk_path = path_cat((char*)root_directory, file->path);
-    if (disk_path == NULL)
-      return false;
-    if (has_path_traversal(disk_path)) {
-      log_message(LOG_LEVEL_ERROR, "Path traversal blocked: %s", disk_path);
-      free(disk_path);
-      return false;
-    }
-    unlink(disk_path);
-    bool ok = (symlink(file->link_target, disk_path) == 0);
-    if (ok && file->metadata)
-      file_restore_metadata(disk_path, file->metadata);
-    free(disk_path);
-    return ok;
-  }
-
-  char* disk_path = path_cat((char*)root_directory, file->path);
-  if (disk_path == NULL)
-    return false;
-  if (has_path_traversal(disk_path)) {
-    log_message(LOG_LEVEL_ERROR, "Path traversal blocked: %s", disk_path);
-    free(disk_path);
-    return false;
-  }
+bool file_save_to_disk(const char *root_directory, File *file) {
+  char *disk_path = path_cat((char *)root_directory, file->path);
+  if (disk_path == NULL) return false;
   bool ok = to_disk(disk_path, file->data->data, file->data->size);
-  if (ok)
-    file_restore_metadata(disk_path, file->metadata);
+  if (ok) file_restore_metadata(disk_path, file->metadata);
   free(disk_path);
   return ok;
 }
 
-static void* old_data_from_path(const char* full_path, unsigned long long old_size) {
-  void* data = malloc((size_t)old_size);
-  if (!data)
-    return NULL;
-  FILE* fp = fopen(full_path, "rb");
-  if (!fp) {
-    free(data);
-    return NULL;
-  }
-  size_t nread = fread(data, 1, (size_t)old_size, fp);
-  fclose(fp);
-  if (nread != (size_t)old_size) {
-    free(data);
-    return NULL;
-  }
-  return data;
-}
-
-/**
- * Helper: receive data from wire, optionally decompress, and store in file.
- * On success, returns the received Data* (caller owns it). On failure, returns NULL.
- * If `file_data` is received via receive_data(fd), this function handles decompression
- * when config->use_compression is set.
- */
-static Data* receive_and_decompress(int fd, const Config* config) {
-  Data* file_data = receive_data(fd);
-  if (file_data == NULL)
-    return NULL;
-  if (config->use_compression) {
-    Data* uncompressed = data_decompress(file_data);
-    data_destroy(file_data);
-    if (uncompressed == NULL)
-      return NULL;
-    file_data = uncompressed;
-  }
-  return file_data;
-}
-
-/**
- * Helper: receive metadata from wire and assign to file.
- * Returns true on success (metadata may be NULL if absent), false on I/O error.
- */
-static bool receive_and_assign_metadata(int fd, const Config* config, File* file) {
-  if (!config->use_metadata)
-    return true;
-  int meta_ok = 1;
-  file->metadata = metadata_receive(fd, &meta_ok);
-  if (!meta_ok) {
-    file_destroy(file);
-    send_status(fd, STATUS_ERROR);
-    return false;
-  }
-  return true;
-}
-
-static File* receive_delta_file(int fd, const Config* config, const char* check_path,
-                                void* old_data, unsigned long long old_size) {
-  if (!old_data)
-    return NULL;
-
-  DeltaSignature* sig = delta_signature_create(old_data, old_size, config->delta_block_size);
-  if (!sig) {
-    free(old_data);
-    return NULL;
-  }
-
-  Data* sig_data = delta_signature_serialize(sig);
-  if (!sig_data) {
-    delta_signature_destroy(sig);
-    free(old_data);
-    return NULL;
-  }
-
-  bool sig_sent = send_status(fd, STATUS_DELTA_SIGNATURE) && send_data(fd, sig_data);
-  data_destroy(sig_data);
-
-  if (!sig_sent) {
-    delta_signature_destroy(sig);
-    free(old_data);
-    return NULL;
-  }
-
-  Status resp;
-  if (!receive_status(fd, &resp)) {
-    delta_signature_destroy(sig);
-    free(old_data);
-    return NULL;
-  }
-
-  if (resp == STATUS_DELTA_DATA) {
-    Data* delta_data = receive_data(fd);
-    if (!delta_data) {
-      delta_signature_destroy(sig);
-      free(old_data);
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    Data* raw_delta = delta_data;
-    if (config->use_compression) {
-      raw_delta = data_decompress(delta_data);
-      data_destroy(delta_data);
-      if (!raw_delta) {
-        free(old_data);
-        delta_signature_destroy(sig);
-        send_status(fd, STATUS_ERROR);
-        return NULL;
-      }
-    }
-
-    Delta* delta = delta_deserialize(raw_delta);
-    data_destroy(raw_delta);
-    if (!delta) {
-      free(old_data);
-      delta_signature_destroy(sig);
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    void* new_data = delta_apply(old_data, old_size, delta, config->delta_block_size);
-    uint64_t new_size = delta->new_file_size;
-    delta_destroy(delta);
-
-    if (!new_data) {
-      free(old_data);
-      delta_signature_destroy(sig);
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    File* file = file_create(check_path);
-    if (!file) {
-      free(new_data);
-      free(old_data);
-      delta_signature_destroy(sig);
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    if (config->use_metadata) {
-      int meta_ok = 1;
-      file->metadata = metadata_receive(fd, &meta_ok);
-      if (!meta_ok) {
-        file_destroy(file);
-        free(new_data);
-        free(old_data);
-        delta_signature_destroy(sig);
-        send_status(fd, STATUS_ERROR);
-        return NULL;
-      }
-    }
-
-    data_destroy(file->data);
-    file->data = data_create(new_data, (size_t)new_size);
-
-    free(old_data);
-    delta_signature_destroy(sig);
-    return file;
-  }
-
-  if (resp == STATUS_NEXT) {
-    delta_signature_destroy(sig);
-    free(old_data);
-
-    File* file = file_create(check_path);
-    if (!file) {
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    if (!receive_and_assign_metadata(fd, config, file))
-      return NULL;
-
-    Data* file_data = receive_and_decompress(fd, config);
-    if (file_data == NULL) {
-      file_destroy(file);
-      send_status(fd, STATUS_ERROR);
-      return NULL;
-    }
-
-    data_destroy(file->data);
-    file->data = file_data;
-    return file;
-  }
-
-  delta_signature_destroy(sig);
-  free(old_data);
-  return NULL;
-}
-
-File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
-  *skipped = false;
-  char* check_path = receive_str(fd);
-  if (check_path == NULL) {
-    send_status(fd, STATUS_ERROR);
-    return NULL;
-  }
+File *receive_incremental_check(int fd, Config *config, bool *skipped) {  *skipped = false;
+  char *check_path = receive_str(fd);
+  if (check_path == NULL) { send_status(fd, STATUS_ERROR); return NULL; }
 
   unsigned long long check_size;
   long long check_mtime;
@@ -461,169 +145,82 @@ File* receive_incremental_check(int fd, const Config* config, bool* skipped) {
     return NULL;
   }
 
-  char* full_path = path_cat(config->receive_root_directory, check_path);
-  if (full_path && strstr(full_path, "..") != NULL) {
-    log_message(LOG_LEVEL_ERROR, "Path traversal blocked: %s", full_path);
-    free(full_path);
-    free(check_path);
-    send_status(fd, STATUS_ERROR);
-    return NULL;
-  }
+  char *full_path = path_cat(config->receive_root_directory, check_path);
   struct stat st;
-  bool has_old_file = (full_path && stat(full_path, &st) == 0);
-  unsigned long long old_size = has_old_file ? (unsigned long long)st.st_size : 0;
-
-  // Check for partial file if enabled
-  if (config->partial && !has_old_file && full_path) {
-    char* partial_path = malloc(strlen(full_path) + 20);
-    if (partial_path) {
-      snprintf(partial_path, strlen(full_path) + 20, "%s.fastsync-partial", full_path);
-      has_old_file = (stat(partial_path, &st) == 0);
-      if (has_old_file)
-        old_size = (unsigned long long)st.st_size;
-      free(partial_path);
+  bool match = false;
+  if (full_path && stat(full_path, &st) == 0 &&
+      (unsigned long long)st.st_size == check_size &&
+      (long long)st.st_mtime == check_mtime) {
+    match = true;
   }
-  }
-
-  bool match = has_old_file && (unsigned long long)st.st_size == check_size &&
-               (long long)st.st_mtime == check_mtime;
+  free(full_path);
 
   if (match) {
-    if (!send_status(fd, STATUS_OK)) {
-      free(full_path);
-      free(check_path);
-      return NULL;
-    }
-    free(full_path);
+    if (!send_status(fd, STATUS_OK)) { free(check_path); return NULL; }
     free(check_path);
     *skipped = true;
     return NULL;
   }
 
-  bool try_delta = config->use_delta && has_old_file &&
-                   delta_should_attempt(old_size, check_size, config->delta_max_file_size);
+  if (!send_status(fd, STATUS_NEXT)) { free(check_path); return NULL; }
 
-  if (try_delta) {
-    void* old_data = old_data_from_path(full_path, old_size);
-    File* delta_file = receive_delta_file(fd, config, check_path, old_data, old_size);
-    if (delta_file) {
-      free(full_path);
+  File *file = file_create(check_path);
   free(check_path);
-      return delta_file;
-    }
-    try_delta = false;
+  if (file == NULL) { send_status(fd, STATUS_ERROR); return NULL; }
+
+  if (config->use_metadata) {
+    int meta_ok = 1;
+    file->metadata = metadata_receive(fd, &meta_ok);
+    if (!meta_ok) { file_destroy(file); send_status(fd, STATUS_ERROR); return NULL; }
   }
 
-  if (!try_delta) {
-    if (!send_status(fd, STATUS_NEXT)) {
-      free(full_path);
-      free(check_path);
-      return NULL;
-    }
-  }
-
-  File* file = file_create(check_path);
-  free(check_path);
-  free(full_path);
-  if (file == NULL) {
-    send_status(fd, STATUS_ERROR);
-    return NULL;
-  }
-
-  if (!receive_and_assign_metadata(fd, config, file))
-    return NULL;
-
-  // Read file type indicator
-  int file_type;
-  if (!receive_int(fd, &file_type)) {
-    file_destroy(file);
-    send_status(fd, STATUS_ERROR);
-    return NULL;
-  }
-  file->type = (FileType)file_type;
-
-  if (file->type == FILE_TYPE_SYMLINK) {
-    char* link_target = receive_str(fd);
-    if (link_target) {
-      file->link_target = link_target;
-    }
-    Data* empty_data = receive_data(fd);
-    if (empty_data)
-      data_destroy(empty_data);
-    return file;
-  }
-
-  Data* file_data = receive_and_decompress(fd, config);
+  Data *file_data = receive_data(fd);
   if (file_data == NULL) {
     file_destroy(file);
     send_status(fd, STATUS_ERROR);
     return NULL;
   }
 
+  if (config->use_compression) {
+    Data *uncompressed = data_decompress(file_data);
+    data_destroy(file_data);
+    if (uncompressed == NULL) { file_destroy(file); send_status(fd, STATUS_ERROR); return NULL; }
+    file_data = uncompressed;
+  }
+
   data_destroy(file->data);
   file->data = file_data;
   return file;
 }
 
-bool to_disk(const char* path, const void* data, unsigned long long data_size) {
-  // dirname() may modify its argument and may return a pointer to static storage.
-  // We must use a copy of the result to be safe.
-  char* path_dup = str_dup(path);
-  if (!path_dup)
-    return false;
-  const char* dir_result = dirname(path_dup);
-  char* directory = str_dup(dir_result);
-  free(path_dup);
-  if (!directory)
-    return false;
-
-  bool ok = true;
+bool to_disk(const char *path, const void *data, unsigned long long data_size) {
+  char *directory = str_dup(path);
+  char *dir_to_free = directory;
+  directory = dirname(directory);
   if (!mkdir_r(directory)) {
-    ok = false;
-    goto done;
+    free(dir_to_free);
+    return false;
   }
-  FILE* file_pointer = fopen(path, "wb");
+  FILE *file_pointer = fopen(path, "wb");
   if (file_pointer == NULL) {
     perror("Could not open File");
-    ok = false;
-    goto done;
+    free(dir_to_free);
+    return false;
   }
   if (fwrite(data, 1, data_size, file_pointer) != data_size) {
     perror("Failed to write all data to disk");
     fclose(file_pointer);
-    ok = false;
-    goto done;
+    free(dir_to_free);
+    return false;
   }
   fclose(file_pointer);
-
-done:
-  free(directory);
-  return ok;
+  free(dir_to_free);
+  return true;
 }
 
-bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level,
-                        bool send_path) {
-  // Handle symlinks
-  if (file->type == FILE_TYPE_SYMLINK) {
-    return file_send_single_calls(file, file_descriptor, use_metadata, compression_level,
-                                  send_path);
-  }
-
-  // sendfile is incompatible with compression (kernel zero-copy).
-  // If compression is requested, fall back to the regular send path.
-  if (compression_level > 0)
-    return file_send_single_calls(file, file_descriptor, use_metadata, compression_level,
-                                  send_path);
-
-  if (send_path && !send_str(file_descriptor, file->path))
-    return false;
-  if (use_metadata && !metadata_send(file_descriptor, file->metadata))
-    return false;
-
-  // Send file type indicator
-  int ft = (int)file->type;
-  if (!send_int(file_descriptor, ft))
-    return false;
+bool file_send_sendfile(File *file, int file_descriptor, bool use_metadata, bool send_path) {
+  if (send_path && !send_str(file_descriptor, file->path)) return false;
+  if (use_metadata && !metadata_send(file_descriptor, file->metadata)) return false;
 
   int fd = open(file->path, O_RDONLY);
   if (fd == -1) {
@@ -638,11 +235,9 @@ bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int
   }
 
   off_t offset = 0;
-  while ((unsigned long long)offset < file_size) {
+  while (offset < file_size) {
     ssize_t sent = sendfile(file_descriptor, fd, &offset, file_size - offset);
     if (sent == -1) {
-      if (errno == EINTR)
-        continue;
       perror("sendfile failed");
       close(fd);
       return false;
@@ -653,53 +248,24 @@ bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int
   return true;
 }
 
-File* file_receive(const Config* config, int file_descriptor) {
-  char* path = receive_str(file_descriptor);
-  if (path == NULL)
-    return NULL;
-  File* file = file_create(path);
+File *file_receive(Config *config, int file_descriptor) {
+  char *path = receive_str(file_descriptor);
+  if (path == NULL) return NULL;
+  File *file = file_create(path);
   free(path);
-  if (file == NULL)
-    return NULL;
+  if (file == NULL) return NULL;
   if (config->use_metadata) {
     int meta_ok = 1;
     file->metadata = metadata_receive(file_descriptor, &meta_ok);
-    if (!meta_ok) {
-      file_destroy(file);
-      return NULL;
+    if (!meta_ok) { file_destroy(file); return NULL; }
   }
-  }
-
-  // Receive file type indicator
-  int file_type;
-  if (!receive_int(file_descriptor, &file_type)) {
-    file_destroy(file);
-    return NULL;
-  }
-  file->type = (FileType)file_type;
-
-  if (file->type == FILE_TYPE_SYMLINK) {
-    char* link_target = receive_str(file_descriptor);
-    if (link_target == NULL) {
-      file_destroy(file);
-      return NULL;
-    }
-    file->link_target = link_target;
-    // Receive and discard zero-length data
-    Data* empty_data = receive_data(file_descriptor);
-    if (empty_data)
-      data_destroy(empty_data);
-    return file;
-  }
-
-  // Regular file - receive data
-  Data* file_data = receive_data(file_descriptor);
+  Data *file_data = receive_data(file_descriptor);
   if (file_data == NULL) {
     file_destroy(file);
     return NULL;
   }
   if (config->use_compression) {
-    Data* file_data_uncompressed = data_decompress(file_data);
+    Data *file_data_uncompressed = data_decompress(file_data);
     data_destroy(file_data);
     if (file_data_uncompressed == NULL) {
       file_destroy(file);
@@ -707,19 +273,19 @@ File* file_receive(const Config* config, int file_descriptor) {
     }
     file_data = file_data_uncompressed;
   }
-
   data_destroy(file->data);
   file->data = file_data;
   return file;
 }
 
-size_t file_content_to_buffer(File* file) {
-  FILE* file_pointer = fopen(file->path, "rb");
+size_t file_content_to_buffer(File *file) {
+  FILE *file_pointer = fopen(file->path, "rb");
   if (file_pointer == NULL) {
     perror("Could not open the file!");
     return 0;
   }
-  size_t bytes_read = fread(file->data->data, 1, file->data->size, file_pointer);
+  size_t bytes_read =
+      fread(file->data->data, 1, file->data->size, file_pointer);
   if (bytes_read != (size_t)file->data->size) {
     fclose(file_pointer);
     perror("Read unexpected number of bytes from File!");
@@ -729,22 +295,21 @@ size_t file_content_to_buffer(File* file) {
   return bytes_read;
 }
 
-int receive_manifest(int fd, const Config* config, int* next_status) {
+int receive_manifest(int fd, Config *config, int *next_status) {
   int count;
-  if (!receive_int(fd, &count))
-    return -1;
-  ArrayList* manifest = array_list_create(free);
+  if (!receive_int(fd, &count)) return -1;
+  ArrayList *manifest = array_list_create(free);
   if (manifest) {
     for (int i = 0; i < count; i++) {
-      char* s = receive_str(fd);
-      if (s)
-        array_list_add(manifest, s);
+      char *s = receive_str(fd);
+      if (s) array_list_add(manifest, s);
     }
     fprintf(stderr, "Deleting files not in manifest...\n");
     delete_extras(config->receive_root_directory, manifest);
     array_list_delete(manifest);
   }
-  if (!receive_status(fd, next_status))
-    return -1;
+  if (!receive_status(fd, next_status)) return -1;
   return 0;
 }
+
+

src/shared/file.h

@@ -6,8 +6,6 @@
 #include <stdbool.h>
 #include <sys/stat.h>
 
-typedef enum { FILE_TYPE_REGULAR, FILE_TYPE_SYMLINK, FILE_TYPE_DIR } FileType;
-
 typedef struct {
   mode_t mode;
   uid_t uid;
@@ -17,27 +15,23 @@ typedef struct {
 } FileMetadata;
 
 typedef struct {
-  char* path;
-  Data* data;
-  FileMetadata* metadata;
-  FileType type;
-  char* link_target;
+  char *path;
+  Data *data;
+  FileMetadata *metadata;
 } File;
 
-File* file_create(const char* path);
-void file_destroy(void* item);
-bool file_load_data(File* file);
-File* file_receive(const Config* config, int file_descriptor);
-bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
-                            int compression_level, bool send_path);
-bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, int compression_level,
-                        bool send_path);
-size_t file_content_to_buffer(File* file);
-FileMetadata* file_metadata_create(const struct stat* stats);
-void file_metadata_destroy(void* metadata);
-bool to_disk(const char* path, const void* data, unsigned long long data_size);
-bool file_save_to_disk(const char* root_directory, File* file);
-File* receive_incremental_check(int fd, const Config* config, bool* skipped);
-int receive_manifest(int fd, const Config* config, int* next_status);
+File *file_create(const char *path);
+void file_destroy(void *item);
+bool file_load_data(File *file);
+File *file_receive(Config *config, int file_descriptor);
+bool file_send_single_calls(File *file, int file_descriptor, bool use_metadata, int compression_level, bool send_path);
+bool file_send_sendfile(File *file, int file_descriptor, bool use_metadata, bool send_path);
+size_t file_content_to_buffer(File *file);
+FileMetadata *file_metadata_create(struct stat *stats);
+void file_metadata_destroy(void *metadata);
+bool to_disk(const char *path, const void *data, unsigned long long data_size);
+bool file_save_to_disk(const char *root_directory, File *file);
+File *receive_incremental_check(int fd, Config *config, bool *skipped);
+int receive_manifest(int fd, Config *config, int *next_status);
 
 #endif

src/shared/log.c

@@ -3,21 +3,22 @@
 #include <stdio.h>
 #include <time.h>
 
-static const char* log_level_strings[] = {"DEBUG", "INFO", "WARN", "ERROR"};
+static const char *log_level_strings[] = {"DEBUG", "INFO", "WARN", "ERROR"};
 static LogLevel current_log_level = LOG_LEVEL_WARNING;
 
 void set_log_level(LogLevel level) {
   current_log_level = level;
 }
 
-void log_message(LogLevel log_level, const char* format, ...) {
+void log_message(LogLevel log_level, char *format, ...) {
   if (log_level < current_log_level)
     return;
   time_t now = time(NULL);
-  const struct tm* t = localtime(&now);
+  struct tm *t = localtime(&now);
 
-  fprintf(stderr, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t->tm_year + 1900, t->tm_mon + 1,
-          t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, log_level_strings[log_level]);
+  fprintf(stderr, "%04d-%02d-%02d %02d:%02d:%02d [%s]: ", t->tm_year + 1900,
+          t->tm_mon + 1, t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec,
+          log_level_strings[log_level]);
 
   va_list args;
   va_start(args, format);

src/shared/log.h

@@ -1,9 +1,14 @@
 #ifndef LOG_H
 #define LOG_H
 
-typedef enum { LOG_LEVEL_DEBUG, LOG_LEVEL_INFO, LOG_LEVEL_WARNING, LOG_LEVEL_ERROR } LogLevel;
+typedef enum {
+  LOG_LEVEL_DEBUG,
+  LOG_LEVEL_INFO,
+  LOG_LEVEL_WARNING,
+  LOG_LEVEL_ERROR
+} LogLevel;
 
-void log_message(LogLevel log_level, const char* message, ...);
+void log_message(LogLevel log_level, char *message, ...);
 void set_log_level(LogLevel level);
 
 #endif

src/shared/metadata.c

@@ -1,165 +1,90 @@
 #include "metadata.h"
 #include "file.h"
-#include "log.h"
 #include "protocol.h"
-#include <errno.h>
 #include <fcntl.h>
-#include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
 #include <time.h>
 #include <unistd.h>
 
-void metadata_to_buf(char** buf, const FileMetadata* m) {
-  int32_t present = (m != NULL) ? 1 : 0;
-  memcpy(*buf, &present, sizeof(present));
-  *buf += sizeof(present);
+void metadata_to_buf(char **buf, FileMetadata *m) {
+  int present = (m != NULL) ? 1 : 0;
+  memcpy(*buf, &present, sizeof(int));
+  *buf += sizeof(int);
   if (m == NULL)
     return;
-  int32_t mode = (int32_t)m->mode;
-  memcpy(*buf, &mode, sizeof(mode));
-  *buf += sizeof(mode);
-  int32_t uid = (int32_t)m->uid;
-  memcpy(*buf, &uid, sizeof(uid));
-  *buf += sizeof(uid);
-  int32_t gid = (int32_t)m->gid;
-  memcpy(*buf, &gid, sizeof(gid));
-  *buf += sizeof(gid);
-  int64_t mtime_sec = (int64_t)m->mtime_sec;
-  memcpy(*buf, &mtime_sec, sizeof(mtime_sec));
-  *buf += sizeof(mtime_sec);
-  int64_t mtime_nsec = (int64_t)m->mtime_nsec;
-  memcpy(*buf, &mtime_nsec, sizeof(mtime_nsec));
-  *buf += sizeof(mtime_nsec);
+  memcpy(*buf, &m->mode, sizeof(mode_t));        *buf += sizeof(mode_t);
+  memcpy(*buf, &m->uid, sizeof(uid_t));          *buf += sizeof(uid_t);
+  memcpy(*buf, &m->gid, sizeof(gid_t));          *buf += sizeof(gid_t);
+  memcpy(*buf, &m->mtime_sec, sizeof(time_t));   *buf += sizeof(time_t);
+  memcpy(*buf, &m->mtime_nsec, sizeof(long));    *buf += sizeof(long);
 }
 
-FileMetadata* metadata_from_buf(char** buf) {
-  int32_t present;
-  memcpy(&present, *buf, sizeof(present));
-  *buf += sizeof(present);
+FileMetadata *metadata_from_buf(char **buf) {
+  int present;
+  memcpy(&present, *buf, sizeof(int));
+  *buf += sizeof(int);
   if (!present)
     return NULL;
-  FileMetadata* m = malloc(sizeof(FileMetadata));
-  if (m == NULL)
-    return NULL;
-  int32_t mode;
-  memcpy(&mode, *buf, sizeof(mode));
-  *buf += sizeof(mode);
-  m->mode = (mode_t)mode;
-  int32_t uid;
-  memcpy(&uid, *buf, sizeof(uid));
-  *buf += sizeof(uid);
-  m->uid = (uid_t)uid;
-  int32_t gid;
-  memcpy(&gid, *buf, sizeof(gid));
-  *buf += sizeof(gid);
-  m->gid = (gid_t)gid;
-  int64_t mtime_sec;
-  memcpy(&mtime_sec, *buf, sizeof(mtime_sec));
-  *buf += sizeof(mtime_sec);
-  m->mtime_sec = (time_t)mtime_sec;
-  int64_t mtime_nsec;
-  memcpy(&mtime_nsec, *buf, sizeof(mtime_nsec));
-  *buf += sizeof(mtime_nsec);
-  m->mtime_nsec = (long)mtime_nsec;
+  FileMetadata *m = malloc(sizeof(FileMetadata));
+  memcpy(&m->mode, *buf, sizeof(mode_t));        *buf += sizeof(mode_t);
+  memcpy(&m->uid, *buf, sizeof(uid_t));          *buf += sizeof(uid_t);
+  memcpy(&m->gid, *buf, sizeof(gid_t));          *buf += sizeof(gid_t);
+  memcpy(&m->mtime_sec, *buf, sizeof(time_t));   *buf += sizeof(time_t);
+  memcpy(&m->mtime_nsec, *buf, sizeof(long));    *buf += sizeof(long);
   return m;
 }
 
-bool metadata_send(int file_descriptor, FileMetadata* m) {
+bool metadata_send(int file_descriptor, FileMetadata *m) {
   if (m == NULL) {
-    int32_t zero = 0;
-    return send_n_data(file_descriptor, &zero, sizeof(zero));
+    int zero = 0;
+    return send_n_data(file_descriptor, &zero, sizeof(int));
   }
-  int32_t present = 1;
-  int32_t mode = (int32_t)m->mode;
-  int32_t uid = (int32_t)m->uid;
-  int32_t gid = (int32_t)m->gid;
-  int64_t mtime_sec = (int64_t)m->mtime_sec;
-  int64_t mtime_nsec = (int64_t)m->mtime_nsec;
-  return send_n_data(file_descriptor, &present, sizeof(present)) &&
-         send_n_data(file_descriptor, &mode, sizeof(mode)) &&
-         send_n_data(file_descriptor, &uid, sizeof(uid)) &&
-         send_n_data(file_descriptor, &gid, sizeof(gid)) &&
-         send_n_data(file_descriptor, &mtime_sec, sizeof(mtime_sec)) &&
-         send_n_data(file_descriptor, &mtime_nsec, sizeof(mtime_nsec));
+  int present = 1;
+  return send_n_data(file_descriptor, &present, sizeof(int)) &&
+         send_n_data(file_descriptor, &m->mode, sizeof(mode_t)) &&
+         send_n_data(file_descriptor, &m->uid, sizeof(uid_t)) &&
+         send_n_data(file_descriptor, &m->gid, sizeof(gid_t)) &&
+         send_n_data(file_descriptor, &m->mtime_sec, sizeof(time_t)) &&
+         send_n_data(file_descriptor, &m->mtime_nsec, sizeof(long));
 }
 
-FileMetadata* metadata_receive(int file_descriptor, int* ok) {
-  int32_t present;
-  if (!receive_n_data(file_descriptor, &present, sizeof(present))) {
-    if (ok)
-      *ok = 0;
+FileMetadata *metadata_receive(int file_descriptor, int *ok) {
+  int present;
+  if (!receive_n_data(file_descriptor, &present, sizeof(int))) {
+    if (ok) *ok = 0;
     return NULL;
   }
   if (!present) {
-    if (ok)
-      *ok = 1;
+    if (ok) *ok = 1;
     return NULL;
   }
-  FileMetadata* m = malloc(sizeof(FileMetadata));
-  if (m == NULL) {
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  int32_t mode;
-  if (!receive_n_data(file_descriptor, &mode, sizeof(mode))) {
+  FileMetadata *m = malloc(sizeof(FileMetadata));
+  if (m == NULL) { if (ok) *ok = 0; return NULL; }
+  if (!receive_n_data(file_descriptor, &m->mode, sizeof(mode_t)) ||
+      !receive_n_data(file_descriptor, &m->uid, sizeof(uid_t)) ||
+      !receive_n_data(file_descriptor, &m->gid, sizeof(gid_t)) ||
+      !receive_n_data(file_descriptor, &m->mtime_sec, sizeof(time_t)) ||
+      !receive_n_data(file_descriptor, &m->mtime_nsec, sizeof(long))) {
     free(m);
-    if (ok)
-      *ok = 0;
+    if (ok) *ok = 0;
     return NULL;
   }
-  m->mode = (mode_t)mode;
-  int32_t uid;
-  if (!receive_n_data(file_descriptor, &uid, sizeof(uid))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->uid = (uid_t)uid;
-  int32_t gid;
-  if (!receive_n_data(file_descriptor, &gid, sizeof(gid))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->gid = (gid_t)gid;
-  int64_t mtime_sec;
-  if (!receive_n_data(file_descriptor, &mtime_sec, sizeof(mtime_sec))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->mtime_sec = (time_t)mtime_sec;
-  int64_t mtime_nsec;
-  if (!receive_n_data(file_descriptor, &mtime_nsec, sizeof(mtime_nsec))) {
-    free(m);
-    if (ok)
-      *ok = 0;
-    return NULL;
-  }
-  m->mtime_nsec = (long)mtime_nsec;
-  if (ok)
-    *ok = 1;
+  if (ok) *ok = 1;
   return m;
 }
 
-void file_restore_metadata(const char* path, FileMetadata* metadata) {
+void file_restore_metadata(const char *path, FileMetadata *metadata) {
   if (metadata == NULL)
     return;
-  if (chmod(path, metadata->mode & 07777 & ~(S_ISUID | S_ISGID)) != 0)
-    log_message(LOG_LEVEL_WARNING, "Failed to chmod %s: %s", path, strerror(errno));
-  if (chown(path, metadata->uid, metadata->gid) != 0)
-    log_message(LOG_LEVEL_WARNING, "Failed to chown %s: %s", path, strerror(errno));
+  chmod(path, metadata->mode & 07777);
+  int chown_ret = chown(path, metadata->uid, metadata->gid);
+  (void)chown_ret;
   struct timespec times[2];
   times[0].tv_sec = 0;
   times[0].tv_nsec = UTIME_OMIT;
   times[1].tv_sec = metadata->mtime_sec;
   times[1].tv_nsec = metadata->mtime_nsec;
-  if (utimensat(AT_FDCWD, path, times, 0) != 0)
-    log_message(LOG_LEVEL_WARNING, "Failed to set timestamps on %s: %s", path, strerror(errno));
+  utimensat(AT_FDCWD, path, times, 0);
 }

src/shared/metadata.h

@@ -3,15 +3,14 @@
 
 #include "file.h"
 #include <stdbool.h>
-#include <stdint.h>
 #include <sys/stat.h>
 
-#define FILE_METADATA_WIRE_SIZE (sizeof(int32_t) * 3 + sizeof(int64_t) * 2)
+#define FILE_METADATA_WIRE_SIZE (sizeof(mode_t) + sizeof(uid_t) + sizeof(gid_t) + sizeof(time_t) + sizeof(long))
 
-void metadata_to_buf(char** buf, const FileMetadata* m);
-FileMetadata* metadata_from_buf(char** buf);
-bool metadata_send(int file_descriptor, FileMetadata* m);
-FileMetadata* metadata_receive(int file_descriptor, int* ok);
-void file_restore_metadata(const char* path, FileMetadata* metadata);
+void metadata_to_buf(char **buf, FileMetadata *m);
+FileMetadata *metadata_from_buf(char **buf);
+bool metadata_send(int file_descriptor, FileMetadata *m);
+FileMetadata *metadata_receive(int file_descriptor, int *ok);
+void file_restore_metadata(const char *path, FileMetadata *metadata);
 
 #endif

src/shared/multiprocessing.c

@@ -13,11 +13,11 @@
 #include <string.h>
 #include <threads.h>
 
-PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* queue_scanner,
-                                                      Queue* queue_loader) {
-  PipelineContextSender* context = malloc(sizeof(PipelineContextSender));
-  if (context == NULL)
-    return NULL;
+PipelineContextSender *pipeline_context_sender_create(Config *config,
+                                                      Queue *queue_scanner,
+                                                      Queue *queue_loader) {
+  PipelineContextSender *context = malloc(sizeof(PipelineContextSender));
+  if (context == NULL) return NULL;
   context->config = config;
   context->queue_scanner = queue_scanner;
   context->queue_loader = queue_loader;
@@ -37,7 +37,7 @@ PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* que
   return context;
 }
 
-void pipeline_context_sender_destroy(PipelineContextSender* context) {
+void pipeline_context_sender_destroy(PipelineContextSender *context) {
   if (context->manifest) {
     array_list_delete(context->manifest);
   }
@@ -53,11 +53,11 @@ void pipeline_context_sender_destroy(PipelineContextSender* context) {
   free(context);
 }
 
-PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue,
+PipelineContextReceiver *pipeline_context_receiver_create(Config *config,
+                                                          Queue *queue,
                                                           int file_descriptor) {
-  PipelineContextReceiver* context = malloc(sizeof(PipelineContextReceiver));
-  if (context == NULL)
-    return NULL;
+  PipelineContextReceiver *context = malloc(sizeof(PipelineContextReceiver));
+  if (context == NULL) return NULL;
   context->config = config;
   context->queue = queue;
   context->file_descriptor = file_descriptor;
@@ -72,7 +72,7 @@ PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue*
   return context;
 }
 
-void pipeline_context_receiver_destroy(PipelineContextReceiver* context) {
+void pipeline_context_receiver_destroy(PipelineContextReceiver *context) {
   config_delete(context->config);
   queue_destroy(context->queue);
   mtx_destroy(&context->mutex);
@@ -81,57 +81,57 @@ void pipeline_context_receiver_destroy(PipelineContextReceiver* context) {
   free(context);
 }
 
-static void receive_chunk_enqueue(int file_descriptor, PipelineContextReceiver* context) {
-  Chunk* chunk = receive_chunk_data(file_descriptor, context->config);
-  if (chunk == NULL)
-    return;
+static void receive_chunk_enqueue(int file_descriptor,
+                                  PipelineContextReceiver *context) {
+  Chunk *chunk = receive_chunk_data(file_descriptor, context->config);
+  if (chunk == NULL) return;
 
   for (int i = 0; i < chunk->element_count; i++) {
-    File* file = chunk->items[i];
+    File *file = chunk->items[i];
     chunk->items[i] = NULL;
     queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                &context->condition_not_empty, &context->condition_not_full);
+                                &context->condition_not_empty,
+                                &context->condition_not_full);
   }
   chunk_destroy(chunk);
 }
 
-int receive_thread(void* pipeline_context) {
-  PipelineContextReceiver* context = (PipelineContextReceiver*)pipeline_context;
+int receive_thread(void *pipeline_context) {
+  PipelineContextReceiver *context =
+      (PipelineContextReceiver *)pipeline_context;
   mtx_lock(&context->mutex);
   int file_descriptor = context->file_descriptor;
-  const Config* config = context->config;
+  Config *config = context->config;
   mtx_unlock(&context->mutex);
 
   Status status;
-  if (!receive_status(file_descriptor, &status))
-    return thrd_error;
+  if (!receive_status(file_descriptor, &status)) return thrd_error;
   while (status == STATUS_NEXT || status == STATUS_CHUNK || status == STATUS_CHECK) {
     if (status == STATUS_CHECK) {
       bool skipped;
-      File* file = receive_incremental_check(file_descriptor, config, &skipped);
+      File *file = receive_incremental_check(file_descriptor, config, &skipped);
       if (!skipped) {
-        if (file == NULL)
-          return thrd_error;
+        if (file == NULL) return thrd_error;
         queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                    &context->condition_not_empty, &context->condition_not_full);
+                                    &context->condition_not_empty,
+                                    &context->condition_not_full);
       }
     } else if (status == STATUS_CHUNK) {
       receive_chunk_enqueue(file_descriptor, context);
     } else {
-      File* file = file_receive(config, file_descriptor);
+      File *file = file_receive(config, file_descriptor);
       if (file) {
         queue_enqueue_multithreaded(context->queue, file, &context->mutex,
-                                    &context->condition_not_empty, &context->condition_not_full);
+                                    &context->condition_not_empty,
+                                    &context->condition_not_full);
       } else {
         log_message(LOG_LEVEL_ERROR, "Failed to receive file");
       }
     }
-    if (!receive_status(file_descriptor, &status))
-      return thrd_error;
+    if (!receive_status(file_descriptor, &status)) return thrd_error;
   }
   if (status == STATUS_MANIFEST) {
-    if (receive_manifest(file_descriptor, config, &status) != 0)
-      return thrd_error;
+    if (receive_manifest(file_descriptor, config, &status) != 0) return thrd_error;
   }
   mtx_lock(&context->mutex);
   context->receiver_done = true;
@@ -140,16 +140,17 @@ int receive_thread(void* pipeline_context) {
   return thrd_success;
 }
 
-int write_thread(void* pipeline_context) {
-  PipelineContextReceiver* context = (PipelineContextReceiver*)pipeline_context;
+int write_thread(void *pipeline_context) {
+  PipelineContextReceiver *context =
+      (PipelineContextReceiver *)pipeline_context;
   mtx_lock(&context->mutex);
   bool save_to_disk = context->config->save_to_disk;
-  char* root_directory = str_dup(context->config->receive_root_directory);
+  char *root_directory = str_dup(context->config->receive_root_directory);
   mtx_unlock(&context->mutex);
 
   while (true) {
-    File* file =
-        queue_dequeue_multithreaded(context->queue, &context->mutex, &context->condition_not_empty,
+    File *file = queue_dequeue_multithreaded(
+        context->queue, &context->mutex, &context->condition_not_empty,
         &context->condition_not_full, &context->receiver_done);
     if (file == NULL) {
       free(root_directory);

src/shared/multiprocessing.h

@@ -9,23 +9,23 @@
 #include "queue.h"
 
 typedef struct {
-  Config* config;
-  Queue* queue_scanner;
+  Config *config;
+  Queue *queue_scanner;
   mtx_t mutex_scanner;
   cnd_t condition_not_full_scanner;
   cnd_t condition_not_empty_scanner;
   bool scanner_done;
-  Queue* queue_loader;
+  Queue *queue_loader;
   mtx_t mutex_loader;
   cnd_t condition_not_full_loader;
   cnd_t condition_not_empty_loader;
   bool loader_done;
-  ArrayList* manifest;
+  ArrayList *manifest;
 } PipelineContextSender;
 
 typedef struct PipelineContextReceiver {
-  Queue* queue;
-  Config* config;
+  Queue *queue;
+  Config *config;
   int file_descriptor;
   mtx_t mutex;
   cnd_t condition_not_full;
@@ -33,12 +33,14 @@ typedef struct PipelineContextReceiver {
   bool receiver_done;
 } PipelineContextReceiver;
 
-PipelineContextSender* pipeline_context_sender_create(Config* config, Queue* queue_scanner,
-                                                      Queue* queue_loader);
-void pipeline_context_sender_destroy(PipelineContextSender* context);
-PipelineContextReceiver* pipeline_context_receiver_create(Config* config, Queue* queue_receiver,
+PipelineContextSender *pipeline_context_sender_create(Config *config,
+                                                      Queue *queue_scanner,
+                                                      Queue *queue_loader);
+void pipeline_context_sender_destroy(PipelineContextSender *context);
+PipelineContextReceiver *pipeline_context_receiver_create(Config *config,
+                                                          Queue *queue_receiver,
                                                           int file_descriptor);
-void pipeline_context_receiver_destroy(PipelineContextReceiver* context);
-int receive_thread(void* pipeline_context);
-int write_thread(void* pipeline_context);
+void pipeline_context_receiver_destroy(PipelineContextReceiver *context);
+int receive_thread(void *pipeline_context);
+int write_thread(void *pipeline_context);
 #endif

src/shared/protocol.c

@@ -1,7 +1,6 @@
 #include "protocol.h"
 #include "log.h"
 #include <errno.h>
-#include <openssl/ssl.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -10,7 +9,6 @@
 
 static __thread int io_read_fd = -1;
 static __thread int io_write_fd = -1;
-static SSL* io_ssl = NULL;
 
 static unsigned long long io_bwlimit = 0;
 static long long bw_tokens = 0;
@@ -28,20 +26,16 @@ void io_set_bwlimit(unsigned long long bytes_per_sec) {
 }
 
 static void bw_throttle(size_t bytes_written) {
-  if (io_bwlimit == 0)
-    return;
+  if (io_bwlimit == 0) return;
 
   struct timespec now;
   clock_gettime(CLOCK_MONOTONIC, &now);
 
-  /* Use unsigned long long for elapsed_ns to avoid overflow in multiplication.
-   * time_t differences fit comfortably in 64-bit for any practical runtime. */
-  unsigned long long elapsed_ns =
-      (unsigned long long)(now.tv_sec - bw_last_refill.tv_sec) * 1000000000ULL +
-      (unsigned long long)(now.tv_nsec - bw_last_refill.tv_nsec);
+  long long elapsed_ns = (now.tv_sec - bw_last_refill.tv_sec) * 1000000000LL +
+                         (now.tv_nsec - bw_last_refill.tv_nsec);
   bw_last_refill = now;
 
-  long long tokens_to_add = (long long)((double)io_bwlimit * (double)elapsed_ns / 1000000000.0);
+  long long tokens_to_add = (long long)((double)io_bwlimit * elapsed_ns / 1000000000.0);
   bw_tokens += tokens_to_add;
   if (bw_tokens > (long long)io_bwlimit)
     bw_tokens = (long long)io_bwlimit;
@@ -49,9 +43,7 @@ static void bw_throttle(size_t bytes_written) {
   bw_tokens -= (long long)bytes_written;
 
   if (bw_tokens < 0) {
-    long long deficit_ns = (long long)((double)(-bw_tokens) / (double)io_bwlimit * 1000000000.0);
-    if (deficit_ns < 0)
-      deficit_ns = 0;
+    long long deficit_ns = (long long)((double)(-bw_tokens) / io_bwlimit * 1000000000.0);
     struct timespec sleep_time, remaining;
     sleep_time.tv_sec = deficit_ns / 1000000000LL;
     sleep_time.tv_nsec = deficit_ns % 1000000000LL;
@@ -62,33 +54,21 @@ static void bw_throttle(size_t bytes_written) {
   }
 }
 
-void io_set_ssl(SSL* ssl) {
-  io_ssl = ssl;
-}
-
 static int io_fd(int dir_fd, int file_descriptor) {
   return (dir_fd != -1) ? dir_fd : file_descriptor;
 }
 
-bool send_n_data(int file_descriptor, const void* data, size_t data_size) {
+bool send_n_data(int file_descriptor, void *data, size_t data_size) {
   log_message(LOG_LEVEL_DEBUG, "    Sending n Data: %zu", data_size);
   int fd = io_fd(io_write_fd, file_descriptor);
   ssize_t total_bytes_send = 0;
-  while ((size_t)total_bytes_send < data_size) {
+  while (total_bytes_send < data_size) {
     size_t chunk = data_size - total_bytes_send;
     if (io_bwlimit > 0 && chunk > 65536)
       chunk = 65536;
-    ssize_t bytes_send;
-    if (io_ssl)
-      bytes_send = SSL_write(io_ssl, (const char*)data + total_bytes_send, chunk);
-    else
-      bytes_send = write(fd, (const char*)data + total_bytes_send, chunk);
+    ssize_t bytes_send =
+        write(fd, (char *)data + total_bytes_send, chunk);
     if (bytes_send <= 0) {
-      if (io_ssl) {
-        int ssl_err = SSL_get_error(io_ssl, (int)bytes_send);
-        if (ssl_err == SSL_ERROR_WANT_WRITE || ssl_err == SSL_ERROR_WANT_READ)
-          continue;
-      }
       log_message(LOG_LEVEL_ERROR, "Could not send data");
       return false;
     }
@@ -99,24 +79,14 @@ bool send_n_data(int file_descriptor, const void* data, size_t data_size) {
   return true;
 }
 
-bool receive_n_data(int file_descriptor, void* data, size_t data_size) {
+bool receive_n_data(int file_descriptor, void *data, size_t data_size) {
   log_message(LOG_LEVEL_DEBUG, "    Receiving n Data: %zu", data_size);
   int fd = io_fd(io_read_fd, file_descriptor);
   size_t total_bytes_received = 0;
   while (total_bytes_received < data_size) {
-    ssize_t bytes_received;
-    if (io_ssl)
-      bytes_received =
-          SSL_read(io_ssl, (char*)data + total_bytes_received, data_size - total_bytes_received);
-    else
-      bytes_received =
-          read(fd, (char*)data + total_bytes_received, data_size - total_bytes_received);
+    ssize_t bytes_received =
+        read(fd, (char *)data + total_bytes_received, data_size - total_bytes_received);
     if (bytes_received <= 0) {
-      if (io_ssl) {
-        int ssl_err = SSL_get_error(io_ssl, (int)bytes_received);
-        if (ssl_err == SSL_ERROR_WANT_READ || ssl_err == SSL_ERROR_WANT_WRITE)
-          continue;
-      }
       if (bytes_received == 0)
         log_message(LOG_LEVEL_ERROR, "Connection closed while receiving data");
       else
@@ -129,7 +99,7 @@ bool receive_n_data(int file_descriptor, void* data, size_t data_size) {
   return true;
 }
 
-static const char* status_to_string(Status status) {
+static const char *status_to_string(Status status) {
   switch (status) {
   case STATUS_OK:
     return "OK";
@@ -143,41 +113,24 @@ static const char* status_to_string(Status status) {
     return "CHUNK";
   case STATUS_CHECK:
     return "CHECK";
-  case STATUS_DELTA_SIGNATURE:
-    return "DELTA_SIGNATURE";
-  case STATUS_DELTA_DATA:
-    return "DELTA_DATA";
   default:
     return "UNKNOWN";
   }
 }
 
-bool send_str(int file_descriptor, const char* data) {
-  if (data == NULL) {
-    log_message(LOG_LEVEL_ERROR, "send_str called with NULL data");
-    return false;
-  }
+bool send_str(int file_descriptor, char *data) {
   size_t size = strlen(data);
-  if (!send_n_data(file_descriptor, &size, sizeof(size_t)))
-    return false;
-  if (!send_n_data(file_descriptor, data, size))
-    return false;
+  if (!send_n_data(file_descriptor, &size, sizeof(size_t))) return false;
+  if (!send_n_data(file_descriptor, data, size)) return false;
   log_message(LOG_LEVEL_DEBUG, "Send String: %s", data);
   return true;
 }
 
-char* receive_str(int file_descriptor) {
+char *receive_str(int file_descriptor) {
   size_t size;
-  if (!receive_n_data(file_descriptor, &size, sizeof(size_t)))
-    return NULL;
-  if (size > MAX_STRING_SIZE) {
-    log_message(LOG_LEVEL_ERROR, "receive_str: size %zu exceeds maximum %zu", size,
-                (size_t)MAX_STRING_SIZE);
-    return NULL;
-  }
-  char* data = (char*)malloc(size + 1);
-  if (data == NULL)
-    return NULL;
+  if (!receive_n_data(file_descriptor, &size, sizeof(size_t))) return NULL;
+  char *data = (char *)malloc(size + 1);
+  if (data == NULL) return NULL;
   if (!receive_n_data(file_descriptor, data, size)) {
     free(data);
     return NULL;
@@ -187,7 +140,7 @@ char* receive_str(int file_descriptor) {
   return data;
 }
 
-bool send_data(int file_descriptor, const Data* data) {
+bool send_data(int file_descriptor, Data *data) {
   unsigned long long data_size = data->size;
   if (!send_n_data(file_descriptor, &data_size, sizeof(unsigned long long)))
     return false;
@@ -197,19 +150,12 @@ bool send_data(int file_descriptor, const Data* data) {
   return true;
 }
 
-#define MAX_DATA_SIZE (1024ULL * 1024 * 1024) // 1 GB
-
-Data* receive_data(int file_descriptor) {
+Data *receive_data(int file_descriptor) {
   unsigned long long size = 0;
   if (!receive_n_data(file_descriptor, &size, sizeof(unsigned long long)))
     return NULL;
-  if (size > MAX_DATA_SIZE) {
-    log_message(LOG_LEVEL_ERROR, "receive_data: size %llu exceeds maximum", size);
-    return NULL;
-  }
-  void* data = malloc((size_t)size);
-  if (data == NULL)
-    return NULL;
+  void *data = malloc((size_t)size);
+  if (data == NULL) return NULL;
   if (!receive_n_data(file_descriptor, data, (size_t)size)) {
     free(data);
     return NULL;
@@ -219,29 +165,25 @@ Data* receive_data(int file_descriptor) {
 }
 
 bool send_int(int file_descriptor, int data) {
-  if (!send_n_data(file_descriptor, &data, sizeof(int)))
-    return false;
+  if (!send_n_data(file_descriptor, &data, sizeof(int))) return false;
   log_message(LOG_LEVEL_DEBUG, "Send Int: %d", data);
   return true;
 }
 
-bool receive_int(int file_descriptor, int* data) {
-  if (!receive_n_data(file_descriptor, data, sizeof(int)))
-    return false;
+bool receive_int(int file_descriptor, int *data) {
+  if (!receive_n_data(file_descriptor, data, sizeof(int))) return false;
   log_message(LOG_LEVEL_DEBUG, "Received Int: %d", *data);
   return true;
 }
 
 bool send_status(int file_descriptor, Status status) {
-  if (!send_n_data(file_descriptor, &status, sizeof(Status)))
-    return false;
+  if (!send_n_data(file_descriptor, &status, sizeof(Status))) return false;
   log_message(LOG_LEVEL_DEBUG, "Send Status: %s", status_to_string(status));
   return true;
 }
 
-bool receive_status(int file_descriptor, Status* status) {
-  if (!receive_n_data(file_descriptor, status, sizeof(Status)))
-    return false;
+bool receive_status(int file_descriptor, Status *status) {
+  if (!receive_n_data(file_descriptor, status, sizeof(Status))) return false;
   log_message(LOG_LEVEL_DEBUG, "Received Status: %s", status_to_string(*status));
   return true;
 }

src/shared/protocol.h

@@ -5,37 +5,21 @@
 #include <stdbool.h>
 #include <stddef.h>
 
-/* Maximum allowed string size for receive_str (10 MB) */
-#define MAX_STRING_SIZE (10 * 1024 * 1024)
-
-typedef struct ssl_st SSL;
-
 typedef int Status;
-enum NET_STATUS {
-  STATUS_OK,
-  STATUS_ERROR,
-  STATUS_FINISHED,
-  STATUS_NEXT,
-  STATUS_CHUNK,
-  STATUS_MANIFEST,
-  STATUS_CHECK,
-  STATUS_DELTA_SIGNATURE,
-  STATUS_DELTA_DATA
-};
+enum NET_STATUS { STATUS_OK, STATUS_ERROR, STATUS_FINISHED, STATUS_NEXT, STATUS_CHUNK, STATUS_MANIFEST, STATUS_CHECK };
 
 void io_set_fds(int read_fd, int write_fd);
 void io_set_bwlimit(unsigned long long bytes_per_sec);
-void io_set_ssl(SSL* ssl);
-bool send_n_data(int file_descriptor, const void* data, size_t data_size);
-bool receive_n_data(int file_descriptor, void* data, size_t data_size);
+bool send_n_data(int file_descriptor, void *data, size_t data_size);
+bool receive_n_data(int file_descriptor, void *data, size_t data_size);
 
-bool send_str(int file_descriptor, const char* data);
-char* receive_str(int file_descriptor);
-bool send_data(int file_descriptor, const Data* data);
-Data* receive_data(int file_descriptor);
+bool send_str(int file_descriptor, char *data);
+char *receive_str(int file_descriptor);
+bool send_data(int file_descriptor, Data *data);
+Data *receive_data(int file_descriptor);
 bool send_int(int file_descriptor, int data);
-bool receive_int(int file_descriptor, int* data);
+bool receive_int(int file_descriptor, int *data);
 bool send_status(int file_descriptor, Status status);
-bool receive_status(int file_descriptor, Status* status);
+bool receive_status(int file_descriptor, Status *status);
 
 #endif

src/shared/queue.c

@@ -6,14 +6,14 @@
 
 #include "queue.h"
 
-Queue* queue_create(int capacity, void (*destroyer)(void* item)) {
-  Queue* queue = (Queue*)malloc(sizeof(Queue));
+Queue *queue_create(int capacity, void (*destroyer)(void *item)) {
+  Queue *queue = (Queue *)malloc(sizeof(Queue));
   if (queue == NULL) {
     perror("ERROR: Could not allocate memory for queue structure");
     return NULL;
   }
 
-  queue->items = malloc(capacity * sizeof(void*));
+  queue->items = malloc(capacity * sizeof(void *));
   if (queue->items == NULL) {
     free(queue);
     return NULL;
@@ -32,7 +32,7 @@ Queue* queue_create(int capacity, void (*destroyer)(void* item)) {
   return queue;
 }
 
-void queue_destroy(Queue* queue) {
+void queue_destroy(Queue *queue) {
   if (queue == NULL)
     return;
 
@@ -46,25 +46,24 @@ void queue_destroy(Queue* queue) {
   free(queue);
 }
 
-bool queue_is_empty(const Queue* queue) {
+bool queue_is_empty(Queue *queue) {
   if (queue == NULL)
     return true;
   return queue->size == 0;
 }
 
-bool queue_is_full(const Queue* queue) {
+bool queue_is_full(Queue *queue) {
   if (queue == NULL)
     return false;
   return queue->size == queue->capacity;
 }
 
-static bool queue_double_capacity(Queue* queue) {
-  if (queue == NULL)
-    return false;
+static bool queue_double_capacity(Queue *queue) {
+  if (queue == NULL) return false;
   unsigned int new_capacity = queue->capacity * 2;
   if (new_capacity <= 1)
     new_capacity = 100;
-  void** new_items = malloc(new_capacity * sizeof(void*));
+  void **new_items = malloc(new_capacity * sizeof(void *));
   if (new_items == NULL) {
     perror("ERROR: Could not allocate memory for doubling capacity of queue.");
     return false;
@@ -79,12 +78,10 @@ static bool queue_double_capacity(Queue* queue) {
   return true;
 }
 
-bool queue_enqueue(Queue* queue, void* item) {
-  if (queue == NULL || item == NULL)
-    return false;
+bool queue_enqueue(Queue *queue, void *item) {
+  if (queue == NULL || item == NULL) return false;
   if (queue_is_full(queue)) {
-    if (!queue_double_capacity(queue))
-      return false;
+    if (!queue_double_capacity(queue)) return false;
   }
   queue->items[queue->rear] = item;
   queue->rear = (queue->rear + 1) % queue->capacity;
@@ -92,8 +89,9 @@ bool queue_enqueue(Queue* queue, void* item) {
   return true;
 }
 
-bool queue_enqueue_multithreaded(Queue* queue, void* item, mtx_t* mutex, cnd_t* condition_not_empty,
-                                 cnd_t* condition_not_full) {
+bool queue_enqueue_multithreaded(Queue *queue, void *item, mtx_t *mutex,
+                                 cnd_t *condition_not_empty,
+                                 cnd_t *condition_not_full) {
   mtx_lock(mutex);
   while (queue_is_full(queue))
     cnd_wait(condition_not_full, mutex);
@@ -103,21 +101,23 @@ bool queue_enqueue_multithreaded(Queue* queue, void* item, mtx_t* mutex, cnd_t*
   return ok;
 }
 
-void* queue_dequeue(Queue* queue) {
+void *queue_dequeue(Queue *queue) {
   if (queue == NULL || queue_is_empty(queue)) {
     perror("ERROR: Could not dequeue from null or empty queue.");
     return NULL;
   }
 
-  void* item = queue->items[queue->front];
+  void *item = queue->items[queue->front];
   queue->items[queue->front] = NULL;
   queue->front = (queue->front + 1) % queue->capacity;
   queue->size--;
   return item;
 }
 
-void* queue_dequeue_multithreaded(Queue* queue, mtx_t* mutex, cnd_t* condition_not_empty,
-                                  cnd_t* condition_not_full, const bool* other_thread_done) {
+void *queue_dequeue_multithreaded(Queue *queue, mtx_t *mutex,
+                                  cnd_t *condition_not_empty,
+                                  cnd_t *condition_not_full,
+                                  bool *other_thread_done) {
   mtx_lock(mutex);
   while (queue_is_empty(queue) && !*other_thread_done)
     cnd_wait(condition_not_empty, mutex);
@@ -125,7 +125,7 @@ void* queue_dequeue_multithreaded(Queue* queue, mtx_t* mutex, cnd_t* condition_n
     mtx_unlock(mutex);
     return NULL;
   }
-  void* item = queue_dequeue(queue);
+  void *item = queue_dequeue(queue);
   cnd_signal(condition_not_full);
   mtx_unlock(mutex);
   return item;

src/shared/queue.h

@@ -5,23 +5,26 @@
 #include <threads.h>
 
 typedef struct Queue {
-  void** items;
+  void **items;
   int front;
   int rear;
   int size;
   int capacity;
-  void (*item_destroyer)(void* item);
+  void (*item_destroyer)(void *item);
 } Queue;
 
-Queue* queue_create(int capacity, void (*destroyer)(void* item));
-void queue_destroy(Queue* queue);
-bool queue_is_empty(const Queue* queue);
-bool queue_is_full(const Queue* queue);
-bool queue_enqueue(Queue* queue, void* item);
-bool queue_enqueue_multithreaded(Queue* queue, void* item, mtx_t* mutex, cnd_t* condition_not_empty,
-                                 cnd_t* condition_not_full);
-void* queue_dequeue(Queue* queue);
-void* queue_dequeue_multithreaded(Queue* queue, mtx_t* mutex, cnd_t* condition_not_empty,
-                                  cnd_t* condition_not_full, const bool* other_thread_done);
+Queue *queue_create(int capacity, void (*destroyer)(void *item));
+void queue_destroy(Queue *queue);
+bool queue_is_empty(Queue *queue);
+bool queue_is_full(Queue *queue);
+bool queue_enqueue(Queue *queue, void *item);
+bool queue_enqueue_multithreaded(Queue *queue, void *item, mtx_t *mutex,
+                                 cnd_t *condition_not_empty,
+                                 cnd_t *condition_not_full);
+void *queue_dequeue(Queue *queue);
+void *queue_dequeue_multithreaded(Queue *queue, mtx_t *mutex,
+                                  cnd_t *condition_not_empty,
+                                  cnd_t *condition_not_full,
+                                  bool *other_thread_done);
 
 #endif

src/shared/transport_ssh.c

@@ -1,5 +1,4 @@
 #include "transport_ssh.h"
-#include "utils.h"
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -9,65 +8,41 @@
 #include <unistd.h>
 
 typedef struct {
-  char* user;
-  char* host;
-  char* remote_path;
+  char user[256];
+  char host[256];
+  char remote_path[4096];
 } RemoteDest;
 
-static void remote_dest_destroy(RemoteDest* r) {
-  free(r->user);
-  free(r->host);
-  free(r->remote_path);
-}
+static int parse_remote_dest(const char *dest, RemoteDest *r) {
+  const char *colon = strchr(dest, ':');
+  if (!colon) return -1;
 
-static int parse_remote_dest(const char* dest, RemoteDest* r) {
-  memset(r, 0, sizeof(*r));
-  const char* colon = strchr(dest, ':');
-  if (!colon)
-    return -1;
+  size_t remote_path_len = strlen(colon + 1);
+  if (remote_path_len >= sizeof(r->remote_path)) return -1;
+  memcpy(r->remote_path, colon + 1, remote_path_len + 1);
 
-  r->remote_path = str_dup(colon + 1);
-  if (!r->remote_path)
-    return -1;
-
-  const char* at = memchr(dest, '@', colon - dest);
+  const char *at = memchr(dest, '@', colon - dest);
   if (at) {
     size_t user_len = at - dest;
-    r->user = malloc(user_len + 1);
-    if (!r->user) {
-      remote_dest_destroy(r);
-      return -1;
-    }
+    if (user_len >= sizeof(r->user)) return -1;
     memcpy(r->user, dest, user_len);
     r->user[user_len] = '\0';
 
     size_t host_len = colon - at - 1;
-    r->host = malloc(host_len + 1);
-    if (!r->host) {
-      remote_dest_destroy(r);
-      return -1;
-    }
+    if (host_len >= sizeof(r->host)) return -1;
     memcpy(r->host, at + 1, host_len);
     r->host[host_len] = '\0';
   } else {
-    r->user = str_dup("");
-    if (!r->user) {
-      remote_dest_destroy(r);
-      return -1;
-    }
+    r->user[0] = '\0';
     size_t host_len = colon - dest;
-    r->host = malloc(host_len + 1);
-    if (!r->host) {
-      remote_dest_destroy(r);
-      return -1;
-    }
+    if (host_len >= sizeof(r->host)) return -1;
     memcpy(r->host, dest, host_len);
     r->host[host_len] = '\0';
   }
   return 0;
 }
 
-Client* client_connect_ssh(const char* destination, int port) {
+Client *client_connect_ssh(char *destination, int port) {
   RemoteDest r;
   if (parse_remote_dest(destination, &r) != 0) {
     fprintf(stderr, "Invalid remote destination: %s\n", destination);
@@ -77,7 +52,6 @@ Client* client_connect_ssh(const char* destination, int port) {
   int sv[2];
   if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv) < 0) {
     perror("socketpair failed");
-    remote_dest_destroy(&r);
     return NULL;
   }
 
@@ -90,20 +64,15 @@ Client* client_connect_ssh(const char* destination, int port) {
   int exec_pipe[2];
   if (pipe(exec_pipe) < 0) {
     perror("pipe failed");
-    close(sv[0]);
-    close(sv[1]);
-    remote_dest_destroy(&r);
+    close(sv[0]); close(sv[1]);
     return NULL;
   }
 
   pid_t pid = fork();
   if (pid < 0) {
     perror("fork failed");
-    close(sv[0]);
-    close(sv[1]);
-    close(exec_pipe[0]);
-    close(exec_pipe[1]);
-    remote_dest_destroy(&r);
+    close(sv[0]); close(sv[1]);
+    close(exec_pipe[0]); close(exec_pipe[1]);
     return NULL;
   }
 
@@ -111,23 +80,20 @@ Client* client_connect_ssh(const char* destination, int port) {
     close(sv[0]);
     close(exec_pipe[0]);
     fcntl(exec_pipe[1], F_SETFD, FD_CLOEXEC);
+
     if (sv[1] != STDIN_FILENO)
       dup2(sv[1], STDIN_FILENO);
     if (sv[1] != STDOUT_FILENO)
       dup2(sv[1], STDOUT_FILENO);
-    if (sv[1] > 1)
-      close(sv[1]);
+    if (sv[1] > 1) close(sv[1]);
 
     char ssh_user[512];
-    if (r.user && r.user[0] != '\0')
+    if (r.user[0] != '\0')
       snprintf(ssh_user, sizeof(ssh_user), "%s@%s", r.user, r.host);
     else
       snprintf(ssh_user, sizeof(ssh_user), "%s", r.host);
 
-    size_t ssh_argv_max = 32;
-    char** ssh_argv = calloc(ssh_argv_max, sizeof(char*));
-    if (ssh_argv == NULL)
-      _exit(1);
+    char *ssh_argv[16];
     int ac = 0;
     char port_str[16];
     ssh_argv[ac++] = "ssh";
@@ -138,22 +104,15 @@ Client* client_connect_ssh(const char* destination, int port) {
     ssh_argv[ac++] = "-o";
     ssh_argv[ac++] = "ControlPath=~/.cache/fastsync-%r@%h:%p";
     if (port > 0 && port != 22) {
-      if ((size_t)ac + 2 >= ssh_argv_max) {
-        _exit(1);
-      }
       ssh_argv[ac++] = "-p";
       snprintf(port_str, sizeof(port_str), "%d", port);
       ssh_argv[ac++] = port_str;
     }
-    if ((size_t)ac + 3 >= ssh_argv_max) {
-      _exit(1);
-    }
     ssh_argv[ac++] = ssh_user;
     ssh_argv[ac++] = "fastsync-server";
     ssh_argv[ac++] = "--stdio";
     ssh_argv[ac] = NULL;
     execvp("ssh", ssh_argv);
-    free(ssh_argv);
     perror("exec of ssh failed");
     ssize_t wret = write(exec_pipe[1], "x", 1);
     (void)wret;
@@ -170,24 +129,19 @@ Client* client_connect_ssh(const char* destination, int port) {
   if (n > 0) {
     close(sv[0]);
     waitpid(pid, NULL, 0);
-    remote_dest_destroy(&r);
     fprintf(stderr, "Error: could not launch 'fastsync-server --stdio' on remote\n");
     return NULL;
   }
 
-  remote_dest_destroy(&r);
-
-  Client* client = malloc(sizeof(Client));
+  Client *client = malloc(sizeof(Client));
   if (client == NULL) {
     close(sv[0]);
     waitpid(pid, NULL, 0);
     return NULL;
   }
   client->file_descriptor = sv[0];
-  client->address.ss_family = AF_UNIX;
+  client->address.sin_family = AF_UNIX;
   client->address_length = 0;
   client->ssh_child_pid = pid;
-  client->ssl = NULL;
-  client->ssl_ctx = NULL;
   return client;
 }

src/shared/transport_ssh.h

@@ -3,6 +3,6 @@
 
 #include "transport_tcp.h"
 
-Client* client_connect_ssh(const char* destination, int port);
+Client *client_connect_ssh(char *destination, int port);
 
 #endif

src/shared/transport_tcp.c

@@ -1,294 +1,130 @@
 #include "transport_tcp.h"
 #include "log.h"
-#include "protocol.h"
 #include <arpa/inet.h>
-#include <errno.h>
-#include <netdb.h>
-#include <openssl/ssl.h>
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/socket.h>
-#include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
-bool set_socket_timeouts(int fd) {
-  struct timeval tv;
-  tv.tv_sec = 30;
-  tv.tv_usec = 0;
-
-  int keepalive = 1;
-  if (setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof(keepalive)) < 0) {
-    perror("Could not set SO_KEEPALIVE");
-    return false;
-  }
-  if (setsockopt(fd, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof(tv)) < 0) {
-    perror("Could not set SO_RCVTIMEO");
-    return false;
-  }
-  if (setsockopt(fd, SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv)) < 0) {
-    perror("Could not set SO_SNDTIMEO");
-    return false;
-  }
-  return true;
-}
-
-Server* server_create(int port) {
-  Server* server = (Server*)malloc(sizeof(Server));
+Server *server_create(int port) {
+  Server *server = (Server *)malloc(sizeof(Server));
   if (server == NULL) {
     perror("Could not allocate space for Server");
     return NULL;
   }
-  memset(&server->address, 0, sizeof(server->address));
-  server->ssl_ctx = NULL;
 
-  // Try IPv6 first, fall back to IPv4
-  int domain = AF_INET6;
-  int fd = socket(domain, SOCK_STREAM, 0);
-  if (fd < 0) {
-    domain = AF_INET;
-    fd = socket(domain, SOCK_STREAM, 0);
-  }
-  if (fd < 0) {
+  int file_descriptor = socket(AF_INET, SOCK_STREAM, 0);
+  if (file_descriptor < 0) {
     perror("Could not create Socket!");
     free(server);
     return NULL;
   }
-
-  if (!set_socket_timeouts(fd)) {
-    close(fd);
-    free(server);
-    return NULL;
-  }
-
-  server->file_descriptor = fd;
+  server->file_descriptor = file_descriptor;
   int opt = 1;
-  if (setsockopt(server->file_descriptor, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt))) {
+  if (setsockopt(server->file_descriptor, SOL_SOCKET, SO_REUSEADDR, &opt,
+                 sizeof(opt))) {
     perror("Error setting a socket option!");
     close(server->file_descriptor);
     free(server);
     return NULL;
   }
 
-  struct sockaddr_storage* addr = &server->address;
-  struct sockaddr_in* addr4 = (struct sockaddr_in*)addr;
-  struct sockaddr_in6* addr6 = (struct sockaddr_in6*)addr;
+  server->address.sin_family = AF_INET;
+  server->address.sin_addr.s_addr = INADDR_ANY;
+  server->address.sin_port = htons(port);
+  server->address_length = sizeof(server->address);
 
-  if (domain == AF_INET6) {
-    addr6->sin6_family = AF_INET6;
-    addr6->sin6_addr = in6addr_any;
-    addr6->sin6_port = htons(port);
-    server->address_length = sizeof(struct sockaddr_in6);
-  } else {
-    addr4->sin_family = AF_INET;
-    addr4->sin_addr.s_addr = INADDR_ANY;
-    addr4->sin_port = htons(port);
-    server->address_length = sizeof(struct sockaddr_in);
-  }
-
-  if (bind(server->file_descriptor, (struct sockaddr*)&server->address, server->address_length) <
-      0) {
-    // If IPv6 bind failed (maybe no IPv6), try IPv4
-    if (domain == AF_INET6) {
-      close(fd);
-      fd = socket(AF_INET, SOCK_STREAM, 0);
-      if (fd < 0) {
-        perror("Could not create IPv4 Socket!");
-        free(server);
-        return NULL;
-      }
-      if (!set_socket_timeouts(fd)) {
-        close(fd);
-        free(server);
-        return NULL;
-      }
-      server->file_descriptor = fd;
-      setsockopt(server->file_descriptor, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
-      memset(addr, 0, sizeof(*addr));
-      addr4->sin_family = AF_INET;
-      addr4->sin_addr.s_addr = INADDR_ANY;
-      addr4->sin_port = htons(port);
-      server->address_length = sizeof(struct sockaddr_in);
-      if (bind(server->file_descriptor, (struct sockaddr*)addr, server->address_length) < 0) {
+  if (bind(server->file_descriptor, (struct sockaddr *)&server->address,
+           server->address_length) < 0) {
     perror("Could not bind server");
     close(server->file_descriptor);
     free(server);
     return NULL;
   }
-    } else {
-      perror("Could not bind server");
-      close(server->file_descriptor);
-      free(server);
-      return NULL;
-    }
-  }
 
   return server;
 }
 
-void server_delete(Server** server) {
-  if (server == NULL || *server == NULL)
-    return;
+void server_delete(Server **server) {
+  if (server == NULL || *server == NULL) return;
   close((*server)->file_descriptor);
-  if ((*server)->ssl_ctx) {
-    SSL_CTX_free((*server)->ssl_ctx);
-    (*server)->ssl_ctx = NULL;
-  }
   free(*server);
   *server = NULL;
 }
 
-/* Flag set by server_request_shutdown() to request graceful shutdown
-   of the accept loop. Accessed only from transport_tcp.c so it won't
-   cause linker errors when this file is compiled into client/test targets. */
-static volatile sig_atomic_t g_tcp_cleanup_requested = 0;
-
-void server_request_shutdown(void) {
-  g_tcp_cleanup_requested = 1;
-}
-
-static void accept_loop(Server* server, void (*child_fn)(int, void*), void* child_ctx,
-                        const char* log_fmt) {
+bool server_listen(Server *server, void (*handler)(int file_descriptor)) {
+  log_message(LOG_LEVEL_INFO, "Start Listening on Port: %d",
+              server->address.sin_port);
   if (listen(server->file_descriptor, SOMAXCONN) < 0) {
     perror("Could not listen on port!");
-    return;
+    return false;
   }
+
   signal(SIGCHLD, SIG_IGN);
-  while (!g_tcp_cleanup_requested) {
-    struct sockaddr_storage client_addr;
+
+  while (1) {
+    struct sockaddr_in client_addr;
     socklen_t client_len = sizeof(client_addr);
-    int fd = accept(server->file_descriptor, (struct sockaddr*)&client_addr, &client_len);
-    if (fd < 0) {
-      if (errno == EINTR) {
-        if (g_tcp_cleanup_requested)
-          break;
-        continue;
-      }
+    int file_descriptor =
+        accept(server->file_descriptor, (struct sockaddr *)&client_addr,
+               &client_len);
+    if (file_descriptor < 0) {
       perror("Could not accept the connection");
       continue;
     }
-    set_socket_timeouts(fd);
-    log_message(LOG_LEVEL_INFO, "%s", log_fmt);
+    log_message(LOG_LEVEL_INFO, "Received Connection");
     pid_t pid = fork();
     if (pid == 0) {
       close(server->file_descriptor);
-      child_fn(fd, child_ctx);
-      close(fd);
+      handler(file_descriptor);
+      close(file_descriptor);
       _exit(0);
     }
-    close(fd);
+    close(file_descriptor);
   }
-}
-
-struct plain_ctx {
-  void (*handler)(int);
-};
-
-static void plain_child_fn(int fd, void* ctx) {
-  ((struct plain_ctx*)ctx)->handler(fd);
-}
-
-bool server_listen(Server* server, void (*handler)(int file_descriptor)) {
-  struct sockaddr_in* addr4 = (struct sockaddr_in*)&server->address;
-  int port = (server->address.ss_family == AF_INET6)
-                 ? ntohs(((struct sockaddr_in6*)&server->address)->sin6_port)
-                 : ntohs(addr4->sin_port);
-  log_message(LOG_LEVEL_INFO, "Start Listening on Port: %d", port);
-  struct plain_ctx ctx = {handler};
-  accept_loop(server, plain_child_fn, &ctx, "Received Connection");
   return true;
 }
 
-void server_accept_loop(Server* server, void (*child_fn)(int, void*), void* child_ctx,
-                        const char* log_fmt) {
-  struct sockaddr_in* addr4 = (struct sockaddr_in*)&server->address;
-  int port = (server->address.ss_family == AF_INET6)
-                 ? ntohs(((struct sockaddr_in6*)&server->address)->sin6_port)
-                 : ntohs(addr4->sin_port);
-  log_message(LOG_LEVEL_INFO, "Start TLS Listening on Port: %d", port);
-  accept_loop(server, child_fn, child_ctx, log_fmt);
-}
-
-Client* client_create() {
-  Client* client = (Client*)malloc(sizeof(Client));
-  if (client == NULL) {
+Client *client_create() {
+  int file_descriptor = socket(AF_INET, SOCK_STREAM, 0);
+  if (file_descriptor < 0) {
+    perror("Could not create Socket!");
     return NULL;
   }
-  memset(&client->address, 0, sizeof(client->address));
-  client->address.ss_family = AF_UNSPEC;
+
+  Client *client = (Client *)malloc(sizeof(Client));
+  if (client == NULL) {
+    close(file_descriptor);
+    return NULL;
+  }
+  client->file_descriptor = file_descriptor;
+  client->address.sin_family = AF_INET;
   client->address_length = sizeof(client->address);
-  client->file_descriptor = -1;
   client->ssh_child_pid = -1;
-  client->ssl = NULL;
-  client->ssl_ctx = NULL;
   return client;
 }
 
-bool client_connect(Client* client, char* host, int port) {
-  struct addrinfo hints, *res, *rp;
-  memset(&hints, 0, sizeof(hints));
-  hints.ai_family = AF_UNSPEC;
-  hints.ai_socktype = SOCK_STREAM;
+bool client_connect(Client *client, char *host, int port) {
+  client->address.sin_port = htons(port);
 
-  char port_str[16];
-  snprintf(port_str, sizeof(port_str), "%d", port);
-
-  int gai_err = getaddrinfo(host, port_str, &hints, &res);
-  if (gai_err != 0) {
-    fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(gai_err));
+  if (inet_pton(AF_INET, host, &client->address.sin_addr) <= 0) {
+    perror("Could not convert host address!");
     return false;
   }
 
-  // Try IPv6 first, then IPv4
-  int fd = -1;
-  for (rp = res; rp != NULL; rp = rp->ai_next) {
-    fd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
-    if (fd < 0)
-      continue;
-    if (!set_socket_timeouts(fd)) {
-      close(fd);
-      fd = -1;
-      continue;
-    }
-    if (connect(fd, rp->ai_addr, rp->ai_addrlen) == 0)
-      break;
-    close(fd);
-    fd = -1;
-  }
-
-  if (fd < 0) {
+  if (connect(client->file_descriptor, (struct sockaddr *)&client->address,
+              client->address_length) < 0) {
     perror("Could not connect to Server!");
-    freeaddrinfo(res);
     return false;
   }
-
-  // Save the connected address
-  size_t copy_len =
-      rp->ai_addrlen < sizeof(client->address) ? rp->ai_addrlen : sizeof(client->address);
-  memcpy(&client->address, rp->ai_addr, copy_len);
-  client->address_length = (int)copy_len;
-  freeaddrinfo(res);
-
-  // Close old fd if any and set new one
-  if (client->file_descriptor >= 0)
-    close(client->file_descriptor);
-  client->file_descriptor = fd;
   return true;
 }
 
-void client_disconnect(Client* client) {
-  if (client->ssl) {
-    SSL_shutdown(client->ssl);
-    SSL_free(client->ssl);
-    client->ssl = NULL;
-    io_set_ssl(NULL);
-  }
-  if (client->file_descriptor >= 0) {
+void client_disconnect(Client *client) {
   close(client->file_descriptor);
-    client->file_descriptor = -1;
-  }
   if (client->ssh_child_pid > 0) {
     int status;
     waitpid(client->ssh_child_pid, &status, 0);
@@ -296,12 +132,8 @@ void client_disconnect(Client* client) {
   }
 }
 
-void client_delete(Client* client) {
+void client_delete(Client *client) {
   if (client == NULL)
     return;
-  if (client->ssl_ctx) {
-    SSL_CTX_free(client->ssl_ctx);
-    client->ssl_ctx = NULL;
-  }
   free(client);
 }

src/shared/transport_tcp.h

@@ -1,38 +1,29 @@
 #ifndef TRANSPORT_TCP_H
 #define TRANSPORT_TCP_H
 
-#include <netdb.h>
 #include <netinet/in.h>
 #include <stdbool.h>
-#include <sys/socket.h>
 #include <sys/types.h>
 
 typedef struct Server {
-  struct sockaddr_storage address;
+  struct sockaddr_in address;
   unsigned int address_length;
   int file_descriptor;
-  void* ssl_ctx;
 } Server;
 
 typedef struct Client {
-  struct sockaddr_storage address;
+  struct sockaddr_in address;
   unsigned int address_length;
   int file_descriptor;
   pid_t ssh_child_pid;
-  void* ssl;
-  void* ssl_ctx;
 } Client;
 
-Server* server_create(int port);
-bool server_listen(Server* server, void (*handler)(int file_descriptor));
-void server_accept_loop(Server* server, void (*child_fn)(int, void*), void* child_ctx,
-                        const char* log_fmt);
-void server_delete(Server** server);
-void server_request_shutdown(void);
-Client* client_create();
-bool client_connect(Client* client, char* host, int port);
-void client_disconnect(Client* client);
-void client_delete(Client* client);
-bool set_socket_timeouts(int fd);
+Server *server_create(int port);
+bool server_listen(Server *server, void (*handler)(int file_descriptor));
+void server_delete(Server **server);
+Client *client_create();
+bool client_connect(Client *client, char *host, int port);
+void client_disconnect(Client *client);
+void client_delete(Client *client);
 
 #endif

src/shared/transport_tls.c

@@ -1,182 +0,0 @@
-#include "transport_tls.h"
-#include "log.h"
-#include "protocol.h"
-#include "transport_tcp.h"
-#include <arpa/inet.h>
-#include <openssl/err.h>
-#include <openssl/ssl.h>
-#include <openssl/x509.h>
-#include <openssl/x509v3.h>
-#include <signal.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/socket.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-bool tls_global_init(void) {
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
-  SSL_library_init();
-  OpenSSL_add_all_algorithms();
-  SSL_load_error_strings();
-#endif
-  return true;
-}
-
-static void log_ssl_errors(void) {
-  unsigned long err;
-  char buf[256];
-  while ((err = ERR_get_error()) != 0) {
-    ERR_error_string_n(err, buf, sizeof(buf));
-    log_message(LOG_LEVEL_ERROR, "SSL error: %s", buf);
-  }
-}
-
-static SSL_CTX* create_ssl_ctx(bool is_server, const char* cert, const char* key,
-                               const char* ca_path) {
-  const SSL_METHOD* method = is_server ? TLS_server_method() : TLS_client_method();
-  SSL_CTX* ctx = SSL_CTX_new(method);
-  if (!ctx) {
-    log_message(LOG_LEVEL_ERROR, "Unable to create SSL context");
-    log_ssl_errors();
-    return NULL;
-  }
-
-  SSL_CTX_set_min_proto_version(ctx, TLS1_2_VERSION);
-
-  if (cert && key) {
-    if (SSL_CTX_use_certificate_file(ctx, cert, SSL_FILETYPE_PEM) <= 0) {
-      log_message(LOG_LEVEL_ERROR, "Failed to load certificate: %s", cert);
-      log_ssl_errors();
-      SSL_CTX_free(ctx);
-      return NULL;
-    }
-    if (SSL_CTX_use_PrivateKey_file(ctx, key, SSL_FILETYPE_PEM) <= 0) {
-      log_message(LOG_LEVEL_ERROR, "Failed to load private key: %s", key);
-      log_ssl_errors();
-      SSL_CTX_free(ctx);
-      return NULL;
-    }
-    if (!SSL_CTX_check_private_key(ctx)) {
-      log_message(LOG_LEVEL_ERROR, "Private key does not match certificate");
-      SSL_CTX_free(ctx);
-      return NULL;
-    }
-  }
-
-  if (ca_path) {
-    if (!SSL_CTX_load_verify_locations(ctx, ca_path, NULL)) {
-      log_message(LOG_LEVEL_ERROR, "Failed to load CA: %s", ca_path);
-      log_ssl_errors();
-      SSL_CTX_free(ctx);
-      return NULL;
-    }
-    SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);
-    SSL_CTX_set_verify_depth(ctx, 4);
-  } else {
-    if (!is_server) {
-      log_message(LOG_LEVEL_WARNING,
-                  "No CA path provided — TLS server certificate will not be verified");
-    }
-    SSL_CTX_set_verify(ctx, SSL_VERIFY_NONE, NULL);
-  }
-
-  return ctx;
-}
-
-static SSL* wrap_fd_with_ssl(int fd, SSL_CTX* ctx, bool is_server) {
-  SSL* ssl = SSL_new(ctx);
-  if (!ssl) {
-    log_message(LOG_LEVEL_ERROR, "Failed to create SSL object");
-    return NULL;
-  }
-  SSL_set_fd(ssl, fd);
-
-  int ret;
-  if (is_server)
-    ret = SSL_accept(ssl);
-  else
-    ret = SSL_connect(ssl);
-
-  if (ret <= 0) {
-    log_message(LOG_LEVEL_ERROR, "SSL %s failed", is_server ? "accept" : "connect");
-    log_ssl_errors();
-    SSL_free(ssl);
-    return NULL;
-  }
-
-  // In client mode, check verification result if peer verification was requested
-  if (!is_server) {
-    long verify_result = SSL_get_verify_result(ssl);
-    if (verify_result != X509_V_OK) {
-      log_message(LOG_LEVEL_ERROR, "TLS certificate verification failed: %ld", verify_result);
-      SSL_free(ssl);
-      return NULL;
-    }
-  }
-
-  return ssl;
-}
-
-bool server_create_tls(Server* server, const char* cert_path, const char* key_path,
-                       const char* ca_path) {
-  SSL_CTX* ctx = create_ssl_ctx(true, cert_path, key_path, ca_path);
-  if (!ctx)
-    return false;
-  server->ssl_ctx = ctx;
-  return true;
-}
-
-struct tls_child_ctx {
-  void (*handler)(int);
-  SSL_CTX* ssl_ctx;
-};
-
-static void tls_child_fn(int fd, void* arg) {
-  struct tls_child_ctx* ctx = (struct tls_child_ctx*)arg;
-  SSL* ssl = wrap_fd_with_ssl(fd, ctx->ssl_ctx, true);
-  if (!ssl)
-    return;
-  io_set_ssl(ssl);
-  ctx->handler(fd);
-  SSL_shutdown(ssl);
-  SSL_free(ssl);
-  io_set_ssl(NULL);
-}
-
-bool server_listen_tls(Server* server, void (*handler)(int file_descriptor)) {
-  struct tls_child_ctx ctx = {handler, (SSL_CTX*)server->ssl_ctx};
-  server_accept_loop(server, tls_child_fn, &ctx, "Received TLS Connection");
-  return true;
-}
-
-bool client_connect_tls(Client* client, char* host, int port, const char* cert_path,
-                        const char* key_path, const char* ca_path) {
-  // Use the common TCP connection logic (with IPv6 support)
-  if (!client_connect(client, host, port))
-    return false;
-
-  SSL_CTX* ctx = create_ssl_ctx(false, cert_path, key_path, ca_path);
-  if (!ctx)
-    return false;
-  client->ssl_ctx = ctx;
-
-  SSL* ssl = wrap_fd_with_ssl(client->file_descriptor, ctx, false);
-  if (!ssl) {
-    SSL_CTX_free(ctx);
-    client->ssl_ctx = NULL;
-    return false;
-  }
-
-  // Set SNI and enable hostname verification
-  SSL_set_tlsext_host_name(ssl, host);
-  X509_VERIFY_PARAM* param = SSL_get0_param(ssl);
-  if (param) {
-    X509_VERIFY_PARAM_set1_host(param, host, 0);
-  }
-
-  client->ssl = ssl;
-  io_set_ssl(ssl);
-  return true;
-}

src/shared/transport_tls.h

@@ -1,15 +0,0 @@
-#ifndef TRANSPORT_TLS_H
-#define TRANSPORT_TLS_H
-
-#include "transport_tcp.h"
-#include <stdbool.h>
-
-bool tls_global_init(void);
-
-bool server_create_tls(Server* server, const char* cert_path, const char* key_path,
-                       const char* ca_path);
-bool server_listen_tls(Server* server, void (*handler)(int file_descriptor));
-bool client_connect_tls(Client* client, char* host, int port, const char* cert_path,
-                        const char* key_path, const char* ca_path);
-
-#endif

src/shared/utils.c

@@ -2,49 +2,33 @@
 #include "array_list.h"
 #include "libgen.h"
 #include <dirent.h>
-#include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
 #include <unistd.h>
 
-bool mkdir_r(const char* path) {
-  size_t path_len = strlen(path);
-  char* path_duplicate = malloc(path_len + 1);
-  if (!path_duplicate)
-    return false;
-  memcpy(path_duplicate, path, path_len + 1);
-  /* Buffer for building subpaths: path_len + 1 for leading '/' + 1 for null */
-  size_t buf_size = path_len + 2;
-  char* path_current = (char*)malloc(buf_size);
-  if (!path_current) {
-    free(path_duplicate);
-    return false;
-  }
-  size_t pos = 0;
+bool mkdir_r(char *path) {
+  char *path_duplicate = malloc(strlen(path) + 1);
+  if (!path_duplicate) return false;
+  strcpy(path_duplicate, path);
+  char *path_current = (char *)malloc((strlen(path) + 2) * sizeof(char));
+  if (!path_current) { free(path_duplicate); return false; }
+  char *path_current_position = path_current;
   if (path[0] == '/') {
-    path_current[0] = '/';
-    path_current[1] = '\0';
-    pos = 1;
+    strcpy(path_current, "/");
+    path_current_position += 1;
   } else {
     path_current[0] = '\0';
   }
-  const char* delimiter = "/";
-  char* saveptr;
-  const char* part = strtok_r(path_duplicate, delimiter, &saveptr);
+  const char *delimiter = "/";
+  char *part = strtok(path_duplicate, delimiter);
   bool ok = true;
   while (part != NULL) {
-    size_t part_len = strlen(part);
-    if (pos + part_len + 1 >= buf_size) {
-      ok = false;
-      break;
-    }
-    memcpy(path_current + pos, part, part_len);
-    pos += part_len;
-    path_current[pos] = '/';
-    pos++;
-    path_current[pos] = '\0';
+    strcpy(path_current_position, part);
+    path_current_position += strlen(part) * sizeof(char);
+    strcpy(path_current_position, "/");
+    path_current_position += sizeof(char);
     struct stat st;
     if (stat(path_current, &st) != 0) {
       if (mkdir(path_current, 0755) != 0) {
@@ -53,40 +37,24 @@ bool mkdir_r(const char* path) {
         break;
       }
     }
-    part = strtok_r(NULL, delimiter, &saveptr);
+    part = strtok(NULL, delimiter);
   }
   free(path_duplicate);
   free(path_current);
   return ok;
 }
-char* str_dup(const char* string) {
+
+char *str_dup(const char *string) {
   if (string == NULL)
     return NULL;
-  char* new_string = (char*)malloc(strlen(string) + 1);
-  memcpy(new_string, string, strlen(string) + 1);
+  char *new_string = (char *)malloc(strlen(string) + 1);
+  strcpy(new_string, string);
   return new_string;
 }
 
-bool glob_match(const char* pattern, const char* str) {
+bool glob_match(const char *pattern, const char *str) {
   while (*pattern) {
     if (*pattern == '*') {
-      /* Check for double-star (globstar) pattern */
-      if (*(pattern + 1) == '*') {
-        pattern += 2;
-        /* Trailing double-star matches everything */
-        if (*pattern == '\0')
-          return true;
-        /* double-star slash: match at any depth */
-        if (*pattern == '/')
-          pattern++;
-        while (*str) {
-          if (glob_match(pattern, str))
-            return true;
-          str++;
-        }
-        return glob_match(pattern, str);
-      }
-      /* Single * — does not cross / boundaries */
       pattern++;
       while (*str && *str != '/') {
         if (glob_match(pattern, str))
@@ -100,17 +68,8 @@ bool glob_match(const char* pattern, const char* str) {
       pattern++;
       str++;
     } else {
-      if (*pattern != *str) {
-        /* If pattern has a '/' followed by '**', allow zero path components */
-        if (*pattern == '/' && *(pattern + 1) == '*' && *(pattern + 2) == '*') {
-          /* Skip over slash-double-star and try to match rest against current str */
-          const char* rest = pattern + 3;
-          if (*rest == '/')
-            rest++;
-          return glob_match(rest, str);
-        }
+      if (*pattern != *str)
         return false;
-      }
       pattern++;
       str++;
     }
@@ -118,28 +77,17 @@ bool glob_match(const char* pattern, const char* str) {
   return *str == '\0';
 }
 
-static bool is_dir_in_manifest(const char* rel_path, ArrayList* manifest) {
-  size_t len = strlen(rel_path);
-  for (int i = 0; i < manifest->size; i++) {
-    const char* entry = (const char*)manifest->items[i];
-    // Check if entry starts with rel_path + '/' or matches exactly
-    if (strncmp(entry, rel_path, len) == 0 && (entry[len] == '/' || entry[len] == '\0'))
-      return true;
-  }
-  return false;
-}
-
-static void delete_extras_walk(const char* abs_path, const char* rel_path, ArrayList* manifest) {
-  DIR* dir = opendir(abs_path);
+static void delete_extras_walk(const char *abs_path, const char *rel_path,
+                               ArrayList *manifest) {
+  DIR *dir = opendir(abs_path);
   if (!dir)
     return;
-  bool all_removed = true;
-  struct dirent* entry;
+  struct dirent *entry;
   while ((entry = readdir(dir)) != NULL) {
     if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
       continue;
-    char* child_abs = path_cat((char*)abs_path, entry->d_name);
-    char* child_rel = path_cat((char*)rel_path, entry->d_name);
+    char *child_abs = path_cat((char *)abs_path, entry->d_name);
+    char *child_rel = path_cat((char *)rel_path, entry->d_name);
     struct stat st;
     if (stat(child_abs, &st) != 0) {
       free(child_abs);
@@ -148,16 +96,11 @@ static void delete_extras_walk(const char* abs_path, const char* rel_path, Array
     }
     if (S_ISDIR(st.st_mode)) {
       delete_extras_walk(child_abs, child_rel, manifest);
-      // After recursion, try to remove the subdirectory if it's now empty.
-      // Ignore ENOENT: the recursive call may have already removed it.
-      if (rmdir(child_abs) != 0 && errno != ENOENT) {
-        all_removed = false;
-      }
     } else {
       // Check if relative path is in manifest
       bool found = false;
       for (int i = 0; i < manifest->size; i++) {
-        if (strcmp((char*)manifest->items[i], child_rel) == 0) {
+        if (strcmp((char *)manifest->items[i], child_rel) == 0) {
           found = true;
           break;
         }
@@ -165,42 +108,35 @@ static void delete_extras_walk(const char* abs_path, const char* rel_path, Array
       if (!found) {
         unlink(child_abs);
         fprintf(stderr, "  Deleted: %s\n", child_rel);
-      } else {
-        all_removed = false;
       }
     }
     free(child_abs);
     free(child_rel);
   }
   closedir(dir);
-  // Only remove the directory itself if it is not in the manifest
-  // and contained no kept entries.
-  if (all_removed && rel_path[0] != '\0' && !is_dir_in_manifest(rel_path, manifest)) {
   rmdir(abs_path);
-  }
 }
 
-void delete_extras(const char* dest_root, ArrayList* manifest) {
+void delete_extras(const char *dest_root, ArrayList *manifest) {
   delete_extras_walk(dest_root, "", manifest);
 }
 
-char* path_cat(const char* path1, char* path2) {
+char *path_cat(char *path1, char *path2) {
   if (path1 == NULL || *path1 == '\0')
     return str_dup(path2);
   if (path2 == NULL || *path2 == '\0')
     return str_dup(path1);
   int path1_len = strlen(path1);
   int path2_len = strlen(path2);
-  char* path2_pointer = path2;
+  char *path2_pointer = path2;
   if (path1[path1_len - 1] == '/')
     path1_len -= 1;
   if (path2[0] == '/') {
     path2_pointer += 1;
     path2_len -= 1;
   }
-  char* new_path = malloc(path1_len + path2_len + 2);
-  if (new_path == NULL)
-    return NULL;
+  char *new_path = malloc(path1_len + path2_len + 2);
+  if (new_path == NULL) return NULL;
   memcpy(new_path, path1, path1_len);
   new_path[path1_len] = '/';
   memcpy(new_path + path1_len + 1, path2_pointer, path2_len);

src/shared/utils.h

@@ -4,10 +4,10 @@
 #include "array_list.h"
 #include <stdbool.h>
 
-bool mkdir_r(const char* path);
-char* str_dup(const char* string);
-char* path_cat(const char* path1, char* path2);
-bool glob_match(const char* pattern, const char* str);
-void delete_extras(const char* dest_root, ArrayList* manifest);
+bool mkdir_r(char *path);
+char *str_dup(const char *string);
+char *path_cat(char *path1, char *path2);
+bool glob_match(const char *pattern, const char *str);
+void delete_extras(const char *dest_root, ArrayList *manifest);
 
 #endif

test.py

@@ -0,0 +1,700 @@
+import argparse
+import filecmp
+import os
+import random
+import re
+import shutil
+import subprocess
+import sys
+import tempfile
+import time
+import socket
+
+TEST_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "test_data")
+DEFAULT_SOURCE_DIR = os.path.join(TEST_DIR, "source")
+DEFAULT_DEST_DIR = os.path.join(TEST_DIR, "dest")
+
+SERVER_CMD = ["./build/server"]
+BASE_CLIENT_CMD = ["./build/client"]
+
+DISK_DEVICE = "/dev/nvme0n1p5"
+READ_BPS_MAX = "15M"
+WRITE_BPS_MAX = "10M"
+NETWORK_INTERFACE = "lo"
+
+NETWORK_PROFILES = {
+    "Unlimited": {},
+    "LAN": {
+        "rate": "1000mbit",
+        "delay": "20ms",
+        "jitter": "1ms",
+        "loss": "0.1%",
+    },
+    "WAN": {
+        "rate": "100mbit",
+        "delay": "50ms",
+        "jitter": "10ms",
+        "loss": "1%",
+    },
+}
+
+CLIENT_CMD_PREFIX = [
+    "sudo",
+    "systemd-run",
+    "--scope",
+    "-p",
+    f"IOReadBandwidthMax={DISK_DEVICE} {READ_BPS_MAX}",
+    "-p",
+    f"IOWriteBandwidthMax={DISK_DEVICE} {WRITE_BPS_MAX}",
+]
+
+BASE_CLIENT_FLAGS = ["--save-to-disk"]
+
+TEST_CASES = [
+    {"name": "Standard", "flags": []},
+    {"name": "Posix Args (no flags)", "flags": [], "posix": True},
+    {"name": "Standard (no metadata)", "flags": [], "use_metadata": False},
+    {"name": "Multithreading (-m)", "flags": ["-m"]},
+    {"name": "Compression (-c)", "flags": ["-c"]},
+    {"name": "Chunk Serialization (-s)", "flags": ["-s"]},
+    {"name": "Compression + Chunk Serialization (-c -s)", "flags": ["-c", "-s"]},
+    {"name": "Multithreading + Compression (-m -c)", "flags": ["-m", "-c"]},
+    {"name": "Multithreading + Chunk Serialization (-m -s)", "flags": ["-m", "-s"]},
+    {
+        "name": "Multithreading + Compression + Chunk Serialization (-m -c -s)",
+        "flags": ["-m", "-c", "-s"],
+    },
+    {"name": "Sendfile (-f)", "flags": ["-f"]},
+    {"name": "Sendfile + Multithreading (-f -m)", "flags": ["-f", "-m"]},
+]
+
+SSH_CASES = [
+    {"name": "SSH (localhost)", "flags": []},
+    {"name": "SSH Multithreading (-m)", "flags": ["-m"]},
+    {"name": "SSH Compression (-c)", "flags": ["-c"]},
+    {"name": "SSH Chunk Serialization (-s)", "flags": ["-s"]},
+    {"name": "SSH Compression + Chunk Serialization (-c -s)", "flags": ["-c", "-s"]},
+    {"name": "SSH Multithreading + Compression (-m -c)", "flags": ["-m", "-c"]},
+    {"name": "SSH Multithreading + Chunk Serialization (-m -s)", "flags": ["-m", "-s"]},
+    {"name": "SSH Multithreading + Compression + Chunk Serialization (-m -c -s)", "flags": ["-m", "-c", "-s"]},
+]
+
+RSYNC_CASES = [
+    {"name": "rsync (archive)", "args": ["-aH"]},
+    {"name": "rsync (archive + compress)", "args": ["-aHz"]},
+]
+
+
+def netem_apply(profile):
+    params = NETWORK_PROFILES[profile]
+    if not params:
+        netem_reset()
+        return
+    netem_reset()
+    cmd = ["sudo", "tc", "qdisc", "add", "dev", NETWORK_INTERFACE, "root", "netem"]
+    cmd += ["rate", params["rate"]]
+    cmd += ["delay", params["delay"], params["jitter"]]
+    cmd += ["loss", params["loss"]]
+    subprocess.run(cmd, check=True, capture_output=True)
+
+
+def netem_reset():
+    subprocess.run(
+        f"sudo tc qdisc del dev {NETWORK_INTERFACE} root".split(),
+        capture_output=True,
+    )
+
+
+def wait_proc(proc, timeout=5):
+    try:
+        proc.wait(timeout=timeout)
+    except subprocess.TimeoutExpired:
+        proc.kill()
+        proc.wait()
+
+
+def find_free_port():
+    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
+        s.bind(('', 0))
+        return s.getsockname()[1]
+
+
+def generate_test_files(source_dir):
+    if os.path.exists(source_dir):
+        shutil.rmtree(source_dir)
+    os.makedirs(source_dir)
+
+    target_total = 25 * 1024 * 1024
+    written = 0
+
+    files = {
+        "small.txt": b"hello world\n",
+        "medium.txt": b"the quick brown fox jumps over the lazy dog\n" * 5000,
+        "binary.bin": bytes(range(256)) * 1000,
+        "nested/subdir/deep.txt": b"deeply nested file\n",
+        "nested/another.txt": b"another nested file\n" * 50,
+    }
+    for rel_path, content in files.items():
+        full_path = os.path.join(source_dir, rel_path)
+        os.makedirs(os.path.dirname(full_path), exist_ok=True)
+        with open(full_path, "wb") as f:
+            f.write(content)
+        written += len(content)
+
+    os.makedirs(os.path.join(source_dir, "bulk"), exist_ok=True)
+    i = 0
+    while written < target_total:
+        chunk_size = min(5 * 1024 * 1024, target_total - written)
+        with open(os.path.join(source_dir, f"bulk/file_{i}.dat"), "wb") as f:
+            f.write(random.randbytes(chunk_size))
+        written += chunk_size
+        i += 1
+
+    total_mb = written / (1024 * 1024)
+    small_bytes = sum(len(c) for c in files.values())
+    print(f"  Generated {total_mb:.1f} MB of test data in {source_dir} "
+          f"({(written - small_bytes)/(1024*1024):.1f} MB random, "
+          f"{small_bytes} B structured)")
+    return written
+
+
+def verify_transfer(source_dir, received_dir):
+    source_dir = os.path.abspath(source_dir)
+    received_dir = os.path.abspath(received_dir)
+    if not os.path.exists(received_dir):
+        return [], ["no received files found"]
+    mismatches, missing = [], []
+    for root, dirs, files in os.walk(source_dir):
+        for f in files:
+            src_path = os.path.join(root, f)
+            rel = os.path.relpath(src_path, source_dir)
+            dst_path = os.path.join(received_dir, rel)
+            if not os.path.exists(dst_path):
+                missing.append(rel)
+            elif not filecmp.cmp(src_path, dst_path, shallow=False):
+                mismatches.append(rel)
+    return mismatches, missing
+
+
+def start_rsync_daemon(source_dir):
+    port = find_free_port()
+    conf = os.path.join(tempfile.gettempdir(), f"rsyncd-{port}.conf")
+    with open(conf, "w") as f:
+        f.write(f"port = {port}\nread only = yes\n\n[source]\n    path = {source_dir}\n")
+    daemon = subprocess.Popen(
+        ["rsync", "--daemon", "--no-detach", f"--config={conf}"],
+        stdout=subprocess.DEVNULL, stderr=None,
+    )
+    for _ in range(50):
+        time.sleep(0.1)
+        if daemon.poll() is not None:
+            raise RuntimeError(f"rsync daemon exited (rc={daemon.returncode})")
+        try:
+            with socket.create_connection(("127.0.0.1", port), timeout=0.3):
+                break
+        except (ConnectionRefusedError, OSError):
+            continue
+    else:
+        raise RuntimeError("rsync daemon did not start")
+    return port, conf, daemon
+
+
+def run_single_test(cmd, name, source_dir, dest_dir, *, source_prefix=None, no_server=False, expected_missing=None):
+    if os.path.exists(dest_dir):
+        shutil.rmtree(dest_dir)
+    if no_server:
+        server = None
+    else:
+        server = subprocess.Popen(SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None)
+        time.sleep(0.5)
+    try:
+        start = time.monotonic()
+        result = subprocess.run(cmd, text=True, capture_output=True)
+        duration = time.monotonic() - start
+    finally:
+        if server:
+            wait_proc(server)
+
+    mismatches, missing = [], []
+    if result.returncode == 0:
+        received = os.path.join(dest_dir, source_prefix if source_prefix is not None
+                                else os.path.abspath(source_dir).lstrip(os.sep))
+        mismatches, missing = verify_transfer(source_dir, received)
+        if expected_missing:
+            missing = [m for m in missing if m not in expected_missing]
+
+    first_line = lambda s: (s or "").strip().split("\n")[0]
+    entry = {
+        "name": name,
+        "time": f"{duration:.4f}s" if result.returncode == 0 else "N/A",
+    }
+    if result.returncode == 0 and not mismatches and not missing:
+        entry["status"] = "Success"
+        entry["error"] = ""
+    else:
+        entry["status"] = "Failed"
+        errors = []
+        if result.returncode != 0:
+            errors.append(f"Exit code {result.returncode}: {first_line(result.stderr) or first_line(result.stdout) or 'No output'[:80]}")
+        if missing:
+            errors.append(f"Missing ({len(missing)}): {', '.join(missing[:5])}")
+        if mismatches:
+            errors.append(f"Mismatch ({len(mismatches)}): {', '.join(mismatches[:3])}")
+        entry["error"] = " | ".join(errors)
+    return entry
+
+
+def print_profile_header(profile_name):
+    params = NETWORK_PROFILES[profile_name]
+    print(f"\n{'=' * 60}\nProfile: {profile_name}\n{'=' * 60}")
+    if params:
+        print(f"  Network: rate={params['rate']}, delay={params['delay']} ±{params['jitter']}, loss={params['loss']}")
+        print(f"  Disk I/O: Reads <= {READ_BPS_MAX}, Writes <= {WRITE_BPS_MAX}")
+    else:
+        print("  No limits applied")
+
+
+def run_profile(profile_name, source_dir, dest_dir):
+    print_profile_header(profile_name)
+    is_limited = profile_name != "Unlimited"
+    client_prefix = CLIENT_CMD_PREFIX if is_limited else []
+
+    try:
+        if is_limited:
+            netem_apply(profile_name)
+        else:
+            netem_reset()
+
+        results = []
+        for case in TEST_CASES:
+            flags = BASE_CLIENT_FLAGS + (["-M"] if case.get("use_metadata", True) else []) + case["flags"]
+            if case.get("posix"):
+                cmd = client_prefix + BASE_CLIENT_CMD + [source_dir, dest_dir] + flags
+            else:
+                cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags
+            print(f"\n  --- {case['name']} ---\n    Running: {' '.join(cmd)}")
+            try:
+                r = run_single_test(cmd, case["name"], source_dir, dest_dir)
+                r["suite"] = profile_name
+                results.append(r)
+            except Exception as e:
+                results.append({"name": case["name"], "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        if SSH_AVAILABLE:
+            for case in SSH_CASES:
+                flags = BASE_CLIENT_FLAGS + (["-M"] if case.get("use_metadata", True) else []) + case["flags"]
+                ssh_dest = f"localhost:{dest_dir}_ssh"
+                cmd = BASE_CLIENT_CMD + [source_dir, ssh_dest] + flags
+                print(f"\n  --- {case['name']} ---\n    Running: {' '.join(cmd)}")
+                try:
+                    r = run_single_test(cmd, case["name"], source_dir, f"{dest_dir}_ssh", no_server=True)
+                    r["suite"] = profile_name
+                    results.append(r)
+                except Exception as e:
+                    results.append({"name": case["name"], "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+    
+        port, conf, daemon = start_rsync_daemon(source_dir)
+        try:
+            for case in RSYNC_CASES:
+                cmd = client_prefix + ["rsync"] + case["args"] + [f"rsync://localhost:{port}/source/", f"{dest_dir}/"]
+                print(f"\n  --- {case['name']} ---\n    Running: {' '.join(cmd)}")
+                try:
+                    r = run_single_test(cmd, case["name"], source_dir, dest_dir, source_prefix="")
+                    r["suite"] = profile_name
+                except subprocess.TimeoutExpired:
+                    r = {"name": case["name"], "suite": profile_name, "status": "Timeout", "time": "N/A", "error": "Exceeded 120s"}
+                except Exception as e:
+                    r = {"name": case["name"], "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)}
+                else:
+                    if r["status"] != "Success" and client_prefix:
+                        tmp = tempfile.mkdtemp()
+                        try:
+                            plain = subprocess.run(["rsync", "-aH", f"rsync://localhost:{port}/source/", f"{tmp}/"], capture_output=True, text=True, timeout=30)
+                            if plain.returncode != 0:
+                                errs = [l for l in (plain.stderr or "").split("\n") if l.strip()]
+                                if errs:
+                                    r["error"] += f" | raw: {errs[-1][:150]}"
+                        finally:
+                            shutil.rmtree(tmp, ignore_errors=True)
+                results.append(r)
+        finally:
+            wait_proc(daemon)
+            try:
+                os.unlink(conf)
+            except Exception:
+                pass
+
+        # Feature-specific tests for rsync-compatible flags
+        print("\n  " + "─" * 56 + "\n  Feature Tests\n  " + "─" * 56)
+
+        # Dry run (-n) — no server needed
+        print("\n  --- Dry run (-n) ---")
+        flags = BASE_CLIENT_FLAGS + ["-n"]
+        cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags
+        print(f"    Running: {' '.join(cmd)}")
+        try:
+            start = time.monotonic()
+            result = subprocess.run(cmd, text=True, capture_output=True)
+            duration = time.monotonic() - start
+            r = {"name": "Dry run (-n)", "suite": profile_name}
+            if result.returncode == 0 and "Dry run:" in result.stdout:
+                r["status"] = "Success"
+                r["time"] = f"{duration:.4f}s"
+                r["error"] = ""
+            else:
+                r["status"] = "Failed"
+                r["time"] = "N/A"
+                r["error"] = f"Exit {result.returncode}: {(result.stderr or result.stdout)[:100]}"
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Dry run (-n)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Archive mode (-a)
+        feature_flags = BASE_CLIENT_FLAGS + ["-a"]
+        cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags
+        print(f"\n  --- Archive mode (-a) ---\n    Running: {' '.join(cmd)}")
+        try:
+            r = run_single_test(cmd, "Archive mode (-a)", source_dir, dest_dir)
+            r["suite"] = profile_name
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Archive mode (-a)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Exclude (--exclude small.txt)
+        feature_flags = BASE_CLIENT_FLAGS + ["--exclude", "small.txt"]
+        cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags
+        print(f"\n  --- Exclude (--exclude small.txt) ---\n    Running: {' '.join(cmd)}")
+        try:
+            r = run_single_test(cmd, "Exclude (--exclude small.txt)", source_dir, dest_dir,
+                                expected_missing=["small.txt"])
+            r["suite"] = profile_name
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Exclude (--exclude small.txt)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Progress (--progress)
+        feature_flags = BASE_CLIENT_FLAGS + ["--progress"]
+        cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags
+        print(f"\n  --- Progress (--progress) ---\n    Running: {' '.join(cmd)}")
+        try:
+            r = run_single_test(cmd, "Progress (--progress)", source_dir, dest_dir)
+            r["suite"] = profile_name
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Progress (--progress)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Incremental sync (--incremental) — first sync, then second sync should skip all
+        print(f"\n  --- Incremental (--incremental) ---")
+        try:
+            flags = BASE_CLIENT_FLAGS + ["-M"]
+            srv = subprocess.Popen(SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None)
+            time.sleep(0.5)
+            first_cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags
+            r1 = subprocess.run(first_cmd, text=True, capture_output=True)
+            wait_proc(srv)
+            if r1.returncode != 0:
+                raise RuntimeError(f"First sync failed: {r1.stderr[:100]}")
+            srv2 = subprocess.Popen(SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None)
+            time.sleep(0.5)
+            second_cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags + ["--incremental"]
+            start = time.monotonic()
+            r2 = subprocess.run(second_cmd, text=True, capture_output=True, timeout=30)
+            duration = time.monotonic() - start
+            wait_proc(srv2)
+            r = {"name": "Incremental (--incremental)", "suite": profile_name,
+                 "status": "Success" if r2.returncode == 0 else "Failed",
+                 "time": f"{duration:.4f}s" if r2.returncode == 0 else "N/A",
+                 "error": "" if r2.returncode == 0 else f"Exit {r2.returncode}: {(r2.stderr or r2.stdout)[:60]}"}
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Incremental (--incremental)", "suite": profile_name,
+                            "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Chunk size (--chunk-size 5242880)
+        feature_flags = BASE_CLIENT_FLAGS + ["--chunk-size", "5242880"]
+        cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + feature_flags
+        print(f"\n  --- Chunk size (--chunk-size 5242880) ---\n    Running: {' '.join(cmd)}")
+        try:
+            r = run_single_test(cmd, "Chunk size (--chunk-size 5242880)", source_dir, dest_dir)
+            r["suite"] = profile_name
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Chunk size (--chunk-size 5242880)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # Delete (--delete) — pre-populate dest, add extra files, then sync with --delete
+        # Note: server handles one client per launch, so we restart between syncs
+        print(f"\n  --- Delete (--delete) ---")
+        try:
+            flags = BASE_CLIENT_FLAGS + ["-M"]
+            # First sync (no delete) to populate dest
+            s1 = subprocess.Popen(SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None)
+            time.sleep(0.5)
+            first_cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags
+            r1 = subprocess.run(first_cmd, text=True, capture_output=True)
+            wait_proc(s1)
+            if r1.returncode != 0:
+                raise RuntimeError(f"First sync failed: {r1.stderr[:100]}")
+            # Add extra files to received dir
+            received = os.path.join(dest_dir, os.path.abspath(source_dir).lstrip(os.sep))
+            extra_path = os.path.join(received, "extra_file.txt")
+            with open(extra_path, "w") as f:
+                f.write("should be deleted")
+            extra_dir = os.path.join(received, "extra_dir")
+            os.makedirs(extra_dir, exist_ok=True)
+            with open(os.path.join(extra_dir, "nested.txt"), "w") as f:
+                f.write("nested extra")
+            # Second sync with --delete (fresh server)
+            s2 = subprocess.Popen(SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None)
+            time.sleep(0.5)
+            second_cmd = client_prefix + BASE_CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir] + flags + ["--delete"]
+            start = time.monotonic()
+            r2 = subprocess.run(second_cmd, text=True, capture_output=True)
+            duration = time.monotonic() - start
+            wait_proc(s2)
+            r = {"name": "Delete (--delete)", "suite": profile_name}
+            if r2.returncode == 0 and not os.path.exists(extra_path) and not os.path.exists(extra_dir):
+                mismatches, missing = verify_transfer(source_dir, received)
+                if not mismatches and not missing:
+                    r["status"] = "Success"
+                    r["time"] = f"{duration:.4f}s"
+                    r["error"] = ""
+                else:
+                    r["status"] = "Failed"
+                    r["time"] = "N/A"
+                    r["error"] = f"post-delete verify: mismatches={len(mismatches)}, missing={len(missing)}"
+            else:
+                r["status"] = "Failed"
+                r["time"] = "N/A"
+                errs = []
+                if r2.returncode != 0:
+                    errs.append(f"Exit {r2.returncode}: {(r2.stderr or r2.stdout)[:60]}")
+                if os.path.exists(extra_path):
+                    errs.append("extra_file.txt remains")
+                if os.path.exists(extra_dir):
+                    errs.append("extra_dir remains")
+                r["error"] = " | ".join(errs)
+            results.append(r)
+        except Exception as e:
+            results.append({"name": "Delete (--delete)", "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+        # SSH feature tests
+        if SSH_AVAILABLE:
+            ssh_dest = f"localhost:{dest_dir}_ssh"
+            ssh_feature_cases = [
+                {"name": "SSH Archive (-a)", "flags": ["-a"]},
+                {"name": "SSH Exclude (--exclude small.txt)", "flags": ["--exclude", "small.txt"], "expected_missing": ["small.txt"]},
+            ]
+            for case in ssh_feature_cases:
+                flags = BASE_CLIENT_FLAGS + case["flags"]
+                cmd = BASE_CLIENT_CMD + [source_dir, ssh_dest] + flags
+                print(f"\n  --- {case['name']} ---\n    Running: {' '.join(cmd)}")
+                try:
+                    r = run_single_test(cmd, case["name"], source_dir, f"{dest_dir}_ssh",
+                                        no_server=True,
+                                        expected_missing=case.get("expected_missing"))
+                    r["suite"] = profile_name
+                    results.append(r)
+                except Exception as e:
+                    results.append({"name": case["name"], "suite": profile_name, "status": "Error", "time": "N/A", "error": str(e)})
+
+    except (subprocess.CalledProcessError, RuntimeError) as e:
+        print(f"  Error: {e}")
+        results = []
+    finally:
+        if is_limited:
+            try:
+                netem_reset()
+            except Exception:
+                pass
+
+    return results
+
+
+def print_metrics(profile_name, results, total_bytes):
+    params = NETWORK_PROFILES.get(profile_name)
+    if not params or "rate" not in params:
+        return
+
+    client_times, rsync_times = [], {}
+    for r in results:
+        if r["status"] != "Success" or r["time"] == "N/A":
+            continue
+        t = float(r["time"].rstrip("s"))
+        if r["name"].startswith("rsync"):
+            rsync_times[r["name"]] = t
+        elif "Dry run" not in r["name"]:
+            client_times.append((t, r["name"]))
+    if not client_times or len(rsync_times) < 2:
+        return
+
+    m = re.match(r'(\d+)\s*(mbit|gbit|kbit|bit)', params["rate"])
+    rate_val = int(m.group(1)) * {'mbit': 1_000_000, 'gbit': 1_000_000_000, 'kbit': 1000, 'bit': 1}[m.group(2)] / 8 if m else None
+
+    best_time, best_name = min(client_times, key=lambda x: x[0])
+    theoretical_max = total_bytes / rate_val if rate_val else None
+
+    print(f"\n  {'─' * 90}\n  Profile: {profile_name}\n  {'─' * 90}")
+    print(f"  Total data size:               {total_bytes / (1024*1024):.1f} MB")
+    if rate_val:
+        print(f"  Network rate:                  {params['rate']} ({format_throughput(rate_val)})")
+    print(f"  Best client configuration:     {best_name}")
+    print(f"  Best client time:              {best_time:.4f}s")
+    if theoretical_max:
+        print(f"  Theoretical max (uncompressed): {theoretical_max:.4f}s")
+        print(f"  Speedup vs theoretical max:    {theoretical_max / best_time:.2f}x")
+    if (a := rsync_times.get("rsync (archive)")):
+        print(f"  Speedup vs rsync (archive):    {a / best_time:.2f}x")
+    if (c := rsync_times.get("rsync (archive + compress)")):
+        print(f"  Speedup vs rsync (compress):   {c / best_time:.2f}x")
+
+
+def format_throughput(bps):
+    for unit, threshold in [("GB/s", 1_000_000_000), ("MB/s", 1_000_000), ("KB/s", 1000)]:
+        if bps >= threshold:
+            return f"{bps/threshold:.1f} {unit}"
+    return f"{bps:.0f} B/s"
+
+
+SSH_AVAILABLE = False
+
+def check_ssh_localhost():
+    global SSH_AVAILABLE
+    build_dir = os.path.abspath("build")
+    server_path = os.path.join(build_dir, "server")
+
+    r = subprocess.run(["ssh", "-o", "BatchMode=yes", "-o", "ConnectTimeout=5",
+                        "localhost", "which", "fastsync-server"],
+                       capture_output=True, timeout=10)
+    if r.returncode == 0:
+        SSH_AVAILABLE = True
+        return
+
+    SSH_AVAILABLE = False
+    # Try each PATH dir: create symlink, then verify with which
+    r = subprocess.run(
+        ["ssh", "-o", "BatchMode=yes", "localhost",
+         'echo "$PATH"'],
+        capture_output=True, timeout=10, text=True)
+    if r.returncode != 0:
+        return
+    for d in r.stdout.strip().split(":"):
+        d = d.strip()
+        if not d:
+            continue
+        if "wrappers" in d:
+            continue
+        test = subprocess.run(
+            ["ssh", "-o", "BatchMode=yes", "localhost",
+             f'test -w "{d}" && ln -sf {server_path} "{d}/fastsync-server" && which fastsync-server'],
+            capture_output=True, timeout=10)
+        if test.returncode == 0:
+            SSH_AVAILABLE = True
+            return
+
+
+def preflight_checks():
+    global SSH_AVAILABLE
+    errors = []
+    print("Pre-flight checks:")
+    print("  [1] --help flag...", end=" ")
+    r = subprocess.run(BASE_CLIENT_CMD + ["--help"], capture_output=True, text=True)
+    if r.returncode == 0 and "Usage:" in r.stdout and "SSH transport" in r.stdout:
+        print("OK")
+    else:
+        print("FAIL")
+        errors.append("--help failed")
+
+    print("  [2] Remote SSH dest detection...", end=" ")
+    r = subprocess.run(BASE_CLIENT_CMD + ["/x", "somehost:/y"], capture_output=True, text=True, timeout=5)
+    if r.returncode != 0 and ("ssh" in r.stderr or "Could not receive" in r.stderr or "could not launch" in r.stderr or "Error" in r.stderr):
+        print("OK (detected as SSH)")
+    else:
+        print("FAIL (not detected as SSH dest)")
+        errors.append("SSH detection failed")
+
+    print("  [3] Server --stdio flag...", end=" ")
+    try:
+        r = subprocess.run(["./build/server", "--stdio"], capture_output=True, text=True, timeout=3)
+        if r.returncode != 0 and ("receiving" in r.stderr or "receiving" in r.stdout or "Receiving" in r.stderr):
+            print("OK (started in stdio mode)")
+        else:
+            print("WARN (stdio exited: rc=%d)" % r.returncode)
+    except subprocess.TimeoutExpired:
+        print("OK (waiting for stdin)")
+
+    print("  [4] Posix arg syntax (no server, expect failure)...", end=" ")
+    r = subprocess.run(BASE_CLIENT_CMD + ["/tmp/x", "/tmp/y"], capture_output=True, text=True, timeout=5)
+    if r.returncode != 0 and "connect" in r.stderr:
+        print("OK (TCP fallback)")
+    else:
+        print("FAIL")
+        errors.append("Posix arg syntax failed")
+
+    check_ssh_localhost()
+    print("  [5] SSH to localhost...", end=" ")
+    if SSH_AVAILABLE:
+        print("OK")
+    else:
+        print("SKIP (install fastsync-server in PATH on remote)")
+
+    if errors:
+        print(f"\n  {len(errors)} pre-flight check(s) failed: {', '.join(errors)}")
+        sys.exit(1)
+    print("  All pre-flight checks passed.\n")
+
+
+def main():
+    os.system("cmake -B build -S . > /dev/null 2>&1")
+    if os.system("cd build && make -j$(nproc) 2>&1 | tail -3") != 0:
+        print("Build failed")
+        sys.exit(1)
+    preflight_checks()
+    parser = argparse.ArgumentParser(description="FastSync integration test / benchmark")
+    parser.add_argument("--source-dir", default=DEFAULT_SOURCE_DIR)
+    parser.add_argument("--dest-dir", default=DEFAULT_DEST_DIR)
+    parser.add_argument("--keep-data", action="store_true")
+    parser.add_argument("--unlimited", action="store_true")
+    parser.add_argument("--wan", action="store_true")
+    args = parser.parse_args()
+
+    total_bytes = generate_test_files(args.source_dir)
+    if os.path.exists(args.dest_dir):
+        shutil.rmtree(args.dest_dir)
+    os.makedirs(args.dest_dir, exist_ok=True)
+
+    profiles = []
+    if args.unlimited:
+        profiles.append("Unlimited")
+    elif args.wan:
+        profiles.append("WAN")
+    else:
+        profiles.append("LAN")
+
+    try:
+        all_results = []
+        for p in profiles:
+            all_results.extend(run_profile(p, args.source_dir, args.dest_dir))
+
+        print("\n" + "=" * 130)
+        print(f"{'RESULTS':^130}")
+        print("=" * 130)
+        print(f"{'Configuration':<45} | {'Profile':<12} | {'Status':<8} | {'Time':<10} | {'Details'}")
+        print("-" * 130)
+        for r in all_results:
+            print(f"{r['name']:<45} | {r['suite']:<12} | {r['status']:<8} | {r['time']:<10} | {r['error']}")
+
+        for p in profiles:
+            print_metrics(p, [r for r in all_results if r["suite"] == p], total_bytes)
+
+        failed = [r for r in all_results if r["status"] != "Success"]
+        if failed:
+            print(f"\n  {len(failed)} test(s) FAILED")
+            sys.exit(1)
+        print(f"\n  ALL {len(all_results)} TESTS PASSED")
+    finally:
+        if not args.keep_data:
+            shutil.rmtree(TEST_DIR, ignore_errors=True)
+
+
+if __name__ == "__main__":
+    main()

tests/conftest.py

@@ -1,17 +0,0 @@
-"""Shared pytest configuration for integration tests."""
-import os
-import sys
-import pytest
-
-sys.path.insert(0, os.path.join(os.path.dirname(__file__), "integration"))
-
-from common import ServerManager
-
-
-@pytest.fixture(scope="session")
-def shared_server():
-    """One server for the entire test session. Avoids 27+ server start/stop cycles."""
-    server = ServerManager()
-    server.start()
-    yield server
-    server.stop()

tests/fuzz/fuzz_chunk_deserialize.c

@@ -1,26 +0,0 @@
-#include "chunk.h"
-#include "data.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size == 0)
-    return 0;
-
-  void* buf = malloc(size);
-  if (!buf)
-    return 0;
-  memcpy(buf, data, size);
-
-  Data* d = data_create(buf, size);
-  if (!d)
-    return 0;
-
-  Chunk* chunk = chunk_deserialize(d, false);
-  if (chunk)
-    chunk_destroy(chunk);
-
-  data_destroy(d);
-  return 0;
-}

tests/fuzz/fuzz_compress_decompress.c

@@ -1,31 +0,0 @@
-#include "compression.h"
-#include "data.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size == 0)
-    return 0;
-
-  void* buf = malloc(size);
-  if (!buf)
-    return 0;
-  memcpy(buf, data, size);
-
-  Data* d = data_create(buf, size);
-  if (!d)
-    return 0;
-
-  Data* compressed = data_compress(d, 3);
-  if (compressed) {
-    Data* decompressed = data_decompress(compressed);
-    if (decompressed) {
-      data_destroy(decompressed);
-    }
-    data_destroy(compressed);
-  }
-
-  data_destroy(d);
-  return 0;
-}

tests/fuzz/fuzz_delta_deserialize.c

@@ -1,26 +0,0 @@
-#include "delta.h"
-#include "data.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size == 0)
-    return 0;
-
-  void* buf = malloc(size);
-  if (!buf)
-    return 0;
-  memcpy(buf, data, size);
-
-  Data* d = data_create(buf, size);
-  if (!d)
-    return 0;
-
-  Delta* delta = delta_deserialize(d);
-  if (delta)
-    delta_destroy(delta);
-
-  data_destroy(d);
-  return 0;
-}

tests/fuzz/fuzz_delta_signature_deserialize.c

@@ -1,26 +0,0 @@
-#include "delta.h"
-#include "data.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size == 0)
-    return 0;
-
-  void* buf = malloc(size);
-  if (!buf)
-    return 0;
-  memcpy(buf, data, size);
-
-  Data* d = data_create(buf, size);
-  if (!d)
-    return 0;
-
-  DeltaSignature* sig = delta_signature_deserialize(d);
-  if (sig)
-    delta_signature_destroy(sig);
-
-  data_destroy(d);
-  return 0;
-}

tests/fuzz/fuzz_glob_match.c

@@ -1,32 +0,0 @@
-#include "utils.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size < 2)
-    return 0;
-
-  // Split input into pattern and string at the midpoint
-  size_t mid = size / 2;
-
-  char* pattern = malloc(mid + 1);
-  char* str = malloc(size - mid + 1);
-  if (!pattern || !str) {
-    free(pattern);
-    free(str);
-    return 0;
-  }
-
-  memcpy(pattern, data, mid);
-  pattern[mid] = '\0';
-
-  memcpy(str, data + mid, size - mid);
-  str[size - mid] = '\0';
-
-  glob_match(pattern, str);
-
-  free(pattern);
-  free(str);
-  return 0;
-}

tests/fuzz/fuzz_metadata_from_buf.c

@@ -1,23 +0,0 @@
-#include "metadata.h"
-#include "file.h"
-#include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
-
-int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  if (size < sizeof(int) + FILE_METADATA_WIRE_SIZE)
-    return 0;
-
-  char* buf = malloc(size);
-  if (!buf)
-    return 0;
-  memcpy(buf, data, size);
-
-  char* original_buf = buf;
-  FileMetadata* m = metadata_from_buf(&buf);
-  if (m)
-    free(m);
-
-  free(original_buf);
-  return 0;
-}

tests/integration/common.py

@@ -1,181 +0,0 @@
-import filecmp
-import os
-import random
-import shutil
-import socket
-import subprocess
-import sys
-import tempfile
-import time
-
-PROJECT_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", ".."))
-BUILD_DIR = os.path.join(PROJECT_ROOT, "build")
-SERVER_CMD = [os.path.join(BUILD_DIR, "server")]
-CLIENT_CMD = [os.path.join(BUILD_DIR, "client")]
-TEST_DATA_DIR = os.path.join(PROJECT_ROOT, "test_data")
-
-
-class ServerManager:
-    """Manages a long-lived server process. Reuses across test cases."""
-
-    def __init__(self):
-        self._proc = None
-        self._port = None
-
-    def start(self, extra_args=None):
-        self.stop()
-        self._port = _find_free_port()
-        cmd = SERVER_CMD + ["-p", str(self._port)]
-        if extra_args:
-            cmd += extra_args
-        self._proc = subprocess.Popen(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
-        _wait_for_port(self._port, timeout=5)
-
-    def stop(self):
-        if self._proc:
-            _wait_proc(self._proc)
-            self._proc = None
-
-    @property
-    def port(self):
-        return self._port
-
-    def __enter__(self):
-        self.start()
-        return self
-
-    def __exit__(self, *args):
-        self.stop()
-
-    def __del__(self):
-        self.stop()
-
-
-def run_client(source_dir, dest_dir, flags=None, port=None, extra_args=None):
-    """Run the client and return (result, duration)."""
-    cmd = CLIENT_CMD + ["--source-dir", source_dir, "--dest-dir", dest_dir, "--save-to-disk"]
-    if port:
-        cmd += ["--server-port", str(port)]
-    if flags:
-        cmd += flags
-    if extra_args:
-        cmd += extra_args
-    start = time.monotonic()
-    result = subprocess.run(cmd, text=True, capture_output=True)
-    duration = time.monotonic() - start
-    return result, duration
-
-
-def run_client_posix(source_dir, dest_dir, flags=None, port=None):
-    """Run the client with positional args (rsync-style)."""
-    cmd = CLIENT_CMD + [source_dir, dest_dir, "--save-to-disk"]
-    if port:
-        cmd += ["--server-port", str(port)]
-    if flags:
-        cmd += flags
-    start = time.monotonic()
-    result = subprocess.run(cmd, text=True, capture_output=True)
-    duration = time.monotonic() - start
-    return result, duration
-
-
-def generate_test_files(source_dir, full=False):
-    """Generate structured test data. Returns total bytes written."""
-    if os.path.exists(source_dir):
-        shutil.rmtree(source_dir)
-    os.makedirs(source_dir)
-
-    target_total = 25 * 1024 * 1024 if full else 0
-    written = 0
-
-    files = {
-        "small.txt": b"hello world\n",
-        "medium.txt": b"the quick brown fox jumps over the lazy dog\n" * 5000,
-        "binary.bin": bytes(range(256)) * 1000,
-        "nested/subdir/deep.txt": b"deeply nested file\n",
-        "nested/another.txt": b"another nested file\n" * 50,
-    }
-    for rel_path, content in files.items():
-        full_path = os.path.join(source_dir, rel_path)
-        os.makedirs(os.path.dirname(full_path), exist_ok=True)
-        with open(full_path, "wb") as f:
-            f.write(content)
-        written += len(content)
-
-    if full:
-        os.makedirs(os.path.join(source_dir, "bulk"), exist_ok=True)
-        i = 0
-        while written < target_total:
-            chunk_size = min(5 * 1024 * 1024, target_total - written)
-            with open(os.path.join(source_dir, f"bulk/file_{i}.dat"), "wb") as f:
-                f.write(random.randbytes(chunk_size))
-            written += chunk_size
-            i += 1
-
-    return written
-
-
-def verify_transfer(source_dir, received_dir):
-    """Verify all files from source exist in received_dir and match. Returns (mismatches, missing)."""
-    source_dir = os.path.abspath(source_dir)
-    received_dir = os.path.abspath(received_dir)
-    if not os.path.exists(received_dir):
-        return [], ["no received files found"]
-    mismatches, missing = [], []
-    for root, dirs, files in os.walk(source_dir):
-        for f in files:
-            src_path = os.path.join(root, f)
-            rel = os.path.relpath(src_path, source_dir)
-            dst_path = os.path.join(received_dir, rel)
-            if not os.path.exists(dst_path):
-                missing.append(rel)
-            elif not filecmp.cmp(src_path, dst_path, shallow=False):
-                mismatches.append(rel)
-    return mismatches, missing
-
-
-def clean_dir(path):
-    """Remove and recreate a directory."""
-    if os.path.exists(path):
-        shutil.rmtree(path)
-    os.makedirs(path, exist_ok=True)
-
-
-def make_result(name, success, duration=None, error=""):
-    """Create a standardized result dict."""
-    return {
-        "name": name,
-        "status": "Success" if success else "Failed",
-        "time": f"{duration:.4f}s" if duration is not None else "N/A",
-        "error": error,
-    }
-
-
-def get_dest_received_dir(dest_dir, source_dir):
-    """Get the path where received files land inside dest_dir."""
-    return os.path.join(dest_dir, os.path.abspath(source_dir).lstrip(os.sep))
-
-
-def _find_free_port():
-    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
-        s.bind(("", 0))
-        return s.getsockname()[1]
-
-
-def _wait_for_port(port, timeout=5):
-    deadline = time.monotonic() + timeout
-    while time.monotonic() < deadline:
-        try:
-            with socket.create_connection(("127.0.0.1", port), timeout=0.3):
-                return
-        except (ConnectionRefusedError, OSError):
-            time.sleep(0.05)
-    raise RuntimeError(f"Server port {port} not ready after {timeout}s")
-
-
-def _wait_proc(proc, timeout=5):
-    try:
-        proc.wait(timeout=timeout)
-    except subprocess.TimeoutExpired:
-        proc.kill()
-        proc.wait()

tests/integration/test_features.py

@@ -1,256 +0,0 @@
-"""Feature tests: incremental sync, bandwidth limiting, dry run, metadata, filters."""
-import os
-import shutil
-import sys
-import time
-import pytest
-
-sys.path.insert(0, os.path.dirname(__file__))
-from common import (
-    PROJECT_ROOT, BUILD_DIR, TEST_DATA_DIR,
-    run_client,
-    generate_test_files, verify_transfer, clean_dir, make_result,
-    get_dest_received_dir, CLIENT_CMD,
-)
-
-SOURCE_DIR = os.path.join(TEST_DATA_DIR, "feature_source")
-DEST_DIR = os.path.join(TEST_DATA_DIR, "feature_dest")
-
-
-@pytest.fixture(scope="module", autouse=True)
-def setup_test_data():
-    generate_test_files(SOURCE_DIR, full=False)
-    clean_dir(DEST_DIR)
-    yield
-    shutil.rmtree(TEST_DATA_DIR, ignore_errors=True)
-
-
-class TestDryRun:
-    def test_dry_run(self):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-n"],
-        )
-        assert result.returncode == 0, f"Exit {result.returncode}: {result.stderr[:100]}"
-        assert "Dry run:" in result.stdout, f"No dry run output: {result.stdout[:200]}"
-
-
-class TestArchiveMode:
-    def test_archive_mode(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-a"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing: {missing}"
-        assert not mismatches, f"Mismatch: {mismatches}"
-
-
-class TestExclude:
-    def test_exclude_single(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--exclude", "small.txt"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert "small.txt" in missing, "small.txt should be excluded but was transferred"
-        other_missing = [m for m in missing if m != "small.txt"]
-        assert not other_missing, f"Other files missing: {other_missing}"
-        assert not mismatches, f"Mismatch: {mismatches}"
-
-    def test_exclude_glob(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--exclude", "*.txt"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        assert not os.path.exists(os.path.join(received, "small.txt")), "small.txt should be excluded"
-        assert os.path.exists(os.path.join(received, "binary.bin")), "binary.bin should be present"
-
-
-class TestInclude:
-    def test_include_single(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--include", "binary.bin"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        assert os.path.exists(os.path.join(received, "binary.bin")), "binary.bin should be included"
-        assert not os.path.exists(os.path.join(received, "small.txt")), "small.txt should not be included"
-
-    def test_include_glob(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--include", "*.bin"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        assert os.path.exists(os.path.join(received, "binary.bin")), "binary.bin should be included"
-
-
-class TestSizeFilters:
-    def test_max_size(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--max-size", "100"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        assert os.path.exists(os.path.join(received, "small.txt")), "small.txt should be present"
-        assert not os.path.exists(os.path.join(received, "medium.txt")), "medium.txt should be skipped"
-
-    def test_min_size(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--min-size", "1000"],
-            port=shared_server.port,
-        )
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        assert not os.path.exists(os.path.join(received, "small.txt")), "small.txt should be skipped"
-        assert os.path.exists(os.path.join(received, "medium.txt")), "medium.txt should be present"
-
-
-class TestIncremental:
-    def test_incremental_skips_unchanged(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0, f"First sync failed: {result.stderr[:100]}"
-
-        start = time.monotonic()
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M", "--incremental"],
-            port=shared_server.port,
-        )
-        incremental_time = time.monotonic() - start
-
-        assert result.returncode == 0, f"Incremental sync failed: {(result.stderr or result.stdout)[:200]}"
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing: {missing}"
-        assert not mismatches, f"Mismatch: {mismatches}"
-
-    def test_incremental_detects_changes(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, _ = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0
-
-        modified_file = os.path.join(SOURCE_DIR, "small.txt")
-        with open(modified_file, "wb") as f:
-            f.write(b"modified content for incremental test\n")
-
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M", "--incremental"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0
-
-        with open(modified_file, "wb") as f:
-            f.write(b"hello world\n")
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        received_file = os.path.join(received, "small.txt")
-        assert os.path.exists(received_file), "Modified file should be present"
-        with open(received_file, "rb") as f:
-            content = f.read()
-        assert b"modified content" in content, f"Modified content not transferred: {content[:50]}"
-
-
-class TestDelete:
-    def test_delete_removes_extra_files(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, _ = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        extra_file = os.path.join(received, "extra_file.txt")
-        extra_dir = os.path.join(received, "extra_dir")
-        with open(extra_file, "w") as f:
-            f.write("should be deleted")
-        os.makedirs(extra_dir, exist_ok=True)
-        with open(os.path.join(extra_dir, "nested.txt"), "w") as f:
-            f.write("nested extra")
-
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["-M", "--delete"],
-            port=shared_server.port,
-        )
-
-        assert result.returncode == 0, f"Delete sync failed: {(result.stderr or result.stdout)[:200]}"
-        assert not os.path.exists(extra_file), "extra_file.txt should be deleted"
-        assert not os.path.exists(extra_dir), "extra_dir should be deleted"
-
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing: {missing}"
-        assert not mismatches, f"Mismatch: {mismatches}"
-
-
-class TestProgress:
-    def test_progress_output(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--progress"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0, f"Exit {result.returncode}: {result.stderr[:100]}"
-        output = result.stdout + result.stderr
-        assert len(output) >= 0
-
-
-class TestBandwidthLimit:
-    def test_bwlimit_runs(self, shared_server):
-        clean_dir(DEST_DIR)
-        result, dur = run_client(
-            SOURCE_DIR, DEST_DIR,
-            flags=["--bwlimit", "10240"],
-            port=shared_server.port,
-        )
-        assert result.returncode == 0, f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}"
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing: {missing}"
-        assert not mismatches, f"Mismatch: {mismatches}"

tests/integration/test_preflight.py

@@ -1,81 +0,0 @@
-"""CLI validation and preflight checks."""
-import subprocess
-import sys
-import os
-import pytest
-
-sys.path.insert(0, os.path.dirname(__file__))
-from common import BUILD_DIR, CLIENT_CMD, SERVER_CMD
-
-
-class TestHelp:
-    def test_client_help(self):
-        r = subprocess.run(CLIENT_CMD + ["--help"], capture_output=True, text=True)
-        assert r.returncode == 0
-        assert "Usage:" in r.stdout
-        assert "SSH transport" in r.stdout
-
-    def test_server_help(self):
-        r = subprocess.run(SERVER_CMD + ["--help"], capture_output=True, text=True)
-        assert r.returncode == 0
-        assert "Usage:" in r.stdout
-
-
-class TestSSHDetection:
-    def test_remote_dest_detected(self):
-        """Posix-style SSH dest should be detected and fail gracefully."""
-        r = subprocess.run(
-            CLIENT_CMD + ["/x", "somehost:/y"],
-            capture_output=True, text=True, timeout=5,
-        )
-        assert r.returncode != 0
-        stderr = (r.stderr or "").lower()
-        assert "ssh" in stderr or "error" in stderr or "could not" in stderr
-
-    def test_local_dest_not_ssh(self):
-        """Local path should not be detected as SSH."""
-        r = subprocess.run(
-            CLIENT_CMD + ["/tmp/x", "/tmp/y"],
-            capture_output=True, text=True, timeout=5,
-        )
-        # Should fail with connection error (no server), not SSH error
-        assert r.returncode != 0
-
-
-class TestServerStdio:
-    def test_stdio_mode_starts(self):
-        """Server --stdio should start and wait for stdin."""
-        try:
-            r = subprocess.run(
-                SERVER_CMD + ["--stdio"],
-                capture_output=True, text=True, timeout=3,
-            )
-            # Should exit with error (no data on stdin) or timeout
-        except subprocess.TimeoutExpired:
-            pass  # Expected: server waiting for stdin
-
-
-class TestServerPort:
-    def test_invalid_port(self):
-        """Server should reject invalid port numbers."""
-        r = subprocess.run(
-            SERVER_CMD + ["-p", "99999"],
-            capture_output=True, text=True, timeout=5,
-        )
-        assert r.returncode != 0
-
-    def test_default_port(self):
-        """Server should start on default port 8080."""
-        proc = subprocess.Popen(
-            SERVER_CMD, stdout=subprocess.DEVNULL, stderr=None,
-        )
-        try:
-            import socket, time
-            time.sleep(0.5)
-            with socket.create_connection(("127.0.0.1", 8080), timeout=2):
-                pass  # Port is listening
-        except (ConnectionRefusedError, OSError):
-            pytest.fail("Server not listening on default port 8080")
-        finally:
-            proc.terminate()
-            proc.wait(timeout=5)

tests/integration/test_ssh.py

@@ -1,132 +0,0 @@
-"""SSH transport tests."""
-import os
-import shutil
-import subprocess
-import sys
-import pytest
-
-sys.path.insert(0, os.path.dirname(__file__))
-from common import (
-    PROJECT_ROOT, BUILD_DIR, TEST_DATA_DIR,
-    CLIENT_CMD, generate_test_files, verify_transfer, clean_dir, make_result,
-)
-
-SOURCE_DIR = os.path.join(TEST_DATA_DIR, "ssh_source")
-DEST_DIR = os.path.join(TEST_DATA_DIR, "ssh_dest")
-SSH_AVAILABLE = False
-
-
-def _check_ssh():
-    global SSH_AVAILABLE
-    try:
-        r = subprocess.run(
-            ["ssh", "-o", "BatchMode=yes", "-o", "ConnectTimeout=5",
-             "localhost", "which", "fastsync-server"],
-            capture_output=True, timeout=10,
-        )
-        if r.returncode == 0:
-            SSH_AVAILABLE = True
-            return
-
-        # Try to install server binary into PATH
-        server_path = os.path.join(BUILD_DIR, "server")
-        r = subprocess.run(
-            ["ssh", "-o", "BatchMode=yes", "localhost", 'echo "$PATH"'],
-            capture_output=True, timeout=10, text=True,
-        )
-        if r.returncode != 0:
-            return
-        for d in r.stdout.strip().split(":"):
-            d = d.strip()
-            if not d or "wrappers" in d:
-                continue
-            test = subprocess.run(
-                ["ssh", "-o", "BatchMode=yes", "localhost",
-                 f'test -w "{d}" && ln -sf {server_path} "{d}/fastsync-server" && which fastsync-server'],
-                capture_output=True, timeout=10,
-            )
-            if test.returncode == 0:
-                SSH_AVAILABLE = True
-                return
-    except FileNotFoundError:
-        pass
-
-
-@pytest.fixture(scope="module", autouse=True)
-def setup_test_data():
-    _check_ssh()
-    if SSH_AVAILABLE:
-        generate_test_files(SOURCE_DIR, full=False)
-        clean_dir(DEST_DIR)
-    yield
-    shutil.rmtree(TEST_DATA_DIR, ignore_errors=True)
-
-
-def _run_ssh_test(name, flags, expected_missing=None):
-    """Run an SSH test case (no server process needed, client spawns SSH)."""
-    ssh_dest = f"localhost:{DEST_DIR}"
-    clean_dir(DEST_DIR)
-    cmd = CLIENT_CMD + [SOURCE_DIR, ssh_dest, "--save-to-disk"] + flags
-    start = __import__("time").monotonic()
-    result = subprocess.run(cmd, text=True, capture_output=True)
-    duration = __import__("time").monotonic() - start
-
-    if result.returncode != 0:
-        return make_result(name, False, duration, f"Exit {result.returncode}: {(result.stderr or result.stdout)[:100]}")
-
-    mismatches, missing = verify_transfer(SOURCE_DIR, DEST_DIR)
-    if expected_missing:
-        missing = [m for m in missing if m not in expected_missing]
-    if missing:
-        return make_result(name, False, duration, f"Missing: {', '.join(missing[:5])}")
-    if mismatches:
-        return make_result(name, False, duration, f"Mismatch: {', '.join(mismatches[:3])}")
-    return make_result(name, True, duration)
-
-
-@pytest.mark.skipif(not SSH_AVAILABLE, reason="SSH to localhost not available")
-class TestSSHStandard:
-    def test_standard(self):
-        r = _run_ssh_test("SSH (localhost)", [])
-        assert r["status"] == "Success", r["error"]
-
-    def test_multithreading(self):
-        r = _run_ssh_test("SSH Multithreading (-m)", ["-m"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_compression(self):
-        r = _run_ssh_test("SSH Compression (-c)", ["-c"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_chunk_serialization(self):
-        r = _run_ssh_test("SSH Chunk Serialization (-s)", ["-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_compression_chunk(self):
-        r = _run_ssh_test("SSH Compression + Chunk (-c -s)", ["-c", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_multithread_compression(self):
-        r = _run_ssh_test("SSH Multithread + Compression (-m -c)", ["-m", "-c"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_multithread_chunk(self):
-        r = _run_ssh_test("SSH Multithread + Chunk (-m -s)", ["-m", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_all_flags(self):
-        r = _run_ssh_test("SSH All Flags (-m -c -s)", ["-m", "-c", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-
-@pytest.mark.skipif(not SSH_AVAILABLE, reason="SSH to localhost not available")
-class TestSSHFeatures:
-    def test_archive(self):
-        r = _run_ssh_test("SSH Archive (-a)", ["-a"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_exclude(self):
-        r = _run_ssh_test("SSH Exclude (--exclude small.txt)",
-                          ["--exclude", "small.txt"],
-                          expected_missing=["small.txt"])
-        assert r["status"] == "Success", r["error"]

tests/integration/test_tcp.py

@@ -1,110 +0,0 @@
-"""TCP transport correctness tests."""
-import os
-import shutil
-import sys
-import pytest
-
-sys.path.insert(0, os.path.dirname(__file__))
-from common import (
-    PROJECT_ROOT, BUILD_DIR, TEST_DATA_DIR,
-    run_client, run_client_posix,
-    generate_test_files, verify_transfer, clean_dir, make_result,
-    get_dest_received_dir, CLIENT_CMD,
-)
-
-SOURCE_DIR = os.path.join(TEST_DATA_DIR, "tcp_source")
-DEST_DIR = os.path.join(TEST_DATA_DIR, "tcp_dest")
-
-
-@pytest.fixture(scope="module", autouse=True)
-def setup_test_data():
-    generate_test_files(SOURCE_DIR, full=False)
-    clean_dir(DEST_DIR)
-    yield
-    shutil.rmtree(TEST_DATA_DIR, ignore_errors=True)
-
-
-def _run_tcp_test(name, port, flags, use_metadata=True, posix=False):
-    """Run a single TCP test case against a shared server."""
-    clean_dir(DEST_DIR)
-    if posix:
-        result, dur = run_client_posix(SOURCE_DIR, DEST_DIR,
-                                       flags=(["-M"] if use_metadata else []) + flags,
-                                       port=port)
-    else:
-        result, dur = run_client(SOURCE_DIR, DEST_DIR,
-                                 flags=(["-M"] if use_metadata else []) + flags,
-                                 port=port)
-
-    if result.returncode != 0:
-        return make_result(name, False, dur, f"Exit {result.returncode}: {(result.stderr or result.stdout)[:100]}")
-
-    received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-    mismatches, missing = verify_transfer(SOURCE_DIR, received)
-    if missing:
-        return make_result(name, False, dur, f"Missing: {', '.join(missing[:5])}")
-    if mismatches:
-        return make_result(name, False, dur, f"Mismatch: {', '.join(mismatches[:3])}")
-    return make_result(name, True, dur)
-
-
-class TestTCPStandard:
-    def test_standard(self, shared_server):
-        r = _run_tcp_test("Standard", shared_server.port, [])
-        assert r["status"] == "Success", r["error"]
-
-    def test_posix_args(self, shared_server):
-        r = _run_tcp_test("Posix Args", shared_server.port, [], posix=True)
-        assert r["status"] == "Success", r["error"]
-
-    def test_no_metadata(self, shared_server):
-        r = _run_tcp_test("Standard (no metadata)", shared_server.port, [], use_metadata=False)
-        assert r["status"] == "Success", r["error"]
-
-
-class TestTCPFlags:
-    def test_multithreading(self, shared_server):
-        r = _run_tcp_test("Multithreading (-m)", shared_server.port, ["-m"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_compression(self, shared_server):
-        r = _run_tcp_test("Compression (-c)", shared_server.port, ["-c"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_chunk_serialization(self, shared_server):
-        r = _run_tcp_test("Chunk Serialization (-s)", shared_server.port, ["-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_compression_chunk(self, shared_server):
-        r = _run_tcp_test("Compression + Chunk (-c -s)", shared_server.port, ["-c", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_multithread_compression(self, shared_server):
-        r = _run_tcp_test("Multithreading + Compression (-m -c)", shared_server.port, ["-m", "-c"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_multithread_chunk(self, shared_server):
-        r = _run_tcp_test("Multithreading + Chunk (-m -s)", shared_server.port, ["-m", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_all_flags(self, shared_server):
-        r = _run_tcp_test("Multithread + Compression + Chunk (-m -c -s)", shared_server.port, ["-m", "-c", "-s"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_sendfile(self, shared_server):
-        r = _run_tcp_test("Sendfile (-f)", shared_server.port, ["-f"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_sendfile_multithread(self, shared_server):
-        r = _run_tcp_test("Sendfile + Multithreading (-f -m)", shared_server.port, ["-f", "-m"])
-        assert r["status"] == "Success", r["error"]
-
-
-class TestTCPChunkSize:
-    def test_custom_chunk_size(self, shared_server):
-        r = _run_tcp_test("Chunk size 5MB", shared_server.port, ["--chunk-size", "5242880"])
-        assert r["status"] == "Success", r["error"]
-
-    def test_small_chunk_size(self, shared_server):
-        r = _run_tcp_test("Chunk size 1KB", shared_server.port, ["--chunk-size", "1024"])
-        assert r["status"] == "Success", r["error"]

tests/integration/test_tls.py

@@ -1,181 +0,0 @@
-"""TLS transport tests. Generates self-signed certs for testing."""
-import os
-import shutil
-import subprocess
-import sys
-import tempfile
-import pytest
-
-sys.path.insert(0, os.path.dirname(__file__))
-from common import (
-    PROJECT_ROOT, BUILD_DIR, SERVER_CMD, TEST_DATA_DIR,
-    ServerManager, run_client,
-    generate_test_files, verify_transfer, clean_dir, make_result,
-    get_dest_received_dir, _find_free_port, _wait_proc,
-)
-
-SOURCE_DIR = os.path.join(TEST_DATA_DIR, "tls_source")
-DEST_DIR = os.path.join(TEST_DATA_DIR, "tls_dest")
-CERT_DIR = os.path.join(TEST_DATA_DIR, "tls_certs")
-
-
-def _generate_certs(cert_dir):
-    """Generate a self-signed CA, server cert, and client cert for testing."""
-    os.makedirs(cert_dir, exist_ok=True)
-    ca_key = os.path.join(cert_dir, "ca.key")
-    ca_cert = os.path.join(cert_dir, "ca.pem")
-    server_key = os.path.join(cert_dir, "server.key")
-    server_cert = os.path.join(cert_dir, "server.pem")
-    client_key = os.path.join(cert_dir, "client.key")
-    client_cert = os.path.join(cert_dir, "client.pem")
-
-    # CA key + cert
-    subprocess.run([
-        "openssl", "req", "-x509", "-newkey", "rsa:2048", "-nodes",
-        "-keyout", ca_key, "-out", ca_cert,
-        "-days", "1", "-subj", "/CN=FastSync Test CA",
-    ], check=True, capture_output=True)
-
-    # Server key + CSR + cert (signed by CA)
-    subprocess.run([
-        "openssl", "req", "-newkey", "rsa:2048", "-nodes",
-        "-keyout", server_key, "-out", os.path.join(cert_dir, "server.csr"),
-        "-subj", "/CN=localhost",
-    ], check=True, capture_output=True)
-    subprocess.run([
-        "openssl", "x509", "-req", "-in", os.path.join(cert_dir, "server.csr"),
-        "-CA", ca_cert, "-CAkey", ca_key, "-CAcreateserial",
-        "-out", server_cert, "-days", "1",
-    ], check=True, capture_output=True)
-
-    # Client key + CSR + cert (signed by CA)
-    subprocess.run([
-        "openssl", "req", "-newkey", "rsa:2048", "-nodes",
-        "-keyout", client_key, "-out", os.path.join(cert_dir, "client.csr"),
-        "-subj", "/CN=fastsync-client",
-    ], check=True, capture_output=True)
-    subprocess.run([
-        "openssl", "x509", "-req", "-in", os.path.join(cert_dir, "client.csr"),
-        "-CA", ca_cert, "-CAkey", ca_key, "-CAcreateserial",
-        "-out", client_cert, "-days", "1",
-    ], check=True, capture_output=True)
-
-    return {
-        "ca": ca_cert,
-        "server_cert": server_cert,
-        "server_key": server_key,
-        "client_cert": client_cert,
-        "client_key": client_key,
-    }
-
-
-@pytest.fixture(scope="module")
-def certs():
-    """Generate test certificates once per test module."""
-    if os.path.exists(CERT_DIR):
-        shutil.rmtree(CERT_DIR)
-    c = _generate_certs(CERT_DIR)
-    yield c
-    shutil.rmtree(CERT_DIR, ignore_errors=True)
-
-
-@pytest.fixture(scope="module", autouse=True)
-def setup_test_data():
-    generate_test_files(SOURCE_DIR, full=False)
-    clean_dir(DEST_DIR)
-    yield
-    shutil.rmtree(TEST_DATA_DIR, ignore_errors=True)
-
-
-class TestTLSBasic:
-    def test_tls_server_client(self, certs):
-        """Basic TLS: server with cert/key, client with cert/key + CA."""
-        clean_dir(DEST_DIR)
-        with ServerManager() as server:
-            server.start(extra_args=[
-                "--tls", "--cert", certs["server_cert"], "--key", certs["server_key"],
-            ])
-            result, dur = run_client(
-                SOURCE_DIR, DEST_DIR,
-                flags=["--tls",
-                       "--cert", certs["client_cert"], "--key", certs["client_key"],
-                       "--ca", certs["ca"]],
-                port=server.port,
-            )
-
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing files: {missing}"
-        assert not mismatches, f"Mismatched files: {mismatches}"
-
-    def test_tls_with_compression(self, certs):
-        """TLS + compression."""
-        clean_dir(DEST_DIR)
-        with ServerManager() as server:
-            server.start(extra_args=[
-                "--tls", "--cert", certs["server_cert"], "--key", certs["server_key"],
-            ])
-            result, dur = run_client(
-                SOURCE_DIR, DEST_DIR,
-                flags=["-c", "--tls",
-                       "--cert", certs["client_cert"], "--key", certs["client_key"],
-                       "--ca", certs["ca"]],
-                port=server.port,
-            )
-
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing files: {missing}"
-        assert not mismatches, f"Mismatched files: {mismatches}"
-
-    def test_tls_with_multithreading(self, certs):
-        """TLS + multithreading."""
-        clean_dir(DEST_DIR)
-        with ServerManager() as server:
-            server.start(extra_args=[
-                "--tls", "--cert", certs["server_cert"], "--key", certs["server_key"],
-            ])
-            result, dur = run_client(
-                SOURCE_DIR, DEST_DIR,
-                flags=["-m", "--tls",
-                       "--cert", certs["client_cert"], "--key", certs["client_key"],
-                       "--ca", certs["ca"]],
-                port=server.port,
-            )
-
-        if result.returncode != 0:
-            pytest.fail(f"Exit {result.returncode}: {(result.stderr or result.stdout)[:200]}")
-
-        received = get_dest_received_dir(DEST_DIR, SOURCE_DIR)
-        mismatches, missing = verify_transfer(SOURCE_DIR, received)
-        assert not missing, f"Missing files: {missing}"
-        assert not mismatches, f"Mismatched files: {mismatches}"
-
-
-class TestTLSErrorCases:
-    def test_server_tls_missing_cert_key(self):
-        """Server should fail if --tls is given without --cert/--key."""
-        proc = subprocess.Popen(
-            SERVER_CMD + ["--tls"],
-            stdout=subprocess.DEVNULL, stderr=subprocess.PIPE,
-        )
-        _, stderr = proc.communicate(timeout=5)
-        assert proc.returncode != 0, "Server should fail with --tls but no cert/key"
-
-    def test_client_tls_missing_key(self):
-        """Client should fail if --tls is given without --key."""
-        clean_dir(DEST_DIR)
-        with ServerManager() as server:
-            result, _ = run_client(
-                SOURCE_DIR, DEST_DIR,
-                flags=["--tls",
-                       "--cert", "/nonexistent/cert.pem"],
-                port=server.port,
-            )
-        assert result.returncode != 0, "Client should fail with --tls but no --key"

tests/runner.c

@@ -2,24 +2,9 @@
 #include "test_chunk.h"
 #include "test_compression.h"
 #include "test_config.h"
-#include "test_data.h"
-#include "test_delta.h"
-#include "test_file.h"
-#include "test_file_sendfile.h"
-#include "test_glob.h"
-#include "test_log.h"
-#include "test_metadata.h"
-#include "test_multiprocessing.h"
-#include "test_property.h"
-#include "test_protocol.h"
 #include "test_queue.h"
-#include "test_robustness.h"
 #include "test_scanner.h"
 #include "test_shared_utils.h"
-#include "test_stress.h"
-#include "test_transport_tcp.h"
-#include "test_transport_ssh.h"
-#include "test_transport_tls.h"
 #include "test_utils.h"
 #include <stdio.h>
 
@@ -38,21 +23,6 @@ int main() {
   RUN_TEST(test_config);
   RUN_TEST(test_compression);
   RUN_TEST(test_scanner);
-  RUN_TEST(test_delta);
-  RUN_TEST(test_data);
-  RUN_TEST(test_protocol);
-  RUN_TEST(test_metadata);
-  RUN_TEST(test_glob);
-  RUN_TEST(test_file);
-  RUN_TEST(test_file_sendfile);
-  RUN_TEST(test_multiprocessing);
-  RUN_TEST(test_log);
-  RUN_TEST(test_transport_tcp);
-  RUN_TEST(test_transport_ssh);
-  RUN_TEST(test_transport_tls);
-  RUN_TEST(test_robustness);
-  RUN_TEST(test_stress);
-  RUN_TEST(test_property);
 
   printf("\n\033[1;36m=== TEST SUMMARY ===\033[0m\n");
   printf("Total Tests Run: %d\n", tests_run);

tests/test_array_list.c

@@ -4,28 +4,28 @@
 #include <stdlib.h>
 
 static int destroyer_calls = 0;
-static void test_destroyer(void* item) {
+static void test_destroyer(void *item) {
   destroyer_calls++;
   free(item);
 }
 
 void test_array_list() {
-  ArrayList* list = array_list_create(free);
+  ArrayList *list = array_list_create(free);
   EXPECT_NOT_NULL(list);
   EXPECT_EQ_INT(list->size, 0);
   EXPECT_EQ_INT(list->capacity, 100);
 
   // Test adding
-  int* val1 = malloc(sizeof(int));
+  int *val1 = malloc(sizeof(int));
   *val1 = 42;
   array_list_add(list, val1);
   EXPECT_EQ_INT(list->size, 1);
-  EXPECT_EQ_INT(*(int*)list->items[0], 42);
+  EXPECT_EQ_INT(*(int *)list->items[0], 42);
 
   // Test extending capacity
   // Initial capacity is 100. Let's add 105 elements.
   for (int i = 0; i < 105; i++) {
-    int* val = malloc(sizeof(int));
+    int *val = malloc(sizeof(int));
     *val = i;
     array_list_add(list, val);
   }
@@ -33,15 +33,15 @@ void test_array_list() {
   EXPECT_EQ_INT(list->capacity, 200); // 100 * 2
 
   // Verify contents
-  EXPECT_EQ_INT(*(int*)list->items[0], 42);
-  EXPECT_EQ_INT(*(int*)list->items[1], 0);
-  EXPECT_EQ_INT(*(int*)list->items[105], 104);
+  EXPECT_EQ_INT(*(int *)list->items[0], 42);
+  EXPECT_EQ_INT(*(int *)list->items[1], 0);
+  EXPECT_EQ_INT(*(int *)list->items[105], 104);
 
   // Test array conversion
-  void** arr = array_list_to_array(list);
+  void **arr = array_list_to_array(list);
   EXPECT_NOT_NULL(arr);
-  EXPECT_EQ_INT(*(int*)arr[0], 42);
-  EXPECT_EQ_INT(*(int*)arr[105], 104);
+  EXPECT_EQ_INT(*(int *)arr[0], 42);
+  EXPECT_EQ_INT(*(int *)arr[105], 104);
   free(arr);
 
   // Delete list, verifying the destroyer is called 106 times

tests/test_chunk.c

@@ -7,13 +7,13 @@
 #include <unistd.h>
 
 static void test_file_operations() {
-  char* test_path = "temp_file_test.txt";
-  char* test_content = "Hello, Chunk System!";
+  char *test_path = "temp_file_test.txt";
+  char *test_content = "Hello, Chunk System!";
   unsigned long long test_len = strlen(test_content);
 
   to_disk(test_path, test_content, test_len);
 
-  File* f = file_create(test_path);
+  File *f = file_create(test_path);
   EXPECT_NOT_NULL(f);
   EXPECT_EQ_STR(f->path, test_path);
   EXPECT_NOT_NULL(f->data);
@@ -35,12 +35,12 @@ static void test_file_operations() {
 }
 
 static void test_chunk_operations() {
-  char* path1 = "temp_chunk_1.txt";
-  char* content1 = "chunk item 1";
+  char *path1 = "temp_chunk_1.txt";
+  char *content1 = "chunk item 1";
   unsigned long long len1 = strlen(content1);
 
-  char* path2 = "temp_chunk_2.txt";
-  char* content2 = "chunk item number 2";
+  char *path2 = "temp_chunk_2.txt";
+  char *content2 = "chunk item number 2";
   unsigned long long len2 = strlen(content2);
 
   to_disk(path1, content1, len1);
@@ -50,13 +50,13 @@ static void test_chunk_operations() {
   stat(path1, &st1);
   stat(path2, &st2);
 
-  File* f1 = file_create(path1);
+  File *f1 = file_create(path1);
   f1->data->size = st1.st_size;
-  File* f2 = file_create(path2);
+  File *f2 = file_create(path2);
   f2->data->size = st2.st_size;
 
-  File* files[2] = {f1, f2};
-  Chunk* chunk = chunk_create(files, 2);
+  File *files[2] = {f1, f2};
+  Chunk *chunk = chunk_create(files, 2);
   EXPECT_NOT_NULL(chunk);
   EXPECT_EQ_INT(chunk->element_count, 2);
   EXPECT_NOT_NULL(chunk->items[0]);
@@ -67,10 +67,10 @@ static void test_chunk_operations() {
   file_load_data(f2);
 
   // Test chunk_serialize / chunk_deserialize round-trip
-  Data* serialized = chunk_serialize(chunk, false);
+  Data *serialized = chunk_serialize(chunk, false);
   EXPECT_NOT_NULL(serialized);
 
-  Chunk* deserialized = chunk_deserialize(serialized, false);
+  Chunk *deserialized = chunk_deserialize(serialized, false);
   EXPECT_NOT_NULL(deserialized);
   EXPECT_EQ_INT(deserialized->element_count, 2);
   EXPECT_EQ_STR(deserialized->items[0]->path, path1);

tests/test_compression.c

@@ -9,18 +9,18 @@
 #include <unistd.h>
 
 static void test_data_compress_decompress_roundtrip() {
-  const char original[] = "Hello, World! This is test data for compression round-trip!";
+  char original[] = "Hello, World! This is test data for compression round-trip!";
   size_t len = strlen(original);
 
-  char* buf = malloc(len);
+  char *buf = malloc(len);
   memcpy(buf, original, len);
-  Data* original_data = data_create(buf, len);
+  Data *original_data = data_create(buf, len);
   EXPECT_NOT_NULL(original_data);
 
-  Data* compressed = data_compress(original_data, 3);
+  Data *compressed = data_compress(original_data, 3);
   EXPECT_NOT_NULL(compressed);
 
-  Data* decompressed = data_decompress(compressed);
+  Data *decompressed = data_decompress(compressed);
   EXPECT_NOT_NULL(decompressed);
   EXPECT_EQ_INT((int)decompressed->size, (int)len);
   EXPECT_EQ_INT(memcmp(decompressed->data, original, len), 0);
@@ -32,18 +32,18 @@ static void test_data_compress_decompress_roundtrip() {
 
 static void test_data_compress_decompress_large() {
   size_t size = 1024 * 10;
-  char* original = malloc(size);
+  char *original = malloc(size);
   EXPECT_NOT_NULL(original);
   for (size_t i = 0; i < size; i++)
     original[i] = (char)(i % 256);
 
-  Data* original_data = data_create(original, size);
+  Data *original_data = data_create(original, size);
   EXPECT_NOT_NULL(original_data);
 
-  Data* compressed = data_compress(original_data, 1);
+  Data *compressed = data_compress(original_data, 1);
   EXPECT_NOT_NULL(compressed);
 
-  Data* decompressed = data_decompress(compressed);
+  Data *decompressed = data_decompress(compressed);
   EXPECT_NOT_NULL(decompressed);
   EXPECT_EQ_INT((int)decompressed->size, (int)size);
   EXPECT_EQ_INT(memcmp(decompressed->data, original, size), 0);
@@ -54,12 +54,12 @@ static void test_data_compress_decompress_large() {
 }
 
 static void test_chunk_compress_decompress_roundtrip() {
-  char* path1 = "temp_comp_test_1.txt";
-  char* content1 = "chunk compression test file 1";
+  char *path1 = "temp_comp_test_1.txt";
+  char *content1 = "chunk compression test file 1";
   unsigned long long len1 = strlen(content1);
 
-  char* path2 = "temp_comp_test_2.txt";
-  char* content2 = "chunk compression test file 2 with more data";
+  char *path2 = "temp_comp_test_2.txt";
+  char *content2 = "chunk compression test file 2 with more data";
   unsigned long long len2 = strlen(content2);
 
   to_disk(path1, content1, len1);
@@ -69,9 +69,9 @@ static void test_chunk_compress_decompress_roundtrip() {
   EXPECT_EQ_INT(stat(path1, &st1), 0);
   EXPECT_EQ_INT(stat(path2, &st2), 0);
 
-  File* f1 = file_create(path1);
+  File *f1 = file_create(path1);
   f1->data->size = st1.st_size;
-  File* f2 = file_create(path2);
+  File *f2 = file_create(path2);
   f2->data->size = st2.st_size;
   EXPECT_NOT_NULL(f1);
   EXPECT_NOT_NULL(f2);
@@ -79,17 +79,17 @@ static void test_chunk_compress_decompress_roundtrip() {
   file_load_data(f1);
   file_load_data(f2);
 
-  File* files[2] = {f1, f2};
-  Chunk* chunk = chunk_create(files, 2);
+  File *files[2] = {f1, f2};
+  Chunk *chunk = chunk_create(files, 2);
   EXPECT_NOT_NULL(chunk);
 
-  Data* compressed = chunk_compress(chunk, 3, false);
+  Data *compressed = chunk_compress(chunk, 3, false);
   EXPECT_NOT_NULL(compressed);
 
-  Data* decompressed_data = data_decompress(compressed);
+  Data *decompressed_data = data_decompress(compressed);
   EXPECT_NOT_NULL(decompressed_data);
 
-  Chunk* decompressed_chunk = chunk_deserialize(decompressed_data, false);
+  Chunk *decompressed_chunk = chunk_deserialize(decompressed_data, false);
   EXPECT_NOT_NULL(decompressed_chunk);
   EXPECT_EQ_INT(decompressed_chunk->element_count, 2);
 

tests/test_config.c

@@ -7,8 +7,8 @@
 #include <stdlib.h>
 
 static void test_config_lifecycle() {
-  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/dst"), true, true, false,
-                              false, false, 1, false, 0);
+  Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/dst"),
+                              true, true, false, false, false, 1, false, 0);
   EXPECT_NOT_NULL(cfg);
   EXPECT_EQ_STR(cfg->version, "1.0");
   EXPECT_EQ_STR(cfg->send_directory, "/src");
@@ -23,8 +23,8 @@ static void test_config_lifecycle() {
 }
 
 static void test_config_ssh_dest() {
-  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("user@host:/dst"), true,
-                              false, false, false, false, 1, false, 0);
+  Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("user@host:/dst"),
+                              true, false, false, false, false, 1, false, 0);
   EXPECT_NOT_NULL(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
   EXPECT_NULL(cfg->ssh_destination);
@@ -38,8 +38,8 @@ static void test_config_ssh_dest() {
 }
 
 static void test_config_ssh_dest_local_path() {
-  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/local/path"), true, false,
-                              false, false, false, 1, false, 0);
+  Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("/local/path"),
+                              true, false, false, false, false, 1, false, 0);
   config_parse_ssh_dest(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_TCP);
   EXPECT_NULL(cfg->ssh_destination);
@@ -48,8 +48,8 @@ static void test_config_ssh_dest_local_path() {
 }
 
 static void test_config_ssh_dest_no_user() {
-  Config* cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("host:/remote"), true, false,
-                              false, false, false, 1, false, 0);
+  Config *cfg = config_create(str_dup("1.0"), str_dup("/src"), str_dup("host:/remote"),
+                              true, false, false, false, false, 1, false, 0);
   config_parse_ssh_dest(cfg);
   EXPECT_EQ_INT(cfg->transport, TRANSPORT_SSH);
   EXPECT_EQ_STR(cfg->ssh_destination, "host:/remote");
@@ -58,12 +58,12 @@ static void test_config_ssh_dest_no_user() {
 }
 
 static void test_pipeline_sender_lifecycle() {
-  Config* cfg = config_create(str_dup("2.0"), str_dup("/src2"), str_dup("/dst2"), false, false,
-                              true, true, false, 1, false, 0);
-  Queue* q1 = queue_create(5, NULL);
-  Queue* q2 = queue_create(15, NULL);
+  Config *cfg = config_create(str_dup("2.0"), str_dup("/src2"),
+                              str_dup("/dst2"), false, false, true, true, false, 1, false, 0);
+  Queue *q1 = queue_create(5, NULL);
+  Queue *q2 = queue_create(15, NULL);
 
-  PipelineContextSender* pcs = pipeline_context_sender_create(cfg, q1, q2);
+  PipelineContextSender *pcs = pipeline_context_sender_create(cfg, q1, q2);
   EXPECT_NOT_NULL(pcs);
   EXPECT_EQ_STR(pcs->config->version, "2.0");
   EXPECT_EQ_INT(pcs->queue_scanner->capacity, 5);
@@ -75,11 +75,11 @@ static void test_pipeline_sender_lifecycle() {
 }
 
 static void test_pipeline_receiver_lifecycle() {
-  Config* cfg = config_create(str_dup("3.0"), str_dup("/src3"), str_dup("/dst3"), true, true, true,
-                              true, false, 1, false, 0);
-  Queue* q = queue_create(20, NULL);
+  Config *cfg = config_create(str_dup("3.0"), str_dup("/src3"),
+                              str_dup("/dst3"), true, true, true, true, false, 1, false, 0);
+  Queue *q = queue_create(20, NULL);
 
-  PipelineContextReceiver* pcr = pipeline_context_receiver_create(cfg, q, 42);
+  PipelineContextReceiver *pcr = pipeline_context_receiver_create(cfg, q, 42);
   EXPECT_NOT_NULL(pcr);
   EXPECT_EQ_STR(pcr->config->version, "3.0");
   EXPECT_EQ_INT(pcr->queue->capacity, 20);

tests/test_data.c

@@ -1,59 +0,0 @@
-#include "data.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <string.h>
-
-static void test_data_create() {
-  char* buf = malloc(6);
-  EXPECT_NOT_NULL(buf);
-  memcpy(buf, "hello", 6);
-  Data* d = data_create(buf, 6);
-  EXPECT_NOT_NULL(d);
-  EXPECT_NOT_NULL(d->data);
-  EXPECT_TRUE(d->data == buf);
-  EXPECT_EQ_INT((int)d->size, 6);
-  data_destroy(d);
-}
-
-static void test_data_create_empty() {
-  Data* d = data_create_empty(256);
-  EXPECT_NOT_NULL(d);
-  EXPECT_NOT_NULL(d->data);
-  EXPECT_EQ_INT((int)d->size, 256);
-  data_destroy(d);
-}
-
-static void test_data_create_empty_zero() {
-  Data* d = data_create_empty(0);
-  EXPECT_NOT_NULL(d);
-  EXPECT_NOT_NULL(d->data);
-  EXPECT_EQ_INT((int)d->size, 0);
-  data_destroy(d);
-}
-
-static void test_data_create_reserve() {
-  Data* d = data_create_reserve(1024);
-  EXPECT_NOT_NULL(d);
-  EXPECT_NULL(d->data);
-  EXPECT_EQ_INT((int)d->size, 1024);
-  data_destroy(d);
-}
-
-static void test_data_destroy_null() {
-  data_destroy(NULL);
-}
-
-static void test_data_destroy_normal() {
-  Data* d = data_create_empty(128);
-  EXPECT_NOT_NULL(d);
-  data_destroy(d);
-}
-
-void test_data() {
-  test_data_create();
-  test_data_create_empty();
-  test_data_create_empty_zero();
-  test_data_create_reserve();
-  test_data_destroy_null();
-  test_data_destroy_normal();
-}

tests/test_data.h

@@ -1,6 +0,0 @@
-#ifndef TEST_DATA_H
-#define TEST_DATA_H
-
-void test_data();
-
-#endif

tests/test_delta.c

@@ -1,341 +0,0 @@
-#include "test_utils.h"
-#include "delta.h"
-#include <string.h>
-#include <stdlib.h>
-
-static void test_adler32_basic() {
-  const char* data = "Hello";
-  uint32_t h = delta_adler32(data, 5);
-  EXPECT_TRUE(h != 0);
-  uint32_t h2 = delta_adler32(data, 5);
-  EXPECT_EQ_INT((int)h, (int)h2);
-}
-
-static void test_adler32_different_data() {
-  const char* a = "AAAA";
-  const char* b = "BBBB";
-  uint32_t ha = delta_adler32(a, 4);
-  uint32_t hb = delta_adler32(b, 4);
-  EXPECT_TRUE(ha != hb);
-}
-
-static void test_xxhash32_basic() {
-  const char* data = "Hello";
-  uint32_t h = delta_xxhash32(data, 5);
-  EXPECT_TRUE(h != 0);
-  uint32_t h2 = delta_xxhash32(data, 5);
-  EXPECT_EQ_INT((int)h, (int)h2);
-}
-
-static void test_xxhash32_different_data() {
-  const char* a = "AAAA";
-  const char* b = "BBBB";
-  uint32_t ha = delta_xxhash32(a, 4);
-  uint32_t hb = delta_xxhash32(b, 4);
-  EXPECT_TRUE(ha != hb);
-}
-
-static void test_signature_roundtrip() {
-  char old_data[4096];
-  for (int i = 0; i < 4096; i++)
-    old_data[i] = (char)(i % 256);
-
-  DeltaSignature* sig = delta_signature_create(old_data, 4096, 1024);
-  EXPECT_NOT_NULL(sig);
-  EXPECT_EQ_INT((int)sig->block_count, 4);
-  EXPECT_EQ_INT((int)sig->block_size, 1024);
-
-  Data* serialized = delta_signature_serialize(sig);
-  EXPECT_NOT_NULL(serialized);
-
-  DeltaSignature* deserialized = delta_signature_deserialize(serialized);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT((int)deserialized->block_count, (int)sig->block_count);
-  EXPECT_EQ_INT((int)deserialized->block_size, (int)sig->block_size);
-
-  for (uint32_t i = 0; i < sig->block_count; i++) {
-    EXPECT_EQ_INT((int)deserialized->blocks[i].adler32, (int)sig->blocks[i].adler32);
-    EXPECT_EQ_INT((int)deserialized->blocks[i].xxhash, (int)sig->blocks[i].xxhash);
-  }
-
-  delta_signature_destroy(sig);
-  data_destroy(serialized);
-  delta_signature_destroy(deserialized);
-}
-
-static void test_delta_identical_files() {
-  char data[2048];
-  for (int i = 0; i < 2048; i++)
-    data[i] = (char)(i % 128);
-
-  DeltaSignature* sig = delta_signature_create(data, 2048, 512);
-  EXPECT_NOT_NULL(sig);
-
-  Delta* delta = delta_compute(data, 2048, sig, 512);
-  EXPECT_NOT_NULL(delta);
-
-  bool has_match = false;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_BLOCK_MATCH) {
-      has_match = true;
-      break;
-    }
-  }
-  EXPECT_TRUE(has_match);
-
-  bool all_match = true;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type != DELTA_INSTR_BLOCK_MATCH) {
-      all_match = false;
-      break;
-    }
-  }
-  EXPECT_TRUE(all_match);
-
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_delta_small_edit() {
-  char old_data[4096];
-  char new_data[4096];
-  for (int i = 0; i < 4096; i++) {
-    old_data[i] = (char)(i % 256);
-    new_data[i] = old_data[i];
-  }
-  new_data[100] = 'X';
-  new_data[101] = 'Y';
-  new_data[102] = 'Z';
-
-  DeltaSignature* sig = delta_signature_create(old_data, 4096, 1024);
-  EXPECT_NOT_NULL(sig);
-
-  Delta* delta = delta_compute(new_data, 4096, sig, 1024);
-  EXPECT_NOT_NULL(delta);
-
-  uint64_t total_literal = 0;
-  uint32_t match_count = 0;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_LITERAL)
-      total_literal += delta->instructions[i].literal.length;
-    else
-      match_count++;
-  }
-  EXPECT_TRUE(match_count > 0);
-  EXPECT_TRUE(total_literal < 4096);
-
-  void* reconstructed = delta_apply(old_data, 4096, delta, 1024);
-  EXPECT_NOT_NULL(reconstructed);
-  EXPECT_EQ_INT(memcmp(reconstructed, new_data, 4096), 0);
-
-  free(reconstructed);
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_delta_completely_different() {
-  char old_data[4096];
-  char new_data[4096];
-  for (int i = 0; i < 4096; i++) {
-    old_data[i] = (char)(i * 7 + 3);
-    new_data[i] = (char)(i * 13 + 97);
-  }
-
-  DeltaSignature* sig = delta_signature_create(old_data, 4096, 1024);
-  EXPECT_NOT_NULL(sig);
-
-  Delta* delta = delta_compute(new_data, 4096, sig, 1024);
-  EXPECT_NOT_NULL(delta);
-
-  bool has_match = false;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_BLOCK_MATCH) {
-      has_match = true;
-      break;
-    }
-  }
-  EXPECT_TRUE(!has_match);
-  EXPECT_TRUE(!delta_is_worthwhile(delta, 4096));
-
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_delta_serialize_roundtrip() {
-  char old_data[4096];
-  char new_data[4096];
-  for (int i = 0; i < 4096; i++) {
-    old_data[i] = (char)(i % 256);
-    new_data[i] = old_data[i];
-  }
-  new_data[500] = 'A';
-  new_data[501] = 'B';
-
-  DeltaSignature* sig = delta_signature_create(old_data, 4096, 1024);
-  Delta* delta = delta_compute(new_data, 4096, sig, 1024);
-  EXPECT_NOT_NULL(delta);
-
-  Data* serialized = delta_serialize(delta);
-  EXPECT_NOT_NULL(serialized);
-
-  Delta* deserialized = delta_deserialize(serialized);
-  EXPECT_NOT_NULL(deserialized);
-  EXPECT_EQ_INT((int)deserialized->new_file_size, (int)delta->new_file_size);
-  EXPECT_EQ_INT((int)deserialized->instruction_count, (int)delta->instruction_count);
-
-  void* reconstructed = delta_apply(old_data, 4096, deserialized, 1024);
-  EXPECT_NOT_NULL(reconstructed);
-  EXPECT_EQ_INT(memcmp(reconstructed, new_data, 4096), 0);
-
-  free(reconstructed);
-  data_destroy(serialized);
-  delta_destroy(deserialized);
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_delta_file_growth() {
-  char old_data[2048];
-  char new_data[3072];
-  for (int i = 0; i < 2048; i++)
-    old_data[i] = (char)(i % 256);
-  memcpy(new_data, old_data, 2048);
-  for (int i = 2048; i < 3072; i++)
-    new_data[i] = (char)(i % 256);
-
-  DeltaSignature* sig = delta_signature_create(old_data, 2048, 512);
-  EXPECT_NOT_NULL(sig);
-
-  Delta* delta = delta_compute(new_data, 3072, sig, 512);
-  EXPECT_NOT_NULL(delta);
-
-  void* reconstructed = delta_apply(old_data, 2048, delta, 512);
-  EXPECT_NOT_NULL(reconstructed);
-  EXPECT_EQ_INT(delta->new_file_size, 3072);
-  EXPECT_EQ_INT(memcmp(reconstructed, new_data, 3072), 0);
-
-  free(reconstructed);
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_delta_file_shrink() {
-  char old_data[3072];
-  char new_data[2048];
-  for (int i = 0; i < 3072; i++)
-    old_data[i] = (char)(i % 256);
-  for (int i = 0; i < 2048; i++)
-    new_data[i] = old_data[i];
-
-  DeltaSignature* sig = delta_signature_create(old_data, 3072, 512);
-  EXPECT_NOT_NULL(sig);
-
-  Delta* delta = delta_compute(new_data, 2048, sig, 512);
-  EXPECT_NOT_NULL(delta);
-
-  void* reconstructed = delta_apply(old_data, 3072, delta, 512);
-  EXPECT_NOT_NULL(reconstructed);
-  EXPECT_EQ_INT(delta->new_file_size, 2048);
-  EXPECT_EQ_INT(memcmp(reconstructed, new_data, 2048), 0);
-
-  free(reconstructed);
-  delta_signature_destroy(sig);
-  delta_destroy(delta);
-}
-
-static void test_should_attempt() {
-  EXPECT_TRUE(delta_should_attempt(100000, 100000, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(!delta_should_attempt(100, 100, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(!delta_should_attempt(100000, 10, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(!delta_should_attempt(300000000, 300000000, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(delta_should_attempt(50000, 60000, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(!delta_should_attempt(50000, 600000, DELTA_MAX_FILE_SIZE));
-  EXPECT_TRUE(delta_should_attempt(50000, 60000, 500000));
-  EXPECT_TRUE(!delta_should_attempt(100000, 100000, 50000));
-}
-
-static void test_is_worthwhile() {
-  Delta d;
-  d.instruction_count = 1;
-  DeltaInstruction instr;
-  instr.type = DELTA_INSTR_BLOCK_MATCH;
-  d.instructions = &instr;
-
-  d.delta_size = 100;
-  EXPECT_TRUE(delta_is_worthwhile(&d, 1000));
-
-  d.delta_size = 800;
-  EXPECT_TRUE(!delta_is_worthwhile(&d, 1000));
-
-  d.instruction_count = 1;
-  instr.type = DELTA_INSTR_LITERAL;
-  EXPECT_TRUE(!delta_is_worthwhile(&d, 1000));
-
-  EXPECT_TRUE(!delta_is_worthwhile(NULL, 1000));
-}
-
-static void test_large_file_delta() {
-  uint32_t block_size = 8192;
-  uint64_t old_size = 200000;
-  uint64_t new_size = 200000;
-
-  void* old_data = malloc((size_t)old_size);
-  void* new_data = malloc((size_t)new_size);
-  EXPECT_TRUE(old_data != NULL && new_data != NULL);
-
-  for (uint64_t i = 0; i < old_size; i++)
-    ((uint8_t*)old_data)[i] = (uint8_t)(i % 251);
-  memcpy(new_data, old_data, (size_t)old_size);
-
-  uint64_t offset = 100000;
-  uint32_t change_len = 4096;
-  for (uint32_t i = 0; i < change_len; i++)
-    ((uint8_t*)new_data)[offset + i] = (uint8_t)((i * 7 + 13) % 256);
-
-  DeltaSignature* sig = delta_signature_create(old_data, old_size, block_size);
-  EXPECT_TRUE(sig != NULL);
-  EXPECT_TRUE(sig->block_count == (uint32_t)((old_size + block_size - 1) / block_size));
-
-  Delta* delta = delta_compute(new_data, new_size, sig, block_size);
-  EXPECT_TRUE(delta != NULL);
-
-  uint64_t total_literal = 0;
-  uint32_t match_count = 0;
-  for (uint32_t i = 0; i < delta->instruction_count; i++) {
-    if (delta->instructions[i].type == DELTA_INSTR_LITERAL)
-      total_literal += delta->instructions[i].literal.length;
-    else
-      match_count++;
-  }
-  EXPECT_TRUE(total_literal > 0);
-  EXPECT_TRUE(match_count > 0);
-  EXPECT_TRUE(delta->delta_size < new_size / 2);
-
-  void* result = delta_apply(old_data, old_size, delta, block_size);
-  EXPECT_TRUE(result != NULL);
-  EXPECT_TRUE(delta->new_file_size == new_size);
-  EXPECT_TRUE(memcmp(result, new_data, (size_t)new_size) == 0);
-
-  free(result);
-  delta_destroy(delta);
-  delta_signature_destroy(sig);
-  free(old_data);
-  free(new_data);
-}
-
-void test_delta() {
-  test_adler32_basic();
-  test_adler32_different_data();
-  test_xxhash32_basic();
-  test_xxhash32_different_data();
-  test_signature_roundtrip();
-  test_delta_identical_files();
-  test_delta_small_edit();
-  test_delta_completely_different();
-  test_delta_serialize_roundtrip();
-  test_delta_file_growth();
-  test_delta_file_shrink();
-  test_should_attempt();
-  test_is_worthwhile();
-  test_large_file_delta();
-}

tests/test_delta.h

@@ -1,6 +0,0 @@
-#ifndef TEST_DELTA_H
-#define TEST_DELTA_H
-
-void test_delta(void);
-
-#endif

tests/test_file.c

@@ -1,288 +0,0 @@
-#include "test_file.h"
-#include "file.h"
-#include "data.h"
-#include "utils.h"
-#include "protocol.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <string.h>
-#include <sys/stat.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-static void test_file_create() {
-  File* f = file_create("test_file_create.txt");
-  EXPECT_NOT_NULL(f);
-  EXPECT_NOT_NULL(f->path);
-  EXPECT_EQ_STR(f->path, "test_file_create.txt");
-  EXPECT_NOT_NULL(f->data);
-  EXPECT_NULL(f->data->data);
-  EXPECT_EQ_INT((int)f->data->size, 0);
-  EXPECT_NULL(f->metadata);
-  file_destroy(f);
-}
-
-static void test_file_destroy_null() {
-  file_destroy(NULL);
-}
-
-static void test_file_destroy_normal() {
-  File* f = file_create("test_destroy.txt");
-  EXPECT_NOT_NULL(f);
-  file_destroy(f);
-}
-
-static void test_file_load_data() {
-  const char* content = "Hello Load Test";
-  EXPECT_TRUE(to_disk("test_file_load_data.txt", content, strlen(content)));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_file_load_data.txt", &st), 0);
-
-  File* f = file_create("test_file_load_data.txt");
-  EXPECT_NOT_NULL(f);
-  f->data->size = st.st_size;
-
-  EXPECT_TRUE(file_load_data(f));
-  EXPECT_NOT_NULL(f->data->data);
-  EXPECT_EQ_INT((int)f->data->size, (int)st.st_size);
-  EXPECT_EQ_INT(memcmp(f->data->data, content, strlen(content)), 0);
-
-  file_destroy(f);
-  unlink("test_file_load_data.txt");
-}
-
-static void test_file_load_data_missing_file() {
-  File* f = file_create("nonexistent_test_file_xyz.txt");
-  EXPECT_NOT_NULL(f);
-  f->data->size = 10;
-  EXPECT_FALSE(file_load_data(f));
-  file_destroy(f);
-}
-
-static void test_file_save_to_disk() {
-  File* f = file_create("saved_file.txt");
-  EXPECT_NOT_NULL(f);
-  const char* content = "Save to disk content";
-  f->data->data = malloc(strlen(content));
-  EXPECT_NOT_NULL(f->data->data);
-  memcpy(f->data->data, content, strlen(content));
-  f->data->size = strlen(content);
-
-  EXPECT_TRUE(file_save_to_disk("test_save_tmp", f));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_save_tmp/saved_file.txt", &st), 0);
-
-  FILE* fp = fopen("test_save_tmp/saved_file.txt", "rb");
-  EXPECT_NOT_NULL(fp);
-  char buf[100];
-  size_t nread = fread(buf, 1, sizeof(buf), fp);
-  fclose(fp);
-  EXPECT_EQ_INT((int)nread, (int)strlen(content));
-  EXPECT_EQ_INT(memcmp(buf, content, strlen(content)), 0);
-
-  file_destroy(f);
-  unlink("test_save_tmp/saved_file.txt");
-  rmdir("test_save_tmp");
-}
-
-static void test_to_disk_basic() {
-  const char* content = "Basic to_disk test";
-  EXPECT_TRUE(to_disk("test_to_disk_basic.txt", content, strlen(content)));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_to_disk_basic.txt", &st), 0);
-  EXPECT_EQ_INT((int)st.st_size, (int)strlen(content));
-
-  FILE* fp = fopen("test_to_disk_basic.txt", "rb");
-  EXPECT_NOT_NULL(fp);
-  char buf[100];
-  size_t nread = fread(buf, 1, sizeof(buf), fp);
-  fclose(fp);
-  EXPECT_EQ_INT((int)nread, (int)strlen(content));
-  EXPECT_EQ_INT(memcmp(buf, content, strlen(content)), 0);
-
-  unlink("test_to_disk_basic.txt");
-}
-
-static void test_to_disk_creates_dirs() {
-  const char* content = "Nested dir test";
-  EXPECT_TRUE(to_disk("test_nested_tmp/nested/file.txt", content, strlen(content)));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_nested_tmp/nested/file.txt", &st), 0);
-
-  FILE* fp = fopen("test_nested_tmp/nested/file.txt", "rb");
-  EXPECT_NOT_NULL(fp);
-  char buf[100];
-  size_t nread = fread(buf, 1, sizeof(buf), fp);
-  fclose(fp);
-  EXPECT_EQ_INT((int)nread, (int)strlen(content));
-  EXPECT_EQ_INT(memcmp(buf, content, strlen(content)), 0);
-
-  unlink("test_nested_tmp/nested/file.txt");
-  rmdir("test_nested_tmp/nested");
-  rmdir("test_nested_tmp");
-}
-
-static void test_file_content_to_buffer() {
-  const char* content = "Buffer content test";
-  EXPECT_TRUE(to_disk("test_buffer_file.txt", content, strlen(content)));
-
-  File* f = file_create("test_buffer_file.txt");
-  EXPECT_NOT_NULL(f);
-  f->data->size = strlen(content);
-  f->data->data = malloc(f->data->size);
-  EXPECT_NOT_NULL(f->data->data);
-
-  size_t bytes_read = file_content_to_buffer(f);
-  EXPECT_EQ_INT((int)bytes_read, (int)strlen(content));
-  EXPECT_EQ_INT(memcmp(f->data->data, content, strlen(content)), 0);
-
-  file_destroy(f);
-  unlink("test_buffer_file.txt");
-}
-
-static void test_file_send_receive() {
-  File* file = file_create("test_send_recv.txt");
-  EXPECT_NOT_NULL(file);
-  const char* content = "Hello, File Send!";
-  size_t len = strlen(content);
-  file->data->data = malloc(len);
-  EXPECT_NOT_NULL(file->data->data);
-  memcpy(file->data->data, content, len);
-  file->data->size = len;
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, false, false, 0, false, 0);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (!received->path || strcmp(received->path, "test_send_recv.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_single_calls(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-static void test_file_send_no_path() {
-  File* file = file_create("test_no_path.txt");
-  EXPECT_NOT_NULL(file);
-  const char* content = "No Path Data";
-  size_t len = strlen(content);
-  file->data->data = malloc(len);
-  EXPECT_NOT_NULL(file->data->data);
-  memcpy(file->data->data, content, len);
-  file->data->size = len;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    // Read file type indicator
-    int file_type;
-    EXPECT_TRUE(receive_int(p[0], &file_type));
-    EXPECT_EQ_INT(file_type, (int)FILE_TYPE_REGULAR);
-    Data* received = receive_data(p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else if (received->size != len)
-      ok = false;
-    else if (memcmp(received->data, content, len) != 0)
-      ok = false;
-
-    data_destroy(received);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_single_calls(file, p[1], false, 0, false);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-static void test_file_metadata_create() {
-  EXPECT_TRUE(to_disk("test_meta_file.txt", "metadata test", 13));
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_meta_file.txt", &st), 0);
-
-  FileMetadata* m = file_metadata_create(&st);
-  EXPECT_NOT_NULL(m);
-  EXPECT_EQ_INT(m->mode, st.st_mode);
-  EXPECT_EQ_INT(m->uid, st.st_uid);
-  EXPECT_EQ_INT(m->gid, st.st_gid);
-  EXPECT_EQ_INT((int)m->mtime_sec, (int)st.st_mtime);
-
-  file_metadata_destroy(m);
-  unlink("test_meta_file.txt");
-}
-
-void test_file() {
-  test_file_create();
-  test_file_destroy_null();
-  test_file_destroy_normal();
-  test_file_load_data();
-  test_file_load_data_missing_file();
-  test_file_save_to_disk();
-  test_to_disk_basic();
-  test_to_disk_creates_dirs();
-  test_file_content_to_buffer();
-  if (!is_running_under_valgrind()) {
-    // Fork tests are skipped under valgrind because the parent process runs
-    // orders of magnitude slower than the child (parent is instrumented, child
-    // is not), which causes pipe-based protocol handshake timeouts. The parent
-    // process itself has zero valgrind errors -- the failures are all in the
-    // forked children where inherited allocations are reported as leaks.
-    test_file_send_receive();
-    test_file_send_no_path();
-  }
-  test_file_metadata_create();
-}

tests/test_file.h

@@ -1,6 +0,0 @@
-#ifndef TEST_FILE_H
-#define TEST_FILE_H
-
-void test_file();
-
-#endif

tests/test_file_sendfile.c

@@ -1,273 +0,0 @@
-#include "test_file_sendfile.h"
-#include "file.h"
-#include "config.h"
-#include "protocol.h"
-#include "utils.h"
-#include "test_utils.h"
-#include <stdlib.h>
-#include <string.h>
-#include <sys/stat.h>
-#include <sys/wait.h>
-#include <unistd.h>
-
-/* Test basic sendfile transfer: create a file, send it via file_send_sendfile,
- * receive via file_receive, and verify contents. */
-static void test_sendfile_basic() {
-  const char* content = "Hello from sendfile test!";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_basic.txt", content, len));
-
-  File* file = file_create("test_sendfile_basic.txt");
-  EXPECT_NOT_NULL(file);
-  /* Set the size so file_send_sendfile can report it */
-  file->data->size = len;
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    /* Child: receive */
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (!received->path || strcmp(received->path, "test_sendfile_basic.txt") != 0)
-        ok = false;
-      if (!received->data || received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    /* Parent: send via sendfile */
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_basic.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile with an empty file */
-static void test_sendfile_empty_file() {
-  const char* content = "";
-  size_t len = 0;
-  EXPECT_TRUE(to_disk("test_sendfile_empty.txt", content, len));
-
-  File* file = file_create("test_sendfile_empty.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 0;
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, false, false, 0, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (strcmp(received->path, "test_sendfile_empty.txt") != 0)
-        ok = false;
-      if (received->data->size != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_empty.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test error path: file does not exist on disk */
-static void test_sendfile_missing_file() {
-  File* file = file_create("nonexistent_sendfile_test_file.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = 100; /* fake size */
-
-  /* Use a pipe that we can write to but sendfile should fail */
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  /* file_send_sendfile will try to open the nonexistent file -> should return false */
-  bool sent = file_send_sendfile(file, p[1], false, 0, true);
-
-  close(p[0]);
-  close(p[1]);
-  file_destroy(file);
-
-  EXPECT_FALSE(sent);
-}
-
-/* Test compression level > 0 falls back to file_send_single_calls */
-static void test_sendfile_compression_fallback() {
-  const char* content = "Compression fallback content";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_comp.txt", content, len));
-
-  struct stat st;
-  EXPECT_EQ_INT(stat("test_sendfile_comp.txt", &st), 0);
-
-  File* file = file_create("test_sendfile_comp.txt");
-  EXPECT_NOT_NULL(file);
-  /* Load the file data into memory (required by file_send_single_calls fallback) */
-  file->data->size = (size_t)st.st_size;
-  EXPECT_TRUE(file_load_data(file));
-
-  Config* cfg = config_create(str_dup(PROTOCOL_VERSION), str_dup("/tmp"), str_dup("/tmp"), false,
-                              false, false, true, false, 3, false, 0);
-  EXPECT_NOT_NULL(cfg);
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    File* received = file_receive(cfg, p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else {
-      if (received->data->size != len)
-        ok = false;
-      else if (memcmp(received->data->data, content, len) != 0)
-        ok = false;
-    }
-    file_destroy(received);
-    config_delete(cfg);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    /* compression_level = 3 triggers fallback to file_send_single_calls */
-    bool sent = file_send_sendfile(file, p[1], false, 3, true);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    config_delete(cfg);
-    unlink("test_sendfile_comp.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-/* Test sendfile without path (send_path = false) */
-static void test_sendfile_no_path() {
-  const char* content = "No path sendfile test";
-  size_t len = strlen(content);
-  EXPECT_TRUE(to_disk("test_sendfile_nopath.txt", content, len));
-
-  File* file = file_create("test_sendfile_nopath.txt");
-  EXPECT_NOT_NULL(file);
-  file->data->size = len;
-
-  int p[2];
-  EXPECT_EQ_INT(pipe(p), 0);
-  io_set_fds(p[0], p[1]);
-  io_set_bwlimit(0);
-
-  pid_t pid = fork();
-  if (pid == 0) {
-    close(p[1]);
-    /* Read file type indicator */
-    int file_type;
-    EXPECT_TRUE(receive_int(p[0], &file_type));
-    EXPECT_EQ_INT(file_type, (int)FILE_TYPE_REGULAR);
-    Data* received = receive_data(p[0]);
-    close(p[0]);
-
-    bool ok = true;
-    if (!received)
-      ok = false;
-    else if (received->size != len)
-      ok = false;
-    else if (memcmp(received->data, content, len) != 0)
-      ok = false;
-
-    data_destroy(received);
-    _exit(ok ? 0 : 1);
-  } else {
-    close(p[0]);
-    bool sent = file_send_sendfile(file, p[1], false, 0, false);
-    close(p[1]);
-
-    int status;
-    waitpid(pid, &status, 0);
-
-    file_destroy(file);
-    unlink("test_sendfile_nopath.txt");
-
-    EXPECT_TRUE(sent);
-    EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
-  }
-}
-
-void test_file_sendfile() {
-  if (!is_running_under_valgrind()) {
-    // Fork tests are skipped under valgrind because the parent process runs
-    // orders of magnitude slower than the child (parent is instrumented, child
-    // is not), which causes pipe-based protocol handshake timeouts. The parent
-    // process itself has zero valgrind errors -- the failures are all in the
-    // forked children where inherited allocations are reported as leaks.
-    test_sendfile_basic();
-    test_sendfile_empty_file();
-    test_sendfile_compression_fallback();
-    test_sendfile_no_path();
-  }
-  test_sendfile_missing_file(); // no fork, safe under valgrind
-}