19 Commits

Author	SHA1	Message	Date
TapTap	15a861747a	style: apply clang-format	2026-07-30 19:16:36 +02:00
TapTap	80768d64d4	fix: security issues #192 #191 #190 #189 #188 #187	2026-07-30 18:49:25 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	23b1d6660c	fix: reformat codebase and fix const-correctness for CI lint ... - Reformat all C/H files to match .clang-format (LLVM style) - Fix 26 cppcheck const-correctness warnings (constParameterPointer, constVariablePointer, constVariable) - Update function declarations in headers to match const parameters	2026-07-19 15:57:31 +02:00
TapTap	7876721906	refactor: extract receive_chunk_data and receive_manifest shared helpers ... - receive_chunk_data(fd, config) -> Chunk*: shared receive/decompress/deserialize (eliminates ~25 lines of duplication between server.c and multiprocessing.c) - receive_manifest(fd, config, next_status): moved from server.c to file.c, fixes missing 'Deleting files not in manifest...' log in multiprocessing.c - Removes redundant manual free loop in multiprocessing.c manifest handling (array_list_create(free) destructor already handles this) - server.c and multiprocessing.c: remove local chunk/manifest helpers, remove compression.h include (no longer needed)	2026-07-18 17:19:12 +02:00
TapTap	bbdf027be8	Fix exit() in library code, add --include/--max-size/--min-size	2026-07-16 14:15:38 +02:00
TapTap	8f4ea62ae7	Phase 1+2: bug fixes and dead code cleanup ... Phase 1 — Bugs: - receive_data: fix unsigned long long vs size_t mismatch - chunk_deserialize: add NULL check in multiprocessing.c and server.c - file_content_to_buffer: add missing fclose on error path - send_files_multithreaded: propagate sender thread result - server: add SIGPIPE handler - to_disk: check fwrite return value - scanner: use S_ISDIR instead of !S_ISREG - scanner: free cur_path before early return Phase 2 — Cleanup: - Remove unused chunk_decompress function - Remove unused array_list_clear function - Remove unused num_connections config field - Remove duplicate FILE_METADATA_WIRE_SIZE macro - Update tests for removed APIs	2026-07-16 12:08:09 +02:00
TapTap	02619cca5c	refactor: split monolithic modules and extract shared components ... - Remove dead socket.c/socket.h (accumulated duplicate symbols) - Extract compression.h/c (data_compress/decompress from data.c) - Extract io.h/c (low-level I/O from protocol.c) - Extract metadata.h/c (unified metadata wire format from file.c, chunk.c, utils.c) - Split client.c into client_cli.c (CLI parsing) + client_send.c (send logic) - Move receiver pipeline threads from server.c to multiprocessing.c - Move to_disk/file_restore_metadata from utils.c to file.c/metadata.c - Fix const qualifiers on to_disk and str_dup signatures - Suppress chown unused-result warning	2026-07-15 19:36:26 +02:00
TapTap	b3f69208ce	cleanup: remove dead code, fix bugs, refactor SSH dest parsing ... - Remove debug printf calls from file.c - Remove dead code: chunk_print, chunk_format, chunk_data_create/delete - Remove unused config.use_single_send_per_file field - Fix server_delete() no-op (double-pointer) - Fix double cast (long)(long) -> ptrdiff_t in chunk.c - Fix thread return value: thrd_error instead of 1 - Remove unused config param from receive_chunk_enqueue() - Make queue_double_capacity() static - Move SSH dest parsing into config.c as config_parse_ssh_dest() - Fix test_config_ssh_dest to test parsing round-trip - Remove chunk_format test (obsolete format) - Replace chunk_data_delete with data_destroy in tests	2026-07-07 19:07:24 +02:00
TapTap	5fa0dc11e1	fix: address PR review comments ... - Rename receive_file_receive -> file_receive (comment 62) - Guard metadata receive with config->use_metadata in server.c (comment 63) - Add NULL check after malloc in file_load_data (comment 66) - Make chunk_serialize/chunk_deserialize metadata conditional on use_metadata param, thread through chunk_compress/chunk_decompress (comment 65) - Add missing stdbool.h include to chunk.h	2026-07-05 20:45:34 +02:00
TapTap	4a1e666365	refactor: merge File/FileReceive, add optional metadata transfer with -M flag ... - Remove FileReceive struct; use File everywhere with nullable FileMetadata* - Remove struct stat from File; file size lives in Data->size (data_create_reserve) - Add FileMetadata struct (mode, uid, gid, mtime) sent conditionally over wire - Add -M / --preserve flag to client - Restore permissions, ownership, timestamps on disk write - Wire format uses per-file present flag for metadata (zero overhead when off)	2026-07-05 20:21:46 +02:00
TapTap	c4aeed9f4d	feat: implement chunk serialization protocol with -s flag ... - Extract chunk_serialize/chunk_deserialize from chunk_compress/chunk_decompress - Add STATUS_CHUNK to wire protocol for chunk-mode transfers - Client: -s sends chunk via STATUS_CHUNK (serialized or compressed+serialized) - Server: handle STATUS_CHUNK in both single-threaded and multithreaded paths - Fix memory leak in receive_file_receive (free->data_destroy) - Remove dead declarations: file_receive_from_buffer, file_receive_decompress, file_compress, chunk_data_to_disk, unused #defines	2026-07-04 21:38:46 +02:00
TapTap	43c0a1395d	Add compression and scanner tests; fix chunk_decompress data ownership bug, data_destroy NULL safety, chunk_compress memory leak	2026-07-04 21:25:34 +02:00
TapTap	1486ac7088	fix: chunk_decompress compilation, chunk_compress data ptr, chunk_format serialization, file_destroy leak, test_chunk memcmp	2026-07-04 21:02:59 +02:00
TapTap	e6c55356c8	Fix critical issues: implement chunk_decompress and fix file descriptor check in server_listen	2026-07-04 20:24:16 +02:00
Theo Tappe	4d6171d6bf	fix: bring project back to a working state	2026-07-04 17:55:03 +02:00
Theo Tappe	75d5f91c6a	add data compression and decompression	2026-06-14 16:52:07 +00:00
Theo Tappe	1e5eeb704f	First Commit	2026-06-10 16:58:35 +02:00