196 Commits

Include renames

Author	SHA1	Message	Date
TapTap	2234879b2f	fix: #258 normalize mode and truncate on --inplace overwrite ... The --inplace branch opened the destination with O_WRONLY|O_CREAT (no O_TRUNC) and only restored metadata when the sender supplied it. Two flaws resulted: 1. An existing destination file kept its original mode when no metadata was sent, so setuid/setgid/sticky bits survived an overwrite (a root sync could leave a root-owned setuid binary controlled by a client). 2. A shorter payload left stale trailing bytes from the previous version because the file was never truncated to the new length. In the inplace branch of file_to_disk_secure_impl: - Always trim the file to the new payload length (ftruncate after the write) so stale trailing bytes can never survive; sparse targets keep their pre-size ftruncate. - Always normalize the mode after a successful overwrite: apply the metadata-derived safe mode when metadata is present (as before), else fchmod to a safe default 0644, so setuid/setgid/sticky are cleared in both cases. - The --update newer-destination check still runs before any truncation or chmod, preserving the skip semantics. Adds unit tests in test_file.c: (a) setuid/sticky bits on an existing destination are cleared after an inplace write with and without metadata, (b) a shorter inplace payload leaves no trailing stale bytes.	2026-09-05 12:29:46 +02:00
TapTap	98120fc722	fix: #254 bound receiver queue by aggregate payload bytes ... The per-connection memory budget (MAX_CONNECTION_MEMORY, 256 MiB) only charged wire buffers via receive_data_limited. Decompression buffers and per-file chunk copies were not accounted for, and the multithreaded receiver could enqueue up to 100 files (each up to 64 MiB uncompressed) ahead of a slow disk writer, retaining ~6.4 GiB per connection. A client sending highly compressible chunks with little bandwidth could OOM the host while the reserve never tripped. Bound the receive pipeline by aggregate payload bytes instead of item count alone: - Export MAX_CONNECTION_MEMORY from protocol.h. - PipelineContextReceiver tracks queued_bytes (payload bytes received but not yet released by the disk writer, i.e. queued or in the writer's hand) under the existing mutex. - receiver enqueue now blocks while the queue is full by count OR when adding the file would push queued_bytes over the configured byte limit, applying backpressure to the sender instead of failing the transfer. - The disk writer releases the byte budget after each file is freed and signals the not-full condition. - The server sets the byte ceiling to MAX_CONNECTION_MEMORY - 2*MAX_CHUNK_SIZE so that the queued payloads plus the transient wire/decompression buffers of the one in-flight chunk stay within the per-connection budget. The single-threaded receive path is already bounded: it writes files to disk before reading the next chunk, so its transient is at most one chunk's wire + decompressed + copied payload (~3 * MAX_CHUNK_SIZE, below the budget). Wire buffers remain charged exactly once by receive_data_limited; this change does not double charge them. Adds a deterministic unit test in test_multiprocessing.c proving that an enqueue which would exceed the byte budget blocks until the writer releases bytes.	2026-09-05 12:29:41 +02:00
TapTap	9f8b58893b	Apply clang-format 18 to merge-conflict resolution code ... The Phase 1 merge conflict resolutions introduced formatting that failed the CI lint job (clang-format 18.1.3). Reformatted with the exact CI version; no functional changes.	2026-09-05 10:57:41 +02:00
TapTap	48dfd5dfa0	Fix incremental skip regression from modify-window nsec comparison ... metadata_mtime_matches() required exact nanosecond equality at the default modify_window=0, but destination write-time nsecs never match source creation-time nsecs unless -M preserves metadata. Compare whole seconds (rsync's default quick-check) at window 0; keep the subsecond-refined tolerance for explicit window values.	2026-09-05 10:43:58 +02:00
TapTap	8384a1997b	Merge remote-tracking branch 'origin/feat/rsync-delete-during-alias' into dev	2026-09-05 02:53:59 +02:00
TapTap	a1981a78ad	Merge remote-tracking branch 'origin/feat/rsync-old-dirs-aliases' into dev	2026-09-05 02:48:48 +02:00
TapTap	b5646a0b9e	Merge remote-tracking branch 'origin/feat/rsync-checksum-choice-alias' into dev	2026-09-05 02:44:04 +02:00
TapTap	c6a341bd1e	Merge remote-tracking branch 'origin/feat/rsync-partial-progress' into dev	2026-09-05 02:39:03 +02:00
TapTap	c1e9509f16	Merge remote-tracking branch 'origin/feat/rsync-old-args' into dev	2026-09-05 02:34:29 +02:00
TapTap	8689778233	Merge remote-tracking branch 'origin/feat/rsync-no-options' into dev	2026-09-05 02:30:50 +02:00
TapTap	cf0d10fccb	Merge remote-tracking branch 'origin/feat/rsync-info' into dev	2026-09-05 02:25:36 +02:00
TapTap	90112a7585	Merge remote-tracking branch 'origin/feat/max-alloc' into dev	2026-09-05 02:13:35 +02:00
TapTap	3304541337	Merge remote-tracking branch 'origin/feat/compress-threads' into dev	2026-09-05 02:01:43 +02:00
TapTap	6a95efbe41	Merge remote-tracking branch 'origin/feat/skip-compress' into dev	2026-09-04 18:35:19 +02:00
TapTap	3b013bf9d2	Merge remote-tracking branch 'origin/feat/rsync-compression-aliases' into dev	2026-09-04 18:24:21 +02:00
TapTap	4f21498ee6	Merge remote-tracking branch 'origin/feat/chmod' into dev	2026-09-04 18:20:08 +02:00
TapTap	315e572d18	Merge remote-tracking branch 'origin/feat/executability' into dev	2026-09-04 18:13:34 +02:00
TapTap	55172ff6de	Merge remote-tracking branch 'origin/feat/ignore-existing' into dev	2026-09-04 17:59:50 +02:00
TapTap	c650f9a3d0	Merge remote-tracking branch 'origin/feat/existing' into dev	2026-09-04 17:50:55 +02:00
TapTap	192aff8c46	Merge remote-tracking branch 'origin/feat/update' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/shared/file.c # src/shared/file.h # src/shared/file_receive.c # tests/test_client_cli.c	2026-09-04 17:44:07 +02:00
TapTap	6d10116d50	Merge remote-tracking branch 'origin/feat/modify-window' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # src/shared/file_receive.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:40:16 +02:00
TapTap	e42df1bde3	Merge remote-tracking branch 'origin/feat/size-only' into dev ... # Conflicts: # src/client/client_cli.c # src/client/usage.c # src/server/receiver.c # src/server/server.c # src/shared/config.c # src/shared/config.h # tests/integration/test_features.py # tests/test_config.c	2026-09-04 17:30:14 +02:00
TapTap	9fc1e72972	Merge remote-tracking branch 'origin/feat/ignore-times' into dev ... # Conflicts: # src/shared/config.c # tests/integration/test_features.py # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:27:04 +02:00
TapTap	71f1529222	Merge remote-tracking branch 'origin/feat/whole-file' into dev ... # Conflicts: # tests/test_client_cli.c # tests/test_config.c	2026-09-04 17:24:22 +02:00
TapTap	2adfa5a03b	Merge remote-tracking branch 'origin/feat/rsync-secluded-args' into dev ... # Conflicts: # RSYNC_COMPAT.md # tests/test_client_cli.c	2026-09-04 17:22:53 +02:00
TapTap	47d1cbdae8	Merge remote-tracking branch 'origin/feat/rsync-debug' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_cli.c # src/client/usage.c # src/shared/log.h # src/shared/protocol.c	2026-09-04 17:21:48 +02:00
TapTap	b59139589d	Merge remote-tracking branch 'origin/feat/rsync-stderr-mode' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/shared/log.c # src/shared/log.h # tests/test_client_cli.c	2026-09-04 17:20:36 +02:00
TapTap	49e4af275f	Merge remote-tracking branch 'origin/feat/8-bit-output' into dev ... # Conflicts: # src/client/client_cli.c # src/client/client_send.c # src/shared/config.c # tests/test_client_cli.c # tests/test_config.c # tests/test_shared_utils.c	2026-09-04 17:18:01 +02:00
TapTap	8e1bc9bb9c	Merge remote-tracking branch 'origin/feat/human-readable' into dev ... # Conflicts: # RSYNC_COMPAT.md # src/client/client_send.c # tests/test_client_cli.c	2026-09-04 17:16:24 +02:00
TapTap	421a94773f	Merge remote-tracking branch 'origin/feat/quiet' into dev ... # Conflicts: # src/client/client_send.c	2026-09-04 17:14:45 +02:00
TapTap	ead4651d12	Merge remote-tracking branch 'origin/feat/remove-source-files' into dev	2026-09-04 17:14:23 +02:00
TapTap	638d953b1d	fix: bump protocol version for max alloc wire format	2026-09-04 02:29:06 +02:00
TapTap	04cea295b5	fix: enforce max alloc in delta deserialization	2026-09-04 02:25:26 +02:00
TapTap	820afd334a	fix: reject malformed max-alloc sizes	2026-09-04 02:22:00 +02:00
TapTap	2f553a2a43	fix: honor explicit protocol allocation sessions	2026-09-04 02:18:44 +02:00
TapTap	f990e86309	fix: make protocol allocation accounting atomic	2026-09-04 02:12:22 +02:00
TapTap	0d306940e1	fix: bind allocation sessions in worker threads	2026-09-04 01:56:34 +02:00
TapTap	aab45873ac	test: cover compression option equals forms	2026-09-03 22:47:41 +02:00
TapTap	605f79a450	fix: make rsync info none override verbose	2026-09-03 22:44:44 +02:00
TapTap	066c7ed1af	fix: address 8-bit output re-review findings	2026-09-03 22:40:30 +02:00
TapTap	9f23b23893	fix: clarify unsupported directory option diagnostics	2026-09-03 22:32:09 +02:00
TapTap	2ace6416a7	test: cover configured fsync save path	2026-09-03 22:29:40 +02:00
TapTap	e491e811e3	fix: enforce max alloc across protocol workers	2026-09-03 22:26:29 +02:00
TapTap	ec02ee6dde	fix: bound compression worker threads	2026-09-03 22:22:04 +02:00
TapTap	98cbf3495d	fix: complete skip-compress protocol handling	2026-09-03 22:19:00 +02:00
TapTap	245a34fa11	fix: guard source removal against file replacement	2026-09-03 22:11:18 +02:00
TapTap	68aaf89da7	fix: address update option review findings	2026-09-03 21:59:55 +02:00
TapTap	e37d5b9438	fix: address modify-window review findings	2026-09-03 21:54:46 +02:00
TapTap	5b8cdf457b	fix: bump protocol version for size-only field	2026-09-03 21:51:29 +02:00
TapTap	1ebe261e05	fix: complete ignore-times incremental handling	2026-09-03 21:49:10 +02:00