389 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
TapTap	86247fe2b5	ci: trigger CI on PR	2026-07-20 19:48:32 +02:00
TapTap	788d3c7bea	ci: trigger CI on PR	2026-07-20 19:48:31 +02:00
TapTap	7ecba4e0d5	fix: adapt tests and fix bugs from enhancements rebase onto main ... - Fix transport_tcp.c: initialize server->ssl_ctx to NULL (prevents SSL_CTX_free on garbage when server_create_tls fails) - Fix test_transport_tcp.c: client_create now sets fd=-1, family=AF_UNSPEC - Fix test_transport_tcp.c: server address family may be AF_INET or AF_INET6 - Fix test_file_sendfile.c: send_path=false protocol includes file_type prefix	2026-07-20 19:42:53 +02:00
TapTap	16376bcafc	fix: add unit test coverage — issues #71, #63, #62, #56, #55	2026-07-20 19:38:49 +02:00
TapTap	d75701270d	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 19:38:45 +02:00
TapTap	990c4362af	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 19:38:43 +02:00
TapTap	6b8979a040	Merge pull request 'Revert all 6 merged PRs (#80-#85)' (#86) from revert-merged-prs into main ... Reviewed-on: #86	2026-07-20 19:37:23 +02:00
TapTap	bcf5ffcf40	Revert "Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main" ... This reverts commit ddfdb3825a, reversing changes made to 504a3a4d4f.	2026-07-20 19:36:09 +02:00
TapTap	5049a7bbf0	Revert "Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main" ... This reverts commit df0f52ce39, reversing changes made to ddfdb3825a.	2026-07-20 19:36:09 +02:00
TapTap	e6e8679bfc	Revert "Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main" ... This reverts commit 28d076fc28, reversing changes made to df0f52ce39.	2026-07-20 19:36:09 +02:00
TapTap	6831e7e6fb	Revert "Merge pull request 'Add unit test coverage (#71, #63, #62, #56, #55)' (#83) from fix/test-coverage into main" ... This reverts commit 12ca4b13c8, reversing changes made to 28d076fc28.	2026-07-20 19:36:09 +02:00
TapTap	e3484939b6	Revert "Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main" ... This reverts commit 8f25f6a6b6, reversing changes made to 12ca4b13c8.	2026-07-20 19:36:09 +02:00
TapTap	2f9a4fac78	Revert "Merge pull request 'Fix integration issues: ssl_ctx init + test API updates' (#85) from fix/integration-cleanup into main" ... This reverts commit e1f9ba090f, reversing changes made to 8f25f6a6b6.	2026-07-20 19:36:09 +02:00
TapTap	e1f9ba090f	Merge pull request 'Fix integration issues: ssl_ctx init + test API updates' (#85) from fix/integration-cleanup into main	2026-07-20 19:34:20 +02:00
TapTap	f6b4d89a3c	fix: initialize ssl_ctx in server_create, update tests for sockaddr_storage API	2026-07-20 19:34:12 +02:00
TapTap	8f25f6a6b6	Merge pull request 'Features and enhancements (#70, #36, #34, #33, #32, #57, #40, #37)' (#84) from fix/enhancements into main	2026-07-20 19:31:59 +02:00
TapTap	2dd40d6a5b	fix: features and enhancements — issues #70, #36, #34, #33, #32, #57, #40, #37	2026-07-20 19:28:17 +02:00
TapTap	12ca4b13c8	Merge pull request 'Add unit test coverage (#71, #63, #62, #56, #55)' (#83) from fix/test-coverage into main	2026-07-20 19:13:35 +02:00
TapTap	2fed5dddaa	fix: add unit test coverage — issues #71, #63, #62, #56, #55	2026-07-20 19:12:45 +02:00
TapTap	28d076fc28	Merge pull request 'Fix logic/correctness bugs (#73, #68, #67, #66, #59, #58, #54, #48, #53)' (#82) from fix/logic-correctness into main	2026-07-20 19:05:02 +02:00
TapTap	4383caa3bb	fix: logic/correctness bugs — issues #73, #68, #67, #66, #59, #58, #54, #48, #53	2026-07-20 19:04:35 +02:00
TapTap	df0f52ce39	Merge pull request 'Fix refactoring and portability issues (#61, #51, #52)' (#81) from fix/refactoring into main	2026-07-20 18:59:19 +02:00
TapTap	c2ddda26ad	fix: refactoring and portability — issues #61, #51, #52	2026-07-20 18:58:48 +02:00
TapTap	ddfdb3825a	Merge pull request 'Fix memory/null safety bugs (#74, #72, #69, #64, #60, #50, #49, #65)' (#80) from fix/memory-safety into main	2026-07-20 18:56:44 +02:00
TapTap	4dbb2b4f8b	fix: memory/null safety bugs — issues #74, #72, #69, #64, #60, #50, #49, #65	2026-07-20 18:56:22 +02:00
TapTap	504a3a4d4f	Merge pull request 'Fix 11 Gitea issues — bugs, quality, security, and refactoring' (#47) from fix/gitea-issues into main ... Reviewed-on: #47	2026-07-20 17:51:22 +02:00
TapTap	6a5a61b59f	fix: address all remaining review warnings and style issues ... - config.h: bump PROTOCOL_VERSION from "1.2.0" to "1.3.0" (WARNING-1) - client_cli.c: fix realloc leak on exclude/include patterns (WARNING-2) - file.c: document sendfile fallback as safety net only (WARNING-4) - metadata.c: add warning log for utimensat failure (WARNING-5/STYLE-1) - utils.c: fix is_dir_in_manifest false prefix match (WARNING-1) - utils.c: fix double rmdir on recursive collapse, add errno.h (WARNING-2) - client_send.c: guard unchecked send calls for manifest/finished (WARNING-3) - client_send.c: send STATUS_NEXT on rc==2 without delta (WARNING-4)	2026-07-20 17:48:03 +02:00
TapTap	fd7e98cb25	fix: config_receive uninitialized server_host (CRITICAL-2) & protocol desync on sendfile+delta (CRITICAL-5)	2026-07-20 17:32:49 +02:00
TapTap	b71d132b17	Merge pull request 'ci: fix double CI runs on PR pushes' (#75) from fix/ci-double-trigger into main ... Reviewed-on: #75	2026-07-20 17:32:03 +02:00
TapTap	e7634f6581	chore: load AGENTS.md as instructions and block direct pushes to main	2026-07-20 17:27:32 +02:00
TapTap	00b6f2064b	ci: only trigger push on main to avoid double CI runs	2026-07-20 17:26:58 +02:00
TapTap	41e814ad97	fix: cppcheck const warning & update architect agent with CI-wait instructions	2026-07-20 17:21:19 +02:00
TapTap	9e1afd0764	fix: const-qualify dir_result to fix cppcheck style warning	2026-07-20 17:20:21 +02:00
TapTap	e2d8659d94	fix: clang-format formatting issues in client_send.c and file.c	2026-07-20 17:17:42 +02:00
TapTap	0d7cb7230d	fix: remove use-after-free in transport_ssh.c child process ... remote_dest_destroy(&r) was called before r.user and r.host were accessed to build the SSH username string. Since the child process _exit()s, memory cleanup is unnecessary there.	2026-07-20 17:14:57 +02:00
TapTap	38be7c090a	Fix 11 Gitea issues (#29, #30, #31, #35, #38, #41, #42, #43, #44, #45, #46) ... #29 - compression_level now used in data_compress() #30 - chunk_size no longer truncated to 32-bit #31 - chmod/chown failures now logged #35 - strtok -> strtok_r for thread safety #38 - open_next_directory returns -1 on opendir failure #41 - file_send_sendfile uses compression_level param #42 - dirname() uses copy to avoid modifying input #43 - delete_extras_walk checks manifest before rmdir #44 - server_host/port moved into Config struct #45 - SSH parse_remote_dest uses dynamic allocation #46 - send_chunk refactored, reduced nesting/duplication	2026-07-20 17:09:12 +02:00
TapTap	5fe89eb49f	Merge pull request 'testing: add comprehensive test suite for test-driven development' (#25) from testing/comprehensive-test-suite into main ... Reviewed-on: #25	2026-07-20 17:05:44 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	ed6242cfc5	ci: bump CI image to v9 with libclang-rt-18-dev ... v8 had cached image without libclang-rt-18-dev on CI runner. v9 forces a fresh pull and includes all fuzzer runtime libraries.	2026-07-20 14:44:41 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	7c6e69ad81	ci: install lcov and valgrind in CI jobs ... The fastsync-ci:v7 container does not include lcov or valgrind. Add apt-get install steps to the coverage and valgrind jobs. Also update lcov flags for lcov 2.x compatibility: --rc lcov_branch_coverage=1 -> --branch-coverage	2026-07-20 14:44:41 +02:00
TapTap	51a984871c	Merge pull request 'Improve agentic workflow — CI rules, branch strategy, deprecation rules, and new agents' (#28) from improve-agentic-workflow into main ... Reviewed-on: #28	2026-07-20 14:44:35 +02:00
TapTap	66d994f01b	fix: resolve cppcheck warnings in new test files ... - Remove unused ConsumerCtx struct in test_stress.c - Add const qualifiers to variables only checked for NULL in test_metadata.c, test_protocol.c, test_robustness.c	2026-07-20 14:44:35 +02:00
TapTap	44d0f99de9	style: fix clang-format violations in test files ... Fix line wrapping and designated initializer alignment in test_file.c, test_protocol.c, and test_stress.c to pass CI clang-format check.	2026-07-20 14:44:35 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00
TapTap	91071a4ed5	Merge branch 'main' into improve-agentic-workflow	2026-07-20 14:42:03 +02:00
TapTap	afa5aeca37	Merge pull request 'feat: update AI automation agents, add reviewer agent, enhance CI' (#26) from feat/ai-automation-updates into main ... Reviewed-on: #26	2026-07-20 14:38:51 +02:00
TapTap	6501b15574	fix: set issue-creator mode to subagent, move into .opencode/agents/	2026-07-20 14:34:20 +02:00