28 Commits

Author	SHA1	Message	Date
TapTap	4534284fe9	fix: complete triage security and transfer remediation	2026-08-08 20:35:29 +02:00
TapTap	e876055167	fix: remove Gitea Actions agent workflows (agents run locally, not in CI)	2026-07-30 18:25:45 +02:00
TapTap	3d2eb97205	ci: add automated agent workflows — review, fix, maintenance, batch-merge	2026-07-30 18:24:29 +02:00
TapTap	00b6f2064b	ci: only trigger push on main to avoid double CI runs	2026-07-20 17:26:58 +02:00
TapTap	3f73012b36	fix: address re-review — coverage build, chunk OOB guard, UBSan loads, srand scope ... - Remove -DSTRICT_WARNINGS=ON from coverage job (_FORTIFY_SOURCE + -O0 + -Werror fatal) - Fix chunk.c metadata guard: peek at present flag before calling metadata_from_buf so the remaining_size check covers the full sizeof(int)+FILE_METADATA_WIRE_SIZE - Fix chunk.c UBSan misaligned loads: use memcpy instead of *(size_t*)deref - Move srand(42) to test_property() top level so all property tests are seeded	2026-07-20 14:53:39 +02:00
TapTap	ed6242cfc5	ci: bump CI image to v9 with libclang-rt-18-dev ... v8 had cached image without libclang-rt-18-dev on CI runner. v9 forces a fresh pull and includes all fuzzer runtime libraries.	2026-07-20 14:44:41 +02:00
TapTap	a27f13d657	fix: bake CI deps into Docker image, fix chunk use_metadata OOB ... - Build and push fastsync-ci:v8 with lcov, valgrind, clang baked in - Remove all apt-get install steps from CI (v8 has them pre-installed) - Fix chunk.c use_metadata=true OOB: add remaining_size guard before metadata_from_buf reads past the buffer. The bug allowed network-facing chunk_deserialize to heap-buffer-overflow on crafted inputs. - Also guard against unsigned underflow on remaining_size - sizeof(int)	2026-07-20 14:44:41 +02:00
TapTap	eb8651e3d5	fix: address PR review — fuzz target fixes, UBSan, CI improvements ... Critical fixes: - Add missing #include <string.h> to 5 fuzz targets (wouldn't compile with GCC14+/Clang16+) - Fix fuzz_metadata_from_buf.c OOB read: guard size >= sizeof(int) + FILE_METADATA_WIRE_SIZE - Add Clang compiler check for ENABLE_FUZZ in CMakeLists.txt (fail fast at configure time) - Add fuzz-build CI job (install clang, build all 6 fuzz targets with ENABLE_FUZZ=ON) Warning fixes: - Add UBSan to sanitizer CI matrix (address + undefined) - Remove tautological test_property_glob_consistency (pure/deterministic function) - Use fixed seed srand(42) instead of srand(time(NULL)) for reproducible property tests - Add valid-header + truncated-instructions delta robustness test (exercises instruction-loop error paths) - Fix lcov --remove to exclude '*/_deps/*' (xxhash coverage pollution) - Add comment explaining FASTSYNC_UNDER_VALGRIND skip in test_file.c - Update .gitignore for build-*/ directories	2026-07-20 14:44:41 +02:00
TapTap	e9ab84b5ea	ci: fix coverage and valgrind jobs, skip fork tests under valgrind ... - Install lcov in coverage job (not in fastsync-ci:v7) - Use lcov 2.x compatible flags (--branch-coverage instead of --rc) - Remove unused xxhash exclude pattern that lcov 2.x rejects - Install valgrind in valgrind job - Skip fork-based file tests under valgrind (pipe timing issues) - Add FASTSYNC_UNDER_VALGRIND env var for test skip detection - Move cleanup before assertions in fork tests to prevent leaks - Add coverage.info to .gitignore	2026-07-20 14:44:41 +02:00
TapTap	7c6e69ad81	ci: install lcov and valgrind in CI jobs ... The fastsync-ci:v7 container does not include lcov or valgrind. Add apt-get install steps to the coverage and valgrind jobs. Also update lcov flags for lcov 2.x compatibility: --rc lcov_branch_coverage=1 -> --branch-coverage	2026-07-20 14:44:41 +02:00
TapTap	8f77395b58	testing: add comprehensive test suite for test-driven development ... Add unit tests for previously untested modules (protocol, data, metadata, file, glob), robustness tests for deserialization of malformed inputs, thread safety stress tests, property-based roundtrip tests, and 6 fuzz targets. Update CI with CTest integration, coverage reporting, and valgrind memory checking. New test files: - test_data.c: Data type lifecycle (5 tests) - test_protocol.c: Protocol I/O roundtrips and error paths (9 tests) - test_metadata.c: Metadata serialization roundtrips (6 tests) - test_file.c: File operations and send/receive (12 tests) - test_glob.c: Glob pattern matching (10 tests) - test_robustness.c: Malformed input handling for chunk/delta/protocol (11 tests) - test_stress.c: MPMC queue stress, backpressure, rapid create/destroy (3 tests) - test_property.c: Compress, delta, chunk, glob roundtrip properties (4 tests) - tests/fuzz/: 6 libFuzzer targets for deserialization functions Extended existing tests: - test_config.c: config_send/config_receive roundtrip via fork+pipe - test_shared_utils.c: mkdir_r, glob_match, delete_extras Infrastructure: - CTest integration in CMakeLists.txt - Coverage support (-DENABLE_COVERAGE=ON) - Fuzz target support (-DENABLE_FUZZ=ON) - CI: coverage, valgrind, address sanitizer jobs - Fixed MPMC stress test race condition (cnd_signal -> cnd_broadcast)	2026-07-20 14:44:35 +02:00
TapTap	c7f34eaf9d	ci: symlink build dir for sanitizer integration tests	2026-07-20 14:22:27 +02:00
TapTap	bd17f50f9b	feat: update AI automation agents, add reviewer agent, fix leaks, enhance CI ... Agents: - cmake-expert: fix stale CMake version (4.1 -> 3.22), add OpenSSL/xxHash deps - integrator: fix stale test.py references to tests/integration/, update CI docs - test-writer: update integration test patterns for modular test structure - reviewer: new comprehensive PR reviewer (code, build, CI, docs, quality) Bug fixes: - delta.c: set instructions[i].type = DELTA_INSTR_LITERAL in deserialize - scanner.c: free ArrayList when directory_scanner_next returns NULL CI: - Add sanitizer job (ASan + UBSan) with LSAN suppressions for pre-existing leaks - Add clang-tidy job with proper warning/error detection - Remove || true masking (fixes now make sanitizer useful) Cleanup: - gitignore build-asan/ - .lsan-suppressions.txt for known CLI config leaks	2026-07-20 14:22:27 +02:00
TapTap	5dfc262cf7	fix: scanner leak, remove TSan (Docker incompatible) ... - Fix ArrayList leak in directory_scanner_next when no files found - Remove TSan from CI matrix (Docker 'unexpected memory mapping') - Keep ASan which now passes clean	2026-07-19 16:22:16 +02:00
TapTap	f6eeb69d77	ci: use find|xargs for clang-format to fix directory handling	2026-07-19 16:09:13 +02:00
TapTap	5ede5c8bec	ci: use fastsync-ci:v7 image with cppcheck and clang-format pre-installed	2026-07-19 16:01:48 +02:00
TapTap	02266710fb	ci: add static analysis, sanitizers, and formatting enforcement ... Add Tier 1 review automation to catch issues before human review: - Add cppcheck and clang-format to CI lint job - Add sanitizer matrix (ASan + TSan) CI job - Enable -Wextra -Wpedantic -Werror in CI build - Add SANITIZER and STRICT_WARNINGS CMake options - Add .clang-format for consistent code style - Update Dockerfile with cppcheck and clang-format - Fix sign-compare and unused-parameter warnings for -Werror	2026-07-19 15:37:18 +02:00
TapTap	b28bac9f41	refactor: split test.py into modular pytest integration tests + benchmark tool ... - tests/integration/common.py: ServerManager (reuses server across tests), run_client, test data generation, verification utilities - tests/integration/test_tcp.py: 14 TCP transport correctness tests - tests/integration/test_ssh.py: 10 SSH transport tests (skip when unavailable) - tests/integration/test_tls.py: 5 TLS encryption tests (new coverage!) - tests/integration/test_features.py: 13 feature tests (incremental, delete, exclude, include, max/min size, bwlimit, dry run, archive, progress) - tests/integration/test_preflight.py: 7 CLI validation/error tests - benchmark/bench.py: standalone benchmark with JSON output, p50/p95, multi-run - Updated Dockerfile with python3-pytest, openssl, openssh-client - Updated CI to use pytest (gitea.tap-tap.win/taptap/fastsync-ci:v6) - Removed old monolithic test.py	2026-07-18 19:19:33 +02:00
TapTap	fed77f6ce0	ci: use v5 Docker image to force runner to pull updated image with libssl-dev	2026-07-18 17:53:08 +02:00
TapTap	e9554c1e69	ci: add integration tests (light mode)	2026-07-18 16:06:22 +02:00
TapTap	ed7f8ee56e	ci: add g++ and libc6-dev, use v4 image (verified locally)	2026-07-18 15:31:41 +02:00
TapTap	8c7ebbfe32	ci: add make to Docker image, use v3 tag	2026-07-18 15:27:35 +02:00
TapTap	cc09bedc07	ci: use v2 image tag to bypass runner cache	2026-07-18 15:20:57 +02:00
TapTap	9130ee4b03	ci: use custom Docker image with build tools pre-installed	2026-07-18 15:15:26 +02:00
TapTap	36da0d6adb	ci: restore apt-get update for package resolution	2026-07-18 14:45:03 +02:00
TapTap	e7087d518b	ci: skip apt-get update for faster installs	2026-07-18 14:43:02 +02:00
TapTap	3ea11b5984	ci: add build + unit tests workflow, lower cmake minimum to 3.22	2026-07-18 14:41:27 +02:00
TapTap	33f70f7de3	add demo action	2026-07-18 14:22:58 +02:00