TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

hard-links: -H/--hard-links preserves inode relationships
CI / lint (pull_request) Successful in 50s
Details
CI / sanitizers (address) (pull_request) Skipped
Details
CI / sanitizers (undefined) (pull_request) Skipped
Details
CI / fuzz-build (pull_request) Skipped
Details
CI / coverage (pull_request) Skipped
Details
CI / valgrind (pull_request) Skipped
Details
CI / build-and-test (pull_request) Successful in 1m19s
Details

Browse Source 
Source files sharing (st_dev,st_ino) are recreated as hard links on the
destination; only the first member's data crosses the wire (siblings ride a
payload-less STATUS_HARDLINK frame). Ordering requires the single-FIFO-writer
receiver + forced sequential scan (documented). link()-failure falls back to a
byte-identical local copy. Rejects -s/--append. PROTOCOL_VERSION 2.11.0->2.12.0.
Review fixes: delete the dead HardLinkRegistry (ordering holds by FIFO writer),
and --existing no longer aborts when the first member is absent but the sibling
exists (leaves the sibling in place).
This commit is contained in:
TapTap
2026-09-08 20:58:56 +02:00
parent cbb09e41ab
commit f891cd0a6a
21 changed files with 792 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_client_cli.c
+48 -2
View File
@@ -768,8 +768,6 @@ static void test_parse_args_delete_timing_without_delete_rejected() {
static void test_parse_args_rejects_unimplemented_options() {
static const char* const options[] = {"--silent",
"--queue-size",
"-H",
"--hard-links",
"-A",
"--acls",
"-X",
@@ -845,6 +843,52 @@ static void test_parse_args_update() {
config_delete(cfg);
}
static void test_parse_args_hard_links() {
Config* cfg = config_create();
char* argv_H[] = {"fastsync", "-H", "/src", "/dst"};
int positional_args[2];
int positional_count = 0;
EXPECT_EQ_INT(parse_args(cfg, 4, argv_H, positional_args, &positional_count), 0);
EXPECT_TRUE(cfg->preserve_hard_links);
config_delete(cfg);
cfg = config_create();
positional_count = 0;
char* argv_long[] = {"fastsync", "--hard-links", "/src", "/dst"};
EXPECT_EQ_INT(parse_args(cfg, 4, argv_long, positional_args, &positional_count), 0);
EXPECT_TRUE(cfg->preserve_hard_links);
config_delete(cfg);
/* --no-hard-links clears the flag. */
cfg = config_create();
positional_count = 0;
char* argv_neg[] = {"fastsync", "--hard-links", "--no-hard-links", "/src", "/dst"};
EXPECT_EQ_INT(parse_args(cfg, 5, argv_neg, positional_args, &positional_count), 0);
EXPECT_FALSE(cfg->preserve_hard_links);
config_delete(cfg);
}
/* -H/--hard-links violates the per-file streaming requirement of -s and the
* payload-bearing tail-resume of --append: both combos are rejected up front. */
static void test_validate_config_hard_links_incompatible_modes() {
Config* cfg = config_create();
char* argv_s[] = {"fastsync", "-H", "-s", "/src", "/dst"};
int positional_args[2];
int positional_count = 0;
EXPECT_EQ_INT(parse_args(cfg, 5, argv_s, positional_args, &positional_count), 0);
EXPECT_TRUE(cfg->preserve_hard_links);
EXPECT_FALSE(validate_config(cfg));
config_delete(cfg);
cfg = config_create();
positional_count = 0;
char* argv_append[] = {"fastsync", "-H", "--append", "/src", "/dst"};
EXPECT_EQ_INT(parse_args(cfg, 5, argv_append, positional_args, &positional_count), 0);
EXPECT_TRUE(cfg->preserve_hard_links);
EXPECT_FALSE(validate_config(cfg));
config_delete(cfg);
}
static void test_parse_args_info_flags() {
Config* cfg = config_create();
char* argv[] = {"fastsync", "--info=copy,skip", "/src", "/dst"};
@@ -2314,6 +2358,8 @@ void test_client_cli() {
test_parse_args_rejects_unimplemented_options();
test_parse_args_quiet();
test_parse_args_human_readable();
test_parse_args_hard_links();
test_validate_config_hard_links_incompatible_modes();
test_parse_args_update();
test_parse_args_info_flags();
test_parse_args_info_verbose_order();