TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address review findings — receive_delta_file STATUS_ERROR on early returns
CI / lint (pull_request) Successful in 7s
Details
CI / sanitizers (address) (pull_request) Successful in 16s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / coverage (pull_request) Successful in 11s
Details
CI / fuzz-build (pull_request) Successful in 12s
Details
CI / valgrind (pull_request) Successful in 12s
Details
CI / build-and-test (pull_request) Successful in 54s
Details

Browse Source
This commit is contained in:
TapTap
2026-07-21 14:32:04 +02:00
parent e62296d92f
commit e34ec3d594
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/file.c
+5 -1
View File
@@ -162,17 +162,21 @@ static void* old_data_from_path(const char* full_path, unsigned long long old_si
static File* receive_delta_file(int fd, const Config* config, const char* check_path, static File* receive_delta_file(int fd, const Config* config, const char* check_path,
void* old_data, unsigned long long old_size) { void* old_data, unsigned long long old_size) {
if (!old_data) if (!old_data) {
send_status(fd, STATUS_ERROR);
return NULL; return NULL;
}
DeltaSignature* sig = delta_signature_create(old_data, old_size, config->delta_block_size); DeltaSignature* sig = delta_signature_create(old_data, old_size, config->delta_block_size);
if (!sig) { if (!sig) {
send_status(fd, STATUS_ERROR);
free(old_data); free(old_data);
return NULL; return NULL;
} }
Data* sig_data = delta_signature_serialize(sig); Data* sig_data = delta_signature_serialize(sig);
if (!sig_data) { if (!sig_data) {
send_status(fd, STATUS_ERROR);
delta_signature_destroy(sig); delta_signature_destroy(sig);
free(old_data); free(old_data);
return NULL; return NULL;