chore(p8h): reconcile ssh old-args docs, secret-file perms docs; fix test cppcheck

2026-09-12 15:33:54 +02:00
parent 81fed86748
commit e1bb2e9233
3 changed files with 12 additions and 6 deletions
@@ -6,10 +6,13 @@
 Client* client_connect_ssh(const char* destination, int port, const char* server_path,
                           bool old_args, const char* rsh_command, bool blocking_io,
                           char* const* remote_options, int remote_option_count);
-/* Build the escaped remote-shell command string (the server program path quoted
- * as one remote-shell word unless --old-args, followed by ` --stdio` and each
+/* Build the escaped remote-shell command string (the server program path always
+ * quoted as one remote-shell word, followed by ` --stdio` and each
 * --remote-option value appended as an individually single-quoted shell word).
- * Every --remote-option value is individually escaped with the '\'' sequence and
+ * `old_args` is accepted for CLI/ABI compatibility but no longer disables
+ * quoting: the path is always escaped so a metacharacter-bearing
+ * --rsync-path can never be interpreted by the remote shell.  Every
+ * --remote-option value is individually escaped with the '\'' sequence and
 * values with empty/control characters are rejected at the CLI parse layer. */
 char* ssh_build_remote_command(const char* server_path, bool old_args, char* const* remote_options,
                               int remote_option_count);