TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve cppcheck warnings in new test files
CI / lint (push) Successful in 8s
Details
CI / lint (pull_request) Successful in 8s
Details
CI / build-and-test (push) Successful in 53s
Details
CI / sanitizers (address) (push) Successful in 14s
Details
CI / coverage (push) Failing after 7s
Details
CI / valgrind (push) Failing after 9s
Details
CI / build-and-test (pull_request) Successful in 53s
Details
CI / sanitizers (address) (pull_request) Successful in 14s
Details
CI / coverage (pull_request) Failing after 7s
Details
CI / valgrind (pull_request) Failing after 10s
Details

Browse Source 
- Remove unused ConsumerCtx struct in test_stress.c
- Add const qualifiers to variables only checked for NULL
  in test_metadata.c, test_protocol.c, test_robustness.c
This commit is contained in:
TapTap
2026-07-19 19:29:31 +02:00
parent c06a065a6a
commit 958e0b6c00
4 changed files with 13 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_robustness.c
+10 -10
View File
@@ -30,7 +30,7 @@ static void test_chunk_deserialize_truncated() {
size_t orig_size = serialized->size;
serialized->size = orig_size / 2;
Chunk* result = chunk_deserialize(serialized, false);
const Chunk* result = chunk_deserialize(serialized, false);
EXPECT_NULL(result);
serialized->size = orig_size;
@@ -45,7 +45,7 @@ static void test_chunk_deserialize_empty() {
EXPECT_NOT_NULL(d);
memcpy(d->data, garbage, sizeof(garbage));
Chunk* result = chunk_deserialize(d, false);
const Chunk* result = chunk_deserialize(d, false);
EXPECT_NULL(result);
data_destroy(d);
@@ -57,7 +57,7 @@ static void test_chunk_deserialize_garbage() {
EXPECT_NOT_NULL(d);
memcpy(d->data, garbage, sizeof(garbage));
Chunk* result = chunk_deserialize(d, false);
const Chunk* result = chunk_deserialize(d, false);
EXPECT_NULL(result);
data_destroy(d);
@@ -77,7 +77,7 @@ static void test_delta_deserialize_truncated() {
EXPECT_NOT_NULL(serialized);
serialized->size = 4;
Delta* result = delta_deserialize(serialized);
const Delta* result = delta_deserialize(serialized);
EXPECT_NULL(result);
data_destroy(serialized);
@@ -91,7 +91,7 @@ static void test_delta_deserialize_empty() {
EXPECT_NOT_NULL(d);
memcpy(d->data, garbage, sizeof(garbage));
Delta* result = delta_deserialize(d);
const Delta* result = delta_deserialize(d);
EXPECT_NULL(result);
data_destroy(d);
@@ -103,7 +103,7 @@ static void test_delta_deserialize_garbage() {
EXPECT_NOT_NULL(d);
memcpy(d->data, garbage, sizeof(garbage));
Delta* result = delta_deserialize(d);
const Delta* result = delta_deserialize(d);
EXPECT_NULL(result);
data_destroy(d);
@@ -119,7 +119,7 @@ static void test_delta_signature_deserialize_truncated() {
EXPECT_NOT_NULL(serialized);
serialized->size = 4;
DeltaSignature* result = delta_signature_deserialize(serialized);
const DeltaSignature* result = delta_signature_deserialize(serialized);
EXPECT_NULL(result);
data_destroy(serialized);
@@ -127,7 +127,7 @@ static void test_delta_signature_deserialize_truncated() {
}
static void test_delta_apply_null() {
void* result = delta_apply(NULL, 0, NULL, 0);
const void* result = delta_apply(NULL, 0, NULL, 0);
EXPECT_NULL(result);
}
@@ -151,7 +151,7 @@ static void test_receive_data_closed_pipe() {
io_set_bwlimit(0);
close(p[1]);
Data* result = receive_data(0);
const Data* result = receive_data(0);
EXPECT_NULL(result);
close(p[0]);
@@ -164,7 +164,7 @@ static void test_receive_str_closed_pipe() {
io_set_bwlimit(0);
close(p[1]);
char* result = receive_str(0);
const char* result = receive_str(0);
EXPECT_NULL(result);
close(p[0]);