From 90ccf297d7c8d7251cf53992f39f6bd9e4c589fd Mon Sep 17 00:00:00 2001 From: TapTap Date: Tue, 8 Sep 2026 22:53:47 +0200 Subject: [PATCH] =?UTF-8?q?style:=20cppcheck=20=E2=80=94=20const-correctne?= =?UTF-8?q?ss=20in=20file=5Fsend=5Fspecial=20and=20test=5Fchunk?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit file_send_special now takes const File*; test_chunk declares the deserialized Chunk* const. cppcheck (--error-exitcode=1) now exits clean; clang-format clean; unit 29/29. --- src/shared/file_send.c | 2 +- src/shared/file_send.h | 2 +- tests/test_chunk.c | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/shared/file_send.c b/src/shared/file_send.c index 18a1f27..8da018a 100644 --- a/src/shared/file_send.c +++ b/src/shared/file_send.c @@ -22,7 +22,7 @@ * frame: the destination path, the metadata frame (whose mode's S_IFMT bits * carry the node kind) and the device rdev major/minor. The receiver validates * the kind and rdev and recreates the node (privilege-gating the mknod). */ -bool file_send_special(File* file, int file_descriptor, bool use_metadata) { +bool file_send_special(const File* file, int file_descriptor, bool use_metadata) { if (!file || !file_wire_path(file)) return false; if (!send_status(file_descriptor, STATUS_SPECIAL)) diff --git a/src/shared/file_send.h b/src/shared/file_send.h index 183394e..b48d33c 100644 --- a/src/shared/file_send.h +++ b/src/shared/file_send.h @@ -6,7 +6,7 @@ /* Client-side file send path. */ -bool file_send_special(File* file, int file_descriptor, bool use_metadata); +bool file_send_special(const File* file, int file_descriptor, bool use_metadata); bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata, int compression_level, bool send_path); bool file_send_single_calls_with_skip(File* file, int file_descriptor, bool use_metadata, diff --git a/tests/test_chunk.c b/tests/test_chunk.c index 3d239cf..b1d6cf6 100644 --- a/tests/test_chunk.c +++ b/tests/test_chunk.c @@ -273,9 +273,8 @@ static void test_chunk_special_rdev_out_of_range_rejected() { EXPECT_NOT_NULL(chunk); Data* serialized = chunk_serialize(chunk, true); EXPECT_NOT_NULL(serialized); - Chunk* deserialized = chunk_deserialize(serialized, true); + const Chunk* deserialized = chunk_deserialize(serialized, true); EXPECT_NULL(deserialized); - data_destroy(serialized); chunk_destroy(chunk); }