TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

perf(protocol): skip string debug escaping when proto debug is off

Browse Source 
output_escape() was called on every send_str/receive_str even when
LOG_DEBUG_PROTO logging was disabled, allocating and scanning the whole
payload for a line that log_debug_message() then discarded.  Add a
log_debug_enabled(flag) gate mirroring log_debug_message()'s own filter and
check it before escaping.  Redacted (secret) strings still log the same
<redacted> marker; no observable log output changes.
This commit is contained in:
TapTap
2026-09-12 16:54:43 +02:00
parent 1ba6372017
commit 87585e9881
4 changed files with 30 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_log.c
+20
View File
@@ -128,6 +128,25 @@ static void test_log_message_formats() {
EXPECT_TRUE(true);
}
/* log_debug_enabled is the lazy-formatting gate for log_debug_message: it must
* be true only at DEBUG level with the requested flag selected, exactly
* mirroring the filter inside log_debug_message itself. */
static void test_log_debug_enabled_matches_gate() {
set_log_level(LOG_LEVEL_WARNING);
set_log_debug_flags(LOG_DEBUG_ALL);
EXPECT_FALSE(log_debug_enabled(LOG_DEBUG_PROTO));
set_log_level(LOG_LEVEL_DEBUG);
set_log_debug_flags(LOG_DEBUG_PROTO);
EXPECT_TRUE(log_debug_enabled(LOG_DEBUG_PROTO));
EXPECT_FALSE(log_debug_enabled(LOG_DEBUG_IO));
set_log_debug_flags(0);
EXPECT_FALSE(log_debug_enabled(LOG_DEBUG_PROTO));
set_log_debug_flags(LOG_DEBUG_ALL);
}
void test_log() {
test_log_message_debug();
test_log_message_info();
@@ -139,4 +158,5 @@ void test_log() {
test_log_filtering();
test_log_stderr_mode_all();
test_log_message_formats();
test_log_debug_enabled_matches_gate();
}