TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address all 12 PR review issues
CI / lint (pull_request) Successful in 9s
Details
CI / sanitizers (address) (pull_request) Successful in 16s
Details
CI / sanitizers (undefined) (pull_request) Successful in 15s
Details
CI / coverage (pull_request) Successful in 12s
Details
CI / fuzz-build (pull_request) Successful in 13s
Details
CI / valgrind (pull_request) Successful in 13s
Details
CI / build-and-test (pull_request) Failing after 54s
Details

Browse Source
This commit is contained in:
TapTap
2026-07-21 15:46:38 +02:00
parent 7adb82f8ac
commit 60ab410a8c
9 changed files with 57 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/config.c
+12 -8
View File
@@ -82,6 +82,8 @@ void config_parse_ssh_dest(Config* config) {
}
void config_delete(Config* config) {
if (config == NULL)
return;
free(config->version);
free(config->send_directory);
free(config->receive_root_directory);
@@ -260,10 +262,6 @@ Config* config_receive(int file_descriptor) {
MAX_PATTERN_COUNT);
goto error;
}
if ((size_t)ec > SIZE_MAX / sizeof(char*)) {
log_message(LOG_LEVEL_ERROR, "Exclude pattern count %d would cause integer overflow", ec);
goto error;
}
config->exclude_count = ec;
if (ec > 0) {
config->exclude_patterns = malloc((size_t)ec * sizeof(char*));
@@ -293,10 +291,6 @@ Config* config_receive(int file_descriptor) {
MAX_PATTERN_COUNT);
goto error;
}
if ((size_t)ic > SIZE_MAX / sizeof(char*)) {
log_message(LOG_LEVEL_ERROR, "Include pattern count %d would cause integer overflow", ic);
goto error;
}
config->include_count = ic;
if (ic > 0) {
config->include_patterns = malloc((size_t)ic * sizeof(char*));
@@ -340,6 +334,16 @@ error:
free(config->version);
free(config->send_directory);
free(config->receive_root_directory);
for (int i = 0; i < config->exclude_count; i++)
free(config->exclude_patterns[i]);
free(config->exclude_patterns);
for (int i = 0; i < config->include_count; i++)
free(config->include_patterns[i]);
free(config->include_patterns);
free(config->tls_cert);
free(config->tls_key);
free(config->tls_ca);
free(config->ssh_destination);
free(config->server_host);
free(config);
return NULL;