TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: satisfy cppcheck const analysis
CI / lint (pull_request) Successful in 31s
Details
CI / sanitizers (address) (pull_request) Successful in 38s
Details
CI / sanitizers (undefined) (pull_request) Successful in 37s
Details
CI / fuzz-build (pull_request) Failing after 14s
Details
CI / coverage (pull_request) Successful in 32s
Details
CI / build-and-test (pull_request) Successful in 1m15s
Details
CI / valgrind (pull_request) Successful in 33s
Details

Browse Source
This commit is contained in:
TapTap
2026-08-15 12:30:52 +02:00
parent 8cca891b9a
commit 3b7f97853c
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/client_send.c
+1 -1
View File
@@ -124,7 +124,7 @@ static void pipeline_cancel(PipelineContextSender* context) {
} }
/* Print dry-run manifest showing files that would be transferred. Returns 0 on success. */ /* Print dry-run manifest showing files that would be transferred. Returns 0 on success. */
static int send_dry_run_manifest(Config* config) { static int send_dry_run_manifest(const Config* config) {
ScannerOptions options = scanner_options_from_config(config, 0); ScannerOptions options = scanner_options_from_config(config, 0);
DirectoryScanner* scanner = DirectoryScanner* scanner =
directory_scanner_create_with_options(config->send_directory, &options); directory_scanner_create_with_options(config->send_directory, &options);
src/client/scanner.c
+3 -3
View File
@@ -252,7 +252,7 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner) {
break; break;
} }
struct dirent* entry = readdir(scanner->current_dir); const struct dirent* entry = readdir(scanner->current_dir);
if (entry == NULL) { if (entry == NULL) {
closedir(scanner->current_dir); closedir(scanner->current_dir);
scanner->current_dir = NULL; scanner->current_dir = NULL;
@@ -454,7 +454,7 @@ ParallelScanner* parallel_scanner_create_with_options(const char* root_directory
parallel_scanner_destroy(ps); parallel_scanner_destroy(ps);
return NULL; return NULL;
} }
struct dirent* entry; const struct dirent* entry;
while ((entry = readdir(dir)) != NULL) { while ((entry = readdir(dir)) != NULL) {
if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0) if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
continue; continue;
@@ -637,7 +637,7 @@ ParallelScanner* parallel_scanner_create_with_options(const char* root_directory
return ps; return ps;
} }
ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata, ParallelScanner* parallel_scanner_create(const char* root_directory, bool use_metadata,
unsigned long long chunk_size, char** exclude_patterns, unsigned long long chunk_size, char** exclude_patterns,
int exclude_count, char** include_patterns, int exclude_count, char** include_patterns,
int include_count, unsigned long long max_size, int include_count, unsigned long long max_size,
src/client/scanner.h
+1 -1
View File
@@ -77,7 +77,7 @@ Chunk* directory_scanner_next(DirectoryScanner* scanner);
bool directory_scanner_failed(const DirectoryScanner* scanner); bool directory_scanner_failed(const DirectoryScanner* scanner);
void directory_scanner_destroy(DirectoryScanner* scanner); void directory_scanner_destroy(DirectoryScanner* scanner);
ParallelScanner* parallel_scanner_create(char* root_directory, bool use_metadata, ParallelScanner* parallel_scanner_create(const char* root_directory, bool use_metadata,
unsigned long long chunk_size, char** exclude_patterns, unsigned long long chunk_size, char** exclude_patterns,
int exclude_count, char** include_patterns, int exclude_count, char** include_patterns,
int include_count, unsigned long long max_size, int include_count, unsigned long long max_size,
tests/test_config.c
+1 -1
View File
@@ -238,7 +238,7 @@ static void test_config_receive_truncated() {
EXPECT_TRUE(send_int(p[1], 1)); EXPECT_TRUE(send_int(p[1], 1));
shutdown(p[1], SHUT_WR); shutdown(p[1], SHUT_WR);
Config* cfg = config_receive(p[0]); const Config* cfg = config_receive(p[0]);
EXPECT_NULL(cfg); EXPECT_NULL(cfg);
close(p[0]); close(p[0]);
close(p[1]); close(p[1]);