Merge fix/quality-cleanup into dev

fixes #260 (dead code, CLI =form/missing-arg diagnostics)

src/shared/utils.c

@@ -1,6 +1,5 @@
 #include "utils.h"
 #include "array_list.h"
-#include "libgen.h"
 #include "log.h"
 #include <dirent.h>
 #include <errno.h>
@@ -83,45 +82,6 @@ static int open_authorized_destination(const char* dest_root) {
   return dirfd;
 }
 
-bool mkdir_r(const char* path) {
-  if (!path || *path == '\0')
-    return false;
-  char* duplicate = str_dup(path);
-  if (!duplicate)
-    return false;
-  int dirfd = open(path[0] == '/' ? "/" : ".", O_RDONLY | O_DIRECTORY | O_CLOEXEC | O_NOFOLLOW);
-  if (dirfd < 0) {
-    free(duplicate);
-    return false;
-  }
-  bool ok = true;
-  char* saveptr = NULL;
-  char* component = strtok_r(duplicate, "/", &saveptr);
-  while (component) {
-    if (strcmp(component, "..") == 0) {
-      ok = false;
-      break;
-    }
-    if (strcmp(component, ".") != 0) {
-      int next = openat(dirfd, component, O_RDONLY | O_DIRECTORY | O_CLOEXEC | O_NOFOLLOW);
-      if (next < 0 && errno == ENOENT) {
-        if (mkdirat(dirfd, component, 0755) == 0 || errno == EEXIST)
-          next = openat(dirfd, component, O_RDONLY | O_DIRECTORY | O_CLOEXEC | O_NOFOLLOW);
-      }
-      if (next < 0) {
-        ok = false;
-        break;
-      }
-      close(dirfd);
-      dirfd = next;
-    }
-    component = strtok_r(NULL, "/", &saveptr);
-  }
-  close(dirfd);
-  free(duplicate);
-  return ok;
-}
-
 char* str_dup(const char* string) {
   if (string == NULL)
     return NULL;

src/shared/utils.h

@@ -5,7 +5,6 @@
 #include <stddef.h>
 #include <stdbool.h>
 
-bool mkdir_r(const char* path);
 char* str_dup(const char* string);
 char* output_escape(const char* string, bool eight_bit_output);
 char* path_cat(const char* path1, const char* path2);