TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reformat codebase and fix const-correctness for CI lint
CI / lint (push) Failing after 16s
Details
CI / build-and-test (push) Has been skipped
Details
CI / sanitizers (address) (push) Has been skipped
Details
CI / sanitizers (thread) (push) Has been skipped
Details
CI / lint (pull_request) Failing after 44s
Details
CI / build-and-test (pull_request) Has been skipped
Details
CI / sanitizers (address) (pull_request) Has been skipped
Details
CI / sanitizers (thread) (pull_request) Has been skipped
Details

Browse Source 
- Reformat all C/H files to match .clang-format (LLVM style)
- Fix 26 cppcheck const-correctness warnings (constParameterPointer,
  constVariablePointer, constVariable)
- Update function declarations in headers to match const parameters
This commit is contained in:
TapTap
2026-07-19 15:57:31 +02:00
parent 02266710fb
commit 23b1d6660c
44 changed files with 1053 additions and 923 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_scanner.c
+34 -28
View File
@@ -6,27 +6,28 @@
#include <sys/stat.h>
#include <unistd.h>
static void create_test_file(const char *path, const char *content) {
static void create_test_file(const char* path, const char* content) {
(void)to_disk(path, content, strlen(content));
}
static void test_scanner_single_file() {
const char *dir = "test_scan_dir_single";
const char *file1 = "test_scan_dir_single/file1.txt";
const char *content1 = "hello scanner";
const char* dir = "test_scan_dir_single";
const char* file1 = "test_scan_dir_single/file1.txt";
const char* content1 = "hello scanner";
mkdir(dir, 0755);
create_test_file(file1, content1);
DirectoryScanner *scanner = directory_scanner_create((char *)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
DirectoryScanner* scanner =
directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
EXPECT_NOT_NULL(scanner);
Chunk *chunk = directory_scanner_next(scanner);
Chunk* chunk = directory_scanner_next(scanner);
EXPECT_NOT_NULL(chunk);
EXPECT_EQ_INT(chunk->element_count, 1);
EXPECT_EQ_STR(chunk->items[0]->path, file1);
Chunk *next = directory_scanner_next(scanner);
const Chunk* next = directory_scanner_next(scanner);
EXPECT_NULL(next);
chunk_destroy(chunk);
@@ -36,35 +37,38 @@ static void test_scanner_single_file() {
}
static void test_scanner_multiple_files() {
const char *dir = "test_scan_dir_multi";
const char *file1 = "test_scan_dir_multi/a.txt";
const char *file2 = "test_scan_dir_multi/b.txt";
const char *content1 = "alpha";
const char *content2 = "beta";
const char* dir = "test_scan_dir_multi";
const char* file1 = "test_scan_dir_multi/a.txt";
const char* file2 = "test_scan_dir_multi/b.txt";
const char* content1 = "alpha";
const char* content2 = "beta";
mkdir(dir, 0755);
create_test_file(file1, content1);
create_test_file(file2, content2);
DirectoryScanner *scanner = directory_scanner_create((char *)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
DirectoryScanner* scanner =
directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
EXPECT_NOT_NULL(scanner);
Chunk *chunk = directory_scanner_next(scanner);
const Chunk* chunk = directory_scanner_next(scanner);
EXPECT_NOT_NULL(chunk);
EXPECT_EQ_INT(chunk->element_count, 2);
int found1 = 0, found2 = 0;
for (int i = 0; i < chunk->element_count; i++) {
if (strcmp(chunk->items[i]->path, file1) == 0) found1 = 1;
if (strcmp(chunk->items[i]->path, file2) == 0) found2 = 1;
if (strcmp(chunk->items[i]->path, file1) == 0)
found1 = 1;
if (strcmp(chunk->items[i]->path, file2) == 0)
found2 = 1;
}
EXPECT_TRUE(found1);
EXPECT_TRUE(found2);
Chunk *next = directory_scanner_next(scanner);
const Chunk* next = directory_scanner_next(scanner);
EXPECT_NULL(next);
chunk_destroy(chunk);
chunk_destroy((void*)chunk);
directory_scanner_destroy(scanner);
unlink(file1);
unlink(file2);
@@ -72,22 +76,23 @@ static void test_scanner_multiple_files() {
}
static void test_scanner_subdirectory() {
const char *root = "test_scan_sub";
const char *sub = "test_scan_sub/sub";
const char *root_file = "test_scan_sub/root.txt";
const char *sub_file = "test_scan_sub/sub/sub_file.txt";
const char *content = "nested content";
const char* root = "test_scan_sub";
const char* sub = "test_scan_sub/sub";
const char* root_file = "test_scan_sub/root.txt";
const char* sub_file = "test_scan_sub/sub/sub_file.txt";
const char* content = "nested content";
mkdir(root, 0755);
mkdir(sub, 0755);
create_test_file(root_file, content);
create_test_file(sub_file, content);
DirectoryScanner *scanner = directory_scanner_create((char *)root, false, 0, NULL, 0, NULL, 0, 0, 0);
DirectoryScanner* scanner =
directory_scanner_create((char*)root, false, 0, NULL, 0, NULL, 0, 0, 0);
EXPECT_NOT_NULL(scanner);
int total_files = 0;
Chunk *chunk;
Chunk* chunk;
while ((chunk = directory_scanner_next(scanner)) != NULL) {
total_files += chunk->element_count;
chunk_destroy(chunk);
@@ -102,14 +107,15 @@ static void test_scanner_subdirectory() {
}
static void test_scanner_empty_directory() {
const char *dir = "test_scan_empty";
const char* dir = "test_scan_empty";
mkdir(dir, 0755);
DirectoryScanner *scanner = directory_scanner_create((char *)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
DirectoryScanner* scanner =
directory_scanner_create((char*)dir, false, 0, NULL, 0, NULL, 0, 0, 0);
EXPECT_NOT_NULL(scanner);
Chunk *chunk = directory_scanner_next(scanner);
const Chunk* chunk = directory_scanner_next(scanner);
EXPECT_NULL(chunk);
directory_scanner_destroy(scanner);