fix: reformat codebase and fix const-correctness for CI lint
CI / lint (push) Failing after 16s
CI / build-and-test (push) Has been skipped
CI / sanitizers (address) (push) Has been skipped
CI / sanitizers (thread) (push) Has been skipped
CI / lint (pull_request) Failing after 44s
CI / build-and-test (pull_request) Has been skipped
CI / sanitizers (address) (pull_request) Has been skipped
CI / sanitizers (thread) (pull_request) Has been skipped

- Reformat all C/H files to match .clang-format (LLVM style)
- Fix 26 cppcheck const-correctness warnings (constParameterPointer,
  constVariablePointer, constVariable)
- Update function declarations in headers to match const parameters
This commit is contained in:
2026-07-19 15:57:31 +02:00
parent 02266710fb
commit 23b1d6660c
44 changed files with 1053 additions and 923 deletions
+89 -58
View File
@@ -19,15 +19,15 @@
#include "protocol.h"
#include "utils.h"
File *file_create(const char *path) {
File *file = (File *)malloc(sizeof(File));
File* file_create(const char* path) {
File* file = (File*)malloc(sizeof(File));
if (file == NULL) {
perror("ERROR: Could not allocate memory for file struct");
return NULL;
}
int path_len = strlen(path);
file->path = (char *)malloc(path_len + 1);
file->path = (char*)malloc(path_len + 1);
if (file->path == NULL) {
free(file);
return NULL;
@@ -44,10 +44,10 @@ File *file_create(const char *path) {
return file;
}
void file_destroy(void *item) {
void file_destroy(void* item) {
if (item == NULL)
return;
File *file = (File *)item;
File* file = (File*)item;
data_destroy(file->data);
file->data = NULL;
file_metadata_destroy(file->metadata);
@@ -57,8 +57,8 @@ void file_destroy(void *item) {
free(file);
}
FileMetadata *file_metadata_create(struct stat *stats) {
FileMetadata *m = malloc(sizeof(FileMetadata));
FileMetadata* file_metadata_create(const struct stat* stats) {
FileMetadata* m = malloc(sizeof(FileMetadata));
if (m == NULL) {
perror("ERROR: Could not allocate memory for file metadata");
return NULL;
@@ -75,12 +75,13 @@ FileMetadata *file_metadata_create(struct stat *stats) {
return m;
}
void file_metadata_destroy(void *metadata) {
void file_metadata_destroy(void* metadata) {
free(metadata);
}
bool file_load_data(File *file) {
if (file == NULL) return false;
bool file_load_data(File* file) {
if (file == NULL)
return false;
if (file->data->data == NULL) {
file->data->data = malloc(file->data->size);
if (file->data->data == NULL) {
@@ -96,9 +97,10 @@ bool file_load_data(File *file) {
return true;
}
bool file_send_single_calls(File *file, int file_descriptor, bool use_metadata, int compression_level, bool send_path) {
Data *data_to_send = file->data;
Data *compressed_data = NULL;
bool file_send_single_calls(File* file, int file_descriptor, bool use_metadata,
int compression_level, bool send_path) {
Data* data_to_send = file->data;
Data* compressed_data = NULL;
if (compression_level > 0) {
compressed_data = data_compress(file->data, compression_level);
if (compressed_data == NULL) {
@@ -123,18 +125,24 @@ bool file_send_single_calls(File *file, int file_descriptor, bool use_metadata,
return true;
}
bool file_save_to_disk(const char *root_directory, File *file) {
char *disk_path = path_cat((char *)root_directory, file->path);
if (disk_path == NULL) return false;
bool file_save_to_disk(const char* root_directory, File* file) {
char* disk_path = path_cat((char*)root_directory, file->path);
if (disk_path == NULL)
return false;
bool ok = to_disk(disk_path, file->data->data, file->data->size);
if (ok) file_restore_metadata(disk_path, file->metadata);
if (ok)
file_restore_metadata(disk_path, file->metadata);
free(disk_path);
return ok;
}
File *receive_incremental_check(int fd, Config *config, bool *skipped) { *skipped = false;
char *check_path = receive_str(fd);
if (check_path == NULL) { send_status(fd, STATUS_ERROR); return NULL; }
File* receive_incremental_check(int fd, Config* config, bool* skipped) {
*skipped = false;
char* check_path = receive_str(fd);
if (check_path == NULL) {
send_status(fd, STATUS_ERROR);
return NULL;
}
unsigned long long check_size;
long long check_mtime;
@@ -145,36 +153,48 @@ File *receive_incremental_check(int fd, Config *config, bool *skipped) { *skipp
return NULL;
}
char *full_path = path_cat(config->receive_root_directory, check_path);
char* full_path = path_cat(config->receive_root_directory, check_path);
struct stat st;
bool match = false;
if (full_path && stat(full_path, &st) == 0 &&
(unsigned long long)st.st_size == check_size &&
if (full_path && stat(full_path, &st) == 0 && (unsigned long long)st.st_size == check_size &&
(long long)st.st_mtime == check_mtime) {
match = true;
}
free(full_path);
if (match) {
if (!send_status(fd, STATUS_OK)) { free(check_path); return NULL; }
if (!send_status(fd, STATUS_OK)) {
free(check_path);
return NULL;
}
free(check_path);
*skipped = true;
return NULL;
}
if (!send_status(fd, STATUS_NEXT)) { free(check_path); return NULL; }
if (!send_status(fd, STATUS_NEXT)) {
free(check_path);
return NULL;
}
File *file = file_create(check_path);
File* file = file_create(check_path);
free(check_path);
if (file == NULL) { send_status(fd, STATUS_ERROR); return NULL; }
if (file == NULL) {
send_status(fd, STATUS_ERROR);
return NULL;
}
if (config->use_metadata) {
int meta_ok = 1;
file->metadata = metadata_receive(fd, &meta_ok);
if (!meta_ok) { file_destroy(file); send_status(fd, STATUS_ERROR); return NULL; }
if (!meta_ok) {
file_destroy(file);
send_status(fd, STATUS_ERROR);
return NULL;
}
}
Data *file_data = receive_data(fd);
Data* file_data = receive_data(fd);
if (file_data == NULL) {
file_destroy(file);
send_status(fd, STATUS_ERROR);
@@ -182,9 +202,13 @@ File *receive_incremental_check(int fd, Config *config, bool *skipped) { *skipp
}
if (config->use_compression) {
Data *uncompressed = data_decompress(file_data);
Data* uncompressed = data_decompress(file_data);
data_destroy(file_data);
if (uncompressed == NULL) { file_destroy(file); send_status(fd, STATUS_ERROR); return NULL; }
if (uncompressed == NULL) {
file_destroy(file);
send_status(fd, STATUS_ERROR);
return NULL;
}
file_data = uncompressed;
}
@@ -193,15 +217,15 @@ File *receive_incremental_check(int fd, Config *config, bool *skipped) { *skipp
return file;
}
bool to_disk(const char *path, const void *data, unsigned long long data_size) {
char *directory = str_dup(path);
char *dir_to_free = directory;
bool to_disk(const char* path, const void* data, unsigned long long data_size) {
char* directory = str_dup(path);
char* dir_to_free = directory;
directory = dirname(directory);
if (!mkdir_r(directory)) {
free(dir_to_free);
return false;
}
FILE *file_pointer = fopen(path, "wb");
FILE* file_pointer = fopen(path, "wb");
if (file_pointer == NULL) {
perror("Could not open File");
free(dir_to_free);
@@ -218,9 +242,11 @@ bool to_disk(const char *path, const void *data, unsigned long long data_size) {
return true;
}
bool file_send_sendfile(File *file, int file_descriptor, bool use_metadata, bool send_path) {
if (send_path && !send_str(file_descriptor, file->path)) return false;
if (use_metadata && !metadata_send(file_descriptor, file->metadata)) return false;
bool file_send_sendfile(File* file, int file_descriptor, bool use_metadata, bool send_path) {
if (send_path && !send_str(file_descriptor, file->path))
return false;
if (use_metadata && !metadata_send(file_descriptor, file->metadata))
return false;
int fd = open(file->path, O_RDONLY);
if (fd == -1) {
@@ -248,24 +274,29 @@ bool file_send_sendfile(File *file, int file_descriptor, bool use_metadata, bool
return true;
}
File *file_receive(Config *config, int file_descriptor) {
char *path = receive_str(file_descriptor);
if (path == NULL) return NULL;
File *file = file_create(path);
File* file_receive(const Config* config, int file_descriptor) {
char* path = receive_str(file_descriptor);
if (path == NULL)
return NULL;
File* file = file_create(path);
free(path);
if (file == NULL) return NULL;
if (file == NULL)
return NULL;
if (config->use_metadata) {
int meta_ok = 1;
file->metadata = metadata_receive(file_descriptor, &meta_ok);
if (!meta_ok) { file_destroy(file); return NULL; }
if (!meta_ok) {
file_destroy(file);
return NULL;
}
}
Data *file_data = receive_data(file_descriptor);
Data* file_data = receive_data(file_descriptor);
if (file_data == NULL) {
file_destroy(file);
return NULL;
}
if (config->use_compression) {
Data *file_data_uncompressed = data_decompress(file_data);
Data* file_data_uncompressed = data_decompress(file_data);
data_destroy(file_data);
if (file_data_uncompressed == NULL) {
file_destroy(file);
@@ -278,14 +309,13 @@ File *file_receive(Config *config, int file_descriptor) {
return file;
}
size_t file_content_to_buffer(File *file) {
FILE *file_pointer = fopen(file->path, "rb");
size_t file_content_to_buffer(File* file) {
FILE* file_pointer = fopen(file->path, "rb");
if (file_pointer == NULL) {
perror("Could not open the file!");
return 0;
}
size_t bytes_read =
fread(file->data->data, 1, file->data->size, file_pointer);
size_t bytes_read = fread(file->data->data, 1, file->data->size, file_pointer);
if (bytes_read != (size_t)file->data->size) {
fclose(file_pointer);
perror("Read unexpected number of bytes from File!");
@@ -295,21 +325,22 @@ size_t file_content_to_buffer(File *file) {
return bytes_read;
}
int receive_manifest(int fd, Config *config, int *next_status) {
int receive_manifest(int fd, const Config* config, int* next_status) {
int count;
if (!receive_int(fd, &count)) return -1;
ArrayList *manifest = array_list_create(free);
if (!receive_int(fd, &count))
return -1;
ArrayList* manifest = array_list_create(free);
if (manifest) {
for (int i = 0; i < count; i++) {
char *s = receive_str(fd);
if (s) array_list_add(manifest, s);
char* s = receive_str(fd);
if (s)
array_list_add(manifest, s);
}
fprintf(stderr, "Deleting files not in manifest...\n");
delete_extras(config->receive_root_directory, manifest);
array_list_delete(manifest);
}
if (!receive_status(fd, next_status)) return -1;
if (!receive_status(fd, next_status))
return -1;
return 0;
}