TapTap/FastSync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: fix coverage and valgrind jobs, skip fork tests under valgrind

Browse Source 
- Install lcov in coverage job (not in fastsync-ci:v7)
- Use lcov 2.x compatible flags (--branch-coverage instead of --rc)
- Remove unused xxhash exclude pattern that lcov 2.x rejects
- Install valgrind in valgrind job
- Skip fork-based file tests under valgrind (pipe timing issues)
- Add FASTSYNC_UNDER_VALGRIND env var for test skip detection
- Move cleanup before assertions in fork tests to prevent leaks
- Add coverage.info to .gitignore
This commit is contained in:
TapTap
2026-07-19 20:16:48 +02:00
parent 68603d1395
commit 20cfc5f438
3 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.gitea/workflows/ci.yaml
+4 -2
View File
@@ -79,7 +79,7 @@ jobs:
- name: Coverage Report - name: Coverage Report
run: | run: |
lcov --capture --directory build --output-file coverage.info --branch-coverage lcov --capture --directory build --output-file coverage.info --branch-coverage
lcov --remove coverage.info '/usr/*' '*/tests/*' '*/xxhash/*' --output-file coverage.info --branch-coverage lcov --remove coverage.info '/usr/*' '*/tests/*' --output-file coverage.info --branch-coverage --ignore-errors unused
lcov --list coverage.info lcov --list coverage.info
valgrind: valgrind:
@@ -100,4 +100,6 @@ jobs:
run: cmake --build build -j$(nproc) run: cmake --build build -j$(nproc)
- name: Valgrind Memcheck - name: Valgrind Memcheck
run: valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./build/tests run: valgrind --leak-check=full --show-leak-kinds=definite --error-exitcode=1 ./build/tests
env:
FASTSYNC_UNDER_VALGRIND: "1"
.gitignore
+1
View File
@@ -3,3 +3,4 @@ data_copied
test_data/ test_data/
__pycache__/ __pycache__/
build-asan build-asan
coverage.info
tests/test_file.c
+11 -8
View File
@@ -4,6 +4,7 @@
#include "utils.h" #include "utils.h"
#include "protocol.h" #include "protocol.h"
#include "test_utils.h" #include "test_utils.h"
#include <stdlib.h>
#include <string.h> #include <string.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/wait.h> #include <sys/wait.h>
@@ -187,14 +188,14 @@ static void test_file_send_receive() {
bool sent = file_send_single_calls(file, p[1], false, 0, true); bool sent = file_send_single_calls(file, p[1], false, 0, true);
close(p[1]); close(p[1]);
EXPECT_TRUE(sent);
int status; int status;
waitpid(pid, &status, 0); waitpid(pid, &status, 0);
EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
file_destroy(file); file_destroy(file);
config_delete(cfg); config_delete(cfg);
EXPECT_TRUE(sent);
EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
} }
} }
@@ -234,13 +235,13 @@ static void test_file_send_no_path() {
bool sent = file_send_single_calls(file, p[1], false, 0, false); bool sent = file_send_single_calls(file, p[1], false, 0, false);
close(p[1]); close(p[1]);
EXPECT_TRUE(sent);
int status; int status;
waitpid(pid, &status, 0); waitpid(pid, &status, 0);
EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
file_destroy(file); file_destroy(file);
EXPECT_TRUE(sent);
EXPECT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) == 0);
} }
} }
@@ -270,7 +271,9 @@ void test_file() {
test_to_disk_basic(); test_to_disk_basic();
test_to_disk_creates_dirs(); test_to_disk_creates_dirs();
test_file_content_to_buffer(); test_file_content_to_buffer();
test_file_send_receive(); if (!getenv("FASTSYNC_UNDER_VALGRIND")) {
test_file_send_no_path(); test_file_send_receive();
test_file_send_no_path();
}
test_file_metadata_create(); test_file_metadata_create();
} }